header not included but used in vl.c

2019-10-01 Thread Toe Dev
Hello, does it have a reason why the file vl.c lacks reference #include "qemu/module.h" ? but still uses the defines include their(for example the enum value: MODULE_INIT_OPTS)? I'm using eclipse so I was notified by the IDE immediately. Thanks for yours help :)

header not included but used in vl.c

2019-10-01 Thread Toe Dev
Hello, does it have a reason why the file vl.c lacks reference #include "qemu/module.h" ? but still uses the defines include their(for example the enum value: MODULE_INIT_OPTS)? I'm using eclipse so I was notified by the IDE immediately. Thanks for yours help :)

[Qemu-devel] Greetings qemu folks

2019-09-07 Thread Toe Dev
I am new in QEMU developing and I have general questions about QEMU source code as I could not find any guidelines about it. 1) I have no success running qemu in nographic mode. The internet says using chardev driver to redirect kernel output to host OS... what is the right way to do that?

[Qemu-devel] Subject: Re: [PATCH] hw/block/nvme

2019-09-10 Thread Toe Dev
Hey, While reviewing I noticed maybe we need to update the spec revision. In: nvme_class_init(...) current code pc->revision=2 change to: pc->revision=3 However not really important I think.. Just for consistency. When I done reviewing, should it be patched too, How?

cscope redundant chars

2020-04-14 Thread Toe Dev
add cscope phony(ctags have one) and remove redundancy diff --git a/Makefile b/Makefile index 84ef881600..9cf62532f9 100644 --- a/Makefile +++ b/Makefile @@ -1005,16 +1005,18 @@ ctags: rm -f tags find "$(SRC_PATH)" -name '*.[hc]' -exec ctags --append {} + +.PHONY: cscope + +cscope