frowned upon to have empty descriptions, some rationale
> would be helpful. For instance, you remove a length check from the send
> string, why did you do that?
>
> Any why is this being added? What's it supporting?
>
> -corey
>
> On Wed, Mar 22, 2023 at 05:55:09PM +0
:
- Expanded commit descriptions
- Added the ADM1266 device model that uses new functions
Titus Rwantare (7):
hw/i2c: pmbus add support for block receive
hw/i2c: pmbus: add vout mode bitfields
hw/i2c: pmbus: add fan support
hw/i2c: pmbus: block uninitialised string reads
hw/i2c
The ADM1266 can have string fields written by the driver, so
it's worth specifically testing.
Reviewed-by: Hao Wu
Signed-off-by: Titus Rwantare
---
tests/qtest/adm1266-test.c | 123 +
tests/qtest/meson.build| 1 +
2 files changed, 124 inser
The ADM1266 is a cascadable super sequencer with margin control and
fault recording.
This commit adds basic support for its PMBus commands and models
the identification registers that can be modified in a firmware
update.
Reviewed-by: Hao Wu
Signed-off-by: Titus Rwantare
---
hw/arm
Devices models calling pmbus_send_string can't be relied upon to
send a non-zero pointer. This logs an error and doesn't segfault.
Reviewed-by: Patrick Venture
Signed-off-by: Titus Rwantare
---
hw/i2c/pmbus_device.c | 7 +++
1 file changed, 7 insertions(+)
diff --gi
PMBus devices may integrate fans whose operation is configurable
over PMBus. This commit allows the driver to read and write the
fan control registers but does not model the operation of fans.
Reviewed-by: Stephen Longfield
Signed-off-by: Titus Rwantare
---
hw/i2c/pmbus_device.c | 176
VCAP is a register for devices with energy storage capacitors.
Reviewed-by: Benjamin Streb
Signed-off-by: Titus Rwantare
---
hw/i2c/pmbus_device.c | 8
include/hw/i2c/pmbus_device.h | 1 +
2 files changed, 9 insertions(+)
diff --git a/hw/i2c/pmbus_device.c b/hw/i2c
: Titus Rwantare
---
hw/i2c/pmbus_device.c | 30 +-
include/hw/i2c/pmbus_device.h | 7 +++
2 files changed, 36 insertions(+), 1 deletion(-)
diff --git a/hw/i2c/pmbus_device.c b/hw/i2c/pmbus_device.c
index c3d6046784..02647769cd 100644
--- a/hw/i2c
scale the voltage readings.
Reviewed-by: Hao Wu
Signed-off-by: Titus Rwantare
---
include/hw/i2c/pmbus_device.h | 8
1 file changed, 8 insertions(+)
diff --git a/include/hw/i2c/pmbus_device.h b/include/hw/i2c/pmbus_device.h
index 7dc00cc4d9..2e95164aa1 100644
--- a/include/hw/i2c
tried to read from all pages\n",
>__func__);
> -pmbus_cml_error(pmdev);
> } else if (pmdev->page > pmdev->num_pages - 1) {
> qemu_log_mask(LOG_GUEST_ERROR,
>"%s: page %d is out of range\n",
> --
> 2.25.1
>
Please also update the stale comment just above, since this is now
specified behaviour.
Reviewed-by: Titus Rwantare
RRAY(fan_pwm2rpm, MAX31785State,
> +MAX31785_TOTAL_NUM_PAGES),
> + VMSTATE_UINT64(mfr_location, MAX31785State),
> +VMSTATE_UINT64(mfr_date, MAX31785State),
> +VMSTATE_UINT64(mfr_serial, MAX31785State),
> +VMSTATE_END_OF_LIST()
> +}
> +};
> +
There's missing indentation here for example.
Thanks,
Titus Rwantare
You can take them through the aspeed branch.
Thanks.
-Titus
On Mon, 27 Jun 2022 at 09:33, Cédric Le Goater wrote:
>
> Hello Titus,
>
> On 6/27/22 17:46, Jae Hyun Yoo wrote:
> > Hello,
> >
> > I'm sending a series to add Qualcomm BMC machines that are equipped with
> > Aspeed AST2600 SoC. Also,
On Tue, 28 Jun 2022 at 20:36, Peter Delevoryas
wrote:
>
> Signed-off-by: Peter Delevoryas
> ---
> --- a/hw/i2c/pmbus_device.c
> +++ b/hw/i2c/pmbus_device.c
> @@ -984,6 +984,11 @@ static uint8_t pmbus_receive_byte(SMBusDevice *smd)
> }
> break;
>
> +case PMBUS_IC_DEVICE_ID:
On Tue, 28 Jun 2022 at 20:36, Peter Delevoryas
wrote:
>
> When a pmbus device switches pages, it should clears its output buffer so
> that the next transaction doesn't emit data from the previous page.
>
> Fixes: 3746d5c15e70570b ("hw/i2c: add support for PMBus”)
> Signed-off-by: Peter Delevoryas
On Wed, 29 Jun 2022 at 23:30, Cédric Le Goater wrote:
>
> On 6/30/22 06:51, Peter Delevoryas wrote:
> > From: Peter Delevoryas
> >
> > This adds the ISL69259, using all the same functionality as the existing
> > ISL69260 but overriding the IC_DEVICE_ID.
> >
> > Signed-off-by: Peter Delevoryas
>
On Wed, 29 Jun 2022 at 21:52, Peter Delevoryas wrote:
>
> From: Peter Delevoryas
>
> This adds the ISL69259, using all the same functionality as the existing
> ISL69260 but overriding the IC_DEVICE_ID.
>
> Signed-off-by: Peter Delevoryas
> ---
> hw/sensor/isl_pmbus_vr.c | 28 +++
and is issued.
> + */
> +void pmbus_idle(PMBusDevice *pmdev);
> +
> extern const VMStateDescription vmstate_pmbus_device;
>
> #define VMSTATE_PMBUS_DEVICE(_field, _state) { \
> --
> 2.37.0
>
Reviewed-by: Titus Rwantare
28000 "raa228000"
> #define TYPE_RAA229004 "raa229004"
> +#define ISL_MAX_IC_DEVICE_ID_LEN 16
>
> struct ISLState {
> PMBusDevice parent;
> +
> +uint8_t ic_device_id[ISL_MAX_IC_DEVICE_ID_LEN];
> +uint8_t ic_device_id_len;
> };
>
> OBJECT_DECLARE_SIMPLE_TYPE(ISLState, ISL69260)
> --
> 2.37.0
>
Reviewed-by: Titus Rwantare
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Titus Rwantare
---
hw/i2c/core.c | 8 +---
hw/i2c/trace-events | 2 +-
2 files changed, 6 insertions(+), 4 deletions(-)
diff --git a/hw/i2c/core.c b/hw/i2c/core.c
index bed594fe59..896da359f5 100644
--- a/hw/i2c/core.c
+++ b/hw/i2c
Signed-off-by: Titus Rwantare
---
hw/arm/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/arm/Kconfig b/hw/arm/Kconfig
index b5aed4aff5..548c10d7fc 100644
--- a/hw/arm/Kconfig
+++ b/hw/arm/Kconfig
@@ -406,6 +406,7 @@ config XLNX_VERSAL
config NPCM7XX
bool
+imply
The PCA6416 is an i2c device with 16 GPIO pins, the PCA9538 has 8 pins.
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Hao Wu
Signed-off-by: Titus Rwantare
---
hw/gpio/Kconfig | 5 +
hw/gpio/meson.build | 1 +
hw/gpio/pca_i2c_gpio.c | 392
This device has the same register layout as the pca9538, but 4 fewer
gpio pins. This commit lowers the number of pins initialised, and reuses
the pca9538 logic.
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Hao Wu
Signed-off-by: Titus Rwantare
---
hw/gpio/pca_i2c_gpio.c | 18
unit tests use asymmetric 16-bit test values
- add patch to imply I2C devices on NPCM7xx boards
Since v1:
- addressed comments
- fixed typos in commit messages
Titus Rwantare (5):
bitops.h: add deposit16 function
hw/gpio: add PCA953x i2c GPIO expanders
hw/gpio: add PCA9536 i2c gpio expand
Makes it more explicit that 16 bit values are being used
Signed-off-by: Titus Rwantare
---
include/qemu/bitops.h | 26 ++
1 file changed, 26 insertions(+)
diff --git a/include/qemu/bitops.h b/include/qemu/bitops.h
index 03213ce952..887b8f8ce8 100644
--- a/include/qemu
Reviewed-by: Hao Wu
Signed-off-by: Titus Rwantare
---
include/hw/i2c/pmbus_device.h | 8
1 file changed, 8 insertions(+)
diff --git a/include/hw/i2c/pmbus_device.h b/include/hw/i2c/pmbus_device.h
index 7dc00cc4d9..2e95164aa1 100644
--- a/include/hw/i2c/pmbus_device.h
+++ b/include/hw
, whose bits determine the
formatting of several read commands in PMBus
Fixes:
- String read now handles now logs an error when passed an empty string
This series is in preparation for some additional sensors that exercise
this functionality that will be incoming shortly.
Thanks
Titus Rwantare
VCAP is a register for devices with energy storage capacitors.
Reviewed-by: Benjamin Streb
Signed-off-by: Titus Rwantare
---
hw/i2c/pmbus_device.c | 8
include/hw/i2c/pmbus_device.h | 1 +
2 files changed, 9 insertions(+)
diff --git a/hw/i2c/pmbus_device.c b/hw/i2c
Reviewed-by: Stephen Longfield
Signed-off-by: Titus Rwantare
---
hw/i2c/pmbus_device.c | 176 ++
include/hw/i2c/pmbus_device.h | 1 +
2 files changed, 177 insertions(+)
diff --git a/hw/i2c/pmbus_device.c b/hw/i2c/pmbus_device.c
index 02647769cd
Devices models calling pmbus_send_string can't be relied upon to
send a non-zero pointer. This logs an error and doesn't segfault.
Reviewed-by: Patrick Venture
Signed-off-by: Titus Rwantare
---
hw/i2c/pmbus_device.c | 7 +++
1 file changed, 7 insertions(+)
diff --gi
Reviewed-by: Hao Wu
Signed-off-by: Titus Rwantare
---
hw/i2c/pmbus_device.c | 30 +-
include/hw/i2c/pmbus_device.h | 7 +++
2 files changed, 36 insertions(+), 1 deletion(-)
diff --git a/hw/i2c/pmbus_device.c b/hw/i2c/pmbus_device.c
index c3d6046784
Signed-off-by: Titus Rwantare
---
hw/i2c/pmbus_device.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/hw/i2c/pmbus_device.c b/hw/i2c/pmbus_device.c
index 93c746bab3..6eeb0731d7 100644
--- a/hw/i2c/pmbus_device.c
+++ b/hw/i2c/pmbus_device.c
@@ -307,6 +307,11 @@ static uint8_t
- add the VOUT_MIN and STATUS_MFR registers
Signed-off-by: Titus Rwantare
---
hw/i2c/pmbus_device.c | 24
include/hw/i2c/pmbus_device.h | 3 +++
2 files changed, 27 insertions(+)
diff --git a/hw/i2c/pmbus_device.c b/hw/i2c/pmbus_device.c
index 24f8f522d9
Signed-off-by: Titus Rwantare
---
MAINTAINERS | 10 ++
hw/i2c/pmbus_device.c | 18 +-
2 files changed, 19 insertions(+), 9 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index fa8adc2618..3601984b5d 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -3135,6
From: Shengtan Mao
Signed-off-by: Shengtan Mao
Reviewed-by: Titus Rwantare
---
hw/i2c/pmbus_device.c | 18 ++
include/hw/i2c/pmbus_device.h | 20 +++-
2 files changed, 37 insertions(+), 1 deletion(-)
diff --git a/hw/i2c/pmbus_device.c b/hw/i2c
Signed-off-by: Titus Rwantare
---
hw/i2c/pmbus_device.c | 41 -
1 file changed, 40 insertions(+), 1 deletion(-)
diff --git a/hw/i2c/pmbus_device.c b/hw/i2c/pmbus_device.c
index 07a45c99f9..93c746bab3 100644
--- a/hw/i2c/pmbus_device.c
+++ b/hw/i2c
Signed-off-by: Titus Rwantare
Reviewed-by: Hao Wu
---
hw/sensor/isl_pmbus.c | 50 ++
include/hw/sensor/isl_pmbus.h | 1 +
tests/qtest/isl_pmbus-test.c | 78 +--
3 files changed, 126 insertions(+), 3 deletions(-)
diff --git a/hw
Signed-off-by: Titus Rwantare
Reviewed-by: Hao Wu
---
MAINTAINERS | 3 +
hw/arm/Kconfig| 1 +
hw/sensor/Kconfig | 5 +
hw/sensor/isl_pmbus.c | 210 ++
hw/sensor/meson.build | 1 +
include/hw/sensor/isl_pmbus.h
The Renesas RAA229004 is a PMBus Multiphase Voltage Regulator
Signed-off-by: Titus Rwantare
Reviewed-by: Hao Wu
---
hw/sensor/isl_pmbus.c | 18 ++
include/hw/sensor/isl_pmbus.h | 1 +
tests/qtest/isl_pmbus-test.c | 8
3 files changed, 27 insertions(+)
diff
[.ch] adding _vr for voltage regulators
Shengtan Mao (1):
hw/i2c: Added linear mode translation for pmbus devices
Titus Rwantare (8):
hw/i2c: pmbus: add registers
hw/i2c: pmbus: guard against out of range accesses
hw/i2c: pmbus: add PEC unsupported warning
hw/i2c: pmbus: refactor uint
Signed-off-by: Titus Rwantare
---
MAINTAINERS | 6 +-
hw/arm/Kconfig| 2 +-
hw/sensor/Kconfig | 2 +-
hw/sensor/{isl_pmbus.c => isl_pmbus_vr.c} | 77 ++---
hw/sensor/meson.bu
The rename is from feedback in v1 by Peter. I did this in a separate
patch as it's easier to merge, compared to editing the 4 commits
affected by this.
Titus
On Tue, 1 Mar 2022 at 16:43, Corey Minyard wrote:
>
> On Tue, Mar 01, 2022 at 04:23:07PM -0800, Titus Rwantare wrote:
> &
- add the VOUT_MIN and STATUS_MFR registers
Signed-off-by: Titus Rwantare
---
hw/i2c/pmbus_device.c | 24
include/hw/i2c/pmbus_device.h | 3 +++
2 files changed, 27 insertions(+)
diff --git a/hw/i2c/pmbus_device.c b/hw/i2c/pmbus_device.c
index 24f8f522d9
From: Shengtan Mao
Signed-off-by: Shengtan Mao
Reviewed-by: Titus Rwantare
---
hw/i2c/pmbus_device.c | 18 ++
include/hw/i2c/pmbus_device.h | 20 +++-
2 files changed, 37 insertions(+), 1 deletion(-)
diff --git a/hw/i2c/pmbus_device.c b/hw/i2c
The Renesas RAA229004 is a PMBus Multiphase Voltage Regulator
Signed-off-by: Titus Rwantare
Reviewed-by: Hao Wu
---
hw/sensor/isl_pmbus_vr.c | 18 ++
include/hw/sensor/isl_pmbus_vr.h | 1 +
tests/qtest/isl_pmbus_vr-test.c | 8
3 files changed, 27 insertions
Signed-off-by: Titus Rwantare
---
hw/i2c/pmbus_device.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/hw/i2c/pmbus_device.c b/hw/i2c/pmbus_device.c
index 93c746bab3..6eeb0731d7 100644
--- a/hw/i2c/pmbus_device.c
+++ b/hw/i2c/pmbus_device.c
@@ -307,6 +307,11 @@ static uint8_t
This change cleans up the inputs to pmbus_receive uint, the length of
received data is contained in PMBusDevice state and doesn't need to be
passed around.
Signed-off-by: Titus Rwantare
---
hw/i2c/pmbus_device.c | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
Signed-off-by: Titus Rwantare
---
hw/i2c/pmbus_device.c | 41 -
1 file changed, 40 insertions(+), 1 deletion(-)
diff --git a/hw/i2c/pmbus_device.c b/hw/i2c/pmbus_device.c
index 07a45c99f9..93c746bab3 100644
--- a/hw/i2c/pmbus_device.c
+++ b/hw/i2c
Signed-off-by: Titus Rwantare
Reviewed-by: Hao Wu
---
hw/sensor/isl_pmbus_vr.c | 50
include/hw/sensor/isl_pmbus_vr.h | 1 +
tests/qtest/isl_pmbus_vr-test.c | 78 ++--
3 files changed, 126 insertions(+), 3 deletions(-)
diff --git a/hw
Shengtan Mao (1):
hw/i2c: Added linear mode translation for pmbus devices
Titus Rwantare (8):
hw/i2c: pmbus: add registers
hw/i2c: pmbus: guard against out of range accesses
hw/i2c: pmbus: add PEC unsupported warning
hw/i2c: pmbus: refactor uint handling
hw/i2c: pmbus: update MAINTAINERS
add self to MAINTAINERS for the PMBus subsystem and related sensors,
and set PMBus as maintained.
Signed-off-by: Titus Rwantare
---
MAINTAINERS | 10 ++
1 file changed, 10 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index fa8adc2618..3601984b5d 100644
--- a/MAINTAINERS
+++ b
Signed-off-by: Titus Rwantare
Reviewed-by: Hao Wu
---
MAINTAINERS | 3 +
hw/arm/Kconfig | 1 +
hw/sensor/Kconfig| 5 +
hw/sensor/isl_pmbus_vr.c | 211 +
hw/sensor/meson.build| 1 +
include/hw
Hello all,
I'd like some clarification on how the following code transfers irqs
back and forth:
> b/hw/arm/aspeed_soc.c
>+/* iBT */
>+if (!sysbus_realize(SYS_BUS_DEVICE(&s->ibt), errp)) {
>+return;
>+}
>+memory_region_add_subregion(&s->lpc.iomem,
>+ sc->m
On Fri, 24 Sept 2021 at 03:55, Cédric Le Goater wrote:
>
> Hello Titus,
>
> On 9/24/21 10:42, Philippe Mathieu-Daudé wrote:
> > On 9/24/21 01:48, Titus Rwantare wrote:
> >> Hello all,
> >>
> >> I'd like some clarification on how the following c
because of the missing IRQs and the need for other patches
to get merged.
Thank you all.
Titus Rwantare (1):
hw/ipmi: add an aspeed ipmi iBT device model
hw/ipmi/ipmi_extern.h| 1 +
include/hw/arm/aspeed_soc.h | 2 +
include/hw/ipmi/aspeed_ibt.h | 77 +
hw/arm/aspeed
Modifies [PATCH] hw/misc: Add an iBT device model
posted by Cédric Le Goater, to use IPMIInterface.
Signed-off-by: Titus Rwantare
---
hw/ipmi/ipmi_extern.h| 1 +
include/hw/arm/aspeed_soc.h | 2 +
include/hw/ipmi/aspeed_ibt.h | 77 +
hw/arm/aspeed_ast2600.c | 12
On Tue, 28 Sept 2021 at 23:24, Cédric Le Goater wrote:
>
> Hello Titus,
>
> On 9/29/21 00:39, Titus Rwantare wrote:
> > This patch follows the Handing IPMI for emulating BMC patch set by Hao Wu.
> > Building on top of the work in [PATCH] hw/misc: Add an iBT device model
On Thu, 27 Jan 2022 at 11:39, Peter Maydell wrote:
>
> On Thu, 6 Jan 2022 at 23:19, Titus Rwantare wrote:
> >
> > +static uint8_t isl_pmbus_read_byte(PMBusDevice *pmdev)
> > +{
> > +qemu_log_mask(LOG_GUEST_ERROR,
> > + "%s: re
Signed-off-by: Titus Rwantare
Reviewed-by: Hao Wu
---
hw/sensor/isl_pmbus.c | 50 ++
include/hw/sensor/isl_pmbus.h | 1 +
tests/qtest/isl_pmbus-test.c | 78 +--
3 files changed, 126 insertions(+), 3 deletions(-)
diff --git a/hw
- add vout min register
- add PEC unsupported warning to pmbus_device class
- guard against out of range pmbus page accesses
Signed-off-by: Titus Rwantare
Reviewed-by: Hao Wu
---
MAINTAINERS | 12 -
hw/i2c/pmbus_device.c | 88
This patch series contains updates to PMBus in QEMU along with some PMBus
device models for Renesas regulators.
I have also added myself to MAINTAINERS as this code is in use daily,
where I am responsible for it.
Shengtan Mao (1):
hw/i2c: Added linear mode translation for pmbus devices
Titus
From: Shengtan Mao
Signed-off-by: Shengtan Mao
Reviewed-by: Titus Rwantare
---
hw/i2c/pmbus_device.c | 18 ++
include/hw/i2c/pmbus_device.h | 20 +++-
2 files changed, 37 insertions(+), 1 deletion(-)
diff --git a/hw/i2c/pmbus_device.c b/hw/i2c
Signed-off-by: Titus Rwantare
Reviewed-by: Hao Wu
---
MAINTAINERS | 3 +
hw/arm/Kconfig| 1 +
hw/sensor/Kconfig | 5 +
hw/sensor/isl_pmbus.c | 210 +++
hw/sensor/meson.build | 1 +
include/hw/sensor
The Renesas RAA229004 is a PMBus Multiphase Voltage Regulator
Signed-off-by: Titus Rwantare
Reviewed-by: Hao Wu
---
hw/sensor/isl_pmbus.c | 18 ++
include/hw/sensor/isl_pmbus.h | 1 +
tests/qtest/isl_pmbus-test.c | 7 +++
3 files changed, 26 insertions(+)
diff
Signed-off-by: Titus Rwantare
Reviewed-by: Hao Wu
---
MAINTAINERS | 8 +-
hw/arm/Kconfig| 1 +
hw/sensor/Kconfig | 4 +
hw/sensor/max31790_fan_ctrl.c | 454 ++
hw/sensor/meson.build
Signed-off-by: Titus Rwantare
Reviewed-by: Hao Wu
---
tests/qtest/max31790_fan_ctrl-test.c | 171 +++
tests/qtest/meson.build | 1 +
2 files changed, 172 insertions(+)
create mode 100644 tests/qtest/max31790_fan_ctrl-test.c
diff --git a/tests/qtest
From: Patrick Venture
Signed-off-by: Patrick Venture
Reviewed-by: Titus Rwantare
---
hw/arm/npcm7xx_boards.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/arm/npcm7xx_boards.c b/hw/arm/npcm7xx_boards.c
index 7d0f3148be..6fea2e161f 100644
--- a/hw/arm/npcm7xx_boards.c
+++ b/hw/arm
v), "gpio_input", 0x0F00, &error_abort);
We currently use these to test hardware presence and LEDs in simulation.
Thanks
Titus Rwantare (3):
hw/gpio: add PCA6414 i2c GPIO expander
hw/gpio: add PCA9538 8-bit GPIO expander
hw/gpio: add PCA9536 i2c gpio expander
hw/arm/Kco
This device has the same register layout as the pca9538, but 4 fewer
gpio pins. This commit lowers the number of pins intialised, and reuses
the pca9539 logic.
Reviewed-by: Hao Wu
Signed-off-by: Titus Rwantare
---
hw/gpio/pca_i2c_gpio.c | 22 ++
include/hw/gpio
The 8-bit expander has different register offsets than the 16-bit one,
making them incompatible.
Reviewed-by: Hao Wu
Signed-off-by: Titus Rwantare
---
hw/gpio/pca_i2c_gpio.c | 98 ++
include/hw/gpio/pca_i2c_gpio.h | 7 +++
2 files changed, 105
This is a simple i2c device that allows i2c capable devices to have
GPIOs.
Reviewed-by: Hao Wu
Signed-off-by: Titus Rwantare
---
hw/arm/Kconfig | 1 +
hw/gpio/meson.build | 1 +
hw/gpio/pca_i2c_gpio.c | 362
hw/gpio
On Mon, 6 Feb 2023 at 19:43, Joel Stanley wrote:
>
> On Mon, 6 Feb 2023 at 19:51, Titus Rwantare wrote:
> >
> > This is a simple i2c device that allows i2c capable devices to have
> > GPIOs.
>
> Nice.
>
> In Linux this is supported by a driver called pca953x.
On Mon, 6 Feb 2023 at 17:29, Dong, Eddie wrote:
> > -Original Message-
> > From: qemu-devel-bounces+eddie.dong=intel@nongnu.org > devel-bounces+eddie.dong=intel@nongnu.org> On Behalf Of Titus
> > Rwantare
> > Sent: Monday, February 6, 20
On Mon, 6 Feb 2023 at 13:38, Philippe Mathieu-Daudé wrote:
>
> Hi Titus,
>
> On 6/2/23 20:49, Titus Rwantare wrote:
> > This is a simple i2c device that allows i2c capable devices to have
> > GPIOs.
> >
> > Reviewed-by: Hao Wu
> > Signed-off-by: Ti
On Mon, 6 Feb 2023 at 14:27, Corey Minyard wrote:
>
> On Mon, Feb 06, 2023 at 07:49:34PM +, Titus Rwantare wrote:
> > This is a simple i2c device that allows i2c capable devices to have
> > GPIOs.
> >
> > Reviewed-by: Hao Wu
> > Signed-off-by: Titus R
Signed-off-by: Titus Rwantare
---
hw/i2c/core.c | 8 +---
hw/i2c/trace-events | 2 +-
2 files changed, 6 insertions(+), 4 deletions(-)
diff --git a/hw/i2c/core.c b/hw/i2c/core.c
index d4ba8146bf..c583c1497a 100644
--- a/hw/i2c/core.c
+++ b/hw/i2c/core.c
@@ -161,7 +161,8 @@ static int
v), "gpio_input", 0x0F00, &error_abort);
We currently use these to test hardware presence and LEDs in simulation.
Thanks
Since v1:
- addressed comments
- fixed typos in commit messages
Titus Rwantare (4):
hw/gpio: add PCA6416 i2c GPIO expander
hw/gpio: add PCA9538 8-bit GPIO ex
The 8-bit expander has different register offsets than the 16-bit one,
making them incompatible.
Reviewed-by: Hao Wu
Signed-off-by: Titus Rwantare
---
hw/gpio/pca_i2c_gpio.c | 94 ++
include/hw/gpio/pca_i2c_gpio.h | 7 +++
2 files changed, 101
This device has the same register layout as the pca9538, but 4 fewer
gpio pins. This commit lowers the number of pins initialised, and reuses
the pca9538 logic.
Reviewed-by: Hao Wu
Signed-off-by: Titus Rwantare
---
hw/gpio/pca_i2c_gpio.c | 18 ++
include/hw/gpio
The PCA6416 is an i2c device with 16 GPIOs.
Reviewed-by: Hao Wu
Signed-off-by: Titus Rwantare
---
hw/arm/Kconfig | 1 +
hw/gpio/Kconfig | 4 +
hw/gpio/meson.build | 1 +
hw/gpio/pca_i2c_gpio.c | 388
On Fri, 4 Mar 2022 at 13:43, Corey Minyard wrote:
>
> On Tue, Mar 01, 2022 at 05:50:44PM -0800, Titus Rwantare wrote:
> > v2:
> > - split PMBus commit with updates into individual fixes
> > - renamed isl_pmbus[.ch] adding _vr for voltage regulators
> >
>
/3/22 02:50, Titus Rwantare wrote:
> > Signed-off-by: Titus Rwantare
> > ---
> > hw/i2c/pmbus_device.c | 41 -
> > 1 file changed, 40 insertions(+), 1 deletion(-)
>
> > static uint8_t pmbus_receive_byte(SMBusDevic
Yes, fixed.
On Fri, 4 Mar 2022 at 16:02, Philippe Mathieu-Daudé
wrote:
>
> On 2/3/22 02:50, Titus Rwantare wrote:
> > Signed-off-by: Titus Rwantare
> > ---
> > hw/i2c/pmbus_device.c | 5 +
> > 1 file changed, 5 insertions(+)
> >
> > d
Signed-off-by: Titus Rwantare
Reviewed-by: Philippe Mathieu-Daudé
---
hw/i2c/pmbus_device.c | 47 ---
include/hw/i2c/pmbus_device.h | 2 ++
2 files changed, 45 insertions(+), 4 deletions(-)
diff --git a/hw/i2c/pmbus_device.c b/hw/i2c/pmbus_device.c
add self to MAINTAINERS for the PMBus subsystem and related sensors,
and set PMBus as maintained.
Signed-off-by: Titus Rwantare
Reviewed-by: Philippe Mathieu-Daudé
---
MAINTAINERS | 10 ++
1 file changed, 10 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index fa8adc2618
The Renesas RAA229004 is a PMBus Multiphase Voltage Regulator
Signed-off-by: Titus Rwantare
Reviewed-by: Hao Wu
Reviewed-by: Philippe Mathieu-Daudé
---
hw/sensor/isl_pmbus_vr.c | 18 ++
include/hw/sensor/isl_pmbus_vr.h | 1 +
tests/qtest/isl_pmbus_vr-test.c | 8
This change cleans up the inputs to pmbus_receive uint, the length of
received data is contained in PMBusDevice state and doesn't need to be
passed around.
Signed-off-by: Titus Rwantare
Reviewed-by: Philippe Mathieu-Daudé
---
hw/i2c/pmbus_device.c | 18 +-
1 file chang
From: Shengtan Mao
Signed-off-by: Shengtan Mao
Reviewed-by: Titus Rwantare
Reviewed-by: Philippe Mathieu-Daudé
---
hw/i2c/pmbus_device.c | 18 ++
include/hw/i2c/pmbus_device.h | 20 +++-
2 files changed, 37 insertions(+), 1 deletion(-)
diff --git a/hw
Signed-off-by: Titus Rwantare
Reviewed-by: Hao Wu
Reviewed-by: Philippe Mathieu-Daudé
---
hw/sensor/isl_pmbus_vr.c | 50 ++
include/hw/sensor/isl_pmbus_vr.h | 1 +
tests/qtest/isl_pmbus_vr-test.c | 72
3 files changed, 123
Signed-off-by: Titus Rwantare
Reviewed-by: Hao Wu
Reviewed-by: Philippe Mathieu-Daudé
---
MAINTAINERS | 3 +
hw/arm/Kconfig | 1 +
hw/sensor/Kconfig| 5 +
hw/sensor/isl_pmbus_vr.c | 211 +
hw/sensor
- add the VOUT_MIN and STATUS_MFR registers
Signed-off-by: Titus Rwantare
Reviewed-by: Philippe Mathieu-Daudé
---
hw/i2c/pmbus_device.c | 24
include/hw/i2c/pmbus_device.h | 3 +++
2 files changed, 27 insertions(+)
diff --git a/hw/i2c/pmbus_device.c b/hw
Signed-off-by: Titus Rwantare
---
hw/i2c/pmbus_device.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/hw/i2c/pmbus_device.c b/hw/i2c/pmbus_device.c
index c7ec8e5499..ff644c1d4a 100644
--- a/hw/i2c/pmbus_device.c
+++ b/hw/i2c/pmbus_device.c
@@ -307,6 +307,11 @@ static uint8_t
returns
Shengtan Mao (1):
hw/i2c: Added linear mode translation for pmbus devices
Titus Rwantare (8):
hw/i2c: pmbus: add registers
hw/i2c: pmbus: fix error returns and guard against out of range
accesses
hw/i2c: pmbus: add PEC unsupported warning
hw/i2c: pmbus: refactor uint handling
config space is exposed due to Intel posting
various platform configuration in PCI config space.
Commands implemented:
- Ping
- GetDIB
- GetTemp
- GetPkgConfig (partial)
Commands not implemented:
- RdIAMSR
- RdPCIConfig
- RdPCIConfigLocal
Signed-off-by: Titus Rwantare
Reviewed-by: Hao Wu
Reviewed-by
These fields can also be adjusted at runtime through
qmp.
A lot of the registers are hard coded, see hw/peci/peci-client.c. I'd like to
gauge interest in what potential users would like to be adjustable at runtime.
I've not written QEMU models that read config files at runtime, some
Signed-off-by: Titus Rwantare
Reviewed-by: Hao Wu
---
hw/peci/peci-client.c | 63 ++
hw/peci/peci-core.c| 44 +++--
include/hw/peci/peci.h | 23 +++
3 files changed, 128 insertions(+), 2 deletions(-)
diff --git a
This allows BMC firmware for npcm7xx BMCs to talk to a PECI client
in qemu.
Signed-off-by: Titus Rwantare
Reviewed-by: Patrick Venture
---
MAINTAINERS| 3 +-
hw/arm/Kconfig | 1 +
hw/arm/npcm7xx.c | 9 ++
hw/peci/meson.build
config space is exposed due to Intel posting
various platform configuration in PCI config space.
Commands implemented:
- Ping
- GetDIB
- GetTemp
- GetPkgConfig (partial)
Commands not implemented:
- RdIAMSR
- RdPCIConfig
- RdPCIConfigLocal
Signed-off-by: Titus Rwantare
Reviewed-by: Hao Wu
Reviewed-by
These fields can also be adjusted at runtime through
qmp.
A lot of the registers are hard coded, see hw/peci/peci-client.c. I'd like to
gauge interest in what potential users would like to be adjustable at runtime.
I've not written QEMU models that read config files at runtime, somethi
On Fri, 9 Sept 2022 at 12:54, Peter Delevoryas wrote:
>
> On Tue, Sep 06, 2022 at 10:05:49PM +, Titus Rwantare wrote:
...
> >
> > This is something that can also be extended as other parameters arise that
> > need
> > to differ between platforms. So far you can
On Fri, 9 Sept 2022 at 12:58, Peter Delevoryas wrote:
> > +/*
> > + * PECI Client device
> > + * Copyright 2021 Google LLC
> > + *
> > + * SPDX-License-Identifier: GPL-2.0-or-later
>
> Not sure, but I think the SPDX license identifier is supposed to be in
> the first line? Maybe not though. I wou
1 - 100 of 165 matches
Mail list logo
