some dependencies for unit tests. Hence, this patch introduces a new
function vmstate_save_state_with_err, which will eventually propagate
the error message to savevm.c where a migrate_set_error call can be
eventually done.
Acked-by: Peter Xu
Signed-off-by: Tejus GK
---
include/migration/vmstate.h
clients like libvirt never know the actual reason for the failure.
This patch covers such cases outside of migration.c and updates the
error description at the appropriate places.
Acked-by: Peter Xu
Signed-off-by: Tejus GK
---
migration/savevm.c | 17 ++---
migration/vmstate.c | 7
Hi everyone,
I'm sending out the rebased version of the v2 patch, please review.
Thanks,
Tejus
Changelog:
v3:
- Rebase on master
v2:
- Rebase on master
Tejus GK (2):
migration/vmstate: Introduce vmstate_save_state_with_err
migration: Update error description outside migrat
On 22/06/23 10:25 pm, Juan Quintela wrote:
From: Tejus GK
In the function qmp_migrate(), yank_unregister_instance() gets called
twice which isn't required. Hence, refactoring it so that it gets called
during the local_error cleanup.
Reviewed-by: Daniel P. Berrangé
Reviewed-by: Juan Qui
On 24 Apr 2024, at 9:19 PM, Zhao Liu wrote:
@@ -2140,6 +2164,7 @@ static const CPUCaches epyc_milan_cache_info = {
.lines_per_tag = 1,
.self_init = 1,
.no_invd_sharing = true,
+.share_level = CPU_TOPO_LEVEL_CORE,
},
.l1i_cache = &(CPUCacheInfo) {
On 08/05/23 10:19 pm, Thomas Huth wrote:
> Hi!
>
> On 08/05/2023 17.32, tejus.gk wrote:
>> There are places in the code where the migration is marked failed with
>> MIGRATION_STATUS_FAILED, but the failiure reason is never updated. Hence
>
> s/failiure/failure/
Ack
>
>> libvirt doesn't know
On 09/05/23 3:46 pm, Juan Quintela wrote:
> "tejus.gk" wrote:
>> There are places in the code where the migration is marked failed with
>> MIGRATION_STATUS_FAILED, but the failiure reason is never updated. Hence
>> libvirt doesn't know why the migration failed when it queries for it.
>>
>> Sign
There are places outside of migration.c which eventually leads to a
migration failure, but the failure reason is never updated. Hence
libvirt doesn't know why the migration failed when it queries for it.
Signed-off-by: Tejus GK
---
migration/savevm.c | 13 ++---
migration/vmst
There are places in migration.c where the migration is marked failed with
MIGRATION_STATUS_FAILED, but the failure reason is never updated. Hence
libvirt doesn't know why the migration failed when it queries for it.
Signed-off-by: Tejus GK
---
migration/migration.c
test build
failing, so I wanted to know the right way to approach this.
regards,
Tejus
Tejus GK (2):
migration: Update error description whenever migration fails
migration: Update error description whenever migration fails
migration/migration.c | 23 ---
migration/savevm
On 04/05/23 1:46 pm, Daniel P. Berrangé wrote:
> On Wed, May 03, 2023 at 08:31:16PM +, tejus.gk wrote:
>> There are places in the code where the migration is marked failed with
>> MIGRATION_STATUS_FAILED, but the failiure reason is never updated. Hence
>> libvirt doesn't know why the migration
On 18/05/23 5:22 pm, Juan Quintela wrote:
> Tejus GK wrote:
>> There are places outside of migration.c which eventually leads to a
>> migration failure, but the failure reason is never updated. Hence
>> libvirt doesn't know why the migration failed when it queries f
In the function qmp_migrate(), yank_unregister_instance() gets called
twice which isn't required. Hence, refactoring it so that it gets called
during the local_error cleanup.
Reviewed-by: Daniel P. Berrangé
Reviewed-by: Juan Quintela
Signed-off-by: Tejus GK
---
migration/migration.
There are places in migration.c where the migration is marked failed with
MIGRATION_STATUS_FAILED, but the failure reason is never updated. Hence
libvirt doesn't know why the migration failed when it queries for it.
Reviewed-by: Daniel P. Berrangé
Signed-off-by: Tejus GK
---
migr
erent
patchset.
Regards,
Tejus
Tejus GK (2):
migration: Update error description whenever migration fails
migration: Refactor repeated call of yank_unregister_instance
migration/migration.c | 23 ---
1 file changed, 12 insertions(+), 11 deletions(-)
--
2.22.3
clients like libvirt never know the actual reason for the failure.
This patch covers such cases outside of migration.c and updates the
error description at the appropriate places.
Signed-off-by: Tejus GK
---
migration/savevm.c | 17 ++---
migration/vmstate.c | 7 ---
2 files
some dependencies for unit tests. Hence, this patch introduces a new
function vmstate_save_state_with_err, which will eventually propagate
the error message to savevm.c where a migrate_set_error call can be
eventually done.
Signed-off-by: Tejus GK
---
include/migration/vmstate.h | 4 +++-
migration/sav
patchset sent before which
covered cases of such gaps in migration.c aswell.
Previous patchset:
https://lists.gnu.org/archive/html/qemu-devel/2023-05/msg04463.html
Regards,
Tejus
Tejus GK (2):
migration/vmstate: Introduce vmstate_save_state_with_err
migration: Update error description outside
clients like libvirt never know the actual reason for the failure.
This patch covers such cases outside of migration.c and updates the
error description at the appropriate places.
Acked-by: Peter Xu
Signed-off-by: Tejus GK
---
migration/savevm.c | 17 ++---
migration/vmstate.c | 7
master
v2:
- Rebase on master
Tejus GK (2):
migration/vmstate: Introduce vmstate_save_state_with_err
migration: Update error description outside migration.c
include/migration/vmstate.h | 4 +++-
migration/savevm.c | 19 +++
migration/vmstate.c | 19
some dependencies for unit tests. Hence, this patch introduces a new
function vmstate_save_state_with_err, which will eventually propagate
the error message to savevm.c where a migrate_set_error call can be
eventually done.
Acked-by: Peter Xu
Signed-off-by: Tejus GK
---
include/migration/vmstate.h
On 03/10/23 6:14 pm, Juan Quintela wrote:
Tejus GK wrote:
A few code paths exist in the source code,where a migration is
marked as failed via MIGRATION_STATUS_FAILED, but the failure happens
outside of migration.c
In such cases, an error_report() call is made, however the current
On 04/10/23 1:53 pm, Juan Quintela wrote:
Tejus GK wrote:
On 03/10/23 6:14 pm, Juan Quintela wrote:
Tejus GK wrote:
A few code paths exist in the source code,where a migration is
marked as failed via MIGRATION_STATUS_FAILED, but the failure happens
outside of migration.c
In such cases, an
some dependencies for unit tests. Hence, this patch introduces a new
function vmstate_save_state_with_err, which will eventually propagate
the error message to savevm.c where a migrate_set_error call can be
eventually done.
Acked-by: Peter Xu
Signed-off-by: Tejus GK
---
include/migration/vmstate.h
Hi everyone,
This is the rebased version of the v3 patchset, please review, thanks.
Regards
Tejus
Changelog:
v4:
- Rebase on master
v3:
- Rebase on master
v2:
- Rebase on master
Tejus GK (2):
migration/vmstate: Introduce vmstate_save_state_with_err
migration: Update error description
clients like libvirt never know the actual reason for the failure.
This patch covers such cases outside of migration.c and updates the
error description at the appropriate places.
Acked-by: Peter Xu
Signed-off-by: Tejus GK
---
migration/savevm.c | 17 ++---
migration/vmstate.c | 7
On 23/05/23 6:16 pm, Tejus GK wrote:
> Hi everyone,
>
> Thank you for the reviews, this is the v4 patchset based on the reviews
> received on the previous ones.
>
> Links to the previous patchsets:
> v1: https://lists.gnu.org/archive/html/qemu-devel/2023-05/msg0
On 26/05/23 5:20 pm, Tejus GK wrote:
> Hi everyone,
>
> This patchset aims to cover code paths in the source code where a
> migration is marked as failed via MIGRATION_STATUS_FAILED, however the
> failure exists outside of migration.c, and without a call for
> migrate
Hi everyone,
Thank you, Peter, for the review; I'm sending this patch out as a
standard patch rather than an RFC patch. These are the following
modifications in this version:
v2:
- Rebase on master
Thanks,
Tejus
Tejus GK (2):
migration/vmstate: Introduce vmstate_save_state_wit
some dependencies for unit tests. Hence, this patch introduces a new
function vmstate_save_state_with_err, which will eventually propagate
the error message to savevm.c where a migrate_set_error call can be
eventually done.
Acked-by: Peter Xu
Signed-off-by: Tejus GK
---
include/migration/vmstate.h
clients like libvirt never know the actual reason for the failure.
This patch covers such cases outside of migration.c and updates the
error description at the appropriate places.
Acked-by: Peter Xu
Signed-off-by: Tejus GK
---
migration/savevm.c | 17 ++---
migration/vmstate.c | 7
Hi everyone,
This is the v5 patchset which has been rebased on the current
master. Requesting this to be queued for merge as this has already been
reviewed.
Regards,
Tejus
Tejus GK (2):
migration: Update error description whenever migration fails
migration: Refactor repeated call of
There are places in migration.c where the migration is marked failed with
MIGRATION_STATUS_FAILED, but the failure reason is never updated. Hence
libvirt doesn't know why the migration failed when it queries for it.
Reviewed-by: Daniel P. Berrangé
Signed-off-by: Tejus GK
---
migr
In the function qmp_migrate(), yank_unregister_instance() gets called
twice which isn't required. Hence, refactoring it so that it gets called
during the local_error cleanup.
Reviewed-by: Daniel P. Berrangé
Reviewed-by: Juan Quintela
Signed-off-by: Tejus GK
---
migration/migration.
On 22/06/23 7:43 am, Juan Quintela wrote:
> From: Tejus GK
>
> There are places in migration.c where the migration is marked failed with
> MIGRATION_STATUS_FAILED, but the failure reason is never updated. Hence
> libvirt doesn't know why the migration failed when it queries f
Hi, recently I was trying to play with the PCIe limits on the q35
machine type. I see that docs/pcie.txt mentions:
The IO space is very limited, to 65536 byte-wide IO ports, and may
even be fragmented by fixed IO ports owned by platform devices
resulting in at most 10 PCI Express Root Ports or
36 matches
Mail list logo
