[PATCH] Adding ifdefs to call the respective routines only when their configs are enabled

2021-05-24 Thread Swetha Joshi
From: Swetha Signed-off-by: Swetha --- target/arm/kvm64.c | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/target/arm/kvm64.c b/target/arm/kvm64.c index dff85f6db9..724ce78265 100644 --- a/target/arm/kvm64.c +++ b/target/arm/kvm64.c @@ -1403,7 +1403,10 @@ void

Re: [PATCH] Adding ifdefs to call the respective routines only when their configs are enabled

2021-05-24 Thread Swetha Joshi
ne is defined in virt.h and acpi_ghes_record_errors() is defined in ghes.h. ~ Swetha On Mon, May 24, 2021 at 6:53 PM Richard Henderson < richard.hender...@linaro.org> wrote: > On 5/24/21 3:56 PM, Swetha Joshi wrote: > > From: Swetha > > > > Signed-off-by: Swetha >

[PATCH_V2 2/2] Removed double declaration

2021-05-24 Thread Swetha Joshi
--- target/arm/kvm64.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/target/arm/kvm64.c b/target/arm/kvm64.c index 724ce78265..47a4d9d831 100644 --- a/target/arm/kvm64.c +++ b/target/arm/kvm64.c @@ -1405,8 +1405,8 @@ void kvm_arch_on_sigbus_vcpu(CPUState *c, int code,

[PATCH_V2 1/2] Adding ifdefs to call the respective routines only when their configs are enabled

2021-05-24 Thread Swetha Joshi
From: Swetha Signed-off-by: Swetha --- target/arm/kvm64.c | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/target/arm/kvm64.c b/target/arm/kvm64.c index dff85f6db9..724ce78265 100644 --- a/target/arm/kvm64.c +++ b/target/arm/kvm64.c @@ -1403,7 +1403,10 @@ void

[PATCH_V3] Adding ifdefs to call the respective routines only when their configs are enabled

2021-05-24 Thread Swetha Joshi
Signed-off-by: Swetha Joshi --- target/arm/kvm64.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/target/arm/kvm64.c b/target/arm/kvm64.c index dff85f6db9..47a4d9d831 100644 --- a/target/arm/kvm64.c +++ b/target/arm/kvm64.c @@ -1403,7 +1403,10 @@ void

Re: [PATCH_V3] Adding ifdefs to call the respective routines only when their configs are enabled

2021-05-25 Thread Swetha Joshi
May 2021 at 04:21, Richard Henderson > wrote: > > > > On 5/24/21 7:58 PM, Swetha Joshi wrote: > > > Signed-off-by: Swetha Joshi > > > --- > > > target/arm/kvm64.c | 12 > > > 1 file changed, 8 insertions(+), 4 deletions(-) > >

Re: [PATCH_V3] Adding ifdefs to call the respective routines only when their configs are enabled

2021-05-26 Thread Swetha Joshi
mu derived machines we use. Thanks, Swetha. On Tue, May 25, 2021 at 10:16 AM Peter Maydell wrote: > On Tue, 25 May 2021 at 17:28, Swetha Joshi > wrote: > > > > Hey Peter, Phil, > > > > Yeah like Peter mentioned, when KVM is enabled and we don't want VIRT >

Re: [PATCH_V3] Adding ifdefs to call the respective routines only when their configs are enabled

2021-05-28 Thread Swetha Joshi
pointing to these routines: virt_is_acpi_enabled, acpi_ghes_record_errors Thanks, Swetha. On Fri, May 28, 2021 at 12:08 AM Dongjiu Geng wrote: > Peter Maydell 于2021年5月27日周四 上午2:19写道: > > > > On Wed, 26 May 2021 at 18:32, Swetha Joshi > wrote: > > > > > > Hello,

Re: [PATCH_V3] Adding ifdefs to call the respective routines only when their configs are enabled

2021-06-03 Thread Swetha Joshi
Basically, you need to remove CONFIG_VIRT_ARM=y from arm-soft memu.mak and then enable KVM, I might have missed some places where you need to enable kvm. On Wed, Jun 2, 2021 at 6:44 AM Dongjiu Geng wrote: > Swetha Joshi 于2021年5月29日周六 上午3:41写道: > > > > I apologize for the dela

Re: [PATCH_V3] Adding ifdefs to call the respective routines only when their configs are enabled

2021-06-03 Thread Swetha Joshi
Oh okay, thank you. I will test this by eod today! On Thu, Jun 3, 2021 at 10:22 AM Peter Maydell wrote: > On Fri, 28 May 2021 at 20:41, Swetha Joshi > wrote: > > > > I apologize for the delay, here are the repro steps: > > 1. Remove CONFIG_ARM_VIRT=y from arm-softm

Re: [PATCH_V3] Adding ifdefs to call the respective routines only when their configs are enabled

2021-06-03 Thread Swetha Joshi
Hello, I have tested this patch with our qemu and it works, thank you. What are the next steps for this patch? So is it approved and ready to go in mainline? Thanks, Swetha. On Thu, Jun 3, 2021 at 10:30 AM Swetha Joshi wrote: > > Oh okay, thank you. I will test this by eod today! > &

Re: [PATCH_V3] Adding ifdefs to call the respective routines only when their configs are enabled

2021-06-04 Thread Swetha Joshi
Can y oh I let me know once it goes in mainline? Thanks! On Fri, Jun 4, 2021 at 2:03 AM Peter Maydell wrote: > On Fri, 4 Jun 2021 at 06:26, Swetha Joshi > wrote: > > > > Hello, I have tested this patch with our qemu and it works, thank you. > > Thanks for testing. >