Re: [Qemu-devel] [PATCH 1/2] tcg-hppa: Fix brcond2 and setcond2

2012-12-24 Thread Stuart Brady
#x27;bl' here. It may be some time before I get around to submitting a patch for this, so just mentioning it briefly. -- Cheers, Stuart Brady

Re: [Qemu-devel] [PATCH] gdbstub: Fix memory leak

2011-10-18 Thread Stuart Brady
s and 136 deletions. I think I should at least submit the patch to convert cases involving casts as the first part of the patch series, and convert the sizeof(*E) and sizeof(T) cases as the second and third parts. Sound okay? Cheers, -- Stuart Brady

[Qemu-devel] [PATCH 5/5] Convert remaining calls to g_malloc(sizeof(type)) to g_new()

2011-10-20 Thread Stuart Brady
separately. Finally, cris-dis.c appears to perform allocations using the wrong pointer type. This should also be fixed separately. Signed-off-by: Stuart Brady --- block/qcow2-snapshot.c |2 +- block/vvfat.c |2 +- bsd-user/syscall.c |2 +- cpus.c |8

[Qemu-devel] [PATCH 1/5] Convert calls to g_malloc() using casts to g_new()

2011-10-20 Thread Stuart Brady
(T) * N) +E = g_new0(T, N) Signed-off-by: Stuart Brady --- console.c |6 +++--- gdbstub.c |2 +- hw/arm_timer.c |2 +- hw/bt-hci-csr.c|3 +-- hw/ccid-card-emulated.c|4 ++-- hw/ide/microdrive.c|2 +- hw

Re: [Qemu-devel] [PATCH] gdbstub: Fix memory leak

2011-10-20 Thread Stuart Brady
On Wed, Oct 19, 2011 at 01:59:04AM +0100, Stuart Brady wrote: > On Tue, Oct 18, 2011 at 06:18:11PM +, Blue Swirl wrote: > > > Cool. Please include the spatch with the commit message. > > Thanks, will do! Okay, submitted. This is the first time I've used git send-e

[Qemu-devel] [PATCH 4/5] Convert remaining calls to g_malloc(sizeof(type)) using casts to g_new()

2011-10-20 Thread Stuart Brady
*)g_malloc0(sizeof(T)) +g_new0(T, 1) @@ type T; expression N; @@ -(T *)g_malloc(sizeof(T) * N) +g_new(T, N) @@ type T; expression N; @@ -(T *)g_malloc0(sizeof(T) * N) +g_new0(T, N) Signed-off-by: Stuart Brady --- hw/sd.c|2 +- libcacard/vcard_emul_nss.c |2 +- 2 files

Re: [Qemu-devel] [PATCH 5/5] Convert remaining calls to g_malloc(sizeof(type)) to g_new()

2011-10-20 Thread Stuart Brady
On Thu, Oct 20, 2011 at 11:05:33AM +0200, Paolo Bonzini wrote: > On 10/20/2011 10:03 AM, Stuart Brady wrote: > >Coccinelle did not match these when matching assignments involving an > >expression corresponding to the type used for determining the size to > >allocate. &g

Re: [Qemu-devel] [PATCH 1/5] Convert calls to g_malloc() using casts to g_new()

2011-10-20 Thread Stuart Brady
On Thu, Oct 20, 2011 at 10:55:38AM +0200, Paolo Bonzini wrote: > On 10/20/2011 10:03 AM, Stuart Brady wrote: > >Convert calls to g_malloc() and g_malloc0() to g_new() and g_new0() > >respectively, in cases where the return value is casted to the same > >type as specified

Re: [Qemu-devel] [PATCH 5/5] Convert remaining calls to g_malloc(sizeof(type)) to g_new()

2011-10-21 Thread Stuart Brady
On Fri, Oct 21, 2011 at 09:37:02AM +0200, Paolo Bonzini wrote: > On 10/21/2011 02:26 AM, Stuart Brady wrote: > >>> They all look okay, perhaps the include path you passed to > >>> Coccinelle is incomplete? > >Ah, good point! I'm not sure what include dir

Re: [Qemu-devel] [PATCH 11/15] Sparc: avoid AREG0 for CWP and PSTATE helpers

2011-09-12 Thread Stuart Brady
lper.c. Looks like it might not build, either? Cheers, -- Stuart Brady

Re: [Qemu-devel] [PATCH 02/14] tcg: Add INDEX_op_trunc_i32

2014-03-21 Thread Stuart Brady
On Mon, Mar 17, 2014 at 11:37:44AM -0700, Richard Henderson wrote: > diff --git a/tcg/README b/tcg/README > index f178212..160cbe8 100644 > --- a/tcg/README > +++ b/tcg/README > @@ -306,6 +306,11 @@ This operation would be equivalent to > >dest = (t1 & ~0x0f00) | ((t2 << 8) & 0x0f00) > > +*

Re: [Qemu-devel] [PATCH 02/14] tcg: Add INDEX_op_trunc_i32

2014-03-21 Thread Stuart Brady
On Fri, Mar 21, 2014 at 11:35:12PM +, Stuart Brady wrote: > On Mon, Mar 17, 2014 at 11:37:44AM -0700, Richard Henderson wrote: > > diff --git a/tcg/README b/tcg/README > > index f178212..160cbe8 100644 > > --- a/tcg/README > > +++ b/tcg/README > > @@ -306,6 +

Re: [Qemu-devel] [PATCH 13/14] tcg-sparc: Fix 32-bit constant arguments tests

2014-03-22 Thread Stuart Brady
On Mon, Mar 17, 2014 at 11:37:55AM -0700, Richard Henderson wrote: > We need to discard garbage high bits before testing > for 32-bit I and J constraints. > > Signed-off-by: Richard Henderson > --- > tcg/sparc/tcg-target.c | 73 > +- > tcg/sparc/t

Re: [Qemu-devel] [PATCH v2] target-ppc: improve "info registers" by printing SPRs

2014-03-22 Thread Stuart Brady
On Sat, Mar 22, 2014 at 11:25:49PM +1100, Alexey Kardashevskiy wrote: > This adds printing of all SPR registers registered for a CPU. > > This removes "SPR_" prefix from SPR name to reduce the output. > > Cc: Fabien Chouteau > Signed-off-by: Alexey Kardashevskiy > --- > Changes: > v2: > * remov

Re: [Qemu-devel] [PATCH v2] target-ppc: improve "info registers" by printing SPRs

2014-03-31 Thread Stuart Brady
On Mon, Mar 24, 2014 at 05:24:35PM +1100, Alexey Kardashevskiy wrote: > On 03/23/2014 01:43 AM, Stuart Brady wrote: > > This would leave the output without a trailing newline if the last spr > > doesn't have a name registered. Is it necessary to handle unnamed sprs > > a

Re: [Qemu-devel] [PATCH qom-cpu v2 04/40] target-ppc: Clean up ENV_GET_CPU() usage

2014-03-12 Thread Stuart Brady
On Mon, Mar 10, 2014 at 01:15:13AM +0100, Andreas Färber wrote: > Commits fdfba1a298ae26dd44bcfdb0429314139a0bc55a, > ab1da85791340e504d10487e1add81b9988afa98, > f606604f1c10b60ef294f1b9b229426521a365e3 and > 2c17449b3022ca9623c4a7e2a504a4150ac4ad30 added usages of ENV_GET_CPU() > macro in target-i

Re: [Qemu-devel] [PATCH qom-cpu v2 19/40] cpu: Move breakpoints field from CPU_COMMON to CPUState

2014-03-12 Thread Stuart Brady
On Mon, Mar 10, 2014 at 01:15:28AM +0100, Andreas Färber wrote: > Most targets were using offsetof(CPUFooState, breakpoints) to determine > how much of CPUFooState to clear on reset. Use the next field after > CPU_COMMON instead, if any, or sizeof(CPUFooState) otherwise. Would it not be easier and

Re: [Qemu-devel] [PATCH qom-cpu v2 19/40] cpu: Move breakpoints field from CPU_COMMON to CPUState

2014-03-12 Thread Stuart Brady
On Thu, Mar 13, 2014 at 12:59:01AM +0100, Andreas Färber wrote: > Am 13.03.2014 00:08, schrieb Stuart Brady: > > On Mon, Mar 10, 2014 at 01:15:28AM +0100, Andreas Färber wrote: > >> Most targets were using offsetof(CPUFooState, breakpoints) to determine > >> how much

Re: [Qemu-devel] [PATCH] target-alpha: fix subl and s8subl indentation

2014-03-18 Thread Stuart Brady
On Sat, Mar 15, 2014 at 01:40:26PM -0700, Richard Henderson wrote: > On 03/15/2014 11:33 AM, Paolo Bonzini wrote: > > Two missing braces, one close and one open, fabulously let the code > > compile. > > > > Signed-off-by: Paolo Bonzini > > Wow. That's ... amazing. > > Reviewed-by: Richard Hend

[Qemu-devel] [PATCH] target-ppc: Fix overallocation of opcode tables

2014-03-19 Thread Stuart Brady
create_new_table() should allocate 0x20 opc_handler_t pointers, but actually allocates 0x20 opc_handler_t structs. Fix this. Signed-off-by: Stuart Brady --- translate_init.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target-ppc/translate_init.c b/target-ppc

Re: [Qemu-devel] [PATCH 5/8] tcg: Add interpreter for bytecode

2011-09-19 Thread Stuart Brady
ther option that I've not considered? To me, option 1) seems like the simplest, although the macros needed to do this are likely to be a little hairy... I'm also concerned that we should not clobber R1 when storing a 32-bit return value in R0 on 32-bit architectures. Cheers, -- Stuart Brady

Re: [Qemu-devel] [PATCH 6/8] tcg: Add bytecode generator for tcg interpreter

2011-09-19 Thread Stuart Brady
On Sun, Sep 18, 2011 at 10:03:07AM +, Blue Swirl wrote: > I was wondering if this #ifdeffery is needed since TCI would probably > give more performance compared to the alternative, TCG generated > emulation sequences. But it could be useful for testing those. Maybe > there should be two option

Re: [Qemu-devel] [PATCH 5/8] tcg: Add interpreter for bytecode

2011-10-16 Thread Stuart Brady
On Mon, Sep 19, 2011 at 09:24:47PM +0100, Stuart Brady wrote: > On Sat, Sep 17, 2011 at 10:00:31PM +0200, Stefan Weil wrote: > [...] > > +u64 = ((helper_function)t0)(tci_read_reg(TCG_REG_R0), > > +tci_r

Re: [Qemu-devel] [PATCH] gdbstub: Fix memory leak

2011-10-17 Thread Stuart Brady
On Mon, Oct 17, 2011 at 10:01:25PM +0200, Stefan Weil wrote: > > The patch also slightly cleans the g_malloc0 statement which was > touched by that change (no type cast, easier code review). [...] > -s = (GDBRegisterState *)g_malloc0(sizeof(GDBRegisterState)); [...] > +s = g_malloc0(sizeof

Re: [Qemu-devel] [PATCH v3 0/6] Remove libqemu related stuff from QEMU source tree

2011-12-06 Thread Stuart Brady
On Tue, Nov 15, 2011 at 08:47:06PM +0800, Chen Wei-Ren (陳韋任) wrote: > From: Chen Wei-Ren > > According to [1], libqemu is not available anymore. Remove libqemu > related stuff from QEMU source tree. > > [1] http://www.mail-archive.com/address@hidden/msg49809.html Since I've just gone looking

Re: [Qemu-devel] [PATCH] tcg: Remove redundant declarations of TCG_TARGET_REG_BITS

2011-12-08 Thread Stuart Brady
On Thu, Dec 08, 2011 at 08:19:45AM +0100, Stefan Weil wrote: > Am 08.12.2011 08:03, schrieb 陳韋任: > >On Wed, Dec 07, 2011 at 11:31:46PM +0100, Stefan Weil wrote: > >>TCG_TARGET_REG_BITS is declared in tcg.h for all TCG targets. > > > >Just want to make sure. When we talk about target in TCG, that >

Re: [Qemu-devel] [PATCH] Z80 emulation updated again!

2010-12-29 Thread Stuart Brady
ower consumption on mobile devices, this would more likely be a matter of integrating TCG into existing emulators. I won't let the Z80 target bitrot too badly, and do plan to merge back into the fork pretty soon... but there's still quite a bit to do. Cheers, -- Stuart Brady

Re: [Qemu-devel] [PATCH 1/6] softfloat: remove HPPA specific code

2011-01-05 Thread Stuart Brady
absent entirely) on different architectures, different padding is required. Rather than a laundry list of targets, this would best handled automatically, even if this would required rather evil macros or code generation... perhaps I should give this a go? Cheers, -- Stuart Brady

Re: [Qemu-devel] [PATCH 1/6] softfloat: remove HPPA specific code

2011-01-06 Thread Stuart Brady
On Thu, Jan 06, 2011 at 08:58:17AM +, Peter Maydell wrote: > On 5 January 2011 23:13, Stuart Brady wrote: > > I do have a few concerns regarding SoftFloat, though: > > > >   FIXMEs should be left in the code (or a document maintained on the > >   Wiki) to keep t

Re: [Qemu-devel] [PATCH 1/6] softfloat: remove HPPA specific code

2011-01-06 Thread Stuart Brady
On Thu, Jan 06, 2011 at 06:43:28PM +, Peter Maydell wrote: > On 6 January 2011 18:13, Stuart Brady wrote: > > On Thu, Jan 06, 2011 at 08:58:17AM +, Peter Maydell wrote: > >> On 5 January 2011 23:13, Stuart Brady wrote: > >> > I do have a few concer

Re: [Qemu-devel] [PATCH 3/7] tcg-hppa: Implement deposit operation.

2011-01-07 Thread Stuart Brady
(arg2 & ((1u << len) - 1)) << ofs); > +} else { > +tcg_out_zdep(s, arg0, arg2, ofs, len); > +} Otherwise, looks good at first glance. It'll be a few days before I can test on an HPPA box, though. Cheers, -- Stuart Brady

Re: [Qemu-devel] [PATCH 1/7] tcg: Define "deposit" as an optional operation.

2011-01-07 Thread Stuart Brady
? :- For example, 0x804 indicates a 4-bit field starting from bit 8. This operation would be equivalent to: dest = (t1 & ~(0xf << 8)) | ((t2 << 8) & (0xf << 8)) OTOH, the code in your version was simpler... so maybe 0x201 or 0x102 as a compromise? I suppose it's unlikely that anyone's really going to need the example though, so I'm probably fussing too much. :-) Cheers, -- Stuart Brady

Re: [Qemu-devel] [PATCH 2/2] checkpatch: adjust to QEMUisms

2011-01-09 Thread Stuart Brady
stent cleanup tools Could you separate out the coding style changes, please? Otherwise, it's just 2900 lines added and 2900 lines removed. Thanks, -- Stuart Brady

Re: [Qemu-devel] [PATCH 1/2] Add checkpatch.pl from Linux kernel

2011-01-09 Thread Stuart Brady
s and developers might well need in a separate directory (perhaps including examples for tun, etc?) reads like a good idea to my eyes, anyway. Cheers, -- Stuart Brady

Re: [Qemu-devel] tcg shift ops and magnitudes larger than register size

2011-01-14 Thread Stuart Brady
tic ops and loads/stores worked the same way on all targets. Targets using different orderings for dest / source parameters was not really fun when switching constantly between SPARC, MIPS and x86 targets. :-/ Cheers, -- Stuart Brady

Re: [Qemu-devel] How does env_to_regs and regs_to_env works?

2010-06-02 Thread Stuart Brady
job to make sure that the generated code saves values in the CPUState struct where appropriate, i.e. at the end of any 'basic block', or where host registers might get clobbered, or where exceptions might need to be raised. This is handled by calls to the save_globals() function in tcg.c. Cheers, -- Stuart Brady

Re: [Qemu-devel] qemu-ppc can't run static uClibc binaries.

2010-02-16 Thread Stuart Brady
ember whether Jocelyn was interested in running BSD binaries under Linux or under BSD. The former seems reasonable, although even if that did work for PPC at one point, I doubt that's still the case... Cheers, -- Stuart Brady

Re: [Qemu-devel] [PATCH 0/3] Get tcg-hppa working

2010-02-20 Thread Stuart Brady
mu_ld / qemu_st cleanup strikes me as something that would be appropriate for some other TCG targets too, once this has been applied. The first thing that I do when I find the time will be to get TCI working fully on 32-bit archs... then I'll see what I can do to try to track down the remaining issues. Cheers, -- Stuart Brady

Re: [Qemu-devel] [PATCH 0/3] Get tcg-hppa working

2010-02-20 Thread Stuart Brady
On Sun, Feb 21, 2010 at 12:54:46AM +0300, malc wrote: > On Sat, 20 Feb 2010, Stuart Brady wrote: > > > The qemu_ld / qemu_st cleanup strikes me as something that would be > > appropriate for some other TCG targets too, once this has been applied. > > Care to point out

Re: [Qemu-devel] [PATCH] tcg: fix build on 32-bit hppa, ppc and sparc hosts

2010-03-03 Thread Stuart Brady
HPPA, yet, and that's unlikely to change soon. -- Cheers, Stuart Brady

Re: [Qemu-devel] [PATCH 1/4] tcg-hppa: Fix const errors in hppa-dis.c.

2010-03-16 Thread Stuart Brady
On Sat, Feb 20, 2010 at 11:31:31AM -0800, Richard Henderson wrote: > Signed-off-by: Richard Henderson Acked-by: Stuart Brady > --- > hppa-dis.c |4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/hppa-dis.c b/hppa-dis.c > index 9d96d72..4

Re: [Qemu-devel] [PATCH 2/4] tcg-hppa: Fix 64-bit argument ordering.

2010-03-16 Thread Stuart Brady
On Sat, Feb 20, 2010 at 11:32:23AM -0800, Richard Henderson wrote: > Signed-off-by: Richard Henderson Acked-by: Stuart Brady > --- > tcg/tcg.c | 12 +++- > 1 files changed, 11 insertions(+), 1 deletions(-) > > diff --git a/tcg/tcg.c b/tcg/tcg.c > index 18

Re: [Qemu-devel] [PATCH 3/4] tcg-hppa: Finish the port.

2010-03-16 Thread Stuart Brady
shd, vshd, ori, andi, shifts, rotates, > multiply, millicode calls, branches, setcond. Split out TLB reads from > qemu_ld and qemu_st; fix argument loading for tlb external calls. > Generate the prologue. > > Signed-off-by: Richard Henderson Acked-by: Stuart Brady I suppos

Re: [Qemu-devel] [PATCH 4/4] tcg-hppa: Compute is_write in cpu_signal_handler.

2010-03-16 Thread Stuart Brady
On Fri, Mar 12, 2010 at 03:58:08PM +0100, Richard Henderson wrote: > Signed-off-by: Richard Henderson Acked-by: Stuart Brady Argh. It just seems mind bogglingly silly that is_write doesn't seem to be included in the siginfo on archs where doing so would make sense... It's at le

Re: [Qemu-devel] [PATCH 4/4] tcg-hppa: Compute is_write in cpu_signal_handler.

2010-03-16 Thread Stuart Brady
On Wed, Mar 17, 2010 at 02:10:43AM +, Stuart Brady wrote: > Argh. It just seems mind bogglingly silly that is_write doesn't seem to > be included in the siginfo on archs where doing so would make sense... > It's at least something I'd have hoped libc could take car

Re: [Qemu-devel] [PATCH 3/4] tcg-hppa: Finish the port.

2010-03-17 Thread Stuart Brady
On Wed, Mar 17, 2010 at 07:56:12AM -0700, Richard Henderson wrote: > On 03/16/2010 06:58 PM, Stuart Brady wrote: > > The tcg_reg_free() calls worry me slightly, but I assume they're safe... > > Yeah, that one's rather gross. > > Since Aurelien's generic div

Re: [Qemu-devel] Question about memory micro operations in Qemu 0.12.x]

2010-03-27 Thread Stuart Brady
kups from tcg_out_qemu_{ld,st}() so that your tracing code is always called. Instead of modifying tcg_out_qemu_{ld,st}(), you might also be able to bypass it entirely, by using having tcg_gen_qemu_{ld,st}*() generate calls to a helper function. Cheers, -- Stuart Brady

Re: [Qemu-devel] Question about memory micro operations in Qemu 0.12.x

2010-03-27 Thread Stuart Brady
On Sat, Mar 27, 2010 at 09:20:51AM +0300, coo...@gmail.com wrote: > My question is : how memory access microoperations are now > implemented in qemu 0.12.x ? We heard you the first time. :-) Cheers, -- Stuart Brady

[Qemu-devel] [PATCH] Clean up definition of MAX_OPC_PARAM

2010-04-27 Thread Stuart Brady
return value. In reality, TBs tend not to consist purely of helper calls exceeding the stated 10 gen_opparam_buf[] entries, so this would never actually be a problem on 32-bit archs, but the definition is still rather confusing. Signed-off-by: Stuart Brady --- diff --git a/exec-all.h b/exec-all.h

Re: [Qemu-devel] Re: [RFC] [PATCH] add ahci support into qemu

2010-05-05 Thread Stuart Brady
ot;. The naming scheme seems > to be VENDOR_DEVICE_FUNCTION, so i suggest something like > PCI_DEVICE_ID_INTEL_ICH6R_2 or PCI_DEVICE_ID_INTEL_82801FR_2. Linux seems to have called this PCI_DEVICE_ID_INTEL_ICH6_4 at one point. So this should be function 4, no? Cheers, -- Stuart Brady

[Qemu-devel] [PATCH] Fix tarbin Makefile rule

2010-05-12 Thread Stuart Brady
l, or otherwise include binaries from previous builds. Fix both problems once and for all by building a list of binaries to include in the tarball, using the list of targets to be built. Signed-off-by: Stuart Brady --- diff --git a/Makefile b/Makefile index eb9e02b..25c825c 100644 --- a/Makefile

Re: [Qemu-devel] Re: [PATCH] Revive -version 'QEMU PC Emulator...'

2010-05-13 Thread Stuart Brady
for the different binaries to produce different output! Cheers, -- Stuart Brady

Re: [Qemu-devel] [RESEND] [PATCH] ide: fix GET_CONFIGURATION DVD-ROM support

2008-01-04 Thread Stuart Brady
me from, anyway? 1433600? Seems it's the number of 512 KiB blocks in a 700 MiB CD image (700 * 1024 * 2). -- Stuart Brady

Re: [Qemu-devel] [RESEND] [PATCH] ide: fix GET_CONFIGURATION DVD-ROM support

2008-01-04 Thread Stuart Brady
On Sat, Jan 05, 2008 at 01:02:30AM +, Stuart Brady wrote: > 1433600? Seems it's the number of 512 KiB blocks in a 700 MiB CD image > (700 * 1024 * 2). Sorry, I mean 512 *byte* blocks. -- Stuart Brady

Re: [Qemu-devel] [RESEND] [PATCH] ide: fix GET_CONFIGURATION DVD-ROM support

2008-01-05 Thread Stuart Brady
's page on CD-Rs describes them, but they were never very popular, and a lot of drives can't read the discs. -- Stuart Brady

Re: [Qemu-devel] [RESEND] [PATCH] ide: fix GET_CONFIGURATION DVD-ROM support

2008-01-06 Thread Stuart Brady
t much to try to guess a better > magic number than the one was originally used (I like 1440000 though) Sorry, but did anyone complain? No. -- Stuart Brady

Re: [Qemu-devel] Qemu future development

2008-01-14 Thread Stuart Brady
net discussion for example: > http://www.pearpc.net/viewtopic.php?f=9&t=5536&p=47395#p47395 I imagine supporting m68k Amigas with PPC accelerator cards might be tricky. I gather the AmigaOne is PPC-only, though? Anyway, AFAIK, when someone produces patches that work, they tend to be applied! :) -- Stuart Brady

[Qemu-devel] @ref commands in man-page

2008-02-04 Thread Stuart Brady
Hi, I've noticed that "@ref{...}" commands aren't handled properly in the qemu man page -- you can see @ref{pcsys_monitor}, @ref{vnc_security} and @ref{pcsys_keys} in the output. I'm not sure what the correct fix for this is -- any thoughts? Cheers, -- Stuart Brady

[Qemu-devel] [PATCH] fix typo in drive_init() (vl.c)

2008-02-04 Thread Stuart Brady
The following patch fixes a typo in drive_init(). Cheers, -- Stuart Brady Index: vl.c === RCS file: /sources/qemu/qemu/vl.c,v retrieving revision 1.403 diff -u -r1.403 vl.c --- vl.c3 Feb 2008 03:45:47 - 1.403

Re: [Qemu-devel] How to extract content of a raw image on host?

2008-02-16 Thread Stuart Brady
On Sat, Feb 16, 2008 at 08:55:06AM +0100, Laurent Vivier wrote: > Loop is not able to manage partition. You could use kpartx (from util-linux), which will create device nodes for each partition. Cheers, -- Stuart Brady

Re: [Qemu-devel] Re: [PATCH, RFC, WIP] TCG for Qemu target Sparc32/64

2008-02-23 Thread Stuart Brady
On Sat, Feb 23, 2008 at 07:23:49PM +0100, Fabrice Bellard wrote: > But do not mix the target specific defines with target independent > defines (in tcg-op.h there is a specific section for target specific > defines). Might it be worth moving that section into a new file? -- Stuart Brady

[Qemu-devel] Questions/comments on TCG

2008-03-07 Thread Stuart Brady
way with assuming that PIC is not used, but I'm wondering if it would be better to avoid that assumption. I will submit patches where I have some idea of what's required, but I do need to be corrected if there's anything I've misunderstood. Cheers, -- Stuart Brady

Re: [Qemu-devel] Questions/comments on TCG

2008-03-07 Thread Stuart Brady
On Fri, Mar 07, 2008 at 06:07:32PM +0200, Blue Swirl wrote: > On 3/7/08, Stuart Brady <[EMAIL PROTECTED]> wrote: > > I do understand that the current SPARC TCG code is preliminary work. > > However, in some ways, I feel it still serves as a better reference than > >

[Qemu-devel] [PATCH] Remove blank elements in tcg_target_reg_alloc_order[]

2008-03-07 Thread Stuart Brady
f the addition of ARRAY_SIZE is at all controversial. I'll happily resubmit the patch with this removed if it's disliked. Cheers, -- Stuart Brady diff -urp qemu-orig/osdep.h qemu-new/osdep.h --- qemu-orig/osdep.h 2008-01-31 19:42:53.0 + +++ qemu-new/osdep.h2

Re: [Qemu-devel] Questions/comments on TCG

2008-03-07 Thread Stuart Brady
On Fri, Mar 07, 2008 at 08:47:03PM +0200, Blue Swirl wrote: > On 3/7/08, Stuart Brady <[EMAIL PROTECTED]> wrote: > > tcg_target_reg_alloc_order[] has 32 elements, but only 14 are used. > > The rest hold 0, specifying TCG_REG_G0. > > I see. That could be asking for tr

[Qemu-devel] [PATCH] TCG README fixes

2008-03-12 Thread Stuart Brady
Hi, The included patch fixes a few glitches in the TCG README file. Please apply. Cheers, -- Stuart Brady diff -urN qemu-orig/tcg/README qemu-new/tcg/README --- qemu-orig/tcg/README2008-02-04 11:21:46.0 + +++ qemu-new/tcg/README 2008-03-12 19:50:19.0 +

Re: [Qemu-devel] Patches?

2008-03-17 Thread Stuart Brady
On Mon, Mar 17, 2008 at 10:42:51AM -0600, C.W. Betts wrote: > The best place to send patches is this mailing list. > I think they have to be a unified diff, i.e. diff -u. I'd also recommend using the '-p' option, which shows the name of the function that each change is in

Re: [Qemu-devel] [PATCH] target-arm: use clz32() instead of a for loop

2009-10-22 Thread Stuart Brady
B[3] = B[4] ^ (B[4] << 8) => 0x00ff00ff B[2] = B[3] ^ (B[3] << 4) => 0x0f0f0f0f B[1] = B[2] ^ (B[2] << 2) => 0x B[0] = B[1] ^ (B[1] << 1) => 0x5555 In reality, I wonder if five separate loads would be quicker, though. Cheers, -- Stuart Brady

Re: [Qemu-devel] [PATCH] target-arm: use clz32() instead of a for loop

2009-10-23 Thread Stuart Brady
On Fri, Oct 23, 2009 at 09:04:53AM +0200, Aurelien Jarno wrote: > Stuart Brady a écrit : > > Just a quick note that the implementation of clz, ctz and popcnt is > > still listed in the TCG TODO list. The last time I looked, I noticed > > that quite a few architectures have

Re: [Qemu-devel] Re: [PATCH] tcg, tci: Add TCG and interpreter for bytecode (virtual machine)

2009-10-26 Thread Stuart Brady
out', though. Perhaps it's best for TCI to reflect the behaviour of other TCG targets where possible? (You can then compare the code that is generated with different numbers of registers, and different constraints, etc.) Cheers, -- Stuart Brady

Re: [Qemu-devel] [PATCH v3 22/25] ay8910: YM2608 core forked from MAME 0.59

2009-10-28 Thread Stuart Brady
On Thu, Oct 29, 2009 at 01:50:11AM +0900, TAKEDA, toshiya wrote: > + > +/* This version of ay8910.c is a fork of the MAME 0.59 one, relicensed under > the LGPL. Where have you taken this from? Cheers, -- Stuart Brady

Re: [Qemu-devel] [PATCH v3 3/25] i386: add private features for a20mask

2009-10-28 Thread Stuart Brady
they follow the rules in the 'developer's certificate of origin': http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=blob;f=Documentation/SubmittingPatches Cheers, -- Stuart Brady

[Qemu-devel] Re: [PATCH v3 22/25] ay8910: YM2608 core forked from MAME 0.59

2009-10-29 Thread Stuart Brady
On Wed, Oct 28, 2009 at 10:55:04PM +0100, Paolo Bonzini wrote: > On 10/28/2009 09:08 PM, Stuart Brady wrote: > >On Thu, Oct 29, 2009 at 01:50:11AM +0900, TAKEDA, toshiya wrote: > >>+ > >>+/* This version of ay8910.c is a fork of the MAME 0.59 one, relicensed > >&

Re: [Qemu-devel] [PATCH] target-arm: tcg temp variable usage cleanup

2009-10-29 Thread Stuart Brady
id gen_vfp_ld(DisasContext *s, int dp, TCGv addr) > { > if (dp) > -tcg_gen_qemu_ld64(cpu_F0d, addr, IS_USER(s)); > +gen_ld64(cpu_F0d, addr, IS_USER(s)); > else > -tcg_gen_qemu_ld32u(cpu_F0s, addr, IS_USER(s)); > +gen_ld32(cpu_F0s, addr, IS_USER(s)); > } Cheers, -- Stuart Brady

Re: [Qemu-devel] FDC and M48T59 save/reset methods

2007-04-14 Thread Stuart Brady
for which the alarm and watchdog timers are not created. -- Stuart Brady

[Qemu-devel] 16-bit (and 8-bit) emulation

2007-04-15 Thread Stuart Brady
ne, with some success. The one thing that I'm not really sure about is bank switching (although I think I can just call cpu_register_physical_memory()). HTH, -- Stuart Brady

Re: [Qemu-devel] qemu and debian-4.0r0-linux?

2007-04-27 Thread Stuart Brady
.e. which CD image? What version of QEMU are you using? 0.9.0? Or are you using CVS? Could you describe the failure at all? (Any console output would help.) Thanks. -- Stuart Brady

Re: [Qemu-devel] what does vl mean in vl.c?

2007-05-11 Thread Stuart Brady
vl.c?rev=1.1&root=qemu&view=markup See the help() function. -- Stuart Brady

Re: [Qemu-devel] qemu/hw pixel_ops.h

2007-06-10 Thread Stuart Brady
conceivable that moving these functions out of vga_template.h would be useful to others at some point, so I'd be happy to submit a patch for this. (It would have to be #includable from vga.c or vga_template.h, so obviously this can't go in pixel_ops.h.) -- Stuart Brady [1] That's one d*mn fast Speccy, btw. :-)

Re: [Qemu-devel] [PATCH] Fix two typos

2007-07-02 Thread Stuart Brady
On Sat, Jun 23, 2007 at 11:01:00PM +0200, Stefan Weil wrote: > Here is one more "formating" patch. I've found a whole load of misspellings that I could submit patches for, but I've been waiting until Stefan's fixes are committed. Could they be applied, please? Cheers, -- Stuart Brady

[Qemu-devel] [PATCH] Fix a typo

2007-07-03 Thread Stuart Brady
Hi, The patch below fixes the spelling of 'overridden' in several places. Please apply. Cheers, -- Stuart Brady Index: audio/alsaaudio.c === RCS file: /sources/qemu/qemu/audio/alsaaudio.c,v retrieving revision 1.9 diff -

[Qemu-devel] More misspellings

2007-07-17 Thread Stuart Brady
e trivial to fix. Thanks, -- Stuart Brady accordin, addresss, amounnt, an a, apear, arbitary, arbritration, asynchrnonous, autio, begining, choosen, completly, compliation, confition, decrememnted, defering, dependancy, desciptor, dirst, disconect, enought, enoutered, epilog, exeption, existant, exp

Re: [Qemu-devel] Linux KDE vs. Windows

2007-07-24 Thread Stuart Brady
hronological order: alpha, ia64, amd64. ;-) What about mips and ppc, then? ;-) (And if you count wince, there's also arm and sh...) -- Stuart Brady

Re: [Qemu-devel] Questions on "hidden" functions in QEMU source code

2007-10-16 Thread Stuart Brady
resumably so that attributes can be defined later if they're needed. Cheers, -- Stuart Brady

Re: [Qemu-devel] handling SIGWINCH with qemu -nographic

2007-10-16 Thread Stuart Brady
as on the terminal (minicom/tip/qemu -nographic/whatever). While this would be a nice feature (and support for propagating the TERM, LANG and LC_* variables might be nice, too), I'm doubtful as to whether this will ever happen. -- Stuart Brady

Re: [Qemu-devel] qemu Makefile.target vl.h hw/cuda.c hw/grackle_...

2007-10-28 Thread Stuart Brady
On Sun, Oct 28, 2007 at 11:42:18PM +, Jocelyn Mayer wrote: > * Fix the g3bw target: >- fix the Grackle host PCI device >- connect the Heathrow PIC to the PowerPC 6xx bus pins Cool! With this, the Debian 3.1 install CD boots again! :) -- Stuart Brady

[Qemu-devel] Typo in get_reloc_expr (dyngen.c)

2006-06-05 Thread Stuart Brady
tached the (one-line) patch. -- Stuart Brady [0] http://homepage.ntlworld.com/wholehog/stuart/qemu/guest.html diff -ur qemu-head/dyngen.c qemu-new/dyngen.c --- qemu-head/dyngen.c 2006-06-05 14:37:00.0 +0100 +++ qemu-new/dyngen.c 2006-06-05 14:36:49.0 +0100 @@ -1196,7 +1196,7 @@

Re: [Qemu-devel] qemu Makefile qemu-doc.texi hw/sun4m.c hw/sun4u...

2006-06-14 Thread Stuart Brady
ses OpenBIOS > [EMAIL PROTECTED]://www.openbios.org/}. OpenBIOS is a free (GPL v2) portable > +firmware implementation. The goal is to implement a 100% IEEE > +1275-1994 (referred to as Open Firmware) compliant firmware. Shouldn't that be 0.8.2?

Re: [Qemu-devel] VMware Player

2006-06-16 Thread Stuart Brady
gets... I think it would be best if QEMU didn't depend on any particular toolkit, and that includes WxWidgets. -- Stuart Brady ___ Qemu-devel mailing list Qemu-devel@nongnu.org http://lists.nongnu.org/mailman/listinfo/qemu-devel

Re: [Qemu-devel] qemu kbd emulation

2006-06-28 Thread Stuart Brady
ooks: > > 224 42 224 72 224 200 224 170. (e0 2a e0 48 e0 c8 e0 aa) FWIW, 2a is the left shift key. See http://www.win.tue.nl/~aeb/linux/kbd/scancodes.html -- Stuart Brady ___ Qemu-devel mailing list Qemu-devel@nongnu.org http://lists.nongn

Re: [Qemu-devel] qemu kbd emulation

2006-06-28 Thread Stuart Brady
kbd_put_keycode(2a); > + } > + break; > } As I suspected, this is the "fake shift" sequence. It's should also be needed for the insert, delete, home, end, page up and page down keys. Note that fake shifts shouldn't

Re: [Qemu-devel] qemu kbd emulation

2006-06-28 Thread Stuart Brady
e keycodes from set 1 to set 2, and they get converted back to set 1 elsewhere. Maybe that's where the bug is? -- Stuart Brady ___ Qemu-devel mailing list Qemu-devel@nongnu.org http://lists.nongnu.org/mailman/listinfo/qemu-devel

Re: [Qemu-devel] Re: qemu-system-sparc video problem on 16 bitdisplays

2006-09-11 Thread Stuart Brady
On Fri, Sep 08, 2006 at 09:26:52PM +0200, Blue Swirl wrote: > Implementing full audio support for CS4231 would not be too difficult. Is > this chip used anywhere else? The data sheet mentions some ISA card and > Windows 3.1. The "Windows Sound System" cards apparently used i

[Qemu-devel] Possible regression for Heathrow (PPC), with workaround

2007-01-15 Thread Stuart Brady
c_set_irq(pic, irq_num + 8, level); +/* XXX: Workaround */ +heathrow_pic_set_irq(pic, irq_num, level); } PCIBus *pci_grackle_init(uint32_t base, void *pic) Cheers, -- Stuart Brady ___ Qemu-devel mailing list Qemu-devel@nongnu.org http:

[Qemu-devel] [PATCH] qemu-img: fix incorrect error message

2007-02-08 Thread Stuart Brady
Hi, qemu-img convert produces an incorrect error message if an unknown file format is requested for the output image. "qemu-img convert -f raw in.img -O snafu out.img" produces: qemu-img: Unknown file format 'raw' The attached patch fixes this. -- Stuart Bra

Re: [Qemu-devel] [PATCH] don't require a disk image for network boot

2007-02-13 Thread Stuart Brady
On Tue, Feb 13, 2007 at 03:58:13PM +0100, andrzej zaborowski wrote: > What do you think about the following patch? As a side note, I'd > really prefer option roms with serial output enabled (check > CONSOLE_DUAL on rom-o-matic). Maybe even uncheck ASK_BOOT... Hmm, > maybe that's already done, I

[Qemu-devel] [PATCH] allow shift-pageup and shift-pagedown for scrolling in text consoles

2007-02-13 Thread Stuart Brady
arate QEMU_KEY_SHIFT_PAGEUP and QEMU_KEY_SHIFT_PAGEDOWN, but I'm not sure if I should have renamed QEMU_KEY_CTRL_PAGEUP and QEMU_KEY_CTRL_PAGEDOWN instead. It also fixes a minor fomatting problem in the same code. Does it look okay? Cheers, -- Stuart Brady Index:

Re: [Qemu-devel] [PATCH] pcnet32 driver change, please test

2007-03-02 Thread Stuart Brady
"Error while running 'modprobe -v sunlance'". ISTR that if I use the netinstall iso and persist with the installation, Lance works after the reboot. This problem doesn't seem to affect Etch.) Thanks, -- Stuart Brady ___ Qemu-

Re: [Qemu-devel] qemu vl.c vl.h hw/integratorcp.c hw/mips_malta....

2007-03-07 Thread Stuart Brady
e use 'file' as floppy disk 0/1 image\n" "-hda/-hdb file use 'file' as IDE hard disk 0/1 image\n" "-hdc/-hdd file use 'file' as IDE hard disk 2/3 image\n" Cheers, -- Stuart Brady ___ Qemu-devel mailing list Qemu-devel@nongnu.org http://lists.nongnu.org/mailman/listinfo/qemu-devel

Re: [Qemu-devel] qemu cpu-all.h gdbstub.c monitor.c hw/ppc.c lin...

2007-03-07 Thread Stuart Brady
-2.4.27.001 -g 640x480 After this commit, user-mode networking no longer works. DHCP does seem to work and I can telnet to ports on 10.0.2.2, but I can't do any DNS lookups or connect to anything else. I will try to investigate further. Thanks, -- Stuart Brady _

  1   2   >