Re: [Qemu-devel] [PATCH 1/4] introduce virtqueue_unmap_sg

2014-11-25 Thread Stefano Stabellini
On Tue, 25 Nov 2014, Peter Maydell wrote: > On 25 November 2014 at 14:43, Stefano Stabellini > wrote: > > Introduce a function to unmap an sg previously mapped with > > virtqueue_map_sg. > > > > Signed-off-by: Stefano Stabellini > > CC: jasow...@redhat.com &g

[Qemu-devel] [PATCH] increase maxmem before calling xc_domain_populate_physmap

2014-11-25 Thread Stefano Stabellini
: Stefano Stabellini diff --git a/xen-hvm.c b/xen-hvm.c index 5c69a8d..38e08c3 100644 --- a/xen-hvm.c +++ b/xen-hvm.c @@ -218,6 +218,7 @@ void xen_ram_alloc(ram_addr_t ram_addr, ram_addr_t size, MemoryRegion *mr) unsigned long nr_pfn; xen_pfn_t *pfn_list; int i; +xc_dominfo_t info

Re: [Qemu-devel] [Xen-devel] virtio leaks cpu mappings, was: qemu crash with virtio on Xen domUs (backtrace included)

2014-11-26 Thread Stefano Stabellini
On Wed, 26 Nov 2014, Jason Wang wrote: > On 11/25/2014 09:53 PM, Stefano Stabellini wrote: > > On Tue, 25 Nov 2014, Jason Wang wrote: > >> On 11/25/2014 02:44 AM, Stefano Stabellini wrote: > >>> On Mon, 24 Nov 2014, Stefano Stabellini wrote: > >>>>

Re: [Qemu-devel] [Xen-devel] [PATCH] increase maxmem before calling xc_domain_populate_physmap

2014-11-26 Thread Stefano Stabellini
On Tue, 25 Nov 2014, Andrew Cooper wrote: > On 25/11/14 17:45, Stefano Stabellini wrote: > > Increase maxmem before calling xc_domain_populate_physmap_exact to avoid > > the risk of running out of guest memory. This way we can also avoid > > complex memory calculatio

Re: [Qemu-devel] [2.2 PATCH V2] virtio-net: fix unmap leak

2014-11-27 Thread Stefano Stabellini
uched and using a temp variable > in those functions. > > Cc: Wen Congyang > Cc: Stefano Stabellini > Cc: qemu-sta...@nongnu.org > Signed-off-by: Jason Wang Reviewed-by: Stefano Stabellini > Changes from V1: > - Use g_memdup() to simplify codes > --- > hw/ne

Re: [Qemu-devel] [Xen-devel] [PATCH] increase maxmem before calling xc_domain_populate_physmap

2014-11-27 Thread Stefano Stabellini
On Wed, 26 Nov 2014, Don Slutz wrote: > On 11/26/14 13:17, Stefano Stabellini wrote: > > On Tue, 25 Nov 2014, Andrew Cooper wrote: > > > On 25/11/14 17:45, Stefano Stabellini wrote: > > > > Increase maxmem before calling xc_domain_populate_physmap_exact to avoid >

Re: [Qemu-devel] [2.2 PATCH V2 for-4.5] virtio-net: fix unmap leak

2014-11-27 Thread Stefano Stabellini
and using a temp variable > >> in those functions. > >> > >> Cc: Wen Congyang > >> Cc: Stefano Stabellini > >> Cc: qemu-sta...@nongnu.org > >> Signed-off-by: Jason Wang > > > > Reviewed-by: Michael S. Tsirkin > > > >

Re: [Qemu-devel] [2.2 PATCH V2] virtio-net: fix unmap leak

2014-11-27 Thread Stefano Stabellini
ctions that process control vq > >>> request call iov_discard_front() which will shorten the iov. This will > >>> lead unmapping in virtqueue_push() leaks mapping. > >>> > >>> Fixes this by keeping the original iov untouched and using a temp vari

Re: [Qemu-devel] [2.2 PATCH V2 for-4.5] virtio-net: fix unmap leak

2014-11-27 Thread Stefano Stabellini
On Thu, 27 Nov 2014, Konrad Rzeszutek Wilk wrote: > On Nov 27, 2014 7:46 AM, Stefano Stabellini > wrote: > > > > Konrad, I think we should have this fix in 4.5: without it > > vif=[ 'model=virtio-net' ] crashes QEMU. > > > > Is it an regressio

Re: [Qemu-devel] [2.2 PATCH V2 for-4.5] virtio-net: fix unmap leak

2014-11-27 Thread Stefano Stabellini
On Thu, 27 Nov 2014, Konrad Rzeszutek Wilk wrote: > On Nov 27, 2014 9:58 AM, Stefano Stabellini > wrote: > > > > On Thu, 27 Nov 2014, Konrad Rzeszutek Wilk wrote: > > > On Nov 27, 2014 7:46 AM, Stefano Stabellini > > > wrote: > > > > > &

Re: [Qemu-devel] [2.2 PATCH V2 for-4.5] virtio-net: fix unmap leak

2014-11-27 Thread Stefano Stabellini
On Thu, 27 Nov 2014, Konrad Rzeszutek Wilk wrote: > On Nov 27, 2014 10:26 AM, Stefano Stabellini > wrote: > > > > On Thu, 27 Nov 2014, Konrad Rzeszutek Wilk wrote: > > > On Nov 27, 2014 9:58 AM, Stefano Stabellini > > > wrote: > > > > > >

[Qemu-devel] [for 4.5] missing chunk in 11dffa2359e8a2629490c14c029c7c7c777b3e47

2014-11-27 Thread Stefano Stabellini
On Mon, 7 Jul 2014, Chunyan Liu wrote: > diff --git a/tools/libxl/libxl_dm.c b/tools/libxl/libxl_dm.c > index addacdb..4f1cbd2 100644 > --- a/tools/libxl/libxl_dm.c > +++ b/tools/libxl/libxl_dm.c > @@ -479,6 +485,15 @@ static char ** > libxl__build_device_model_args_new(libxl__gc *gc, > if (b

Re: [Qemu-devel] [Xen-devel] [PATCH] increase maxmem before calling xc_domain_populate_physmap

2014-12-01 Thread Stefano Stabellini
On Mon, 1 Dec 2014, Don Slutz wrote: > On 11/27/14 05:48, Stefano Stabellini wrote: > > On Wed, 26 Nov 2014, Don Slutz wrote: > > > On 11/26/14 13:17, Stefano Stabellini wrote: > > > > On Tue, 25 Nov 2014, Andrew Cooper wrote: > > > > >

Re: [Qemu-devel] [Xen-devel] [PATCH] increase maxmem before calling xc_domain_populate_physmap

2014-12-02 Thread Stefano Stabellini
On Mon, 1 Dec 2014, Don Slutz wrote: > On 12/01/14 10:37, Stefano Stabellini wrote: > > On Mon, 1 Dec 2014, Don Slutz wrote: > > > On 11/27/14 05:48, Stefano Stabellini wrote: > > [...] > > > > > > > Works fine in both claim modes and with PoD used

Re: [Qemu-devel] [Xen-devel] [PATCH] increase maxmem before calling xc_domain_populate_physmap

2014-12-03 Thread Stefano Stabellini
On Wed, 3 Dec 2014, Wei Liu wrote: > On Tue, Dec 02, 2014 at 03:23:29PM -0500, Don Slutz wrote: > [...] > > hw_error("xc_domain_getinfo failed"); > > } > > -if (xc_domain_setmaxmem(xen_xc, xen_domid, info.max_memkb + > > -(nr_pfn * X

Re: [Qemu-devel] [PATCH v4 REPOST 1/2] Add device listener interface

2014-12-03 Thread Stefano Stabellini
The second patch is already Acked. You just need a review on this one to move forward, right? Andreas, Michael? On Wed, 3 Dec 2014, Paul Durrant wrote: > The Xen ioreq-server API, introduced in Xen 4.5, requires that PCI device > models explicitly register with Xen for config space accesses. This

Re: [Qemu-devel] [Xen-devel] [PATCH] increase maxmem before calling xc_domain_populate_physmap

2014-12-03 Thread Stefano Stabellini
On Wed, 3 Dec 2014, Don Slutz wrote: > On 12/03/14 07:20, Stefano Stabellini wrote: > > On Wed, 3 Dec 2014, Wei Liu wrote: > > > On Tue, Dec 02, 2014 at 03:23:29PM -0500, Don Slutz wrote: > > > [...] > > > > > > >

Re: [Qemu-devel] Regression: qemu crash of hvm domUs with spice (backtrace included)

2015-04-21 Thread Stefano Stabellini
On Mon, 20 Apr 2015, Fabio Fantoni wrote: > I updated xen and qemu from xen 4.5.0 with its upstream qemu included to xen > 4.5.1-pre with qemu upstream from stable-4.5 (changed Config.mk to use > revision "master"). > After few minutes I booted windows 7 64 bit domU qemu crash, tried 2 times > with

Re: [Qemu-devel] Regression: qemu crash of hvm domUs with spice (backtrace included)

2015-04-21 Thread Stefano Stabellini
On Tue, 21 Apr 2015, Fabio Fantoni wrote: > Il 21/04/2015 12:49, Stefano Stabellini ha scritto: > > On Mon, 20 Apr 2015, Fabio Fantoni wrote: > > > I updated xen and qemu from xen 4.5.0 with its upstream qemu included to > > > xen > > > 4.5.1-pre with qe

Re: [Qemu-devel] [PATCH] Do not emulate a floppy drive when -nodefaults

2015-05-14 Thread Stefano Stabellini
On Wed, 13 May 2015, John Snow wrote: > On 05/13/2015 02:15 PM, Stefano Stabellini wrote: > > On Wed, 13 May 2015, Daniel P. Berrange wrote: > >> On Wed, May 13, 2015 at 06:29:46PM +0100, Stefano Stabellini wrote: > >>> Do not emulate a floppy drive if no dri

Re: [Qemu-devel] [Xen-devel] [PATCH] Do not emulate a floppy drive when -nodefaults

2015-05-14 Thread Stefano Stabellini
On Thu, 14 May 2015, Paolo Bonzini wrote: > On 14/05/2015 15:25, Sander Eikelenboom wrote: > > I tend to kindly disagree if you look at the broader perspective, yes it's > > could > > be a storm in a tea cup, but there seems to be a pattern. > > > > From a "cmdline user" / "platform emulation" p

[Qemu-devel] [PATCH] Add a property to disable the floppy controller

2015-05-14 Thread Stefano Stabellini
Do not change default settings for any machines at the moment: this patch does not introduce any changes in behavior unless the user asks for no-fdc=on. Signed-off-by: Stefano Stabellini --- hw/i386/pc.c | 27 --- include/hw/i386/pc.h |2 ++ vl.c

Re: [Qemu-devel] [Xen-devel] [PATCH] Do not emulate a floppy drive when -nodefaults

2015-05-14 Thread Stefano Stabellini
On Thu, 14 May 2015, Paolo Bonzini wrote: > On 14/05/2015 16:39, Stefano Stabellini wrote: > > On Thu, 14 May 2015, Paolo Bonzini wrote: > >> On 14/05/2015 15:25, Sander Eikelenboom wrote: > >>> I tend to kindly disagree if you look at the broader perspective, yes

Re: [Qemu-devel] [PATCH] Do not emulate a floppy drive when -nodefaults

2015-05-15 Thread Stefano Stabellini
On Fri, 15 May 2015, Paolo Bonzini wrote: > On 15/05/2015 09:50, Markus Armbruster wrote: > > > --nodefaults must continue to disable all optional parts of the board. > > > > What exactly is optional is for the board / machine type to define. It > > can't be changed once the machine type is rele

Re: [Qemu-devel] Regression: qemu crash of hvm domUs with spice (backtrace included)

2015-05-15 Thread Stefano Stabellini
On Wed, 13 May 2015, Fabio Fantoni wrote: > Il 12/05/2015 16:44, Stefano Stabellini ha scritto: > > On Tue, 12 May 2015, Stefano Stabellini wrote: > > > On Tue, 12 May 2015, Fabio Fantoni wrote: > > > > Il 12/05/2015 12:26, Fabio Fantoni ha scritto: > > > &g

Re: [Qemu-devel] old (but unfixed in our clones) qemu security issues?

2015-03-02 Thread Stefano Stabellini
CC'ing qemu-devel On Mon, 2 Mar 2015, Jan Beulich wrote: > Stefano, > > apart from having been curious for a while why we carry a fix for > CVE-2013-4540 in our 4.4.1 based tree, patches for CVE-2014-3615 > appeared there too recently. What is the maintenance state of the > stable qemu upstream t

Re: [Qemu-devel] old (but unfixed in our clones) qemu security issues?

2015-03-02 Thread Stefano Stabellini
On Mon, 2 Mar 2015, Jan Beulich wrote: > >>> On 02.03.15 at 15:05, wrote: > > I guess I could monitor cve.mitre.org or the QEMU stable tree for > > commits with "CVE" in the commit message, but there isn't much else I > > can do. > > Yes, I think the latter is (for the time being) the most promis

Re: [Qemu-devel] backport c1d322e6048796296555dd36fdd102d7fa2f50bf to all stable trees

2015-03-02 Thread Stefano Stabellini
ping? On Thu, 26 Feb 2015, Stefano Stabellini wrote: > Hi all, > > I would like to request a backport of > > commit c1d322e6048796296555dd36fdd102d7fa2f50bf > Author: Stefano Stabellini > Date: Wed Dec 3 08:15:19 2014 -0500 > > xen-hvm: inc

Re: [Qemu-devel] [PATCH RFC] Makefile.target: prepend $libs_softmmu to $LIBS

2015-03-09 Thread Stefano Stabellini
On Mon, 9 Mar 2015, Wei Liu wrote: > On Tue, Mar 10, 2015 at 12:11:44AM +0900, Peter Maydell wrote: > > On 9 March 2015 at 23:54, Wei Liu wrote: > > > I discovered a problem when trying to build QEMU statically with gcc. > > > libm is an element of LIBS while libpixman-1 is an element in > > > lib

[Qemu-devel] several security backports to the qemu-xen stable trees

2015-03-13 Thread Stefano Stabellini
Hi all, I am writing to let you know that have pushed a long series of backports to qemu-xen 4.2, 4.3, 4.4 and 4.5 stable staging trees. See below. All the backports are security fixes of outstanding CVEs affecting QEMU. As QEMU only provides backports to very recent stable releases, I had to com

Re: [Qemu-devel] [PATCH RFC v1 1/2] xen/hw/passthrough: Use errno instead of ret for xc_physdev_map_* calls

2015-03-16 Thread Stefano Stabellini
On Fri, 13 Mar 2015, Konrad Rzeszutek Wilk wrote: > As the libxc library follows (mostly) the return negative > for failure and stashes the error value in errno. > > Signed-off-by: Konrad Rzeszutek Wilk Acked-by: Stefano Stabellini I'll add it to my queue > hw/

Re: [Qemu-devel] [PATCH RFC v1 2/2] xen-hvm: When using xc_domain_add_to_physmap also include errno when reporting

2015-03-16 Thread Stefano Stabellini
On Fri, 13 Mar 2015, Konrad Rzeszutek Wilk wrote: > .errors - as it will most likely have the proper error value. > > Signed-off-by: Konrad Rzeszutek Wilk Acked-by: Stefano Stabellini > xen-hvm.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --

Re: [Qemu-devel] [PATCH v2 1/3] xen: fix usage of ENODATA

2014-05-27 Thread Stefano Stabellini
instead of the value > returned by the function. > > Signed-off-by: Roger Pau Monné > Cc: xen-de...@lists.xenproject.org > Cc: Stefano Stabellini > Cc: Anthony Perard > --- > Changes since v1: > - Define ENODATA to ENOENT for platforms that don't have ENODATA. >

Re: [Qemu-devel] [v3][PATCH 5/5] xen, gfx passthrough: add opregion mapping

2014-05-27 Thread Stefano Stabellini
On Mon, 26 May 2014, Tiejun Chen wrote: > The OpRegion shouldn't be mapped 1:1 because the address in the host > can't be used in the guest directly. > > This patch traps read and write access to the opregion of the Intel > GPU config space (offset 0xfc). > > The original patch is from Jean Guyad

Re: [Qemu-devel] [v3][PATCH 1/5] xen, gfx passthrough: basic graphics passthrough support

2014-05-27 Thread Stefano Stabellini
On Mon, 26 May 2014, Tiejun Chen wrote: > basic gfx passthrough support: > - add a vga type for gfx passthrough > - retrieve VGA bios from sysfs, then load it to guest 0xC > - register/unregister legacy VGA I/O ports and MMIOs for passthroughed gfx > > The original patch is from Weidong Han >

Re: [Qemu-devel] [Xen-devel] [v3][PATCH 2/5] xen, gfx passthrough: create intel isa bridge

2014-05-27 Thread Stefano Stabellini
On Tue, 27 May 2014, Konrad Rzeszutek Wilk wrote: > On Mon, May 26, 2014 at 05:43:06PM +0800, Tiejun Chen wrote: > > ISA bridge is needed since Intel gfx drive will probe it instead > > of Dev31:Fun0 to make graphics device passthrough work easy for VMM, that > > only need to expose ISA bridge to l

Re: [Qemu-devel] [v3][PATCH 3/5] xen, gfx passthrough: support Intel IGD passthrough with VT-D

2014-05-27 Thread Stefano Stabellini
On Mon, 26 May 2014, Tiejun Chen wrote: > Some registers of Intel IGD are mapped in host bridge, so it needs to > passthrough these registers of physical host bridge to guest because > emulated host bridge in guest doesn't have these mappings. > > The original patch is from Weidong Han < weidong.h

Re: [Qemu-devel] [v3][PATCH 4/5] xen, gfx passthrough: create host bridge to passthrough

2014-05-27 Thread Stefano Stabellini
On Mon, 26 May 2014, Tiejun Chen wrote: > Implement that pci host bridge to specific to passthrough. Actually > thsi just inherit the standard one. > > Signed-off-by: Tiejun Chen > --- > v3: > > * Just fix this patch head description typo. > > v2: > > * New patch. > > hw/pci-host/piix.c | 56

Re: [Qemu-devel] [PATCH v2 1/3] xen: fix usage of ENODATA

2014-05-28 Thread Stefano Stabellini
On Tue, 27 May 2014, Roger Pau Monné wrote: > On 27/05/14 18:18, Stefano Stabellini wrote: > > On Fri, 23 May 2014, Roger Pau Monne wrote: > >> ENODATA doesn't exist on FreeBSD, so ENODATA errors returned by the > >> hypervisor are translated to ENOENT. > >&

Re: [Qemu-devel] [v3][PATCH 5/5] xen, gfx passthrough: add opregion mapping

2014-05-28 Thread Stefano Stabellini
On Wed, 28 May 2014, Chen, Tiejun wrote: > > -Original Message- > > From: Stefano Stabellini [mailto:stefano.stabell...@eu.citrix.com] > > Sent: Wednesday, May 28, 2014 1:36 AM > > To: Chen, Tiejun > > Cc: anthony.per...@citrix.com; stefano.stabell...@eu.c

Re: [Qemu-devel] [v3][PATCH 3/5] xen, gfx passthrough: support Intel IGD passthrough with VT-D

2014-05-28 Thread Stefano Stabellini
On Wed, 28 May 2014, Chen, Tiejun wrote: > > -Original Message- > > From: Stefano Stabellini [mailto:stefano.stabell...@eu.citrix.com] > > Sent: Wednesday, May 28, 2014 2:02 AM > > To: Chen, Tiejun > > Cc: anthony.per...@citrix.com; stefano.stabell...@eu.c

Re: [Qemu-devel] [Xen-devel] [PATCH] libxl: change default QEMU machine to pc-i440fx-1.6

2014-05-28 Thread Stefano Stabellini
On Wed, 28 May 2014, Fabio Fantoni wrote: > Il 26/05/2014 10:00, Fabio Fantoni ha scritto: > > Il 25/05/2014 16:14, Stefano Stabellini ha scritto: > > > On Fri, 23 May 2014, Fabio Fantoni wrote: > > > > Il 23/05/2014 18:07, Stefano Stabellini ha scritto: > > &

Re: [Qemu-devel] [Xen-devel] [PATCH] libxl: change default QEMU machine to pc-i440fx-1.6

2014-05-28 Thread Stefano Stabellini
On Wed, 28 May 2014, Stefano Stabellini wrote: > On Wed, 28 May 2014, Fabio Fantoni wrote: > > Il 26/05/2014 10:00, Fabio Fantoni ha scritto: > > > Il 25/05/2014 16:14, Stefano Stabellini ha scritto: > > > > On Fri, 23 May 2014, Fabio Fantoni wrote: > >

Re: [Qemu-devel] [v4][PATCH 4/5] xen, gfx passthrough: create host bridge to passthrough

2014-06-02 Thread Stefano Stabellini
On Fri, 30 May 2014, Tiejun Chen wrote: > Implement that pci host bridge to specific to passthrough. Actually > this just inherit the standard one. > > Signed-off-by: Tiejun Chen Reviewed-by: Stefano Stabellini > v4: > > * Fix one typo in the patch head description.

Re: [Qemu-devel] [v4][PATCH 5/5] xen, gfx passthrough: add opregion mapping

2014-06-02 Thread Stefano Stabellini
The original patch is from Jean Guyader > > Signed-off-by: Yang Zhang > Signed-off-by: Tiejun Chen > Cc: Jean Guyader Reviewed-by: Stefano Stabellini > v4: > > * Nothing is changed. > > v3: > > * Fix some typos. > * Add more comments to make that readable

Re: [Qemu-devel] [v4][PATCH 0/5] xen: add Intel IGD passthrough support

2014-06-02 Thread Stefano Stabellini
The patch series is OK from my point of view. I would appreciate if Paolo or Peter could give their feedback on patch #1 and patch #4 as they modify non-Xen specific files. If you are OK with the patches, I'll send a pull request. On Fri, 30 May 2014, Tiejun Chen wrote: > v4: > > * Fix some t

Re: [Qemu-devel] [Xen-devel] [RFC PATCH 0/2] support xen HVM direct kernel boot

2014-06-02 Thread Stefano Stabellini
On Fri, 30 May 2014, Konrad Rzeszutek Wilk wrote: > On Thu, May 29, 2014 at 11:23:22AM +0800, Chunyan Liu wrote: > > Following previous discussion: > > https://lists.gnu.org/archive/html/qemu-devel/2014-04/msg03843.html > > > > I spent lot of time to understand xen xc_hvm_build, hvmloader code, >

Re: [Qemu-devel] [v4][PATCH 3/5] xen, gfx passthrough: support Intel IGD passthrough with VT-D

2014-06-02 Thread Stefano Stabellini
is from Weidong Han < weidong.han @ intel.com > > > Signed-off-by: Yang Zhang > Signed-off-by: Tiejun Chen > Cc: Weidong Han Reviewed-by: Stefano Stabellini > v4: > > * Given that pci_create_pch() is called unconditionally, so we just return 0 > even if its failed to c

Re: [Qemu-devel] [v4][PATCH 2/5] xen, gfx passthrough: create intel isa bridge

2014-06-02 Thread Stefano Stabellini
original patch is from Allen Kay [allen.m@intel.com] > > Signed-off-by: Yang Zhang > Signed-off-by: Tiejun Chen > Cc: Allen Kay Reviewed-by: Stefano Stabellini > v4: > > * Remove some unnecessary "return" in void foo(). > > v3: > > * Fix some

Re: [Qemu-devel] [v4][PATCH 1/5] xen, gfx passthrough: basic graphics passthrough support

2014-06-02 Thread Stefano Stabellini
s from Weidong Han > > Signed-off-by: Yang Zhang > Signed-off-by: Tiejun Chen > Cc: Weidong Han Reviewed-by: Stefano Stabellini > v4: > > * Fix some typos in the patch head description. > * Improve some comments. > * Given that xen_pt_register_vga_regions()/x

Re: [Qemu-devel] [v4][PATCH 2/5] xen, gfx passthrough: create intel isa bridge

2014-06-03 Thread Stefano Stabellini
On Tue, 3 Jun 2014, Paolo Bonzini wrote: > Il 30/05/2014 10:59, Tiejun Chen ha scritto: > > +static int create_pch_isa_bridge(PCIBus *bus, XenHostPCIDevice *hdev) > > +{ > > +struct PCIDevice *dev; > > + > > +char rid; > > + > > +dev = pci_create(bus, PCI_DEVFN(0x1f, 0), "intel-pch-isa-

Re: [Qemu-devel] [Xen-devel] [RFC PATCH 0/2] support xen HVM direct kernel boot

2014-06-03 Thread Stefano Stabellini
On Tue, 3 Jun 2014, Ian Campbell wrote: > On Tue, 2014-06-03 at 03:16 -0600, Chun Yan Liu wrote: > > > > >>> On 6/2/2014 at 11:14 PM, in message > > , Stefano > > Stabellini wrote: > > > On Fri, 30 May 2014, Konrad Rzeszutek Wilk wrote: > > &g

Re: [Qemu-devel] [v4][PATCH 2/5] xen, gfx passthrough: create intel isa bridge

2014-06-03 Thread Stefano Stabellini
On Tue, 3 Jun 2014, Paolo Bonzini wrote: > Il 03/06/2014 13:29, Stefano Stabellini ha scritto: > > > It's really not your fault, there's not much you can do given the hardware > > > architecture. But I don't think this code can be accepted upstream, > &g

Re: [Qemu-devel] [PATCH] libxl: change default QEMU machine to pc-i440fx-1.6

2014-06-03 Thread Stefano Stabellini
On Wed, 28 May 2014, Paolo Bonzini wrote: > Il 28/05/2014 18:41, Stefano Stabellini ha scritto: > > However it would still place xen-platform at slot 3 instead of slot 2 if > > soundhw is specified. It seems to me that there is not a perfect > > solution to this pr

Re: [Qemu-devel] [PATCH v4 3/3] xen-hvm: Pass is_default to xen_hvm_init

2014-06-06 Thread Stefano Stabellini
On Thu, 5 Jun 2014, Don Slutz wrote: > This is the xen part of "pc & q35: Add new machine opt max-ram-below-4g" > > Signed-off-by: Don Slutz Acked-by: Stefano Stabellini > v4: > Pass is_default instead of max_ram_below_4g. > Also did not add "Ack

Re: [Qemu-devel] [Xen-devel] [PULL 0/19] xen-2015-09-08-tag

2015-09-28 Thread Stefano Stabellini
: > On 9/22/2015 12:03 AM, Stefano Stabellini wrote: > > It is going to be in QEMU 2.5 and qemu-xen 4.7. > > Thanks for your reply. > > Do we have any possibility of just merging this series into qemu-xen 4.6? We > really want to support IGD passthrough on xen 4.6 if possible

Re: [Qemu-devel] [Xen-devel] [PULL 0/19] xen-2015-09-08-tag

2015-09-29 Thread Stefano Stabellini
On Mon, 28 Sep 2015, Pasi Kärkkäinen wrote: > Hi, > > On Mon, Sep 28, 2015 at 11:01:11AM +0100, Stefano Stabellini wrote: > > No, unfortunately it is not possible at this stage of the release cycle. > > But users can still use QEMU 2.5 (as soon as it is released, which >

Re: [Qemu-devel] [PATCH 0/2] xen: Fix crash of "-machine xenfv, accel=kvm"

2015-09-30 Thread Stefano Stabellini
On Mon, 28 Sep 2015, Eduardo Habkost wrote: > This series fixes the following crash: > > $ ./x86_64-softmmu/qemu-system-x86_64 -machine xenfv,accel=kvm > Segmentation fault (core dumped) > > The crash happens because xen-platform calls xc_hvm_set_mem_type() with a NULL > xen_xc on reset, at p

Re: [Qemu-devel] [PATCH 2/2] xen-platform: Ensure xen is enabled when initializing

2015-09-30 Thread Stefano Stabellini
gered by the user because the device is not > hotpluggable, and the only code creating it (at pc_xen_hvm_init()) > already checks xen_enabled(). > > Signed-off-by: Eduardo Habkost Reviewed-by: Stefano Stabellini > hw/i386/xen/xen_platform.c | 3 +++ > 1 file changed, 3

Re: [Qemu-devel] [PATCH 1/2] pc: Require xen when initializing xenfv machine

2015-09-30 Thread Stefano Stabellini
On Mon, 28 Sep 2015, Eduardo Habkost wrote: > Without this check, the xen-platform device will crash on reset > if using the accel option with anything other than xen (e.g. > "-machine xenfv,accel=kvm"). > > Signed-off-by: Eduardo Habkost Reviewed-by: Stefano Stabelli

Re: [Qemu-devel] qemu-system-arm: xen-domid not supported for this target

2015-10-02 Thread Stefano Stabellini
On Fri, 2 Oct 2015, Peter Maydell wrote: > On 2 October 2015 at 07:27, Alexander B. Ustinov > wrote: > > Hello, list. Hi! > > I'm trying to get arm guest running on amd64 dom0 system. Unfortunately it is not possible to run ARM guests on an x86 system with Xen. > > Problem i stumbled upon is

Re: [Qemu-devel] [Fix PATCH] Qemu/Xen: Fix early freeing MSIX MMIO memory region

2015-10-05 Thread Stefano Stabellini
Hi Lan, thanks for the patch. On Wed, 30 Sep 2015, Lan Tianyu wrote: > MSIX MMIO memory region is added to pt device's obj as property. msix->mmio is added to XenPCIPassthroughState's object as property > When pt device is unplugged, all properties will be deleted and > memory region's obj is n

Re: [Qemu-devel] [Fix PATCH] Qemu/Xen: Fix early freeing MSIX MMIO memory region

2015-10-06 Thread Stefano Stabellini
On Tue, 6 Oct 2015, Paolo Bonzini wrote: > On 05/10/2015 18:53, Stefano Stabellini wrote: > >> This patch is to fix the issue via moving MSIX MMIO memory region into > >> struct XenPCIPassthroughState and free it together with pt device's obj. > > > > Given

Re: [Qemu-devel] [v4][PATCH 2/2] libxl: introduce gfx_passthru_kind

2015-10-06 Thread Stefano Stabellini
On Fri, 25 Sep 2015, Ian Campbell wrote: > On Fri, 2015-09-18 at 16:30 +0800, Tiejun Chen wrote: > > Although we already have 'gfx_passthru' in b_info, this doesn't suffice > > after we want to handle IGD specifically. Now we define a new field of > > type, gfx_passthru_kind, to indicate we're tryi

Re: [Qemu-devel] [PATCH] Qemu/Xen: Fix early freeing MSIX MMIO memory region

2015-10-12 Thread Stefano Stabellini
On Sun, 11 Oct 2015, Lan Tianyu wrote: > From: > > > msix->mmio is added to XenPCIPassthroughState's object as property. > object_finalize_child_property is called for XenPCIPassthroughState's > object, which calls object_property_del_all, which is going to try to > delete msix->mmio. object_final

Re: [Qemu-devel] [PATCH] Qemu/Xen: Fix early freeing MSIX MMIO memory region

2015-10-12 Thread Stefano Stabellini
On Mon, 12 Oct 2015, Paolo Bonzini wrote: > On 12/10/2015 13:09, Stefano Stabellini wrote: > > On Sun, 11 Oct 2015, Lan Tianyu wrote: > >> From: > > >> > >> msix->mmio is added to XenPCIPassthroughState's object as property. &g

Re: [Qemu-devel] [PATCH QEMU-XEN v5 9/9] xen: make it possible to build without the Xen PV domain builder

2015-11-10 Thread Stefano Stabellini
t; This is another step towards only using Xen libraries which provide a > stable inteface. > > Signed-off-by: Ian Campbell Reviewed-by: Stefano Stabellini > v5: XEN_CREATE entirely wihtin CONFIG_XEN_PV_DOMAIN_BUILD ifdef. > Simplify configure'ry. > > v4: Fixed a

Re: [Qemu-devel] [PATCH QEMU-XEN v5 7/9] xen: Use stable library interfaces when they are available.

2015-11-10 Thread Stefano Stabellini
6 (inclusive) and the patches targetting > 4.7 which adds these libraries. > > Signed-off-by: Ian Campbell Reviewed-by: Stefano Stabellini Two formatting issues below: > v5: Remove ifdef check when undeffing the compat stuff. > s/now way/no way/ > > v4: xenforeignme

Re: [Qemu-devel] [PATCH QEMU-XEN v5 3/9] xen: Switch to libxengnttab interface for compat shims.

2015-11-10 Thread Stefano Stabellini
upport for actually using > libxengnttab, it just adjusts the existing shims. > > Signed-off-by: Ian Campbell Reviewed-by: Stefano Stabellini > v4: Ran checkpatch, fixed all errors > Allocate correct size for handle (i.e. not size of the ptr) > Rebase onto "xen_con

[Qemu-devel] [PULL 09/11] Add Error **errp for xen_pt_setup_vga()

2016-01-21 Thread Stefano Stabellini
From: Cao jin To catch the error message. Also modify the caller Signed-off-by: Cao jin Reviewed-by: Eric Blake Reviewed-by: Stefano Stabellini --- hw/xen/xen_pt.c |7 +-- hw/xen/xen_pt.h |3 ++- hw/xen/xen_pt_graphics.c | 11 ++- 3 files changed, 13

[Qemu-devel] [PULL 02/11] xenfb.c: avoid expensive loops when prod <= out_cons

2016-01-21 Thread Stefano Stabellini
If the frontend sets out_cons to a value higher than out_prod, it will cause xenfb_handle_events to loop about 2^32 times. Avoid that by using better checks at the beginning of the function. Signed-off-by: Stefano Stabellini Reported-by: Ling Liu --- hw/display/xenfb.c |5 +++-- 1 file

[Qemu-devel] [PULL 11/11] Xen PCI passthru: convert to realize()

2016-01-21 Thread Stefano Stabellini
From: Cao jin Signed-off-by: Cao jin Reviewed-by: Eric Blake Reviewed-by: Stefano Stabellini --- hw/xen/xen_pt.c | 53 - 1 file changed, 28 insertions(+), 25 deletions(-) diff --git a/hw/xen/xen_pt.c b/hw/xen/xen_pt.c index 9eef3df

Re: [Qemu-devel] [PULL 10/11] Add Error **errp for xen_pt_config_init()

2016-01-25 Thread Stefano Stabellini
On Sat, 23 Jan 2016, Cao jin wrote: > On 01/22/2016 07:21 PM, Paolo Bonzini wrote: > > > > > > On 21/01/2016 18:01, Stefano Stabellini wrote: > > > -XEN_PT_LOG(&s->dev, "Failed to initialize %d/%ld > &g

Re: [Qemu-devel] [PATCH v3 04/11] igd: switch TYPE_IGD_PASSTHROUGH_I440FX_PCI_DEVICE to realize

2016-01-25 Thread Stefano Stabellini
On Mon, 25 Jan 2016, Gerd Hoffmann wrote: > Hi, > > > > static void igd_passthrough_i440fx_class_init(ObjectClass *klass, void > > > *data) > > > @@ -78,7 +77,7 @@ static void > > > igd_passthrough_i440fx_class_init(ObjectClass *klass, void *data) > > > DeviceClass *dc = DEVICE_CLASS(kla

[Qemu-devel] [PULL 0/8] xen-20160126

2016-01-26 Thread Stefano Stabellini
The following changes since commit 1535a6d699487740b490369e44f9ca8d305463cd: Merge remote-tracking branch 'remotes/jnsnow/tags/ide-pull-request' into staging (2016-01-26 09:16:07 +) are available in the git repository at: git://xenbits.xen.org/people/sstabellini/qemu-dm.git tags/xen-20

[Qemu-devel] [PULL 6/8] xen: Use stable library interfaces when they are available.

2016-01-26 Thread Stefano Stabellini
CONFIG_XEN_CTRL_INTERFACE_VERSION == 471 to cover the introduction of these new interfaces. Signed-off-by: Ian Campbell Reviewed-by: Stefano Stabellini --- configure | 55 +++ include/hw/xen/xen_common.h | 35 +-- 2 files changed, 88

[Qemu-devel] [PULL 3/8] xen: Switch to libxengnttab interface for compat shims.

2016-01-26 Thread Stefano Stabellini
wed-by: Stefano Stabellini --- hw/block/xen_disk.c | 38 -- hw/char/xen_console.c|4 ++-- hw/net/xen_nic.c | 18 +- hw/xen/xen_backend.c | 10 +- include/hw/xen/xen_backend.h |2 +- incl

[Qemu-devel] [PULL 4/8] xen: Switch uses of xc_map_foreign_range into xc_map_foreign_pages

2016-01-26 Thread Stefano Stabellini
st use a temporary xen_pfn_t to in effect upcast the pointer from int* to xen_pfn_t*. In xenfb.c:common_bind we now explicitly launder the mfn into a xen_pfn_t, so it has the correct type to be passed to xc_map_foreign_pages and doesn't provoke warnings on 32-bit x86. Signed-off-by: Ian Campbel

[Qemu-devel] [PULL 2/8] xen: Switch to libxenevtchn interface for compat shims.

2016-01-26 Thread Stefano Stabellini
und functionality remains in libxenctrl, since that functionality is not exposed by /dev/xen/evtchn. Signed-off-by: Ian Campbell Reviewed-by: Stefano Stabellini --- hw/xen/xen_backend.c | 31 +++-- include/hw/xen/xen_backend.h |2 +- include/hw/xen/xen_commo

[Qemu-devel] [PULL 5/8] xen: Switch uses of xc_map_foreign_{pages, bulk} to use libxenforeignmemory API.

2016-01-26 Thread Stefano Stabellini
em then we could consider adding an extra API to the libxenforeignmemory interface to replace a foreign mapping with anonymous shared memory, but I'd prefer not to. Signed-off-by: Ian Campbell Reviewed-by: Stefano Stabellini --- hw/char/xen_console.c|8 hw/di

[Qemu-devel] [PULL 1/8] xen_console: correctly cleanup primary console on teardown.

2016-01-26 Thread Stefano Stabellini
re either both set or neither. For consistency with con_initialise() with to the former here too. With this con_initialise and con_disconnect now mirror each other. Fix up a hard tab in the function while editing. Signed-off-by: Ian Campbell Reviewed-by: Stefano Stabellini --- hw/char/xen_console

[Qemu-devel] [PULL 7/8] xen: domainbuild: reopen libxenctrl interface after forking for domain watcher.

2016-01-26 Thread Stefano Stabellini
: Ian Campbell Acked-by: Stefano Stabellini --- hw/xenpv/xen_domainbuild.c |9 ++--- include/hw/xen/xen_common.h | 17 - 2 files changed, 6 insertions(+), 20 deletions(-) diff --git a/hw/xenpv/xen_domainbuild.c b/hw/xenpv/xen_domainbuild.c index ac0e5ac..f9be029 100644

[Qemu-devel] [PULL 8/8] xen: make it possible to build without the Xen PV domain builder

2016-01-26 Thread Stefano Stabellini
pbell Reviewed-by: Stefano Stabellini --- configure | 15 +++ hw/xenpv/Makefile.objs |4 +++- hw/xenpv/xen_machine_pv.c | 15 +++ include/hw/xen/xen_common.h |2 ++ 4 files changed, 31 insertions(+), 5 deletions(-) diff --git a/config

Re: [Qemu-devel] [PULL 0/8] xen-20160126

2016-01-26 Thread Stefano Stabellini
On Tue, 26 Jan 2016, Peter Maydell wrote: > On 26 January 2016 at 15:51, Stefano Stabellini > wrote: > > The following changes since commit 1535a6d699487740b490369e44f9ca8d305463cd: > > > > Merge remote-tracking branch 'remotes/jnsnow/tags/ide-pull-request' i

[Qemu-devel] [PULL] xen-20160126-2

2016-01-26 Thread Stefano Stabellini
The following changes since commit 1535a6d699487740b490369e44f9ca8d305463cd: Merge remote-tracking branch 'remotes/jnsnow/tags/ide-pull-request' into staging (2016-01-26 09:16:07 +) are available in the git repository at: git://xenbits.xen.org/people/sstabellini/qemu-dm.git tags/xen-20

Re: [Qemu-devel] [Xen-devel] [PATCH RESEND] fix MSI injection on Xen

2016-01-28 Thread Stefano Stabellini
On Wed, 27 Jan 2016, Konrad Rzeszutek Wilk wrote: > On Wed, Jan 13, 2016 at 02:59:09PM +0000, Stefano Stabellini wrote: > > On Xen MSIs can be remapped into pirqs, which are a type of event > > channels. It's mostly for the benefit of PCI passthrough devices, to >

Re: [Qemu-devel] [PATCH RESEND] fix MSI injection on Xen

2016-02-04 Thread Stefano Stabellini
Hi Michael, do you have any comments on this? On Wed, 13 Jan 2016, Stefano Stabellini wrote: > On Xen MSIs can be remapped into pirqs, which are a type of event > channels. It's mostly for the benefit of PCI passthrough devices, to > avoid the overhead of interacting with the

Re: [Qemu-devel] [PATCH QEMU 2/2] xen: fix usage of xc_domain_create in domain builder

2015-11-13 Thread Stefano Stabellini
f-by: Roger Pau Monné Give a look at include/hw/xen/xen_common.h and add a compatibility shim there. Keep in mind that QEMU needs to build against any version of Xen from 4.0 onward. > Cc: Stefano Stabellini > Cc: qemu-devel@nongnu.org > --- > hw/xenpv/xen_domainbuild.c | 2 +- >

Re: [Qemu-devel] [PATCH QEMU v2 2/2] xen: fix usage of xc_domain_create in domain builder

2015-11-13 Thread Stefano Stabellini
he corresponding libxc change already in Xen? > Cc: Stefano Stabellini > Cc: qemu-devel@nongnu.org > --- > Changes since v1: > - Add a compat layer to support previous libxc versions. > - Add machinery to detect current Xen unstable (4.7). > --- > configure

Re: [Qemu-devel] [PATCH QEMU v3 2/2] xen: fix usage of xc_domain_create in domain builder

2015-11-13 Thread Stefano Stabellini
all stub called xen_domain_create that encapsulates the correct call > to xc_domain_create depending on the libxc version detected. > > Signed-off-by: Roger Pau Monné Acked-by: Stefano Stabellini I'll apply it to my tree > Cc: Stefano Stabellini > Cc: qemu-devel@nongnu.org

Re: [Qemu-devel] [Intel-gfx] [Announcement] 2015-Q3 release of XenGT - a Mediated Graphics Passthrough Solution from Intel

2015-11-19 Thread Stefano Stabellini
On Thu, 19 Nov 2015, Jike Song wrote: > Hi Alex, thanks for the discussion. > > In addition to Kevin's replies, I have a high-level question: can VFIO > be used by QEMU for both KVM and Xen? No. VFIO cannot be used with Xen today. When running on Xen, the IOMMU is owned by Xen.

Re: [Qemu-devel] [Intel-gfx] [Announcement] 2015-Q3 release of XenGT - a Mediated Graphics Passthrough Solution from Intel

2015-11-19 Thread Stefano Stabellini
On Thu, 19 Nov 2015, Paolo Bonzini wrote: > On 19/11/2015 16:32, Stefano Stabellini wrote: > > > In addition to Kevin's replies, I have a high-level question: can VFIO > > > be used by QEMU for both KVM and Xen? > > > > No. VFIO cannot be used with Xen today.

Re: [Qemu-devel] [PATCH for-2.5] xen_disk: Remove ioreq.postsync

2015-11-25 Thread Stefano Stabellini
On Wed, 25 Nov 2015, Alberto Garcia wrote: > This code has been dead for three years (since commit 7e7b7cba1). > > Signed-off-by: Alberto Garcia Reviewed-by: Stefano Stabellini Kevin, I'll send it out together with another fix today. > hw/block/xen_disk.c | 8

[Qemu-devel] [PULL for-4.5 1/2] xen: fix usage of xc_domain_create in domain builder

2015-11-25 Thread Stefano Stabellini
encapsulates the correct call to xc_domain_create depending on the libxc version detected. Signed-off-by: Roger Pau Monné Acked-by: Stefano Stabellini Signed-off-by: Stefano Stabellini --- configure | 17 + hw/xenpv/xen_domainbuild.c |2 +- include/hw/xen

[Qemu-devel] [PULL for-2.5 0/2] xen-20151125

2015-11-25 Thread Stefano Stabellini
The following changes since commit 8337c6cbc37c6b2184f41bab3eaff47d5e68012a: Update version for v2.5.0-rc0 release (2015-11-13 17:10:36 +) are available in the git repository at: git://xenbits.xen.org/people/sstabellini/qemu-dm.git tags/xen-20151125 for you to fetch changes up to 22037d

[Qemu-devel] [PULL for-4.5 2/2] xen_disk: Remove ioreq.postsync

2015-11-25 Thread Stefano Stabellini
From: Alberto Garcia This code has been dead for three years (since commit 7e7b7cba1). Signed-off-by: Alberto Garcia Signed-off-by: Stefano Stabellini Reviewed-by: Stefano Stabellini --- hw/block/xen_disk.c |8 1 file changed, 8 deletions(-) diff --git a/hw/block/xen_disk.c b

Re: [Qemu-devel] [PATCH RESEND] fix MSI injection on Xen

2016-02-08 Thread Stefano Stabellini
On Thu, 4 Feb 2016, Michael S. Tsirkin wrote: > On Thu, Feb 04, 2016 at 05:05:46PM +0000, Stefano Stabellini wrote: > > Hi Michael, > > > > do you have any comments on this? > > I dislike how it spreads xen specific stuff around, > but I don't have a better

Re: [Qemu-devel] [PATCH 1/5] xen: drop support for Xen 4.1 and older.

2016-02-09 Thread Stefano Stabellini
On Tue, 9 Feb 2016, Ian Campbell wrote: > Xen 4.2 become unsupported upstream in 09/2105 (see > http://wiki.xen.org/wiki/Xen_Release_Features). However as far as the > interfaces provided by the toolstack libraries go 4.2 and 4.3 are > indistinguishable. > > Therefore drop support for Xen 4.1 and

Re: [Qemu-devel] [PATCH 2/5] xen: drop xen_xc_hvm_inject_msi wrapper

2016-02-09 Thread Stefano Stabellini
On Tue, 9 Feb 2016, Ian Campbell wrote: > The xc version is now always present. > > Signed-off-by: Ian Campbell Reviewed-by: Stefano Stabellini > include/hw/xen/xen_common.h | 6 -- > xen-hvm.c | 2 +- > 2 files changed, 1 insertion(+), 7 deletions(-)

Re: [Qemu-devel] [PATCH 4/5] xen: move xenforeignmemory compat layer into common place

2016-02-09 Thread Stefano Stabellini
On Tue, 9 Feb 2016, Ian Campbell wrote: > Now that we no longer support Xen 4.2 and earlier only the <470 case > needs this so it can live with all the others. > > Signed-off-by: Ian Campbell Reviewed-by: Stefano Stabellini > include/hw/xen

<    3   4   5   6   7   8   9   10   11   12   >