Re: [Qemu-devel] [PATCH] xen-pvdevice: make device-id property compulsory

2013-11-13 Thread Stefano Stabellini
On Wed, 13 Nov 2013, Paul Durrant wrote: > The intention of the Xen PV device is that it is used as a parent > device for PV drivers in Xen HVM guests and the set of PV drivers that > bind to the device is determined by its device ID (and possibly > vendor ID and revision). As such, the device shou

Re: [Qemu-devel] [PATCH v3] xen_disk: add discard support

2014-05-07 Thread Stefano Stabellini
qemu. The discard support is enabled unconditionally. The tool stack may provide a property "discard-enable" in the backend node to optionally disable discard support. This is helpful in case the backing file was intentionally created non-sparse to avoid fragmentation.

[Qemu-devel] [PULL 0/7] xen-140507

2014-05-07 Thread Stefano Stabellini
xen Olaf Hering (1): xen_disk: add discard support Stefano Stabellini (1): pass an inclusive address range to xc_domain_pin_memory_cacheattr Wei Liu (3): xen: move Xen PV machine files to hw/xenpv xen: move Xen HVM files under hw/i386/xen xen: factor out common

[Qemu-devel] [PULL 6/7] pass an inclusive address range to xc_domain_pin_memory_cacheattr

2014-05-07 Thread Stefano Stabellini
xc_domain_pin_memory_cacheattr expects an inclusive address range: adjust the parameters. Signed-off-by: Stefano Stabellini --- xen-hvm.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen-hvm.c b/xen-hvm.c index 0a49055..a64486c 100644 --- a/xen-hvm.c +++ b/xen-hvm.c

[Qemu-devel] [PULL 2/7] qemu-xen: free all the pirqs for msi/msix when driver unload

2014-05-07 Thread Stefano Stabellini
reuse pirqs between driver reload, but this way is better. Xen-devel: http://marc.info/?l=xen-devel&m=136800120304275&w=2 Signed-off-by: Zhenzhong Duan Signed-off-by: Konrad Rzeszutek Wilk Signed-off-by: Stefano Stabellini --- hw/xen/xen_pt_config_init.c |6 -- hw/xen/xen_

[Qemu-devel] [PULL 3/7] xen: move Xen PV machine files to hw/xenpv

2014-05-07 Thread Stefano Stabellini
From: Wei Liu Signed-off-by: Wei Liu Signed-off-by: Stefano Stabellini --- hw/i386/Makefile.objs |2 +- hw/i386/xen_domainbuild.c | 299 hw/i386/xen_domainbuild.h | 13 -- hw/i386/xen_machine_pv.c | 109 hw/xenpv

[Qemu-devel] [PULL 7/7] xen_disk: add discard support

2014-05-07 Thread Stefano Stabellini
ul in case the backing file was intentionally created non-sparse to avoid fragmentation. Signed-off-by: Olaf Hering Signed-off-by: Stefano Stabellini --- hw/block/xen_blkif.h| 12 hw/block/xen_disk.c | 33 + include/hw/xen/xe

[Qemu-devel] [PULL 4/7] xen: move Xen HVM files under hw/i386/xen

2014-05-07 Thread Stefano Stabellini
From: Wei Liu Signed-off-by: Wei Liu Signed-off-by: Stefano Stabellini --- hw/i386/Makefile.objs |2 +- hw/i386/xen/Makefile.objs |1 + hw/i386/xen/xen_apic.c | 97 ++ hw/i386/xen/xen_platform.c | 450 hw/i386/xen

Re: [Qemu-devel] [PULL 1/7] exec: Limit translation limiting in address_space_translate to xen

2014-05-07 Thread Stefano Stabellini
On Wed, 7 May 2014, Paolo Bonzini wrote: > Il 07/05/2014 17:12, Peter Maydell ha scritto: > > > > -if (memory_access_is_direct(mr, is_write)) { > > > > +if (xen_enabled() && memory_access_is_direct(mr, is_write)) { > > > > hwaddr page = ((addr & TARGET_PAGE_MASK) + TARGET_PAGE_SIZE

[Qemu-devel] [PULL 1/7] exec: Limit translation limiting in address_space_translate to xen

2014-05-07 Thread Stefano Stabellini
safely limit this piece of code to XEN. So does the patch. Suggested-by: Paolo Bonzini Signed-off-by: Alexey Kardashevskiy Signed-off-by: Stefano Stabellini --- exec.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/exec.c b/exec.c index 91513c6..cf12049 100644 --- a

[Qemu-devel] [PULL 2/2] qemu/xen: make use of xenstore relative paths

2013-10-10 Thread Stefano Stabellini
xenstore paths relative to the domain where Qemu is actually running. Signed-off-by: Roger Pau Monné Signed-off-by: Stefano Stabellini Reviewed-by: Anthony PERARD Cc: xen-de...@lists.xenproject.org Cc: Anthony PERARD --- hw/xen/xen_backend.c | 19 ++- xen-all.c

[Qemu-devel] [PULL 1/2] xen_disk: mark ioreq as mapped before unmapping in error case

2013-10-10 Thread Stefano Stabellini
mited resource. Fix by marking the ioreq as mapped before calling ioreq_unmap in this situation. Signed-off-by: Matthew Daley Signed-off-by: Stefano Stabellini CC: qemu-sta...@nongnu.org --- hw/block/xen_disk.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/hw/block/xen_d

[Qemu-devel] [PULL 0/2] Xen 2013-10-10

2013-10-10 Thread Stefano Stabellini
The following changes since commit a684f3cf9b9b9c3cb82be87aafc463de8974610c: Merge remote-tracking branch 'kraxel/seabios-1.7.3.2' into staging (2013-09-30 17:15:27 -0500) are available in the git repository at: git://xenbits.xen.org/people/sstabellini/qemu-dm.git xen-2013-10-10 Matthew Da

Re: [Qemu-devel] [PATCH v2 1/4] xen-all: Fix xen_hvm_init() to adjust pc memory layout.

2014-03-16 Thread Stefano Stabellini
On Tue, 11 Mar 2014, Don Slutz wrote: > This is just below_4g_mem_size and above_4g_mem_size which is used later in > QEMU. > > Signed-off-by: Don Slutz Acked-by: Stefano Stabellini > hw/i386/pc_piix.c| 31 --- > hw/i386

Re: [Qemu-devel] [PATCH v2 4/4] xen-all: Pass max_ram_below_4g to xen_hvm_init.

2014-03-16 Thread Stefano Stabellini
On Tue, 11 Mar 2014, Don Slutz wrote: > This is the xen part of "pc & q35: Add new object pc-memory-layout." > > Signed-off-by: Don Slutz > --- > hw/i386/pc_piix.c| 4 ++-- > hw/i386/pc_q35.c | 4 ++-- > include/hw/xen/xen.h | 4 ++-- > xen-all.c| 41 ++

Re: [Qemu-devel] [PATCH v2 4/4] xen-all: Pass max_ram_below_4g to xen_hvm_init.

2014-03-17 Thread Stefano Stabellini
On Mon, 17 Mar 2014, Don Slutz wrote: > On 03/16/14 12:10, Stefano Stabellini wrote: > > On Tue, 11 Mar 2014, Don Slutz wrote: > > > This is the xen part of "pc & q35: Add new object pc-memory-layout." > > > > > > Signed-off-by: Don

Re: [Qemu-devel] [PATCH v2 4/4] xen-all: Pass max_ram_below_4g to xen_hvm_init.

2014-03-17 Thread Stefano Stabellini
On Mon, 17 Mar 2014, Don Slutz wrote: > On 03/17/14 14:22, Don Slutz wrote: > > On 03/17/14 13:55, Stefano Stabellini wrote: > > > On Mon, 17 Mar 2014, Don Slutz wrote: > > > > On 03/16/14 12:10, Stefano Stabellini wrote: > > > > > On Tue, 11 Mar 2014,

Re: [Qemu-devel] [PATCH] fix QEMU build on Xen/ARM

2015-01-23 Thread Stefano Stabellini
On Thu, 22 Jan 2015, Don Slutz wrote: > On 01/22/15 13:46, Stefano Stabellini wrote: > > xen_get_vmport_regs_pfn should take a xen_pfn_t argument, not an > > unsigned long argument (in fact xen_pfn_t is defined as uint64_t on > > ARM). > > > > Also use xc_hvm_pa

[Qemu-devel] [PATCH v2] fix QEMU build on Xen/ARM

2015-01-23 Thread Stefano Stabellini
xen_get_vmport_regs_pfn should take a xen_pfn_t argument, not an unsigned long argument (in fact xen_pfn_t is defined as uint64_t on ARM). Also use xc_hvm_param_get instead of the deprecated xc_get_hvm_param. Signed-off-by: Stefano Stabellini --- Changes in v2: - properly handle return codes

[Qemu-devel] [PULL 0/1] Xen tree 2015-01-26

2015-01-26 Thread Stefano Stabellini
dm.git xen-2015-01-26 for you to fetch changes up to d01a5a3fe19645f3cdea1566f0e518ea2152a029: fix QEMU build on Xen/ARM (2015-01-26 11:56:33 +) -------- Stefano Stabellini (1): fix QEMU build on Xen/ARM include/hw/xen/xen_commo

[Qemu-devel] [PULL 1/1] fix QEMU build on Xen/ARM

2015-01-26 Thread Stefano Stabellini
xen_get_vmport_regs_pfn should take a xen_pfn_t argument, not an unsigned long argument (in fact xen_pfn_t is defined as uint64_t on ARM). Also use xc_hvm_param_get instead of the deprecated xc_get_hvm_param. Signed-off-by: Stefano Stabellini Reviewed-by: Don Slutz --- include/hw/xen

Re: [Qemu-devel] [PATCH v2 00/14] block: Remove "growable", add blk_new_open()

2015-01-26 Thread Stefano Stabellini
On Thu, 22 Jan 2015, Max Reitz wrote: > This series removes the "growable" field from the BlockDriverState > object. Its use was to clamp guest requests against the limits of the > BDS; however, this can now be done more easily by moving those checks > into the BlockBackend functions. > > In a fut

Re: [Qemu-devel] [PATCH v3 00/14] block: Remove "growable", add blk_new_open()

2015-01-26 Thread Stefano Stabellini
On Mon, 26 Jan 2015, Max Reitz wrote: > This series removes the "growable" field from the BlockDriverState > object. Its use was to clamp guest requests against the limits of the > BDS; however, this can now be done more easily by moving those checks > into the BlockBackend functions. > > In a fut

Re: [Qemu-devel] -device xen-platform crashes

2015-01-29 Thread Stefano Stabellini
On Thu, 29 Jan 2015, Markus Armbruster wrote: > Reproducer: qemu -nodefaults -S -display none -device xen-platform > > Yes, xen-platform makes no sense without Xen, but it shouldn't crash. Is it just a matter of doing the following? diff --git a/hw/i386/xen/xen_platform.c b/hw/i386/xen/xen_platf

Re: [Qemu-devel] [v3 2/5] Qemu-Xen-vTPM: Xen frontend driver infrastructure

2015-01-29 Thread Stefano Stabellini
On Thu, 29 Jan 2015, Xu, Quan wrote: > > -Original Message- > > From: Stefano Stabellini [mailto:stefano.stabell...@eu.citrix.com] > > Sent: Tuesday, January 20, 2015 1:15 AM > > To: Xu, Quan > > Cc: qemu-devel@nongnu.org; xen-de...@lists.xen.org; > &

Re: [Qemu-devel] -device xen-platform crashes

2015-01-29 Thread Stefano Stabellini
On Thu, 29 Jan 2015, Markus Armbruster wrote: > Stefano Stabellini writes: > > > On Thu, 29 Jan 2015, Markus Armbruster wrote: > >> Reproducer: qemu -nodefaults -S -display none -device xen-platform > >> > >> Yes, xen-platform makes no sense without Xen

Re: [Qemu-devel] -device xen-platform crashes

2015-01-30 Thread Stefano Stabellini
On Fri, 30 Jan 2015, Markus Armbruster wrote: > Stefano Stabellini writes: > > > On Thu, 29 Jan 2015, Markus Armbruster wrote: > >> Stefano Stabellini writes: > >> > >> > On Thu, 29 Jan 2015, Markus Armbruster wrote: > >> >> Reproduce

Re: [Qemu-devel] -device xen-platform crashes

2015-02-04 Thread Stefano Stabellini
On Mon, 2 Feb 2015, Markus Armbruster wrote: > Stefano Stabellini writes: > > > On Fri, 30 Jan 2015, Markus Armbruster wrote: > >> Stefano Stabellini writes: > >> > >> > On Thu, 29 Jan 2015, Markus Armbruster wrote: > >> >> Stefano S

Re: [Qemu-devel] [PATCH v2 0/3] fix qemu crash about vnc

2015-02-05 Thread Stefano Stabellini
On Fri, 30 Jan 2015, arei.gong...@huawei.com wrote: > From: Gonglei > > Reproducer: > $ x86_64-softmmu/qemu-system-x86_64 > qemu-system-x86_64: Invalid parameter 'to' > Segmentation fault (core dumped) > > Fix: > https://bugs.launchpad.net/qemu/+bug/1414222 > > Patch 1~2 is bugfix, patch 3 is t

Re: [Qemu-devel] [PATCH 2/2] xen-pt: fix Out-of-bounds read

2015-02-09 Thread Stefano Stabellini
On Sat, 31 Jan 2015, arei.gong...@huawei.com wrote: > From: Gonglei > > The array length of s->real_device.io_regions[] is > "PCI_NUM_REGIONS - 1". Add a check, just make Coverity happy. > > Signed-off-by: Gonglei > --- > hw/xen/xen_pt_config_init.c | 5 + > 1 file changed, 5 insertions(+)

Re: [Qemu-devel] [PATCH 1/2] xen-pt: fix Negative array index read

2015-02-09 Thread Stefano Stabellini
pass index as an argument to > xen_pt_bar_reg_parse(). > > Signed-off-by: Gonglei Acked-by: Stefano Stabellini > hw/xen/xen_pt_config_init.c | 6 ++ > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/hw/xen/xen_pt_config_init.c b/hw/xen/xen_pt_config_ini

Re: [Qemu-devel] [PATCH 2/2] xen-pt: fix Out-of-bounds read

2015-02-09 Thread Stefano Stabellini
On Tue, 10 Feb 2015, Gonglei wrote: > On 2015/2/10 14:39, Stefano Stabellini wrote: > > On Sat, 31 Jan 2015, arei.gong...@huawei.com wrote: > >> From: Gonglei > >> > >> The array length of s->real_device.io_regions[] is > >> "PCI_NU

Re: [Qemu-devel] [PATCH v2 2/2] xen-pt: fix Out-of-bounds read

2015-02-10 Thread Stefano Stabellini
On Tue, 10 Feb 2015, arei.gong...@huawei.com wrote: > From: Gonglei > > The array length of s->real_device.io_regions[] is > "PCI_NUM_REGIONS - 1". > > Signed-off-by: Gonglei Acked-by: Stefano Stabellini I am happy for these patches to go in via th

Re: [Qemu-devel] [Xen-devel] Question about scsi emulation

2015-03-23 Thread Stefano Stabellini
On Mon, 23 Mar 2015, Stefan Hajnoczi wrote: > On Wed, Mar 18, 2015 at 02:16:47PM -0700, Yaoli Zheng wrote: > > We have problem using qemu emulated scsi driver(the old lsi). Wonder if any > > of other device model we can try for emulating scsi, and how we can get and > > config it in Xen? Having b

Re: [Qemu-devel] [Xen-devel] Question about scsi emulation

2015-03-24 Thread Stefano Stabellini
MegaSAS, it should be just a matter of passing the right command line arguments to QEMU so that it will emulate it, same as for QEMU without Xen. You can use device_model_args in the VM config file to pass custom command line arguments from xl to QEMU. > > > > Thanks! &

Re: [Qemu-devel] [PATCH 10/22] ram_addr: tweaks to xen_modified_memory

2015-03-28 Thread Stefano Stabellini
> away soon. > > Second, fix the second argument to the function in the > cpu_physical_memory_set_dirty_lebitmap call site. That function is only used > by KVM, but it is better to be clean anyway. > > Signed-off-by: Paolo Bonzini Acked-by: Stefano Stabellini >

[Qemu-devel] [PATCH][XSA-126] xen: limit guest control of PCI command register

2015-03-31 Thread Stefano Stabellini
host. This is CVE-2015-2756 / XSA-126. Signed-off-by: Jan Beulich Reviewed-by: Stefano Stabellini Acked-by: Ian Campbell diff --git a/hw/xen/xen_pt.c b/hw/xen/xen_pt.c index f2893b2..d095c08 100644 --- a/hw/xen/xen_pt.c +++ b/hw/xen/xen_pt.c @@ -388,7 +388,7 @@ static const MemoryRegionOps ops

Re: [Qemu-devel] [PATCH][XSA-126] xen: limit guest control of PCI command register

2015-04-01 Thread Stefano Stabellini
CC'ing the author of the patch and xen-devel. FYI I think that Jan is going to be on vacation for a couple of weeks. On Wed, 1 Apr 2015, Michael S. Tsirkin wrote: > On Tue, Mar 31, 2015 at 03:18:03PM +0100, Stefano Stabellini wrote: > > From: Jan Beulich > > > > Oth

Re: [Qemu-devel] Question about unbind MSI in xen_pt_msi.c

2015-04-01 Thread Stefano Stabellini
On Wed, 1 Apr 2015, Julien Grall wrote: > Hi, > > I'm looking to replace any call to xc_domain_bind_pt_irq and > xc_domain_unbind_pt_irq by specific IRQ type helpers. > > I found one strange call which will always fail in xen_pt_msix_update_remap. > The function xc_domain_unbind_pt_irq is called

Re: [Qemu-devel] bind interdomain ioctl error xen-kvm.c

2015-01-05 Thread Stefano Stabellini
On Tue, 30 Dec 2014, Rishi Ranjan wrote: > I am trying to use Xen as accelerator for my Qemu machine. I have created a > guest domain with following xl config:  > builder = "hvm" > name = "qemu-hvm" > memory = "512" > vcpus = 1 > vif = [''] > vnc = 1 > boot="c" > > > When I try to run with follo

Re: [Qemu-devel] [PATCH for 2.3 v2 1/1] xen-hvm: increase maxmem before calling xc_domain_populate_physmap

2015-01-12 Thread Stefano Stabellini
On Wed, 3 Dec 2014, Don Slutz wrote: > From: Stefano Stabellini > > Increase maxmem before calling xc_domain_populate_physmap_exact to > avoid the risk of running out of guest memory. This way we can also > avoid complex memory calculations in libxl at domain construction > tim

Re: [Qemu-devel] [PATCH] xen-pt: Fix PCI devices re-attach failed

2015-01-12 Thread Stefano Stabellini
On Wed, 24 Dec 2014, Liang Li wrote: > Use the 'xl pci-attach $DomU $BDF' command to attach more then > one PCI devices to the guest, then detach the devices with > 'xl pci-detach $DomU $BDF', after that, re-attach these PCI > devices again, an error message will be reported like following: > > li

Re: [Qemu-devel] [Xen-devel] [PATCH] xen-pt: Fix PCI devices re-attach failed

2015-01-12 Thread Stefano Stabellini
On Mon, 12 Jan 2015, Paolo Bonzini wrote: > On 12/01/2015 14:35, Li, Liang Z wrote: > > > > diff --git a/hw/xen/xen_pt.c b/hw/xen/xen_pt.c index c1bf357..f2893b2 100644 > > --- a/hw/xen/xen_pt.c > > +++ b/hw/xen/xen_pt.c > > @@ -736,7 +736,7 @@ static int xen_pt_initfn(PCIDevice *d) > > } > >

Re: [Qemu-devel] [v2] xen-pt: Fix PCI devices re-attach failed

2015-01-13 Thread Stefano Stabellini
On Tue, 13 Jan 2015, Liang Li wrote: > Use the 'xl pci-attach $DomU $BDF' command to attach more than > one PCI devices to the guest, then detach the devices with > 'xl pci-detach $DomU $BDF', after that, re-attach these PCI > devices again, an error message will be reported like following: > >

Re: [Qemu-devel] [PATCH for 2.3 v2 1/1] xen-hvm: increase maxmem before calling xc_domain_populate_physmap

2015-01-13 Thread Stefano Stabellini
On Mon, 12 Jan 2015, Stefano Stabellini wrote: > On Wed, 3 Dec 2014, Don Slutz wrote: > > From: Stefano Stabellini > > > > Increase maxmem before calling xc_domain_populate_physmap_exact to > > avoid the risk of running out of guest memory. This way we can al

[Qemu-devel] [PULL 0/2] Xen tree 2015-01-13

2015-01-13 Thread Stefano Stabellini
re-attach failed Stefano Stabellini (1): xen-hvm: increase maxmem before calling xc_domain_populate_physmap hw/xen/xen_pt.c |2 +- xen-hvm.c | 24 2 files changed, 25 insertions(+), 1 deletion(-)

[Qemu-devel] [PULL 1/2] xen-pt: Fix PCI devices re-attach failed

2015-01-13 Thread Stefano Stabellini
From: Liang Li Use the 'xl pci-attach $DomU $BDF' command to attach more than one PCI devices to the guest, then detach the devices with 'xl pci-detach $DomU $BDF', after that, re-attach these PCI devices again, an error message will be reported like following: libxl: error: libxl_qmp.c:287:

[Qemu-devel] [PULL 2/2] xen-hvm: increase maxmem before calling xc_domain_populate_physmap

2015-01-13 Thread Stefano Stabellini
: Stefano Stabellini Signed-off-by: Don Slutz --- xen-hvm.c | 24 1 file changed, 24 insertions(+) diff --git a/xen-hvm.c b/xen-hvm.c index 7548794..e2e575b 100644 --- a/xen-hvm.c +++ b/xen-hvm.c @@ -90,6 +90,12 @@ static inline ioreq_t *xen_vcpu_ioreq(shared_iopage_t

Re: [Qemu-devel] [PATCH for 2.3 v2 1/1] xen-hvm: increase maxmem before calling xc_domain_populate_physmap

2015-01-14 Thread Stefano Stabellini
On Tue, 13 Jan 2015, Don Slutz wrote: > On 01/13/15 13:07, Stefano Stabellini wrote: > > On Mon, 12 Jan 2015, Stefano Stabellini wrote: > >> On Wed, 3 Dec 2014, Don Slutz wrote: > >>> From: Stefano Stabellini > >>> > >>> Increase max

Re: [Qemu-devel] [RFH PATCH 1/2] xen: do not use __-named variables in mapcache

2015-01-14 Thread Stefano Stabellini
On Wed, 14 Jan 2015, Paolo Bonzini wrote: > Keep the namespace clean. > > Signed-off-by: Paolo Bonzini Acked-by: Stefano Stabellini > xen-mapcache.c | 40 > 1 file changed, 20 insertions(+), 20 deletions(-) > > diff --git a

Re: [Qemu-devel] [RFH PATCH 2/2] xen: add a lock for the mapcache

2015-01-14 Thread Stefano Stabellini
On Wed, 14 Jan 2015, Paolo Bonzini wrote: > Extend the existing dummy mapcache_lock/unlock macros to cover all of > xen-mapcache.c. This prepares for unlocked memory access, when parts > of exec.c will not be protected by the BQL. > > Signed-off-by: Paolo Bonzini Acked-by: Ste

Re: [Qemu-devel] [v3 3/5] Qemu-Xen-vTPM: Register Xen stubdom vTPM frontend driver

2015-01-19 Thread Stefano Stabellini
On Tue, 30 Dec 2014, Quan Xu wrote: > This drvier transfers any request/repond between TPM xenstubdoms > driver and Xen vTPM stubdom, and facilitates communications between > Xen vTPM stubdom domain and vTPM xenstubdoms driver. It is a glue for > the TPM xenstubdoms driver and Xen stubdom vTPM doma

Re: [Qemu-devel] [v3 2/5] Qemu-Xen-vTPM: Xen frontend driver infrastructure

2015-01-19 Thread Stefano Stabellini
On Tue, 30 Dec 2014, Quan Xu wrote: > This patch adds infrastructure for xen front drivers living in qemu, > so drivers don't need to implement common stuff on their own. It's > mostly xenbus management stuff: some functions to access XenStore, > setting up XenStore watches, callbacks on device di

Re: [Qemu-devel] [PATCH v3 0/5] QEMU:Xen stubdom vTPM for HVM virtual machine

2015-01-19 Thread Stefano Stabellini
Hi Quan, thanks for the update: this version is much much better than the previous one. I am not familiar enough with QAPI, HMP and TPM to review the first and the last patches though. Cheers, Stefano On Tue, 30 Dec 2014, Quan Xu wrote: > *INTRODUCTION* > The goal of virtual Trusted Platform M

Re: [Qemu-devel] [v3 3/5] Qemu-Xen-vTPM: Register Xen stubdom vTPM frontend driver

2015-01-19 Thread Stefano Stabellini
On Tue, 30 Dec 2014, Quan Xu wrote: > +int vtpm_recv(struct XenDevice *xendev, uint8_t* buf, size_t *count) > +{ > +struct xen_vtpm_dev *vtpmdev = container_of(xendev, struct xen_vtpm_dev, > +xendev); > +struct tpmif_shared_page *shr = vtpmdev

Re: [Qemu-devel] [PATCH v3 0/5] QEMU:Xen stubdom vTPM for HVM virtual machine

2015-01-19 Thread Stefano Stabellini
On Mon, 19 Jan 2015, Stefano Stabellini wrote: > Hi Quan, > thanks for the update: this version is much much better than the > previous one. > > I am not familiar enough with QAPI, HMP and TPM to review the first and > the last patches though. I meant the first and the fourt

Re: [Qemu-devel] [v3 2/5] Qemu-Xen-vTPM: Xen frontend driver infrastructure

2015-01-20 Thread Stefano Stabellini
On Tue, 20 Jan 2015, Xu, Quan wrote: > > -Original Message- > > From: Stefano Stabellini [mailto:stefano.stabell...@eu.citrix.com] > > Sent: Tuesday, January 20, 2015 1:15 AM > > To: Xu, Quan > > Cc: qemu-devel@nongnu.org; xen-de...@lists.xen.org; > &

Re: [Qemu-devel] [v3 3/5] Qemu-Xen-vTPM: Register Xen stubdom vTPM frontend driver

2015-01-20 Thread Stefano Stabellini
On Tue, 20 Jan 2015, Xu, Quan wrote: > > -Original Message- > > From: Stefano Stabellini [mailto:stefano.stabell...@eu.citrix.com] > > Sent: Tuesday, January 20, 2015 1:15 AM > > To: Xu, Quan > > Cc: qemu-devel@nongnu.org; xen-de...@lists.xen.org; > &

[Qemu-devel] [PULL 0/4] Xen tree 2015-01-20

2015-01-20 Thread Stefano Stabellini
The following changes since commit 74acb99737dbedd86654d660c0c20815139a873c: Merge remote-tracking branch 'remotes/kraxel/tags/pull-console-20150119-1' into staging (2015-01-19 13:37:05 +) are available in the git repository at: git://xenbits.xen.org/people/sstabellini/qemu-dm.git xen-

[Qemu-devel] [PULL 3/4] xen: do not use __-named variables in mapcache

2015-01-20 Thread Stefano Stabellini
From: Paolo Bonzini Keep the namespace clean. Signed-off-by: Paolo Bonzini --- xen-mapcache.c | 40 1 file changed, 20 insertions(+), 20 deletions(-) diff --git a/xen-mapcache.c b/xen-mapcache.c index 66da1a6..458069b 100644 --- a/xen-mapcache.c +++

[Qemu-devel] [PULL 4/4] xen: add a lock for the mapcache

2015-01-20 Thread Stefano Stabellini
From: Paolo Bonzini Extend the existing dummy mapcache_lock/unlock macros to cover all of xen-mapcache.c. This prepares for unlocked memory access, when parts of exec.c will not be protected by the BQL. Signed-off-by: Paolo Bonzini --- xen-mapcache.c | 54 +++

[Qemu-devel] [PULL 2/4] Xen: Use the ioreq-server API when available

2015-01-20 Thread Stefano Stabellini
Paul Durrant Acked-by: Stefano Stabellini --- configure | 29 ++ include/hw/xen/xen_common.h | 223 +++ trace-events|9 ++ xen-hvm.c | 160 ++- 4 files changed, 399 inser

[Qemu-devel] [PULL 1/4] Add device listener interface

2015-01-20 Thread Stefano Stabellini
devices. Signed-off-by: Paul Durrant Signed-off-by: Stefano Stabellini Reviewed-by: Paolo Bonzini --- hw/core/qdev.c | 53 +++ include/hw/qdev-core.h | 10 + include/qemu/typedefs.h |1 + 3 files changed, 64 insertions

Re: [Qemu-devel] [PULL 0/4] Xen tree 2015-01-20

2015-01-20 Thread Stefano Stabellini
On Tue, 20 Jan 2015, Peter Maydell wrote: > On 20 January 2015 at 11:19, Stefano Stabellini > wrote: > > The following changes since commit 74acb99737dbedd86654d660c0c20815139a873c: > > > > Merge remote-tracking branch > > 'remotes/kraxel/tags/pull-console-2

[Qemu-devel] [PULL v2 0/4] Xen tree 2015-01-20 v2

2015-01-20 Thread Stefano Stabellini
The following changes since commit 74acb99737dbedd86654d660c0c20815139a873c: Merge remote-tracking branch 'remotes/kraxel/tags/pull-console-20150119-1' into staging (2015-01-19 13:37:05 +) are available in the git repository at: git://xenbits.xen.org/people/sstabellini/qemu-dm.git xen-

[Qemu-devel] [PULL v2 4/4] xen: add a lock for the mapcache

2015-01-20 Thread Stefano Stabellini
From: Paolo Bonzini Extend the existing dummy mapcache_lock/unlock macros to cover all of xen-mapcache.c. This prepares for unlocked memory access, when parts of exec.c will not be protected by the BQL. Signed-off-by: Paolo Bonzini Signed-off-by: Stefano Stabellini --- xen-mapcache.c | 54

[Qemu-devel] [PULL v2 1/4] Add device listener interface

2015-01-20 Thread Stefano Stabellini
devices. Signed-off-by: Paul Durrant Signed-off-by: Stefano Stabellini Reviewed-by: Paolo Bonzini --- hw/core/qdev.c | 53 +++ include/hw/qdev-core.h | 10 + include/qemu/typedefs.h |1 + 3 files changed, 64 insertions

[Qemu-devel] [PULL v2 2/4] Xen: Use the ioreq-server API when available

2015-01-20 Thread Stefano Stabellini
Paul Durrant Signed-off-by: Stefano Stabellini Acked-by: Stefano Stabellini --- configure | 29 ++ include/hw/xen/xen_common.h | 223 +++ trace-events|9 ++ xen-hvm.c |

[Qemu-devel] [PULL v2 3/4] xen: do not use __-named variables in mapcache

2015-01-20 Thread Stefano Stabellini
From: Paolo Bonzini Keep the namespace clean. Signed-off-by: Paolo Bonzini Signed-off-by: Stefano Stabellini --- xen-mapcache.c | 40 1 file changed, 20 insertions(+), 20 deletions(-) diff --git a/xen-mapcache.c b/xen-mapcache.c index 66da1a6

[Qemu-devel] [PATCH] fix QEMU build on Xen/ARM

2015-01-22 Thread Stefano Stabellini
xen_get_vmport_regs_pfn should take a xen_pfn_t argument, not an unsigned long argument (in fact xen_pfn_t is defined as uint64_t on ARM). Also use xc_hvm_param_get instead of the deprecated xc_get_hvm_param. Signed-off-by: Stefano Stabellini diff --git a/include/hw/xen/xen_common.h b/include

Re: [Qemu-devel] [PATCH] pc: piix4_pm: init legacy PCI hotplug when running on Xen

2014-11-04 Thread Stefano Stabellini
Feng, thanks for the email. I was assuming that one of the other maintainers would take care of the patch, but I am happy to submit a pull request for it too. Paolo, Michael? On Tue, 4 Nov 2014, Wu, Feng wrote: > I still see this error in the latest QEMU. I find that this patch is not > merged

Re: [Qemu-devel] [PATCH] pc: piix4_pm: init legacy PCI hotplug when running on Xen

2014-11-04 Thread Stefano Stabellini
On Tue, 4 Nov 2014, Paolo Bonzini wrote: > On 04/11/2014 11:36, Stefano Stabellini wrote: > > Feng, thanks for the email. > > > > I was assuming that one of the other maintainers would take care of the > > patch, but I am happy to submit a pull request for it too. >

Re: [Qemu-devel] [PATCH 2/4] Qemu-Xen-vTPM: Register Xen stubdom vTPM frontend driver

2014-11-05 Thread Stefano Stabellini
On Tue, 4 Nov 2014, Xu, Quan wrote: > > -Original Message- > > From: Stefano Stabellini [mailto:stefano.stabell...@eu.citrix.com] > > Sent: Monday, November 03, 2014 7:54 PM > > To: Xu, Quan > > Cc: qemu-devel@nongnu.org; xen-de...@lists.xen.org; > &

Re: [Qemu-devel] [PATCH 2/4] Qemu-Xen-vTPM: Register Xen stubdom vTPM frontend driver

2014-11-05 Thread Stefano Stabellini
On Wed, 5 Nov 2014, Xu, Quan wrote: > > -Original Message- > > From: Stefano Stabellini [mailto:stefano.stabell...@eu.citrix.com] > > Sent: Wednesday, November 05, 2014 7:01 PM > > To: Xu, Quan > > Cc: Stefano Stabellini; qemu-devel@nongnu.org; xen-de...

Re: [Qemu-devel] [PATCH 2/4] Qemu-Xen-vTPM: Register Xen stubdom vTPM frontend driver

2014-11-06 Thread Stefano Stabellini
On Thu, 6 Nov 2014, Xu, Quan wrote: > > -Original Message- > > From: Stefano Stabellini [mailto:stefano.stabell...@eu.citrix.com] > > Sent: Monday, November 03, 2014 7:54 PM > > To: Xu, Quan > > Cc: qemu-devel@nongnu.org; xen-de...@lists.xen.org; > &

Re: [Qemu-devel] [PATCH 2/4] Qemu-Xen-vTPM: Register Xen stubdom vTPM frontend driver

2014-11-06 Thread Stefano Stabellini
On Thu, 6 Nov 2014, Xu, Quan wrote: > > -Original Message- > > From: Stefano Stabellini [mailto:stefano.stabell...@eu.citrix.com] > > Sent: Thursday, November 06, 2014 11:42 PM > > To: Xu, Quan > > Cc: Stefano Stabellini; qemu-devel@nongnu.org; xen-de...

Re: [Qemu-devel] [PATCH] pc: piix4_pm: init legacy PCI hotplug when running on Xen

2014-11-10 Thread Stefano Stabellini
On Mon, 10 Nov 2014, Zhang, Yang Z wrote: > Igor Mammedov wrote on 2014-05-23: > > if user starts QEMU with "-machine pc,accel=xen", then compat property > > in xenfv won't work and it would cause error: > > "Unsupported bus. Bus doesn't have property 'acpi-pcihp-bsel' set" > > when PCI device is a

Re: [Qemu-devel] [PATCH trivial] xen-hvm: Remove redandant varialbe 'xstate'

2014-11-11 Thread Stefano Stabellini
On Tue, 11 Nov 2014, Chen Gang wrote: > In xen_hvm_change_state_handler(), can pass 'opaque' with type cast to > xen_main_loop_prepare() directly, need not use additional variable for > it. > > Signed-off-by: Chen Gang Acked-by: Stefano Stabellini > xen-hvm.c

Re: [Qemu-devel] [PATCH] xen_disk: fix unmapping of persistent grants

2014-11-12 Thread Stefano Stabellini
gt; - Unmap persistent grants before switching to the closed state, so the >frontend can also free them. > > Signed-off-by: Roger Pau Monné > Reported-and-Tested-by: George Dunlap > Cc: Stefano Stabellini > Cc: Kevin Wolf > Cc: Stefan Hajnoczi > Cc: G

Re: [Qemu-devel] [PATCH v2 for-xen-4.5] xen_disk: fix unmapping of persistent grants

2014-11-13 Thread Stefano Stabellini
p a >single grant if it has been batch-mapped. > - Unmap persistent grants before switching to the closed state, so the >frontend can also free them. > > Signed-off-by: Roger Pau Monné > Reported-by: George Dunlap > Cc: Stefano Stabellini > Cc: Kevin Wolf >

Re: [Qemu-devel] [PATCH v3 for-xen-4.5] xen_disk: fix unmapping of persistent grants

2014-11-14 Thread Stefano Stabellini
>frontend can also free them. > > Signed-off-by: Roger Pau Monné > Reported-by: George Dunlap > Cc: Stefano Stabellini > Cc: Kevin Wolf > Cc: Stefan Hajnoczi > Cc: George Dunlap > Cc: Konrad Rzeszutek Wilk Acked-by: Stefano Stabellini I'll send a pull

[Qemu-devel] [PULL for-2.2 0/2] Xen tree 2014-11-14

2014-11-14 Thread Stefano Stabellini
The following changes since commit c52e67924fbdadfa00668248f5c075542943c54c: Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into staging (2014-11-13 15:44:16 +) are available in the git repository at: git://xenbits.xen.org/people/sstabellini/qemu-dm.git xen-2014-11-14

[Qemu-devel] [PULL for-2.2 1/2] pc: piix4_pm: init legacy PCI hotplug when running on Xen

2014-11-14 Thread Stefano Stabellini
I. From: Igor Mammedov In case of Xen instead of using compat property, just use the fact that xen doesn't use QEMU's fw_cfg/acpi tables to switch piix4_pm into legacy PCI hotplug mode when Xen is enabled. Signed-off-by: Igor Mammedov Signed-off-by: Li Liang Signed-off-by: Stefano Stabe

[Qemu-devel] [PULL for-2.2 2/2] xen_disk: fix unmapping of persistent grants

2014-11-14 Thread Stefano Stabellini
Reported-by: George Dunlap Cc: Stefano Stabellini Cc: Kevin Wolf Cc: Stefan Hajnoczi Cc: George Dunlap Cc: Konrad Rzeszutek Wilk --- hw/block/xen_disk.c | 72 ++- 1 file changed, 66 insertions(+), 6 deletions(-) diff --git a/hw/block

Re: [Qemu-devel] [BUGFIX][PATCH for 2.2 1/1] hw/ide/core.c: Prevent SIGSEGV during migration

2014-11-18 Thread Stefano Stabellini
Konrad, I think we should have this fix in Xen 4.5. Should I go ahead and backport it? On Mon, 17 Nov 2014, Don Slutz wrote: > The other callers to blk_set_enable_write_cache() in this file > already check for s->blk == NULL. > > Signed-off-by: Don Slutz > --- > > I think this is a bugfix that

Re: [Qemu-devel] qemu 2.2 crash on linux hvm domU (full backtrace included)

2014-11-19 Thread Stefano Stabellini
On Wed, 19 Nov 2014, Fabio Fantoni wrote: > Il 19/11/2014 15:56, Don Slutz ha scritto: > > I think I know what is happening here. But you are pointing at the wrong > > change. > > > > commit 9b23cfb76b3a5e9eb5cc899eaf2f46bc46d33ba4 > > > > Is what I am guessing at this time is the issue. I thin

Re: [Qemu-devel] qemu 2.2 crash on linux hvm domU (full backtrace included)

2014-11-19 Thread Stefano Stabellini
ll cases). What happens if you pass vmport=off via --machine, without David Alan Gilbert's patch in QEMU? > -Don Slutz > > > > On 11/19/14 10:52, Stefano Stabellini wrote: > > On Wed, 19 Nov 2014, Fabio Fantoni wrote: > > > Il 19/11/2014 15:56, Don Slutz h

Re: [Qemu-devel] qemu crash with virtio on Xen domUs (backtrace included)

2014-11-24 Thread Stefano Stabellini
CC'ing Paolo. Wen, thanks for the logs. I investigated a little bit and it seems to me that the bug occurs when QEMU tries to unmap only a portion of a memory region previously mapped. That doesn't work with xen-mapcache. See these logs for example: DEBUG address_space_map phys_addr=78ed8b44 v

Re: [Qemu-devel] [v2 2/4] Qemu-Xen-vTPM: Register Xen stubdom vTPM frontend driver

2014-11-24 Thread Stefano Stabellini
On Sun, 23 Nov 2014, Quan Xu wrote: > This drvier transfers any request/repond between TPM xenstubdoms > driver and Xen vTPM stubdom, and facilitates communications between > Xen vTPM stubdom domain and vTPM xenstubdoms driver > > Signed-off-by: Quan Xu This patch needs a better description, see

Re: [Qemu-devel] [v2 3/4] Qemu-Xen-vTPM: Qemu vTPM xenstubdoms driver.

2014-11-24 Thread Stefano Stabellini
On Sun, 23 Nov 2014, Quan Xu wrote: > This driver provides vTPM initialization and sending data and TPM > commends to a Xen stubdom vTPM domain. > > Signed-off-by: Quan Xu We need a better, more detailed, patch description here. > hw/tpm/Makefile.objs | 1 + > hw/tpm/tpm_xenstubdoms.c |

Re: [Qemu-devel] [v2 2/4] Qemu-Xen-vTPM: Register Xen stubdom vTPM frontend driver

2014-11-24 Thread Stefano Stabellini
On Mon, 24 Nov 2014, Stefano Stabellini wrote: > On Sun, 23 Nov 2014, Quan Xu wrote: > > +static void vtpm_backend_changed(struct XenDevice *xendev, const char > > *node) > > +{ > > +struct XenVtpmDev *vtpmdev = container_o

Re: [Qemu-devel] [Xen-devel] qemu crash with virtio on Xen domUs (backtrace included)

2014-11-24 Thread Stefano Stabellini
On Mon, 24 Nov 2014, Stefano Stabellini wrote: > CC'ing Paolo. > > > Wen, > thanks for the logs. > > I investigated a little bit and it seems to me that the bug occurs when > QEMU tries to unmap only a portion of a memory region previously mapped. > That doesn&#x

Re: [Qemu-devel] [Xen-devel] virtio leaks cpu mappings, was: qemu crash with virtio on Xen domUs (backtrace included)

2014-11-24 Thread Stefano Stabellini
On Mon, 24 Nov 2014, Konrad Rzeszutek Wilk wrote: > On Mon, Nov 24, 2014 at 06:44:45PM +0000, Stefano Stabellini wrote: > > On Mon, 24 Nov 2014, Stefano Stabellini wrote: > > > On Mon, 24 Nov 2014, Stefano Stabellini wrote: > > > > CC'ing Paolo. > > >

[Qemu-devel] virtio leaks cpu mappings, was: qemu crash with virtio on Xen domUs (backtrace included)

2014-11-24 Thread Stefano Stabellini
On Mon, 24 Nov 2014, Stefano Stabellini wrote: > On Mon, 24 Nov 2014, Stefano Stabellini wrote: > > CC'ing Paolo. > > > > > > Wen, > > thanks for the logs. > > > > I investigated a little bit and it seems to me that the bug occurs when > &g

Re: [Qemu-devel] [Xen-devel] virtio leaks cpu mappings, was: qemu crash with virtio on Xen domUs (backtrace included)

2014-11-25 Thread Stefano Stabellini
On Tue, 25 Nov 2014, Jason Wang wrote: > On 11/25/2014 02:44 AM, Stefano Stabellini wrote: > > On Mon, 24 Nov 2014, Stefano Stabellini wrote: > >> On Mon, 24 Nov 2014, Stefano Stabellini wrote: > >>> CC'ing Paolo. > >>> > >>> > &g

[Qemu-devel] [PATCH 4/4] virtio-net: do not leak cpu mappings

2014-11-25 Thread Stefano Stabellini
In virtio_net_handle_ctrl unmap the previously mapped out_sg, not a subset of it. This patch fixes an abort() when running on Xen. Signed-off-by: Stefano Stabellini CC: jasow...@redhat.com CC: we...@cn.fujitsu.com CC: m...@redhat.com CC: pbonz...@redhat.com --- hw/net/virtio-net.c |4

[Qemu-devel] [PATCH 1/4] introduce virtqueue_unmap_sg

2014-11-25 Thread Stefano Stabellini
Introduce a function to unmap an sg previously mapped with virtqueue_map_sg. Signed-off-by: Stefano Stabellini CC: jasow...@redhat.com CC: we...@cn.fujitsu.com CC: m...@redhat.com CC: pbonz...@redhat.com --- hw/virtio/virtio.c | 22 ++ include/hw/virtio/virtio.h

[Qemu-devel] [PATCH 0/4] virtio-net: do not leak cpu mappings

2014-11-25 Thread Stefano Stabellini
behaviour is obviously incorrect without Xen too. The patch series fixes the issue by allowing virtio_net_handle_ctrl to unmap the original out_sg iov but still call virtqueue_fill and virtqueue_flush on the modified iov. The first three patches do not introduce any functional changes. Stefano

[Qemu-devel] [PATCH 2/4] use virtqueue_unmap_sg in virtqueue_fill

2014-11-25 Thread Stefano Stabellini
Use virtqueue_unmap_sg to unmap in_sg and out_sg in virtqueue_fill. No functional changes. Signed-off-by: Stefano Stabellini CC: jasow...@redhat.com CC: we...@cn.fujitsu.com CC: m...@redhat.com CC: pbonz...@redhat.com --- hw/virtio/virtio.c | 20 ++-- 1 file changed, 2

[Qemu-devel] [PATCH 3/4] move virtqueue_unmap_sg calls from virtqueue_fill to virtqueue_push

2014-11-25 Thread Stefano Stabellini
from virtio_net_handle_ctrl with an open coded version it in place. No functional changes. Signed-off-by: Stefano Stabellini CC: jasow...@redhat.com CC: we...@cn.fujitsu.com CC: m...@redhat.com CC: pbonz...@redhat.com --- hw/net/virtio-net.c |7 ++- hw/virtio/virtio.c |5 ++--- 2

<    2   3   4   5   6   7   8   9   10   11   >