Re: [Qemu-devel] [PATCH v4 3/7] RTC: Add UIP(update in progress) check logic

2012-03-20 Thread Stefano Stabellini
On Mon, 19 Mar 2012, Zhang, Yang Z wrote: > The UIP(update in progress) is set when RTC is updating. And the update cycle > begins 244us later after UIP is set. And it is cleared when update end. this patch seems good to me > Signed-off-by: Yang Zhang > --- > hw/mc146818rtc.c | 18 +

Re: [Qemu-devel] [PATCH v4 4/7] RTC: Set internal millisecond register to 500ms when reset divider

2012-03-20 Thread Stefano Stabellini
On Mon, 19 Mar 2012, Zhang, Yang Z wrote: > The first update cycle begins one - half seconds later when divider reset is > removing. > > Signed-off-by: Yang Zhang > --- > hw/mc146818rtc.c | 38 +- > 1 files changed, 33 insertions(+), 5 deletions(-) > > dif

Re: [Qemu-devel] [PATCH v4 5/7] RTC:Add RTC update-ended interrupt support

2012-03-20 Thread Stefano Stabellini
On Mon, 19 Mar 2012, Zhang, Yang Z wrote: > Use a timer to emulate update cycle. When update cycle ended and UIE is > setting, then raise an interrupt. The timer runs only when UF or AF is > cleared. The idea is that if the user requests the update-ended interrupt (UIE) we setup a timer to injec

Re: [Qemu-devel] [PATCH v4 5/7] RTC:Add RTC update-ended interrupt support

2012-03-20 Thread Stefano Stabellini
> +/* handle update-ended timer */ > +static void check_update_timer(RTCState *s) > +{ > +uint64_t next_update_time, expire_time; > +uint64_t guest_usec; > +qemu_del_timer(s->update_timer); > +qemu_del_timer(s->update_timer2); > + > +if (!((s->cmos_data[RTC_REG_C] & (REG_C_UF |

Re: [Qemu-devel] [PATCH v4 4/7] RTC: Set internal millisecond register to 500ms when reset divider

2012-03-21 Thread Stefano Stabellini
On Wed, 21 Mar 2012, Zhang, Yang Z wrote: > > > struct tm *tm = &s->current_tm; > > > -int64_t host_usec, guest_sec, guest_usec; > > > +int64_t host_usec, guest_sec, guest_usec, offset_usec, > > > old_guest_usec; > > > > > > host_usec = qemu_get_clock_ns(host_clock) / NS_PER_USEC

Re: [Qemu-devel] [PATCH v4 5/7] RTC:Add RTC update-ended interrupt support

2012-03-21 Thread Stefano Stabellini
On Wed, 21 Mar 2012, Paolo Bonzini wrote: > Il 20/03/2012 19:35, Stefano Stabellini ha scritto: > > This is the function that is used to figure out whether we need the > > timers or not, the condition seems to be: > > > > (Not (REG_C_UF | REG_C_AF)) And (Not (REG

Re: [Qemu-devel] [PATCH v4 5/7] RTC:Add RTC update-ended interrupt support

2012-03-22 Thread Stefano Stabellini
On Thu, 22 Mar 2012, Zhang, Yang Z wrote: > > -Original Message- > > From: Stefano Stabellini [mailto:stefano.stabell...@eu.citrix.com] > > Sent: Wednesday, March 21, 2012 2:04 AM > > > > On Mon, 19 Mar 2012, Zhang, Yang Z wrote: > > > Use a tim

Re: [Qemu-devel] [PATCH v4 5/7] RTC:Add RTC update-ended interrupt support

2012-03-22 Thread Stefano Stabellini
On Wed, 21 Mar 2012, Paolo Bonzini wrote: > Il 21/03/2012 17:54, Stefano Stabellini ha scritto: > >> > > >> > No, you need to set UF in case the code observes it without actually > >> > enabling interrupt delivery on the ISA bus. > > > > Well,

Re: [Qemu-devel] [PATCH v3 1/2] Force timedrift=none on previous machines

2012-03-22 Thread Stefano Stabellini
On Wed, 21 Mar 2012, Paolo Bonzini wrote: > Il 21/03/2012 17:06, Crístian Viana ha scritto: > > The current value for the -rtc timedrift option is none. This patch > > makes sure that the old machines configuration will work the same way > > even after that option changes its default value. > > >

Re: [Qemu-devel] [PATCH V9 1/8] pci_ids: Add INTEL_82599_SFP_VF id.

2012-03-22 Thread Stefano Stabellini
On Wed, 21 Mar 2012, Anthony PERARD wrote: > Signed-off-by: Anthony PERARD Acked-by: Stefano Stabellini

Re: [Qemu-devel] [PATCH V9 4/8] pci.c: Add opaque argument to pci_for_each_device.

2012-03-22 Thread Stefano Stabellini
On Wed, 21 Mar 2012, Anthony PERARD wrote: > Signed-off-by: Anthony PERARD Acked-by: Stefano Stabellini

Re: [Qemu-devel] [QEMU][RFC PATCH 1/6] option: Add -xen-dmid

2012-03-23 Thread Stefano Stabellini
On Thu, 22 Mar 2012, Jan Kiszka wrote: > On 2012-03-22 17:01, Julien Grall wrote: > > With this option, QEMU knows it's ID and can retrieve it's configuration > > from XenStore. > > Isn't this better modeled as a (Xen) machine option? I'd like to avoid > more "special" command line switch prolifer

Re: [Qemu-devel] [QEMU][RFC PATCH 2/6] xen: Add functions to register PCI and IO in Xen

2012-03-23 Thread Stefano Stabellini
On Thu, 22 Mar 2012, Julien Grall wrote: > Add interface for the new xen hypercalls > > Signed-off-by: Julien Grall > --- > hw/xen.h |3 +++ > xen-all.c |2 ++ > xen-stub.c | 13 + > 3 files changed, 18 insertions(+), 0 deletions(-) > > diff --git a/hw/xen.h b/hw/xen.h

Re: [Qemu-devel] [QEMU][RFC PATCH 4/6] xen-pci: Register PCI in Xen

2012-03-23 Thread Stefano Stabellini
On Thu, 22 Mar 2012, Anthony Liguori wrote: > On 03/22/2012 11:01 AM, Julien Grall wrote: > > QEMU will now register PCI in Xen. It will usefull to forward > > IO config space to the right QEMU. > > > > Before to register a PCI device, QEMU will check with XenStore if it is > > autorized to registe

Re: [Qemu-devel] [QEMU][RFC PATCH 6/6] xen: handle qemu disaggregation

2012-03-23 Thread Stefano Stabellini
On Thu, 22 Mar 2012, Julien Grall wrote: > * Register QEMU in Xen as server > * Retrieve it's own shared pages > * Check if the page is already mapping before to populate > > Signed-off-by: Julien Grall > --- > xen-all.c | 62 ++-- > 1 fi

[Qemu-devel] [PATCH 0/2] xen_disk: use NATIVE_AIO and NOCACHE

2012-03-23 Thread Stefano Stabellini
Hi all, this small patch series allows xen_disk to be used correctly with NATIVE_AIO and O_DIRECT. This series should be backported to the stable branch too. Stefano Stabellini (2): xen_disk: open disk with BDRV_O_NOCACHE | BDRV_O_CACHE_WB | BDRV_O_NATIVE_AIO xen_disk: when using

[Qemu-devel] [PATCH 2/2] xen_disk: when using AIO flush after the operation is completed

2012-03-23 Thread Stefano Stabellini
If ioreq->postsync call bdrv_flush when the AIO operation is actually completed. Signed-off-by: Stefano Stabellini --- hw/xen_disk.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/xen_disk.c b/hw/xen_disk.c index 0f265a4..9cb0253 100644 --- a/hw/xen_dis

[Qemu-devel] [PATCH 1/2] xen_disk: open disk with BDRV_O_NOCACHE | BDRV_O_CACHE_WB | BDRV_O_NATIVE_AIO

2012-03-23 Thread Stefano Stabellini
Signed-off-by: Stefano Stabellini --- hw/xen_disk.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/xen_disk.c b/hw/xen_disk.c index 68fa36a..0f265a4 100644 --- a/hw/xen_disk.c +++ b/hw/xen_disk.c @@ -584,10 +584,10 @@ static int blk_init(struct XenDevice *xendev

Re: [Qemu-devel] [QEMU][RFC PATCH 3/6] memory: Add xen memory hook

2012-03-26 Thread Stefano Stabellini
On Sun, 25 Mar 2012, Avi Kivity wrote: > On 03/23/2012 06:37 PM, Jan Kiszka wrote: > > On 2012-03-23 16:08, Julien Grall wrote: > > > On 03/22/2012 05:44 PM, Jan Kiszka wrote: > > >>> > > >>> static void core_region_nop(MemoryListener *listener, > > >>> diff --git a/ioport.c b/ioport.c > > >>> in

Re: [Qemu-devel] [QEMU][RFC PATCH 4/6] xen-pci: Register PCI in Xen

2012-03-26 Thread Stefano Stabellini
On Sun, 25 Mar 2012, Avi Kivity wrote: > On 03/23/2012 01:02 PM, Stefano Stabellini wrote: > > Maybe the best thing to do is to have a set of machine specific options > > to select what devices need to be built in the machine. > > Most devices already can be dynamically sele

Re: [Qemu-devel] [QEMU][RFC PATCH 4/6] xen-pci: Register PCI in Xen

2012-03-26 Thread Stefano Stabellini
On Mon, 26 Mar 2012, Avi Kivity wrote: > > > You may want your own host/pci bridge that lacks the device 0 > > > configuration space. > > > > In order not to disrupt the emulated machine in QEMU too much, I was > > thinking to let QEMU create the default device 0 and device 1: > > > > 00:00.0 Host

Re: [Qemu-devel] [QEMU][RFC PATCH 4/6] xen-pci: Register PCI in Xen

2012-03-26 Thread Stefano Stabellini
On Mon, 26 Mar 2012, Avi Kivity wrote: > > > What about if two BARs (from different devices) are configured for the > > > same address ranges? > > > > I think that it should have the same chance of happening as if there was > > just one QEMU, because from the guest OS and firmware POV the emulated

[Qemu-devel] [PULL 0/2] xen_disk: use NATIVE_AIO and NOCACHE

2012-03-27 Thread Stefano Stabellini
Anthony, please pull this small patch series that allows xen_disk to be used correctly with NATIVE_AIO and O_DIRECT. This series should be backported to the stable branch too. Stefano Stabellini (2): xen_disk: open disk with BDRV_O_NOCACHE | BDRV_O_CACHE_WB | BDRV_O_NATIVE_AIO

[Qemu-devel] [PATCH 1/2] xen_disk: open disk with BDRV_O_NOCACHE | BDRV_O_CACHE_WB | BDRV_O_NATIVE_AIO

2012-03-27 Thread Stefano Stabellini
Signed-off-by: Stefano Stabellini --- hw/xen_disk.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/xen_disk.c b/hw/xen_disk.c index 68fa36a..0f265a4 100644 --- a/hw/xen_disk.c +++ b/hw/xen_disk.c @@ -584,10 +584,10 @@ static int blk_init(struct XenDevice *xendev

[Qemu-devel] [PATCH 2/2] xen_disk: when using AIO flush after the operation is completed

2012-03-27 Thread Stefano Stabellini
If ioreq->postsync call bdrv_flush when the AIO operation is actually completed. Signed-off-by: Stefano Stabellini --- hw/xen_disk.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/xen_disk.c b/hw/xen_disk.c index 0f265a4..9cb0253 100644 --- a/hw/xen_dis

[Qemu-devel] [PULL 0/2] simple Xen fixes

2012-03-27 Thread Stefano Stabellini
Hi Anthony, I have a couple of old Xen one-line fixes laying around: Stefano Stabellini (2): xen_console: ignore console disconnect events from console/0 xen_disk: detach the blkdev before bdrv_delete hw/xen_console.c |3 +++ hw/xen_disk.c|1 + 2 files changed, 4

[Qemu-devel] [PATCH 2/2] xen_disk: detach the blkdev before bdrv_delete

2012-03-27 Thread Stefano Stabellini
We need to detach the blkdev from the BlockDriverState before calling bdrv_delete. Signed-off-by: Stefano Stabellini --- hw/xen_disk.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/hw/xen_disk.c b/hw/xen_disk.c index 68fa36a..bf06fc1 100644 --- a/hw/xen_disk.c +++ b

[Qemu-devel] [PATCH 1/2] xen_console: ignore console disconnect events from console/0

2012-03-27 Thread Stefano Stabellini
The first console has a different location compared to other PV devices (console, rather than device/console/0) and doesn't obey the xenstore state protocol. We already special case the first console in con_init and con_initialise, we should also do it in con_disconnect. Signed-off-by: St

Re: [Qemu-devel] [PULL 0/2] xen_disk: use NATIVE_AIO and NOCACHE

2012-03-27 Thread Stefano Stabellini
On Tue, 27 Mar 2012, Christoph Hellwig wrote: > On Tue, Mar 27, 2012 at 04:48:19PM +0100, Stefano Stabellini wrote: > > Anthony, > > please pull this small patch series that allows xen_disk to be used > > correctly with NATIVE_AIO and O_DIRECT. > > > > This s

[Qemu-devel] [PATCH 0 of 5] xen mapcache fixes and improvements

2011-05-18 Thread Stefano Stabellini
Hi all, this patch series introduces a series of fixes and improvements to the xen mapcache in qemu. The list of patches with a diffstat follows: Stefano Stabellini (5): xen: fix qemu_map_cache with size != MCACHE_BUCKET_SIZE xen: remove qemu_map_cache_unlock xen: remove

Re: [Qemu-devel] [PATCH] xen: Use conditional compilation for xen map cache (fixes w32 builds)

2011-05-18 Thread Stefano Stabellini
/xenbits.xen.org/people/sstabellini/qemu-dm.git mapcache_fixes_2 --- commit 8e1040ee219513d2c692f921f80e2d850aaa47c7 Author: Stefano Stabellini Date: Fri May 13 11:58:59 2011 + xen: remove xen_map_block and xen_unmap_block Replace xen_map_block with qemu_map_cache with

Re: [Qemu-devel] [PATCH 4/5] exec.c: refactor cpu_physical_memory_map

2011-05-19 Thread Stefano Stabellini
On Wed, 18 May 2011, Paolo Bonzini wrote: > On 05/18/2011 07:52 PM, stefano.stabell...@eu.citrix.com wrote: > > From: Stefano Stabellini > > > > Introduce qemu_ram_ptr_length that takes an address and a size as > > parameters rather than just an address. > > > &

Re: [Qemu-devel] [PATCH] xen: Use conditional compilation for xen map cache (fixes w32 builds)

2011-05-19 Thread Stefano Stabellini
On Thu, 19 May 2011, Alexander Graf wrote: > On 05/18/2011 08:27 PM, Stefano Stabellini wrote: > > On Wed, 18 May 2011, Stefan Weil wrote: > >> The current implementation used stubs for systems without XEN. > >> This is unusual for QEMU and adds unneeded dependencies. &g

[Qemu-devel] [PATCH v2 0/5] xen mapcache fixes and improvements

2011-05-19 Thread Stefano Stabellini
Hi all, this patch series introduces a series of fixes and improvements to the xen mapcache in qemu. Changes compared to v1: - remove the two includes from xen-mapcache.h. The list of patches with a diffstat follows: Stefano Stabellini (5): xen: fix qemu_map_cache with size

Re: [Qemu-devel] [Xen-devel] [PATCH] xen: fix interrupt routing

2011-05-19 Thread Stefano Stabellini
On Thu, 19 May 2011, Ian Campbell wrote: > On Wed, 2011-05-18 at 18:53 +0100, Stefano Stabellini wrote: > > From: Stefano Stabellini > > > > Match the routing informations built by seabios: > > > > - remove i440fx_write_config_xen > > we don't n

Re: [Qemu-devel] [PATCH] xen: fix interrupt routing

2011-05-19 Thread Stefano Stabellini
On Thu, 19 May 2011, Isaku Yamahata wrote: > On Wed, May 18, 2011 at 06:53:40PM +0100, stefano.stabell...@eu.citrix.com > wrote: > > From: Stefano Stabellini > > > > Match the routing informations built by seabios: > > > > - remove i440fx_write_config_xe

[Qemu-devel] [PATCH] xen: use uint64_t instead of target_ulong in cpu_ioreq_move

2011-05-20 Thread Stefano Stabellini
cpu_ioreq_move might move 8 bytes at a time so we must make sure that the temporary variable can hold 8 bytes. Signed-off-by: Stefano Stabellini --- xen-all.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/xen-all.c b/xen-all.c index 0eac202..6cb504c 100644 --- a/xen

[Qemu-devel] [PATCH] xen: fix interrupt routing

2011-05-26 Thread Stefano Stabellini
t the number of PIIX3-xen interrupts lines to 128; Signed-off-by: Stefano Stabellini diff --git a/hw/pc.h b/hw/pc.h index 0dcbee7..6d5730b 100644 --- a/hw/pc.h +++ b/hw/pc.h @@ -176,7 +176,6 @@ struct PCII440FXState; typedef struct PCII440FXState PCII440FXState; PCIBus *i440fx_init(PCII440FX

Re: [Qemu-devel] [PATCH] xen: fix interrupt routing

2011-05-31 Thread Stefano Stabellini
On Sat, 28 May 2011, Alexander Graf wrote: > > On 26.05.2011, at 17:48, Stefano Stabellini wrote: > > > xen: fix interrupt routing > > > > - remove i440FX-xen and i440fx_write_config_xen > > we don't need to intercept pci config writes to i440FX anymor

Re: [Qemu-devel] Question on virtio disk maximum index and maximum partition

2011-06-01 Thread Stefano Stabellini
On Wed, 1 Jun 2011, Wei Liu wrote: > That's exactly what I'm seeing... > > Maybe I should modify the checking and make a exception for virtio > disk? Stefano, what would you say? That is not a check, it is just the upper limit to decode "vda1" or "vde2" in a disk number and partition number. I wo

[Qemu-devel] [PATCH] xen-mapcache: remember the last page address rather then the last address_index

2011-06-06 Thread Stefano Stabellini
A single address_index corresponds to multiple pages that might or might not be mapped. It is better to just remember the last page address for the sake of this optimization, so that we are sure that it is mapped. Signed-off-by: Stefano Stabellini diff --git a/xen-mapcache.c b/xen-mapcache.c

Re: [Qemu-devel] [PATCH] xen: avoid tracking the region 0xa0000 - 0xbffff

2011-06-14 Thread Stefano Stabellini
On Tue, 14 Jun 2011, Jan Kiszka wrote: > On 2011-06-14 12:54, Alexander Graf wrote: > > > > On 03.06.2011, at 17:56, > > wrote: > > > >> From: Stefano Stabellini > >> > >> Xen can only do dirty bit tracking for one memory region, so we s

Re: [Qemu-devel] [PATCH] xen: avoid tracking the region 0xa0000 - 0xbffff

2011-06-14 Thread Stefano Stabellini
On Tue, 14 Jun 2011, Alexander Graf wrote: > On 03.06.2011, at 17:56, > wrote: > > > From: Stefano Stabellini > > > > Xen can only do dirty bit tracking for one memory region, so we should > > explicitly avoid trying to track the legacy VGA region between 0xa

Re: [Qemu-devel] [PATCH] xen: fix interrupt routing

2011-06-14 Thread Stefano Stabellini
On Tue, 14 Jun 2011, Jan Kiszka wrote: > I bet the motivation is to have an IRQ route that is independent of > QEMU, thus can be discovered inside the Xen kernel and then remains > stable - or is simply hard-wired. Device assignment? Direct legacy IRQ > injection from the kernel? > This code pred

Re: [Qemu-devel] [Xen-devel] Re: [PATCH] xen: fix interrupt routing

2011-06-14 Thread Stefano Stabellini
ave several on my testboxes. Also give a look at the Intel Multiprocessor Specification, section 3.6.2.3: as you can see from the diagram in "Symmetric I/O Mode" all the interrupts are routed through the IOAPIC directly. > Did this really give you actual performance/latency/scalabil

Re: [Qemu-devel] [PATCH] xen: avoid tracking the region 0xa0000 - 0xbffff

2011-06-14 Thread Stefano Stabellini
On Tue, 14 Jun 2011, Alexander Graf wrote: > On 14.06.2011, at 13:48, Stefano Stabellini wrote: > > > On Tue, 14 Jun 2011, Alexander Graf wrote: > >> On 03.06.2011, at 17:56, > >> wrote: > >> > >>> From: Stefano Stabellini > >>>

Re: [Qemu-devel] [PATCH] xen: fix interrupt routing

2011-06-14 Thread Stefano Stabellini
On Tue, 14 Jun 2011, Jan Kiszka wrote: > On 2011-06-14 15:27, Stefano Stabellini wrote: > > On Tue, 14 Jun 2011, Alexander Graf wrote: > >>>>>>> static int i440fx_load_old(QEMUFile* f, void *opaque, int version_id) > >>>>>>> { > >&

Re: [Qemu-devel] [Xen-devel] Re: [PATCH] xen: fix interrupt routing

2011-06-15 Thread Stefano Stabellini
On Wed, 15 Jun 2011, Alexander Graf wrote: > > commit 973bb091a967fdec37a1bc8fe30d46a483d2903d > > Author: Stefano Stabellini > > Date: Tue May 17 12:10:36 2011 + > > > >xen: fix interrupt routing > > > >- remove i440FX-xen and i440f

Re: [Qemu-devel] [PATCH] xen: avoid tracking the region 0xa0000 - 0xbffff

2011-06-15 Thread Stefano Stabellini
On Wed, 15 Jun 2011, Alexander Graf wrote: > Please add a comment here, explaining that Xen can only handle a single dirty > log region for now, and that we want the linear framebuffer to be that > region. Also, please resend with proper patch headers and I'll pull it into > the xen-next tree. >

[Qemu-devel] [PATCH] xen: only track the linear framebuffer

2011-06-15 Thread Stefano Stabellini
Xen can only do dirty bit tracking for one memory region, so we should explicitly avoid trying to track anything but the vga vram region. Signed-off-by: Stefano Stabellini diff --git a/xen-all.c b/xen-all.c index 9a5c3ec..fa1d2e1 100644 --- a/xen-all.c +++ b/xen-all.c @@ -214,6 +214,7 @@ static

[Qemu-devel] [PATCH v2] xen: fix interrupt routing

2011-06-15 Thread Stefano Stabellini
ge to update the PCI link routing; - set the number of PIIX3-xen interrupts line to 128; Signed-off-by: Stefano Stabellini diff --git a/hw/pc.h b/hw/pc.h index 0dcbee7..6d5730b 100644 --- a/hw/pc.h +++ b/hw/pc.h @@ -176,7 +176,6 @@ struct PCII440FXState; typedef struct PCII440FXState PCII440FX

[Qemu-devel] [PATCH 0/3] xen: support PV on HVM guests

2011-06-16 Thread Stefano Stabellini
could, please let me know if you have any suggestions to improve it. Stefano Stabellini (2): pci: export pci_unplug_device xen: implement unplug protocol in xen_platform Steven Smith (1): xen: Add the Xen platform pci device Makefile.target |2 + hw/hw.h |

Re: [Qemu-devel] [PATCH] Support logging xen-guest console

2011-06-20 Thread Stefano Stabellini
On Mon, 20 Jun 2011, Chunyan Liu wrote: > Add code to support logging xen-domU console, as what xenconsoled does. Log > info > will be saved in /var/log/xen/console/guest-domUname.log. > > Signed-off-by: Chunyan Liu > --- > hw/xen_console.c | 63 >

[Qemu-devel] [ANNOUNCE] xen-stable-0.15 qemu branch

2011-07-27 Thread Stefano Stabellini
Hi all, you might have noticed that there is a number of Xen patches to Qemu floating around and it is difficul to keep track of them for both Qemu and Xen maintainers. For this reason I have setup a git branch to collect them all in a single place: git://xenbits.xen.org/people/sstabellini/qemu-dm

Re: [Qemu-devel] [PATCH] xen-mapcache: Fix rlimit set size.

2011-08-02 Thread Stefano Stabellini
On Mon, 1 Aug 2011, Anthony PERARD wrote: > Previously, the address space soft limit was set mcache_max_size. So, > before the mcache_max_size was reached by the mapcache, QEMU was killed > for overuse of the virtual address space. > > This patch fix that by setting the soft limit to mcache_max_si

Re: [Qemu-devel] [Xen-devel] [PATCH] xen-mapcache: Fix rlimit set size.

2011-08-02 Thread Stefano Stabellini
On Tue, 2 Aug 2011, Jan Beulich wrote: > >>> Anthony PERARD 08/01/11 9:27 PM >>> > >Previously, the address space soft limit was set mcache_max_size. So, > >before the mcache_max_size was reached by the mapcache, QEMU was killed > >for overuse of the virtual address space. > > > >This patch fix

Re: [Qemu-devel] [Xen-devel] Re: [PATCH] xen-mapcache: Fix rlimit set size.

2011-08-03 Thread Stefano Stabellini
On Wed, 3 Aug 2011, Jan Beulich wrote: > >>> Stefano Stabellini 08/03/11 12:01 AM >>> > >if (rlimit_as.rlim_max < MCACHE_MAX_SIZE) { > > This condition minimally needs to include what Anthony's original version had. right > >if (qemu is privil

Re: [Qemu-devel] [PATCH V2] xen-mapcache: Fix rlimit set size.

2011-08-12 Thread Stefano Stabellini
On Thu, 4 Aug 2011, Anthony PERARD wrote: > Previously, the address space soft limit was set mcache_max_size. So, > before the mcache_max_size was reached by the mapcache, QEMU was killed > for overuse of the virtual address space. > > This patch fix that by setting the soft limit the maximum than

Re: [Qemu-devel] qtest: setitimer() failures on Darwin and illumos

2012-05-29 Thread Stefano Stabellini
On Mon, 28 May 2012, Paolo Bonzini wrote: > Il 28/05/2012 21:40, Andreas Färber ha scritto: > > I'm seeing qemu-timer.c:unix_rearm_timer()'s setitimer() abort with > > EINVAL during `make check` on both platforms. The value of > > nearest_delta_ns appears to be INT64_MAX. Is this expected? Is it >

[Qemu-devel] qemu_rearm_alarm_timer: do not call rearm if the next deadline is INT64_MAX

2012-05-29 Thread Stefano Stabellini
removes the duplicated code, always calling qemu_next_alarm_deadline and only rearming the timer if the deadline is less than INT64_MAX. Signed-off-by: Stefano Stabellini diff --git a/qemu-timer.c b/qemu-timer.c index de98977..81ff824 100644 --- a/qemu-timer.c +++ b/qemu-timer.c @@ -112,14

Re: [Qemu-devel] [PATCH 1.1?] qemu_rearm_alarm_timer: do not call rearm if the next deadline is INT64_MAX

2012-05-29 Thread Stefano Stabellini
On Tue, 29 May 2012, Stefan Weil wrote: > Am 29.05.2012 15:35, schrieb Stefano Stabellini: > > qemu_rearm_alarm_timer partially duplicates the code in > > qemu_next_alarm_deadline to figure out if it needs to rearm the timer. > > If it calls qemu_next_alarm_deadline, it al

Re: [Qemu-devel] [PATCH 1.1?] qemu_rearm_alarm_timer: do not call rearm if the next deadline is INT64_MAX

2012-05-29 Thread Stefano Stabellini
On Tue, 29 May 2012, Stefan Weil wrote: > Yes, we could set the upper limit to LONG_MAX seconds for some > timers, but I did not want to have a dependency of the > upper limit on sizeof(long). The function win32_rearm_timer > only allows 4294967 seconds. Is there any reason why we > should allow ti

Re: [Qemu-devel] [PATCH, v2] qemu/xendisk: set maximum number of grants to be used

2012-05-31 Thread Stefano Stabellini
On Thu, 31 May 2012, Jan Beulich wrote: > Legacy (non-pvops) gntdev drivers may require this to be done when the > number of grants intended to be used simultaneously exceeds a certain > driver specific default limit. > > Change in v2: Double the number requested, as we need to account for > the a

Re: [Qemu-devel] Proposed patch: huge RX speedup for hw/e1000.c

2012-05-31 Thread Stefano Stabellini
On Thu, 31 May 2012, Paolo Bonzini wrote: > Il 31/05/2012 00:53, Luigi Rizzo ha scritto: > > The image contains my fast packet generator "pkt-gen" (a stock > > traffic generator such as netperf etc. is too slow to show the > > problem). pkt-gen can send about 1Mpps in this configuration using > > -

Re: [Qemu-devel] [PATCH, v3] qemu/xendisk: set maximum number of grants to be used

2012-05-31 Thread Stefano Stabellini
On Thu, 31 May 2012, Jan Beulich wrote: > Legacy (non-pvops) gntdev drivers may require this to be done when the > number of grants intended to be used simultaneously exceeds a certain > driver specific default limit. > > Change in v2: Double the number requested, as we need to account for > the a

Re: [Qemu-devel] Proposed patch: huge RX speedup for hw/e1000.c

2012-05-31 Thread Stefano Stabellini
On Thu, 31 May 2012, Paolo Bonzini wrote: > Il 31/05/2012 13:06, Stefano Stabellini ha scritto: > >> > For Xen I think this is not possible at the moment because it doesn't > >> > implement rx notification. > > > > Why do you say that? Xen supports th

Re: [Qemu-devel] [PATCH, v3] qemu/xendisk: set maximum number of grants to be used

2012-05-31 Thread Stefano Stabellini
On Thu, 31 May 2012, Jan Beulich wrote: > >>> On 31.05.12 at 13:27, Stefano Stabellini > >>> > wrote: > > On Thu, 31 May 2012, Jan Beulich wrote: > >> Legacy (non-pvops) gntdev drivers may require this to be done when the > >> number of grants i

Re: [Qemu-devel] [PATCH 2/2] xen: Don't peek behind the BlockDriverState abstraction

2012-06-05 Thread Stefano Stabellini
On Tue, 5 Jun 2012, Markus Armbruster wrote: > First offender is xen_config_dev_blk()'s use of disk->bdrv->filename. > Get the filename from disk->opts instead. Same result, except for > snapshots: there, we now get the filename specified by the user > instead of the name of the temporary image cr

[Qemu-devel] [BUG QEMU 1.1] virtio-9p-handle does not compile

2012-06-06 Thread Stefano Stabellini
Hi Anthony, currently QEMU 1.1 doesn't compile virtfs correctly on Ubuntu: qemu/hw/9pfs/virtio-9p-handle.c: In function ‘handle_update_file_cred’: qemu/hw/9pfs/virtio-9p-handle.c:66:58: error: ‘AT_EMPTY_PATH’ undeclared (first use in this function) qemu/hw/9pfs/virtio-9p-handle.c:66:58: note: eac

Re: [Qemu-devel] [PATCH 2/2] xen: Don't peek behind the BlockDriverState abstraction

2012-06-06 Thread Stefano Stabellini
On Wed, 6 Jun 2012, Markus Armbruster wrote: > Stefano Stabellini writes: > > On Tue, 5 Jun 2012, Markus Armbruster wrote: > >> First offender is xen_config_dev_blk()'s use of disk->bdrv->filename. > >> Get the filename from disk->opts instead. Same res

Re: [Qemu-devel] [PATCH] configure: Fix build for some versions of glibc (9pfs)

2012-06-07 Thread Stefano Stabellini
patch. Acked-by: Stefano Stabellini > configure |4 > 1 file changed, 4 insertions(+) > > diff --git a/configure b/configure > index 799ad0f..f737f6c 100755 > --- a/configure > +++ b/configure > @@ -2816,7 +2816,11 @@ fi > open_by_hande_at=no > cat > $TMPC

Re: [Qemu-devel] [PATCH v2 0/2] xen: Clean up BlockDriverState use

2012-06-07 Thread Stefano Stabellini
On Wed, 6 Jun 2012, Markus Armbruster wrote: > Compile tested only. Stefano, please give it a whirl. > > v2: Moved a declaration to an inner block on Stefano's request. > > Markus Armbruster (2): > xen: Don't change -drive if=xen device name during machine init > xen: Don't peek behind the B

Re: [Qemu-devel] [PATCH] configure: Fix build for some versions of glibc (9pfs)

2012-06-08 Thread Stefano Stabellini
On Thu, 7 Jun 2012, Stefan Weil wrote: > Some versions declare open_by_handle_at, but don't define AT_EMPTY_PATH. > Extend the check in configure to test both preconditions. > > Signed-off-by: Stefan Weil I have just noticed that this issue also affects QEMU 1.0.x, but we don't have a check for

Re: [Qemu-devel] [PATCH 1.1?] qemu_rearm_alarm_timer: do not call rearm if the next deadline is INT64_MAX

2012-06-11 Thread Stefano Stabellini
On Wed, 30 May 2012, Anthony Liguori wrote: > >> Reviewed-by: Stefan Weil > >> > >> This patch clearly improves the current code and fixes > >> an abort on Darwin (reported by Andreas Färber) and maybe > >> other hosts. Therefore I changed the subject and suggest > >> to consider this patch for QEM

[Qemu-devel] [PULL] qemu/xendisk fix

2012-06-11 Thread Stefano Stabellini
Hi Anthony, please pull one fix for xen_disk from here: git://xenbits.xen.org/people/sstabellini/qemu-dm.git for_1.1.1 The fix should be applied to the 1.1.x stable tree too. Jan Beulich (1): qemu/xendisk: set maximum number of grants to be used hw/xen_disk.c | 14 ++ 1 fi

Re: [Qemu-devel] [Xen-devel] [PATCH, v3] qemu/xendisk: set maximum number of grants to be used

2012-06-11 Thread Stefano Stabellini
On Fri, 8 Jun 2012, Ian Jackson wrote: > Stefano Stabellini writes ("Re: [Xen-devel] [PATCH, v3] qemu/xendisk: set > maximum number of grants to be used"): > > On Thu, 31 May 2012, Jan Beulich wrote: > > > > It should be applied to qemu-xen-traditional too. >

Re: [Qemu-devel] [Xen-devel] [PATCH, v3] qemu/xendisk: set maximum number of grants to be used

2012-06-11 Thread Stefano Stabellini
On Mon, 11 Jun 2012, Stefano Stabellini wrote: > On Fri, 8 Jun 2012, Ian Jackson wrote: > > Stefano Stabellini writes ("Re: [Xen-devel] [PATCH, v3] qemu/xendisk: set > > maximum number of grants to be used"): > > > On Thu, 31 May 2012, Jan Beulich wrote: > >

Re: [Qemu-devel] [PULL] qemu/xendisk fix

2012-06-12 Thread Stefano Stabellini
On Mon, 11 Jun 2012, Anthony Liguori wrote: > On 06/11/2012 05:14 AM, Stefano Stabellini wrote: > > Hi Anthony, > > please pull one fix for xen_disk from here: > > > > git://xenbits.xen.org/people/sstabellini/qemu-dm.git for_1.1.1 > > > > The fix should

Re: [Qemu-devel] [PATCH] configure: Fix build for some versions of glibc (9pfs)

2012-06-12 Thread Stefano Stabellini
On Fri, 8 Jun 2012, Stefano Stabellini wrote: > On Thu, 7 Jun 2012, Stefan Weil wrote: > > Some versions declare open_by_handle_at, but don't define AT_EMPTY_PATH. > > Extend the check in configure to test both preconditions. > > > > Signed-off-by: Stefan Weil &g

Re: [Qemu-devel] qemu_rearm_alarm_timer: do not call rearm if the next deadline is INT64_MAX

2012-06-12 Thread Stefano Stabellini
On Tue, 12 Jun 2012, Andreas Färber wrote: > Am 12.06.2012 10:24, schrieb Andreas Färber: > > Am 29.05.2012 15:35, schrieb Stefano Stabellini: > > The check-qtest-i386 qemu-system-i386 process now hangs at ~98% CPU, Does this mean that increasing the timeout caused a busy loop s

Re: [Qemu-devel] qemu_rearm_alarm_timer: do not call rearm if the next deadline is INT64_MAX

2012-06-12 Thread Stefano Stabellini
On Tue, 12 Jun 2012, Andreas Färber wrote: > Am 12.06.2012 14:37, schrieb Stefano Stabellini: > > On Tue, 12 Jun 2012, Andreas Färber wrote: > >> Am 12.06.2012 10:24, schrieb Andreas Färber: > >>> Am 29.05.2012 15:35, schrieb Stefano Stabellini: > >>> The

Re: [Qemu-devel] [PATCH V12 5/9] Revert "pci: don't export an internal function"

2012-06-13 Thread Stefano Stabellini
On Tue, 12 Jun 2012, Michael S. Tsirkin wrote: > On Tue, Jun 12, 2012 at 04:05:19PM +0100, Anthony PERARD wrote: > > This reverts commit 94a09e2c846374a96719cda2b4e1312d8c4b08a7. > > > > This function is used by a later patch to parse the BDF of the device to > > passthrough. > > > > Signed-off-b

Re: [Qemu-devel] [PATCH v3 0/3] xen: Clean up BlockDriverState use

2012-06-13 Thread Stefano Stabellini
On Wed, 13 Jun 2012, Markus Armbruster wrote: > Xen compile-tested only. Stefano, please give it a whirl. > > v3: Replaced bdrv_get_format() on Peter's request > > v2: Moved a declaration to an inner block on Stefano's request. > > Markus Armbruster (3): > block: Replace bdrv_get_format() by

Re: [Qemu-devel] [PATCH V12 5/9] Revert "pci: don't export an internal function"

2012-06-13 Thread Stefano Stabellini
On Wed, 13 Jun 2012, Jan Kiszka wrote: > On 2012-06-12 17:15, Michael S. Tsirkin wrote: > > On Tue, Jun 12, 2012 at 04:05:19PM +0100, Anthony PERARD wrote: > >> This reverts commit 94a09e2c846374a96719cda2b4e1312d8c4b08a7. > >> > >> This function is used by a later patch to parse the BDF of the dev

Re: [Qemu-devel] [PATCH V13 0/9] Xen PCI Passthrough

2012-06-15 Thread Stefano Stabellini
On Thu, 14 Jun 2012, Michael S. Tsirkin wrote: > On Thu, Jun 14, 2012 at 06:01:40PM +0100, Anthony PERARD wrote: > > Hi all, > > > > This patch series introduces the PCI passthrough for Xen. > > > > Changes since the last version: > > - New patch that introduce a new qdev-property pci-host-deva

Re: [Qemu-devel] [PATCH 2/2] xenstore: Use

2012-06-15 Thread Stefano Stabellini
On Fri, 15 Jun 2012, Juan Quintela wrote: > Anthony PERARD wrote: > > In the next release of Xen (4.2), xs.h became deprecated. > > > > Signed-off-by: Anthony PERARD > > --- > > configure |2 +- > > hw/xen_common.h |6 +- > > 2 files changed, 6 insertions(+), 2 deletions(-) > >

Re: [Qemu-devel] [PATCH 0/2] xen: Deprecation of .

2012-06-15 Thread Stefano Stabellini
On Fri, 15 Jun 2012, Anthony PERARD wrote: > Considering that will be deprecated in the next release of Xen, this > two > patches clean a bit the inclusion of xs.h and changes it in a single place. > > Anthony PERARD (2): > xen: Reorganize includes of Xen headers. > xenstore: Use > > conf

Re: [Qemu-devel] [PATCH 1/2] serial: fix retry logic

2012-04-02 Thread Stefano Stabellini
On Mon, 2 Apr 2012, Anthony Liguori wrote: > I'm not sure if the retry logic has ever worked when not using FIFO mode. I > found this while writing a test case although code inspection confirms it is > definitely broken. > > The TSR retry logic will never actually happen because it is guarded by

Re: [Qemu-devel] [Xen-devel] [XEN][RFC PATCH 14/15] xl-parsing: Parse the new option device_models

2012-04-03 Thread Stefano Stabellini
On Mon, 2 Apr 2012, Ian Jackson wrote: > Julien Grall writes ("[Xen-devel] [XEN][RFC PATCH 14/15] xl-parsing: Parse > the new option device_models"): > > For the support of multiple ioreq server, we add a new option > > "device_models". > > It's an array of device model, for each device model, we

Re: [Qemu-devel] [Xen-devel] [XEN][RFC PATCH 14/15] xl-parsing: Parse the new option device_models

2012-04-03 Thread Stefano Stabellini
On Tue, 3 Apr 2012, Ian Jackson wrote: > Julien Grall writes ("Re: [Xen-devel] [XEN][RFC PATCH 14/15] xl-parsing: > Parse the new option device_models"): > > On 04/03/2012 02:31 PM, Ian Jackson wrote: > > > Are the PCI addresses not assigned in a deterministic fashion by code > > > in qemu-dm, in

Re: [Qemu-devel] [PATCH] MSI / MSIX injection for Xen HVM

2012-04-04 Thread Stefano Stabellini
On Tue, 3 Apr 2012, Wei Liu (Intern) wrote: > On Thu, 2012-03-01 at 15:56 +, Paolo Bonzini wrote: > > Il 01/03/2012 15:50, Stefano Stabellini ha scritto: > > >>> > > That is a good point actually: we already have lapic emulation in > > >>> > &g

Re: [Qemu-devel] [PATCH 0/0] MSI/MSIX injection for Xen HVM guests

2012-04-05 Thread Stefano Stabellini
On Thu, 5 Apr 2012, Paolo Bonzini wrote: > Il 05/04/2012 11:32, Wei Liu ha scritto: > > Implement a simple Xen APIC module and use it to deliver MSI/MSIX for > > Xen HVM guests. > > Only skimmed the patch but yeah, this is what I had in mind. Thanks! It looks good to me too. Paolo, can I add you

[Qemu-devel] [PATCH] xen: handle backend deletion from xenstore

2012-04-11 Thread Stefano Stabellini
Signed-off-by: Stefano Stabellini --- hw/xen_backend.c | 17 + hw/xen_disk.c|4 2 files changed, 13 insertions(+), 8 deletions(-) diff --git a/hw/xen_backend.c b/hw/xen_backend.c index d876cab..555da41 100644 --- a/hw/xen_backend.c +++ b/hw/xen_backend.c @@ -589,7

Re: [Qemu-devel] [PATCH 2/2] Xen: Add xen-apic support and hook it up.

2012-04-11 Thread Stefano Stabellini
Jan, Anthony, any opinions on this patch? If it is OK for you, I am going to include it in the next Xen pull request. On Thu, 5 Apr 2012, Wei Liu (Intern) wrote: > > Signed-off-by: Wei Liu > --- > Makefile.target |2 +- > hw/pc.c |8 + > hw/xen_apic.c | 90 > ++

Re: [Qemu-devel] [PATCH 2/2] Xen: Add xen-apic support and hook it up.

2012-04-11 Thread Stefano Stabellini
On Wed, 11 Apr 2012, Peter Maydell wrote: > On 5 April 2012 10:35, Wei Liu wrote: > > > > --- /dev/null > > +++ b/hw/xen_apic.c > > @@ -0,0 +1,90 @@ > > +/* > > + * Xen basic APIC support > > + * > > + * Copyright (c) 2012 Citrix > > + * > > + * Authors: > > + *  Wei Liu > > + * > > + * This work

Re: [Qemu-devel] [PATCH 2/2] Xen: Add xen-apic support and hook it up.

2012-04-11 Thread Stefano Stabellini
On Wed, 11 Apr 2012, Stefano Stabellini wrote: > On Wed, 11 Apr 2012, Peter Maydell wrote: > > On 5 April 2012 10:35, Wei Liu wrote: > > > > > > --- /dev/null > > > +++ b/hw/xen_apic.c > > > @@ -0,0 +1,90 @@ > > > +/* > > > + * Xen b

[Qemu-devel] [PATCH v2 0/2] MSI/MSIX injection for Xen HVM guests

2012-04-12 Thread Stefano Stabellini
ing it out). Stefano Stabellini (2): Xen: basic HVM MSI injection support. Xen: Add xen-apic support and hook it up. Makefile.target |2 +- hw/pc.c |8 + hw/xen.h|1 + hw/xen_apic.c | 90 +++

[Qemu-devel] [PATCH v2 1/2] Xen: basic HVM MSI injection support.

2012-04-12 Thread Stefano Stabellini
From: "Wei Liu" Signed-off-by: Wei Liu Signed-off-by: Stefano Stabellini --- hw/xen.h |1 + xen-all.c |5 + xen-stub.c |4 3 files changed, 10 insertions(+), 0 deletions(-) diff --git a/hw/xen.h b/hw/xen.h index b46879c..e5926b7 100644 --- a/hw/xen.h +++

[Qemu-devel] [PATCH v2 2/2] Xen: Add xen-apic support and hook it up.

2012-04-12 Thread Stefano Stabellini
From: "Wei Liu" Signed-off-by: Wei Liu Signed-off-by: Stefano Stabellini Acked-by: Paolo Bonzini CC: Jan Kiszka CC: Peter Maydell --- Makefile.target |2 +- hw/pc.c |8 + hw/xen_apic.c | 90 +++ 3 files c

[Qemu-devel] [PULL] Xen MSI, mapcache, xen_disk

2012-04-13 Thread Stefano Stabellini
: Anthony PERARD (1): Xen, mapcache: Fix the compute of the size of bucket. Julien Grall (1): xen-mapcache: don't unmap locked entry during mapcache invalidation Stefano Stabellini (2): xen: handle backend deletion from xenstore xen: introduce an event channel for buffer

<    1   2   3   4   5   6   7   8   9   10   >