Re: [Qemu-devel] [PATCH] xen-hvm.c: Improve the return method for xen_hvm_init()

2014-09-03 Thread Stefano Stabellini
On Wed, 3 Sep 2014, Chen Gang wrote: > Oh, sorry, forgot Cc to qemu trivial. > > Thanks. > On 9/3/14 0:22, Chen Gang wrote: > > When failure occurs, it need use "return -1" instead of exit(1), so can > > let upper caller has chance to print failure information, too, then user > > can know the fail

Re: [Qemu-devel] [PATCH v2] xen-hvm.c: Always return -1 when failure occurs in xen_hvm_init()

2014-09-04 Thread Stefano Stabellini
&& make && make check" > "echo $? == 0" > > > Signed-off-by: Chen Gang Acked-by: Stefano Stabellini > xen-hvm.c | 9 - > 1 file changed, 4 insertions(+), 5 deletions(-) > > diff --git a/xen-hvm.c b/xen-hvm.c > index 0d0994

Re: [Qemu-devel] [PATCH] vnc: add additional key up event before repeated key down

2014-09-05 Thread Stefano Stabellini
On Fri, 5 Sep 2014, Chunyan Liu wrote: > Using xen tools 'xl vncviewer' with tigervnc (default on SLE-12), > found that: the display of the guest is unexpected while keep > pressing a key. We expect the same character multiple times, but > it prints only one time. This happens on a PV guest in text

Re: [Qemu-devel] [Xen-devel] [RFC Patch v3 23/22] Introduce "xen-load-devices-state"

2014-09-05 Thread Stefano Stabellini
On Fri, 5 Sep 2014, Wen Congyang wrote: > introduce a "xen-load-devices-state" QAPI command that can be used to load > the state of all devices, but not the RAM or the block devices of the > VM. Hello Wen, please CC qemu-devel too for QEMU patches. Could you please explain why do you need this co

Re: [Qemu-devel] [Xen-devel] [RFC Patch v3 23/22] Introduce "xen-load-devices-state"

2014-09-10 Thread Stefano Stabellini
On Tue, 9 Sep 2014, Wen Congyang wrote: > At 09/06/2014 05:57 AM, Stefano Stabellini Write: > > On Fri, 5 Sep 2014, Wen Congyang wrote: > >> introduce a "xen-load-devices-state" QAPI command that can be used to load > >> the state of all devices, but not the RA

Re: [Qemu-devel] [PATCH 1/3] xenfb: Unregister keyboard event handler correctly

2014-09-10 Thread Stefano Stabellini
On Wed, 10 Sep 2014, Owen smith wrote: > Keyboard event handler was replaced with a new handler on disconnect. > Use the unregister function to remove keyboard handler. > > Signed-off-by: Owen smith > --- > hw/display/xenfb.c | 13 +++-- > 1 file changed, 11 insertions(+), 2 deletions(-)

Re: [Qemu-devel] [PATCH 2/3] xenfb: Add option to use grant ref for shared page.

2014-09-10 Thread Stefano Stabellini
On Wed, 10 Sep 2014, Owen smith wrote: > The vkbd device should be able to use a grant reference to map the > shared page. > > Signed-off-by: Owen smith > --- > hw/display/xenfb.c | 39 +-- > 1 file changed, 29 insertions(+), 10 deletions(-) > > diff --git a/

Re: [Qemu-devel] [PATCH 3/3] xenfb: Add "feature-no-abs-rescale" for Windows PV frontend

2014-09-10 Thread Stefano Stabellini
On Wed, 10 Sep 2014, Owen smith wrote: > Windows PV frontend requires absolute mouse values in the range > [0, 0x7fff]. Add a feature to not rescale the axes to DisplaySurface > size. Also allows Windows PV frontend to connect without a vfb > device. Moves the rescaling of axes to a seperate functi

Re: [Qemu-devel] [PATCH 2/3] xenfb: Add option to use grant ref for shared page.

2014-09-11 Thread Stefano Stabellini
On Thu, 11 Sep 2014, Owen Smith wrote: > > -Original Message- > > From: Stefano Stabellini [mailto:stefano.stabell...@eu.citrix.com] > > Sent: 11 September 2014 02:01 > > To: Owen Smith > > Cc: qemu-devel@nongnu.org; xen-de...@lists.xen.org; Stefano Stabelli

Re: [Qemu-devel] [PATCH 3/3] xenfb: Add "feature-no-abs-rescale" for Windows PV frontend

2014-09-11 Thread Stefano Stabellini
On Thu, 11 Sep 2014, Owen Smith wrote: > > -Original Message- > > From: Stefano Stabellini [mailto:stefano.stabell...@eu.citrix.com] > > Sent: 11 September 2014 02:23 > > To: Owen Smith > > Cc: qemu-devel@nongnu.org; xen-de...@lists.xen.org; Stefano Stabelli

Re: [Qemu-devel] [PATCH v2 2/3] tap-bsd: implement a FreeBSD only version of tap_open

2014-07-22 Thread Stefano Stabellini
ike Xen > >> libxl), in order to have a unified behaviour across suported > >> platforms. > >> > >> Signed-off-by: Roger Pau Monné > >> Cc: xen-de...@lists.xenproject.org > >> Cc: Stefano Stabellini > >> Cc: Anthony Liguori > >> C

Re: [Qemu-devel] [PATCH v2 2/3] tap-bsd: implement a FreeBSD only version of tap_open

2014-07-23 Thread Stefano Stabellini
On Wed, 23 Jul 2014, Roger Pau Monné wrote: > On 22/07/14 14:26, Stefano Stabellini wrote: > > On Tue, 22 Jul 2014, Roger Pau Monné wrote: > >> On 27/05/14 15:29, Stefan Hajnoczi wrote: > >>> On Fri, May 23, 2014 at 05:57:48PM +0200, Roger Pau Monne wrote: > >&

[Qemu-devel] [PULL 0/3] Xen tree 2014-08-01

2014-08-01 Thread Stefano Stabellini
The following changes since commit 541bbb07eb197a870661ed702ae1f15c7d46aea6: Update version for v2.1.0 release (2014-08-01 13:31:29 +0100) are available in the git repository at: git://xenbits.xen.org/people/sstabellini/qemu-dm.git xen-20140801 for you to fetch changes up to b33a5bbfbaab6c1

[Qemu-devel] [PULL 1/3] xen: fix usage of ENODATA

2014-08-01 Thread Stefano Stabellini
ction. Signed-off-by: Roger Pau Monné Signed-off-by: Stefano Stabellini Cc: xen-de...@lists.xenproject.org Cc: Stefano Stabellini Cc: Anthony Perard --- xen-hvm.c |7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/xen-hvm.c b/xen-hvm.c index a2486cf..91de2e2 100644 ---

[Qemu-devel] [PULL 2/3] tap-bsd: implement a FreeBSD only version of tap_open

2014-08-01 Thread Stefano Stabellini
ounterpart. This is specially important for toolstacks that use Qemu (like Xen libxl), in order to have a unified behaviour across suported platforms. Signed-off-by: Roger Pau Monné Signed-off-by: Stefano Stabellini Reviewed-by: Stefan Hajnoczi --- net/tap-bs

[Qemu-devel] [PULL 3/3] qemu: support xen hvm direct kernel boot

2014-08-01 Thread Stefano Stabellini
x27;s working when xen uses seabios. During this work, found the 'kvmvapic' is in option_rom list, it should not be there in xen case. Set s->vapic_control = 0 in xen_apic_realize() to handle that. Signed-off-by: Chunyan Liu Acked-by: Stefano Stabellini Acked-by: Michael S. Tsirkin

Re: [Qemu-devel] [RFC PATCH V5 0/3] Support xen HVM direct kernel boot

2014-08-04 Thread Stefano Stabellini
On Thu, 10 Jul 2014, Stefano Stabellini wrote: > On Thu, 10 Jul 2014, Ian Campbell wrote: > > On Mon, 2014-07-07 at 14:34 +0800, Chunyan Liu wrote: > > > Updated current patch series for working with qemu-xen and default > > > BIOS (seabios), to make it in good sha

Re: [Qemu-devel] [PATCH V2 5/5] vga-cirrus: Workaround during restore when using Xen.

2012-01-04 Thread Stefano Stabellini
On Sun, 18 Dec 2011, Avi Kivity wrote: > On 12/12/2011 05:32 PM, Stefano Stabellini wrote: > > > Really, I think this is something inherently incompatible with the > > > current memory API. If Xen has this unfixable special "requirement" > > > (it's ra

Re: [Qemu-devel] [PATCH 11/11] configure: Improve Xen autodetection for hosts without Xen

2012-01-04 Thread Stefano Stabellini
On Sat, 17 Dec 2011, Stefan Weil wrote: > With this patch, it only takes one test (instead of four) > to detect that there is no Xen support at all. > > For most build hosts, this will reduce the time configure needs. > It will also reduce noisy output in config.log. > > Build hosts with Xen now

Re: [Qemu-devel] [PATCH 17/23] xen: convert to MemoryListener API

2012-01-04 Thread Stefano Stabellini
On Mon, 19 Dec 2011, Avi Kivity wrote: > -static int xen_log_start(CPUPhysMemoryClient *client, target_phys_addr_t > phys_addr, ram_addr_t size) > +static void xen_log_start(MemoryListener *listener, > + MemoryRegionSection *section) > { > -XenIOState *state = contain

Re: [Qemu-devel] Xen: qemu dies with xen-all.c:478: xen_log_sync: Assertion `r >= 0' failed.

2012-01-04 Thread Stefano Stabellini
On Wed, 4 Jan 2012, Julian Pidancet wrote: > When testing the latest master branch, qemu dies with the above error > message. The issue seems to have been introduced by the following > recent patch: > > xen: convert to MemoryListener API (20581d207853fe4b1af88b116f077516dfa888cd) > > Commenting t

Re: [Qemu-devel] [PATCH] xen: Fix after recent change in dirty bitmap tracking.

2012-01-05 Thread Stefano Stabellini
On Wed, 4 Jan 2012, Anthony PERARD wrote: > A recent patch set from Avi break the dirty bitmap support of Xen. But this is > because the internal function will return an error for an unhandled memory > region (a - b). s/the internal function/xen_sync_dirty_bitmap > But this is not an err

Re: [Qemu-devel] [PATCH V2 5/5] vga-cirrus: Workaround during restore when using Xen.

2012-01-05 Thread Stefano Stabellini
On Wed, 4 Jan 2012, Avi Kivity wrote: > On 01/04/2012 06:38 PM, Stefano Stabellini wrote: > > > > > I suggest doing the following: > > > > > > 1. keep cirrus code unchanged > > > 2. when the framebuffer is first mapped into physical memory (as know

Re: [Qemu-devel] [PATCH V2] xen: Fix after recent change in dirty bitmap tracking.

2012-01-05 Thread Stefano Stabellini
On Thu, 5 Jan 2012, Anthony PERARD wrote: > A recent patch set from Avi break the dirty bitmap support of Xen. But this is > because xen_sync_dirty_bitmap will return an error for an unhandled memory > range (a - b). However this is not a fatal error, so we should just > continue instead of

[Qemu-devel] [PULL] xen memory fix

2012-01-05 Thread Stefano Stabellini
fff). However this is not a fatal error, so we should just continue instead of aborting. There is now an error printed when the Xen call failed. Signed-off-by: Anthony PERARD Acked-by: Stefano Stabellini --- diff --git a/xen-all.c b/xen-all.c index d58d461..c86ebf4 100644 --- a/xen-all.c +++ b/

Re: [Qemu-devel] [PATCH V2 5/5] vga-cirrus: Workaround during restore when using Xen.

2012-01-05 Thread Stefano Stabellini
On Thu, 5 Jan 2012, Avi Kivity wrote: > On 01/05/2012 02:30 PM, Stefano Stabellini wrote: > > > > > > > > I cannot see how this is going to fix the save/restore issue we are > > > > trying to solve. > > > > The problem, unfortunately very compl

Re: [Qemu-devel] [PATCH V2 5/5] vga-cirrus: Workaround during restore when using Xen.

2012-01-05 Thread Stefano Stabellini
On Thu, 5 Jan 2012, Avi Kivity wrote: > On 01/05/2012 03:17 PM, Stefano Stabellini wrote: > > > > The "solution" I am proposing is introducing an early_savevm set of > > > > save/restore functions so that at restore time we can get to know at > > >

Re: [Qemu-devel] [PATCH V2 5/5] vga-cirrus: Workaround during restore when using Xen.

2012-01-05 Thread Stefano Stabellini
On Thu, 5 Jan 2012, Avi Kivity wrote: > > If the MemoryRegions are re-created by the devices, then we need another > > mechanism to find out where the videoram is. > > What I am saying is that the suggestion of having a xen_address field > > for every MemoryRegion would make the code cleaner but it

Re: [Qemu-devel] [PATCH V2 5/5] vga-cirrus: Workaround during restore when using Xen.

2012-01-05 Thread Stefano Stabellini
On Thu, 5 Jan 2012, Avi Kivity wrote: > On 01/05/2012 05:53 PM, Stefano Stabellini wrote: > > > > > This involves: > > > - adding vmstate to xen-all.c so it can migrate the xen vram address > > > > Easy so far. > > > > > > > - making sur

Re: [Qemu-devel] [PATCH V2 5/5] vga-cirrus: Workaround during restore when using Xen.

2012-01-06 Thread Stefano Stabellini
On Thu, 5 Jan 2012, Jan Kiszka wrote: > On 2012-01-05 15:50, Avi Kivity wrote: > >> Let me summarize what we have come up with so far: > >> > >> - we move the call to xen_register_framebuffer before > >> memory_region_init_ram in vga_common_init; > >> > >> - we prevent xen_ram_alloc from allocating

Re: [Qemu-devel] [PATCH V2 5/5] vga-cirrus: Workaround during restore when using Xen.

2012-01-06 Thread Stefano Stabellini
On Fri, 6 Jan 2012, Jan Kiszka wrote: > On 2012-01-06 08:50, Stefano Stabellini wrote: > > On Thu, 5 Jan 2012, Jan Kiszka wrote: > >> On 2012-01-05 15:50, Avi Kivity wrote: > >>>> Let me summarize what we have come up with so far: > >>>> > >>

Re: [Qemu-devel] [PATCH V2 5/5] vga-cirrus: Workaround during restore when using Xen.

2012-01-09 Thread Stefano Stabellini
On Sun, 8 Jan 2012, Avi Kivity wrote: > On 01/06/2012 04:40 PM, Stefano Stabellini wrote: > > Avi, if you think that early_savevm is a decent solution, we'll start > > working on it. > > I don't like early_savevm because it complicates life for devices, for > wh

[Qemu-devel] [PATCH v3 4/6] cirrus_vga: do not reset videoram on resume

2012-01-19 Thread Stefano Stabellini
From: Anthony PERARD When resuming we shouldn't set the videoram to 0xff considering that we are about to read it from the savefile. Signed-off-by: Anthony PERARD Signed-off-by: Stefano Stabellini --- hw/cirrus_vga.c |9 ++--- 1 files changed, 6 insertions(+), 3 deletions(-)

[Qemu-devel] [PATCH v3 0/6] save/restore on Xen

2012-01-19 Thread Stefano Stabellini
me xen: change memory access behavior during migration. Stefano Stabellini (2): Set runstate to INMIGRATE earlier xen: record physmap changes to xenstore hw/cirrus_vga.c |9 -- vl.c|8 +++-- xen-all.c | 89 +

[Qemu-devel] [PATCH v3 3/6] Set runstate to INMIGRATE earlier

2012-01-19 Thread Stefano Stabellini
Set runstate to RUN_STATE_INMIGRATE as soon as we can on resume. Signed-off-by: Stefano Stabellini --- vl.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/vl.c b/vl.c index 6f0435b..bb0139f 100644 --- a/vl.c +++ b/vl.c @@ -2972,6 +2972,7 @@ int main(int argc, char

[Qemu-devel] [PATCH v3 6/6] xen: change memory access behavior during migration.

2012-01-19 Thread Stefano Stabellini
From: Anthony PERARD Do not allocate RAM during INMIGRATE runstate. Do not actually "do" set_memory during migration. Signed-off-by: Anthony PERARD Signed-off-by: Stefano Stabellini --- xen-all.c |9 + 1 files changed, 9 insertions(+), 0 deletions(-) diff --git a/xen-a

[Qemu-devel] [PATCH v3 5/6] xen: record physmap changes to xenstore

2012-01-19 Thread Stefano Stabellini
Write to xenstore any physmap changes so that the hypervisor can be aware of them. Read physmap changes from xenstore on boot. Signed-off-by: Stefano Stabellini --- xen-all.c | 62 + 1 files changed, 62 insertions(+), 0 deletions

[Qemu-devel] [PATCH v3 2/6] xen mapcache: check if memory region has moved.

2012-01-19 Thread Stefano Stabellini
located to were the guest will look into. This help to have a succefull migration. Signed-off-by: Anthony PERARD Signed-off-by: Stefano Stabellini --- xen-all.c | 18 +- xen-mapcache.c | 22 +++--- xen-mapcache.h |9 +++-- 3 files changed, 43 i

[Qemu-devel] [PATCH v3 1/6] vl.c: do not save the RAM state when Xen is enabled

2012-01-19 Thread Stefano Stabellini
From: Anthony PERARD In the Xen case, the guest RAM is not handle by QEMU, and it is saved by Xen tools. So, we just avoid to register the RAM save state handler. Signed-off-by: Anthony PERARD Signed-off-by: Stefano Stabellini --- vl.c |6 -- 1 files changed, 4 insertions(+), 2

Re: [Qemu-devel] [Xen-devel] [PATCH v3 5/6] xen: record physmap changes to xenstore

2012-01-19 Thread Stefano Stabellini
On Thu, 19 Jan 2012, Ian Campbell wrote: > On Thu, 2012-01-19 at 11:56 +0000, Stefano Stabellini wrote: > > Write to xenstore any physmap changes so that the hypervisor can be > > aware of them. > > What is the structure of the xenstore values? Looks like > /physm

Re: [Qemu-devel] [Xen-devel] [PATCH v3 5/6] xen: record physmap changes to xenstore

2012-01-19 Thread Stefano Stabellini
On Thu, 19 Jan 2012, Ian Campbell wrote: > On Thu, 2012-01-19 at 13:08 +0000, Stefano Stabellini wrote: > > On Thu, 19 Jan 2012, Ian Campbell wrote: > > > On Thu, 2012-01-19 at 11:56 +, Stefano Stabellini wrote: > > > > Write to xenstore any physmap changes

[Qemu-devel] [PATCH v4 0/6] save/restore on Xen

2012-01-20 Thread Stefano Stabellini
save the RAM state when Xen is enabled xen mapcache: check if memory region has moved. cirrus_vga: do not reset videoram on resume xen: change memory access behavior during migration. Stefano Stabellini (2): Set runstate to INMIGRATE earlier xen: record physmap chang

[Qemu-devel] [PATCH v4 2/6] xen mapcache: check if memory region has moved.

2012-01-20 Thread Stefano Stabellini
located to were the guest will look into. This help to have a succefull migration. Signed-off-by: Anthony PERARD Signed-off-by: Stefano Stabellini --- xen-all.c | 18 +- xen-mapcache.c | 22 +++--- xen-mapcache.h |9 +++-- 3 files changed, 43 i

[Qemu-devel] [PATCH v4 1/6] vl.c: do not save the RAM state when Xen is enabled

2012-01-20 Thread Stefano Stabellini
From: Anthony PERARD In the Xen case, the guest RAM is not handle by QEMU, and it is saved by Xen tools. So, we just avoid to register the RAM save state handler. Signed-off-by: Anthony PERARD Signed-off-by: Stefano Stabellini --- vl.c |6 -- 1 files changed, 4 insertions(+), 2

[Qemu-devel] [PATCH v4 5/6] xen: record physmap changes to xenstore

2012-01-20 Thread Stefano Stabellini
Write to xenstore any physmap changes so that the hypervisor can be aware of them. Read physmap changes from xenstore on boot. Signed-off-by: Stefano Stabellini --- xen-all.c | 78 - 1 files changed, 77 insertions(+), 1 deletions

[Qemu-devel] [PATCH v4 4/6] cirrus_vga: do not reset videoram on resume

2012-01-20 Thread Stefano Stabellini
From: Anthony PERARD When resuming we shouldn't set the videoram to 0xff considering that we are about to read it from the savefile. Signed-off-by: Anthony PERARD Signed-off-by: Stefano Stabellini --- hw/cirrus_vga.c |9 ++--- 1 files changed, 6 insertions(+), 3 deletions(-)

[Qemu-devel] [PATCH v4 3/6] Set runstate to INMIGRATE earlier

2012-01-20 Thread Stefano Stabellini
Set runstate to RUN_STATE_INMIGRATE as soon as we can on resume. Signed-off-by: Stefano Stabellini --- vl.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/vl.c b/vl.c index 6f0435b..bb0139f 100644 --- a/vl.c +++ b/vl.c @@ -2972,6 +2972,7 @@ int main(int argc, char

[Qemu-devel] [PATCH v4 6/6] xen: change memory access behavior during migration.

2012-01-20 Thread Stefano Stabellini
From: Anthony PERARD Do not allocate RAM during INMIGRATE runstate. Do not actually "do" set_memory during migration. Signed-off-by: Anthony PERARD Signed-off-by: Stefano Stabellini --- xen-all.c | 16 1 files changed, 16 insertions(+), 0 deletions(-) diff -

Re: [Qemu-devel] [PATCH v4 0/6] save/restore on Xen

2012-01-23 Thread Stefano Stabellini
On Fri, 20 Jan 2012, Jan Kiszka wrote: > On 2012-01-20 18:20, Stefano Stabellini wrote: > > Hi all, > > this is the fourth version of the Xen save/restore patch series. > > We have been discussing this issue for quite a while on #qemu and > > qemu-devel: > >

Re: [Qemu-devel] [PATCH v4 0/6] save/restore on Xen

2012-01-23 Thread Stefano Stabellini
On Mon, 23 Jan 2012, Jan Kiszka wrote: > >> Or what is the ordering > >> of init, RAM restore, and initial device reset now? > > > > RAM restore (done by Xen) > > > > physmap rebuild (done by xen_hvm_init in qemu) > > pc_init() > > qemu_system_reset() > > load_vmstate() > > Hmm, are you sure tha

Re: [Qemu-devel] [PATCH v4 0/6] save/restore on Xen

2012-01-23 Thread Stefano Stabellini
On Mon, 23 Jan 2012, Jan Kiszka wrote: > On 2012-01-23 12:59, Stefano Stabellini wrote: > > On Mon, 23 Jan 2012, Jan Kiszka wrote: > >>>> Or what is the ordering > >>>> of init, RAM restore, and initial device reset now? > >>> > >>>

Re: [Qemu-devel] We need more reviewers/maintainers!!

2012-03-12 Thread Stefano Stabellini
On Mon, 12 Mar 2012, Anthony Liguori wrote: > On 03/12/2012 12:34 PM, Stefano Stabellini wrote: > > On Mon, 12 Mar 2012, Anthony Liguori wrote: > >> On 03/12/2012 12:06 PM, Stefano Stabellini wrote: > >>> Hi all, > >>> I don't mean to steer an

Re: [Qemu-devel] We need more reviewers/maintainers!!

2012-03-12 Thread Stefano Stabellini
On Mon, 12 Mar 2012, Anthony Liguori wrote: > >>> "infrequent write-only contributors". > >>> > >>> I certainly do it for the areas I am a maintainer of, and in general we > >>> try to do it on xen-devel. Overall I think we are mostly succeeding even > >>> though admittedly the traffic is lower tha

Re: [Qemu-devel] We need more reviewers/maintainers!!

2012-03-13 Thread Stefano Stabellini
On Mon, 12 Mar 2012, Michael Roth wrote: > Thanks Stefano. I plan on doing a lot of work with migration in the > future, and as such try to keep tabs on the migration-related stuff on > qemu-devel. I often don't get around to actually reviewing things > though, and that's been nagging me for a whil

Re: [Qemu-devel] We need more reviewers/maintainers!!

2012-03-13 Thread Stefano Stabellini
On Mon, 12 Mar 2012, Anthony Liguori wrote: > > OK, so the actual problem seems to be that not all the source files that > > are supposed to be Supported are actually supported. > > And of course some key files, like savevm.c are not even Maintained!! > > For example if I am not mistaken we are mis

Re: [Qemu-devel] We need more reviewers/maintainers!!

2012-03-13 Thread Stefano Stabellini
On Tue, 13 Mar 2012, Kevin Wolf wrote: > Am 12.03.2012 18:34, schrieb Stefano Stabellini: > > On Mon, 12 Mar 2012, Anthony Liguori wrote: > >> On 03/12/2012 12:06 PM, Stefano Stabellini wrote: > >>> Hi all, > >>> I don't mean to steer any controversy

Re: [Qemu-devel] [PATCH RESEND v5 2/6] Introduce "save_devices"

2012-03-13 Thread Stefano Stabellini
On Mon, 12 Mar 2012, Anthony Liguori wrote: > On 02/28/2012 09:51 AM, Stefano Stabellini wrote: > > - add an "is_ram" flag to SaveStateEntry; > > > > - add an "is_ram" parameter to register_savevm_live; > > > > - introduce a "save_devices&

Re: [Qemu-devel] [PATCH] xen-mapcache: don't unmap locked entry during mapcache invalidation

2012-03-15 Thread Stefano Stabellini
On Thu, 15 Mar 2012, Julien Grall wrote: > When an IOREQ_TYPE_INVALIDATE is sent to QEMU, it invalidates all entry > of the map cache even if it's locked. > > QEMU is not able to know that entry was invalidated, so when an IO > access is requested a segfault occured. The problem here is the long

Re: [Qemu-devel] [PATCH] xen-mapcache: don't unmap locked entry during mapcache invalidation

2012-03-15 Thread Stefano Stabellini
On Thu, 15 Mar 2012, Olaf Hering wrote: > On Thu, Mar 15, Stefano Stabellini wrote: > > > On Thu, 15 Mar 2012, Julien Grall wrote: > > > When an IOREQ_TYPE_INVALIDATE is sent to QEMU, it invalidates all entry > > > of the map cache even if it's locked. > &g

Re: [Qemu-devel] [Xen-devel] [PATCH] xen-mapcache: don't unmap locked entry during mapcache invalidation

2012-03-15 Thread Stefano Stabellini
On Thu, 15 Mar 2012, Tim Deegan wrote: > At 17:14 + on 15 Mar (1331831693), Stefano Stabellini wrote: > > On Thu, 15 Mar 2012, Julien Grall wrote: > > > When an IOREQ_TYPE_INVALIDATE is sent to QEMU, it invalidates all entry > > > of the map cache even if it's

[Qemu-devel] [PATCH v6 0/6] save/restore on Xen

2012-03-15 Thread Stefano Stabellini
stat: Anthony PERARD (2): xen mapcache: check if memory region has moved. xen: do not allocate RAM during INMIGRATE runstate Stefano Stabellini (4): cirrus_vga: do not reset videoram Introduce "save_devices" xen: record physmap changes to xenstore

[Qemu-devel] [PATCH v6 6/6] xen: do not allocate RAM during INMIGRATE runstate

2012-03-15 Thread Stefano Stabellini
From: Anthony PERARD Signed-off-by: Anthony PERARD Signed-off-by: Stefano Stabellini --- xen-all.c |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/xen-all.c b/xen-all.c index 972cffd..10d53d1 100644 --- a/xen-all.c +++ b/xen-all.c @@ -190,6 +190,14 @@ void

[Qemu-devel] [PATCH v6 4/6] xen: record physmap changes to xenstore

2012-03-15 Thread Stefano Stabellini
Write to xenstore any physmap changes so that the hypervisor can be aware of them. Read physmap changes from xenstore on boot. Signed-off-by: Stefano Stabellini --- xen-all.c | 78 - 1 files changed, 77 insertions(+), 1 deletions

[Qemu-devel] [PATCH v6 5/6] xen mapcache: check if memory region has moved.

2012-03-15 Thread Stefano Stabellini
located to were the guest will look into. This help to have a succefull migration. Signed-off-by: Anthony PERARD Signed-off-by: Stefano Stabellini --- xen-all.c | 18 +- xen-mapcache.c | 22 +++--- xen-mapcache.h |9 +++-- 3 files changed, 43 i

[Qemu-devel] [PATCH v6 2/6] Introduce "save_devices"

2012-03-15 Thread Stefano Stabellini
s_ram parameter from register_savevm_live and sets is_ram if the device is a live_savevm device; - introduce save_devices as a QAPI command, write a better description for it; - fix CODING_STYLE; - introduce a new doc to explain the save format used by save_devices. Signed-off-by: Stefano Sta

[Qemu-devel] [PATCH v6 1/6] cirrus_vga: do not reset videoram

2012-03-15 Thread Stefano Stabellini
There is no need to set the videoram to 0xff in cirrus_reset, because it is the BIOS' job. Signed-off-by: Stefano Stabellini Reviewed-by: Avi Kivity --- hw/cirrus_vga.c |4 1 files changed, 0 insertions(+), 4 deletions(-) diff --git a/hw/cirrus_vga.c b/hw/cirrus_vga.c index 4e

[Qemu-devel] [PATCH v6 3/6] Set runstate to INMIGRATE earlier

2012-03-15 Thread Stefano Stabellini
Set runstate to RUN_STATE_INMIGRATE as soon as we can on resume. Signed-off-by: Stefano Stabellini Acked-by: Luiz Capitulino --- vl.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/vl.c b/vl.c index 1d4c350..918177a 100644 --- a/vl.c +++ b/vl.c @@ -3099,6 +3099,7

Re: [Qemu-devel] [PATCH v6 2/6] Introduce "save_devices"

2012-03-16 Thread Stefano Stabellini
On Thu, 15 Mar 2012, Anthony Liguori wrote: > > diff --git a/qapi-schema.json b/qapi-schema.json > > index d0b6792..7f938ff 100644 > > --- a/qapi-schema.json > > +++ b/qapi-schema.json > > @@ -1593,3 +1593,21 @@ > > { 'command': 'qom-list-types', > > 'data': { '*implements': 'str', '*abstract

Re: [Qemu-devel] [PATCH v6 2/6] Introduce "save_devices"

2012-03-16 Thread Stefano Stabellini
On Thu, 15 Mar 2012, Luiz Capitulino wrote: > On Thu, 15 Mar 2012 15:16:15 -0500 > Anthony Liguori wrote: > > > On 03/15/2012 01:19 PM, Stefano Stabellini wrote: > > > - add an "is_ram" flag to SaveStateEntry; > > > > > > - regi

[Qemu-devel] [PATCH v7 0/6] save/restore on Xen

2012-03-16 Thread Stefano Stabellini
ound in the first place). This is the list of patches with a diffstat: Anthony PERARD (2): xen mapcache: check if memory region has moved. xen: do not allocate RAM during INMIGRATE runstate Stefano Stabellini (4): cirrus_vga: do not reset videoram Introduce "save-devic

[Qemu-devel] [PATCH v7 1/6] cirrus_vga: do not reset videoram

2012-03-16 Thread Stefano Stabellini
There is no need to set the videoram to 0xff in cirrus_reset, because it is the BIOS' job. Signed-off-by: Stefano Stabellini Reviewed-by: Avi Kivity --- hw/cirrus_vga.c |4 1 files changed, 0 insertions(+), 4 deletions(-) diff --git a/hw/cirrus_vga.c b/hw/cirrus_vga.c index 4e

[Qemu-devel] [PATCH v7 6/6] xen: do not allocate RAM during INMIGRATE runstate

2012-03-16 Thread Stefano Stabellini
From: Anthony PERARD Signed-off-by: Anthony PERARD Signed-off-by: Stefano Stabellini --- xen-all.c |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/xen-all.c b/xen-all.c index 972cffd..10d53d1 100644 --- a/xen-all.c +++ b/xen-all.c @@ -190,6 +190,14 @@ void

[Qemu-devel] [PATCH v7 5/6] xen mapcache: check if memory region has moved.

2012-03-16 Thread Stefano Stabellini
located to were the guest will look into. This help to have a succefull migration. Signed-off-by: Anthony PERARD Signed-off-by: Stefano Stabellini --- xen-all.c | 18 +- xen-mapcache.c | 22 +++--- xen-mapcache.h |9 +++-- 3 files changed, 43 i

[Qemu-devel] [PATCH v7 3/6] Set runstate to INMIGRATE earlier

2012-03-16 Thread Stefano Stabellini
Set runstate to RUN_STATE_INMIGRATE as soon as we can on resume. Signed-off-by: Stefano Stabellini Acked-by: Luiz Capitulino --- vl.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/vl.c b/vl.c index 1d4c350..918177a 100644 --- a/vl.c +++ b/vl.c @@ -3099,6 +3099,7

[Qemu-devel] [PATCH v7 2/6] Introduce "save-devices-state"

2012-03-16 Thread Stefano Stabellini
the save format used by save_devices. Signed-off-by: Stefano Stabellini Reviewed-by: Anthony Liguori CC: Luiz Capitulino --- docs/save-devices-state.txt | 33 qapi-schema.json| 18 +++ qmp-commands.hx | 25 +++ savevm.c

[Qemu-devel] [PATCH v7 4/6] xen: record physmap changes to xenstore

2012-03-16 Thread Stefano Stabellini
Write to xenstore any physmap changes so that the hypervisor can be aware of them. Read physmap changes from xenstore on boot. Signed-off-by: Stefano Stabellini --- xen-all.c | 78 - 1 files changed, 77 insertions(+), 1 deletions

Re: [Qemu-devel] [PATCH v6 2/6] Introduce "save_devices"

2012-03-16 Thread Stefano Stabellini
On Fri, 16 Mar 2012, Eric Blake wrote: > On 03/15/2012 02:34 PM, Luiz Capitulino wrote: > > On Thu, 15 Mar 2012 15:16:15 -0500 > > Anthony Liguori wrote: > > > >> On 03/15/2012 01:19 PM, Stefano Stabellini wrote: > >>> - add an "is_ram" flag t

Re: [Qemu-devel] [PATCH v7 2/6] Introduce "save-devices-state"

2012-03-16 Thread Stefano Stabellini
On Fri, 16 Mar 2012, Eric Blake wrote: > On 03/16/2012 06:13 AM, Stefano Stabellini wrote: > > - add an "is_ram" flag to SaveStateEntry; > > > > - register_savevm_live sets is_ram for live_savevm devices; > > > > - introduce a "save-devices-stat

[Qemu-devel] [PATCH v8 0/6] save/restore on Xen

2012-03-19 Thread Stefano Stabellini
to be reset in the reset handler at all (tested on Win2K, where the problem was found in the first place). This is the list of patches with a diffstat: Anthony PERARD (2): xen mapcache: check if memory region has moved. xen: do not allocate RAM during INMIGRATE runstate Stefano Stab

[Qemu-devel] [PATCH v8 1/6] cirrus_vga: do not reset videoram

2012-03-19 Thread Stefano Stabellini
There is no need to set the videoram to 0xff in cirrus_reset, because it is the BIOS' job. Signed-off-by: Stefano Stabellini Reviewed-by: Avi Kivity --- hw/cirrus_vga.c |4 1 files changed, 0 insertions(+), 4 deletions(-) diff --git a/hw/cirrus_vga.c b/hw/cirrus_vga.c index 4e

[Qemu-devel] [PATCH v8 6/6] xen: do not allocate RAM during INMIGRATE runstate

2012-03-19 Thread Stefano Stabellini
From: Anthony PERARD Signed-off-by: Anthony PERARD Signed-off-by: Stefano Stabellini --- xen-all.c |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/xen-all.c b/xen-all.c index 972cffd..10d53d1 100644 --- a/xen-all.c +++ b/xen-all.c @@ -190,6 +190,14 @@ void

[Qemu-devel] [PATCH v8 3/6] Set runstate to INMIGRATE earlier

2012-03-19 Thread Stefano Stabellini
Set runstate to RUN_STATE_INMIGRATE as soon as we can on resume. Signed-off-by: Stefano Stabellini Acked-by: Luiz Capitulino --- vl.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/vl.c b/vl.c index 1d4c350..918177a 100644 --- a/vl.c +++ b/vl.c @@ -3099,6 +3099,7

[Qemu-devel] [PATCH v8 5/6] xen mapcache: check if memory region has moved.

2012-03-19 Thread Stefano Stabellini
located to were the guest will look into. This help to have a succefull migration. Signed-off-by: Anthony PERARD Signed-off-by: Stefano Stabellini --- xen-all.c | 18 +- xen-mapcache.c | 22 +++--- xen-mapcache.h |9 +++-- 3 files changed, 43 i

[Qemu-devel] [PATCH v8 4/6] xen: record physmap changes to xenstore

2012-03-19 Thread Stefano Stabellini
Write to xenstore any physmap changes so that the hypervisor can be aware of them. Read physmap changes from xenstore on boot. Signed-off-by: Stefano Stabellini --- xen-all.c | 78 - 1 files changed, 77 insertions(+), 1 deletions

[Qemu-devel] [PATCH v8 2/6] Introduce "xen-save-devices-state"

2012-03-19 Thread Stefano Stabellini
r description for it; - fix CODING_STYLE; - introduce a new doc to explain the save format used by save_devices. Signed-off-by: Stefano Stabellini Reviewed-by: Anthony Liguori --- docs/xen-save-devices-state.txt | 34 ++ qapi-schema.json| 19 +++

Re: [Qemu-devel] [PATCH v7 2/6] Introduce "save-devices-state"

2012-03-19 Thread Stefano Stabellini
On Fri, 16 Mar 2012, Eric Blake wrote: > On 03/16/2012 09:58 AM, Anthony Liguori wrote: > > >>> +These operations are normally used with migration (see migration.txt), > >>> +however it is also possible to save the state of all devices to file, > >>> +without saving the RAM or the block devices of

Re: [Qemu-devel] [PATCH V8 RESEND 1/8] pci_ids: Add INTEL_82599_VF id.

2012-03-19 Thread Stefano Stabellini
On Fri, 16 Mar 2012, Anthony PERARD wrote: > Signed-off-by: Anthony PERARD > --- > hw/pci_ids.h |1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/hw/pci_ids.h b/hw/pci_ids.h > index e8235a7..943106a 100644 > --- a/hw/pci_ids.h > +++ b/hw/pci_ids.h > @@ -118,6 +118,7 @

Re: [Qemu-devel] [PATCH V8 RESEND 2/8] configure: Introduce --enable-xen-pci-passthrough.

2012-03-19 Thread Stefano Stabellini
On Fri, 16 Mar 2012, Anthony PERARD wrote: > Signed-off-by: Anthony PERARD ack > configure | 25 + > 1 files changed, 25 insertions(+), 0 deletions(-) > > diff --git a/configure b/configure > index afe7395..1d1204a 100755 > --- a/configure > +++ b/configure > @@ -136,

Re: [Qemu-devel] [PATCH V8 RESEND 3/8] Introduce HostPCIDevice to access a pci device on the host.

2012-03-19 Thread Stefano Stabellini
On Fri, 16 Mar 2012, Anthony PERARD wrote: > Signed-off-by: Anthony PERARD ack > Makefile.target |3 + > hw/host-pci-device.c | 278 > ++ > hw/host-pci-device.h | 75 ++ > 3 files changed, 356 insertions(+), 0 deletions(-)

Re: [Qemu-devel] [PATCH V8 RESEND 4/8] pci.c: Add pci_check_bar_overlap

2012-03-19 Thread Stefano Stabellini
On Fri, 16 Mar 2012, Anthony PERARD wrote: > From: Yuji Shimada > > This function helps Xen PCI Passthrough device to check for overlap. > > Signed-off-by: Yuji Shimada > Signed-off-by: Anthony PERARD It is probably worth mentioning that the function as it is cannot handle bridges in the comm

Re: [Qemu-devel] [PATCH V8 RESEND 5/8] Introduce Xen PCI Passthrough, qdevice (1/3)

2012-03-19 Thread Stefano Stabellini
On Fri, 16 Mar 2012, Anthony PERARD wrote: > From: Allen Kay > > A more complete history can be found here: > git://xenbits.xensource.com/qemu-xen-unstable.git > > Signed-off-by: Allen Kay > Signed-off-by: Guy Zana > Signed-off-by: Anthony PERARD Such a large patch is obviously hard to revie

Re: [Qemu-devel] [PATCH V8 RESEND 6/8] Introduce Xen PCI Passthrough, PCI config space helpers (2/3)

2012-03-19 Thread Stefano Stabellini
On Fri, 16 Mar 2012, Anthony PERARD wrote: > From: Allen Kay > > A more complete history can be found here: > git://xenbits.xensource.com/qemu-xen-unstable.git > > Signed-off-by: Allen Kay > Signed-off-by: Guy Zana > Signed-off-by: Anthony PERARD ack

Re: [Qemu-devel] [PATCH V8 RESEND 7/8] Introduce apic-msidef.h

2012-03-19 Thread Stefano Stabellini
On Fri, 16 Mar 2012, Anthony PERARD wrote: > This patch move the msi definition from apic.c to apic-msidef.h. So it can be > used also by other .c files. > Ack

Re: [Qemu-devel] [PATCH V8 RESEND 8/8] Introduce Xen PCI Passthrough, MSI (3/3)

2012-03-19 Thread Stefano Stabellini
On Fri, 16 Mar 2012, Anthony PERARD wrote: > From: Jiang Yunhong > > A more complete history can be found here: > git://xenbits.xensource.com/qemu-xen-unstable.git > > Signed-off-by: Jiang Yunhong > Signed-off-by: Shan Haitao > Signed-off-by: Anthony PERARD ack

Re: [Qemu-devel] [PATCH v8 2/6] Introduce "xen-save-devices-state"

2012-03-19 Thread Stefano Stabellini
On Mon, 19 Mar 2012, Luiz Capitulino wrote: > > - add an "is_ram" flag to SaveStateEntry; > > > > - register_savevm_live sets is_ram for live_savevm devices; > > > > - introduce a "xen-save-devices-state" QAPI command that can be used to save > > the state of all devices, but not the RAM or the b

Re: [Qemu-devel] [PATCH v8 2/6] Introduce "xen-save-devices-state"

2012-03-19 Thread Stefano Stabellini
On Mon, 19 Mar 2012, Luiz Capitulino wrote: > On Mon, 19 Mar 2012 11:48:01 + > Stefano Stabellini wrote: > > > - add an "is_ram" flag to SaveStateEntry; > > > > - register_savevm_live sets is_ram for live_savevm devices; > > > > - introduce

[Qemu-devel] [GIT PULL v8 0/6] save/restore on Xen

2012-03-19 Thread Stefano Stabellini
allocate RAM during INMIGRATE runstate Stefano Stabellini (4): cirrus_vga: do not reset videoram Introduce "xen-save-devices-state" Set runstate to INMIGRATE earlier xen: record physmap changes to xenstore docs/xen-save-devices-state.txt | 34 +++

Re: [Qemu-devel] [PATCH v8 2/6] Introduce "xen-save-devices-state"

2012-03-19 Thread Stefano Stabellini
On Mon, 19 Mar 2012, Anthony Liguori wrote: > On 03/19/2012 10:16 AM, Stefano Stabellini wrote: > > On Mon, 19 Mar 2012, Luiz Capitulino wrote: > >>> - add an "is_ram" flag to SaveStateEntry; > >>> > >>> - register_savevm_live sets is_ram

Re: [Qemu-devel] [PATCH v4 1/7] RTC: Remove the logic to update time format when DM bit changed

2012-03-20 Thread Stefano Stabellini
On Mon, 19 Mar 2012, Zhang, Yang Z wrote: > Change DM(date mode) and 24/12 control bit don't affect the internal > registers. It only indicates what format is using for those registers. So we > don't need to update time format when it is modified. That might be true, but if the user changes form

Re: [Qemu-devel] [PATCH v4 2/7] RTC: Update the RTC clock only when reading it

2012-03-20 Thread Stefano Stabellini
On Mon, 19 Mar 2012, Zhang, Yang Z wrote: > There has no need to use two periodic timer to update RTC time. In this > patch, we only update it when guest reading it. So the basic idea here is that we don't need to two periodic timers because we are going to calculate the RTC guest time from QEMU'

<    1   2   3   4   5   6   7   8   9   10   >