[PATCH for-7.2] Add G_GNUC_PRINTF to function qemu_set_info_str and fix related issues

With the G_GNUC_PRINTF function attribute the compiler detects two potential insecure format strings: ../../../net/stream.c:248:31: warning: format string is not a string literal (potentially insecure) [-Wformat-security] qemu_set_info_str(&s->nc, uri); ^~~ ../..

Re: [PATCH for-7.2 v2 3/4] libvhost-user: Fix two more format strings

Am 05.11.22 um 11:24 schrieb Stefan Weil: This fix is required for 32 bit host. The bug was detected by CI for arm-linux, but is also relevant for i386-linux. Reported-by: Stefan Hajnoczi Signed-off-by: Stefan Weil --- subprojects/libvhost-user/libvhost-user.c | 3 ++- 1 file changed, 2 in

Re: [PATCH for-7.2 v2 3/4] libvhost-user: Fix two more format strings

Am 15.11.22 um 08:25 schrieb Stefan Weil: Am 05.11.22 um 11:24 schrieb Stefan Weil: This fix is required for 32 bit host. The bug was detected by CI for arm-linux, but is also relevant for i386-linux. Reported-by: Stefan Hajnoczi Signed-off-by: Stefan Weil ---   subprojects/libvhost-user/lib

Re: [PATCH for-7.2 v2 3/4] libvhost-user: Fix two more format strings

Am 23.11.22 um 07:35 schrieb Stefan Weil: Am 15.11.22 um 08:25 schrieb Stefan Weil: Am 05.11.22 um 11:24 schrieb Stefan Weil: This fix is required for 32 bit host. The bug was detected by CI for arm-linux, but is also relevant for i386-linux. Reported-by: Stefan Hajnoczi Signed-off-by: Stefa

Re: [PATCH for 7.2-rc? v2 0/5] continuing efforts to fix vhost-user issues

Am 25.11.22 um 18:30 schrieb Alex Bennée: Hi, This is continuing to attempt to fix the various vhost-user issues that are currently plaguing the release. One concrete bug I've come across is that all qtest MMIO devices where being treated as legacy which caused the VIRTIO_F_VERSION_1 flag to get

[PATCH v3 for-7.2 1/6] libvhost-user: Fix wrong type of argument to formatting function (reported by LGTM)

Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Stefan Weil Message-Id: <20220422070144.1043697-2...@weilnetz.de> Signed-off-by: Laurent Vivier --- subprojects/libvhost-user/libvhost-user.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/subprojects/libvhost-user/libvhost

[PATCH v3 for-7.2 0/6] Add format attributes and fix format strings

v3: - Fix description for patch 3 - Add patches 5 and 6 The patches 3 and 5 still need reviews! [PATCH v3 for-7.2 1/6] libvhost-user: Fix wrong type of argument to [PATCH v3 for-7.2 2/6] libvhost-user: Fix format strings [PATCH v3 for-7.2 3/6] libvhost-user: Fix two more format strings [PATCH v3

[PATCH v3 for-7.2 2/6] libvhost-user: Fix format strings

Signed-off-by: Stefan Weil Reviewed-by: Marc-André Lureau Message-Id: <20220422070144.1043697-3...@weilnetz.de> Signed-off-by: Laurent Vivier --- subprojects/libvhost-user/libvhost-user.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/subprojects/libvhost-user/libvhost-

[PATCH v3 for-7.2 3/6] libvhost-user: Fix two more format strings

This fix is required for 32 bit hosts. The bug was detected by CI for arm-linux, but is also relevant for i386-linux. Reported-by: Stefan Hajnoczi Signed-off-by: Stefan Weil --- subprojects/libvhost-user/libvhost-user.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/subpr

[PATCH v3 for-7.2 6/6] Add G_GNUC_PRINTF to function qemu_set_info_str and fix related issues

With the G_GNUC_PRINTF function attribute the compiler detects two potential insecure format strings: ../../../net/stream.c:248:31: warning: format string is not a string literal (potentially insecure) [-Wformat-security] qemu_set_info_str(&s->nc, uri); ^~~ ../..

[PATCH v3 for-7.2 5/6] MAINTAINERS: Add subprojects/libvhost-user to section "vhost"

Signed-off-by: Stefan Weil --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index cf24910249..6966490c94 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -2005,6 +2005,7 @@ F: docs/interop/vhost-user.rst F: contrib/vhost-user-*/ F: backends/vhost-user.c

[PATCH v3 for-7.2 4/6] libvhost-user: Add format attribute to local function vu_panic

Signed-off-by: Stefan Weil Reviewed-by: Marc-André Lureau Message-Id: <20220422070144.1043697-4...@weilnetz.de> Signed-off-by: Laurent Vivier --- subprojects/libvhost-user/libvhost-user.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/subprojects/libvhost-user

Re: [PATCH v3 for-7.2 4/6] libvhost-user: Add format attribute to local function vu_panic

Am 27.11.22 um 19:14 schrieb Stefan Hajnoczi: On Sat, 26 Nov 2022 at 10:25, Stefan Weil wrote: Signed-off-by: Stefan Weil Reviewed-by: Marc-André Lureau Message-Id: <20220422070144.1043697-4...@weilnetz.de> Signed-off-by: Laurent Vivier --- subprojects/libvhost-user/libvhost-user.c | 13 +

Re: [PATCH v3 for-7.2 0/6] Add format attributes and fix format strings

Am 27.11.22 um 19:23 schrieb Stefan Hajnoczi: We need to wait for Michael to agree to maintainership in patch 5. If we run out of time I suggest splitting out patch 5. Reviewed-by: Stefan Hajnoczi Citing Michael from a v2 email: "pls do". Stefan Hello Michael, I just noticed tha

Re: [PATCH 0/5] Enable unix socket support on Windows

Am 27.07.22 um 13:37 schrieb Bin Meng: On Wed, Jul 27, 2022 at 6:24 PM Daniel P. Berrangé wrote: That isn't qtest, that is basic unit tests. I would expect those to be able to work with this series Ah, I see. Agreed, will do in v2. Regards, Bin In v2 you might also call RtlGetVersion dire

[PATCH for-7.1] virtiofsd: Fix format strings

Signed-off-by: Stefan Weil --- I have also several patches which add missing G_GNUC_PRINTF. Would such changes still be wanted for 7.1? Regards, Stefan Weil tools/virtiofsd/fuse_lowlevel.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/virtiofsd/fuse_lowlevel.c b

Re: [PATCH 2/2] util/aio-win32: Correct the event array size in aio_poll()

Am 05.08.22 um 16:56 schrieb Bin Meng: From: Bin Meng WaitForMultipleObjects() can only wait for MAXIMUM_WAIT_OBJECTS object handles. Correct the event array size in aio_poll() and add a assert() to ensure it does not cause out of bound access. Signed-off-by: Bin Meng --- util/aio-win32.c

Re: Missing dll

Am 12.08.22 um 01:34 schrieb Philippe Mathieu-Daudé: Cc'ing qemu-windows@ team On 10/8/22 23:42, Peter Butler wrote: In x64 win10 I today I d/l QEMU into new directory. Then navigated to that dir and… qemu-system-aarch64 -boot d -cdrom f:\Downloads\debian-11.4.0-arm64-netinst.iso -m 2048

[PATCH for-7.1?] Fix some typos in documentation (most of them found by codespell)

Signed-off-by: Stefan Weil --- docs/about/deprecated.rst | 2 +- docs/specs/acpi_erst.rst| 4 ++-- docs/system/devices/canokey.rst | 8 docs/system/devices/cxl.rst | 12 ++-- 4 files changed, 13 insertions(+), 13 deletions(-) diff --git a/docs/about/deprecat

[PATCH] Fix some typos in documentation and comments

Signed-off-by: Stefan Weil --- This patch was triggered by a spelling check for the generated QEMU documentation using codespell. It does not try to fix all typos which still exist in the QEMU code, but has a focus on those required to fix the documentation. Nevertheless some code comments with t

Re: dropping 32-bit Windows host support

Am 19.02.24 um 17:26 schrieb Thomas Huth: On 19/02/2024 16.53, Daniel P. Berrangé wrote: On Mon, Feb 19, 2024 at 03:37:31PM +, Peter Maydell wrote: Our msys2 32-bit Windows host CI job has been failing recently because upstream MSYS2 are starting to phase out 32-bit windows host support an

Files without license statement

Hi Paolo, I just noticed that scripts/fix-multiline-comments.sh has a copyright statement, but no license statement. Should that be fixed? It looks like there exist more files with the same problem (if it is a problem), for example docs/devel/loads-stores.rst (written by Peter). LICENSE say

Re: [PATCH 3/7] scripts/nsis.py: Automatically package required DLLs of QEMU executables

Am 10.09.22 um 02:37 schrieb Bin Meng: On Sat, Sep 10, 2022 at 12:49 AM Mark Cave-Ayland wrote: On 08/09/2022 14:28, Bin Meng wrote: From: Bin Meng At present packaging the required DLLs of QEMU executables is a manual process, and error prone. Actually build/config-host.mak contains a GL

Re: [PATCH 3/7] scripts/nsis.py: Automatically package required DLLs of QEMU executables

Am 26.02.24 um 05:35 schrieb Bin Meng: On Mon, Feb 26, 2024 at 1:37 AM Stefan Weil wrote: Am 10.09.22 um 02:37 schrieb Bin Meng: On Sat, Sep 10, 2022 at 12:49 AM Mark Cave-Ayland wrote: On 08/09/2022 14:28, Bin Meng wrote: From: Bin Meng At present packaging the required DLLs of QEMU ex

GPL 3.0 in TCG test code

Dear all, some QEMU code under tests/tcg uses GPL 3.0 or later: tests/tcg/aarch64/semicall.h: * SPDX-License-Identifier: GPL-3.0-or-later tests/tcg/arm/semicall.h: * SPDX-License-Identifier: GPL-3.0-or-later tests/tcg/i386/system/boot.S: * SPDX-License-Identifier: GPL-3.0-or-later tests/tcg/mult

[PATCH for-9.0] Fix some typos in documentation (found by codespell)

Signed-off-by: Stefan Weil --- docs/devel/atomics.rst | 2 +- docs/devel/ci-jobs.rst.inc | 2 +- docs/devel/clocks.rst | 2 +- docs/system/i386/sgx.rst | 2 +- qapi/qom.json | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) diff --git a/docs/devel/atomics.rst b/doc

Re: cross-i686-tci CI job is flaky again (timeouts): can somebody who cares about TCI investigate?

Am 16.04.24 um 14:10 schrieb Peter Maydell: The cross-i686-tci job is flaky again, with persistent intermittent failures due to jobs timing out. [...] Some of these timeouts are very high -- no test should be taking 10 minutes, even given TCI and a slowish CI runner -- which suggests to me tha

Re: cross-i686-tci CI job is flaky again (timeouts): can somebody who cares about TCI investigate?

Am 16.04.24 um 14:17 schrieb Stefan Weil: Am 16.04.24 um 14:10 schrieb Peter Maydell: The cross-i686-tci job is flaky again, with persistent intermittent failures due to jobs timing out. [...] Some of these timeouts are very high -- no test should be taking 10 minutes, even given TCI and a sl

Timeouts in CI jobs (was: cross-i686-tci CI job is flaky again (timeouts): can somebody who cares about TCI investigate?)

Am 20.04.24 um 22:25 schrieb Stefan Weil: Am 16.04.24 um 14:17 schrieb Stefan Weil: Am 16.04.24 um 14:10 schrieb Peter Maydell: The cross-i686-tci job is flaky again, with persistent intermittent failures due to jobs timing out. [...] Some of these timeouts are very high -- no test should be

Re: Timeouts in CI jobs

Am 24.04.24 um 19:09 schrieb Daniel P. Berrangé: On Wed, Apr 24, 2024 at 06:27:58PM +0200, Stefan Weil via wrote: I think the timeouts are caused by running too many parallel processes during testing. The CI uses parallel builds: make -j$(expr $(nproc) + 1) all check-build $MAKE_CHECK_ARGS

Re: building qemu on windows 11

Am 12.01.23 um 16:16 schrieb Neal Elliott: Hello,              is it possible, or has anyone built qemu from the master branch using visual studio? I attempted to build the code using mingw64, but it failed to build. is there a current build document for windows? Building with Visual Studio

Re: MSYS2 and libfdt

Am 19.01.23 um 09:14 schrieb Thomas Huth:  Hi all, in some spare minutes, I started playing with a patch to try to remove the dtc submodule from the QEMU git repository - according to https://repology.org/project/dtc/versions our supported build platforms should now all provide the minimum

Re: Announcement of aborting HAXM maintenance

Am 19.01.23 um 11:12 schrieb Daniel P. Berrangé: On Thu, Jan 19, 2023 at 03:56:04AM +, Wang, Wenchao wrote: Hi, Philippe, Intel decided to abort the development of HAXM and the maintenance of its QEMU part. Should we submit a patch to mark the Guest CPU Cores (HAXM) status as Orphan and rem

Re: [PATCH-for-8.0] block/dmg: Ignore C99 prototype declaration mismatch from

Am 27.03.23 um 17:13 schrieb Philippe Mathieu-Daudé: When liblzfe (Apple LZFSE compression library) is present (for example installed via 'brew') on Darwin, QEMU build fails as: Has header "lzfse.h" : YES Library lzfse found: YES Dependencies lzo support : NO

Re: [PATCH-for-8.0] block/dmg: Ignore C99 prototype declaration mismatch from

Am 27.03.23 um 23:09 schrieb Paolo Bonzini: Il lun 27 mar 2023, 20:58 Philippe Mathieu-Daudé ha scritto: > The warning can also be suppressed if the build uses `-isystem > /opt/homebrew/include` instead of `-I/opt/homebrew/include` as I just > have tested. Is that option adde

Re: [PATCH 19/41] compiler.h: replace QEMU_NORETURN with G_NORETURN

Please excuse the late report, but this old patch causes a build failure for me: Am 20.04.22 um 15:26 schrieb marcandre.lur...@redhat.com: From: Marc-André Lureau G_NORETURN was introduced in glib 2.68, fallback to G_GNUC_NORETURN in glib-compat. Note that this attribute must be placed befor

Re: [PATCH 19/41] compiler.h: replace QEMU_NORETURN with G_NORETURN

Am 07.04.23 um 19:01 schrieb Stefan Weil: Please excuse the late report, but this old patch causes a build failure for me: I just noticed that this is already fixed in latest code (I tested the build with v8.0.0-rc0). So nothing to do. Sorry for the noise. Stefan

[PATCH] hw/arm: Fix some typos in comments (most found by codespell)

Signed-off-by: Stefan Weil --- The patch does not change code and could also be applied for 8.0. hw/arm/Kconfig| 2 +- hw/arm/exynos4210.c | 4 ++-- hw/arm/musicpal.c | 2 +- hw/arm/omap1.c| 2 +- hw/arm/omap2.c| 2 +- hw/arm/virt-acpi-build.c

[PATCH for-8.0] docs: Fix typo (wphx => whpx)

Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1529 Signed-off-by: Stefan Weil --- I suggest to apply the patch for 8.0 because it fixes documentation. Regards Stefan W. docs/system/introduction.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/system/introd

[PATCH for-8.0] docs/cxl: Fix sentence

Signed-off-by: Stefan Weil --- If my change is okay I suggest to apply the patch for 8.0 because it fixes documentation. Regards, Stefan W. docs/system/devices/cxl.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/system/devices/cxl.rst b/docs/system/devices/cxl.rst

Re: [PATCH v2 1/2] qga-win: add logging to Windows event log

Hi, cross builds fail with this code. Please see details below. Am 29.11.22 um 18:38 schrieb Andrey Drobyshev via: This commit allows QGA to write to Windows event log using Win32 API's ReportEvent() [1], much like syslog() under *nix guests. In order to generate log message definitions we use

Re: [PATCH v2 1/2] qga-win: add logging to Windows event log

Am 23.01.23 um 20:38 schrieb Andrey Drobyshev: Hi Stefan, On 1/23/23 19:28, Stefan Weil wrote: Hi, cross builds fail with this code. Please see details below. Am 29.11.22 um 18:38 schrieb Andrey Drobyshev via: This commit allows QGA to write to Windows event log using Win32 API's ReportEven

Re: source fails to compile on msys2

Am 12.04.23 um 14:12 schrieb BALATON Zoltan: On Wed, 12 Apr 2023, Howard Spoelstra wrote: It seems the current source fails to compile with up to date msys2. See here: https://qemu.weilnetz.de/ I think there are some patches there that aren't upstream. I don't know why and also don't know wh

Re: source fails to compile on msys2

Am 12.04.23 um 15:13 schrieb Howard Spoelstra: Hello Peter, My source was cloned today. I just cloned again and I still see the tokens reversed: git clone https://www.gitlab.com/qemu/qemu qemu-master-clean The official URL is https://gitlab.com/qemu-project

Re: [PATCH v2 1/1] ui/sdl2: disable SDL_HINT_GRAB_KEYBOARD on Windows

Am 18.04.23 um 08:56 schrieb Volker Rümelin: Windows sends an extra left control key up/down input event for every right alt key up/down input event for keyboards with international layout. Since commit 830473455f ("ui/sdl2: fix handling of AltGr key on Windows") QEMU uses a Windows low level ke

Re: [PATCH v2] docs/about: Update the support statement for Windows

Am 12.05.22 um 16:30 schrieb Thomas Huth: On 12/05/2022 10.37, Daniel P. Berrangé wrote: On Thu, May 12, 2022 at 09:39:29AM +0200, Thomas Huth wrote: Our support statement for Windows currently talks about "Vista / Server 2008" - which is related to the API of Windows, and this is not easy to

Re: [PATCH 02/16] util/win32: simplify qemu_get_local_state_dir()

Am 04.05.22 um 19:30 schrieb marcandre.lur...@redhat.com: From: Marc-André Lureau SHGetFolderPath() is a deprecated API: https://docs.microsoft.com/en-us/windows/win32/api/shlobj_core/nf-shlobj_core-shgetfolderpatha It is a wrapper for SHGetKnownFolderPath() and CSIDL_COMMON_PATH is mapped to

Re: [PATCH 06/16] include: adjust header guards after renaming

Am 04.05.22 um 19:30 schrieb marcandre.lur...@redhat.com: From: Marc-André Lureau Signed-off-by: Marc-André Lureau --- include/qemu/help-texts.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/qemu/help-texts.h b/include/qemu/help-texts.h index ba32cc8b1f39.

Re: [PATCH] docs/about: Update the support statement for Windows

Am 05.05.22 um 10:27 schrieb Peter Maydell: Ccing Stefan Weil, since we're talking about clarifying what our supported Windows host set is... On Thu, 5 May 2022 at 08:54, Thomas Huth wrote: Our support statement for Windows currently talks about "Vista / Server 2008" - which is related to th

Re: [PATCH v2] Fix 'writeable' typos

Am 05.05.22 um 11:50 schrieb Peter Maydell: We have about 30 instances of the typo/variant spelling 'writeable', and over 500 of the more common 'writable'. Standardize on the latter. Change produced with: sed -i -e 's/\([Ww][Rr][Ii][Tt]\)[Ee]\([Aa][Bb][Ll][Ee]\)/\1\2/g' $(git grep -il wr

Re: [RFC PATCH] docs/about/deprecated: Deprecate 32-bit host systems

On Fri, Feb 17, 2023 at 11:36:41AM +0100, Markus Armbruster wrote: Which 32-bit hosts are still useful, and why? Citing my previous mail: I now checked all downloads of the latests installers since 2022-12-30. qemu-w32-setup-20221230.exe – 509 different IP addresses qemu-w64-setup-

Re: [RFC PATCH] docs/about/deprecated: Deprecate 32-bit host systems

Am 19.02.23 um 12:27 schrieb Reinoud Zandijk: On Fri, Feb 17, 2023 at 12:05:46PM +0100, Stefan Weil wrote: So there still seems to be a certain small need for QEMU installers for 32-bit Windows: 170 users für 32 bit only, 339 users for both 32 and 64 bit, 5132 users for 64 bit only. As you see

Re: [PATCH] Updated the FSF address to

Am 20.02.23 um 08:01 schrieb Khadija Kamran: From: Khadija Kamran The Free Software Foundation moved to a new address and some sources in QEMU referred to their old location. The address should be updated and replaced to a pointer to ... replaced by a pointer

[RFC PATCH] Add new build target 'check-spelling'

`make check-spelling` can now be used to get a list of spelling errors. It uses the latest version of codespell, a spell checker implemented in Python. Signed-off-by: Stefan Weil --- This RFC can already be used for manual tests, but still reports false positives, mostly because some variable na

[PULL 0/4] Patches for Windows

The following changes since commit 75d30fde55485b965a1168a21d016dd07b50ed32: Merge tag 'block-pull-request' of https://gitlab.com/stefanha/qemu into staging (2022-10-30 15:07:25 -0400) are available in the Git repository at: https://gitlab.com/stweil/qemu.git tags/pull-qemu-20221031 for yo

[PULL 3/4] scripts/nsis.py: Automatically package required DLLs of QEMU executables

From: Bin Meng At present packaging the required DLLs of QEMU executables is a manual process, and error prone. Actually build/config-host.mak contains a GLIB_BINDIR variable which is the directory where glib and other DLLs reside. This works for both Windows native build and cross-build on Linu

[PULL 2/4] scripts/nsis.py: Fix destination directory name when invoked on Windows

From: Bin Meng "make installer" on Windows fails with the following message: Traceback (most recent call last): File "G:\msys64\home\foo\git\qemu\scripts\nsis.py", line 89, in main() File "G:\msys64\home\foo\git\qemu\scripts\nsis.py", line 34, in main with open( OSError:

[PULL 4/4] block/nfs: Fix 32-bit Windows build

From: Bin Meng libnfs.h declares nfs_fstat() as the following for win32: int nfs_fstat(struct nfs_context *nfs, struct nfsfh *nfsfh, struct __stat64 *st); The 'st' parameter should be of type 'struct __stat64'. The codes happen to build successfully for 64-bit Windows, but it

[PULL 1/4] scripts/nsis.py: Drop the unnecessary path separator

From: Bin Meng There is no need to append a path separator to the destination directory that is passed to "make install". Signed-off-by: Bin Meng Message-Id: <20220908132817.1831008-2-bmeng...@gmail.com> Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Stefan Weil Signed-off-by: Stefan Weil

Re: [PATCH 0/7] nsis: gitlab-ci: Improve QEMU Windows installer packaging

Am 31.10.22 um 07:52 schrieb Thomas Huth: On 29/10/2022 15.45, Bin Meng wrote: Stefan has reviewed / tested patch 1-3. Not sure who is going to queue these 3 patches? If Stefan has time for a pull request, I think he would be the best fit. Stefan? Otherwise, maybe Marc-André could take tho

[PATCH] Add nsis.py to W32/W64 section in MAINTAINERS

Signed-off-by: Stefan Weil --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 64893e36bc..534b1b8a63 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -548,6 +548,7 @@ F: */*win32* F: include/*/*win32* X: qga/*win32* F: qemu.nsi +F: scripts/nsis.py

Re: [RFC PATCH] Add new build target 'check-spelling'

Am 31.10.22 um 08:52 schrieb Thomas Huth: On 31/10/2022 08.43, Stefan Weil wrote: `make check-spelling` can now be used to get a list of spelling errors. It uses the latest version of codespell, a spell checker implemented in Python. Signed-off-by: Stefan Weil --- This RFC can already be u

Re: [PATCH] Add nsis.py to W32/W64 section in MAINTAINERS

Am 31.10.22 um 11:28 schrieb Philippe Mathieu-Daudé: On 31/10/22 10:57, Stefan Weil via wrote: Signed-off-by: Stefan Weil ---   MAINTAINERS | 1 +   1 file changed, 1 insertion(+) Reviewed-by: Philippe Mathieu-Daudé Cc qemu-trivial

Re: [PATCH v2] Fix some typos in documentation and comments

Am 31.10.22 um 08:35 schrieb Thomas Huth: On 30/10/2022 11.59, Stefan Weil wrote: Most of them were found and fixed using codespell. Signed-off-by: Stefan Weil --- v2: Fixes from Peter Maydell's comments My focus was fixing typos which are relevant for the generated documentation. codesp

Re: [RFC PATCH] Add new build target 'check-spelling'

Below I added some examples for the words which are currently ignored by codespell. Am 31.10.22 um 16:40 schrieb Philippe Mathieu-Daudé: On 31/10/22 08:43, Stefan Weil via wrote: `make check-spelling` can now be used to get a list of spelling errors. It uses the latest version of codespell

Re: [PATCH v3 16/24] disas/nanomips: Remove IMMEDIATE functions

Am 12.09.22 um 14:26 schrieb Milica Lazarevic: Both versions of IMMEDIATE functions have been removed. Before this patch, we'd been calling img_format twice, the first time through the IMMEDIATE to get an appropriate string and the second time to print that string. There's no more need for that.

Re: [PATCH v3 16/24] disas/nanomips: Remove IMMEDIATE functions

Am 01.11.22 um 10:27 schrieb Philippe Mathieu-Daudé: On 1/11/22 09:28, Stefan Weil via wrote: Am 12.09.22 um 14:26 schrieb Milica Lazarevic: Both versions of IMMEDIATE functions have been removed. Before this patch, we'd been calling img_format twice, the first time through the IMMEDIA

Re: [PATCH 1/5] disas/nanomips: Fix invalid PRId64 format calling img_format()

Am 01.11.22 um 12:44 schrieb Philippe Mathieu-Daudé: Fix warnings such: disas/nanomips.c:3251:64: warning: format specifies type 'char *' but the argument has type 'int64' (aka 'long long') [-Wformat] return img_format("CACHE 0x%" PRIx64 ", %s(%s)", op_value, s_value, rs);

Re: [PATCH 2/5] disas/nanomips: Fix invalid PRIx64 format calling img_format()

Am 01.11.22 um 12:44 schrieb Philippe Mathieu-Daudé: Fix: disas/nanomips.c:12231:62: warning: format specifies type 'char *' but the argument has type 'uint64' (aka 'unsigned long long') [-Wformat] return img_format("RESTOREF 0x%" PRIx64 ", %s", u_value, count_value);

Re: [PATCH 3/5] disas/nanomips: Use G_GNUC_PRINTF to avoid invalid string formats

Am 01.11.22 um 12:44 schrieb Philippe Mathieu-Daudé: Suggested-by: Stefan Weil Signed-off-by: Philippe Mathieu-Daudé --- disas/nanomips.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/disas/nanomips.c b/disas/nanomips.c index e4b21e7c45..3f45447292 100644 --- a/disas/n

Re: [PATCH 4/5] disas/nanomips: Remove headers already included by "qemu/osdep.h"

Am 01.11.22 um 12:44 schrieb Philippe Mathieu-Daudé: Signed-off-by: Philippe Mathieu-Daudé --- disas/nanomips.c | 4 1 file changed, 4 deletions(-) diff --git a/disas/nanomips.c b/disas/nanomips.c index 3f45447292..821d4f8832 100644 --- a/disas/nanomips.c +++ b/disas/nanomips.c @@ -30,

[PATCH for 7.2] Fix broken configure with -Wunused-parameter

The configure script fails because it tries to compile small C programs with a main function which is declared with arguments argc and argv although those arguments are unused. Running `configure -extra-cflags=-Wunused-parameter` triggers the problem. configure for a native build does abort but sh

Re: [PATCH] Run docker probe only if docker or podman are available

Am 30.10.22 um 09:35 schrieb Stefan Weil: The docker probe uses "sudo -n" which can cause an e-mail with a security warning each time when configure is run. Therefore run docker probe only if either docker or podman are available. That avoids the problematic "sudo -n" on build environments wh

[PATCH] Add missing include statement for global xml_builtin

This fixes some compiler warnings with compiler flag -Wmissing-variable-declarations (tested with clang): aarch64_be-linux-user-gdbstub-xml.c:564:19: warning: no previous extern declaration for non-static variable 'xml_builtin' [-Wmissing-variable-declarations] aarch64-linux-user-gdbstub

Re: [PATCH for 7.2] Fix broken configure with -Wunused-parameter

Am 03.11.22 um 09:58 schrieb Daniel P. Berrangé: On Wed, Nov 02, 2022 at 09:22:58PM +0100, Stefan Weil via wrote: The configure script fails because it tries to compile small C programs with a main function which is declared with arguments argc and argv although those arguments are unused

Re: [PATCH for 7.2] Fix broken configure with -Wunused-parameter

Am 03.11.22 um 12:48 schrieb Peter Maydell: On Wed, 2 Nov 2022 at 20:24, Stefan Weil via wrote: The configure script fails because it tries to compile small C programs with a main function which is declared with arguments argc and argv although those arguments are unused. Running `configure

Re: [PATCH] meson: avoid unused arguments of main() in compiler tests

Am 03.11.22 um 18:21 schrieb Paolo Bonzini: meson.build has one test where "main" is declared unnecessarily with argc and argv arguments, but does not use them. Because the test needs -Werror too, HAVE_BROKEN_SIZE_MAX is defined incorrectly. Fix the test and, for consistency, remove argc and a

Re: [PULL 04/10] libvhost-user: Fix wrong type of argument to formatting function (reported by LGTM)

Am 04.11.22 um 17:16 schrieb Laurent Vivier: Hi Stefan, Le 03/11/2022 à 17:17, Laurent Vivier a écrit : From: Stefan Weil Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Stefan Weil Message-Id: <20220422070144.1043697-2...@weilnetz.de> Signed-off-by: Laurent Vivier ---   subprojects/li

[PATCH v2 3/4] libvhost-user: Fix two more format strings

This fix is required for 32 bit host. The bug was detected by CI for arm-linux, but is also relevant for i386-linux. Reported-by: Stefan Hajnoczi Signed-off-by: Stefan Weil --- subprojects/libvhost-user/libvhost-user.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/subpro

[PATCH v2 2/4] libvhost-user: Fix format strings

Signed-off-by: Stefan Weil Reviewed-by: Marc-André Lureau Message-Id: <20220422070144.1043697-3...@weilnetz.de> Signed-off-by: Laurent Vivier --- subprojects/libvhost-user/libvhost-user.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/subprojects/libvhost-user/libvhost-

[PATCH v2 4/4] libvhost-user: Add format attribute to local function vu_panic

Signed-off-by: Stefan Weil Reviewed-by: Marc-André Lureau Message-Id: <20220422070144.1043697-4...@weilnetz.de> Signed-off-by: Laurent Vivier --- subprojects/libvhost-user/libvhost-user.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/subprojects/libvhost-user

[PATCH v2 1/4] libvhost-user: Fix wrong type of argument to formatting function (reported by LGTM)

Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Stefan Weil Message-Id: <20220422070144.1043697-2...@weilnetz.de> Signed-off-by: Laurent Vivier --- subprojects/libvhost-user/libvhost-user.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/subprojects/libvhost-user/libvhost

[PATCH v2 for-7.2 0/4] libvhost-user: Add format attribute and fix format strings

v2: Add patch 3 to fix two more format strings before applying patch 4 [PATCH v2 1/4] libvhost-user: Fix wrong type of argument to [PATCH v2 2/4] libvhost-user: Fix format strings [PATCH v2 3/4] libvhost-user: Fix two more format strings [PATCH v2 4/4] libvhost-user: Add format attribute to local

Re: [PATCH v2 3/4] libvhost-user: Fix two more format strings

Am 05.11.22 um 11:24 schrieb Stefan Weil via: This fix is required for 32 bit host. The bug was detected by CI for arm-linux, but is also relevant for i386-linux. s/host/hosts/ I won't send a v3 for that. Maybe it can be fixed when merging this patch. Stefan

[PATCH for-7.2] accel/tcg: Suppress compiler warning with flag -Wclobbered

At least some versions of gcc show a warning when compiler flag -Wclobbered is used (tested with gcc on Debian bookworm i386 and with cross gcc for Windows on Debian bullseye). Signed-off-by: Stefan Weil --- accel/tcg/translate-all.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/accel/t

[PATCH for-7.2] tests/qtest: Fix two format strings

Signed-off-by: Stefan Weil --- tests/qtest/migration-test.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/qtest/migration-test.c b/tests/qtest/migration-test.c index d2eb107f0c..f574331b7b 100644 --- a/tests/qtest/migration-test.c +++ b/tests/qtest/migration-test.c

Re: [PATCH trivial for 7.2 1/2] hw/usb/hcd-xhci.c: spelling: tranfer

Am 05.11.22 um 12:48 schrieb Michael Tokarev: Fixes: effaf5a240e03020f4ae953e10b764622c3e87cc Signed-off-by: Michael Tokarev --- hw/usb/hcd-xhci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/usb/hcd-xhci.c b/hw/usb/hcd-xhci.c index 8299f35e66..b89b618ec2 100644 ---

Re: [PATCH trivial for 7.2 2/2] hw/virtio/virtio.c: spelling: suppoted

Am 05.11.22 um 12:48 schrieb Michael Tokarev: Fixes: f3034ad71fcd0a6a58bc37830f182b307f089159 Signed-off-by: Michael Tokarev --- hw/virtio/virtio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c index 808446b4c9..e76218bdd5 100644 -

Re: [PATCH trivial for 7.2] hw/ssi/sifive_spi.c: spelling: reigster

Am 05.11.22 um 12:53 schrieb Michael Tokarev: Fixes: 0694dabe9763847f3010b54ab3ec7d367d2f0ff0 Signed-off-by: Michael Tokarev --- hw/ssi/sifive_spi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/ssi/sifive_spi.c b/hw/ssi/sifive_spi.c index 03540cf5ca..1b4a401ca1 10064

Re: [PATCH trivial for 7.2 1/2] hw/usb/hcd-xhci.c: spelling: tranfer

Am 05.11.22 um 12:57 schrieb Stefan Weil via: Am 05.11.22 um 12:48 schrieb Michael Tokarev: Fixes: effaf5a240e03020f4ae953e10b764622c3e87cc Signed-off-by: Michael Tokarev ---   hw/usb/hcd-xhci.c | 2 +-   1 file changed, 1 insertion(+), 1 deletion(-) All typos from this series were also found

Re: [PATCH trivial for 7.2 1/2] hw/usb/hcd-xhci.c: spelling: tranfer

Am 05.11.22 um 22:24 schrieb Michael Tokarev: 05.11.2022 15:23, Stefan Weil via wrote: .. All typos from this series were also found by codespell. See https://qemu.weilnetz.de/test/typos7 for many more. That list was produced with `make check-spelling` from my previous patch). Yeah

[PATCH for-7.2] Fix several typos in documentation (found by codespell)

Those typos are in files which are used to generate the QEMU manual. Signed-off-by: Stefan Weil --- I did not fix memory_region_init_resizeable_ram. That might be done after 7.2. Stefan docs/devel/acpi-bits.rst | 2 +- docs/system/devices/can.rst| 2 +- hw/scsi/esp.c

[RFC: PATCH v2] Add new build targets 'check-spelling' and 'check-spelling-docs'

`make check-spelling` can now be used to get a list of spelling errors. It uses the latest version of codespell, a spell checker implemented in Python. 'make check-spelling-docs' checks the generated documentation. Signed-off-by: Stefan Weil --- v2: Additional target check-spelling-docs, update

Re: [PATCH] s390x: Fix spelling errors

Am 11.11.22 um 19:28 schrieb Thomas Huth: Fix typos (discovered with the 'codespell' utility). Signed-off-by: Thomas Huth --- hw/s390x/ipl.h | 2 +- pc-bios/s390-ccw/cio.h | 2 +- pc-bios/s390-ccw/iplb.h | 2 +- target/s390x/cpu_models.h

Re: [PATCH 0/3] libvhost-user: Add format attribute and fix format strings

Am 22.04.22 um 09:01 schrieb Stefan Weil: At least the 1st two patches could also be applied via qemu-trivial. One of them missed release 7.0, so hopefully the fixes will be included in the next QEMU release. Stefan W. [PATCH 1/3] libvhost-user: Fix wrong type of argument to formatting [PATCH 2

Re: [PATCH 1/7] scripts/nsis.py: Drop the unnecessary path separator

Am 08.09.22 um 15:28 schrieb Bin Meng: From: Bin Meng There is no need to append a path separator to the destination directory that is passed to "make install". Signed-off-by: Bin Meng --- scripts/nsis.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/nsis.py

Re: [PATCH 2/7] scripts/nsis.py: Fix destination directory name when invoked on Windows

Am 08.09.22 um 15:28 schrieb Bin Meng: From: Bin Meng "make installer" on Windows fails with the following message: Traceback (most recent call last): File "G:\msys64\home\foo\git\qemu\scripts\nsis.py", line 89, in main() File "G:\msys64\home\foo\git\qemu\scripts\nsis.py",

Re: [PATCH v10 0/4] cutils: Introduce bundle mechanism

Am 27.06.22 um 05:57 schrieb Akihiko Odaki: Developers often run QEMU without installing. The bundle mechanism allows to look up files which should be present in installation even in such a situation. It is a general mechanism and can find any files located relative to the installation tree. Th

Re: [PATCH 3/7] scripts/nsis.py: Automatically package required DLLs of QEMU executables

Am 08.09.22 um 15:28 schrieb Bin Meng: From: Bin Meng At present packaging the required DLLs of QEMU executables is a manual process, and error prone. Actually build/config-host.mak contains a GLIB_BINDIR variable which is the directory where glib and other DLLs reside. This works for both Win

Re: [PATCH v2 29/30] tests/docker: remove FROM qemu/ support from docker.py

Am 15.09.22 um 10:41 schrieb Richard Henderson: On 9/14/22 16:59, Alex Bennée wrote: We want to migrate from docker.py to building our images directly with docker/podman. Before we get there we need to make sure we don't re-introduce our layered builds so bug out if we see FROM qemu/ in a Docker

  1   2   >