The VMState API is rather sparsely documented. Start by describing the
meaning of all VMStateFlags.
Signed-off-by: Sascha Silbe
---
Since I had to dive into the code for debugging the migration breakage
anyway, I figured I could just as well write down the result in the
form of comments so the
r your help on this.
Thanks, looking forward to the next version of your patch. Will use the
the previous one in the meantime as a local work-around.
Sascha
--
Softwareentwicklung Sascha Silbe, Niederhofenstraße 5/1, 71229 Leonberg
https://se-silbe.de/
USt-IdNr. DE281696641
-blk on all architectures whenever
the test case doesn't care about the device type. (I doubt the tests
currently work on architectures that don't support virtio, but will of
course check this).
Sascha
--
Softwareentwicklung Sascha Silbe, Niederhofenstraße 5/1, 71229 Leonberg
https://se-silbe.de/
USt-IdNr. DE281696641
The order of some QMP events may depend on the architecture being
tested. Add support for filtering out QMP events so we can use a
single reference output for all architecture when the test doesn't
care about the events.
Signed-off-by: Sascha Silbe
---
tests/qemu-iotests/common.filte
he Python-based test case 139, so the test coverage should be
unaffected. Make use of _filter_qmp_events() introduced by the
previous patch to remove QMP events from the test case output and
adjust the reference output accordingly.
Signed-off-by: Sascha Silbe
---
This patch is a lot easier to read
second patch.
Sascha Silbe (2):
qemu-iotests: add _filter_qmp_events() for filtering out QMP events
qemu-iotests: 067: ignore QMP events
tests/qemu-iotests/067 | 4 +-
tests/qemu-iotests/067.out | 527 +++
tests/qemu-iotests/common.filter
IDE is only implemented by very few architectures (mostly PC). Use
virtio-scsi instead so the test works on all architectures that
support virtio. In particular, this fixes qemu-iotests on s390x.
Fixes: 16dee418 ("iotests: Add test for eject under NBD server")
Signed-off-by: Sa
devices that are implemented on all
architectures supporting virtio.
For virtio-balloon, only the CCW implementation was missing.
Signed-off-by: Sascha Silbe
---
This leaves out
virtio-{gpu,input,input-hid,input-host,keyboard,mouse,tablet} because
they're currently only implemented usin
Yet another IDE-using test crept in (commit 16dee418). Fix it by using
virtio-scsi. And to make this easier, provide cross-architecture
aliases for all virtio devices.
Sascha Silbe (3):
qdev-monitor: sort alias table by typename
qdev-monitor: add missing aliases for virtio-{9p,balloon,rng
Sort the alias table by typename so it's easier to see which aliases
exist.
Signed-off-by: Sascha Silbe
---
qdev-monitor.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/qdev-monitor.c b/qdev-monitor.c
index 81e3ff3..0145deb 100644
--- a/qdev-monitor.c
. And before I start
implementing a JSON indenter in awk, I'd rather rewrite the whole test
in Python. So if we stay with the shell test for now, we need something
like your incantation above. It's not perfect, but good enough for now
and I can't think of anything significantly simpler right now either.
Will test your version and send a v2. Thanks for the suggestion!
Sascha
--
Softwareentwicklung Sascha Silbe, Niederhofenstraße 5/1, 71229 Leonberg
https://se-silbe.de/
USt-IdNr. DE281696641
to work? I.e. can we rely on it? If so, that would
certainly be the easier route for this particular test. Test coverage
should be unaffected as 139 already tests ejection (using virtio, unlike
118 which is PC-only).
The aliases patch has a value of its own, but that's a separate
matter.
Sascha
--
Softwareentwicklung Sascha Silbe, Niederhofenstraße 5/1, 71229 Leonberg
https://se-silbe.de/
USt-IdNr. DE281696641
Dear Conny,
Cornelia Huck writes:
> On Thu, 11 Feb 2016 10:01:35 +0100
> Markus Armbruster wrote:
>
>> Sascha Silbe writes:
>
>> > This leaves out
>> > virtio-{gpu,input,input-hid,input-host,keyboard,mouse,tablet} because
>> > they're c
Dear Markus,
Markus Armbruster writes:
> Sascha Silbe writes:
>
>> Sort the alias table by typename so it's easier to see which aliases
>> exist.
[...]
[qdev-monitor.c]
>
> Suggest to add
>
>/* Please keep this table sorted */
Good idea. I've a
o complex for my taste. If
_filter_qmp_events() isn't generic enough to be used by other test
cases, I can make it internal to 067. Alternatively I can port 067 to
Python, which can handle JSON data types natively with no need for
post-processing hacks.
Sascha
--
Softwareentwicklung Sascha Silbe, Niederhofenstraße 5/1, 71229 Leonberg
https://se-silbe.de/
USt-IdNr. DE281696641
to introduce another macro
VMSTATE_STRUCT_VARRAY_POINTER_KNOWN?
PS: Won't your patch break migration between different qemu versions? I
don't see any compat code and you're changing at least some field names
(e.g. "virtqueues" vs. "vq").
Sascha
--
Softwareentwicklung Sascha Silbe, Niederhofenstraße 5/1, 71229 Leonberg
https://se-silbe.de/
USt-IdNr. DE281696641
the above, migration fails on x86_64, too. Your patch fixes the
basic save/resume test on both x86_64 and s390x, so:
Tested-By: Sascha Silbe
(I currently don't have a more extensive test for migration; in
particular nothing that puts the guest in a pre-defined state and
compares on-the-wi
current naming scheme in the
first place, e.g. VMSTATE_ARRAY_INT32_UNSAFE vs. VMSTATE_VARRAY_INT32,
with both of them specifying VMS_VARRAY_INT32...
Sascha
--
Softwareentwicklung Sascha Silbe, Niederhofenstraße 5/1, 71229 Leonberg
https://se-silbe.de/
USt-IdNr. DE281696641
IDE is only implemented by very few architectures (mostly PC). The
test doesn't actually need a block device attached to the
BlockBackend, so just drop it and adjust the reference output
accordingly.
Fixes: 16dee418 ("iotests: Add test for eject under NBD server")
Signed-off-b
ption of qemu-iotest 140
Sascha Silbe (2):
qemu-iotests: 140: don't use IDE drive
qemu-iotests: 140: make description slightly more verbose
tests/qemu-iotests/140 | 8 ++--
tests/qemu-iotests/140.out | 1 -
2 files changed, 6 insertions(+), 3 deletions(-)
--
2.1.4
Describe in a little more detail what the test is supposed to achieve.
Signed-off-by: Sascha Silbe
---
Max, does this reflect your intentions well enough? I took the liberty
of re-using some of your review comments to extend the description.
v1->v2: new patch
tests/qemu-iotests/140
pu' (alias 'virtio-gpu-ccw')
> is not a valid device model name
>
> would make it obvious that some alias expansion had been going on. I
> think that would be useful.
Good idea. Will include a patch for this in the next version.
Sascha
--
Softwareentwicklung Sascha S
l name
Special-case the error message to make it explicit that alias
expansion is going on:
$ s390x-softmmu/qemu-system-s390x -device virtio-gpu
qemu-system-s390x: -device virtio-gpu: 'virtio-gpu' (alias
'virtio-gpu-ccw') is not a valid device model name
Suggested-By: Corneli
existing non-abstract virtio device classes.
For virtio-balloon, only the CCW implementation was missing.
Signed-off-by: Sascha Silbe
---
v1->v2:
- Completely wired up all (non-abstract) virtio device classes, even
those that still lack a CCW implementation.
Markus, does your Reviewed-by apply
an alias doesn't exist
- added comment about keeping alias table sorted
- covering all non-abstract virtio device classes rather than just
those already implemented on s390x
Sascha Silbe (3):
qdev-monitor: improve error message when alias device is unavailable
qdev-monitor: sort alias tab
Sort the alias table by typename so it's easier to see which aliases
exist.
Signed-off-by: Sascha Silbe
---
v1->v2: Added comment asking devs to keep table sorted
---
qdev-monitor.c | 15 ---
1 file changed, 8 insertions(+), 7 deletions(-)
diff --git a/qdev-monitor.
oid
switching to single-line JSON which is hard to read
- roll _filter_qmp_events() into 067 as the multi-line version isn't
robust enough for general use
Sascha Silbe (1):
qemu-iotests: 067: ignore QMP events
tests/qemu-iotests/067 | 11 +++-
tests/qemu-iotests/067.o
thon-based test case 139, so the test coverage should be
unaffected. Make use of the recently introduced _filter_qmp_events()
to remove QMP events from the test case output and adjust the
reference output accordingly.
The tr / sed / tr trick used for filtering was suggested by Max Reitz
.
Signed-
t do any virtio-foo → virtio-foo-{pci,ccw} alias magic for it.
[...]
> Reviewed-by: Cornelia Huck
Thanks for the reviews!
Sascha
--
Softwareentwicklung Sascha Silbe, Niederhofenstraße 5/1, 71229 Leonberg
https://se-silbe.de/
USt-IdNr. DE281696641
Dear Amit,
Amit Shah writes:
> On (Thu) 21 Jan 2016 [21:39:27], Sascha Silbe wrote:
>> The VMState API is rather sparsely documented. Start by describing the
>> meaning of all VMStateFlags.
> Thanks, I've pulled this in my queue.
>
> There's one new flag add
Dear Amit,
> Amit Shah writes:
>
>> On (Thu) 21 Jan 2016 [21:39:27], Sascha Silbe wrote:
>>> The VMState API is rather sparsely documented. Start by describing the
>>> meaning of all VMStateFlags.
>
>> Thanks, I've pulled this in my queue.
>>
&g
The VMState API is rather sparsely documented. Start by describing the
meaning of all VMStateFlags.
Reviewed-by: Amit Shah
Reviewed-by: Juan Quintela
Signed-off-by: Sascha Silbe
---
v1->v2:
- rebased on current devel
- documented VMS_MULTIPLY_ELEMENTS (including references
Dear Amit,
Amit Shah writes:
>> FWIW, here's the version based on current master. As mentioned before;
>> I'm happy to rebase on your version if you prefer.
>
> Thanks, can you please post this as a standalone email? Easier for me
> to apply.
Sure.
Sascha
--
S
stering the
quorum block driver if we know it cannot work. This way API consumers
can recognise it's unavailable.
Fixes: 488981a4af396551a3178d032cc2b41d9553ada2
Signed-off-by: Sascha Silbe
---
block/quorum.c | 10 --
1 files changed, 4 insertions(+), 6 deletions(-)
diff --git a
Dear Peter,
Peter Maydell writes:
> Applied to master, thanks.
Thanks everyone for the fast reviews and inclusion!
Sascha
--
Softwareentwicklung Sascha Silbe, Niederhofenstraße 5/1, 71229 Leonberg
https://se-silbe.de/
USt-IdNr. DE281696641
est 041 and 055
>> qemu-iotests: s390x: fix test 049, reject negative sizes in QemuOpts
>> qemu-iotests: s390x: fix test 130
>
> Thanks, applied to the block branch.
I don't see them in master yet. Is there anything else missing before
you're going to send your ne
Sascha Silbe writes:
[...]
> This series makes crafting qemu command lines that work across
> multiple (virtio-supporting) platforms at lot easier.
[...]
Ping. Conny has already given her Reviewed-By; Markus gave it for a
previous version of the third patch. Are there any other opinions o
g them all unconditionally is a bad idea anyway. Since __all__
is not adding any value, let's just get rid of it.
Fixes: f345cfd0 ("qemu-iotests: add iotests Python module")
Signed-off-by: Sascha Silbe
Reviewed-by: Bo Tu
---
tests/qemu-iotests/iotests.py | 4
1 file changed, 4 deletio
Placing files with predictable or even hard-coded names in /tmp is a
security risk and can prevent or disturb operation on a multi-user
machine. Place them inside the "scratch" directory instead, as we
already do for most other test-related files.
Signed-off-by: Sascha Silbe
Reviewed
HE_WB")
Signed-off-by: Sascha Silbe
Reviewed-by: Bo Tu
---
tests/qemu-iotests/051.out | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/tests/qemu-iotests/051.out b/tests/qemu-iotests/051.out
index c1291ff..408d613 100644
--- a/tests/qemu-iotests/051.out
+++ b/
ff-by: Sascha Silbe
Reviewed-by: Bo Tu
---
tests/qemu-iotests/148| 4 +---
tests/qemu-iotests/iotests.py | 5 +
2 files changed, 6 insertions(+), 3 deletions(-)
diff --git a/tests/qemu-iotests/148 b/tests/qemu-iotests/148
index d066ec3..e01b061 100644
--- a/tests/qemu-iotests/148
+++ b/
ib64/python2.7/socket.py", line 224, in meth
+return getattr(self._sock,name)(*args)
+error: [Errno 98] Address already in use
Fix this by cleaning up both the monitor socket and the qtest socket iff
they exist.
Signed-off-by: Sascha Silbe
Reviewed-by: Bo Tu
---
tests/qemu-iotests/iote
None of the other test cases explicitly enable KVM and there's no
obvious reason for 068 to require it. Drop this so all test cases can be
executed in environments where KVM is not available (e.g. because the
user doesn't have sufficient permissions to access /dev/kvm).
Signed-off-
With these fixes, qemu-iotests complete successfully on my test
systems (s390x, x86_64) when used with QCOW2 or raw image formats.
These are purely bug fixes for tests and most are trivial, so they
should be safe even for hard freeze.
Sascha Silbe (7):
qemu-iotests: check: don't place
just replace it with a fixed
value globally (in _filter_qmp), the same way we handle timestamps.
Signed-off-by: Sascha Silbe
Reviewed-by: Bo Tu
---
tests/qemu-iotests/141 | 11 ++-
tests/qemu-iotests/141.out | 24
tests/qemu-iotests/common.filter
hanks for the reviews!
Sascha
--
Softwareentwicklung Sascha Silbe, Niederhofenstraße 5/1, 71229 Leonberg
https://se-silbe.de/
USt-IdNr. DE281696641
Dear Max,
Max Reitz writes:
> On 05.04.2016 11:21, Sascha Silbe wrote:
>> On systems with fast IO, qemu-io may write more than 1 MiB before
>> receiving the block-job-cancel command, causing the test case to fail.
>>
>> 141 is inherently racy, but we can at least r
Dear Max,
Max Reitz writes:
> On 05.04.2016 11:21, Sascha Silbe wrote:
[...]
[_remove_if_exists()]
> Not sure about the leading underscore (it appears to be the only such
> function in iotests.py besides __init__()), but I guess it's a test so
> it doesn't really matter an
Dear Max,
Sascha Silbe writes:
> @Max: From a cursory glance at the code, maybe your 1 *byte* per second
> rate limit is being rounded down to 0 *blocks* per second, with 0
> meaning no limit? See e.g. mirror_set_speed(). Though I must admit I
> don't understand how spee
Dear Kevin,
Kevin Wolf writes:
> Am 08.04.2016 um 14:01 hat Sascha Silbe geschrieben:
[...]
>> The best approach probably would be to fix up the rate limit code to
>> delay for multiple time slices if necessary. We should get rid of the
>> artificial BDRV_SECTOR_SIZE gr
Dear Max,
Max Reitz writes:
> On 05.04.2016 11:21, Sascha Silbe wrote:
>> With these fixes, qemu-iotests complete successfully on my test
>> systems (s390x, x86_64) when used with QCOW2 or raw image formats.
>>
>> These are purely bug fixes for tests and most are tr
_do() was never used and possibly creates temporary files at
predictable, world-writable locations. Get rid of it.
Signed-off-by: Sascha Silbe
Reviewed-by: Bo Tu
---
tests/qemu-iotests/common.rc | 46
1 file changed, 46 deletions(-)
diff --git a
_within_tolerance() isn't used anymore and possibly creates temporary
files at predictable, world-writable locations. Get rid of it.
If it's needed again in the future it can be revived easily and fixed up
to use TEST_DIR and / or safely created temporary files.
Signed-off-by: Sa
Do not place the valgrind log file at a predictable path in a
world-writable location. Use the common scratch directory (${TEST_DIR})
instead.
Signed-off-by: Sascha Silbe
Reviewed-by: Bo Tu
---
tests/qemu-iotests/common.config | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a
separate patch.
This series mostly removes dead code and addresses a potential
security issue, all of that in the test suite rather than in
production code. It should be applicable even during hard freeze.
Sascha Silbe (4):
qemu-iotests: drop unused _within_tolerance() filter
qemu-iotests:
The previous commit removed the last usage of ${tmp} inside the tests
themselves; the only remaining users are sourced by check. So we can now
drop this variable from the tests.
Signed-off-by: Sascha Silbe
Reviewed-by: Bo Tu
---
tests/qemu-iotests/001 | 1 -
tests/qemu-iotests/002 | 1 -
tests
document it. Mention that this will be fixed
in the future, otherwise some users might misguidedly rely on it or
clamp their configuration settings to the documented value.
Signed-off-by: Sascha Silbe
---
Noticed this while figuring out why qemu-iotests #141 failed on one of
my systems. I for one
Dear developers,
Sascha Silbe writes:
> The current rate limit implementation for block jobs is ineffective
> below a certain minimum rate. It will permit writes at least once per
> time slice. The resulting minimum write speed (assuming source and
> sink are fast enough in the fir
code paths if QEMU_DEFAULT_MACHINE is not
set. This can lead to false negatives.
Instead fail hard and tell the user we want to be run via "check".
Signed-off-by: Sascha Silbe
Reviewed-by: Bo Tu
---
It's possible to fix iotests.py to work even outside of check, but
that requires
Dear Max,
Max Reitz writes:
[...]
> Thanks Sascha, I applied the series to my block tree:
Thanks! I've just sent out the last patch from my local queue (fixing
=/var/tmp= usage). Barring further discoveries during testing, I'm done
for 2.6 now.
Sascha
--
Softwareentwicklung
es that indicate we haven't been run via
"check". They are the ones where there isn't any useful default value we
could fall back, but without a full audit we can't tell what else some
of the tests may expect that would normally be set up by "check" (or at
least I can't).
Sascha
--
Softwareentwicklung Sascha Silbe, Niederhofenstraße 5/1, 71229 Leonberg
https://se-silbe.de/
USt-IdNr. DE281696641
Dear Max,
Max Reitz writes:
> On 14.04.2016 13:32, Sascha Silbe wrote:
[tests/qemu-iotests/iotests.py]
[...]
>> def main(supported_fmts=[], supported_oses=['linux']):
>> '''Run tests'''
>>
>> +if test_dir is None o
y
could even set an environment variable "I_AM_CHECK=yes" if that's part
of the environment the tests expect).
I'd be perfectly fine with defining the environment more clearly and
possibly extending the implementation to allow individual test cases to
be invoked di
document it. Mention that this will be fixed
in the future, otherwise some users might misguidedly rely on it or
clamp their configuration settings to the documented value.
Signed-off-by: Sascha Silbe
---
v1→v2:
- Change qapi/block-core.json, too.
---
qapi/block-core.json | 36
Interesting. What exactly is the relationship between qmp-commands.hx
and qapi/block-core.json?
At any rate, you're right that we should update both. See v2.
(And I've forgot the for-2.6 prefix for the patch itself again. Bah.)
Sascha
--
Softwareentwicklung Sascha Silbe, Niederhofenstraß
Dear Max,
Max Reitz writes:
> On 19.04.2016 14:22, Sascha Silbe wrote:
[...]
>> # We are using TEST_DIR and QEMU_DEFAULT_MACHINE as proxies to
>> # indicate that we're not being run via "check". There may be
>> # other things set up by &qu
" anyway, including setting
the two environment variables we check. Whereas a regular developer
just trying to invoke the tests usually won't have both of these
defined in their environment so we can catch their mistake and give
out useful advice.
Signed-off-by: Sascha Silbe
Reviewed-by: Bo
nding review).
OK, thanks for the clarification!
Sascha
--
Softwareentwicklung Sascha Silbe, Niederhofenstraße 5/1, 71229 Leonberg
https://se-silbe.de/
USt-IdNr. DE281696641
nvironment variables must be set and there may be other things that the
tests may expect to have been set up. See what the 'check' script does
if you want to invoke the tests some other way than running 'check'.",
but I don't really see the additional value to the user.
S
Dear Kevin,
Kevin Wolf writes:
> At this point in the 2.6 release cycle, this series is 2.7 material
> anyway. It's critical fixes only now.
Fair enough.
Sascha
--
Softwareentwicklung Sascha Silbe, Niederhofenstraße 5/1, 71229 Leonberg
https://se-silbe.de/
USt-IdNr. DE281696641
ameter will be unused anyway.
Sascha
--
Softwareentwicklung Sascha Silbe, Niederhofenstraße 5/1, 71229 Leonberg
https://se-silbe.de/
USt-IdNr. DE281696641
that anything outside
/var/lib/libvirt/qemu is not guaranteed to work due to e.g. the SELinux
policy configured by libvirt...
Sascha
--
Softwareentwicklung Sascha Silbe, Niederhofenstraße 5/1, 71229 Leonberg
https://se-silbe.de/
USt-IdNr. DE281696641
Dear Daniel,
[CC += libvir-list, didn't notice before this thread is on qemu-devel
only]
"Daniel P. Berrange" writes:
> On Thu, Jun 02, 2016 at 09:27:45PM +0200, Sascha Silbe wrote:
>> Since 71408079 [qemu: Don't bother user with libvirt-internal paths],
>&g
Dear Peter,
Peter Maydell writes:
> On 25 August 2016 at 10:36, Peter Maydell wrote:
>> On 23 August 2016 at 16:01, Sascha Silbe wrote:
>>> Glad to hear. It would be possibly to support the combination of glib <
>>> 2.30.0 AND windows, but only by copying
ons and that future versions may stop doing so
(i.e. users should use either --verbose --foreground or --verbose
--daemon).
3. At some point in the future (qemu 3.0?) we can stop having --verbose
imply --foreground.
I can give it a try if it's out of scope for your current task
Dear Fam,
Fam Zheng writes:
> On Wed, 08/24 20:30, Sascha Silbe wrote:
[tests/docker/docker.py]
>> @@ -25,6 +25,10 @@ from tarfile import TarFile, TarInfo
>> from StringIO import StringIO
>> from shutil import copy, rmtree
>>
>> +
>> +DEVNULL = open(o
Dear Fam,
Fam Zheng writes:
> On Wed, 08/24 20:31, Sascha Silbe wrote:
[tests/docker/dockerfiles/debian-bootstrap.pre]
>> +# debootstrap < 1.0.67 generates empty sources.list, see Debian#732255
>> +MIN_DEBOOTSTRAP_VERSION=1.0.67
[...]
>> if [ -z
to send output to stderr and added a new patch
that fixes up the existing messages that are "fatal" (i.e. those
directly prior to an exit_and_skip).
Sascha
--
Softwareentwicklung Sascha Silbe, Niederhofenstraße 5/1, 71229 Leonberg
https://se-silbe.de/
USt-IdNr. DE281696641
this issue.
Signed-off-by: Sascha Silbe
Reviewed-by: Janosch Frank
---
This fixes a hang for me when building the Ubuntu docker image (empty
docker image cache).
tests/docker/docker.py | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/tests/docker/docker.py b/tests/docker
the debian-debootstrap image
Sascha Silbe (8):
docker.py: don't hang on large docker output
docker: avoid dependency on 'realpath' package
docker: debian-bootstrap.pre: print error messages to stderr
docker: debian-bootstrap.pre: print helpful message if
DEB_ARCH/DEB_TYPE
When using the git version of debootstrap (because no usable version
of debootstrap was installed on the host), we need to run 'make' so
that devices.tar.gz gets built. Otherwise the first debootstrap stage
will fail without printing any error message.
Signed-off-by: Sascha Silbe
debootstrap prior to 1.0.67 generated an empty sources.list during
foreign bootstraps (Debian#732255 [1]). Fall back to the git checkout
if the installed debootstrap version is too old.
[1] https://bugs.debian.org/732255
Signed-off-by: Sascha Silbe
---
v2→v3:
- fix unbalanced white space
Building the debian-debootstrap image will usually fail if EXECUTABLE
isn't set (when using the Makefile). Warn the user in this case so
they know why it's failing.
Signed-off-by: Sascha Silbe
---
tests/docker/Makefile.include | 3 +++
1 file changed, 3 insertions(+)
diff --git a/te
-off-by: Sascha Silbe
---
tests/docker/docker.py | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tests/docker/docker.py b/tests/docker/docker.py
index efb2bf4..b85c165 100755
--- a/tests/docker/docker.py
+++ b/tests/docker/docker.py
@@ -239,8 +239,9 @@ class BuildCommand
Send error messages where they belong so they're seen even if stdout
is redirected to /dev/null.
Signed-off-by: Sascha Silbe
---
v2→v3:
- new patch
tests/docker/dockerfiles/debian-bootstrap.pre | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/tests/d
sing or erroring out because we cannot cd to the mirror URL.
Signed-off-by: Sascha Silbe
---
v2→v3:
- send error messages to stderr
tests/docker/dockerfiles/debian-bootstrap.pre | 13 +
1 file changed, 13 insertions(+)
diff --git a/tests/docker/dockerfiles/debian-bootstrap
The 'realpath' executable is shipped in a separate package that isn't
installed by default on some distros.
We already use 'readlink -e' (provided by GNU coreutils) in some other
part of the code, so let's settle for that instead.
Signed-off-by: Sascha Silbe
-
ion sort support (introduced in 1997) and neglected to
update it for POSIX.1-2008 compliance [1]?
Guess using "-c" and redirecting stderr to /dev/null is our only option
then. Feel free to fix that up when applying.
Thanks for pointing out these portability issues!
Sascha
[1] http://pubs.
to other languages).
Actually there is a direct equivalent of "?:" (which unfortunately isn't
in C11) in Python: "or". So you can use:
result = self.vm.qmp('blockdev-change-medium',
id=self.device_name or 'drive0', filename=new_img,
format=iotests.imgfmt)
Sascha
--
Softwareentwicklung Sascha Silbe, Niederhofenstraße 5/1, 71229 Leonberg
https://se-silbe.de/
USt-IdNr. DE281696641
Dear Eric,
Sascha Silbe writes:
> result = self.vm.qmp('blockdev-change-medium',
> id=self.device_name or 'drive0',
> filename=new_img,
> format=iotests.imgfmt)
Sorry, my eyes deceived me.
27;
result = self.vm.qmp('blockdev-change-medium', **qmp_args)
FWIW these days I tend to use Python magics (like *args / **kwargs) only
if there's a _significant_ improvement in either functionality or
readability; especially for code bases that are being worked on by
developers
feature to
existing guests.
Reviewed-by: Cornelia Huck
Signed-off-by: Sascha Silbe
---
hw/char/virtio-serial-bus.c | 49 ---
include/hw/compat.h | 6 -
include/hw/virtio/virtio-serial.h | 2 ++
3 files changed, 53 insertions(+), 4 deletion
.c).
FWIW, it's not obvious at first sight that the tests added to
check-qtest-i386-y will also be included in check-qtest-x86_64-y. The
line responsible for that is hiding in the midst of other assignments,
without even a blank line separating it from the rest.
Assigning to a common variable
Dear Thomas,
Thomas Huth writes:
> On 11.10.2016 10:27, Sascha Silbe wrote:
[pxe-test failing during "make check"]
>> There's a race condition in the tests. Both the "i386" and the "x86_64"
>> set of tests are creating and removing the same set
(os_error), (fmt), ## __VA_ARGS__)
(I can prepare a proper patch if you agree with the above.)
Sascha
--
Softwareentwicklung Sascha Silbe, Niederhofenstraße 5/1, 71229 Leonberg
https://se-silbe.de/
USt-IdNr. DE281696641
want to make that promise.
Signed-off-by: Sascha Silbe
---
This came up during review of Halil's patch "block: improve error
handling in raw_open" [1].
[1] mid:1469532873-78542-1-git-send-email-pa...@linux.vnet.ibm.com
"[Qemu-devel] [PATCH v2 1/1] block: improve error han
gt;
> Thanks, that sounds good to me.
Great, sent out as a patch [1].
Sascha
[1] mid:1469558699-23314-1-git-send-email-si...@linux.vnet.ibm.com
"[PATCH] error: error_setg_errno(): errno may be clobbered" by
Sascha Silbe , sent on 2016-07-26.
--
Softwareentwicklung Sascha Silbe, Niederhofenstraße 5/1, 71229 Leonberg
https://se-silbe.de/
USt-IdNr. DE281696641
. error_setg_errno() already takes care of preserving errno
and some functions rely on that, so just promise that we continue to
do so in the future.
Signed-off-by: Sascha Silbe
---
Alternative approach to "error: error_setg_errno(): errno may be
clobbered" [1].
[1] mid:1469558699-23314-
Dear Markus,
Markus Armbruster writes:
> Sascha Silbe writes:
>
>> As a general policy, we want callers to save errno
>> themselves. error_setg_internal() currently goes out of its way to
>> preserve errno,
>
> In other words, "error_setg_errno(): errno may
propagate(), error_setg_file_open(), error_set() preserve
errno. Optionally also the other functions listed in
include/qapi/error.h and include/qemu/error-report.h.
Sascha
--
Softwareentwicklung Sascha Silbe, Niederhofenstraße 5/1, 71229 Leonberg
https://se-silbe.de/
USt-IdNr. DE281696641
1 - 100 of 143 matches
Mail list logo
