[Qemu-devel] [PATCH] Better name usb braille device

2012-08-23 Thread Samuel Thibault
Windows users need to know that they have to use the Baum driver to make the qemu braille device work. Signed-off-by: Samuel Thibault diff --git a/hw/usb/dev-serial.c b/hw/usb/dev-serial.c index 56743ee..20d60ba 100644 --- a/hw/usb/dev-serial.c +++ b/hw/usb/dev-serial.c @@ -113,7 +113,7 @@ enum

Re: [Qemu-devel] Working on IPv6 -net user support

2013-02-26 Thread Samuel Thibault
Jan Kiszka, le Tue 26 Feb 2013 12:40:58 +0100, a écrit : > On 2013-02-26 12:23, Guillaume Subiron wrote: > > I represent a group of french network students in master degree > > working on Qemu. Our tutor is Samuel Thibault. He asked us to come on > > this list. > >

[Qemu-devel] socket,mcast looping back frames -> IPv6 broken

2013-03-05 Thread Samuel Thibault
Hello, The reason why IPv6 does not work when using -net socket,mcast=foo is that since qemu explicitly sets IP_MULTICAST_LOOP to 1, it receives its own frames. When the IPv6 stack performs duplicate addresse detection (DAD) through a multicasted announce, it receives its own announcement, and th

Re: [Qemu-devel] [PER] Re: socket, mcast looping back frames -> IPv6 broken

2013-03-06 Thread Samuel Thibault
Stefan Hajnoczi, le Wed 06 Mar 2013 13:29:37 +0100, a écrit : > On Tue, Mar 05, 2013 at 05:35:10PM +0100, Samuel Thibault wrote: > > The reason why IPv6 does not work when using -net socket,mcast=foo is > > that since qemu explicitly sets IP_MULTICAST_LOOP to 1, it receives its

Re: [Qemu-devel] [PER] Re: socket, mcast looping back frames -> IPv6 broken

2013-03-07 Thread Samuel Thibault
Stefan Hajnoczi, le Thu 07 Mar 2013 10:38:26 +0100, a écrit : > On Wed, Mar 06, 2013 at 02:15:25PM +0100, Samuel Thibault wrote: > > Stefan Hajnoczi, le Wed 06 Mar 2013 13:29:37 +0100, a écrit : > > > On Tue, Mar 05, 2013 at 05:35:10PM +0100, Samuel Thibault wrote: > > >

Re: [Qemu-devel] [PER] Re: socket, mcast looping back frames -> IPv6 broken

2013-03-08 Thread Samuel Thibault
Stefan Hajnoczi, le Fri 08 Mar 2013 09:43:18 +0100, a écrit : > On Thu, Mar 07, 2013 at 06:14:28PM +0100, Samuel Thibault wrote: > > Stefan Hajnoczi, le Thu 07 Mar 2013 10:38:26 +0100, a écrit : > > > On Wed, Mar 06, 2013 at 02:15:25PM +0100, Samuel Thibault wrote: > > >

Re: [Qemu-devel] [PER] Re: socket, mcast looping back frames -> IPv6 broken

2013-03-08 Thread Samuel Thibault
Samuel Thibault, le Fri 08 Mar 2013 10:08:55 +0100, a écrit : > There does exist some unique address, which is returned by recvfrom, > I'll have a look at how to get access to it. Ah, no, it's not unique... It's just the host IP address and the same port as the multicast add

Re: [Qemu-devel] [PER] Re: socket, mcast looping back frames -> IPv6 broken

2013-03-10 Thread Samuel Thibault
Stefan Hajnoczi, le Wed 06 Mar 2013 13:29:37 +0100, a écrit : > > What do people think about it? > > We should fix the layer that introduces the problem. Therefore I think > the fix needs to be net/socket.c. > > Unfortunately net/socket.c does not have the concept of a link-layer > address, so w

[Qemu-devel] [PATCH] slirp: goto bad in udp_input if sosendto fails

2014-06-11 Thread Samuel Thibault
Before this patch, if sosendto fails, udp_input is executed as if the packet was sent. This could cause memory leak. This patch adds a goto bad to cut the execution of this function. Signed-off-by: Guillaume Subiron --- slirp/udp.c | 1 + 1 file changed, 1 insertion(+) diff --git a/slirp/udp.c

Re: [Qemu-devel] [PATCH] slirp: goto bad in udp_input if sosendto fails

2014-06-14 Thread Samuel Thibault
Jan Kiszka, le Thu 12 Jun 2014 07:47:25 +0200, a écrit : > On 2014-06-11 10:55, Samuel Thibault wrote: > > Before this patch, if sosendto fails, udp_input is executed as if the > > packet was sent. This could cause memory leak. > > Cannot follow yet how this could leak (n

[Qemu-devel] [PATCH, DoS] slirp (arp): do not special-case bogus IP addresses

2014-05-07 Thread Samuel Thibault
Do not special-case addresses with zero host part, as we do not necessarily know how big it is, and the guest can fake them anyway. Signed-off-by: Samuel Thibault --- This is particularly bad actually, one can for instance simply do this inside a Linux guest ip addr add 192.0.0.0/1 dev eth0

Re: [Qemu-devel] [PATCH, DoS] slirp (arp): do not special-case bogus IP addresses

2014-05-07 Thread Samuel Thibault
Edgar E. Iglesias, le Thu 08 May 2014 06:10:18 +, a écrit : > The search part looks OK to me but when adding to the arp table, don't > you at least want to avoid adding mappings for 0.0.0.0/32? I don't see the gain, actually. It would mean burning some CPU all the time just to save a small po

Re: [Qemu-devel] [PATCH, DoS] slirp (arp): do not special-case bogus IP addresses

2014-05-13 Thread Samuel Thibault
Edgar E. Iglesias, le Thu 08 May 2014 06:59:22 +, a écrit : > On Thu, May 08, 2014 at 08:50:33AM +0200, Samuel Thibault wrote: > > Edgar E. Iglesias, le Thu 08 May 2014 06:10:18 +, a écrit : > > > The search part looks OK to me but when adding to the arp table, don&#x

Re: [Qemu-devel] [PATCH, DoS] slirp (arp): do not special-case bogus IP addresses

2014-05-13 Thread Samuel Thibault
dresses with zero host part, as we do not necessarily know how big it is, and the guest can fake them anyway. Silently avoiding having 0.0.0.0 as a destination, however. Signed-off-by: Samuel Thibault --- diff --git a/slirp/arp_table.c b/slirp/arp_table.c index ecdb0ba..bcaeb44 100644 --- a/slir

Re: [Qemu-devel] [PATCH, DoS] slirp (arp): do not special-case bogus IP addresses

2014-05-13 Thread Samuel Thibault
Edgar E. Iglesias, le Wed 14 May 2014 00:54:50 +, a écrit : > Minor nit, the comment in if_encap should say > "0.0.0.0 can not be a destination address..." D'oh :) Samuel

[Qemu-devel] [PATCHv2, DoS] slirp (arp): do not special-case bogus IP addresses

2014-05-13 Thread Samuel Thibault
Do not special-case addresses with zero host part, as we do not necessarily know how big it is, and the guest can fake them anyway. Silently avoid having 0.0.0.0 as a destination, however. Signed-off-by: Samuel Thibault --- This is particularly bad actually, one can for instance simply do this

[Qemu-devel] MAINTAINERS: please add myself as usb-serial.c and baum.c maintainer

2014-10-22 Thread Samuel Thibault
Hello, I've written mostly all of usb-serial.c and baum.c, and keep maintaining them, since I use them regularly. Samuel

Re: [Qemu-devel] MAINTAINERS: please add myself as usb-serial.c and baum.c maintainer

2014-10-22 Thread Samuel Thibault
Markus Armbruster, le Wed 22 Oct 2014 15:00:20 +0200, a écrit : > Samuel Thibault writes: > > > I've written mostly all of usb-serial.c and baum.c, and keep maintaining > > them, since I use them regularly. > > Please post the obvious patch to MAINTAINERS then :)

Re: [Qemu-devel] [PATCH] MAINTAINERS: add Samuel Thibault as usb-serial.c and baum.c maintainer

2014-10-22 Thread Samuel Thibault
Paolo Bonzini, le Wed 22 Oct 2014 14:54:20 +0200, a écrit : > He wrote "I've written mostly all of usb-serial.c and baum.c, and keep > maintaining them, since I use them regularly." > > Cc: Samuel Thibault > Signed-off-by: Paolo Bonzini Signed-off-by: Samuel T

Re: [Qemu-devel] [PULL 17/28] MAINTAINERS: add Samuel Thibault as usb-serial.c and baum.c maintainer

2014-10-27 Thread Samuel Thibault
Paolo Bonzini, le Mon 27 Oct 2014 16:13:34 +0100, a écrit : > He wrote "I've written mostly all of usb-serial.c and baum.c, and keep > maintaining them, since I use them regularly." > > Cc: Samuel Thibault Signed-off-by: Samuel Thibault > Signed-off-by: Paolo

[Qemu-devel] [PATCH, braille]: Error out if the real braille device is not connected

2014-09-07 Thread Samuel Thibault
message to the user to understand what is happening. This change makes qemu refuse to configure the character device in such case, and let the user know what to fix. Signed-off-by: Samuel Thibault diff --git a/backends/baum.c b/backends/baum.c index 759003f..f5fcdaa 100644 --- a/backends/baum.c

Re: [Qemu-devel] ipv6 slirp network

2014-07-21 Thread Samuel Thibault
Hello, Vasiliy Tolstov, le Mon 21 Jul 2014 15:34:16 +0400, a écrit : > Hello. I have now slirp qemu network with ipv4 address, but for tests > i need also ipv6 addresses in slirp network. How can i provide this > args for qemu via libvirt or (best) via qemu args? > I found some commits about ipv6

Re: [Qemu-devel] ipv6 slirp network

2014-07-21 Thread Samuel Thibault
Vasiliy Tolstov, le Mon 21 Jul 2014 15:42:54 +0400, a écrit : > 2014-07-21 15:41 GMT+04:00 Samuel Thibault : > > ? The support was submitted to the list, but not commited. > > You can find the patches on > > http://lists.gnu.org/archive/html/qemu-devel/2014-03/msg057

Re: [Qemu-devel] ipv6 slirp network

2014-07-21 Thread Samuel Thibault
Vasiliy Tolstov, le Mon 21 Jul 2014 15:59:53 +0400, a écrit : > Does it possible to get this patches via git branch or by another way? > As i see i can't get it via email because of html contents =( I have pushed it to http://dept-info.labri.fr/~thibault/qemu-ipv6 , in the tosubmit branch. Samuel

Re: [Qemu-devel] ipv6 slirp network

2014-07-21 Thread Samuel Thibault
Vasiliy Tolstov, le Mon 21 Jul 2014 18:19:17 +0400, a écrit : > 2014-07-21 16:06 GMT+04:00 Samuel Thibault : > > I have pushed it to http://dept-info.labri.fr/~thibault/qemu-ipv6 , in > > the tosubmit branch. > > > Inside packer (i'm try to build some centos 7 boxes

Re: [Qemu-devel] ipv6 slirp network

2014-07-21 Thread Samuel Thibault
Samuel Thibault, le Mon 21 Jul 2014 16:29:34 +0200, a écrit : > Vasiliy Tolstov, le Mon 21 Jul 2014 18:19:17 +0400, a écrit : > > 2014-07-21 16:06 GMT+04:00 Samuel Thibault : > > > I have pushed it to http://dept-info.labri.fr/~thibault/qemu-ipv6 , in > &g

Re: [Qemu-devel] ipv6 slirp network

2014-07-21 Thread Samuel Thibault
Samuel Thibault, le Mon 21 Jul 2014 16:47:09 +0200, a écrit : > Samuel Thibault, le Mon 21 Jul 2014 16:29:34 +0200, a écrit : > > Vasiliy Tolstov, le Mon 21 Jul 2014 18:19:17 +0400, a écrit : > > > 2014-07-21 16:06 GMT+04:00 Samuel Thibault : > > > > I have pushed i

Re: [Qemu-devel] ipv6 slirp network

2014-07-21 Thread Samuel Thibault
Vasiliy Tolstov, le Mon 21 Jul 2014 18:47:00 +0400, a écrit : > 2014-07-21 18:29 GMT+04:00 Samuel Thibault : > > A gdb backtrace would also be useful. > > Can you provide me info how can i get it from running qemu? As i > understand i need to gdb load-symbol and specify debuging

Re: [Qemu-devel] ipv6 slirp network

2014-07-21 Thread Samuel Thibault
Vasiliy Tolstov, le Mon 21 Jul 2014 23:22:39 +0400, a écrit : > 2014-07-21 18:52 GMT+04:00 Samuel Thibault : > > For instance, yes, but you probably want to try my patch before. > > > Yes, patch fix issue. And now all works fine. Last question - is that > possible to ena

Re: [Qemu-devel] ipv6 slirp network

2014-07-21 Thread Samuel Thibault
Vasiliy Tolstov, le Tue 22 Jul 2014 00:12:23 +0400, a écrit : > 2014-07-21 23:49 GMT+04:00 Samuel Thibault : > > There's no current support for this, but that could be useful to add > > indeed. > > > I hit another issue, but may be not related to the patch. In cent

Re: [Qemu-devel] ipv6 slirp network

2014-07-21 Thread Samuel Thibault
Vasiliy Tolstov, le Tue 22 Jul 2014 00:19:46 +0400, a écrit : > 2014-07-22 0:13 GMT+04:00 Samuel Thibault : > > It is related to the patch. I have fixed it, and pushed a newer > > tosubmit branch. > > Nothing new in tosubmit branch I have regenerated the branch, you need

Re: [Qemu-devel] ipv6 slirp network

2014-07-21 Thread Samuel Thibault
Samuel Thibault, le Mon 21 Jul 2014 22:30:40 +0200, a écrit : > Vasiliy Tolstov, le Tue 22 Jul 2014 00:19:46 +0400, a écrit : > > 2014-07-22 0:13 GMT+04:00 Samuel Thibault : > > > It is related to the patch. I have fixed it, and pushed a newer > > > tosubmit bran

[Qemu-devel] [PATCH, braille] Add dots keypresses support to the baum braille device

2011-08-18 Thread Samuel Thibault
Add dots keypresses support to the baum braille device. Signed-off-by: Samuel Thibault diff --git a/hw/baum.c b/hw/baum.c index 21326ae..131348c 100644 --- a/hw/baum.c +++ b/hw/baum.c @@ -1,7 +1,7 @@ /* * QEMU Baum Braille Device * - * Copyright (c) 2008, 2011 Samuel Thibault + * Copyright

Re: [Qemu-devel] [PATCH, braille] Add dots keypresses support to the baum braille device

2011-08-18 Thread Samuel Thibault
Oops, sorry, the previous patch had a debugging leftover, here it is again. Add dots keypresses support to the baum braille device. Signed-off-by: Samuel Thibault diff --git a/hw/baum.c b/hw/baum.c index 21326ae..0b29498 100644 --- a/hw/baum.c +++ b/hw/baum.c @@ -1,7 +1,7 @@ /* * QEMU Baum

Re: [Qemu-devel] [PATCH, braille] Add dots keypresses support to the baum braille device

2011-08-22 Thread Samuel Thibault
that's the propre one this time :) ) Samuel Add dots keypresses support to the baum braille device Signed-off-by: Samuel Thibault diff --git a/hw/baum.c b/hw/baum.c index 26beeaf..aa0ee55 100644 --- a/hw/baum.c +++ b/hw/baum.c @@ -1,7 +1,7 @@ /* * QEMU Baum Braille Device * - * Copyrigh

[Qemu-devel] [PATCH 02/18] slirp: Generalizing and neutralizing code before adding IPv6 stuff

2014-03-30 Thread Samuel Thibault
to prepare for the IPv6 case. Some code is factorized. Some #define ETH_* are moved upper in slirp.h to make them accessible to other slirp/*.h Signed-off-by: Guillaume Subiron Signed-off-by: Samuel Thibault --- slirp/if.c| 2 +- slirp/mbuf.c | 2 +- slirp/mbuf.h | 2 +- slirp/slir

[Qemu-devel] [PATCH 01/18] slirp: goto bad in udp_input if sosendto fails

2014-03-30 Thread Samuel Thibault
Before this patch, if sosendto fails, udp_input is executed as if the packet was sent. This could cause memory leak. This patch adds a goto bad to cut the execution of this function. Signed-off-by: Guillaume Subiron --- slirp/udp.c | 1 + 1 file changed, 1 insertion(+) diff --git a/slirp/udp.c

[Qemu-devel] [PATCH 18/18] qapi-schema, qemu-options & slirp: Adding Qemu options for IPv6 addresses

2014-03-30 Thread Samuel Thibault
-by: Samuel Thibault --- net/net.c| 30 ++ net/slirp.c | 46 -- qapi-schema.json | 40 ++-- qemu-options.hx | 18 -- slirp/libslirp.h | 8 +--- slirp/slirp.c

[Qemu-devel] [PATCH 09/18] qemu/timer.h : Adding function to second scale

2014-03-30 Thread Samuel Thibault
This patch adds SCALE_S, timer_new_s(), and qemu_clock_get_s in qemu/timer.h to manage second-scale timers. Signed-off-by: Guillaume Subiron Signed-off-by: Samuel Thibault --- include/qemu/timer.h | 32 1 file changed, 32 insertions(+) diff --git a/include

[Qemu-devel] [PATCH 05/18] slirp: Factorizing address translation

2014-03-30 Thread Samuel Thibault
This patch factorizes some duplicate code into a new function, sotranslate_out(). This function perform the address translation when a packet is transmitted to the host network. If the paquet is destinated to the host, the loopback address is used, and if the paquet is destinated to the virtual DNS

[Qemu-devel] [PATCH 04/18] slirp: Make Socket structure IPv6 compatible

2014-03-30 Thread Samuel Thibault
This patch replaces foreign and local address/port couples in Socket structure by 2 sockaddr_storage which can be casted in sockaddr_in or sockaddr_in6. Direct access to address and port is still possible thanks to some \#define, so retrocompatibility of the existing code is assured. The ss_family

[Qemu-devel] [PATCH 03/18] slirp: Reindent after refactoring

2014-03-30 Thread Samuel Thibault
No code change. Signed-off-by: Guillaume Subiron Signed-off-by: Samuel Thibault --- slirp/slirp.c | 107 +- 1 file changed, 54 insertions(+), 53 deletions(-) diff --git a/slirp/slirp.c b/slirp/slirp.c index 676c86d..bfc4832 100644 --- a

[Qemu-devel] [PATCH 16/18] slirp: Handle IPv6 in TCP functions

2014-03-30 Thread Samuel Thibault
This patch adds IPv6 case in TCP functions refactored by the last patches. This also adds IPv6 pseudo-header in tcpiphdr structure. Finally, tcp_input() is called by ip6_input(). Signed-off-by: Guillaume Subiron Signed-off-by: Samuel Thibault --- slirp/ip6_input.c | 4 ++-- slirp/tcp.h

[Qemu-devel] [PATCH 14/18] slirp: Generalizing and neutralizing various TCP functions before adding IPv6 stuff

2014-03-30 Thread Samuel Thibault
Basically, this patch adds some switch in various TCP functions to prepare them for the IPv6 case. To have something to "switch" in tcp_input() and tcp_respond(), a new argument is used to give them the sa_family of the addresses they are working on. Signed-off-by: Guillaume Subiron --- slirp/i

[Qemu-devel] [PATCH 07/18] slirp: Make udp_attach IPv6 compatible

2014-03-30 Thread Samuel Thibault
A sa_family_t is now passed in argument to udp_attach instead of using a hardcoded "AF_INET" to call qemu_socket(). Signed-off-by: Guillaume Subiron --- slirp/ip_icmp.c | 2 +- slirp/udp.c | 7 --- slirp/udp.h | 2 +- 3 files changed, 6 insertions(+), 5 deletions(-) diff --git a/sli

[Qemu-devel] [PATCH 12/18] slirp: Adding IPv6 UDP support

2014-03-30 Thread Samuel Thibault
This patch adds udp6_input() and udp6_output(). It also adds the IPv6 case in sorecvfrom(). Finally, udp_input() is called by ip6_input(). Signed-off-by: Guillaume Subiron --- slirp/Makefile.objs | 2 +- slirp/ip6_input.c | 3 +- slirp/socket.c | 7 ++- slirp/udp.h | 5 ++

[Qemu-devel] [PATCH 08/18] slirp: Adding family argument to tcp_fconnect()

2014-03-30 Thread Samuel Thibault
This patch simply adds a sa_family_t argument to remove the hardcoded "AF_INET" in the call of qemu_socket(). Signed-off-by: Guillaume Subiron --- slirp/slirp.h | 2 +- slirp/tcp_input.c | 3 ++- slirp/tcp_subr.c | 5 +++-- 3 files changed, 6 insertions(+), 4 deletions(-) diff --git a/slir

[Qemu-devel] [PATCH 15/18] slirp: Reindent after refactoring

2014-03-30 Thread Samuel Thibault
No code change. Signed-off-by: Guillaume Subiron Signed-off-by: Samuel Thibault --- slirp/slirp.h | 3 +- slirp/tcp_input.c | 95 +++--- slirp/tcp_output.c | 29 - slirp/tcp_subr.c | 50 ++-- 4

[Qemu-devel] [PATCHv4 00/18] slirp: Adding IPv6 support to Qemu -net user mode

2014-03-30 Thread Samuel Thibault
Hello, This is another respin of IPv6 in Qemu -net user mode. These patches add ICMPv6, NDP, and make UDP and TCP compatible with IPv6. We have made some refactoring to make current code compatible with IPv6. Patches 1 to 8 are refactoring of existing code and do not change the behavior, 9 adds

[Qemu-devel] [PATCH 10/18] slirp: Adding IPv6, ICMPv6 Echo and NDP autoconfiguration

2014-03-30 Thread Samuel Thibault
adds ip6_cksum() to compute ICMPv6 checksums using IPv6 pseudo-header. Signed-off-by: Guillaume Subiron Signed-off-by: Samuel Thibault --- slirp/Makefile.objs | 4 +- slirp/cksum.c | 23 slirp/ip6.h | 139 + slirp/ip6_icmp.c| 349

[Qemu-devel] [PATCH 11/18] slirp: Adding ICMPv6 error sending

2014-03-30 Thread Samuel Thibault
Disambiguation : icmp_error is renamed into icmp_send_error, since it doesn't manage errors, but only sends ICMP Error messages. Adding icmp6_send_error to send ICMPv6 Error messages. This function is simpler than the v4 version. Adding some calls in various functions to send ICMP errors, when a r

[Qemu-devel] [PATCH 06/18] slirp: Factorizing and cleaning solookup()

2014-03-30 Thread Samuel Thibault
This patch makes solookup() compatible with varying address families. Also, this function was only compatible with TCP. Having the socket list in argument, it is now compatible with UDP too. Finally, some optimization code is factorized inside the function (the function look at the last returned re

[Qemu-devel] [PATCH 13/18] slirp: Factorizing tcpiphdr structure with an union

2014-03-30 Thread Samuel Thibault
compatible with the new tcpiphdr structure, whose size will be bigger than sizeof(struct tcphdr) + sizeof(struct ip) Signed-off-by: Guillaume Subiron Signed-off-by: Samuel Thibault --- slirp/if.h | 4 ++-- slirp/mbuf.c | 3 ++- slirp/slirp.c | 15 --- slirp/socket.c

[Qemu-devel] [PATCH 17/18] slirp: Adding IPv6 address for DNS relay

2014-03-30 Thread Samuel Thibault
This patch adds an IPv6 address to the DNS relay. in6_equal_dns() is developed using this Slirp attribute. sotranslate_in/out() are also updated to manage the IPv6 case so the guest can be able to join the host using one of the Slirp addresses. Signed-off-by: Guillaume Subiron --- slirp/ip6.h

Re: [Qemu-devel] [PATCHv3 00/16] slirp: Adding IPv6 support to Qemu -net user mode

2014-04-04 Thread Samuel Thibault
Hello, Samuel Thibault, le Thu 20 Mar 2014 10:03:20 +0100, a écrit : > Stefan Hajnoczi, le Thu 20 Mar 2014 08:58:11 +0100, a écrit : > > My suggestion is to split all the preparation and cleanups into a > > smaller patch series that can be applied easily. > > > >

[Qemu-devel] [PATCH 07/16] slirp: Factorizing address translation

2014-02-11 Thread Samuel Thibault
This patch factorizes some duplicate code into a new function, sotranslate_out(). This function perform the address translation when a packet is transmitted to the host network. If the paquet is destinated to the host, the loopback address is used, and if the paquet is destinated to the virtual DNS

[Qemu-devel] [PATCH 03/16] qemu/timer.h : Adding function to second scale

2014-02-11 Thread Samuel Thibault
This patch adds SCALE_S, timer_new_s(), and qemu_clock_get_s in qemu/timer.h to manage second-scale timers. Signed-off-by: Guillaume Subiron Signed-off-by: Samuel Thibault --- include/qemu/timer.h | 32 1 file changed, 32 insertions(+) diff --git a/include

[Qemu-devel] [PATCH 04/16] slirp: Adding IPv6, ICMPv6 Echo and NDP autoconfiguration

2014-02-11 Thread Samuel Thibault
adds ip6_cksum() to compute ICMPv6 checksums using IPv6 pseudo-header. Signed-off-by: Guillaume Subiron Signed-off-by: Samuel Thibault --- slirp/Makefile.objs | 4 +- slirp/cksum.c | 23 slirp/ip6.h | 139 + slirp/ip6_icmp.c| 349

[Qemu-devel] [PATCH 02/16] slirp: Generalizing and neutralizing code before adding IPv6 stuff

2014-02-11 Thread Samuel Thibault
to prepare for the IPv6 case. Some code is factorized. Some #define ETH_* are moved upper in slirp.h to make them accessible to other slirp/*.h Signed-off-by: Guillaume Subiron Signed-off-by: Samuel Thibault --- slirp/if.c| 2 +- slirp/mbuf.c | 2 +- sli

[Qemu-devel] [PATCH 05/16] slirp: Adding ICMPv6 error sending

2014-02-11 Thread Samuel Thibault
Disambiguation : icmp_error is renamed into icmp_send_error, since it doesn't manage errors, but only sends ICMP Error messages. Adding icmp6_send_error to send ICMPv6 Error messages. This function is simpler than the v4 version. Adding some calls in various functions to send ICMP errors, when a r

[Qemu-devel] [PATCHv3 00/16] slirp: Adding IPv6 support to Qemu -net user mode

2014-02-11 Thread Samuel Thibault
Hello, This is a respin of IPv6 in Qemu -net user mode. These patches add ICMPv6, NDP, and make UDP and TCP compatible with IPv6. We have made some refactoring to make current code compatible with IPv6. Some patches, like 2 and 13, can be reviewed using "interdiff -w /dev/null patchfile" to get

[Qemu-devel] [PATCH 11/16] slirp: Adding family argument to tcp_fconnect()

2014-02-11 Thread Samuel Thibault
This patch simply adds a sa_family_t argument to remove the hardcoded "AF_INET" in the call of qemu_socket(). Signed-off-by: Guillaume Subiron --- slirp/slirp.h | 2 +- slirp/tcp_input.c | 3 ++- slirp/tcp_subr.c | 5 +++-- 3 files changed, 6 insertions(+), 4 deletions(-) diff --git a/slir

[Qemu-devel] [PATCH 14/16] slirp: Handle IPv6 in TCP functions

2014-02-11 Thread Samuel Thibault
This patch adds IPv6 case in TCP functions refactored by the last patches. This also adds IPv6 pseudo-header in tcpiphdr structure. Finally, tcp_input() is called by ip6_input(). Signed-off-by: Guillaume Subiron Signed-off-by: Samuel Thibault --- slirp/ip6_input.c | 4 ++-- slirp/tcp.h

[Qemu-devel] [PATCH 08/16] slirp: Factorizing and cleaning solookup()

2014-02-11 Thread Samuel Thibault
This patch makes solookup() compatible with all address family. Also, this function was only compatible with TCP. Having the socket list in argument, it is now compatible with UDP too. Finally, some optimization code is factorized inside the function (the function look at the last returned result b

[Qemu-devel] [PATCH 13/16] slirp: Generalizing and neutralizing various TCP functions before adding IPv6 stuff

2014-02-11 Thread Samuel Thibault
Basically, this patch adds some switch in various TCP functions to prepare them for the IPv6 case. To have something to "switch" in tcp_input() and tcp_respond(), a new argument is used to give them the sa_family of the addresses they are working on. Signed-off-by: Guillaume Subiron --- slirp/i

[Qemu-devel] [PATCH 15/16] slirp: Adding IPv6 address for DNS relay

2014-02-11 Thread Samuel Thibault
This patch adds an IPv6 address to the DNS relay. in6_equal_dns() is developed using this Slirp attribute. sotranslate_in/out() are also updated to manage the IPv6 case so the guest can be able to join the host using one of the Slirp addresses. Signed-off-by: Guillaume Subiron --- slirp/ip6.h

[Qemu-devel] [PATCH 12/16] slirp: Factorizing tcpiphdr structure with an union

2014-02-11 Thread Samuel Thibault
compatible with the new tcpiphdr structure, whose size will be bigger than sizeof(struct tcphdr) + sizeof(struct ip) Signed-off-by: Guillaume Subiron Signed-off-by: Samuel Thibault --- slirp/if.h | 4 ++-- slirp/mbuf.c | 3 ++- slirp/slirp.c | 15 --- slirp/socket.c

[Qemu-devel] [PATCH 16/16] qapi-schema, qemu-options & slirp: Adding Qemu options for IPv6 addresses

2014-02-11 Thread Samuel Thibault
-by: Samuel Thibault --- net/net.c| 30 ++ net/slirp.c | 46 -- qapi-schema.json | 40 ++-- qemu-options.hx | 18 -- slirp/libslirp.h | 8 +--- slirp

[Qemu-devel] [PATCH 06/16] slirp: Make Socket structure IPv6 compatible

2014-02-11 Thread Samuel Thibault
This patch replaces foreign and local address/port couples in Socket structure by 2 sockaddr_storage which can be casted in sockaddr_in or sockaddr_in6. Direct access to address and port is still possible thanks to some \#define, so retrocompatibility of the existing code is assured. The ss_family

[Qemu-devel] [PATCH 01/16] slirp: goto bad in udp_input if sosendto fails

2014-02-11 Thread Samuel Thibault
Before this patch, if sosendto fails, udp_input is executed as if the packet was sent. This could cause memory leak. This patch adds a goto bad to cut the execution of this function. Signed-off-by: Guillaume Subiron --- slirp/udp.c | 1 + 1 file changed, 1 insertion(+) diff --git a/slirp/udp.c

[Qemu-devel] [PATCH 09/16] slirp: Make udp_attach IPv6 compatible

2014-02-11 Thread Samuel Thibault
A sa_family_t is now passed in argument to udp_attach instead of using a hardcoded "AF_INET" to call qemu_socket(). Signed-off-by: Guillaume Subiron --- slirp/ip_icmp.c | 2 +- slirp/udp.c | 7 --- slirp/udp.h | 2 +- 3 files changed, 6 insertions(+), 5 deletions(-) diff --git a/sli

[Qemu-devel] [PATCH 10/16] slirp: Adding IPv6 UDP support

2014-02-11 Thread Samuel Thibault
This patch adds udp6_input() and udp6_output(). It also adds the IPv6 case in sorecvfrom(). Finally, udp_input() is called by ip6_input(). Signed-off-by: Guillaume Subiron --- slirp/Makefile.objs | 2 +- slirp/ip6_input.c | 3 +- slirp/socket.c | 7 ++- slirp/udp.h | 5 ++

Re: [Qemu-devel] [PATCHv3 00/16] slirp: Adding IPv6 support to Qemu -net user mode

2014-02-11 Thread Samuel Thibault
Eric Blake, le Tue 11 Feb 2014 06:50:54 -0700, a écrit : > On 02/11/2014 06:08 AM, Samuel Thibault wrote: > > This is a respin of IPv6 in Qemu -net user mode. > > When sending a new revision of a long series, it's easier if it appears > as a new top-level thread, ins

Re: [Qemu-devel] Keyboard interrupt routing from QEMU to guest OS

2013-12-08 Thread Samuel Thibault
Maryyam Muhammad Din, le Mon 09 Dec 2013 12:25:23 +0500, a écrit : > I am unable to figure-out when someone presses control-c on the keyboard, > how host OS routes it to QEMU and how QEMU then > routes it to the guest?  It depends which QEMU UI you are using. > Please suggest me how can I extract

Re: [Qemu-devel] Keyboard interrupt routing from QEMU to guest OS

2013-12-09 Thread Samuel Thibault
Maryyam Muhammad Din, le Mon 09 Dec 2013 12:44:20 +0500, a écrit : > I have gone through the source code of QEMU but could not figure out how > external interrupts are handled by QEMU for guest. They aren't. It's the UI that manages keyboard etc. So it depends on the UI you are using. Unless you t

[Qemu-devel] [PATCH 06/16] slirp: Make Socket structure IPv6 compatible

2013-11-17 Thread Samuel Thibault
This patch replaces foreign and local address/port couples in Socket structure by 2 sockaddr_storage which can be casted in sockaddr_in or sockaddr_in6. Direct access to address and port is still possible thanks to some \#define, so retrocompatibility of the existing code is assured. The ss_family

[Qemu-devel] [PATCH 09/16] slirp: Make udp_attach IPv6 compatible

2013-11-17 Thread Samuel Thibault
A sa_family_t is now passed in argument to udp_attach instead of using a hardcoded "AF_INET" to call qemu_socket(). Signed-off-by: Guillaume Subiron --- slirp/ip_icmp.c | 2 +- slirp/udp.c | 7 --- slirp/udp.h | 2 +- 3 files changed, 6 insertions(+), 5 deletions(-) diff --git a/sli

[Qemu-devel] [PATCH 03/16] qemu/timer.h : Adding function to second scale

2013-11-17 Thread Samuel Thibault
This patch adds SCALE_S, timer_new_s(), and qemu_clock_get_s in qemu/timer.h to manage second-scale timers. Signed-off-by: Guillaume Subiron Signed-off-by: Samuel Thibault --- include/qemu/timer.h | 32 1 file changed, 32 insertions(+) diff --git a/include

[Qemu-devel] [PATCH 02/16] slirp: Generalizing and neutralizing code before adding IPv6 stuff

2013-11-17 Thread Samuel Thibault
to prepare for the IPv6 case. Some code is factorized. Some #define ETH_* are moved upper in slirp.h to make them accessible to other slirp/*.h Signed-off-by: Guillaume Subiron Signed-off-by: Samuel Thibault --- slirp/if.c| 2 +- slirp/mbuf.c | 2 +- sli

[Qemu-devel] [PATCH 04/16] slirp: Adding IPv6, ICMPv6 Echo and NDP autoconfiguration

2013-11-17 Thread Samuel Thibault
adds ip6_cksum() to compute ICMPv6 checksums using IPv6 pseudo-header. Signed-off-by: Guillaume Subiron Signed-off-by: Samuel Thibault --- slirp/Makefile.objs | 4 +- slirp/cksum.c | 23 slirp/ip6.h | 139 + slirp/ip6_icmp.c| 349

[Qemu-devel] [PATCH 08/16] slirp: Factorizing and cleaning solookup()

2013-11-17 Thread Samuel Thibault
This patch makes solookup() compatible with all address family. Also, this function was only compatible with TCP. Having the socket list in argument, it is now compatible with UDP too. Finally, some optimization code is factorized inside the function (the function look at the last returned result b

[Qemu-devel] [PATCH 11/16] slirp: Adding family argument to tcp_fconnect()

2013-11-17 Thread Samuel Thibault
This patch simply adds a sa_family_t argument to remove the hardcoded "AF_INET" in the call of qemu_socket(). Signed-off-by: Guillaume Subiron --- slirp/slirp.h | 2 +- slirp/tcp_input.c | 3 ++- slirp/tcp_subr.c | 5 +++-- 3 files changed, 6 insertions(+), 4 deletions(-) diff --git a/slir

[Qemu-devel] [PATCH 01/16] slirp: goto bad in udp_input if sosendto fails

2013-11-17 Thread Samuel Thibault
Before this patch, if sosendto fails, udp_input is executed as if the packet was sent. This could cause memory leak. This patch adds a goto bad to cut the execution of this function. Signed-off-by: Guillaume Subiron --- slirp/udp.c | 1 + 1 file changed, 1 insertion(+) diff --git a/slirp/udp.c

[Qemu-devel] [PATCH 14/16] slirp: Handle IPv6 in TCP functions

2013-11-17 Thread Samuel Thibault
This patch adds IPv6 case in TCP functions refactored by the last patches. This also adds IPv6 pseudo-header in tcpiphdr structure. Finally, tcp_input() is called by ip6_input(). Signed-off-by: Guillaume Subiron Signed-off-by: Samuel Thibault --- slirp/ip6_input.c | 4 ++-- slirp/tcp.h

[Qemu-devel] [PATCH 10/16] slirp: Adding IPv6 UDP support

2013-11-17 Thread Samuel Thibault
This patch adds udp6_input() and udp6_output(). It also adds the IPv6 case in sorecvfrom(). Finally, udp_input() is called by ip6_input(). Signed-off-by: Guillaume Subiron --- slirp/Makefile.objs | 2 +- slirp/ip6_input.c | 3 +- slirp/socket.c | 7 ++- slirp/udp.h | 5 ++

[Qemu-devel] [PATCH 05/16] slirp: Adding ICMPv6 error sending

2013-11-17 Thread Samuel Thibault
Disambiguation : icmp_error is renamed into icmp_send_error, since it doesn't manage errors, but only sends ICMP Error messages. Adding icmp6_send_error to send ICMPv6 Error messages. This function is simpler than the v4 version. Adding some calls in various functions to send ICMP errors, when a r

[Qemu-devel] [PATCH 07/16] slirp: Factorizing address translation

2013-11-17 Thread Samuel Thibault
This patch factorizes some duplicate code into a new function, sotranslate_out(). This function perform the address translation when a packet is transmitted to the host network. If the paquet is destinated to the host, the loopback address is used, and if the paquet is destinated to the virtual DNS

[Qemu-devel] [PATCH 16/16] qapi-schema, qemu-options & slirp: Adding Qemu options for IPv6 addresses

2013-11-17 Thread Samuel Thibault
-by: Samuel Thibault --- net/net.c| 30 ++ net/slirp.c | 46 -- qapi-schema.json | 40 ++-- qemu-options.hx | 18 -- slirp/libslirp.h | 8 +--- slirp

[Qemu-devel] [PATCH 15/16] slirp: Adding IPv6 address for DNS relay

2013-11-17 Thread Samuel Thibault
This patch adds an IPv6 address to the DNS relay. in6_equal_dns() is developed using this Slirp attribute. sotranslate_in/out() are also updated to manage the IPv6 case so the guest can be able to join the host using one of the Slirp addresses. Signed-off-by: Guillaume Subiron --- slirp/ip6.h

[Qemu-devel] [PATCH 13/16] slirp: Generalizing and neutralizing various TCP functions before adding IPv6 stuff

2013-11-17 Thread Samuel Thibault
Basically, this patch adds some switch in various TCP functions to prepare them for the IPv6 case. To have something to "switch" in tcp_input() and tcp_respond(), a new argument is used to give them the sa_family of the addresses they are working on. Signed-off-by: Guillaume Subiron --- slirp/i

[Qemu-devel] [PATCH 12/16] slirp: Factorizing tcpiphdr structure with an union

2013-11-17 Thread Samuel Thibault
compatible with the new tcpiphdr structure, whose size will be bigger than sizeof(struct tcphdr) + sizeof(struct ip) Signed-off-by: Guillaume Subiron Signed-off-by: Samuel Thibault --- slirp/if.h | 4 ++-- slirp/mbuf.c | 3 ++- slirp/slirp.c | 15 --- slirp/socket.c

[Qemu-devel] [PATCHv2 00/16] slirp: Adding IPv6 support to Qemu -net user mode

2013-11-17 Thread Samuel Thibault
Hello, This is a respin of IPv6 in Qemu -net user mode. These patches add ICMPv6, NDP, and make UDP and TCP compatible with IPv6. We have made some refactoring to make current code compatible with IPv6. Some patches, like 2 and 13, can be reviewed using "interdiff -w /dev/null patchfile" to get

[Qemu-devel] [PATCH 00/16] slirp: Adding IPv6 support to Qemu -net user mode

2013-10-20 Thread Samuel Thibault
We have developed IPv6 in Qemu -net user mode. These patches add ICMPv6, NDP, and make UDP and TCP compatible with IPv6. We have made some refactoring to make current code compatible with IPv6. Some patches, like 2 and 13, can be reviewed using "interdiff -w /dev/null patchfile" to get rid o

[Qemu-devel] [PATCH 03/16] qemu/timer.h : Adding function to second scale

2013-10-20 Thread Samuel Thibault
This patch adds SCALE_S, timer_new_s(), and qemu_clock_get_s in qemu/timer.h to manage second-scale timers. Signed-off-by: Guillaume Subiron Signed-off-by: Samuel Thibault --- include/qemu/timer.h | 32 1 file changed, 32 insertions(+) diff --git a/include

[Qemu-devel] [PATCH 15/16] slirp: Adding IPv6 address for DNS relay

2013-10-20 Thread Samuel Thibault
This patch adds an IPv6 address to the DNS relay. in6_equal_dns() is developed using this Slirp attribute. sotranslate_in/out() are also updated to manage the IPv6 case so the guest can be able to join the host using one of the Slirp addresses. Signed-off-by: Guillaume Subiron --- slirp/ip6.h

[Qemu-devel] [PATCH 11/16] slirp: Adding family argument to tcp_fconnect()

2013-10-20 Thread Samuel Thibault
This patch simply adds a sa_family_t argument to remove the hardcoded "AF_INET" in the call of qemu_socket(). Signed-off-by: Guillaume Subiron --- slirp/slirp.h | 2 +- slirp/tcp_input.c | 3 ++- slirp/tcp_subr.c | 5 +++-- 3 files changed, 6 insertions(+), 4 deletions(-) diff --git a/slir

[Qemu-devel] [PATCH 01/16] slirp: goto bad in udp_input if sosendto fails

2013-10-20 Thread Samuel Thibault
Before this patch, if sosendto fails, udp_input is executed as if the packet was sent. This could cause memory leak. This patch adds a goto bad to cut the execution of this function. Signed-off-by: Guillaume Subiron --- slirp/udp.c | 1 + 1 file changed, 1 insertion(+) diff --git a/slirp/udp.c

[Qemu-devel] [PATCH 08/16] slirp: Factorizing and cleaning solookup()

2013-10-20 Thread Samuel Thibault
This patch makes solookup() compatible with all address family. Also, this function was only compatible with TCP. Having the socket list in argument, it is now compatible with UDP too. Finally, some optimization code is factorized inside the function (the function look at the last returned result b

[Qemu-devel] [PATCH 05/16] slirp: Adding ICMPv6 error sending

2013-10-20 Thread Samuel Thibault
Disambiguation : icmp_error is renamed into icmp_send_error, since it doesn't manage errors, but only sends ICMP Error messages. Adding icmp6_send_error to send ICMPv6 Error messages. This function is simpler than the v4 version. Adding some calls in various functions to send ICMP errors, when a r

[Qemu-devel] [PATCH 09/16] slirp: Make udp_attach IPv6 compatible

2013-10-20 Thread Samuel Thibault
A sa_family_t is now passed in argument to udp_attach instead of using a hardcoded "AF_INET" to call qemu_socket(). Signed-off-by: Guillaume Subiron --- slirp/ip_icmp.c | 2 +- slirp/udp.c | 7 --- slirp/udp.h | 2 +- 3 files changed, 6 insertions(+), 5 deletions(-) diff --git a/sli

  1   2   3   4   5   6   7   8   9   10   >