Re: [Qemu-devel] [RFC PATCH v3 1/5] coccinelle: add a script to optimize tcg op using tcg_gen_extract()

2017-05-11 Thread SF Markus Elfring via Qemu-devel
> create mode 100644 scripts/coccinelle/tcg_gen_extract.cocci Will an other subdirectory be more appropriate for this SmPL script? > +// Coccinelle helpful issue: > +// https://github.com/coccinelle/coccinelle/issues/86 I am curious if such an information source will trigger further software e

Re: [Qemu-devel] [RFC PATCH v3 1/5] coccinelle: add a script to optimize tcg op using tcg_gen_extract()

2017-05-12 Thread SF Markus Elfring via Qemu-devel
> Even for 6 functions, I would suggest to write out the function names in > the pattern matching code rather than using regular expressions. If the > names are explicit, then Coccinelle can do some filtering, either based on > an index made with idutils or glimpse (see the coccinelle scripts > di

Re: [Qemu-devel] [RFC PATCH v3 1/5] coccinelle: add a script to optimize tcg op using tcg_gen_extract()

2017-05-12 Thread SF Markus Elfring via Qemu-devel
> +print " candidate", "IS" if is_optimizable else "is NOT", > "optimizable" I suggest to increase your software development attention also for another detail here. This information display is using the channel “sys.stdout”. How do you think about to use the function “sys.stderr.write”