On Wed, Sep 16, 2020 at 04:11:31AM -0400, Paolo Bonzini wrote:
> Because the target/i386/hvf/meson.build rule culls hvf support
> on non-Darwin systems, a --enable-hvf build is succeeding.
> To fix this, just try the compilation test every time someone
> passes --enable-hvf.
>
> Reported-by: Chris
On Wed, Sep 16, 2020 at 04:11:30AM -0400, Paolo Bonzini wrote:
> While detection of the framework was already there, moving
> the option allows for better error reporting.
>
> Reported-by: Christophe de Dinechin
> Signed-off-by: Paolo Bonzini
> ---
> configure | 17 +++--
>
On Sun, Oct 04, 2020 at 08:04:41PM +0200, Philippe Mathieu-Daudé wrote:
> There is a number of contributions from this domain,
> add its own entry to the gitdm domain map.
>
> Cc: Igor Kononenko
> Cc: Roman Bolshakov
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> One
Thomas, I think the issue is there. SSE/MMX weren't yet added for HVF.
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1759333
Title:
Illegal Instruction with HVF when encountering SSE instructions i
There's a problem for management applications to determine if certain
accelerators available. Generic QMP command should help with that.
Signed-off-by: Roman Bolshakov
---
monitor/qmp-cmds.c | 15 +++
qapi/machine.json | 19 +++
2 files changed, 34 inser
HMP to replace 'info kvm' in future.
Thanks,
Roman
Roman Bolshakov (6):
qapi: Add query-accel command
qapi: Rename KvmInfo to AccelInfo
qapi: Use qmp_query_accel() in qmp_query_kvm()
softmmu: Remove kvm_available()
hmp: Add 'info accel' command
qapi: Deprecate '
There's nothing specific to KVM in the structure. A more generic name
would be more appropriate.
Signed-off-by: Roman Bolshakov
---
monitor/hmp-cmds.c | 4 ++--
monitor/qmp-cmds.c | 8
qapi/machine.json | 18 +-
3 files changed, 15 insertions(+), 15 dele
qmp_query_accel() is generic and can be used instead of open-coding
qmp_query_kvm().
Signed-off-by: Roman Bolshakov
---
monitor/qmp-cmds.c | 7 +--
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/monitor/qmp-cmds.c b/monitor/qmp-cmds.c
index f5d50afa9c..5a5f3a65f4 100644
--- a
(qemu) info accel
hvf support: enabled
(qemu) info accel kvm
kvm support: not compiled
(qemu) info accel tcg
tcg support: disabled
Signed-off-by: Roman Bolshakov
---
hmp-commands-info.hx | 13 +
include/monitor/hmp.h | 1 +
monitor/hmp
The function isn't used anywhere after qmp_query_kvm() has been switched
to invoke qmp_query_accel().
Signed-off-by: Roman Bolshakov
---
include/sysemu/arch_init.h | 1 -
softmmu/arch_init.c| 9 -
2 files changed, 10 deletions(-)
diff --git a/include/sysemu/arch_ini
'query-accel' QMP command should be used instead.
Signed-off-by: Roman Bolshakov
---
qapi/machine.json | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/qapi/machine.json b/qapi/machine.json
index 5648d8d24d..130b0dbebc 100644
--- a/qapi/machine.json
On Mon, Nov 16, 2020 at 10:20:04AM -0600, Eric Blake wrote:
> On 11/16/20 7:10 AM, Roman Bolshakov wrote:
> > There's a problem for management applications to determine if certain
> > accelerators available. Generic QMP command should help with that.
> >
> >
On Tue, Nov 17, 2020 at 09:51:58AM +0100, Markus Armbruster wrote:
> Eduardo Habkost writes:
>
> > On Mon, Nov 16, 2020 at 10:20:04AM -0600, Eric Blake wrote:
> >> On 11/16/20 7:10 AM, Roman Bolshakov wrote:
> >> > There's a problem for managemen
On Wed, Nov 18, 2020 at 02:08:21PM +0100, Markus Armbruster wrote:
> Paolo Bonzini writes:
> > On 18/11/20 09:36, Markus Armbruster wrote:
> >> While figuring this out, I noticed that the TYPE_ACCEL instance we
> >> create doesn't get its parent set. It's therefore not in the QOM
> >> composition
+ b/MAINTAINERS
> @@ -443,7 +443,6 @@ M: Cameron Esfahani
> M: Roman Bolshakov
> W: https://wiki.qemu.org/Features/HVF
> S: Maintained
> -F: accel/stubs/hvf-stub.c
> F: target/i386/hvf/
> F: include/sysemu/hvf.h
>
> --
> 2.26.2
>
Reviewed-by: Roman Bolshakov
Thanks,
Roman
(1 << 3)
> +#define MMU_PAGE_NX (1 << 4)
>
> bool mmu_gva_to_gpa(struct CPUState *cpu, target_ulong gva, uint64_t *gpa);
>
> --
> 2.28.0
>
Reviewed-by: Roman Bolshakov
But I agree with Paolo that eliminating HVF-only definition duplicates
would be helpful.
Thanks,
Roman
> typedef struct x68_segment_selector {
> union {
> uint16_t sel;
> struct {
> -uint16_t rpl:3;
> +uint16_t rpl:2;
> uint16_t ti:1;
> -uint16_t index:12;
> +uint16_t index:13;
> };
&g
On Wed, Nov 18, 2020 at 09:58:37AM +0100, Paolo Bonzini wrote:
> On 16/11/20 21:04, Jessica Clarke wrote:
> > The Requested Privilege Level field is 2 bits, the Table Indicator field
> > is 1 bit and the Index field is the remaining 15 bits, with TI=0 meaning
> > GDT and TI=1 meaning LDT.
> >
> >
ASED2, &cap);
> +if (!(cap & CPU_BASED2_RDTSCP)) {
> +edx &= ~CPUID_EXT2_RDTSCP;
> +}
> hv_vmx_read_capability(HV_VMX_CAP_PROCBASED, &cap);
> if (!(cap & CPU_BASED_TSC_OFFSET)) {
> edx &= ~CPUID_EXT2_RDTSCP;
> --
> 2.28.0
>
Reviewed-by: Roman Bolshakov
Thanks,
Roman
On Thu, Nov 19, 2020 at 03:41:53PM +0100, Claudio Fontana wrote:
> On 11/16/20 2:10 PM, Roman Bolshakov wrote:
> > Management applications have no way to determine if certain accelerator
> > is available. That complicates discovery of non-KVM accelerators.
>
> are we think
> target/i386/hvf/hvf-cpus.h | 8
> target/i386/hvf/x86hvf.c | 2 ++
> target/i386/hvf/x86hvf.h | 1 -
> 6 files changed, 10 insertions(+), 40 deletions(-)
> delete mode 100644 accel/stubs/hvf-stub.c
>
Reviewed-by: Roman Bolshakov
Thanks,
Roman
t; -/* accelerator already implements the CpusAccel interface */
> -cpus_accel->create_vcpu_thread(cpu);
> -} else {
> -g_assert_not_reached();
> -}
> +/* accelerators all implement the CpusAccel interface */
> +g_assert(cpus_accel != NULL && cpus_accel->create_vcpu_thread != NULL);
> +cpus_accel->create_vcpu_thread(cpu);
>
> while (!cpu->created) {
> qemu_cond_wait(&qemu_cpu_cond, &qemu_global_mutex);
> --
> 2.26.2
>
Reviewed-by: Roman Bolshakov
but I still find the condition (if cpus_accel->func) redundant, is it
feasible to drop it?
Regards,
Roman
On Tue, Sep 01, 2020 at 09:21:57AM +0200, Claudio Fontana wrote:
> kvm: uses the generic handler
> qtest: uses the generic handler
> whpx: changed to use the generic handler (identical implementation)
> hax: changed to use the generic handler (identical implementation)
> hvf: changed to use the gen
On Wed, Sep 02, 2020 at 10:17:01AM +0200, Christian Schoenebeck wrote:
> On Dienstag, 1. September 2020 14:45:55 CEST David Cohen wrote:
> > Hi,
> >
> > I'm trying to use qemu on OSX Catalina using HVF hypervisor, but it's
> > currently panic'ing upon booting Linux guest.
> >
> > These are the ar
New meson/make build requires GNU make 3.82+ but macOS ships 3.81 even
on Big Sur while homebrew provides GNU make 4.3 as 'gmake' in $PATH.
With the change, 'make' switches over to gmake implicitly.
Signed-off-by: Roman Bolshakov
---
configure | 22 ++
The set of changes addresses "Diagnose "make is too old" in configure
(or in the makefile?)" from https://wiki.qemu.org/Features/Meson#Easy.
It also provides cleaner backwards compatible build invocation on macOS.
Roman Bolshakov (4):
configure: Use discovered make
configure doesn't detect if $make is installed on the build host.
This is also helpful for hosts where an alias for make is used, i.e.
configure would fail if gmake is not present on macOS.
Signed-off-by: Roman Bolshakov
---
configure | 4
1 file changed, 4 insertions(+)
diff --
A recursive make is inovked if in-source build is used but $(MAKE) is
the same as the one used in the original make invocaton.
Some platforms have preference to use gmake, or a make passed as an
option to "configure". Honor the choice.
Signed-off-by: Roman Bolshakov
---
configure
QEMU build fails with cryptic messages if make is too old:
Makefile.ninja:2655: *** multiple target patterns. Stop.
To avoid the confusion it's worth to fail the build right away and print
a friendly error message.
Signed-off-by: Roman Bolshakov
---
Makefile | 5 +
1 file chang
https://markmail.org/message/5xrxt2w5m42nojkz
Cc: Daniel P. Berrangé
Cc: Cameron Esfahani
Signed-off-by: Roman Bolshakov
---
trace/meson.build | 13 -
1 file changed, 8 insertions(+), 5 deletions(-)
This is an update of the previous patch that is no longer valid due to
conversion of the
On Fri, Aug 21, 2020 at 01:48:02PM -0400, Eduardo Habkost wrote:
> On Fri, Aug 21, 2020 at 01:29:38PM -0400, Eduardo Habkost wrote:
> > On Fri, Aug 21, 2020 at 01:53:52PM +0300, Roman Bolshakov wrote:
> > > On Thu, Aug 20, 2020 at 05:55:29PM -0400, Eduardo Habkost wrote:
>
On Mon, Aug 24, 2020 at 12:45:52PM -0400, Eduardo Habkost wrote:
> On Mon, Aug 24, 2020 at 07:41:34PM +0300, Roman Bolshakov wrote:
> > On Fri, Aug 21, 2020 at 01:48:02PM -0400, Eduardo Habkost wrote:
> > > Signed-off-by: Eduardo Habkost
> > > ---
> > > diff --
On Mon, Aug 24, 2020 at 09:37:07AM -0500, Eric Blake wrote:
> On 8/22/20 4:21 PM, Roman Bolshakov wrote:
> > @@ -38,6 +38,8 @@ then
> > # This file is auto-generated by configure to support in-source tree
> > # 'make' command invocation
> > +include build
On Mon, Aug 24, 2020 at 03:24:31PM +0100, Daniel P. Berrangé wrote:
> On Sun, Aug 23, 2020 at 12:05:47PM +0300, Roman Bolshakov wrote:
> > dtrace on macOS uses unresolved symbols with a special prefix to define
> > probes [1], only headers should be generated for USDT (dtrace(
On Mon, Aug 24, 2020 at 04:57:31PM +0100, Peter Maydell wrote:
> On Mon, 24 Aug 2020 at 15:51, Eric Blake wrote:
> >
> > On 8/22/20 4:21 PM, Roman Bolshakov wrote:
> > > New meson/make build requires GNU make 3.82+ but macOS ships 3.81 even
> > > on Big Sur while
On Tue, Aug 25, 2020 at 01:07:55AM +0300, Roman Bolshakov wrote:
> On Mon, Aug 24, 2020 at 09:37:07AM -0500, Eric Blake wrote:
> > On 8/22/20 4:21 PM, Roman Bolshakov wrote:
> > > @@ -38,6 +38,8 @@ then
> > > # This file is auto-generated by configure to support in-
QEMU build fails with cryptic messages if make is too old:
Makefile.ninja:2655: *** multiple target patterns. Stop.
To avoid the confusion it's worth to fail the build right away and print
a friendly error message.
Reviewed-by: Daniel P. Berrangé
Signed-off-by: Roman Bols
ed configure (Eric B.)
- Added an empty rule for config-host.mak to avoid second call of
recursive make (which happened because of implicit force rule)
Roman Bolshakov (4):
configure: Use discovered make for in-source build
Makefile: Require GNU make 3.82+
configure: Prefer gmake on darw
configure doesn't detect if $make is installed on the build host.
This is also helpful for hosts where an alias for make is used, i.e.
configure would fail if gmake is not present on macOS.
Reviewed-by: Daniel P. Berrangé
Signed-off-by: Roman Bolshakov
---
configure | 4
1 file chang
New meson/make build requires GNU make 3.82+ but macOS ships 3.81 even
on Big Sur while homebrew provides GNU make 4.3 as 'gmake' in $PATH.
With the change, 'make' switches over to gmake implicitly.
Signed-off-by: Roman Bolshakov
---
configure | 26 ++
A recursive make is invoked if in-source build is used but $(MAKE) is
the same as the one used in the original make invocation.
Some platforms have preference to use gmake, or a make passed as an
option to "configure". Honor the choice.
Signed-off-by: Roman Bolshakov
---
con
On Tue, Aug 25, 2020 at 03:19:56PM -0400, Eduardo Habkost wrote:
> git tree for this series:
> https://github.com/ehabkost/qemu-hacks/tree/work/qom-macros-autoconvert
>
Hi Eduardo,
another assert fires during QEMU start:
$ lldb -- $QEMU -cpu nahelem -M q35,accel=hvf -cdrom test.iso
(lldb) targe
On Wed, Aug 26, 2020 at 07:18:15AM -0400, Eduardo Habkost wrote:
> On Wed, Aug 26, 2020 at 01:22:38PM +0300, Roman Bolshakov wrote:
> > On Tue, Aug 25, 2020 at 03:19:56PM -0400, Eduardo Habkost wrote:
> > > git tree for this series:
> > > https://github.com/ehabkost/qemu
On Thu, Jun 11, 2020 at 03:24:31PM +0200, Claudio Fontana wrote:
> On 6/4/20 8:27 PM, Paolo Bonzini wrote:
> > On 28/05/20 21:37, Roman Bolshakov wrote:
> >> There's no similar field in CPUX86State, but it's needed for MMIO traps.
> >>
> >> Signed-
** Changed in: qemu
Status: New => Confirmed
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1840719
Title:
win98se floppy fails to boot with isapc machine
Status in QEMU:
Confirmed
Bug de
The files are generated.
Fixes: 2af282ec51a ("qemu-storage-daemon: Add --monitor option")
Cc: Kevin Wolf
Signed-off-by: Roman Bolshakov
---
.gitignore | 17 +
1 file changed, 9 insertions(+), 8 deletions(-)
diff --git a/.gitignore b/.gitignore
index 0c5af83aa7..
On Fri, Jun 12, 2020 at 03:33:38PM +0200, Paolo Bonzini wrote:
> On 12/06/20 15:09, Peter Maydell wrote:
> > Hi; I'm afraid this fails to build on OSX, and has a check-tcg
> > failure on x86-64 Linux.
> >
> > OSX:
> >
> > In file included from
> > /Users/pm215/src/qemu-for-merges/target/i386/hvf
On Fri, Jun 12, 2020 at 03:33:38PM +0200, Paolo Bonzini wrote:
> On 12/06/20 15:09, Peter Maydell wrote:
> > Hi; I'm afraid this fails to build on OSX, and has a check-tcg
> > failure on x86-64 Linux.
> >
> > OSX:
> >
> > In file included from
> > /Users/pm215/src/qemu-for-merges/target/i386/hvf
.")
Reported-by: Philippe Mathieu-Daudé
Cc: Kevin O'Connor
Signed-off-by: Roman Bolshakov
---
src/hw/timer.c | 13 +
1 file changed, 9 insertions(+), 4 deletions(-)
diff --git a/src/hw/timer.c b/src/hw/timer.c
index 56bb289..2441402 100644
--- a/src/hw/timer.c
+++ b/src/h
The ticket should be closed as soon as SeaBIOS gets updated in QEMU. A patch
has been posted to SeaBIOS mailing list:
https://mail.coreboot.org/hyperkitty/list/seab...@seabios.org/thread/XPKQNLVWZX55TSLSXZVY5S5DMFYS4CNO/
** Changed in: seabios
Assignee: (unassigned) => Roman Bolsha
rtions(+)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index c3bfa132fd6..16ea47a5e6d 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -505,6 +505,7 @@ F: target/arm/hvf/
> X86 HVF CPUs
> M: Cameron Esfahani
> M: Roman Bolshakov
> +R: Phil Dennis-Jordan
> W: https
accelerator.
>
Reviewed-by: Roman Bolshakov
Thanks,
Roman
tly uses the emulated APIC when running on hvf as well.
>
> This change wires up the read & write operations for the MSR VM exits
> and allow-lists the CPUID flag in the x86 hvf runtime.
>
> Signed-off-by: Phil Dennis-Jordan
Reviewed-by: Roman Bolshakov
Hi Phil,
I don
vf accel
> i386/hvf: Fix for UB in handling CPUID function 0xD
> i386/hvf: Fixes startup memory leak (vmcs caps)
> i386/hvf: Raise exception on error setting APICBASE
> i386/hvf: Removes duplicate/shadowed variables in hvf_vcpu_exec
>
To the series,
Reviewed-by: Roman Bol
hift uses uint64_t, where behaviour for the entire
> range of 2..62 is safe and correct.
>
Thanks for correcting the regression.
Reviewed-by: Roman Bolshakov
ated once.
>
Looks good,
Reviewed-by: Roman Bolshakov
Regards,
Roman
On Tue, Nov 05, 2024 at 04:58:00PM +0100, Phil Dennis-Jordan wrote:
> Pointers to the x86 CPU state already exist at the function scope,
> no need to re-obtain them in individual exit reason cases.
>
Reviewed-by: Roman Bolshakov
Regards,
Roman
On 10.12.2024 04:22, Philippe Mathieu-Daudé wrote:
> On 9/12/24 21:36, p...@philjordan.eu wrote:
>> From: Phil Dennis-Jordan
>>
>> This seems to be entirely superfluous and is costly enough to show up in
>
> So the pthread_kill(cpu->thread, SIG_IPI) is entirely superfluous?
>
>> profiling. hv_vcpu
301 - 358 of 358 matches
Mail list logo
