My guess is that RFLAGS.ZF == 1 and one or a few of the checks on VMX controls
have failed. So far I have verified the following checks (26-2 and 26-3 in
Intel SDM Vol. 3C):
* Reserved bits in Pin-based VM execution controls are set according to
associated capabilities MSR
* Reserved bits in Pr
It's not possible to allocate MSR bitmap in userspace because it
requires a physical address to be stored in the VMCS field. However, the
bitmap page is already allocated inside kernel part of
Hypervisor.framework. The 4k bitmap region is aligned to page boundary.
It's worth to continue inspection
During the inspection of Apple reference, I have noticed that Guest CR0 and CR0
Guest/Host Mask has incorrect value. Apple defines that Guest CR0 is writable
only if:
CR0.CD and CR0.NW are unset
But hvf accel code follows Intel SDM "Table 9-1. IA-32 and Intel 64
Processor States Following Power-
On Tue, Jan 25, 2022 at 01:14:27PM +0900, Akihiko Odaki wrote:
> On Tue, Jan 25, 2022 at 8:00 AM Roman Bolshakov wrote:
> >
> > On Mon, Jan 24, 2022 at 08:14:31PM +, Peter Maydell wrote:
> > > On Mon, 24 Jan 2022 at 17:49, Roman Bolshakov wrote:
> > > > I
x27;m not sure if the comment belongs here. Perhaps you mean that bridged
mode is available from 10.15:
VMNET_BRIDGED_MODE API_AVAILABLE(macos(10.15)) = 1002
This means vmnet.framework is supported on all macbooks starting from 2012.
With this fixed,
Tested-by: Roman Bolshakov
Reviewed-by:
On Thu, Jan 13, 2022 at 08:22:14PM +0300, Vladislav Yaroshchuk wrote:
> Create separate netdevs for each vmnet operating mode:
> - vmnet-host
> - vmnet-shared
> - vmnet-bridged
>
Sure I'm late to the party but what if we add only one backend - vmnet
with default mode set to shared and all paramet
On Thu, Jan 13, 2022 at 08:22:14PM +0300, Vladislav Yaroshchuk wrote:
> Create separate netdevs for each vmnet operating mode:
> - vmnet-host
> - vmnet-shared
> - vmnet-bridged
>
> Signed-off-by: Vladislav Yaroshchuk
> ---
> net/clients.h | 11
> net/meson.build | 7 +++
> net/
On Mon, Jan 24, 2022 at 12:27:40PM +0100, Christian Schoenebeck wrote:
> On Montag, 24. Januar 2022 10:56:00 CET Roman Bolshakov wrote:
> > On Thu, Jan 13, 2022 at 08:22:14PM +0300, Vladislav Yaroshchuk wrote:
> > > net/vmnet-bridged.m | 25 +
> > >
On Mon, Jan 24, 2022 at 08:14:31PM +, Peter Maydell wrote:
> On Mon, 24 Jan 2022 at 17:49, Roman Bolshakov wrote:
> > I'm not sure why blocks are Objective-C specific. All the data I have
> > shows the opposite [3][4][5]. They're just extensively used in Apple APIs.
&
On Mon, Jan 10, 2022 at 02:09:54PM +0100, Philippe Mathieu-Daudé wrote:
> Few patches to be able to build QEMU on macOS 12 (Monterey).
>
> This basically consists of adapting deprecated APIs. I am not
> sure about these APIs, so tagging as RFC.
>
> I couldn't succeed to adapt the Cocoa code.
>
>
e for raw images with extensions outside of the
specified list or for images without any extension.
Reviewed-by: Roman Bolshakov
Tested-by: Roman Bolshakov
Regards,
-Roman
> [2789/6622] Compiling Objective-C object libcommon.fa.p/ui_cocoa.m.o
> ui/cocoa.m:1411:16: error: &#
On Mon, Jan 10, 2022 at 02:09:57PM +0100, Philippe Mathieu-Daudé wrote:
> Both hvf_get_segments/hvf_put_segments() functions are only
> used within x86hvf.c: do not declare them as public API.
>
Reviewed-by: Roman Bolshakov
Tested-by: Roman Bolshakov
Thanks,
Roman
> Signed-off-
On Mon, Jan 10, 2022 at 02:09:55PM +0100, Philippe Mathieu-Daudé wrote:
> We can pass C/CPP/LD flags via CFLAGS/CXXFLAGS/LDFLAGS environment
> variables, or via configure --extra-cflags / --extra-cxxflags /
> --extra-ldflags options. Provide similar behavior for Objective C:
> use existing flags fr
> Not very useful deprecation doc:
> https://developer.apple.com/documentation/hypervisor/1441386-hv_vcpu_flush
>
Reviewed-by: Roman Bolshakov
Tested-by: Roman Bolshakov
Thanks,
Roman
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> target/i386/hvf/vmx.h | 2 --
> ta
On Mon, Jan 10, 2022 at 02:09:59PM +0100, Philippe Mathieu-Daudé wrote:
> When building on macOS 12 we get:
>
> audio/coreaudio.c:50:5: error: 'kAudioObjectPropertyElementMaster' is
> deprecated: first deprecated in macOS 12.0 [-Werror,-Wdeprecated-declarations]
> kAudioObjectPropertyElem
On Mon, Jan 10, 2022 at 02:09:59PM +0100, Philippe Mathieu-Daudé wrote:
> When building on macOS 12 we get:
>
> audio/coreaudio.c:50:5: error: 'kAudioObjectPropertyElementMaster' is
> deprecated: first deprecated in macOS 12.0 [-Werror,-Wdeprecated-declarations]
> kAudioObjectPropertyElem
On Wed, Jan 12, 2022 at 01:39:28PM +0800, Jason Wang wrote:
>
> 在 2022/1/12 上午6:02, Vladislav Yaroshchuk 写道:
> >
> >
> > вт, 11 янв. 2022 г., 5:10 AM Jason Wang :
> >
> > On Tue, Jan 11, 2022 at 12:49 AM Peter Maydell
> > wrote:
> > >
> > > On Mon, 10 Jan 2022 at 03:40, Jason W
On Wed, Jan 12, 2022 at 12:14:15AM +0300, Vladislav Yaroshchuk wrote:
> macOS provides networking API for VMs called 'vmnet.framework':
> https://developer.apple.com/documentation/vmnet
>
> We can provide its support as the new QEMU network backends which
> represent three different vmnet.framewor
On Wed, Jan 12, 2022 at 10:50:04AM +0300, Roman Bolshakov wrote:
> On Wed, Jan 12, 2022 at 12:14:15AM +0300, Vladislav Yaroshchuk wrote:
> > macOS provides networking API for VMs called 'vmnet.framework':
> > https://developer.apple.com/documentation/vmnet
> >
&g
On Wed, Jan 12, 2022 at 04:23:30PM +0300, Vladislav Yaroshchuk wrote:
> ср, 12 янв. 2022 г. в 11:22, Roman Bolshakov :
>
> > On Wed, Jan 12, 2022 at 10:50:04AM +0300, Roman Bolshakov wrote:
> > > On Wed, Jan 12, 2022 at 12:14:15AM +0300, Vladislav Yaroshchuk wro
On Wed, Jan 12, 2022 at 03:21:44PM +0300, Vladislav Yaroshchuk wrote:
> vmnet.framework dependency is added with 'vmnet' option
> to enable or disable it. Default value is 'auto'.
>
> vmnet features to be used are available since macOS 11.0,
> corresponding probe is created into meson.build.
>
>
+497,14 @@ F: target/arm/hvf/
>
> X86 HVF CPUs
> M: Cameron Esfahani
> -M: Roman Bolshakov
> +M: Roman Bolshakov
> W: https://wiki.qemu.org/Features/HVF
> S: Maintained
> F: target/i386/hvf/
>
> HVF
> M: Cameron Esfahani
> -M: Roman Bolsh
On Mon, Dec 03, 2018 at 01:04:15PM +0300, Roman Bolshakov wrote:
> It's going to clutter QEMU logs if 0x0f00 is trapped.
>
> Signed-off-by: Roman Bolshakov
> ---
> target/i386/hvf/x86_decode.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/target/i386/h
** Summary changed:
- HVF linux on OSX hangs 2nd time started after adding socket
+ MMX emulation is missing on HVF Acceleration
** Description changed:
-
Robs-MacBook-Pro-2:~ robmaskell$ qemu-system-x86_64 --version
QEMU emulator version 3.0.0
Host: MacOS - 10.13.6
Model Name: Mac
Hello dear subscribers,
I'm running Linux in QEMU on macOS with hvf accel enabled and having an
issue that is very similar to the KVM bug in nested KVM environments,
where KVM is run under another hypervisor:
https://bugs.launchpad.net/qemu/+bug/1636217
The symptomps are the same as in the bug a
On Wed, Oct 17, 2018 at 10:47:40AM +0100, Stefan Hajnoczi wrote:
> On Tue, Oct 16, 2018 at 06:27:12PM +0300, Roman Bolshakov wrote:
> >
> > It looks like virtio backend doesn't return 0 device status after
> > vp_iowrite8 and vp_reset blocks udev:
> > w
si)" is
decoded as "mov %bh,(%rsi)".
That caused an infinite loop in vp_reset:
https://lists.gnu.org/archive/html/qemu-devel/2018-10/msg03293.html
Signed-off-by: Roman Bolshakov
---
target/i386/hvf/x86_decode.c | 67
target/i386/hvf/x86_decod
accel_init_machine sets *(acc->allowed) to true if acc->init_machine(ms)
succeeds. There's no need to have both hvf_allowed and hvf_disabled.
Signed-off-by: Roman Bolshakov
---
include/sysemu/hvf.h | 4 ++--
target/i386/hvf/hvf.c | 9 +
2 files changed, 3 insertions(+), 1
I've had issues with multiple vcpus previously.
But I've tried that recently and it worked fine with the fix:
https://lists.gnu.org/archive/html/qemu-devel/2018-10/msg03864.html.
And I've checked your command, no issues.
Could you please try to install qemu from my tap and check if it's gone?
b
I have tried to run the OS and I can confirm that some instructions that
require VMEXIT are not implemented. In your case that's 0F7F or MOVQ
(mem from mmxreg) from MMX. In my case that's 0F11 or MOVUPS(xmmreg1 to
mem) from SSE.
I'd recommend you to run -cpu host,-mmx,-sse for a while, but the ker
Considering the fact that both Ubuntu and Elementary require SSE to
boot, I'd wait to get decoding fixed. I wrote a test kernel module that
reliably reproduces your issue on qemu edu device. Whenever QEMU prints
Unimplemented handler Instruction pointer only moves two bytes further,
instead of the
ned-off-by: Roman Bolshakov
---
roms/Makefile | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/roms/Makefile b/roms/Makefile
index f4141e1d96..a6043eff37 100644
--- a/roms/Makefile
+++ b/roms/Makefile
@@ -83,12 +83,12 @@ build-seabios-config-%: config.%
cp $< s
On Thu, Oct 25, 2018 at 01:20:50PM -0400, Emilio G. Cota wrote:
> For now only add it for ELF platforms, since we rely on the linker's
> --dynamic-list flag to pass a list of symbols to be exported to the
> executable. An alternative would be to use -rdynamic, but that would
> expose all of QEMU's
On Tue, Nov 27, 2018 at 06:13:57PM -0500, Emilio G. Cota wrote:
> On Tue, Nov 27, 2018 at 15:43:52 +0300, Roman Bolshakov wrote:
> > ld64 on macOS has similar -exported_symbols_list option. Here's the
> > reference:
> >
> > -exported_symbols_list filenam
On Wed, Nov 28, 2018 at 12:23:32PM -0500, Emilio G. Cota wrote:
> On Wed, Nov 28, 2018 at 13:43:30 +0300, Roman Bolshakov wrote:
> > qemu-ga fails to link because it doesn't have symbols declared in
> > qemu-plugins-ld64.symbols. Perhaps "-Wl,-exported_symbols_list"
Can you try to build it without SDL/GTK support? I'm not having any
issues with Cocoa display.
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1802684
Title:
QEMU gui crashes on macOS Mojave
Status
On Thu, Nov 29, 2018 at 12:49:27PM -0500, Emilio G. Cota wrote:
> On Thu, Nov 29, 2018 at 12:00:55 -0500, Emilio G. Cota wrote:
> > On Thu, Nov 29, 2018 at 12:57:16 +0300, Roman Bolshakov wrote:
> > > Hi Emilio,
> > >
> > > I think there's an issue with
On Thu, Oct 25, 2018 at 01:20:57PM -0400, Emilio G. Cota wrote:
> +
> +lib%.so: %.o
> + $(CC) -shared -Wl,-soname,$@ -o $@ $^ $(LDLIBS)
The rule should be a bit different for macOS:
%.bundle: %.o
$(CC) -bundle -Wl,-bundle_loader,PATH_TO_QEMU_EXE -o $@ $^ $(LDLIBS)
"-bundle" flag is nee
I've tried to run two x86 guests with Cocoa display on 3.1 rc3, the GUI
doesn't crash. I've tried to change screen resolution on openSUSE 15, it
also works without an issue.
My command line is:
./x86_64-softmmu/qemu-system-x86_64 -accel hvf -cpu host -hda /path/to/disk -m
MEMORY
--
You received
It's going to clutter QEMU logs if 0x0f00 is trapped.
Signed-off-by: Roman Bolshakov
---
target/i386/hvf/x86_decode.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/target/i386/hvf/x86_decode.c b/target/i386/hvf/x86_decode.c
index d125a6ef83..5f513c5563 100644
--- a/target/i38
correct maximum length for _decode_tbl2 and _decode_tbl3.
Signed-off-by: Roman Bolshakov
---
target/i386/hvf/x86_decode.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/target/i386/hvf/x86_decode.c b/target/i386/hvf/x86_decode.c
index 2e33b69541..d125a6ef83 100644
--- a
Linux.
An ability to retrieve SIGBUS via signalfd(2) is used by QEMU for
memory preallocation therefore we can't unblock it without consequences.
But it's important to leave a remark that the signal is lost on macOS.
Signed-off-by: Roman Bolshakov
---
util/qemu-thread-posix.c | 5 +
macOS provides pthread_setname_np that doesn't have thread id argument.
Signed-off-by: Roman Bolshakov
---
configure| 32 ++--
qemu-options.hx | 4 ++--
util/qemu-thread-posix.c | 6 +-
3 files changed, 33 insertions(+), 9 dele
naming on macOS. Some threads
(signalfd_compat and rcu_call) are created before debug-threads=on is
parsed and don't get their names though.
Thank you,
Roman
Roman Bolshakov (2):
util: Implement debug-threads for macOS
qemu-thread: Don't block SEGV, ILL and FPE
configure| 3
On Wed, Dec 19, 2018 at 10:12:48AM +0100, Markus Armbruster wrote:
> Avoids pointless recompilation. Missed in commit 112ed241f5d.
>
> Signed-off-by: Markus Armbruster
> ---
> Untested; I don't have access to a Mac.
>
> ui/cocoa.m | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
>
On Thu, Dec 20, 2018 at 09:45:59AM +0100, Markus Armbruster wrote:
> Avoids pointless recompilation. Missed in commit 112ed241f5d.
>
> Signed-off-by: Markus Armbruster
> ---
> ui/cocoa.m | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
Reviewed-by: Roman
confirm that as I have only
Ivy Bridge and Haswell-based laptops.
Reviewed-by: Roman Bolshakov
Thanks,
Roman
On Wed, Aug 22, 2018 at 12:38:35PM +0200, Paolo Bonzini wrote:
> For some reason __APPLE__ was not checked in pty code. However, the #ifdef
> is redundant: this file is already compiled only if CONFIG_POSIX, same as
> util/qemu-openpty.c which it uses.
>
Hi Paolo,
Is it possible to apply the pa
For some reason __APPLE__ was not checked in pty code. pty chardev
should be available on macOS, according to man page.
Signed-off-by: Roman Bolshakov
---
chardev/char-pty.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/chardev/char-pty.c b/chardev/char-pty.c
index
On Wed, Aug 22, 2018 at 12:38:35PM +0200, Paolo Bonzini wrote:
> For some reason __APPLE__ was not checked in pty code. However, the #ifdef
> is redundant: this file is already compiled only if CONFIG_POSIX, same as
> util/qemu-openpty.c which it uses.
>
Thanks Paolo!
FWIW, qemu_openpty_raw and
locked up forever in
qemu_wait_io_event() (cpu_thread_is_idle() evaluates inhibition
flag and considers the CPU idle if the flag is set).
Cc: Cameron Esfahani
Signed-off-by: Roman Bolshakov
---
target/i386/hvf/vmx.h | 3 +++
1 file changed, 3 insertions(+)
diff --git a/target/i386/hvf/vmx.h b
** Changed in: qemu
Status: Fix Committed => Fix Released
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1840719
Title:
win98se floppy fails to boot with isapc machine
Status in QEMU:
Fix
ni/qemu branch meson-poc-next.
>
> Paolo
>
Hi Paolo,
for macOS/darwin,
Tested-by: Roman Bolshakov
On the next step, it might be good to drop configure in favor of meson
configuration, so configure, build and test commands would be similar to
libvirt:
meson build
ninja -C build
meson test -C build
Thanks,
Roman
On Fri, Aug 14, 2020 at 05:11:21AM -0400, Paolo Bonzini wrote:
> This shows how to do some "computations" in meson.build using its array
> and dictionary data structures, and also a basic usage of the sourceset
> module for conditional compilation.
>
> [...]
> diff --git a/trace/meson.build b/trac
On Mon, Aug 17, 2020 at 01:24:50PM +0200, Paolo Bonzini wrote:
> On 17/08/20 13:02, Roman Bolshakov wrote:
> >
> > Tested-by: Roman Bolshakov
> >
> > On the next step, it might be good to drop configure in favor of meson
> > configuration, so configure, build a
On Fri, Aug 14, 2020 at 02:01:01PM -0700, Richard Henderson wrote:
> On 8/12/20 11:32 AM, Claudio Fontana wrote:
> > +static void generic_handle_interrupt(CPUState *cpu, int mask)
> > +{
> > +cpu->interrupt_request |= mask;
> > +
> > +if (!qemu_cpu_is_self(cpu)) {
> > +qemu_cpu_kick
On Thu, Aug 13, 2020 at 06:25:44PM -0400, Eduardo Habkost wrote:
> This is an extension of the series previously submitted by
> Daniel[1], including a script that will convert existing type
> checker macros automatically.
>
Hi Eduardo,
do you have a repo where it can be checked it out?
Thanks,
emu/hvf.h | 2 ++
> 1 file changed, 2 insertions(+)
>
Reviewed-by: Roman Bolshakov
On Thu, Aug 20, 2020 at 05:55:29PM -0400, Eduardo Habkost wrote:
> While trying to convert TypeInfo declarations to the new
> OBJECT_DECLARE* macros, I've stumbled on a few suspicious cases
> where instance_size or class_size is not set, despite having type
> checker macros that use a specific type
hanges v1 -> v2: none
>
> ---
> Cc: Cameron Esfahani
> Cc: Roman Bolshakov
> Cc: Paolo Bonzini
> Cc: Richard Henderson
> Cc: Eduardo Habkost
> Cc: qemu-devel@nongnu.org
> ---
> include/sysemu/hvf.h | 1 +
> target/i386/hvf/hvf-i386.h | 4 ++--
> 2 file
hanges v1 -> v2: none
>
> ---
> Cc: Cameron Esfahani
> Cc: Roman Bolshakov
> Cc: Paolo Bonzini
> Cc: Richard Henderson
> Cc: Eduardo Habkost
> Cc: qemu-devel@nongnu.org
> ---
> include/sysemu/hvf.h | 1 +
> target/i386/hvf/hvf-i386.h | 4 ++--
> 2 file
On Tue, Jun 23, 2020 at 01:48:57PM +0100, Stefan Hajnoczi wrote:
> On Mon, Jun 01, 2020 at 03:42:57PM +0300, Roman Bolshakov wrote:
> > ld64 is making PIE executables for 10.7 and above by default, as
> > documented in ld(1).
> >
> > Signed-off-by: Roman Bolshakov
On Mon, Jun 22, 2020 at 03:45:30PM +0200, Claudio Fontana wrote:
> Motivation and higher level steps:
>
> https://lists.gnu.org/archive/html/qemu-devel/2020-05/msg04628.html
>
> MAIN OPEN POINTS:
>
> * confirmation on hvf state (Roman).
>
Hi Claudio,
I'm sorry for delay. I'm wrapping up anoth
that points to the I/O write instruction. Execution of the CPU
gets stuck on the instruction.
The issue can be avoided if eip doesn't contain stale value when dirty
flag is set on cpu.
Cc: Cameron Esfahani
Signed-off-by: Roman Bolshakov
---
target/i386/hvf/vmx.h | 1 +
1 file changed, 1 in
hvf lacks an implementation of cpu_synchronize_pre_loadvm().
Cc: Cameron Esfahani
Signed-off-by: Roman Bolshakov
---
include/sysemu/hvf.h | 1 +
include/sysemu/hw_accel.h | 3 +++
target/i386/hvf/hvf.c | 11 +++
3 files changed, 15 insertions(+)
diff --git a/include/sysemu
The series is a prerequisite to implement gdbstub support for HVF and mostly
concerns improvements of cpu_synchronize_* functions wrt to HVF and addresses
old TODO's in the related code.
Unfortunately live snapshots don't seem to work yet but they don't work with
tcg (on macOS)
Make them more concise and consitent with the rest of the code in the
file and drop non-relevant TODO.
Cc: Cameron Esfahani
Signed-off-by: Roman Bolshakov
---
target/i386/hvf/hvf.c | 36
1 file changed, 16 insertions(+), 20 deletions(-)
diff --git a/target
Cc: Cameron Esfahani
Signed-off-by: Roman Bolshakov
---
cpus.c| 12
include/sysemu/hw_accel.h | 10 ++
2 files changed, 10 insertions(+), 12 deletions(-)
diff --git a/cpus.c b/cpus.c
index 7317ae06b9..26709677d3 100644
--- a/cpus.c
+++ b/cpus.c
efore it's safe to remove them from hvf_reset_vcpu().
Cc: Cameron Esfahani
Signed-off-by: Roman Bolshakov
---
target/i386/hvf/hvf.c | 78 ---
1 file changed, 78 deletions(-)
diff --git a/target/i386/hvf/hvf.c b/target/i386/hvf/hvf.c
index 4d254a477a..
It's worth to have a custom accel-specific reset in x86_cpu_reset() only
if something related to CPUState has to be reset and that can't be done
in post-init or post-reset.
Cc: Cameron Esfahani
Signed-off-by: Roman Bolshakov
---
include/sysemu/hvf.h | 1 -
target/i386/cpu.
erent from what hv_vcpu_interrupt does. The latter
one results in invocation of mp_cpus_kick() in XNU kernel [1].
While at it, correct type of hvf_fd to the type of hv_vcpuid_t to avoid
compilation warnings.
1. https://opensource.apple.com/source/xnu/xnu-6153.81.5/osfmk/i386/mp.c
Cc: Cameron Esfahani
Signe
Similar patch was sent a while ago but got lost.
While at it, add a status wiki page.
Cc: Cameron Esfahani
Signed-off-by: Roman Bolshakov
---
MAINTAINERS | 2 ++
1 file changed, 2 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 01e6b3fefe..f54a50cdb2 100644
--- a/MAINTAINERS
+++ b
The issue should be fixed in QEMU v5.0+
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1818937
Title:
Crash with HV_ERROR on macOS host
Status in QEMU:
Fix Released
Bug description:
On macOS h
I'm not exactly sure what commit improved the situation (either
https://git.qemu.org/?p=qemu.git;a=commit;h=e37aa8b0e410 or
https://git.qemu.org/?p=qemu.git;a=commit;h=fbafbb6db7742) but I have
noticed that sporadic failures are gone after the series was applied:
https://lists.gnu.org/archive/html
by doing a `git diff -w` after the change.
>
> This could probably be turned into a pre-commit hook.
>
For HVF bits,
Reviewed-by: Roman Bolshakov
Thanks,
Roman
The commit fixes the issue in master branch:
https://git.qemu.org/?p=qemu.git;a=commit;h=de15df5ead400b7c3d0cf21c8164a7686dc81933
The fix is going to be released in 5.1
** Changed in: qemu
Status: In Progress => Fix Committed
--
You received this bug notification because you are a member
On Thu, Jul 02, 2020 at 02:42:45PM +0200, Paolo Bonzini wrote:
> On 02/07/20 12:57, Roman Bolshakov wrote:
> > There's still a small chance of kick loss, on user-to-kernel border
> > between atomic_mb_set's just before the entry to hv_vcpu_run and just
> > after it.
Removal of register reset omitted initialization of CR4 guest/host mask.
x86_64 guests aren't booting without it.
Fixes: 5009ef22c6bb2 ("i386: hvf: Don't duplicate register reset")
Signed-off-by: Roman Bolshakov
---
target/i386/hvf/vmx.h | 1 +
1 file changed, 1 insert
On Tue, Jul 14, 2020 at 12:07:27PM +0300, Roman Bolshakov wrote:
> Removal of register reset omitted initialization of CR4 guest/host mask.
> x86_64 guests aren't booting without it.
>
> Fixes: 5009ef22c6bb2 ("i386: hvf: Don't duplicate register reset")
> Sig
On Wed, Jul 15, 2020 at 04:31:30PM +0200, Philippe Mathieu-Daudé wrote:
> Unused trace event cause build failure when using the dtrace backend:
>
> "probe colo_compare_miscompare doesn't exist"
>
> Fixes: f4b618360e ("colo-compare: add TCP, UDP, ICMP packe
sn't exist"
> >
> > Fixes: f4b618360e ("colo-compare: add TCP, UDP, ICMP packet comparison")
> > Reported-by: Roman Bolshakov
>
> Note Roman indicated on IRC that this is seen with dtrace on macOS and
> there were other problems too.
>
> Unless someone k
integer types. We don't want QEMU specific types
as we can't assume trace backends can resolve all the
typedefs
Fixes: 3d211d9f4dbee ("trace: Add 'vcpu' event property to trace guest vCPU")
Cc: Cameron Esfahani
Signed-off-by: Roman Bolshakov
---
scripts/tra
dtrace USDT is fully supported since OS X 10.6. There are a few
peculiarities compared to other dtrace flavors.
1. It doesn't accept empty files.
2. It doesn't recognize bool type but accepts ANSI C _Bool.
Cc: Cameron Esfahani
Signed-off-by: Roman Bolshakov
---
scripts/tracetool/f
Hi,
This is a small series that enables dtrace tracing backend on macOS.
Whether or not it should go to 5.1 is up to discretion of tracing
maintainers.
Thanks,
Roman
Roman Bolshakov (4):
scripts/tracetool: Fix dtrace generation for macOS
scripts/tracetool: Use void pointer for vcpu
build
ppe Mathieu-Daudé
Cc: Cameron Esfahani
Signed-off-by: Roman Bolshakov
---
net/colo-compare.c| 12 +++-
net/filter-rewriter.c | 8 ++--
net/trace-events | 2 --
3 files changed, 13 insertions(+), 9 deletions(-)
diff --git a/net/colo-compare.c b/net/colo-compare.c
index 398b7
https://markmail.org/message/5xrxt2w5m42nojkz
Cc: Cameron Esfahani
Signed-off-by: Roman Bolshakov
---
Makefile.objs | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Makefile.objs b/Makefile.objs
index d22b3b45d7..982f15ba30 100644
--- a/Makefile.objs
+++ b/Makefile.objs
@@ -211,5 +211,7 @@ trace-e
On Thu, Jul 16, 2020 at 09:51:27AM +0100, Daniel P. Berrangé wrote:
> Adding Stefan to CC as the trace maintainer.
>
> On Thu, Jul 16, 2020 at 11:17:54AM +0300, Roman Bolshakov wrote:
> > Build of QEMU with dtrace fails on macOS:
> >
> > LINKx86_64-softmmu/q
t; > Paolo
> >
> > Il mar 14 lug 2020, 12:39 Roman Bolshakov ha
> > scritto:
> >
> > > On Tue, Jul 14, 2020 at 12:07:27PM +0300, Roman Bolshakov wrote:
> > > > Removal of register reset omitted initialization of CR4 guest/host mask.
> > >
[-Wpointer-sign] warning.
Cc: Cameron Esfahani
Signed-off-by: Roman Bolshakov
---
scripts/tracetool/format/d.py | 15 ++-
1 file changed, 14 insertions(+), 1 deletion(-)
diff --git a/scripts/tracetool/format/d.py b/scripts/tracetool/format/d.py
index 0afb5f3f47..353722f89c 10
converting int8_t * to
signed char * in static probe definitions.
- Moved COLO packet dump under #ifdef DEBUG_COLO_PACKETS (Daniel).
- Separated tracepoints in net/filter-rewriter.c to use matching
is-enabled probe (Daniel).
Roman Bolshakov (4):
scripts/tracetool: Fix dtrace generation
("colo-compare: add TCP, UDP, ICMP packet comparison")
Cc: Philippe Mathieu-Daudé
Cc: Cameron Esfahani
Signed-off-by: Roman Bolshakov
---
net/colo-compare.c| 42 ++
net/filter-rewriter.c | 10 --
net/trace-events | 2 --
3 files
integer types. We don't want QEMU specific types
as we can't assume trace backends can resolve all the
typedefs
Fixes: 3d211d9f4dbee ("trace: Add 'vcpu' event property to trace guest vCPU")
Reviewed-by: Daniel P. Berrangé
Cc: Cameron Esfahani
Signed-off-by:
https://markmail.org/message/5xrxt2w5m42nojkz
Reviewed-by: Daniel P. Berrangé
Cc: Cameron Esfahani
Signed-off-by: Roman Bolshakov
---
Makefile.objs | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Makefile.objs b/Makefile.objs
index d22b3b45d7..982f15ba30 100644
--- a/Makefile.objs
+++ b/Makefile
On Sun, Jul 19, 2020 at 03:52:08PM +0200, Philippe Mathieu-Daudé wrote:
> On 7/17/20 11:35 AM, Roman Bolshakov wrote:
> > dtrace USDT is fully supported since OS X 10.6. There are a few
> > peculiarities compared to other dtrace flavors.
> >
> > 1. It doesn't accep
On Sat, Jul 18, 2020 at 05:58:56PM +, Zhang, Chen wrote:
> > -Original Message-
> > From: Roman Bolshakov
> > Sent: Friday, July 17, 2020 5:35 PM
> > @@ -533,12 +535,12 @@ static int colo_packet_compare_udp(Packet *spkt,
> > Packet *ppkt)
> >
On Fri, Jul 17, 2020 at 12:35:16PM +0300, Roman Bolshakov wrote:
> dtrace on macOS uses unresolved symbols with a special prefix to define
> probes [1], only headers should be generated for USDT (dtrace(1)). But
> it doesn't support backwards compatible no-op -G flag [2] and implicit
On Tue, Jul 21, 2020 at 03:06:57PM +0100, Daniel P. Berrangé wrote:
> On Sat, Jul 18, 2020 at 05:58:56PM +, Zhang, Chen wrote:
> >
> >
> > > -Original Message-
> > > From: Roman Bolshakov
> > > Sent: Friday, July 17, 2020 5:35 PM
> >
clear VMX-preemption timer, i.e. kicks are coalesced with interrupts.
While at it, correct type of hvf_fd to the type of hv_vcpuid_t to avoid
compilation warnings.
1. https://opensource.apple.com/source/xnu/xnu-6153.81.5/osfmk/i386/mp.c
Cc: Cameron Esfahani
Signed-off-by: Roman Bolshakov
---
On Mon, Aug 03, 2020 at 11:05:27AM +0200, Claudio Fontana wrote:
> The new interface starts unused, will start being used by the
> next patches.
>
> It provides methods for each accelerator to start a vcpu, kick a vcpu,
> synchronize state, get cpu virtual clock and elapsed ticks.
>
> Signed-off-
+++ b/target/i386/hvf/Makefile.objs
> @@ -1,2 +1,2 @@
> -obj-y += hvf.o
> +obj-y += hvf.o hvf-cpus.o
> obj-y += x86.o x86_cpuid.o x86_decode.o x86_descr.o x86_emu.o x86_flags.o
> x86_mmu.o x86hvf.o x86_task.o
> diff --git a/target/i386/hvf/hvf-cpus.c b/target/i386/hvf/hvf-cpus.c
> new file mode 100644
> index 00..9540157f1e
> --- /dev/null
> +++ b/target/i386/hvf/hvf-cpus.c
I'd prefer singular form in variables and file names. More on that in
the comment to patch 2.
Besides that it works fine,
Reviewed-by: Roman Bolshakov
Tested-by: Roman Bolshakov
Regards,
Roman
1 - 100 of 358 matches
Mail list logo
