Public bug reported:
command line:
qemu-system-arm -semihosting -nographic -monitor null -serial null -no-reboot
-kernel build/fw/0HNFcomSLuP1_CUNIT.elf
output:
rom: requested regions overlap (rom phdr #6: build/fw/0HNFcomSLuP1_CUNIT.elf.
free=0x8001effc, addr=0x8001c000)
rom loading failed
I
I did a test (with version 2.2.0) to simply not fail out upon this error
(removed the "return -1" in function rom_load_all() in file
hw/core/loader.c).
With that hack I got the elf file running I'll attach with *this* comment (note
that attachment #1 won't run correctly but probably for some othe
additional info:
0MFWSL_EmoDatauP1_CUNIT.elf from previous post runs fine with 1.0.50 (Debian
1.0.50-2012.03-0ubuntu2.1) and 0.10.2
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1429841
Title:
err
To make things more easy I added some debug output to function rom_load_all().
It prints infos for every rom section is processes:
rom phdr #1: 0MFWSL_EmoDatauP1_CUNIT.elf. free=0x,
size=0x003c, addr=0x)
rom phdr #2: 0MFWSL_EmoDatauP1_CUNIT.elf. free=0x
Retest with qemu 2.7.0: issue still occours
Same fix works for me: removed 'return -1;' in function
rom_check_and_register_reset() (line 1030 of file hw/core/loader.c)
** Tags added: qemu
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QE
Public bug reported:
I'll attach a binary that runs fine with qemu-system-arm V2.2.0 but V2.7.0
segfaults.
By stepping through with gdb I found that the segfaults happens when executing
the line "smulbb r7, r5, r5" (where r7=0x1, r5=0x12).
I'll also attach a debugger screenshot.
call and output
in the screenshot one can see the assembler line that fails
** Attachment added: "Debugger screenshot"
https://bugs.launchpad.net/qemu/+bug/1636126/+attachment/4766312/+files/Screenshot_Debugger.png
--
You received this bug notification because you are a member of qemu-
devel-ml, which is su
Hi Peter!
Thank you for your help, it works fine with "-M integratprcp -cpu cortex-m4"
but I might choose another board as you suggested.
I didn't have in mind that we switched to M4 instruction set.
Where do I get the information that integratorcp is not good for cortex-M3?
Or better question:
Tried to run cortex-M4 command on M3.
** Changed in: qemu
Status: New => Invalid
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1636126
Title:
qemu-system-arm segfaults on "smulbb r7, r5, r5
Just tested with QEMU 2.10.93 in cygwin: problem does not occour
anymore!
Thanks a lot!
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1429841
Title:
error "rom: requested regions overlap" for NOLO
Public bug reported:
running on cygwin in Windows 7
QEMU 2.10.93 segfaults:
$ /opt/qemu2.11/qemu-system-arm -M integratorcp -cpu cortex-m4 -semihosting
-nographic -monitor null -serial null -no-reboot -kernel
MFWso_Cycle_f1uP2_CUNIT_0.elf
Segmentation fault
where QEMU 2.7.0 worked:
$ /opt/qemu
Thanks Peter for this information!
I guess our code was tweaked to run with this options a long time ago -
so I will have to do some investigations to get it working with a valid
NVIC...
As of writing I remember having a similar issue some time ago (which I now
found to have resulted in Bug 1636
.com/7/1407910491.666.2014-07-16T130602Z-trim.png
I was only successful in using this with the virtual IDE interface disks on
Qemu/KVM 2.0, the virtio mode does not seem to support TRIM; did not try with
sata/ahci.
--
With respect,
Roman
signature.asc
Description: PGP signature
and 2
also by software. Level 1 says that the solution must only use approved
algorythms, but there is no requirement about enforcing this. Level 2
requires enforcement.
As a consequence, for qemu to be able to run with a crypto library that
is FIPS-140-2 certified, it should be aware of the FIPS mode if there is
any, and refrain from initializing cryptography that is not allowable
(crypt(3) aka DES, but also MD5 (is a no-go)). In addition to that, qemu
must not have any own algorythm implementations (convenient...).
> Alex
Thanks,
Roman.
, and using guest-exec to perform it.
IMO the question is how low the bar is to extend the qga protocol with
yet another general-purpose (i.e. not virtual machine-specific) OS
management task. I'd rather see it out of scope for qga. Instead, such
an upper management layer, if necessary, would bring its own agent, with
qga acting as a transport. This way e.g. OpenStack would be able to
uniformly change admin passwords also in ESXi, Parallels Server, LXC,
OpenVz, physical servers, etc.
Roman.
do from a user belonging to a particular group (IIRC Ubuntu is usually
set up like that).
> NB windows support is desirable, but not implemented in this
> patch.
Yes Windows may have an issue with username here too, because the admin
user can be any user (and even "Administrator" can be localized).
Roman.
On Thu, Dec 25, 2014 at 08:37:29AM +0300, Denis V. Lunev wrote:
> +#ifdef CONFIG_FALLOCATE_ZERO_RANGE
> +do {
> +if (fallocate(s->fd, CONFIG_FALLOCATE_ZERO_RANGE,
Must be a typo, FALLOC_FL_ZERO_RANGE is what you mean.
Roman.
is suboptimal in that fallocate(FALLOC_FL_ZERO_RANGE) would always
be called in vain for such systems. Might be worth another flag in
BDRVRawState?
Roman.
c | 12
> 1 file changed, 8 insertions(+), 4 deletions(-)
Acked-by: Roman Kagan
Roman.
; ---
> block/parallels.c | 48
> 1 file changed, 24 insertions(+), 24 deletions(-)
Acked-by: Roman Kagan
Roman.
tefan Hajnoczi
> ---
> block/parallels.c | 19 ++-
> 1 file changed, 10 insertions(+), 9 deletions(-)
Acked-by: Roman Kagan
Roman.
dded to the file, you'd have two bat entries pointing at the same
cluster.
The _sync version used to leave this window quite narrow due to the
flush following the write. The patch makes the reordering more likely.
I'm afraid the only reliable way to handle it is to put a barrier
between truncate and bat update, and mitigate the costs by batching the
file expansions, as you seem to do in the followup patches.
Roman.
On Tue, Jan 13, 2015 at 11:16:04PM +0300, Denis V. Lunev wrote:
> On 13/01/15 18:17, Denis V. Lunev wrote:
> >On 13/01/15 17:50, Roman Kagan wrote:
> >>On Tue, Dec 30, 2014 at 01:07:09PM +0300, Denis V. Lunev wrote:
> >>>--- a/block/parallels.c
> >>>+++
flush_to_os(BlockDriverState *bs)
> +{
> +BDRVParallelsState *s = bs->opaque;
> +int ret;
> +
> +qemu_co_mutex_lock(&s->lock);
> +ret = write_bat_cache(bs);
> +qemu_co_mutex_unlock(&s->lock);
> +
> +return ret;
> +}
> +
> +
> static int cluster_remainder(BDRVParallelsState *s, int64_t sector_num,
> int nb_sectors)
> {
> @@ -387,6 +474,7 @@ exit:
> static void parallels_close(BlockDriverState *bs)
> {
> BDRVParallelsState *s = bs->opaque;
> +qemu_vfree(s->bat_cache);
Don't you need to flush the bat cache here first?
> g_free(s->bat);
> }
>
> @@ -416,6 +504,7 @@ static BlockDriver bdrv_parallels = {
> .bdrv_open = parallels_open,
> .bdrv_close = parallels_close,
> .bdrv_co_get_block_status = parallels_co_get_block_status,
> +.bdrv_co_flush_to_os = parallels_co_flush_to_os,
> .bdrv_co_readv = parallels_co_readv,
> .bdrv_co_writev = parallels_co_writev,
Roman.
On Wed, Jan 14, 2015 at 04:08:50PM +0300, Denis V. Lunev wrote:
> On 14/01/15 16:03, Roman Kagan wrote:
> >On Tue, Dec 30, 2014 at 01:07:10PM +0300, Denis V. Lunev wrote:
> >>+static int cache_bat(BlockDriverState *bs, uint32_t idx, uint32_t
> >>new_data_off)
>
fied.
I think it would make sense to consolidate that option with this new
batched allocation in the generic block code. I guess qcow2 and
raw-posix would benefit from it, too.
At any rate I think it's a matter for a separate patchset.
Roman.
On Wed, Jan 14, 2015 at 05:31:20PM +0300, Denis V. Lunev wrote:
> On 14/01/15 17:26, Roman Kagan wrote:
> >On Tue, Dec 30, 2014 at 01:07:11PM +0300, Denis V. Lunev wrote:
> >>This is preparational commit for tweaks in Parallels image expansion.
> >>The idea is that enlar
gt; +++ b/block/parallels.c
> @@ -82,6 +82,7 @@ typedef struct BDRVParallelsState {
> int bat_cache_off;
> int data_off;
>
> +int64_t prealloc_off;
This field name confused me. I think "data_end" would fit better.
Otherwise looks good to me.
Roman.
On Mon, Dec 15, 2014 at 01:30:03PM +0100, Kevin Wolf wrote:
> Am 15.12.2014 um 09:27 hat Denis V. Lunev geschrieben:
> > From: Roman Kagan
> >
> > Add backing file support to Parallels format driver.
> >
> > That said, I think backing file operations should end
ment about locking considerations in the driver.
>
> Signed-off-by: Denis V. Lunev
> CC: Roman Kagan
> CC: Kevin Wolf
> CC: Stefan Hajnoczi
> ---
> block/parallels.c | 54 +-
> 1 file changed, 33 insertions(+), 21 deletions(-)
Reviewed-by: Roman Kagan
On Tue, Apr 28, 2015 at 10:46:41AM +0300, Denis V. Lunev wrote:
> From the guest point of view unallocated blocks are zeroed.
>
> Signed-off-by: Denis V. Lunev
> CC: Roman Kagan
> CC: Kevin Wolf
> CC: Stefan Hajnoczi
> ---
> block/parallels.c | 1 +
> 1 file change
older truncate()
> could be used as a fallback using image open options thanks to the
> previous patch.
>
> The benefit is around 15%.
>
> Signed-off-by: Denis V. Lunev
> Reviewed-by: Roman Karan
s/Karan/Kagan/
> CC: Kevin Wolf
> CC: Stefan Hajnoczi
> ---
>
On Tue, Apr 28, 2015 at 10:46:42AM +0300, Denis V. Lunev wrote:
> Support write on Parallels images. The code is almost the same as one
> in the previous patch implemented scatter-gather IO for read.
>
> Signed-off-by: Denis V. Lunev
> CC: Roman Kagan
> CC: Kevin Wolf
>
or the image expansion
> - tail writes are ordered, i.e. the guest IO queue could not be sent
> immediately to the host introducing additional IO delays
>
> This patch just adds proper parameters into BDRVParallelsState and
> performs options parsing in parallels_open.
>
>
On Tue, Apr 28, 2015 at 01:59:56PM +0300, Roman Kagan wrote:
> On Tue, Apr 28, 2015 at 10:46:58AM +0300, Denis V. Lunev wrote:
> > This is preparational commit for tweaks in Parallels image expansion.
> > The idea is that enlarge via truncate by one data block is slow. It
> >
On Tue, Mar 10, 2015 at 11:51:09AM +0300, Denis V. Lunev wrote:
> This will allow to use this data as buffer to BAT update directly
> without any intermediate buffers.
>
> Signed-off-by: Denis V. Lunev
> CC: Roman Kagan
> CC: Kevin Wolf
> CC: Stefan Hajnoczi
> ---
&
On Tue, Mar 10, 2015 at 11:51:08AM +0300, Denis V. Lunev wrote:
> deduplicate copy/paste arithmetcs
>
> Signed-off-by: Denis V. Lunev
> CC: Roman Kagan
> CC: Kevin Wolf
> CC: Stefan Hajnoczi
> ---
> block/parallels.c | 12 +---
> 1 file changed, 9
1.hds
> from 45 Mb/sec to 160 Mb/sec on my SSD disk. The gain on rotational media
> is much more sufficient, from 800 Kb/sec to 45 Mb/sec.
>
> Signed-off-by: Denis V. Lunev
> CC: Roman Kagan
> CC: Kevin Wolf
> CC: Stefan Hajnoczi
> ---
> block/parallels.c | 2 +-
64k ./1.hds 64G
> qemu-io -f parallels -c "write -P 0x11 0 1024k" 1.hds
> writing from 50-60 Mb/sec to 80-90 Mb/sec on rotational media and
> from 160 Mb/sec to 190 Mb/sec on SSD disk.
>
> Signed-off-by: Denis V. Lunev
> CC: Roman Kagan
> CC: Kevin
BDRVParallelsState for this.
>
> On the other hand, nothing should be done to clear inuse in
> parallels_check. Generic close will do the job right.
>
> Signed-off-by: Denis V. Lunev
> CC: Roman Kagan
> CC: Kevin Wolf
> CC: Stefan Hajnoczi
> ---
> block/parallels.c | 5
On Tue, Mar 10, 2015 at 11:51:14AM +0300, Denis V. Lunev wrote:
> Signed-off-by: Denis V. Lunev
> CC: Roman Kagan
> CC: Kevin Wolf
> CC: Stefan Hajnoczi
> ---
> tests/qemu-iotests/115 | 9 +
> tests/qemu-iotests/115.out | 19 ++-
> 2 file
pand by some significant amount at once.
>
> This patch just adds proper parameters into BDRVParallelsState and
> performs options parsing in parallels_open.
>
> Signed-off-by: Denis V. Lunev
> CC: Roman Kagan
> CC: Kevin Wolf
> CC: Stefan Hajno
mage are zeroed. Nothing else could be done here
>
> Signed-off-by: Denis V. Lunev
> CC: Roman Kagan
> CC: Kevin Wolf
> CC: Stefan Hajnoczi
> ---
> block/parallels.c | 82
> +++
> 1 file changed, 82 insertions(+)
&
V. Lunev
> CC: Roman Kagan
> CC: Kevin Wolf
> CC: Stefan Hajnoczi
> ---
> block/parallels.c | 24 +---
> 1 file changed, 17 insertions(+), 7 deletions(-)
Reviewed-by: Roman Kagan
Roman.
On Tue, Mar 10, 2015 at 11:51:17AM +0300, Denis V. Lunev wrote:
> calculate offset of the BAT entry in the image file.
>
> Signed-off-by: Denis V. Lunev
> CC: Roman Kagan
> CC: Kevin Wolf
> CC: Stefan Hajnoczi
> ---
> block/parallels.c | 15 +--
> 1
On Tue, Mar 10, 2015 at 05:44:19PM +0300, Denis V. Lunev wrote:
> On 10/03/15 17:38, Roman Kagan wrote:
> >On Tue, Mar 10, 2015 at 11:51:13AM +0300, Denis V. Lunev wrote:
> >>The software driver must set inuse field in Parallels header to
> >>0x746F6E59 when the image i
On Tue, Mar 10, 2015 at 11:51:11AM +0300, Denis V. Lunev wrote:
> This will help to avoid forward declarations for upcoming parallels_check
>
> Signed-off-by: Denis V. Lunev
> CC: Roman Kagan
> CC: Kevin Wolf
> CC: Stefan Hajnoczi
> ---
>
On Tue, Mar 10, 2015 at 11:51:16AM +0300, Denis V. Lunev wrote:
> Try to perform IO for the biggest continuous block possible.
> The performance for sequential read is increased from 220 Gb/sec to
> 360 Gb/sec for continous image on my SSD HDD.
>
> Signed-off-by: Denis V. Lunev
&g
older truncate()
> could be used as a fallback using image open options thanks to the
> previous patch.
>
> The benefit is around 15%.
Reviewed-by: Roman Kagan
Roman.
ential write is increased from 200 Gb/sec to
> 235 Gb/sec on my SSD HDD.
>
> Signed-off-by: Denis V. Lunev
> CC: Roman Kagan
> CC: Kevin Wolf
> CC: Stefan Hajnoczi
> ---
> block/parallels.c | 44
> 1 file changed, 24 insertions(+),
mage are zeroed. Nothing else could be done here
>
> Signed-off-by: Denis V. Lunev
> CC: Roman Kagan
> CC: Kevin Wolf
> CC: Stefan Hajnoczi
> ---
> block/parallels.c | 85
> +++
> 1 file changed, 85 insertions(+)
Reviewed-by: Roman Kagan
Roman.
to (ab)use MSI for SINT
delivery, though. Anyway the need to implement auto-EOI rules that out.
Thanks for the quick review, we'll try to address your comments in the
next round.
Roman.
s to the next instruction. Hence the exit,
to allow the userspace to react accordingly before reentering the guest.
Roman.
eem to be the only special one.
>
> Great. Roman, Denis, can you do this then?
Sure, gonna be in the next round.
Thanks,
Roman.
writing to the
> Again, is 'synic' intended? Hmm, I see it throughout the patch, so it
> looks intentional, but I keep trying to read it as a typo for 'sync'.
I tend to mistype it as 'cynic' as better matching what it is ;)
Note taken, we'll address that in the next round, thanks.
Roman.
.
While Andrey is testing it, I'd like to ask similar question re. MSI:
why is there a "shortcut" for KVM_IRQ_ROUTING_MSI case (which we
basically modelled after) when it would probably get handled through
->set handler in irqfd_inject() too?
Roman.
r-V SynIC MSR's
> > * setup Hyper-V SynIC evt/msg pages
> > * setup SINT's routing
> > * inject SINT's into destination vCPU by 'hyperv-synic-test-device'
> > * wait for SINT's isr's completion
> > * clear Hyper-V SynIC evt/msg pages and
t the host doesn't support it, and then check for the
property only when deciding if the relevant actions need to be taken.
Protecting vcpu exits with !host in the kernel seems to make sense, too.
We're in progress of preparing the updated patches.
Thanks,
Roman.
On Sun, Feb 07, 2016 at 11:08:07AM +0200, Michael S. Tsirkin wrote:
> On Tue, Jan 26, 2016 at 02:50:25PM +0100, Igor Mammedov wrote:
> > From: Roman Kagan
> > -static Aml *build_fdc_device_aml(void)
> > +static Aml *build_fdinfo_aml(int idx, uint8_t ty
bounds. As a result, seek fails
when QEMU denies to move the current track, but reports success anyway.
This can confuse the guest, leading to kernel panics in the guest.
Signed-off-by: John Snow
Reviewed-by: Eric Blake
Message-id: 1454106932-17236-1-git-send-email-js...@redhat.com
Roman.
On Mon, Feb 08, 2016 at 03:20:47PM -0500, John Snow wrote:
> On 02/08/2016 08:14 AM, Roman Kagan wrote:
> > On Fri, Feb 05, 2016 at 07:25:07PM +0100, Igor Mammedov wrote:
> >>> +aml_append(fdi,
> >>> +aml_int(cylinders - 1)); /* Maximum Cylinder Num
untime so I thought I wasn't
doing worse than it was.
As for what to do now, I'll try to check how tolerant the guests are of
changing the floppy geometry under them without updating _FDI, and then
decide.
Roman.
the *absolute minimum* to adapt this AML generation patch to
> John's FDC rework, and ignore all dynamic aspects (like media change).
Hopefully that'll suffice.
Roman.
AH.3D08h:_Read_Drive_Parameters
and, as I wrote in another mail, the SeaBIOS implementation here is
rather simplistic.
> Roman, does the 0xFF "empty disk geometry" hack appear to work for
> Windows 10?
>
> Maybe it's fine enough as-is, as per Laszlo's good synopsis here.
I'll test and let you know.
Roman.
On Wed, Feb 10, 2016 at 12:16:32PM -0500, John Snow wrote:
> On 02/10/2016 12:10 PM, Roman Kagan wrote:
> > Well, as I wrote in another mail, SeaBIOS, which is supposed to provide
> > the same information to int 0x13/0x08, populates it with static data
> > based only on the
n the drive,
> but the maximum capability of the specified drive".
Thanks for the info, I've re-implemented the patchset according to it
and Windows guests (w2k12, w10) seem to be happy with it, including
dynamically (re-)inserting the "diskette" of compatible size.
I'll submit the patches shortly.
Thanks,
Roman.
description into runtime-generated SSDT.
Roman Kagan (4):
i386/acpi: make floppy controller object dynamic
i386: expose floppy drive CMOS type
fdc: add function to determine drive chs limits
i386: populate floppy drive information in DSDT
Signed-off-by: Roman Kagan
Cc: Igor Mammedov
Cc: "Mich
matching the given floppy drive type.
Signed-off-by: Roman Kagan
Cc: Igor Mammedov
Cc: "Michael S. Tsirkin"
Cc: Marcel Apfelbaum
Cc: John Snow
Cc: Laszlo Ersek
Cc: Kevin O'Connor
---
changes since v7:
- use drive max c,h,s rather than the current diskette geometry
Make it possible to query the CMOS type of a floppy drive outside of the
source file where it's defined.
It will allow to properly populate the corresponding ACPI objects and
thus enable Windows on BIOS-less systems to access the floppy drives.
Signed-off-by: Roman Kagan
Cc: Igor Mammedo
VMF.
This patch adds those objects to the floppy controller in DSDT,
populating them with the information from respective QEMU objects.
Signed-off-by: Roman Kagan
Cc: Igor Mammedov
Cc: "Michael S. Tsirkin"
Cc: Marcel Apfelbaum
Cc: John Snow
Cc: Laszlo Ersek
Cc: Kevin O'Connor
---
the declarations of the fields indicating whether the contoller is
enabled.
Signed-off-by: Roman Kagan
Signed-off-by: Igor Mammedov
Reviewed-by: Marcel Apfelbaum
Cc: "Michael S. Tsirkin"
Cc: John Snow
Cc: Laszlo Ersek
Cc: Kevin O'Connor
---
changes since v7:
- remove unn
arse read where
the server would, instead of sending the full length of data in the
response payload, send a smarter variable-length package with a
scatter-gather list or a bitmap of used blocks in the beginning, and let
the client decode it and fill the gaps with zeros.
Roman.
s of the corresponding configuration
> MSR. If deemed necessary, the "catch up" mode (the timer period is
> shortened until the timer catches up) will be implemented later.
>
> Signed-off-by: Andrey Smetanin
> CC: Gleb Natapov
> CC: Paolo Bonzini
> CC: "K.
and let the message sources compete for the slot again.
>
> Signed-off-by: Andrey Smetanin
> CC: Gleb Natapov
> CC: Paolo Bonzini
> CC: "K. Y. Srinivasan"
> CC: Haiyang Zhang
> CC: Vitaly Kuznetsov
> CC: Roman Kagan
> CC: Denis V. Lunev
> CC: qemu-devel@nongnu.org
Reviewed-by: Roman Kagan
Roman.
On Fri, Nov 27, 2015 at 11:49:40AM +0100, Paolo Bonzini wrote:
[ sorry missed your message on Friday, replying now ]
> On 27/11/2015 09:12, Roman Kagan wrote:
> >> > +n = div64_u64(time_now - stimer->exp_time, stimer->count) + 1;
> >> > +stim
On Mon, Dec 14, 2015 at 04:05:03PM +0100, Igor Mammedov wrote:
> On Mon, 14 Dec 2015 11:22:39 +0300
> "Denis V. Lunev" wrote:
>
> > From: Roman Kagan
> >
> > On x86-based systems Linux determines the presence and the type of
> > floppy drives via a q
sting series under review,
> I'd suggest to put it before:
>
> if (misc->applesmc_io_base) {
No prob, will do in v2.
Thanks,
Roman.
On Mon, Jan 11, 2016 at 02:51:15PM +0100, Igor Mammedov wrote:
> On Wed, 30 Dec 2015 23:11:50 +0300
> Roman Kagan wrote:
>
> > Windows on UEFI systems is only capable of detecting the presence and
> > the type of floppy drives via corresponding ACPI objects.
> >
>
On Mon, Jan 11, 2016 at 03:47:24PM +0100, Igor Mammedov wrote:
> On Mon, 11 Jan 2016 17:26:26 +0300
> Roman Kagan wrote:
>
> > On Mon, Jan 11, 2016 at 02:51:15PM +0100, Igor Mammedov wrote:
> > > I've rebased/rewrote this series on top of current PCI tree.
> &
>which simplifies code a bit.
> Roman,
> I don't have OVMF+Win setup,
> Could you test this series and reply with Tested-by if it works?
Sure.
I just did a brief test booting qemu (master + this series) with RHEL7
OVMF off an installation DVD image for w2k8r2sp1 and w2k12r2, c
On Wed, Jan 13, 2016 at 03:36:18PM +0100, Laszlo Ersek wrote:
> On 12/30/15 21:11, Roman Kagan wrote:
> > Windows on UEFI systems is only capable of detecting the presence and
> > the type of floppy drives via corresponding ACPI objects.
>
> I'm late to the party, but
On Wed, Jan 13, 2016 at 06:49:44PM +0300, Roman Kagan wrote:
> On Wed, Jan 13, 2016 at 03:36:18PM +0100, Laszlo Ersek wrote:
> > On 12/30/15 21:11, Roman Kagan wrote:
> > > Windows on UEFI systems is only capable of detecting the presence and
> > > the type of floppy dr
. KVM already has to make the decision that the
particular vmexit is a HyperV hypercall; it appears unnatural to then
pass the data on to userspace in a generic structure and have them make
that decision again.
Roman.
ving a vcpu exit code.
> I'm afraid that in future we can end up in having 10 versions of
> KVM_EXIT_xxx_HYPERCALL with very small difference between them.
> Will it be good?
I don't see it to be a problem.
Roman.
d value, skip to the next valid one.
I think Paolo wanted to be compatible not only with the de facto
implementation in Windows Hyper-V guests, but also with the Linux driver
which followed the buggy spec and thought 0x to be invalid.
So the change is fine (as long as there's || rather than a space there
;)
Thanks,
Roman.
w exit
Why? VCPU exit codes are not a scarse resource.
> (I suggested elsewhere the existing hyper-v exit)
So far we've envisaged two reasons for VCPU exit related to hyper-v: one
for hyper-v MSRs and the other for hypercalls. Since there was a
discussion on implementing generic MSR access by Peter we thought it
wiser to introduce a new VCPU exit for hyper-v hypercalls to avoid
interfering with the MSR implementation.
Thanks,
Roman.
; >
> > Signed-off-by: Andrey Smetanin
> > Reviewed-by: Roman Kagan
> > CC: Gleb Natapov
> > CC: Paolo Bonzini
> > CC: Joerg Roedel
> > CC: "K. Y. Srinivasan"
> > CC: Haiyang Zhang
> > CC: Roman Kagan
> > CC: Denis V. Lunev
>
On Wed, Jan 20, 2016 at 06:02:25PM +0100, Paolo Bonzini wrote:
>
>
> On 20/01/2016 16:20, 'Roman Kagan' wrote:
> >> > So we should not add a new exit
> > Why? VCPU exit codes are not a scarse resource.
>
> Indeed, but grouping makes things easier t
drive stays the same, and
it's only the diskette that can change. I'd guess that the OS driver
should do the necessary revalidation on its own, without ACPI
assistance; I'll give it a try when I have some time.
But again, as you said, people are mainly interested in floppies to
bootstrap a Windows installation on virtio disks, so support of floppy
geometry update at runtime is non-critical for most users.
Thanks,
Roman.
insert different kinds
> of diskettes, which does happen in the real world.
>
> e.g. a 2.88MB capable floppy drive that can read either 1.44MB or 2.88MB
> types.
That's right; the question WRT ACPI is whether the Windows driver
expects the drive parameters or the currently inserted diskette
parameters in the ACPI object; I guess the former, so we should be OK
with that data generated once at startup.
Roman.
On Wed, Dec 16, 2015 at 11:15:55PM +0100, Igor Mammedov wrote:
> On Wed, 16 Dec 2015 20:34:55 +0300
> Roman Kagan wrote:
>
> > On Wed, Dec 16, 2015 at 05:46:57PM +0100, Igor Mammedov wrote:
> > > On Wed, 16 Dec 2015 10:45:09 +0300 "Denis V. Lunev"
> &
ff hand why a generic infrastructure wouldn't fit
in our usecase.
Roman.
and KVM_EXIT_MSR_HYPERV_SYNIC wouldn't be needed at all.
I don't immediately see why it wouldn't work for us; we'd have reused
the infrastructure if it existed when we started our work. I didn't see
Peter's patches yet; maybe we can come up with an interim solution to
fit in the merge window but expose a sufficiently generic API.
Roman.
meant here rather than struct.
I hope Andrey will help to shed some light on that when he's back in the
office on Monday; meanwhile I think this peculiarity can be ignored.
Roman.
Roman Kagan (2):
i386: expose floppy-related objects in SSDT
tests: update expected SSDT for floppy changes
Signed-off-by: Roman Kagan
Signed-off-by: Denis V. Lunev
CC: Michael S. Tsirkin
CC: Igor Mammedov
CC: Paolo Bonzini
CC: Richard Henderson
CC: Eduardo Habkost
CC: John Snow
CC
Update the expected SSDTs to reflect the changes introduced in the
previous patch.
Signed-off-by: Roman Kagan
Signed-off-by: Denis V. Lunev
CC: Michael S. Tsirkin
CC: Igor Mammedov
CC: Paolo Bonzini
CC: Richard Henderson
CC: Eduardo Habkost
CC: John Snow
CC: Kevin Wolf
---
changes since
SSDT, populating them via AML
API. For that, a couple of functions are extern-ified to facilitate
populating those objects in acpi-build.c.
Signed-off-by: Roman Kagan
Signed-off-by: Denis V. Lunev
CC: Michael S. Tsirkin
CC: Igor Mammedov
CC: Paolo Bonzini
CC: Richard Henderson
CC: Eduardo Habkos
On Tue, Dec 22, 2015 at 05:07:16PM +0200, Michael S. Tsirkin wrote:
> On Fri, Dec 18, 2015 at 10:32:29PM +0300, Roman Kagan wrote:
> > On x86-based systems Linux determines the presence and the type of
> > floppy drives via a query of a CMOS field. So does SeaBIOS when
> >
can be extended to other
mechanisms like network / cluster / SAN lock managers, etc. In
particular, it can be made to talk to virtlockd.
Roman.
On Tue, Dec 22, 2015 at 06:41:47PM +0200, Michael S. Tsirkin wrote:
> On Fri, Dec 18, 2015 at 10:32:30PM +0300, Roman Kagan wrote:
> > Update the expected SSDTs to reflect the changes introduced in the
> > previous patch.
> >
> > Signed-off-by: Roman Kagan
> &
1 - 100 of 1313 matches
Mail list logo
