, the code being inserted into the prologue
array are x86 push instructions.
I'll also try the --cpu option recommended by the previous poster.
Thanks both for your help. I'll reply with the results.
Roger
On Mar 6, 2012, at 10:54 AM, Peter Maydell wrote:
> On 6 March 2012 0
Thank you both. The --CPU option worked like a charm.
Roger
On Mar 6, 2012, at 11:14 AM, Peter Maydell wrote:
> On 6 March 2012 16:09, Roger wrote:
>> I will try the --cross-prefix option. I have a feeling this
>> will do it. I know that the prologue is being initiali
target_qemu_prologue() is from the file
tcg/i386/tcg-target.c and not from tcg/arm/tcg-target.c. Is this the right?
Thanks in advance,
Roger
> Soo, do you have any more ideas what qemu can what the (free)
alternatives> from M$/VMWare can't?
I use both QEMU and VMWare (commercial version),
but for very different reasons. Both are excellent tools that make my job
easier.
I'm primarily a Windows developer, but I do have
some Linux
to have this working. Our app is an embedded system with really crude
(read, no TCP/IP) network support. Until now, getting log files off the
guest has been a pain. So, a big THANKS to whoever wrote block-vvfat,
despite the little buglets.
Roger
block-vvfat.
define
DEBUG_IRQ_COUNT line.
You can then use command 'info irq' in the monitor console. This will show
you a count of interrupts for each IRQ.
Regards,
Roger
For example, I wrote a module of a simple memory without implementing
IRQ...
I think it is an error but it works fine... are IRQ r
Public bug reported:
Hello,
I have a nice working qemu with gpu passthrough setup.
I pass through my nvidia gtx 880m.
It boots in 4mins 18secs.
If I remove the "-vga none" switch and allow qemu to create a vga
adapter I can boot in 1min.
Why does a normal boot with the nvidia card hang for 3mins
Public bug reported:
After using qemu with gpu passthrough and then shutting down windows 7 properly
I cannot boot windows 7 a second time.
Only a full reboot of linux fixes this issue.
Qemu appears to corrupt something in linux when exiting.
I get no error messages but windows 7 never finishes b
I have been told that getting this to work with a laptop is rare.
I own an MSI GT70-2PE.
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1680679
Title:
qemu cannot run twice
Status in QEMU:
New
B
NOTE: I only get gpu passthrough to work when using seabios. UEFI will
not work with modern nvidia drivers. You get the 'code 43' error because
whatever standards nvidia expects when talking to uefi are not met by
the OVMF firmware used by qemu. This issue happens to windows users
also. They had to
NOTE: Article showing windows users updating their motherboard uefi firmware to
get around code 43:
https://devtalk.nvidia.com/default/topic/861244/cuda-setup-and-installation/geforce-740m-asus-x550l-code-43-after-windows-10-update/3
--
You received this bug notification because you are a member
GTX880M - uefi firmware built in, confirmed
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1680679
Title:
qemu cannot run twice
Status in QEMU:
Invalid
Bug description:
After using qemu with g
My uefi build script. If you see an error or issue that could cause
error 43 please confirm it:
#!/bin/bash
cd /home/dad/qemu/qemu2
sudo ./up.sh tap0
configfile=./vfio-pci1.cfg
vfiobind() {
dev="$1"
vendor=$(cat /sys/bus/pci/devices/$dev/vendor)
device=$(cat /sys/bus/pci/dev
ok, so I will research qemu and nvidia optimus. I have a custom BIOS
made by an MSI employee. I have hundreds of bios options to play with.
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1680679
Title
It works using seabios. I assume that the nvidia driver cannot see
optimus, and expect an intel card also, unless I use OVMF. I do know
that you cannot run off the intel card in windows. It's a no-no. Thanks
for the bios tip. Maybe I can hide the optimus feature from OVMF and
windows.
--
You rece
I meant to say you cannot run without the intel card in windows if you
have optimus. I am glad seabios somehow hides optimus.
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1680679
Title:
qemu canno
Thanks.
I will look into this.
On 11/15/2017 10:56 AM, misairu wrote:
> Does your Subsystem ID and Subsystem Vendor ID (of your GPU) show
> correctly inside the WindowsVM?
>
> It should be the same ID shown in your host. Otherwise that will trigger
> the Code 43 error.
>
> I once have this proble
d when
linking.
[0] http://linux.die.net/man/3/modf
[1] http://linux.die.net/man/2/timer_gettime
Signed-off-by: Roger Pau Monne
---
Makefile|4 ++--
Makefile.target |2 ++
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/Makefile b/Makefile
index 301c75e..e2c3cd4
am, and it will come really handy for
what I'm trying to do, do someone know where this has gone?
Thanks, Roger.
Stefan Hajnoczi wrote:
On Mon, Jun 18, 2012 at 3:19 PM, Roger Pau Monne wrote:
I've read from the GSoC/2010 that some work was being done creating a
query-netdev QMP command:
http://wiki.qemu.org/Google_Summer_of_Code_2010/QMP#query-netdev
The status says that "mentor has merged i
On ioreq_release the full ioreq was memset to 0, loosing all the data
and memory allocations inside the QEMUIOVector, which leads to a
memory leak. Create a new function to specifically reset ioreq.
Reported-by: Maik Wessler
Signed-off-by: Roger Pau Monné
Cc: xen-de...@lists.xen.org
Cc: Stefano
This series contains two bug fixes for xen_disk (patches 1 & 2) and
the implementation of the persistent grants extensions (patch 3), that
brings a considerable speed improvement.
Thanks for the reviews, Roger.
Files that reside on ramfs or tmpfs cannot be opened with O_DIRECT,
if first call to bdrv_open fails with errno = EINVAL, try a second
call without BDRV_O_NOCACHE.
Signed-off-by: Roger Pau Monné
Cc: xen-de...@lists.xen.org
Cc: Stefano Stabellini
Cc: Anthony PERARD
---
hw/xen_disk.c | 16
header.
Speed improvement with 15 guests performing I/O is ~450%.
Signed-off-by: Roger Pau Monné
Cc: xen-de...@lists.xen.org
Cc: Stefano Stabellini
Cc: Anthony PERARD
---
Performance comparison with the previous implementation can be seen in
the followign graph:
http://xenbits.xen.org/people/royger
Ping?
On 23/05/14 17:57, Roger Pau Monne wrote:
> On FreeBSD polling a master pty while the other end is not connected
> with G_IO_OUT only results in an endless wait. This is different from
> the Linux behaviour, that returns immediately. In order to demonstrate
> this, I have t
/test_poll.c
When executed on Linux:
$ ./test_poll
In callback
On FreeBSD instead, the callback never gets called:
$ ./test_poll
So, in order to workaround this, poll the source with G_IO_HUP (which
makes the code behave the same way on both Linux and FreeBSD).
Signed-off-by: Roger Pau Monné
Cc: Peter
behave the same way on both FreeBSD and Linux (see the commit message
for the rationale).
Thanks for the review, Roger.
ENODATA doesn't exist on FreeBSD, so ENODATA errors returned by the
hypervisor are translated to ENOENT.
Also, the error code is returned in errno if the call returns -1, so
compare the error code with the value in errno instead of the value
returned by the function.
Signed-off-by: Roge
specially important for toolstacks that use Qemu (like Xen
libxl), in order to have a unified behaviour across suported
platforms.
Signed-off-by: Roger Pau Monné
Cc: xen-de...@lists.xenproject.org
Cc: Stefano Stabellini
Cc: Anthony Liguori
Cc: Stefan Hajnoczi
---
net/tap-bs
Acknowledge this and forcefully set BDRV_O_NOCACHE and O_DIRECT in order to
force QEMU to use aligned buffers.
Signed-off-by: Roger Pau Monné
Cc: Kevin Wolf
Cc: Stefan Hajnoczi
---
block/raw-posix.c | 12
1 file changed, 12 insertions(+)
diff --git a/block/raw-posix.c b/block
El 20/10/14 a les 19.22, Kevin Wolf ha escrit:
> Am 20.10.2014 um 18:39 hat Roger Pau Monne geschrieben:
>> Acknowledge this and forcefully set BDRV_O_NOCACHE and O_DIRECT in order to
>> force QEMU to use aligned buffers.
>>
>> Signed-off-by: Roger Pau Monné
>&
Introduce a new flag to mark devices that require requests to be aligned and
replace the usage of BDRV_O_NOCACHE and O_DIRECT with this flag when
appropriate.
If a character device is used as a backend on a FreeBSD host set this flag
unconditionally.
Signed-off-by: Roger Pau Monné
Cc: Kevin
Introduce a new flag to mark devices that require requests to be aligned and
replace the usage of BDRV_O_NOCACHE and O_DIRECT with this flag when
appropriate.
If a character device is used as a backend on a FreeBSD host set this flag
unconditionally.
Signed-off-by: Roger Pau Monné
Reviewed-by
On 27/05/14 15:29, Stefan Hajnoczi wrote:
> On Fri, May 23, 2014 at 05:57:48PM +0200, Roger Pau Monne wrote:
>> The current behaviour of tap_open for BSD systems differ greatly from
>> it's Linux counterpart. Since FreeBSD supports interface renaming and
>> tap device c
On 22/07/14 14:26, Stefano Stabellini wrote:
> On Tue, 22 Jul 2014, Roger Pau Monné wrote:
>> On 27/05/14 15:29, Stefan Hajnoczi wrote:
>>> On Fri, May 23, 2014 at 05:57:48PM +0200, Roger Pau Monne wrote:
>>>> The current behaviour of tap_open for BSD systems diffe
2012/2/18 Andreas Färber :
> Am 18.02.2012 09:24, schrieb Blue Swirl:
>> On Wed, Feb 8, 2012 at 17:06, Roger Pau Monne
>> wrote:
>>> libm is used in cutils.c, but the library was not specified
>>> when linking some binaries, throwing the following err
Remove the hardcoded use of libm and instead rely on configure to
check for it. It is needed at least for qemu-ga and qemu-system.
Signed-off-by: Roger Pau Monne
---
Makefile.target |4
configure | 14 ++
2 files changed, 14 insertions(+), 4 deletions(-)
diff --git
Replace clock_gettime with timer_gettime, since at least under
uclibc 0.9.33 the clock_getttime function can be used without linking
against librt (although the manual page states the opposite).
Signed-off-by: Roger Pau Monne
---
configure |3 ++-
1 files changed, 2 insertions(+), 1
2012/2/22 Anthony Liguori :
> On 02/20/2012 06:11 AM, Roger Pau Monne wrote:
>>
>> Replace clock_gettime with timer_gettime, since at least under
>> uclibc 0.9.33 the clock_getttime function can be used without linking
>> against librt (although the manual page states
2012/2/27 Ian Campbell :
> On Thu, 2012-02-23 at 13:34 +0000, Roger Pau Monné wrote:
>> 2012/2/22 Anthony Liguori :
>> > On 02/20/2012 06:11 AM, Roger Pau Monne wrote:
>> >>
>> >> Replace clock_gettime with timer_gettime, since at least under
>> >
Replace clock_gettime with timer_gettime, since at least under
uclibc 0.9.33 the clock_getttime function can be used without linking
against librt (although the manual page states the opposite).
Signed-off-by: Roger Pau Monne
---
configure |3 ++-
1 files changed, 2 insertions(+), 1
Remove the hardcoded use of libm and instead rely on configure to
check for it. It is needed at least for qemu-ga and qemu-system.
Signed-off-by: Roger Pau Monne
---
Makefile.target |4
configure | 14 ++
2 files changed, 14 insertions(+), 4 deletions(-)
diff --git
librt is needed to link qemu-ga.
Signed-off-by: Roger Pau Monne
---
configure |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/configure b/configure
index 68eb3fa..790d495 100755
--- a/configure
+++ b/configure
@@ -2521,6 +2521,7 @@ if compile_prog ""
Replace clock_gettime with timer_gettime, since at least under
uclibc 0.9.33 the clock_getttime function can be used without linking
against librt (although the manual page states the opposite).
Signed-off-by: Roger Pau Monne
---
configure |3 ++-
1 files changed, 2 insertions(+), 1
librt is needed to link qemu-ga.
Signed-off-by: Roger Pau Monne
---
configure |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/configure b/configure
index 68eb3fa..790d495 100755
--- a/configure
+++ b/configure
@@ -2521,6 +2521,7 @@ if compile_prog ""
Remove the hardcoded use of libm and instead rely on configure to
check for it. It is needed at least for qemu-ga and qemu-system.
Signed-off-by: Roger Pau Monne
---
Makefile.target |4
configure | 14 ++
2 files changed, 14 insertions(+), 4 deletions(-)
diff --git
specially important for toolstacks that use Qemu (like Xen
libxl), in order to have a unified behaviour across suported
platforms.
Signed-off-by: Roger Pau Monné
Cc: xen-de...@lists.xenproject.org
Cc: Stefano Stabellini
Cc: Anthony Liguori
Cc: Stefan Hajnoczi
---
net/tap-bs
_open which behaves like it's Linux
counterpart, allowing Qemu to create tap interfaces and rename them.
I've decided to just fork the function instead of adding a bunch more
of preprocessor code in the original function.
Thanks for the review, Roger.
ENODATA doesn't exist on FreeBSD, so ENODATA errors returned by the
hypervisor are translated to ENOENT.
Also, the error code is returned in errno if the call returns -1, so
compare the error code with the value in errno instead of the value
returned by the function.
Signed-off-by: Roge
On 15/04/14 18:15, Anthony PERARD wrote:
> On Tue, Apr 15, 2014 at 10:33:08AM +0200, Roger Pau Monne wrote:
>> ENODATA doesn't exist on FreeBSD, so ENODATA errors returned by the
>> hypervisor are translated to ENOENT.
>>
>> Also, the error code is returned in
On 15/04/14 14:33, Egger, Christoph wrote:
> On 15.04.14 10:33, Roger Pau Monne wrote:
>> ENODATA doesn't exist on FreeBSD, so ENODATA errors returned by the
>> hypervisor are translated to ENOENT.
>>
>> Also, the error code is returned in errno if the call returns
/test_poll.c
When executed on Linux:
$ ./test_poll
In callback
On FreeBSD instead, the callback never gets called:
$ ./test_poll
So, in order to workaround this, poll the source with G_IO_HUP (which
makes the code behave the same way on both Linux and FreeBSD).
Signed-off-by: Roger Pau Monné
Cc: Peter
On 28/04/14 11:19, Paolo Bonzini wrote:
> Il 22/04/2014 19:08, Roger Pau Monne ha scritto:
>> On FreeBSD polling a master pty while the other end is not connected
>> with G_IO_OUT only results in an endless wait. This is different from
>> the Linux behaviour, that returns imm
state, so the
frontend can also free them.
Signed-off-by: Roger Pau Monné
Reported-and-Tested-by: George Dunlap
Cc: Stefano Stabellini
Cc: Kevin Wolf
Cc: Stefan Hajnoczi
Cc: George Dunlap
---
hw/block/xen_disk.c | 35 ---
1 file changed, 24 insertions(+
El 12/11/14 a les 18.41, Stefano Stabellini ha escrit:
> On Wed, 12 Nov 2014, Roger Pau Monne wrote:
>> This patch fixes two issues with persistent grants and the disk PV backend
>> (Qdisk):
>>
>> - Don't use batch mappings when using persistent grants, doing so
grants before switching to the closed state, so the
frontend can also free them.
Signed-off-by: Roger Pau Monné
Reported-by: George Dunlap
Cc: Stefano Stabellini
Cc: Kevin Wolf
Cc: Stefan Hajnoczi
Cc: George Dunlap
Cc: Konrad Rzeszutek Wilk
---
Xen release exception: this is obviously an
El 13/11/14 a les 16.36, Stefano Stabellini ha escrit:
> On Thu, 13 Nov 2014, Roger Pau Monne wrote:
>> @@ -421,7 +451,17 @@ static int ioreq_map(struct ioreq *ioreq)
>> }
>> }
>> }
>> -if (ioreq->blkdev->feature_
been added
to make sure persistent grants are only used if the whole mapped region
can be persistently mapped in the batch_maps case.
- Unmap persistent grants before switching to the closed state, so the
frontend can also free them.
Signed-off-by: Roger Pau Monné
Reported-by: George
On 27/05/14 18:18, Stefano Stabellini wrote:
> On Fri, 23 May 2014, Roger Pau Monne wrote:
>> ENODATA doesn't exist on FreeBSD, so ENODATA errors returned by the
>> hypervisor are translated to ENOENT.
>>
>> Also, the error code is returned in errno if the call ret
Ccing the maintainers.
El 23/10/15 a les 17.53, Ed Maste ha escrit:
> Acked-by: Roger Pau Monné
> Signed-off-by: Ed Maste
> ---
> As an aside this was reviewed on FreeBSD's Phabricator here:
> https://reviews.freebsd.org/D3969
>
> Resend with Signed-off-by
Due to the addition of HVMlite and the requirement to always provide a valid
xc_domain_configuration_t, xc_domain_create now always takes an arch domain
config, which can be NULL in order to mimic previous behaviour.
Signed-off-by: Roger Pau Monné
---
Cc: Stefano Stabellini
Cc: qemu-devel
xc_domain_create depending on the libxc version detected.
Signed-off-by: Roger Pau Monné
---
Cc: Stefano Stabellini
Cc: qemu-devel@nongnu.org
---
Changes since v1:
- Add a compat layer to support previous libxc versions.
- Add machinery to detect current Xen unstable (4.7).
---
configure
xc_domain_create depending on the libxc version detected.
Signed-off-by: Roger Pau Monné
---
Cc: Stefano Stabellini
Cc: qemu-devel@nongnu.org
---
Changes since v2:
- Drop the last parameter to xen_create_domain since it's always NULL ATM
and was causing build problems with older Xen ver
On 04/01/13 15:54, Stefano Stabellini wrote:
> On Thu, 3 Jan 2013, Ian Campbell wrote:
>> On Mon, 2012-12-31 at 12:16 +0000, Roger Pau Monne wrote:
>>> Files that reside on ramfs or tmpfs cannot be opened with O_DIRECT,
>>> if first call to bdrv_open fails with e
On 04/01/13 17:42, Stefano Stabellini wrote:
> On Mon, 31 Dec 2012, Roger Pau Monne wrote:
>> This protocol extension reuses the same set of grant pages for all
>> transactions between the front/back drivers, avoiding expensive tlb
>> flushes, grant table lock contention
header.
http://xenbits.xen.org/gitweb/?p=xen.git;a=blob_plain;f=xen/include/public/io/blkif.h
Speed improvement with 15 guests performing I/O is ~450%.
Signed-off-by: Roger Pau Monné
Cc: xen-de...@lists.xen.org
Cc: Stefano Stabellini
Cc: Anthony PERARD
---
Performance comparison with the previous
On 09/01/13 13:48, Stefano Stabellini wrote:
> On Tue, 8 Jan 2013, Roger Pau Monne wrote:
>> This protocol extension reuses the same set of grant pages for all
>> transactions between the front/back drivers, avoiding expensive tlb
>> flushes, grant table lock contention
ypes are not defined.
Cc: Vassili Karpov (malc)
Signed-off-by: Roger Pau Monne
---
audio/mixeng_template.h | 12
1 files changed, 12 insertions(+), 0 deletions(-)
diff --git a/audio/mixeng_template.h b/audio/mixeng_template.h
index e644c23..33e6b61 100644
--- a/audio/mixeng_te
malc escribió:
On Fri, 11 May 2012, Roger Pau Monne wrote:
This is a bug fix for rc1, although I think this bug has been present
for a long time.
If there's a bug than it's within NetBSD itself, this issue has been
discussed few times (at least twice it hink) in the past, please
NetBSD
6.0BETA.
Cc: Vassili Karpov (malc)
Signed-off-by: Roger Pau Monne
---
audio/mixeng.c | 36
audio/mixeng_template.h |4 +++-
2 files changed, 27 insertions(+), 13 deletions(-)
diff --git a/audio/mixeng.c b/audio/mixeng.c
index 5446be6
malc wrote:
On Fri, 18 May 2012, Roger Pau Monne wrote:
Split IN_T into BSIZE and ITYPE, to avoid expansion if the OS has
defined macros for the intX_t and uintX_t types. The IN_T constant is
then defined in mixeng_template.h so it can be used by the
functions/macros on this header file.
This
the domain where Qemu is
actually running.
Signed-off-by: Roger Pau Monné
Cc: xen-de...@lists.xenproject.org
Cc: Anthony PERARD
Cc: Stefano Stabellini
---
hw/xen_backend.c | 19 ++-
xen-all.c|2 +-
2 files changed, 7 insertions(+), 14 deletions(-)
diff --git a/hw
On 26/09/13 18:46, Anthony PERARD wrote:
> On Wed, Sep 18, 2013 at 09:50:58PM +0200, Roger Pau Monne wrote:
>> Qemu has several hardcoded xenstore paths that are only valid on Dom0.
>> Attempts to launch a Qemu instance (to act as a userspace backend for
>> PV disks) will fai
the domain where Qemu is
actually running.
Signed-off-by: Roger Pau Monné
Reviewed-by: Anthony PERARD
Cc: xen-de...@lists.xenproject.org
Cc: Anthony PERARD
Cc: Stefano Stabellini
---
Changes since v1:
* Update paths to match upstream Qemu.
---
hw/xen/xen_backend.c | 19
El 23/10/15 a les 16.39, Ed Maste ha escrit:
> ---
> As an aside this was reviewed on FreeBSD's Phabricator here:
> https://reviews.freebsd.org/D3969
This is missing the SoB, but provided that's added:
Acked-by: Roger Pau Monné
Thanks.
Do I need to resend this? it's been more than a month without review.
Roger.
On 13/06/14 17:35, Roger Pau Monné wrote:
> Ping?
>
> On 23/05/14 17:57, Roger Pau Monne wrote:
>> On FreeBSD polling a master pty while the other end is not connected
>> with G_IO_OUT only
t prevents MSI-X from working?
Roger.
On Tue, Mar 12, 2019 at 09:58:56AM -0400, Jason Andryuk wrote:
> On Tue, Mar 12, 2019 at 8:38 AM Marek Marczykowski-Górecki
> wrote:
> >
> > On Tue, Mar 12, 2019 at 01:04:19PM +0100, Roger Pau Monné wrote:
> > > On Mon, Mar 11, 2019 at 02:02:15PM -0400, Jason Andryuk
0001f80 with f000
Assertion failed: (p && p == memory_region_get_ram_ptr(mr)), function
xen_add_to_physmap, file
/usr/ports/sysutils/xen-tools/work/xen-4.11.1/tools/qemu-xen/hw/i386/xen/xen-hvm.c,
line 392.
This is with Xen 4.11.1.
Thanks, Roger.
eeBSD using MAP_FIXED will cause mmap to
try harder to honor the passed address.
Signed-off-by: Roger Pau Monné
---
Cc: Stefano Stabellini
Cc: Anthony Perard
Cc: Paul Durrant
Cc: Igor Druzhinin
Cc: Paolo Bonzini
Cc: Richard Henderson
Cc: Eduardo Habkost
Cc: "Michael S. Tsirkin&qu
On Fri, Mar 15, 2019 at 10:54:42AM +0100, Paul Durrant wrote:
> > -Original Message-
> > From: Roger Pau Monne [mailto:roger@citrix.com]
> > Sent: 15 March 2019 08:59
> > To: qemu-devel@nongnu.org
> > Cc: Roger Pau Monne ; Stefano Stabellini
> >
n order to run pygrub.
This is also with QEMU 7.2, as testing with upstream QEMU is blocked
ATM, so there's a chance it has already been fixed upstream.
Thanks, Roger.
Dropped xen-devel, adding back.
On Wed, Jun 28, 2023 at 02:31:39PM +0200, Roger Pau Monné wrote:
> On Fri, Jun 23, 2023 at 03:04:21PM +, osstest service owner wrote:
> > flight 181558 xen-unstable real [real]
> > http://logs.test-lab.xenproject.org/osstest/logs/181558/
>
On Tue, Jul 04, 2023 at 10:37:38AM +0100, Anthony PERARD wrote:
> On Wed, Jun 28, 2023 at 02:31:39PM +0200, Roger Pau Monné wrote:
> > On Fri, Jun 23, 2023 at 03:04:21PM +, osstest service owner wrote:
> > > flight 181558 xen-unstable real [real]
> > > http://l
t domain,
> }
> d->device_id = v;
>
> -xen_host_pci_get_dec_value(d, "irq", &v, errp);
> +xen_host_pci_get_dec_value(d, "gsi", &v, errp);
Don't you need to fallthrough to use the irq number on failure?
Otherwise passthrough won't work on older Linux versions that don't
expose the gsi node.
Thanks, Roger.
value 'feature_grant_copy' is added to recognize when the
> grant copy operation is supported by a guest.
>
> Signed-off-by: Paulina Szubarczyk
Acked-by: Roger Pau Monné
Just a couple of minor comments below, but the implementation looks fine to
me.
> ---
> Changes
rontend, otherwise it may needlessly copy data into persistently
> > granted buffers.
> >
> > Signed-off-by: Paul Durrant
>
> CC'ing Roger.
>
> It is true that using feature-persistent together with grant copies is a
> a very bad idea.
>
> But this c
On Wed, Jun 21, 2017 at 11:40:00AM +0100, Paul Durrant wrote:
> > -Original Message-
> > From: Qemu-devel [mailto:qemu-devel-
> > bounces+paul.durrant=citrix@nongnu.org] On Behalf Of Paul Durrant
> > Sent: 21 June 2017 10:36
> > To: Roger Pau Monne ;
On Wed, Jan 25, 2017 at 11:05:29AM +, Roger Pau Monné wrote:
> On Tue, Jan 24, 2017 at 01:30:02PM -0800, Stefano Stabellini wrote:
> > On Tue, 24 Jan 2017, Stefano Stabellini wrote:
> > > On Tue, 24 Jan 2017, Roger Pau Monné wrote:
> > > > Hello,
> &g
On Fri, Jan 27, 2017 at 12:13:58PM +0100, Juergen Gross wrote:
> On 24/01/17 17:42, Roger Pau Monné wrote:
> > Hello,
> >
> > The following commit:
> >
> > commit 3a6c9172ac5951e6dac2b3f6cbce3cfccdec5894
> > Author: Juergen Gross
> > Date: Tue No
ing the attack surface
> of the hypervisor. For KVM, for example, IOMMU emulation requires using
> the "split irqchip" feature to move the PIC and IOAPIC out of the kernel
> and back to QEMU.
Yes, that's right, we are increasing the surface of attack. But Xen also needs
it in order to support APIC IDs > 255 on PVH guests (that have a local APIC but
no QEMU).
Roger.
ttab_grant_copy(gnt, count, segs);
> +
> +if (rc) {
> +xen_be_printf(&ioreq->blkdev->xendev, 0,
> + "failed to copy data %d\n", rc);
> +ioreq->aio_errors++;
> +return -1;
> +} else {
> +r = 0;
> +}
Do you really need both r and rc here? I think you could just have rc and
use it below also.
> +for (i = 0; i < count; i++) {
> +if (segs[i].status != GNTST_okay) {
> +xen_be_printf(&ioreq->blkdev->xendev, 3,
> + "failed to copy data %d for gref %d, domid %d\n",
> rc,
> + ioreq->refs[i], ioreq->domids[i]);
> +ioreq->aio_errors++;
> +r = -1;
> +}
> +}
> +
> +return r;
> +}
> +
> static int ioreq_runio_qemu_aio(struct ioreq *ioreq);
>
> static void qemu_aio_complete(void *opaque, int ret)
Roger.
n for example we don't yet
support the gnttab device, so initialization of the Xen Qdisk backend can fail
(and possibly the same applies to Linux if someone decides to compile a kernel
without the gnttab device). Yet QEMU can be used without the Qdisk backend.
Roger.
On Tue, Jan 24, 2017 at 01:30:02PM -0800, Stefano Stabellini wrote:
> On Tue, 24 Jan 2017, Stefano Stabellini wrote:
> > On Tue, 24 Jan 2017, Roger Pau Monné wrote:
> > > Hello,
> > >
> > > The following commit:
> > >
> > > commit 3a6c9172
bound.
Signed-off-by: Roger Pau Monné
Reported-by: Andreas Kinzler
---
Cc: Stefano Stabellini
Cc: Anthony Perard
Cc: Jan Beulich
Cc: qemu-devel@nongnu.org
---
hw/xen/xen_pt_msi.c | 11 ---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/hw/xen/xen_pt_msi.c b/hw/xen
the parameter to "unmask", so that false -> no change to mask, true
-> unconditionally unmask.
Thanks, Roger.
iginal behavior is keep if the unmask
> > bit is not set. In this case this should be 'true' in order to keep
> > the previous behavior, which was correct for MSI.
>
> Wouldn't you want to pass the state of the mask bit here,
> rather than uniformly hard coding true or false?
Yes, I think so. I've overlooked the MSI code because I thought we
allowed QEMU to directly write to the mask register, but that's not
true, it's trapped by Xen.
Thanks, Roger.
bound.
This also requires to track the mask register for MSI interrupts, so
QEMU can also notify to Xen whether the MSI interrupt should be bound
masked or unmasked
Signed-off-by: Roger Pau Monné
Reported-by: Andreas Kinzler
---
Cc: Stefano Stabellini
Cc: Anthony Perard
Cc: Jan Beulich
Cc: qemu
sk register for MSI interrupts, so
> > QEMU can also notify to Xen whether the MSI interrupt should be bound
> > masked or unmasked
> >
> > Signed-off-by: Roger Pau Monné
> > Reported-by: Andreas Kinzler
>
> Reviewed-by: Jan Beulich
Thanks, Roger.
bound.
This also requires to track the mask register for MSI interrupts, so
QEMU can also notify to Xen whether the MSI interrupt should be bound
masked or unmasked
Signed-off-by: Roger Pau Monné
Reviewed-by: Jan Beulich
Reported-by: Andreas Kinzler
---
Cc: Stefano Stabellini
Cc: Anthony Perard
1 - 100 of 152 matches
Mail list logo
