Re: [PATCH v8 00/74] per-CPU locks

2020-03-27 Thread Robert Foley
26, 2020 at 15:30:43 -0400, Robert Foley wrote: > > This is a continuation of the series created by Emilio Cota. > > We are picking up this patch set with the goal to apply > > any fixes or updates needed to get this accepted. > > Thanks for picking this up! > > >

Re: [PATCH v2 3/4] target/i386: add the missing features for Icelake-Server CPU model

2020-03-31 Thread Robert Hoo
On Sat, 2020-03-28 at 11:06 +0800, Chenyi Qiang wrote: > Add the SHA_NI and AVX512IFMA feature bits in FEAT_7_0_EBX, RDPID > feature bit in FEAT_7_0_ECX and FSRM feature bit in FEAT_7_0_EDX. > > Signed-off-by: Chenyi Qiang > --- > target/i386/cpu.c | 10 ++ > 1 file changed, 10 insertion

qemu plugin exposure of register addresses

2020-04-02 Thread Robert Henry
n be used to subvert some aspects of the GPL. I don't understand the details of this concern, nor know where the "line in the sand" is. Robert Henry

Re: [PATCH v3 2/2] util: add util function buffer_zero_avx512()

2020-02-28 Thread Robert Hoo
On Fri, 2020-02-28 at 18:09 -0800, Richard Henderson wrote: > On 2/27/20 6:24 PM, Robert Hoo wrote: > > if ((bv & 6) == 6 && (b & bit_AVX2)) { > > cache |= CACHE_AVX2; > > } > > +

[PATCH v4 2/2] util: add util function buffer_zero_avx512()

2020-02-29 Thread Robert Hoo
. buffer_zero_avx2()). Signed-off-by: Robert Hoo --- include/qemu/cpuid.h | 3 +++ util/bufferiszero.c | 74 +--- 2 files changed, 67 insertions(+), 10 deletions(-) diff --git a/include/qemu/cpuid.h b/include/qemu/cpuid.h index 6930170..09fc245 100644 --- a

[PATCH v4 0/2] Add AVX512F optimization option and buffer_zero_avx512()

2020-02-29 Thread Robert Hoo
e the case in select_accel_fn(), and have a global variable alongside buffer_accel) 3. Changes avx512f configuration option's default status to disabled. 4. Ran 'make check-unit' on this patch, on both a Ivybridge machine and a CascadeLake machine. Robert Hoo (2): configure: add configu

[PATCH v4 1/2] configure: add configure option avx512f_opt

2020-02-29 Thread Robert Hoo
-programming-reference.pdf Signed-off-by: Robert Hoo Reviewed-by: Richard Henderson --- configure | 41 + 1 file changed, 41 insertions(+) diff --git a/configure b/configure index d57261e..a0b41ce 100755 --- a/configure +++ b/configure @@ -1395,6 +1395,11 @@ for

Re: [PATCH v2 00/14] tests/vm: Add support for aarch64 VMs

2020-03-02 Thread Robert Foley
On Mon, 2 Mar 2020 at 11:38, Alex Bennée wrote: > > > Robert Foley writes: > > > This is version 2 of the patch series to > > add support for aarch64 VMs. > > - Ubuntu 18.04 aarch64 VM > > - CentOS 8 aarch64 VM > > For now I've pulled the first 5

Re: [PATCH v2 00/14] tests/vm: Add support for aarch64 VMs

2020-03-03 Thread Robert Foley
On Tue, 3 Mar 2020 at 05:24, Alex Bennée wrote: > > We are happy to make any adjustments here. Our first set of > > refactoring here was > > aimed at making it more pythonic. Is this where the concerns are? > > I'm just worried about the fragility of multiple steps in the chain of > io we are s

[PATCH v2 0/7] accel/tcg: remove implied BQL from cpu_handle_interrupt/exception path

2020-08-19 Thread Robert Foley
emu-devel/2020-07/msg08731.html https://lists.gnu.org/archive/html/qemu-devel/2020-08/msg00044.html This patch series is based on the per-CPU locks patch: https://lists.gnu.org/archive/html/qemu-devel/2020-06/msg05314.html Our most recent WIP tree is here: https://github.com/rf972/qemu/tree/interr

[PATCH v2 6/7] target: rename all *_cpu_exec_interrupt functions to *_cpu_exec_interrupt_locked

2020-08-19 Thread Robert Foley
-devel/2020-08/msg00784.html https://lists.gnu.org/archive/html/qemu-devel/2020-08/msg01517.html https://lists.gnu.org/archive/html/qemu-devel/2020-07/msg08731.html https://lists.gnu.org/archive/html/qemu-devel/2020-08/msg00044.html Signed-off-by: Robert Foley --- target/alpha/cpu.c | 2

[PATCH v2 2/7] target/arm: add ARMCPUClass->do_interrupt_locked

2020-08-19 Thread Robert Foley
of this approach. https://lists.gnu.org/archive/html/qemu-devel/2020-08/msg00784.html https://lists.gnu.org/archive/html/qemu-devel/2020-08/msg01517.html https://lists.gnu.org/archive/html/qemu-devel/2020-07/msg08731.html https://lists.gnu.org/archive/html/qemu-devel/2020-08/msg00044.html Signed-off

[PATCH v2 1/7] target: rename all *_do_interupt functions to _do_interrupt_locked

2020-08-19 Thread Robert Foley
://lists.gnu.org/archive/html/qemu-devel/2020-08/msg01517.html https://lists.gnu.org/archive/html/qemu-devel/2020-07/msg08731.html https://lists.gnu.org/archive/html/qemu-devel/2020-08/msg00044.html Signed-off-by: Robert Foley --- hw/ppc/spapr_events.c | 2 +- target/alpha/cpu.c

[PATCH v2 3/7] target/cris: add CRISCPUClass->do_interrupt_locked

2020-08-19 Thread Robert Foley
of this approach. https://lists.gnu.org/archive/html/qemu-devel/2020-08/msg00784.html https://lists.gnu.org/archive/html/qemu-devel/2020-08/msg01517.html https://lists.gnu.org/archive/html/qemu-devel/2020-07/msg08731.html https://lists.gnu.org/archive/html/qemu-devel/2020-08/msg00044.html Signed-off

[PATCH v2 5/7] accel/tcg: Change BQL critical section in cpu_handle_interrupt

2020-08-19 Thread Robert Foley
eed to consider? Are we missing anything here? Signed-off-by: Robert Foley --- accel/tcg/cpu-exec.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/accel/tcg/cpu-exec.c b/accel/tcg/cpu-exec.c index e661635f06..499a8bdc5e 100644 --- a/accel/tcg/cpu-exec.c +++ b/accel/t

[PATCH v2 4/7] target: Push BQL on ->do_interrupt down into per-arch implementation

2020-08-19 Thread Robert Foley
u-devel/2020-08/msg00044.html Signed-off-by: Robert Foley --- accel/tcg/cpu-exec.c| 2 -- target/alpha/cpu.c | 2 +- target/alpha/cpu.h | 2 +- target/alpha/helper.c | 9 - target/arm/cpu.c| 2 +- target/arm/cpu.h

[PATCH v2 7/7] target: Push BQL on ->cpu_exec_interrupt down into per-arch implementation

2020-08-19 Thread Robert Foley
g/archive/html/qemu-devel/2020-08/msg00784.html https://lists.gnu.org/archive/html/qemu-devel/2020-08/msg01517.html https://lists.gnu.org/archive/html/qemu-devel/2020-07/msg08731.html https://lists.gnu.org/archive/html/qemu-devel/2020-08/msg00044.html Signed-off-by: Robert Foley --- accel/tcg/c

[PATCH v3 00/10] tests/vm: Add support for aarch64 VMs

2020-03-10 Thread Robert Foley
text for vm-help. - Moved the workaround for consuming the console to the end of the patch. - Added patch to validate the target of vm-build operations. Robert Foley (10): tests/vm: Add validation of target to Makefile.include tests/vm: Add configuration to basevm.py tests/vm: Added

[PATCH v3 02/10] tests/vm: Add configuration to basevm.py

2020-03-10 Thread Robert Foley
to vary on the VM being created or launched. This will for example allow for creating an aarch64 vm. Signed-off-by: Robert Foley --- tests/vm/basevm.py | 143 +++-- 1 file changed, 112 insertions(+), 31 deletions(-) diff --git a/tests/vm/basevm.py b/tests

[PATCH v3 03/10] tests/vm: Added configuration file support

2020-03-10 Thread Robert Foley
.yml. Signed-off-by: Robert Foley --- configure | 9 ++ tests/vm/Makefile.include | 6 tests/vm/basevm.py| 40 +++- tests/vm/conf_example_aarch64.yml | 51 +++ tests/vm/conf_example_x86.yml

[PATCH v3 06/10] tests/vm: allow wait_ssh() to specify command

2020-03-10 Thread Robert Foley
This allows for waiting for completion of arbitrary commands. Signed-off-by: Robert Foley --- tests/vm/basevm.py | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/tests/vm/basevm.py b/tests/vm/basevm.py index 3562a33ffa..305b839000 100644 --- a/tests/vm

[PATCH v3 01/10] tests/vm: Add validation of target

2020-03-10 Thread Robert Foley
This validation is now useful since some targets may not be valid if their dependencies are not installed. Instead of allowing the scripts to fail with missing dependencies we will fail earlier with a helpful error message. Signed-off-by: Robert Foley --- tests/vm/Makefile.include | 16

[PATCH v3 04/10] tests/vm: add --boot-console switch

2020-03-10 Thread Robert Foley
Added ability to view console during boot via --boot-console switch to basevm.py. This helps debug issues that occur during the boot sequence. Also added a new special variable to vm-build: BOOT_CONSOLE=1 will cause this new --boot-console switch to be set. Signed-off-by: Robert Foley --- tests

[PATCH v3 05/10] tests/vm: Add ability to select QEMU from current build.

2020-03-10 Thread Robert Foley
Added a new special variable QEMU_LOCAL=1, which will indicate to take the QEMU binary from the current build. Signed-off-by: Robert Foley --- tests/vm/Makefile.include | 4 tests/vm/basevm.py| 28 2 files changed, 28 insertions(+), 4 deletions

[PATCH v3 09/10] tests/vm: change scripts to use self._config

2020-03-10 Thread Robert Foley
This change converts existing scripts to using for example self.ROOT_PASS, to self._config['root_pass']. We made similar changes for GUEST_USER, and GUEST_PASS. This allows us also to remove the change in basevm.py, which adds __getattr__ for backwards compatibility. Signed-off-by: Ro

[PATCH v3 07/10] tests/vm: Added a new script for ubuntu.aarch64.

2020-03-10 Thread Robert Foley
ubuntu.aarch64 provides a script to create an Ubuntu 18.04 VM. Another new file is also added aarch64vm.py, which is a module with common methods used by aarch64 VMs, such as how to create the flash images. Signed-off-by: Robert Foley --- configure | 16 ++ tests/vm

[PATCH v3 08/10] tests/vm: Added a new script for centos.aarch64.

2020-03-10 Thread Robert Foley
centos.aarch64 creates a CentOS 8 image. Also added a new kickstart script used to build the centos.aarch64 image. Signed-off-by: Robert Foley --- tests/vm/Makefile.include| 3 +- tests/vm/centos-8-aarch64.ks | 51 tests/vm/centos.aarch64 | 226

[PATCH v3 10/10] tests/vm: Add workaround to consume console

2020-03-10 Thread Robert Foley
characters to be consumed. We also add the option of logging the console to a file. Signed-off-by: Robert Foley --- python/qemu/console_socket.py | 162 ++ python/qemu/machine.py| 12 ++- tests/vm/Makefile.include | 4 + tests/vm/basevm.py| 23

[Bug 1866892] [NEW] guest OS catches a page fault bug when running dotnet

2020-03-10 Thread Robert Henry
Public bug reported: The linux guest OS catches a page fault bug when running the dotnet application. host = metal = x86_64 host OS = ubuntu 19.10 qemu emulation, without KVM, with "tiny code generator" tcg; no plugins; built from head/master guest emulation = x86_64 guest OS = ubuntu 19.10 gues

Re: [PATCH v3 00/10] tests/vm: Add support for aarch64 VMs

2020-03-11 Thread Robert Foley
On Wed, 11 Mar 2020 at 08:04, Alex Bennée wrote: > > > Robert Foley writes: > > > This is version 3 of the patch series to > > add support for aarch64 VMs in the vm-build infrastructure. > > - Ubuntu 18.04 aarch64 VM > > - CentOS 8 aarch64 VM > > >

[PATCH v4 00/10] tests/vm: Add support for aarch64 VMs

2020-03-12 Thread Robert Foley
Makefile.include. - Corrected a dependency on a later patch in gen_cloud_init_iso(). - Changed the consume console patch to make draining the console to a buffer optional. This fixes the acceptance test issue. Robert Foley (10): tests/vm: Fix issues in gen_cloud_init_iso tests/vm: Add configuration

[PATCH v4 07/10] tests/vm: Added a new script for ubuntu.aarch64.

2020-03-12 Thread Robert Foley
ubuntu.aarch64 provides a script to create an Ubuntu 18.04 VM. Another new file is also added aarch64vm.py, which is a module with common methods used by aarch64 VMs, such as how to create the flash images. Signed-off-by: Robert Foley --- configure | 16 ++ tests/vm

[PATCH v4 03/10] tests/vm: Added configuration file support

2020-03-12 Thread Robert Foley
.yml. Signed-off-by: Robert Foley --- configure | 9 ++ tests/vm/Makefile.include | 6 tests/vm/basevm.py| 40 +++- tests/vm/conf_example_aarch64.yml | 51 +++ tests/vm/conf_example_x86.yml

[PATCH v4 05/10] tests/vm: Add ability to select QEMU from current build.

2020-03-12 Thread Robert Foley
Added a new special variable QEMU_LOCAL=1, which will indicate to take the QEMU binary from the current build. Signed-off-by: Robert Foley --- tests/vm/Makefile.include | 4 tests/vm/basevm.py| 28 2 files changed, 28 insertions(+), 4 deletions

[PATCH v4 01/10] tests/vm: Fix issues in gen_cloud_init_iso

2020-03-12 Thread Robert Foley
Fixed issue caused by dependencies on a later set of patches that have not been merged yet. Signed-off-by: Robert Foley --- tests/vm/basevm.py | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/tests/vm/basevm.py b/tests/vm/basevm.py index 8400b0e07f

[PATCH v4 09/10] tests/vm: change scripts to use self._config

2020-03-12 Thread Robert Foley
This change converts existing scripts to using for example self.ROOT_PASS, to self._config['root_pass']. We made similar changes for GUEST_USER, and GUEST_PASS. This allows us also to remove the change in basevm.py, which adds __getattr__ for backwards compatibility. Signed-off-by: Ro

[PATCH v4 02/10] tests/vm: Add configuration to basevm.py

2020-03-12 Thread Robert Foley
to vary on the VM being created or launched. This will for example allow for creating an aarch64 vm. Signed-off-by: Robert Foley --- tests/vm/basevm.py | 159 ++--- 1 file changed, 120 insertions(+), 39 deletions(-) diff --git a/tests/vm/basevm.py b/tests

[PATCH v4 06/10] tests/vm: allow wait_ssh() to specify command

2020-03-12 Thread Robert Foley
This allows for waiting for completion of arbitrary commands. Signed-off-by: Robert Foley --- tests/vm/basevm.py | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/tests/vm/basevm.py b/tests/vm/basevm.py index 3562a33ffa..305b839000 100644 --- a/tests/vm

[PATCH v4 10/10] tests/vm: Add workaround to consume console

2020-03-12 Thread Robert Foley
characters to be consumed. We also add the option of logging the console to a file. Signed-off-by: Robert Foley --- python/qemu/console_socket.py | 162 ++ python/qemu/machine.py| 23 - tests/vm/Makefile.include | 4 + tests/vm/basevm.py| 24

[PATCH v4 04/10] tests/vm: add --boot-console switch

2020-03-12 Thread Robert Foley
Added ability to view console during boot via --boot-console switch to basevm.py. This helps debug issues that occur during the boot sequence. Also added a new special variable to vm-build: BOOT_CONSOLE=1 will cause this new --boot-console switch to be set. Signed-off-by: Robert Foley --- tests

[PATCH v4 08/10] tests/vm: Added a new script for centos.aarch64.

2020-03-12 Thread Robert Foley
centos.aarch64 creates a CentOS 8 image. Also added a new kickstart script used to build the centos.aarch64 image. Signed-off-by: Robert Foley --- tests/vm/Makefile.include| 3 +- tests/vm/centos-8-aarch64.ks | 51 tests/vm/centos.aarch64 | 226

[PATCH v5 1/9] tests/vm: Add configuration to basevm.py

2020-04-30 Thread Robert Foley
to vary on the VM being created or launched. This will for example allow for creating an aarch64 vm. Signed-off-by: Robert Foley Reviewed-by: Peter Puhov --- tests/vm/basevm.py | 170 ++--- 1 file changed, 131 insertions(+), 39 deletions(-) diff --git a

[PATCH v5 3/9] tests/vm: add --boot-console switch

2020-04-30 Thread Robert Foley
Added ability to view console during boot via --boot-console switch to basevm.py. This helps debug issues that occur during the boot sequence. Also added a new special variable to vm-build: BOOT_CONSOLE=1 will cause this new --boot-console switch to be set. Signed-off-by: Robert Foley Reviewed

[PATCH v5 2/9] tests/vm: Added configuration file support

2020-04-30 Thread Robert Foley
.yml. Signed-off-by: Robert Foley Reviewed-by: Peter Puhov --- configure | 9 ++ tests/vm/Makefile.include | 6 tests/vm/basevm.py| 40 +++- tests/vm/conf_example_aarch64.yml | 51 +++ tests

[PATCH v5 5/9] tests/vm: allow wait_ssh() to specify command

2020-04-30 Thread Robert Foley
This allows for waiting for completion of arbitrary commands. Signed-off-by: Robert Foley Reviewed-by: Peter Puhov --- tests/vm/basevm.py | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/tests/vm/basevm.py b/tests/vm/basevm.py index 7b86ccd018..9f06f84974

[PATCH v5 0/9] tests/vm: Add support for aarch64 VMs

2020-04-30 Thread Robert Foley
uot; - Fix issue in CentOS aarch64 VM where python was not set up. Robert Foley (9): tests/vm: Add configuration to basevm.py tests/vm: Added configuration file support tests/vm: add --boot-console switch tests/vm: Add ability to select QEMU from current build. tests/vm: allow wait_ssh()

[PATCH v5 9/9] tests/vm: Add workaround to consume console

2020-04-30 Thread Robert Foley
characters to be consumed. We also add the option of logging the console to a file. Signed-off-by: Robert Foley Reviewed-by: Peter Puhov --- python/qemu/console_socket.py | 162 ++ python/qemu/machine.py| 23 - tests/vm/Makefile.include | 4 + tests/vm

[PATCH v5 7/9] tests/vm: Added a new script for centos.aarch64.

2020-04-30 Thread Robert Foley
centos.aarch64 creates a CentOS 8 image. Also added a new kickstart script used to build the centos.aarch64 image. Signed-off-by: Robert Foley Reviewed-by: Peter Puhov --- tests/vm/Makefile.include| 3 +- tests/vm/centos-8-aarch64.ks | 51 tests/vm/centos.aarch64 | 227

[PATCH v5 4/9] tests/vm: Add ability to select QEMU from current build.

2020-04-30 Thread Robert Foley
Added a new special variable QEMU_LOCAL=1, which will indicate to take the QEMU binary from the current build. Signed-off-by: Robert Foley Reviewed-by: Peter Puhov --- tests/vm/Makefile.include | 4 tests/vm/basevm.py| 30 +- 2 files changed, 29

[PATCH v5 6/9] tests/vm: Added a new script for ubuntu.aarch64.

2020-04-30 Thread Robert Foley
ubuntu.aarch64 provides a script to create an Ubuntu 20.04 VM. Another new file is also added aarch64vm.py, which is a module with common methods used by aarch64 VMs, such as how to create the flash images. Signed-off-by: Robert Foley Reviewed-by: Peter Puhov --- configure

[PATCH v5 8/9] tests/vm: change scripts to use self._config

2020-04-30 Thread Robert Foley
This change converts existing scripts to using for example self.ROOT_PASS, to self._config['root_pass']. We made similar changes for GUEST_USER, and GUEST_PASS. This allows us also to remove the change in basevm.py, which adds __getattr__ for backwards compatibility. Signed-off-by: Ro

Re: [PATCH v1 12/18] tests/vm: allow us to take advantage of MTTCG

2020-06-22 Thread Robert Foley
Reviewed-by: Robert Foley On Mon, 22 Jun 2020 at 10:38, Alex Bennée wrote: > > We currently limit TCG guests to -smp 1 but now we have added some > aarch64 guests we can do better when running on x86_64 hardware. > Raise the limit for TCG guests when it is safe to do so. > > S

Re: [PATCH v1 11/18] tests/vm: switch from optsparse to argparse

2020-06-22 Thread Robert Foley
Reviewed-by: Robert Foley On Mon, 22 Jun 2020 at 10:41, Alex Bennée wrote: > > optparse has been deprecated since version 3.2 and argparse is the > blessed replacement. Take the opportunity to enhance our help output > showing defaults when called. > > Signed-off-by: Alex Benn

Re: [PATCH v1 08/13] plugins: expand the bb plugin to be thread safe and track per-cpu

2020-07-09 Thread Robert Foley
Reviewed-by: Robert Foley On Thu, 9 Jul 2020 at 10:13, Alex Bennée wrote: > > While there isn't any easy way to make the inline counts thread safe > we can ensure the callback based ones are. While we are at it we can > reduce introduce a new option ("idle") to dump a

Re: [PATCH v1 10/13] tests/plugins: add -Wno-unknown-warning-option to handle -Wpsabi

2020-07-09 Thread Robert Foley
Reviewed-by: Robert Foley On Thu, 9 Jul 2020 at 10:13, Alex Bennée wrote: > > Not all compilers support the -Wpsabi (clang-9 in my case). > > Fixes: bac8d222a > Signed-off-by: Alex Bennée > --- > tests/plugin/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 dele

Re: [PULL 10/41] python/qemu: Add ConsoleSocket for optional use in QEMUMachine

2020-07-11 Thread Robert Foley
Hi, Thanks for the detailed feedback! I will look at making these changes. On Fri, 10 Jul 2020 at 15:20, John Snow wrote: > > > > On 7/7/20 3:08 AM, Alex Bennée wrote: > > From: Robert Foley > > > > > +def recv(self, n=1, sleep_delay_s=0.1): > >

[PATCH 1/2] python/qemu: Cleanup changes to ConsoleSocket

2020-07-15 Thread Robert Foley
The changes to console_socket.py and machine.py are to cleanup for pylint and flake8. Signed-off-by: Robert Foley --- python/qemu/console_socket.py | 58 +-- python/qemu/machine.py| 7 +++-- python/qemu/pylintrc | 2 +- 3 files changed, 34

[PATCH 0/2] python/qemu: follow-up changes for ConsoleSocket

2020-07-15 Thread Robert Foley
ConsoleSocket for both the draining and non-draining cases, we changed ConsoleSocket to handle the case where it does not drain the socket at all and essentially behaves like a socket. Robert Foley (2): python/qemu: Cleanup changes to ConsoleSocket python/qemu: Change ConsoleSocket to optionally drain

[PATCH 2/2] python/qemu: Change ConsoleSocket to optionally drain socket.

2020-07-15 Thread Robert Foley
ocket. Signed-off-by: Robert Foley --- python/qemu/console_socket.py | 81 +-- python/qemu/machine.py| 13 ++ 2 files changed, 54 insertions(+), 40 deletions(-) diff --git a/python/qemu/console_socket.py b/python/qemu/console_socket.py index 6a746

Re: [PATCH 1/2] python/qemu: Cleanup changes to ConsoleSocket

2020-07-16 Thread Robert Foley
On Thu, 16 Jul 2020 at 07:07, Alex Bennée wrote: > > > Robert Foley writes: > > > The changes to console_socket.py and machine.py are to > > cleanup for pylint and flake8. > > > > Signed-off-by: Robert Foley > > -

Re: [PATCH 2/2] python/qemu: Change ConsoleSocket to optionally drain socket.

2020-07-16 Thread Robert Foley
On Thu, 16 Jul 2020 at 09:42, Alex Bennée wrote: > > > +self._drain_thread = None > > +socket.socket.__init__(self, socket.AF_UNIX, socket.SOCK_STREAM) > > +self.connect(address) > > +self._drain = drain > > We end up with two variables that represent the fact we h

[PATCH v1 0/3] python/qemu: follow-up changes for ConsoleSocket

2020-07-17 Thread Robert Foley
at all and essentially behaves like a socket. Robert Foley (3): python/qemu: Cleanup changes to ConsoleSocket python/qemu: Change ConsoleSocket to optionally drain socket. tests/vm: add shutdown timeout in basevm.py python/qemu/console_socket.py | 137

[PATCH v1 1/3] python/qemu: Cleanup changes to ConsoleSocket

2020-07-17 Thread Robert Foley
The changes to console_socket.py and machine.py are to cleanup for pylint and flake8. Reviewed-by: Alex Bennée Signed-off-by: Robert Foley --- python/qemu/console_socket.py | 57 ++- python/qemu/machine.py| 7 +++-- python/qemu/pylintrc | 2

[PATCH v1 3/3] tests/vm: add shutdown timeout in basevm.py

2020-07-17 Thread Robert Foley
We are adding the shutdown timeout to solve an issue we now see where the aarch64 VMs timeout on shutdown under TCG. There is a new 3 second timeout in machine.py, which we override in basevm.py when shutting down. Signed-off-by: Robert Foley --- tests/vm/basevm.py | 15 ++- 1 file

[PATCH v1 2/3] python/qemu: Change ConsoleSocket to optionally drain socket.

2020-07-17 Thread Robert Foley
ocket. Signed-off-by: Robert Foley --- python/qemu/console_socket.py | 92 +-- python/qemu/machine.py| 13 ++--- 2 files changed, 59 insertions(+), 46 deletions(-) diff --git a/python/qemu/console_socket.py b/python/qemu/console_socket.py index 09986

Re: tests/vm infrastructure fails to notice that QEMU dying is a failure

2020-07-18 Thread Robert Foley
On Fri, 17 Jul 2020 at 18:24, John Snow wrote: > > - The real problem, though: Why is QEMU hanging? It might need a longer > timeout, or it might be having problems with the console socket again. > > (CC Robert Foley who has been working on the Console socket draining > prob

[Bug 1888431] [NEW] v5.1.0-rc1 build fails on Mac OS X 10.11.6

2020-07-21 Thread Robert Ball
ate: Tue Jul 21 20:28:59 2020 +0100 Update version for v5.1.0-rc1 release Signed-off-by: Peter Maydell rtb:qemu rtb$ Please find the full output of all the commands (from git clone of the repo, to the make) in the attached file "buildfail.txt". Thank you! Bes

[Bug 1888431] Re: v5.1.0-rc1 build fails on Mac OS X 10.11.6

2020-07-22 Thread Robert Ball
OK, thank you for pointing that out. Question, can you help me identify the most recent release/tag/commit that I could back up to which would support Mac OS X 10.11.6? Thank you! Best regards, Robert Ball -- You received this bug notification because you are a member of qemu- devel-ml

[Bug 1888431] Re: v5.1.0-rc1 build fails on Mac OS X 10.11.6

2020-07-24 Thread Robert Ball
Fantastic. Thank you Thomas, greatly appreciated! Best regards, Robert Ball -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1888431 Title: v5.1.0-rc1 build fails on Mac OS X 10.11.6 Status in

Re: [PATCH v3 06/16] accel/tcg: better handle memory constrained systems

2020-07-24 Thread Robert Foley
Reviewed-by: Robert Foley On Fri, 24 Jul 2020 at 02:49, Alex Bennée wrote: > > It turns out there are some 64 bit systems that have relatively low > amounts of physical memory available to them (typically CI system). > Even with swapping available a 1GB translation buffer that fi

[PATCH 0/2] accel/tcg: remove implied BQL from cpu_handle_interrupt/exception path

2020-07-31 Thread Robert Foley
take advantage of it in later series. This patch series is based on the per-CPU locks patch: https://lists.gnu.org/archive/html/qemu-devel/2020-06/msg05314.html Robert Foley (2): hw/core: Add bql_interrupt flag to CPUClass accel/tcg: interrupt/exception handling uses bql_interrupt flag accel

[PATCH 2/2] accel/tcg: interrupt/exception handling uses bql_interrupt flag

2020-07-31 Thread Robert Foley
the change to remove BQL when it makes sense. Signed-off-by: Robert Foley --- accel/tcg/cpu-exec.c | 34 ++ 1 file changed, 26 insertions(+), 8 deletions(-) diff --git a/accel/tcg/cpu-exec.c b/accel/tcg/cpu-exec.c index 80d0e649b2..cde27ee0bf 100644 --- a/accel

[PATCH 1/2] hw/core: Add bql_interrupt flag to CPUClass

2020-07-31 Thread Robert Foley
The new flag bql_interrupt, allows the CPUClass to determine if the BQL should be held during calls to cpu_exec_interrupt or do_interrupt. This is being added in preparation for changes in cpu_handle_interrupt, which will use this flag. Signed-off-by: Robert Foley --- hw/core/cpu.c | 1

Re: [PATCH 1/2] hw/core: Add bql_interrupt flag to CPUClass

2020-07-31 Thread Robert Foley
On Fri, 31 Jul 2020 at 13:44, Eduardo Habkost wrote: > > > > +static inline void cpu_class_disable_bql_interrupt(CPUClass *cc) > > +{ > > +cc->bql_interrupt = false; > > +} > > Class data is not supposed to change outside class_init. Why do > you need this function? I don't see it being used

Re: [PATCH 2/2] accel/tcg: interrupt/exception handling uses bql_interrupt flag

2020-07-31 Thread Robert Foley
On Fri, 31 Jul 2020 at 14:02, Paolo Bonzini wrote: > > On 31/07/20 14:51, Robert Foley wrote: > > This change removes the implied BQL from the cpu_handle_interrupt, > > and cpu_handle_exception paths. We can now select per-arch if > > the BQL is needed or not by usin

Re: [EXTERNAL] Re: ia-32/ia-64 fxsave64 instruction behavior when saving mmx

2020-07-31 Thread Robert Henry
On 7/31/20 1:34 PM, Eduardo Habkost wrote: > On Mon, Jun 01, 2020 at 08:19:51AM +0200, Philippe Mathieu-Daudé wrote: >> Hi Robert. >> >> Top-posting is difficult to read on technical lists, >> it's better to reply inline. >> >> Cc'ing the X86 FPU

[PATCH v1 04/21] target/avr: add BQL to do_interrupt and cpu_exec_interrupt

2020-08-05 Thread Robert Foley
reasoning/benefits of this approach. https://lists.gnu.org/archive/html/qemu-devel/2020-07/msg08731.html https://lists.gnu.org/archive/html/qemu-devel/2020-08/msg00044.html Signed-off-by: Robert Foley --- target/avr/helper.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a

[PATCH v1 02/21] target/alpha: add BQL to do_interrupt and cpu_exec_interrupt

2020-08-05 Thread Robert Foley
reasoning/benefits of this approach. https://lists.gnu.org/archive/html/qemu-devel/2020-07/msg08731.html https://lists.gnu.org/archive/html/qemu-devel/2020-08/msg00044.html Signed-off-by: Robert Foley --- target/alpha/helper.c | 15 +-- 1 file changed, 13 insertions(+), 2 deletions(-) diff

[PATCH v1 01/21] accel/tcg: Change interrupt/exception handling to remove implied BQL

2020-08-05 Thread Robert Foley
This change removes the implied BQL from the cpu_handle_interrupt, and cpu_handle_exception paths. This BQL acquire is being pushed down into the per arch implementation. Signed-off-by: Robert Foley --- accel/tcg/cpu-exec.c | 19 +++ 1 file changed, 11 insertions(+), 8 deletions

[PATCH v1 00/21] accel/tcg: remove implied BQL from cpu_handle_interrupt/exception path

2020-08-05 Thread Robert Foley
patch series is based on the per-CPU locks patch: https://lists.gnu.org/archive/html/qemu-devel/2020-06/msg05314.html Robert Foley (21): accel/tcg: Change interrupt/exception handling to remove implied BQL target/alpha: add BQL to do_interrupt and cpu_exec_interrupt target/arm: add BQL to

[PATCH v1 03/21] target/arm: add BQL to do_interrupt and cpu_exec_interrupt

2020-08-05 Thread Robert Foley
reasoning/benefits of this approach. https://lists.gnu.org/archive/html/qemu-devel/2020-07/msg08731.html https://lists.gnu.org/archive/html/qemu-devel/2020-08/msg00044.html Signed-off-by: Robert Foley --- target/arm/cpu.c| 13 ++--- target/arm/helper.c | 17 - 2 files changed

[PATCH v1 10/21] target/microblaze: add BQL to do_interrupt and cpu_exec_interrupt

2020-08-05 Thread Robert Foley
reasoning/benefits of this approach. https://lists.gnu.org/archive/html/qemu-devel/2020-07/msg08731.html https://lists.gnu.org/archive/html/qemu-devel/2020-08/msg00044.html Signed-off-by: Robert Foley --- target/microblaze/helper.c | 20 1 file changed, 20 insertions(+) diff --git a

[PATCH v1 06/21] target/hppa: add BQL to do_interrupt and cpu_exec_interrupt

2020-08-05 Thread Robert Foley
reasoning/benefits of this approach. https://lists.gnu.org/archive/html/qemu-devel/2020-07/msg08731.html https://lists.gnu.org/archive/html/qemu-devel/2020-08/msg00044.html Signed-off-by: Robert Foley --- target/hppa/int_helper.c | 25 +++-- 1 file changed, 19 insertions(+), 6

[PATCH v1 12/21] target/nios2: add BQL to do_interrupt and cpu_exec_interrupt

2020-08-05 Thread Robert Foley
reasoning/benefits of this approach. https://lists.gnu.org/archive/html/qemu-devel/2020-07/msg08731.html https://lists.gnu.org/archive/html/qemu-devel/2020-08/msg00044.html Signed-off-by: Robert Foley --- target/nios2/cpu.c| 3 +++ target/nios2/helper.c | 8 +++- 2 files changed, 10 insertions

[PATCH v1 11/21] target/mips: add BQL to do_interrupt and cpu_exec_interrupt

2020-08-05 Thread Robert Foley
reasoning/benefits of this approach. https://lists.gnu.org/archive/html/qemu-devel/2020-07/msg08731.html https://lists.gnu.org/archive/html/qemu-devel/2020-08/msg00044.html Signed-off-by: Robert Foley --- target/mips/helper.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/target/mips

[PATCH v1 05/21] target/cris: add BQL to do_interrupt and cpu_exec_interrupt

2020-08-05 Thread Robert Foley
reasoning/benefits of this approach. https://lists.gnu.org/archive/html/qemu-devel/2020-07/msg08731.html https://lists.gnu.org/archive/html/qemu-devel/2020-08/msg00044.html Signed-off-by: Robert Foley --- target/cris/helper.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/target

[PATCH v1 15/21] target/riscv: add BQL to do_interrupt and cpu_exec_interrupt

2020-08-05 Thread Robert Foley
reasoning/benefits of this approach. https://lists.gnu.org/archive/html/qemu-devel/2020-07/msg08731.html https://lists.gnu.org/archive/html/qemu-devel/2020-08/msg00044.html Signed-off-by: Robert Foley --- target/riscv/cpu_helper.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/target

[PATCH v1 09/21] target/m68k: add BQL to do_interrupt and cpu_exec_interrupt

2020-08-05 Thread Robert Foley
reasoning/benefits of this approach. https://lists.gnu.org/archive/html/qemu-devel/2020-07/msg08731.html https://lists.gnu.org/archive/html/qemu-devel/2020-08/msg00044.html Signed-off-by: Robert Foley --- target/m68k/op_helper.c | 5 + 1 file changed, 5 insertions(+) diff --git a/target/m68k

[PATCH v1 13/21] target/openrisc: add BQL to do_interrupt and cpu_exec_interrupt

2020-08-05 Thread Robert Foley
reasoning/benefits of this approach. https://lists.gnu.org/archive/html/qemu-devel/2020-07/msg08731.html https://lists.gnu.org/archive/html/qemu-devel/2020-08/msg00044.html Signed-off-by: Robert Foley --- target/openrisc/interrupt.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/target

[PATCH v1 07/21] target/i386: add BQL to do_interrupt and cpu_exec_interrupt

2020-08-05 Thread Robert Foley
reasoning/benefits of this approach. https://lists.gnu.org/archive/html/qemu-devel/2020-07/msg08731.html https://lists.gnu.org/archive/html/qemu-devel/2020-08/msg00044.html Signed-off-by: Robert Foley --- target/i386/seg_helper.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a

[PATCH v1 19/21] target/sparc: add BQL to do_interrupt and cpu_exec_interrupt

2020-08-05 Thread Robert Foley
reasoning/benefits of this approach. https://lists.gnu.org/archive/html/qemu-devel/2020-07/msg08731.html https://lists.gnu.org/archive/html/qemu-devel/2020-08/msg00044.html Signed-off-by: Robert Foley --- target/sparc/cpu.c | 3 +++ target/sparc/int32_helper.c | 13 - 2 files

[PATCH v1 18/21] target/sh4: add BQL to do_interrupt and cpu_exec_interrupt

2020-08-05 Thread Robert Foley
reasoning/benefits of this approach. https://lists.gnu.org/archive/html/qemu-devel/2020-07/msg08731.html https://lists.gnu.org/archive/html/qemu-devel/2020-08/msg00044.html Signed-off-by: Robert Foley --- target/sh4/helper.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git

[PATCH v1 20/21] target/unicore32: add BQL to do_interrupt and cpu_exec_interrupt

2020-08-05 Thread Robert Foley
reasoning/benefits of this approach. https://lists.gnu.org/archive/html/qemu-devel/2020-07/msg08731.html https://lists.gnu.org/archive/html/qemu-devel/2020-08/msg00044.html Signed-off-by: Robert Foley --- target/unicore32/helper.c | 3 +++ target/unicore32/softmmu.c | 7 +++ 2 files changed, 10

[PATCH v1 14/21] target/ppc: add BQL to do_interrupt and cpu_exec_interrupt

2020-08-05 Thread Robert Foley
reasoning/benefits of this approach. https://lists.gnu.org/archive/html/qemu-devel/2020-07/msg08731.html https://lists.gnu.org/archive/html/qemu-devel/2020-08/msg00044.html Signed-off-by: Robert Foley --- target/ppc/excp_helper.c | 5 + 1 file changed, 5 insertions(+) diff --git a/target/ppc

[PATCH v1 08/21] target/lm32: add BQL to do_interrupt and cpu_exec_interrupt

2020-08-05 Thread Robert Foley
reasoning/benefits of this approach. https://lists.gnu.org/archive/html/qemu-devel/2020-07/msg08731.html https://lists.gnu.org/archive/html/qemu-devel/2020-08/msg00044.html Signed-off-by: Robert Foley --- target/lm32/helper.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/target/lm32

[PATCH v1 17/21] target/s390x: add BQL to do_interrupt and cpu_exec_interrupt

2020-08-05 Thread Robert Foley
reasoning/benefits of this approach. https://lists.gnu.org/archive/html/qemu-devel/2020-07/msg08731.html https://lists.gnu.org/archive/html/qemu-devel/2020-08/msg00044.html Signed-off-by: Robert Foley --- target/s390x/excp_helper.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff

[PATCH v1 16/21] target/rx: add BQL to do_interrupt and cpu_exec_interrupt

2020-08-05 Thread Robert Foley
reasoning/benefits of this approach. https://lists.gnu.org/archive/html/qemu-devel/2020-07/msg08731.html https://lists.gnu.org/archive/html/qemu-devel/2020-08/msg00044.html Signed-off-by: Robert Foley --- target/rx/helper.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/target/rx

[PATCH v1 21/21] target/xtensa: add BQL to do_interrupt and cpu_exec_interrupt

2020-08-05 Thread Robert Foley
reasoning/benefits of this approach. https://lists.gnu.org/archive/html/qemu-devel/2020-07/msg08731.html https://lists.gnu.org/archive/html/qemu-devel/2020-08/msg00044.html Signed-off-by: Robert Foley --- target/xtensa/exc_helper.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/target/xtensa

Re: [PATCH v1 02/21] target/alpha: add BQL to do_interrupt and cpu_exec_interrupt

2020-08-05 Thread Robert Foley
On Wed, 5 Aug 2020 at 15:18, Richard Henderson wrote: > > On 8/5/20 11:12 AM, Robert Foley wrote: > > @@ -299,8 +299,12 @@ void alpha_cpu_do_interrupt(CPUState *cs) > > { > > AlphaCPU *cpu = ALPHA_CPU(cs); > > CPUAlphaState *env = &cpu->env;

Re: [PATCH v1 01/21] accel/tcg: Change interrupt/exception handling to remove implied BQL

2020-08-06 Thread Robert Foley
On Thu, 6 Aug 2020 at 05:22, Paolo Bonzini wrote: > > On 05/08/20 21:18, Richard Henderson wrote: > > On 8/5/20 11:12 AM, Robert Foley wrote: > >> This change removes the implied BQL from the cpu_handle_interrupt, > >> and cpu_handle_exception paths. This BQL acq

<    1   2   3   4   5   6   7   8   9   10   >