Re: [Qemu-devel] [PATCH v3 1/3] x86: Data structure changes to support MSR based features

2018-08-17 Thread Robert Hoo
On Sat, 2018-08-18 at 11:10 +0800, Robert Hoo wrote: > On Fri, 2018-08-17 at 00:10 -0300, Eduardo Habkost wrote: > [trim...] > > > + > > > typedef struct FeatureWordInfo { > > > -/* feature flags names are taken from "Intel Processor > > > Ide

Re: [Qemu-devel] [PATCH v3 2/3] kvm: Add support to KVM_GET_MSR_FEATURE_INDEX_LIST and KVM_GET_MSRS system ioctl

2018-08-18 Thread Robert Hoo
On Fri, 2018-08-17 at 10:18 -0300, Eduardo Habkost wrote: > Thanks for the patch, comments below: > > On Fri, Aug 10, 2018 at 10:06:28PM +0800, Robert Hoo wrote: > > Add kvm_get_supported_feature_msrs() to get supported MSR feature index > > list. > > Add kvm_arch_get

Re: [Qemu-devel] [PATCH v3 3/3] Change other funcitons referring to feature_word_info[]

2018-08-18 Thread Robert Hoo
On Fri, 2018-08-17 at 10:28 -0300, Eduardo Habkost wrote: > On Fri, Aug 10, 2018 at 10:06:29PM +0800, Robert Hoo wrote: > > Add an util function feature_word_description(), which help construct the > > string > > describing the feature word (bot

Re: [Qemu-devel] [PATCH v3 3/3] Change other funcitons referring to feature_word_info[]

2018-08-18 Thread Robert Hoo
On Fri, 2018-08-17 at 17:52 +0200, Paolo Bonzini wrote: > On 10/08/2018 16:06, Robert Hoo wrote: > > x86_cpu_get_feature_words(): limit to CPUID_FEATURE_WORD only. > > This should also grow support for MSR feature words. > > My suggestion is that you add another patch after

Re: [Qemu-devel] [PATCH v3 2/3] kvm: Add support to KVM_GET_MSR_FEATURE_INDEX_LIST and KVM_GET_MSRS system ioctl

2018-08-22 Thread Robert Hoo
On Sat, 2018-08-18 at 12:05 -0300, Eduardo Habkost wrote: > > > > > > > > int kvm_has_pit_state2(void) > > > > { > > > > @@ -420,6 +421,41 @@ uint32_t kvm_arch_get_supported_cpuid(KVMState *s, > > > > uint32_t function, > > > > return ret; > > > > } > > > > > > > > +uint32_t kvm_arch_

[Qemu-devel] [Bug 1769189] Re: Issue with qemu 2.12.0 + SATA

2018-06-14 Thread Robert Hu
Hi, Where can I find the fix patch at present? -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1769189 Title: Issue with qemu 2.12.0 + SATA Status in QEMU: Fix Committed Bug description: [EDIT:

[Qemu-devel] [Bug 1686350] [NEW] [KVM] The qemu ‘-cpu’ option not have skylake server cpu model

2017-04-26 Thread Robert Hu
Public bug reported: Environment: --- KVM commit/branch: bd17117b/next Qemu commit/branch: cd1ea508/master Host OS: RHEL7.3 ia32e Host Kernel:4.11.0-rc3 Bug detailed description: -- In latest qemu commit the qemu still not have skylake server cpu mod

[Qemu-devel] [Bug 1656234] [NEW] Qemu core dumped if using virtio-net

2017-01-13 Thread Robert Hu
Public bug reported: System Environment === Qemu commit/branch: e92fbc75 Host OS: RHEL7.2 ia32e Host Kernel: 4.9.0 Guest OS: RHEL7.2 ia32e Guest Kernel: 4.9.0 Bug detailed description === While create a kvm guest using virtio-net, the qemu will core dump with showing "Aborted (core dumpe

[Qemu-devel] bus= and host= documentation missing virtio-net-pci

2018-02-14 Thread Robert White
I need to hook up a net device via virtio-net-pci such as 03:10.1 and there is documentation for addr=10.1 but there is no information on how to provide the 03 part. There's clearly a bus= item but nothing seems to work. I've tried bus=3 bus=03 bus=pcie.3 and a good number of other things. The su

[Qemu-devel] [Bug 1738840] [NEW] qemu-img convert qcow2 to raw fails on OS X

2017-12-18 Thread Robert Marklund
Public bug reported: I try to convert a image from qcow2 to raw and the result is a not bootable image. I dont know if it is a bug in qemu-img convert or with the image it self. See this error report for better readability: https://github.com/coreos/bugs/issues/1121#issuecomment-351968518 As a

[Qemu-devel] [Bug 1738840] Re: qemu-img convert qcow2 to raw fails on OS X

2017-12-19 Thread Robert Marklund
I gave it a try here: http://termbin.com/ufv4 Its only the first 4096 bytes. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1738840 Title: qemu-img convert qcow2 to raw fails on OS X Status in QEM

[Qemu-devel] [Bug 1738840] Re: qemu-img convert qcow2 to raw fails on OS X

2017-12-19 Thread Robert Marklund
I tried to make a quick grep of the start of the disk in the "bad" raw image and it does not exist anywhere so there is more ot it then just a offset issue. rg -M 20 -a --encoding=ascii '\xeb\x63\x90\x00\x00\x00\x00\x00\x00\x00\x00\x00' coreos_production_openstack_image.bin.apfs or rg -M 20 -a -

[Qemu-devel] [Bug 1738840] Re: qemu-img convert qcow2 to raw fails on OS X

2017-12-19 Thread Robert Marklund
Adding "-S 0" on the APFS convert only makes the file 8.5Gb but its still "bad". -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1738840 Title: qemu-img convert qcow2 to raw fails on OS X Status in

[Qemu-devel] [Bug 1738840] Re: qemu-img convert qcow2 to raw fails on OS X

2017-12-19 Thread Robert Marklund
The image apfs2 here is created with "-S 0"and the .bin is a working one generated on a ubuntu machine. Strange thing is that this say they are identical: $ time qemu-img compare -f qcow2 -F raw coreos_production_openstack_image.img.org coreos_production_openstack_image.bin.apfs Images are iden

[Qemu-devel] [Bug 1748434] [NEW] Possibly wrong GICv3 behavior when secure enabled

2018-02-09 Thread Robert Pasz
Public bug reported: I an tried arm-aarch64 interrupt routing to EL3, by SCR_EL3.FIQ=1. First I am started QEMU with secure=on and GICv3 support. I programmed secure and non-secure timers and set-up appropriate interrupts.Secure timer to be GRP1_Secure and non-secure timer to be GRP1_NonSecure.

[Qemu-devel] [Bug 1748434] Re: Possibly wrong GICv3 behavior when secure enabled

2018-02-09 Thread Robert Pasz
see possible solution, in #if 0 is original code in #else see possible fix static uint64_t icc_pmr_read(CPUARMState *env, const ARMCPRegInfo *ri) #if 0 // KIURCHER: bug - shall be opposite; see ARM specification if (value & 0x80) { /* Secure priorities not visible to NS */

Re: [PATCH 00/10] target/i386/tcg: fixes for seg_helper.c

2024-07-10 Thread Robert Henry
I have only skimmed the diffs. Your knowledge of the deep semantics, gained by close differential reading of intel and amd docs, is truly amazing. Many thanks for pushing this through! I have 2 nits, perhaps stylistic only. For code like "sp -= 2" or "sp += 2" followed or preceded by a write to

[Bug 1866892] Re: guest OS catches a page fault bug when running dotnet

2020-03-24 Thread Robert Henry
I've stepped/nexted from the helper_iret_protected, going deep into the bowels of the TLB, MMU and page table engine. None of which I understand. The helper_ret_protected faults in the first POPQ_RA. I'll investigate the value of sp at the time of the POPQ_RA. Here's the POPQ_RA in i386/seg_help

[Bug 1866892] Re: guest OS catches a page fault bug when running dotnet

2020-03-24 Thread Robert Henry
Peter: I think your intuition is right. The POPQ_RA (pop quad, passing through return address handle) is only called from helper_ret_protected, and it suspiciously calls cpu_ldq_kernel_ra which calls cpu_mmu_index_kernel which only is prepared for kernel space iretq (and of course the substring _k

[PATCH 2/2] util/bufferiszero: improve avx2 accelerator

2020-03-24 Thread Robert Hoo
By increasing avx2 length_to_accel to 128, we can simplify its logic and reduce a branch. The authorship of this patch actually belongs to Richard Henderson , I just fix a boudary case on his original patch. Suggested-by: Richard Henderson Signed-off-by: Robert Hoo --- util/bufferiszero.c

[PATCH 1/2] util/bufferiszero: assign length_to_accel value for each accelerator case

2020-03-24 Thread Robert Hoo
Because in unit test, init_accel() will be called several times, each with different accelerator type. Signed-off-by: Robert Hoo --- util/bufferiszero.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/util/bufferiszero.c b/util/bufferiszero.c index 6639035..b801253 100644 --- a/util

[Bug 1866892] Re: guest OS catches a page fault bug when running dotnet

2020-03-25 Thread Robert Henry
The change should only be dynamically visible when doing an iretq from and to the same protection level, AFAICT. The code clearly[sic] works now for the interrupt return that is used by the linux kernel, presumably {from=kernel, to=kernel} or {from=kernel, to=user}. I would claim that to make this

RE: [PATCH 2/2] util/bufferiszero: improve avx2 accelerator

2020-03-25 Thread Hu, Robert
(Don't know why my Linux-Evolution missed this mail.) > -Original Message- > From: Eric Blake > Sent: Wednesday, March 25, 2020 20:54 > To: Robert Hoo ; qemu-devel@nongnu.org; > pbonz...@redhat.com; richard.hender...@linaro.org > Cc: Hu, Robert > Sub

Re: [PATCH 2/2] util/bufferiszero: improve avx2 accelerator

2020-03-26 Thread Robert Hoo
On Thu, 2020-03-26 at 08:26 -0500, Eric Blake wrote: > On 3/25/20 9:09 PM, Hu, Robert wrote: > > (Don't know why my Linux-Evolution missed this mail.) > > > -Original Message- > > > Long line; it's nice to wrap commit messages around column 70 or >

[PATCH v8 00/74] per-CPU locks

2020-03-26 Thread Robert Foley
of the BQL cpus-common: release BQL earlier in run_on_cpu cpu: add async_run_on_cpu_no_bql cputlb: queue async flush jobs without the BQL Paolo Bonzini (4): ppc: use cpu_reset_interrupt i386: use cpu_reset_interrupt s390x: use cpu_reset_interrupt openrisc: use cpu_reset_interrupt

[PATCH v8 04/74] cpu: make qemu_work_cond per-cpu

2020-03-26 Thread Robert Foley
f-by: Emilio G. Cota Signed-off-by: Robert Foley --- cpus-common.c | 72 ++- cpus.c| 2 +- hw/core/cpu.c | 1 + include/hw/core/cpu.h | 6 ++-- 4 files changed, 63 insertions(+), 18 deletions(-) diff --git a/cpus-comm

[PATCH v8 01/74] cpu: convert queued work to a QSIMPLEQ

2020-03-26 Thread Robert Foley
From: "Emilio G. Cota" Instead of open-coding it. While at it, make sure that all accesses to the list are performed while holding the list's lock. Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley ---

[PATCH v8 03/74] cpu: introduce cpu_mutex_lock/unlock

2020-03-26 Thread Robert Foley
vCPUs are locked by the same thread, which explains why the bitmap is introduced here. Reviewed-by: Richard Henderson Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- cpus.c| 48 +-- include/h

[PATCH v8 06/74] cpu: introduce process_queued_cpu_work_locked

2020-03-26 Thread Robert Foley
From: "Emilio G. Cota" This completes the conversion to cpu_mutex_lock/unlock in the file. Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- cpus-common.c | 17 +++-- 1 file changed, 11 insert

[PATCH v8 02/74] cpu: rename cpu->work_mutex to cpu->lock

2020-03-26 Thread Robert Foley
From: "Emilio G. Cota" This lock will soon protect more fields of the struct. Give it a more appropriate name. Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- cpus-common.c | 14 +++-

[PATCH v8 07/74] cpu: make per-CPU locks an alias of the BQL in TCG rr mode

2020-03-26 Thread Robert Foley
ex_destroy, and call from cpu_common_finalize, to avoid destroying qemu_global_mutex, when cpu mutex is destroyed. Reviewed-by: Alex Bennée Reviewed-by: Richard Henderson Signed-off-by: Emilio G. Cota [RF: Fixed destroy issue, added cpu_mutex_destroy.] Signed-off-by: Robert Foley ---

[PATCH v8 09/74] ppc: convert to helper_cpu_halted_set

2020-03-26 Thread Robert Foley
From: "Emilio G. Cota" Cc: David Gibson Cc: qemu-...@nongnu.org Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Acked-by: David Gibson Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- target/ppc/translate.c | 6 ++ 1 file changed, 2 insertions(+), 4

[PATCH v8 08/74] tcg-runtime: define helper_cpu_halted_set

2020-03-26 Thread Robert Foley
From: "Emilio G. Cota" Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- accel/tcg/tcg-runtime.c | 7 +++ accel/tcg/tcg-runtime.h | 2 ++ 2 files changed, 9 insertions(+) diff --git a/accel/tcg/tcg-runtime

[PATCH v8 05/74] cpu: move run_on_cpu to cpus-common

2020-03-26 Thread Robert Foley
From: "Emilio G. Cota" We don't pass a pointer to qemu_global_mutex anymore. Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- cpus-common.c | 2 +- cpus.c| 5 - include/hw/

[PATCH v8 10/74] cris: convert to helper_cpu_halted_set

2020-03-26 Thread Robert Foley
From: "Emilio G. Cota" And fix the temp leak along the way. Cc: "Edgar E. Iglesias" Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- target/cris/translate.c | 5 +++-- 1 file changed, 3 insert

[PATCH v8 19/74] ppc: convert to cpu_halted

2020-03-26 Thread Robert Foley
f not already held) from cpu_has_work. Cc: David Gibson Cc: qemu-...@nongnu.org Reviewed-by: Richard Henderson Acked-by: David Gibson Signed-off-by: Emilio G. Cota [RF: hw/ppc/spapr_hcall.c, spapr_rtas.c more conversions] Signed-off-by: Robert Foley --- hw/ppc/e500.c

[PATCH v8 12/74] m68k: convert to helper_cpu_halted_set

2020-03-26 Thread Robert Foley
From: "Emilio G. Cota" Cc: Laurent Vivier Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Reviewed-by: Laurent Vivier Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- target/m68k/translate.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) di

[PATCH v8 22/74] lm32: convert to cpu_halted

2020-03-26 Thread Robert Foley
From: "Emilio G. Cota" Cc: Michael Walle Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- target/lm32/op_helper.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target/lm32/op_helper.

[PATCH v8 11/74] hppa: convert to helper_cpu_halted_set

2020-03-26 Thread Robert Foley
From: "Emilio G. Cota" Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- target/hppa/translate.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/target/hppa/translate.c b/target/hppa/transla

[PATCH v8 13/74] alpha: convert to helper_cpu_halted_set

2020-03-26 Thread Robert Foley
From: "Emilio G. Cota" Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- target/alpha/translate.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/target/alpha/translate.c b/target/alpha/t

[PATCH v8 40/74] i386: convert to cpu_interrupt_request

2020-03-26 Thread Robert Foley
From: "Emilio G. Cota" Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- target/i386/cpu.c| 2 +- target/i386/helper.c | 4 ++-- target/i386/svm_helper.c | 4 ++-- 3 files changed, 5 insertions(+), 5

[PATCH v8 24/74] mips: convert to cpu_halted

2020-03-26 Thread Robert Foley
From: "Emilio G. Cota" Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota [RF: Converted code in target/mips/kvm.c to cpu_halted.] Signed-off-by: Robert Foley --- hw/mips/cps.c| 2 +- hw/misc/mips_itu.c | 4 ++-- target/mips/cp

[PATCH v8 14/74] microblaze: convert to helper_cpu_halted_set

2020-03-26 Thread Robert Foley
From: "Emilio G. Cota" Cc: "Edgar E. Iglesias" Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- target/microblaze/translate.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git

[PATCH v8 16/74] tcg-runtime: convert to cpu_halted_set

2020-03-26 Thread Robert Foley
From: "Emilio G. Cota" Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- accel/tcg/tcg-runtime.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/accel/tcg/tcg-runtime.c b/accel/tcg/tcg-runti

[PATCH v8 41/74] i386/kvm: convert to cpu_interrupt_request

2020-03-26 Thread Robert Foley
From: "Emilio G. Cota" Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- target/i386/kvm.c | 58 --- 1 file changed, 35 insertions(+), 23 deletions(-) diff --git a/t

[PATCH v8 18/74] arm: convert to cpu_halted

2020-03-26 Thread Robert Foley
From: "Emilio G. Cota" Cc: Andrzej Zaborowski Cc: Peter Maydell Cc: qemu-...@nongnu.org Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- hw/arm/omap1.c| 4 ++-- hw/arm/pxa2xx_gpio.c | 2

[PATCH v8 32/74] cpu: convert to cpu_halted

2020-03-26 Thread Robert Foley
From: "Emilio G. Cota" This finishes the conversion to cpu_halted. Reviewed-by: Alex Bennée Reviewed-by: Richard Henderson Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- accel/tcg/cpu-exec.c | 2 +- cpus.c | 4 ++-- hw/core/cpu.c

[PATCH v8 42/74] i386/hax-all: convert to cpu_interrupt_request

2020-03-26 Thread Robert Foley
From: "Emilio G. Cota" Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota [RF: Converted new code to cpu_interrupt_request] Signed-off-by: Robert Foley --- target/i386/hax-all.c | 34 +++--- 1 file changed, 19 inserti

[PATCH v8 15/74] cpu: define cpu_halted helpers

2020-03-26 Thread Robert Foley
From: "Emilio G. Cota" cpu->halted will soon be protected by cpu->lock. We will use these helpers to ease the transition, since right now cpu->halted has many direct callers. Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota Signed-o

[PATCH v8 23/74] m68k: convert to cpu_halted

2020-03-26 Thread Robert Foley
From: "Emilio G. Cota" Cc: Laurent Vivier Reviewed-by: Richard Henderson Reviewed-by: Laurent Vivier Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- target/m68k/op_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --gi

[PATCH v8 33/74] cpu: define cpu_interrupt_request helpers

2020-03-26 Thread Robert Foley
sition; once that is complete, cpu_interrupt_request will be simple again. Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- hw/core/cpu.c | 27 +-- include/hw/core/cpu.h | 37

[PATCH v8 50/74] m68k: convert to cpu_interrupt_request

2020-03-26 Thread Robert Foley
From: "Emilio G. Cota" Cc: Laurent Vivier Reviewed-by: Richard Henderson Reviewed-by: Laurent Vivier Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- target/m68k/cpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/m68k/cpu.c b/target/

[PATCH v8 27/74] sparc: convert to cpu_halted

2020-03-26 Thread Robert Foley
From: "Emilio G. Cota" Cc: Fabien Chouteau Cc: Mark Cave-Ayland Cc: Artyom Tarasenko Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Reviewed-by: Mark Cave-Ayland Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- hw/sparc/leon3.c | 2 +- hw/spa

[PATCH v8 17/74] hw/semihosting: convert to cpu_halted_set

2020-03-26 Thread Robert Foley
Signed-off-by: Robert Foley --- hw/semihosting/console.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/semihosting/console.c b/hw/semihosting/console.c index 6346bd7f50..f70085f3c1 100644 --- a/hw/semihosting/console.c +++ b/hw/semihosting/console.c @@ -131,7 +131,7

[PATCH v8 20/74] sh4: convert to cpu_halted

2020-03-26 Thread Robert Foley
From: "Emilio G. Cota" Cc: Aurelien Jarno Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- target/sh4/op_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/sh4/op_helper.c b/

[PATCH v8 52/74] nios: convert to cpu_interrupt_request

2020-03-26 Thread Robert Foley
From: "Emilio G. Cota" Cc: Chris Wulff Cc: Marek Vasut Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- target/nios2/cpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/nios2/cpu.

[PATCH v8 37/74] s390x: use cpu_reset_interrupt

2020-03-26 Thread Robert Foley
From: Paolo Bonzini Cc: Cornelia Huck Cc: David Hildenbrand Cc: qemu-s3...@nongnu.org Reviewed-by: David Hildenbrand Reviewed-by: Richard Henderson Reviewed-by: Cornelia Huck Reviewed-by: Alex Bennée Signed-off-by: Paolo Bonzini Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley

[PATCH v8 28/74] xtensa: convert to cpu_halted

2020-03-26 Thread Robert Foley
From: "Emilio G. Cota" Cc: Max Filippov Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- target/xtensa/cpu.c| 2 +- target/xtensa/exc_helper.c | 2 +- target/xtensa/helper.c | 2 +- 3 files

[PATCH v8 64/74] ppc: convert to cpu_has_work_with_iothread_lock

2020-03-26 Thread Robert Foley
From: "Emilio G. Cota" Soon we will call cpu_has_work without the BQL. Cc: David Gibson Cc: qemu-...@nongnu.org Reviewed-by: Richard Henderson Acked-by: David Gibson Signed-off-by: Emilio G. Cota [RF: Converted new code related to POWER10] Signed-off-by: Robert Foley ---

[PATCH v8 53/74] s390x: convert to cpu_interrupt_request

2020-03-26 Thread Robert Foley
From: "Emilio G. Cota" Cc: Cornelia Huck Cc: Christian Borntraeger Cc: David Hildenbrand Cc: qemu-s3...@nongnu.org Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Reviewed-by: Cornelia Huck Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- hw/intc/s390_

[PATCH v8 21/74] i386: convert to cpu_halted

2020-03-26 Thread Robert Foley
From: "Emilio G. Cota" Cc: Eduardo Habkost Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota [RF: Converted new code in i386/hax-all.c to cpu_halted] Signed-off-by: Robert Foley --- target/i386/cpu.c | 2 +- target/i386/cpu.h

[PATCH v8 29/74] gdbstub: convert to cpu_halted

2020-03-26 Thread Robert Foley
From: "Emilio G. Cota" Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- gdbstub.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 013fb1ac0f..d95c32997a 10

[PATCH v8 68/74] sparc: convert to cpu_has_work_with_iothread_lock

2020-03-26 Thread Robert Foley
From: "Emilio G. Cota" Soon we will call cpu_has_work without the BQL. Cc: Mark Cave-Ayland Cc: Artyom Tarasenko Reviewed-by: Richard Henderson Acked-by: Mark Cave-Ayland Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- target/sparc/cpu.c | 4 +++- 1 file

[PATCH v8 25/74] riscv: convert to cpu_halted

2020-03-26 Thread Robert Foley
From: "Emilio G. Cota" Cc: Palmer Dabbelt Cc: Sagar Karandikar Cc: Bastian Koppelmann Cc: Alistair Francis Reviewed-by: Palmer Dabbelt Reviewed-by: Richard Henderson Reviewed-by: Alistair Francis Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- target/riscv/op_he

[PATCH v8 54/74] alpha: convert to cpu_interrupt_request

2020-03-26 Thread Robert Foley
From: "Emilio G. Cota" Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- target/alpha/cpu.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/target/alpha/cpu.c b/target/alpha/c

[PATCH v8 30/74] openrisc: convert to cpu_halted

2020-03-26 Thread Robert Foley
From: "Emilio G. Cota" Cc: Stafford Horne Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- target/openrisc/sys_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/openrisc/sys_

[PATCH v8 44/74] i386/hvf: convert to cpu_request_interrupt

2020-03-26 Thread Robert Foley
From: "Emilio G. Cota" Reviewed-by: Richard Henderson Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- target/i386/hvf/hvf.c| 8 +--- target/i386/hvf/x86hvf.c | 26 +++--- 2 files changed, 20 insertions(+), 14 deletions(-) diff --git a/t

[PATCH v8 69/74] xtensa: convert to cpu_has_work_with_iothread_lock

2020-03-26 Thread Robert Foley
From: "Emilio G. Cota" Soon we will call cpu_has_work without the BQL. Cc: Max Filippov Reviewed-by: Richard Henderson Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- target/xtensa/cpu.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tar

[PATCH v8 26/74] s390x: convert to cpu_halted

2020-03-26 Thread Robert Foley
From: "Emilio G. Cota" Cc: Cornelia Huck Cc: Christian Borntraeger Cc: David Hildenbrand Cc: qemu-s3...@nongnu.org Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Reviewed-by: Cornelia Huck Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- hw/intc/s

[PATCH v8 34/74] ppc: use cpu_reset_interrupt

2020-03-26 Thread Robert Foley
From: Paolo Bonzini Cc: David Gibson Cc: qemu-...@nongnu.org Acked-by: David Gibson Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Paolo Bonzini Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- target/ppc

[PATCH v8 71/74] cpu: protect CPU state with cpu->lock instead of the BQL

2020-03-26 Thread Robert Foley
keup. Reviewed-by: Alex Bennée Reviewed-by: Richard Henderson Signed-off-by: Emilio G. Cota [RF: Adjusted assert and changed to use timed_wait] Signed-off-by: Robert Foley --- cpus.c| 288 +++--- hw/core/cpu.c | 29 + include/hw/core/

[PATCH v8 60/74] accel/tcg: convert to cpu_interrupt_request

2020-03-26 Thread Robert Foley
From: "Emilio G. Cota" Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- accel/tcg/cpu-exec.c | 15 --- accel/tcg/tcg-all.c | 12 +--- accel/tcg/translate-all.c | 2 +- 3 files c

[PATCH v8 31/74] cpu-exec: convert to cpu_halted

2020-03-26 Thread Robert Foley
From: "Emilio G. Cota" Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- accel/tcg/cpu-exec.c | 25 + 1 file changed, 21 insertions(+), 4 deletions(-) diff --git a/accel/tcg/cpu-exec.c b

[PATCH v8 36/74] i386: use cpu_reset_interrupt

2020-03-26 Thread Robert Foley
From: Paolo Bonzini Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Paolo Bonzini Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- target/i386/hax-all.c| 4 ++-- target/i386/hvf/x86hvf.c | 8 target/i386/kvm.c| 14

[PATCH v8 61/74] cpu: convert to interrupt_request

2020-03-26 Thread Robert Foley
From: "Emilio G. Cota" This finishes the conversion to interrupt_request. Reviewed-by: Alex Bennée Reviewed-by: Richard Henderson Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- hw/core/cpu.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH v8 38/74] openrisc: use cpu_reset_interrupt

2020-03-26 Thread Robert Foley
From: Paolo Bonzini Cc: Stafford Horne Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Paolo Bonzini Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- target/openrisc/sys_helper.c | 2 +- 1 file changed, 1 insertion

[PATCH v8 35/74] exec: use cpu_reset_interrupt

2020-03-26 Thread Robert Foley
From: "Emilio G. Cota" Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- exec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/exec.c b/exec.c index de9d949902..a379016693 100644 --- a/ex

[PATCH v8 73/74] cpu: add async_run_on_cpu_no_bql

2020-03-26 Thread Robert Foley
From: "Emilio G. Cota" Some async jobs do not need the BQL. Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- cpus-common.c | 39 ++- include/hw/core/cpu.h | 14 +++

[PATCH v8 43/74] i386/whpx-all: convert to cpu_interrupt_request

2020-03-26 Thread Robert Foley
From: "Emilio G. Cota" Reviewed-by: Richard Henderson Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- target/i386/whpx-all.c | 41 - 1 file changed, 24 insertions(+), 17 deletions(-) diff --git a/target/i386/whpx-all.c b/target

[PATCH v8 39/74] arm: convert to cpu_interrupt_request

2020-03-26 Thread Robert Foley
From: "Emilio G. Cota" Cc: Peter Maydell Cc: qemu-...@nongnu.org Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- target/arm/cpu.c | 6 +++--- target/arm/helper.c | 16 +++- target/arm/mach

[PATCH v8 45/74] ppc: convert to cpu_interrupt_request

2020-03-26 Thread Robert Foley
From: "Emilio G. Cota" Cc: David Gibson Cc: qemu-...@nongnu.org Reviewed-by: Richard Henderson Acked-by: David Gibson Signed-off-by: Emilio G. Cota [RF: Minor adjustment for new code in hvf_inject_interrupts] Signed-off-by: Robert Foley --- hw/ppc/ppc.c| 2

[PATCH v8 48/74] hppa: convert to cpu_interrupt_request

2020-03-26 Thread Robert Foley
From: "Emilio G. Cota" Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- target/hppa/cpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/hppa/cpu.c b/target/hppa/cpu.c index

[PATCH v8 49/74] lm32: convert to cpu_interrupt_request

2020-03-26 Thread Robert Foley
From: "Emilio G. Cota" Cc: Michael Walle Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- target/lm32/cpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/lm32/cpu.c b/target/lm32/c

[PATCH v8 46/74] sh4: convert to cpu_interrupt_request

2020-03-26 Thread Robert Foley
From: "Emilio G. Cota" Cc: Aurelien Jarno Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- target/sh4/cpu.c| 2 +- target/sh4/helper.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/

[PATCH v8 55/74] moxie: convert to cpu_interrupt_request

2020-03-26 Thread Robert Foley
From: "Emilio G. Cota" Cc: Anthony Green Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- target/moxie/cpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/moxie/cpu.c b/target/m

[PATCH v8 47/74] cris: convert to cpu_interrupt_request

2020-03-26 Thread Robert Foley
From: "Emilio G. Cota" Cc: "Edgar E. Iglesias" Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- target/cris/cpu.c| 2 +- target/cris/helper.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deleti

[PATCH v8 51/74] mips: convert to cpu_interrupt_request

2020-03-26 Thread Robert Foley
From: "Emilio G. Cota" Cc: Aurelien Jarno Cc: Aleksandar Markovic Reviewed-by: Richard Henderson Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- target/mips/cpu.c | 7 --- target/mips/kvm.c | 2 +- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/t

[PATCH v8 63/74] cpu: introduce cpu_has_work_with_iothread_lock

2020-03-26 Thread Robert Foley
From: "Emilio G. Cota" It will gain some users soon. Suggested-by: Paolo Bonzini Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- include/hw/core/cpu.h | 37 ++--- 1 file c

[PATCH v8 57/74] openrisc: convert to cpu_interrupt_request

2020-03-26 Thread Robert Foley
From: "Emilio G. Cota" Cc: Stafford Horne Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- hw/openrisc/cputimer.c | 2 +- target/openrisc/cpu.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff

[PATCH v8 66/74] s390x: convert to cpu_has_work_with_iothread_lock

2020-03-26 Thread Robert Foley
From: "Emilio G. Cota" Soon we will call cpu_has_work without the BQL. Cc: Cornelia Huck Cc: David Hildenbrand Cc: qemu-s3...@nongnu.org Reviewed-by: Richard Henderson Reviewed-by: Cornelia Huck Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- target/s390x/cpu.c |

[PATCH v8 67/74] riscv: convert to cpu_has_work_with_iothread_lock

2020-03-26 Thread Robert Foley
From: "Emilio G. Cota" Soon we will call cpu_has_work without the BQL. Cc: Palmer Dabbelt Cc: Sagar Karandikar Cc: Bastian Koppelmann Reviewed-by: Palmer Dabbelt Reviewed-by: Richard Henderson Reviewed-by: Alistair Francis Signed-off-by: Emilio G. Cota Signed-off-by: Ro

[PATCH v8 58/74] unicore32: convert to cpu_interrupt_request

2020-03-26 Thread Robert Foley
From: "Emilio G. Cota" Cc: Guan Xuetao Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- target/unicore32/cpu.c | 2 +- target/unicore32/softmmu.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) di

[PATCH v8 56/74] sparc: convert to cpu_interrupt_request

2020-03-26 Thread Robert Foley
From: "Emilio G. Cota" Cc: Mark Cave-Ayland Cc: Artyom Tarasenko Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Reviewed-by: Mark Cave-Ayland Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- hw/sparc64/sparc64.c | 4 ++-- target/sparc/cpu.c | 2 +- 2 fil

[PATCH v8 70/74] cpu: rename all_cpu_threads_idle to qemu_tcg_rr_all_cpu_threads_idle

2020-03-26 Thread Robert Foley
From: "Emilio G. Cota" This function is only called from TCG rr mode, so add a prefix to mark this as well as an assertion. Reviewed-by: Alex Bennée Reviewed-by: Richard Henderson Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- cpus.c | 10 ++ 1 file

[PATCH v8 59/74] microblaze: convert to cpu_interrupt_request

2020-03-26 Thread Robert Foley
From: "Emilio G. Cota" Cc: "Edgar E. Iglesias" Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- target/microblaze/cpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/micro

[PATCH v8 62/74] cpu: call .cpu_has_work with the CPU lock held

2020-03-26 Thread Robert Foley
From: "Emilio G. Cota" Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- include/hw/core/cpu.h | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/include/hw/core/cpu.h b/include/hw/

[PATCH v8 65/74] mips: convert to cpu_has_work_with_iothread_lock

2020-03-26 Thread Robert Foley
From: "Emilio G. Cota" Soon we will call cpu_has_work without the BQL. Cc: Aurelien Jarno Cc: Aleksandar Markovic Reviewed-by: Richard Henderson Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- target/mips/cpu.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletio

[PATCH v8 72/74] cpus-common: release BQL earlier in run_on_cpu

2020-03-26 Thread Robert Foley
From: "Emilio G. Cota" After completing the conversion to per-CPU locks, there is no need to release the BQL after having called cpu_kick. Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- cpus-com

[PATCH v8 74/74] cputlb: queue async flush jobs without the BQL

2020-03-26 Thread Robert Foley
68% of all branches ( +- 0.09% ) 7.389068145 seconds time elapsed ( +- 0.13% ) That is, a 1.37% slowdown. Reviewed-by: Alex Bennée Reviewed-by: Richard Henderson Tested-by: Alex Bennée Signed-off-by: Emilio G. Cota Signed-off-by: Ro

Re: [PATCH v8 00/74] per-CPU locks

2020-03-27 Thread Robert Foley
get this accepted. > >> >> > >> > > >> > Thank for this work, Robert. > >> > > >> > However, I just hope you don't intend to request integrating the series > >> > in > >> > 5.0. The right timing for such

<    1   2   3   4   5   6   7   8   9   10   >