to vary on the VM being created
or launched.
This will for example allow for creating an aarch64 vm.
Signed-off-by: Robert Foley
---
tests/vm/basevm.py | 143 +++--
1 file changed, 112 insertions(+), 31 deletions(-)
diff --git a/tests/vm/basevm.py b/tests
Added a new special variable QEMU_LOCAL=1, which
will indicate to take the QEMU binary from the current
build.
Signed-off-by: Robert Foley
---
tests/vm/Makefile.include | 4
tests/vm/basevm.py| 29 -
2 files changed, 28 insertions(+), 5 deletions
ubuntu.aarch64 provides a script to create an Ubuntu 18.04 VM.
Another new file is also added aarch64vm.py, which is a module with
common methods used by aarch64 VMs, such as how to create the
flash images.
Signed-off-by: Robert Foley
---
tests/vm/Makefile.include | 3 +-
tests/vm
This change converts existing scripts to using for example self.ROOT_PASS,
to self._config['root_pass'].
We made similar changes for GUEST_USER, and GUEST_PASS.
This allows us also to remove the change in basevm.py,
which adds __getattr__ for backwards compatibility.
Signed-off-by: Ro
Add changes to tests/vm/basevm.py so that during debug mode we show ssh output.
Signed-off-by: Robert Foley
Reviewed-by: Peter Puhov
Reviewed-by: Alex Bennée
---
tests/vm/basevm.py | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/tests/vm/basevm.py b/tests/vm
Added ability to view console during boot via
--boot-console switch to basevm.py. This helps debug issues that occur
during the boot sequence.
Also added a new special variable to vm-build:
BOOT_CONSOLE=1 will cause this new --boot-console switch to be set.
Signed-off-by: Robert Foley
---
tests
Change Makefile.include to use $(PYTHON) so for vm-boot-ssh to be
consistent with other cases like vm-build.
Signed-off-by: Robert Foley
Reviewed-by: Alex Bennée
Reviewed-by: Peter Puhov
---
tests/vm/Makefile.include | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/vm
Add change to increase timeout waiting for VM to boot.
Needed for some emulation cases where it can take longer
than 5 minutes to boot.
Signed-off-by: Robert Foley
Reviewed-by: Alex Bennée
Reviewed-by: Peter Puhov
---
tests/vm/basevm.py | 7 +++
1 file changed, 7 insertions(+)
diff --git
some cases the latin1 is needed for chars coming out of the i
socket which do not have a utf-8 equivalent.
Robert Foley (14):
tests/vm: use $(PYTHON) consistently
tests/vm: Debug mode shows ssh output.
tests/vm: increased max timeout for vm boot.
tests/vm: give wait_ssh() option to wai
Allow wait_ssh to wait for root user to be ready.
This solves the issue where we perform a wait_ssh()
successfully, but the root user is not yet ready
to be logged in.
Signed-off-by: Robert Foley
Reviewed-by: Alex Bennée
Reviewed-by: Peter Puhov
---
tests/vm/basevm.py | 7 +--
1 file
centos.aarch64 creates a CentOS 8 image.
Also added a new kickstart script used to build the centos.aarch64 image.
Signed-off-by: Robert Foley
---
tests/vm/Makefile.include| 3 +-
tests/vm/centos-8-aarch64.ks | 51
tests/vm/centos.aarch64 | 224
characters to be consumed.
We also add the option of logging the console to a file.
Signed-off-by: Robert Foley
---
python/qemu/console_socket.py | 162 ++
python/qemu/machine.py| 12 ++-
tests/vm/Makefile.include | 4 +
tests/vm/basevm.py| 24
.yml.
Signed-off-by: Robert Foley
---
tests/vm/Makefile.include | 2 ++
tests/vm/basevm.py| 29 +-
tests/vm/conf_example_aarch64.yml | 51 +++
tests/vm/conf_example_x86.yml | 50 ++
4 files changed
This allows for waiting for completion of arbitrary commands.
Signed-off-by: Robert Foley
---
tests/vm/basevm.py | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/tests/vm/basevm.py b/tests/vm/basevm.py
index a30a641a4a..792e4a3fb2 100644
--- a/tests/vm
re we chase the symlinks to copy the right
> binary to where it can be found.
>
> Signed-off-by: Alex Bennée
> Reviewed-by: Philippe Mathieu-Daudé
> Tested-by: Philippe Mathieu-Daudé
Reviewed-by: Robert Foley
Add change to increase timeout waiting for VM to boot.
Needed for some emulation cases where it can take longer
than 5 minutes to boot.
Signed-off-by: Robert Foley
---
tests/vm/basevm.py | 7 +++
1 file changed, 7 insertions(+)
diff --git a/tests/vm/basevm.py b/tests/vm/basevm.py
index
This method was located in both centos and ubuntu.i386.
Signed-off-by: Robert Foley
---
tests/vm/basevm.py | 40
tests/vm/centos | 33 +
tests/vm/ubuntu.i386 | 37 +
3 files
Change Makefile.include to use $(PYTHON) so for vm-boot-ssh to be
consistent with other cases like vm-build.
Signed-off-by: Robert Foley
---
tests/vm/Makefile.include | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/vm/Makefile.include b/tests/vm/Makefile.include
index
Add changes to tests/vm/basevm.py so that during debug mode we show ssh output.
Signed-off-by: Robert Foley
Reviewed-by: Peter Puhov
Reviewed-by: Alex Bennée
---
tests/vm/basevm.py | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/tests/vm/basevm.py b/tests/vm
the boot console as the VM boots up to aid in
debugging problems during VM boot.
Robert Foley (14):
tests/vm: use $(PYTHON) consistently
tests/vm: Debug mode shows ssh output.
tests/vm: increased max timeout for vm boot.
tests/vm: give wait_ssh() option to wait for root
tests/vm: Added gen_
Allow wait_ssh to wait for root user to be ready.
This solves the issue where we perform a wait_ssh()
successfully, but the root user is not yet ready
to be logged in.
Signed-off-by: Robert Foley
---
tests/vm/basevm.py | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a
to vary on the VM being created
or launched.
This will for example allow for creating an aarch64 vm.
Signed-off-by: Robert Foley
---
tests/vm/basevm.py | 141 +++--
1 file changed, 111 insertions(+), 30 deletions(-)
diff --git a/tests/vm/basevm.py b/tests
not consumed by the script.
Signed-off-by: Robert Foley
---
tests/vm/basevm.py| 48 ++---
tests/vm/socket_thread.py | 73 +++
2 files changed, 116 insertions(+), 5 deletions(-)
create mode 100644 tests/vm/socket_thread.py
diff
This allows for waiting for completion of arbitrary commands.
Signed-off-by: Robert Foley
---
tests/vm/basevm.py | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/tests/vm/basevm.py b/tests/vm/basevm.py
index 97d55f8030..ebedbce4ae 100755
--- a/tests/vm
Added ability to view console during boot via
--boot-console switch to basevm.py. This helps debug issues that occur
during the boot sequence.
Also added a new special variable to vm-build:
BOOT_CONSOLE=1 will cause this new --boot-console switch to be set.
Signed-off-by: Robert Foley
---
tests
.yml.
Signed-off-by: Robert Foley
---
tests/vm/Makefile.include | 2 ++
tests/vm/basevm.py| 29 +-
tests/vm/conf_example_aarch64.yml | 51 +++
tests/vm/conf_example_x86.yml | 50 ++
4 files changed
This change converts existing scripts to using for example self.ROOT_PASS,
to self._config['root_pass'].
We made similar changes for GUEST_USER, and GUEST_PASS.
This allows us also to remove the change in basevm.py,
which adds __getattr__ for backwards compatibility.
Signed-off-by: Ro
Added a new special variable QEMU_LOCAL=1, which
will indicate to take the QEMU binary from the current
build.
Signed-off-by: Robert Foley
---
tests/vm/Makefile.include | 4
tests/vm/basevm.py| 28
2 files changed, 28 insertions(+), 4 deletions
ubuntu.aarch64 provides a script to create an Ubuntu 18.04 VM.
Another new file is also added aarch64vm.py, which is a module with
common methods used by aarch64 VMs, such as how to create the
flash images.
Signed-off-by: Robert Foley
---
tests/vm/Makefile.include | 3 +-
tests/vm
centos.aarch64 creates a CentOS 8 image.
Also added a new kickstart script used to build the centos.aarch64 image.
Signed-off-by: Robert Foley
---
tests/vm/Makefile.include| 3 +-
tests/vm/centos-8-aarch64.ks | 51
tests/vm/centos.aarch64 | 221
Hi,
On Fri, 7 Feb 2020 at 10:01, Alex Bennée wrote:
> -static void decode_RV32_64C0(DisasContext *ctx)
> +static void decode_RV32_64C0(DisasContext *ctx, uint16_t opcode)
> {
> -uint8_t funct3 = extract32(ctx->opcode, 13, 3);
> -uint8_t rd_rs2 = GET_C_RS2S(ctx->opcode);
> -uint8_t rs1
On Fri, 7 Feb 2020 at 10:01, Alex Bennée wrote:
>
> I forgot to document the lifetime of handles in the developer
> documentation. Do so now.
>
> Signed-off-by: Alex Bennée
Reviewed-by: Robert Foley
Regards,
-Rob
> ---
> docs/devel/tcg-plugins.rst | 13 +++--
On Fri, 7 Feb 2020 at 12:12, Alex Bennée wrote:
> Robert Foley writes:
>
> > This adds logging of the char device used by the console
> > to a file. The basevm.py then uses this file to read
> > chars from the console.
> > One reason to add this is to aid with debu
On Fri, 7 Feb 2020 at 17:20, Robert Foley wrote:
>
> On Fri, 7 Feb 2020 at 12:12, Alex Bennée wrote:
> > > +
> > > +def join(self, timeout=None):
> > > +"""Time to destroy the thread.
> > > + Clear the event to stop
15 @@ static void plugin_exit(qemu_plugin_id_t id, void *p)
> g_list_free(it);
> }
>
> +g_list_free(counts);
> +g_hash_table_destroy(insns);
> +
Just one minor comment. Seems like there might be an option to use
g_autoptr(GList) for counts.
Reviewed-by: Ro
vm_lookup_matching_slot(), kvm_physical_memory_addr_from_host(),
kvm_physical_log_clear(), kvm_log_sync_global().
Test:
Temporarily set KVM_DEF_NR_SLOTS = 8, let it go through slot[] dynamic
increase, VM launched and works well.
Signed-off-by: Robert Hoo
---
accel/kvm/kvm-all.c | 57 ++
On Thu, 2022-06-16 at 13:38 +0200, Igor Mammedov wrote:
> On Mon, 30 May 2022 11:40:44 +0800
> Robert Hoo wrote:
>
> > The Intel Optane PMem DSM Interface, Version 2.0 [1], is the up-to-
> > date
> > spec for NVDIMM _DSM definition, which supports revision_id == 2.
&
On Thu, 2022-06-16 at 14:35 +0200, Igor Mammedov wrote:
> On Mon, 30 May 2022 11:40:47 +0800
> Robert Hoo wrote:
>
> suggest to put this patch as the 1st in series
> (well you can rebase it on current master and
> post that right away for merging since it doesn't
> real
On Thu, 2022-06-16 at 14:32 +0200, Igor Mammedov wrote:
> On Mon, 30 May 2022 11:40:45 +0800
> Robert Hoo wrote:
>
> > Recent ACPI spec [1] has defined NVDIMM Label Methods _LS{I,R,W},
> > which
> > depricates corresponding _DSM Functions defined by PMEM _DS
Signed-off-by: Robert Hoo
Reviewed-by: Jingqi Liu
---
This is separated from patch set
https://lore.kernel.org/qemu-devel/20220616143542.3e049...@redhat.com/
hw/acpi/nvdimm.c| 35 ---
hw/acpi/trace-events| 13 +
include/hw/mem/nvdimm.h
784949 30263
Signed-off-by: Robert Hoo
---
Resend:
Add stats about kvm_lookup_matching_slot() for example.
CC kvm mail list per get_maintainer.pl suggests.
I believe this benefits Live Migration, but not devices at hand to do
the system level test.
accel/
Babu Moger 于2023年4月25日周二 00:42写道：
>
> From: Michael Roth
>
> New EPYC CPUs versions require small changes to their cache_info's.
Do you mean, for the real HW of EPYC CPU, each given model, e.g. Rome,
has HW version updates periodically?
> Because current QEMU x86 CPU definition does not support
Hi,
Can we remove the deprecated 'Icelake-Client' CPU model now? if so, I
can rebase patch to latest and resend.
Thanks.
On Sat, 2021-05-08 at 11:16 +0800, Robert Hoo wrote:
> Hi,
>
> Ping...
>
> Thanks.
>
> On Thu, 2021-04-29 at 09:35 +0800, Robert Hoo
On Fri, 2022-05-06 at 11:23 +0200, Igor Mammedov wrote:
>
> >
> > No, sorry, I didn't explain it clear.
> > No extra interface/ABI but these 3 must _LS{I,R,W} nvdimm-sub-
> > device
> > methods. Of course, I'm going to extract 'SystemIO' and
> > 'SystemMemory'
> > operation regions out of NACL to
On Wed, 2022-04-27 at 16:39 +0200, Igor Mammedov wrote:
> On Tue, 12 Apr 2022 14:57:51 +0800
> Robert Hoo wrote:
>
> > The original NVDIMM _DSM functions (index 4~6) for label operations
> > have
> > been deprecated by new ACPI methods _LS{I,R,W}[1][2].
> >
>
On Wed, 2022-04-27 at 16:34 +0200, Igor Mammedov wrote:
> On Tue, 12 Apr 2022 14:57:52 +0800
> Robert Hoo wrote:
>
> > Since ACPI 6.2, previous NVDIMM/_DSM funcions "Get Namespace Label
> > Data
> > Size (function index 4)", "Get Namespace Label Data (
On Tue, 2022-05-03 at 10:27 +0200, Igor Mammedov wrote:
> On Fri, 29 Apr 2022 17:01:47 +0800
> Robert Hoo wrote:
>
> > On Wed, 2022-04-27 at 16:34 +0200, Igor Mammedov wrote:
> > > On Tue, 12 Apr 2022 14:57:52 +0800
> > > Robert Hoo wrote:
> > >
&g
On Thu, 2022-05-05 at 10:50 +0200, Igor Mammedov wrote:
...
> > > > > > @@ -1247,6 +1247,11 @@ static void nvdimm_build_fit(Aml
> > > > > > *dev)
> > > > > > static void nvdimm_build_nvdimm_devices(Aml *root_dev,
> > > > > > uint32_t
> > > > > > ram_slots)
> > > > > > {
> > > > > > uint32_t
Patch 2
Dance with tests/qtest/bios-table-tests
Add trace event
Robert Hoo (5):
tests/acpi: allow SSDT changes
acpi/ssdt: Fix aml_or() and aml_and() in if clause
acpi/nvdimm: define macro for NVDIMM Device _DSM
acpi/nvdimm: Implement ACPI NVDIMM Label Methods
test/acpi/bios-tables-test
Signed-off-by: Robert Hoo
Reviewed-by: Jingqi Liu
---
tests/qtest/bios-tables-test-allowed-diff.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tests/qtest/bios-tables-test-allowed-diff.h
b/tests/qtest/bios-tables-test-allowed-diff.h
index dfb8523c8b..eb8bae1407 100644
--- a/tests
3) == 0x04) && (SizeOf (Arg3) == One)))
Fixes: 90623ebf603 ("nvdimm acpi: check UUID")
Fixes: 4568c948066 ("nvdimm acpi: save arg3 of _DSM method")
Signed-off-by: Robert Hoo
Reviewed-by: Jingqi Liu
Reviewed-by: Igor Mammedov
---
hw/acpi/nvdimm.c | 7 +++
1 file changed,
/IntelOptanePMem_DSM_Interface-V2.0.pdf
Signed-off-by: Robert Hoo
Reviewed-by: Jingqi Liu
---
hw/acpi/nvdimm.c | 91
1 file changed, 91 insertions(+)
diff --git a/hw/acpi/nvdimm.c b/hw/acpi/nvdimm.c
index afff911c1e..516acfe53b 100644
--- a/hw/acpi/nvdimm.c
+++ b/hw/acpi
/documents/IntelOptanePMem_DSM_Interface-V2.0.pdf
Signed-off-by: Robert Hoo
Reviewed-by: Jingqi Liu
---
hw/acpi/nvdimm.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/acpi/nvdimm.c b/hw/acpi/nvdimm.c
index 201317c611..afff911c1e 100644
--- a/hw/acpi/nvdimm.c
+++ b/hw/acp
(Local3, Zero, STTS)
+Return (ToInteger (STTS))
+}
+
Method (_DSM, 4, NotSerialized) // _DSM: Device-Specific
Method
{
Return (NCAL (Arg0, Arg1, Arg2, Arg3, One))
}
}
... // iterates in each
On Mon, 2022-09-26 at 15:22 +0200, Igor Mammedov wrote:
> > > 0800200c9a66"), One, 0x05, Local0, One)
> > > +CreateDWordField (Local3, Zero, STTS)
> > > +CreateField (Local3, 0x20, (LEN << 0x03),
> > > LDAT)
> > > +Name (LSA, Buffer (Zero)
Ping...
On Fri, 2022-10-07 at 21:27 +0800, Robert Hoo wrote:
> Ping...
> On Tue, 2022-09-27 at 08:30 +0800, Robert Hoo wrote:
> > On Mon, 2022-09-26 at 15:22 +0200, Igor Mammedov wrote:
> > > > > 0800200c9a66"), One, 0x05, Local0, One)
> > > > > +
On Wed, 2022-10-26 at 10:45 -0400, Michael S. Tsirkin wrote:
> On Thu, Sep 22, 2022 at 08:21:55PM +0800, Robert Hoo wrote:
> > And empty bios-tables-test-allowed-diff.h.
> >
> > Diff of ASL form, from qtest testlog.txt:
> >
> > --- /tmp/asl-RFWZS1.dsl 20
getContent/671368
Signed-off-by: Robert Hoo
---
target/i386/cpu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target/i386/cpu.c b/target/i386/cpu.c
index 4d2b8d0444..d6d573ca38 100644
--- a/target/i386/cpu.c
+++ b/target/i386/cpu.c
@@ -876,7 +876,7 @@ Featu
e any of this chatter in this email thread on the bug report
https://gitlab.com/qemu-project/qemu/-/issues/249
Robert Henry
On Sat, Jun 15, 2024 at 4:25 PM Richard Henderson <
richard.hender...@linaro.org> wrote:
> On 6/11/24 09:20, Robert R. Henry wrote:
> > This fixes a bug wher
Icelake, is the codename for Intel 3rd generation Xeon Scalable server
processors. There isn't ever client variants. This "Icelake-Client" CPU
model was added wrongly and imaginarily.
It has been deprecated since v5.2, now it's time to remove it completely
from code.
Signe
On Thu, 2022-07-07 at 11:21 +0200, Igor Mammedov wrote:
> On Mon, 4 Jul 2022 16:58:52 +0800
> Robert Hoo wrote:
>
> > Signed-off-by: Robert Hoo
> > Reviewed-by: Jingqi Liu
>
> Reviewed-by: Igor Mammedov
Thanks for review Igor.
BTW, during the unit test, I met
On Mon, 2022-07-18 at 15:41 +0200, Igor Mammedov wrote:
> On Mon, 18 Jul 2022 15:12:03 +0800
> Robert Hoo wrote:
> [...]
> > BTW, during the unit test, I met some bios-table test error,
> > https://gitlab.com/qemu-project/qemu/-/issues/1098, perhaps related
> >
Ping...
On Fri, 2022-07-01 at 17:23 +0800, Robert Hoo wrote:
> On Thu, 2022-06-16 at 14:32 +0200, Igor Mammedov wrote:
> > On Mon, 30 May 2022 11:40:45 +0800
> > Robert Hoo wrote:
> >
> > > Recent ACPI spec [1] has defined NVDIMM Label Methods _LS{I,R,W}
https://pmem.io/documents/IntelOptanePMem_DSM_Interface-V2.0.pdf
[2] ACPI Spec v6.4, 6.5.10 NVDIMM Label Methods
https://uefi.org/sites/default/files/resources/ACPI_Spec_6_4_Jan22.pdf
---
Change Log:
v2:
Almost rewritten
Separate Patch 2
Dance with tests/qtest/bios-table-tests
Add trace events
Robert Hoo (6)
change to support this revision_id == 2 case.
[1] https://pmem.io/documents/IntelOptanePMem_DSM_Interface-V2.0.pdf
Signed-off-by: Robert Hoo
Reviewed-by: Jingqi Liu
---
hw/acpi/nvdimm.c | 10 +++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/hw/acpi/nvdimm.c b/hw/acpi
3) == 0x04) && (SizeOf (Arg3) == One)))
Fixes: 90623ebf603 ("nvdimm acpi: check UUID")
Fixes: 4568c948066 ("nvdimm acpi: save arg3 of _DSM method")
Signed-off-by: Robert Hoo
Reviewed-by: Jingqi Liu
Reviewed-by: Igor Mammedov
---
hw/acpi/nvdimm.c | 7 +++
1 file changed,
/sites/default/files/resources/ACPI_Spec_6_4_Jan22.pdf
[2] Intel PMEM _DSM Interface Spec v2.0, 3.10 Deprecated Functions
https://pmem.io/documents/IntelOptanePMem_DSM_Interface-V2.0.pdf
Signed-off-by: Robert Hoo
Reviewed-by: Jingqi Liu
---
hw/acpi/nvdimm.c
Signed-off-by: Robert Hoo
Reviewed-by: Jingqi Liu
---
tests/qtest/bios-tables-test-allowed-diff.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tests/qtest/bios-tables-test-allowed-diff.h
b/tests/qtest/bios-tables-test-allowed-diff.h
index dfb8523c8b..eb8bae1407 100644
--- a/tests
Method (_DSM, 4, NotSerialized) // _DSM: Device-Specific
Method
{
Return (NCAL (Arg0, Arg1, Arg2, Arg3, 0x03))
}
}
}
}
-
-Name (MEMA, 0x07FFF000)
}
Signed-off-by: Robert Hoo
Reviewed-by: Jingqi Liu
---
tests/da
Signed-off-by: Robert Hoo
Reviewed-by: Jingqi Liu
---
hw/acpi/nvdimm.c| 38 ++
hw/acpi/trace-events| 14 ++
include/hw/mem/nvdimm.h | 8
3 files changed, 32 insertions(+), 28 deletions(-)
diff --git a/hw/acpi/nvdimm.c b/hw
Ping...
Best Regards,
Robert Hoo
> -Original Message-
> From: Robert Hoo
> Sent: Monday, May 30, 2022 11:41
> To: imamm...@redhat.com; m...@redhat.com;
> xiaoguangrong.e...@gmail.com; a...@anisinha.ca; Williams, Dan J
> ; Liu, Jingqi
> Cc: qemu-devel@nongnu.org;
Hi Igor,
Ping...
Thanks.
On Mon, 2022-03-14 at 16:50 +0800, Robert Hoo wrote:
> Icelake, is the codename for Intel 3rd generation Xeon Scalable
> server
> processors. There isn't ever client variants. This "Icelake-Client"
> CPU
> model was added wrongly and
I have not done anything on this front, alas.
From: Aaron Lindsay
Sent: Thursday, March 24, 2022 1:17 PM
To: qemu-devel@nongnu.org ; qemu-...@nongnu.org
Cc: Alex Bennée ; richard.hender...@linaro.org
; Robert Henry
Subject: [EXTERNAL] Plugins Not Reporting
Per recent spec[1], change struct NVDIMMDevice::label_size semanteme to
describe the label's size in LSA (Label Storage Area). Instead, use new
'lsa_size' for the total size of LSA.
[1]: UEFI spec v2.9, "Label Storage Area Description" in section 13.19.
Signed-off-by
apable. So without initialization, guest Kernel will judge it
label-less, though it actually support label.
This patch set, is to init vNVDIMM's LSA, so that guest Kernel can
correctly identify and use it.
[1]:
https://uefi.org/sites/default/files/resources/ACPI_Spec_6_4_Jan22.pdf,
Section
nitial Label Storage Area Configuration:
"for Label Storage Areas of 128KB and 256KB, the corresponding Index
Block size is 256 or 512 bytes."
In driver and ndctl code, they refer to these 2 cases as v1.1 and v1.2.
Signed-off-by: Robert Hoo
Reviewed-by: Liu, Jingqi
---
Note: most functions
On Thu, 2022-03-31 at 14:03 +0200, Igor Mammedov wrote:
> On Tue, 29 Mar 2022 15:07:41 +0800
> Robert Hoo wrote:
>
> > QEMU option "-device nvdimm,...,label-size=" designates a vNVDIMM
> > with
> > Label Storage Area (LSA), where stores the namespace label
On Thu, 2022-03-31 at 14:09 +0200, Igor Mammedov wrote:
> On Tue, 29 Mar 2022 15:07:43 +0800
> Robert Hoo wrote:
>
> > Since v2.7, QEMU has supported the emulation of NVDIMM's labels.
> > With -device nvdimm,...,lsa-size=, the vNVDIMM to guest has this
> > cap
On Thu, 2022-03-31 at 16:41 +0200, Igor Mammedov wrote:
> On Thu, 31 Mar 2022 21:08:12 +0800
> Robert Hoo wrote:
>
> > >
> > > Can user initialize/format LSA from guest using ndctl/some other
> > > tool?
> > >
> >
> > Yes, he c
haven't causing trouble.
[1] https://uefi.org/htmlspecs/ACPI_Spec_6_4_html/index.html, 6.5.10 NVDIMM
Label Methods
[2] https://pmem.io/documents/IntelOptanePMem_DSM_Interface-V2.0.pdf, 3.10
Deprecated Functions
Robert Hoo (2):
acpi/nvdimm: Create _LS{I,R,W} method for NVDIMM device
uot; due to
550-'Message headers fail syntax check'.
Robert Hoo (2):
acpi/nvdimm: Create _LS{I,R,W} method for NVDIMM device
acpi/nvdimm: Fix aml_or() and aml_and() in if clause
hw/acpi/nvdimm.c | 60 +++-
1 file changed, 54 insertions(+), 6 d
ID ("4309ac30-0d11-11e4-9191-0800200c9a66"),
0x02, 0x06, PKG1, One))
}
Method (_DSM, 4, NotSerialized) // _DSM: Device-Specific Method
{
Return (NCAL (Arg0, Arg1, Arg2, Arg3, One))
}
}
Signed-off-by: Ro
== One)))
==>
If (((ObjectType (Arg3) == 0x04) && (SizeOf (Arg3) == One)))
Fixes: 90623ebf603 ("nvdimm acpi: check UUID")
Fixes: 4568c948066 ("nvdimm acpi: save arg3 of _DSM method")
Signed-off-by: Robert Hoo
Reviewed-by: Jingqi Liu
---
hw/acpi/nvdimm.c | 7 +++--
On Thu, 2022-03-24 at 09:22 +0100, Igor Mammedov wrote:
> On Mon, 14 Mar 2022 16:50:59 +0800
> Robert Hoo wrote:
>
> > Icelake, is the codename for Intel 3rd generation Xeon Scalable
> > server
> > processors. There isn't ever client variants. This "Icelake
On Fri, 2022-09-09 at 15:39 +0200, Igor Mammedov wrote:
> On Thu, 1 Sep 2022 11:27:20 +0800
> Robert Hoo wrote:
>
> > Recent ACPI spec [1] has defined NVDIMM Label Methods _LS{I,R,W},
> > which
> > deprecates corresponding _DSM Functions defined by PMEM _DS
On Fri, 2022-09-09 at 15:39 +0200, Igor Mammedov wrote:
...
> looks more or less fine except of excessive use of named variables
> which creates global scope variables.
>
> I'd suggest to store temporary buffers/packages in LocalX variales,
> you should be able to do that for everything modulo
> a
On Fri, 2022-09-16 at 09:37 +0200, Igor Mammedov wrote:
> > Fine, get your point now.
> > In ASL it will look like this:
> > Local1 = Package (0x3) {STTS, SLSA, MAXT}
> > Return (Local1)
>
>
> >
> > But as for
> > CreateDWordField (Lo
On Tue, 2022-09-20 at 11:13 +0200, Igor Mammedov wrote:
> On Fri, 16 Sep 2022 21:15:35 +0800
> Robert Hoo wrote:
>
> > On Fri, 2022-09-16 at 09:37 +0200, Igor Mammedov wrote:
> >
> > > > Fine, get your point now.
> > > > In ASL it will look
On Wed, 2022-09-21 at 15:29 +0200, Igor Mammedov wrote:
> On Tue, 20 Sep 2022 20:28:31 +0800
> Robert Hoo wrote:
>
> > On Tue, 2022-09-20 at 11:13 +0200, Igor Mammedov wrote:
> > > On Fri, 16 Sep 2022 21:15:35 +0800
> > > Robert Hoo wrote:
> > >
ntation to the idea of simply wrapper _DSM.
v1 --> v2:
Almost rewritten
Separate Patch 2
Dance with tests/qtest/bios-table-tests
Add trace event
Robert Hoo (5):
tests/acpi: allow SSDT changes
acpi/ssdt: Fix aml_or() and aml_and() in if clause
acpi/nvdimm: define macro for NVDIMM Device _
3) == 0x04) && (SizeOf (Arg3) == One)))
Fixes: 90623ebf603 ("nvdimm acpi: check UUID")
Fixes: 4568c948066 ("nvdimm acpi: save arg3 of _DSM method")
Signed-off-by: Robert Hoo
Reviewed-by: Jingqi Liu
Reviewed-by: Igor Mammedov
---
hw/acpi/nvdimm.c | 7 +++
1 file changed,
On Thu, 2022-09-22 at 20:21 +0800, Robert Hoo wrote:
> And empty bios-tables-test-allowed-diff.h.
>
> Diff of ASL form, from qtest testlog.txt:
>
> --- /tmp/asl-RFWZS1.dsl 2022-09-22 18:25:06.191519589 +0800
> +++ /tmp/asl-B1ZZS1.dsl 2022-09-22 18:25:06.18751918
/IntelOptanePMem_DSM_Interface-V2.0.pdf
Signed-off-by: Robert Hoo
---
hw/acpi/nvdimm.c | 95
1 file changed, 95 insertions(+)
diff --git a/hw/acpi/nvdimm.c b/hw/acpi/nvdimm.c
index afff911c1e..a3b25a92f3 100644
--- a/hw/acpi/nvdimm.c
+++ b/hw/acpi/nvdimm.c
@@ -1243,6
01)
+{
+INPT
+}
+Local3 = NCAL (ToUUID
("4309ac30-0d11-11e4-9191-0800200c9a66"), One, 0x06, Local0, One)
+ CreateDWordField (Local3, Zero, STTS)
+Retu
Signed-off-by: Robert Hoo
Reviewed-by: Jingqi Liu
---
tests/qtest/bios-tables-test-allowed-diff.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tests/qtest/bios-tables-test-allowed-diff.h
b/tests/qtest/bios-tables-test-allowed-diff.h
index dfb8523c8b..eb8bae1407 100644
--- a/tests
/documents/IntelOptanePMem_DSM_Interface-V2.0.pdf
Signed-off-by: Robert Hoo
Reviewed-by: Igor Mammedov
---
hw/acpi/nvdimm.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/acpi/nvdimm.c b/hw/acpi/nvdimm.c
index 201317c611..afff911c1e 100644
--- a/hw/acpi/nvdimm.c
+++ b/hw/acp
Ping...
On Tue, 2022-09-27 at 08:30 +0800, Robert Hoo wrote:
> On Mon, 2022-09-26 at 15:22 +0200, Igor Mammedov wrote:
> > > > 0800200c9a66"), One, 0x05, Local0, One)
> > > > +CreateDWordField (Local3, Zero, STTS)
> > > > +
Ping...
On Tue, 2022-04-12 at 14:57 +0800, Robert Hoo wrote:
> The original NVDIMM _DSM functions (index 4~6) for label operations
> have
> been deprecated by new ACPI methods _LS{I,R,W}[1][2].
>
> Patch 1 implements the new _LS{I,R,W} methods, on top of old _DSM
> implementa
ry to switch to virtio_console?
Thank you
Robert
On 20/06/2023 10:41, Gerd Hoffmann wrote:
Hi,
The guest driver should be able to restore resources after resume.
Thank you for your suggestion!
As far as I know, resources are created on host side and guest has no backup,
if resources are destroyed, guest can't restore them.
Or do you me
201 - 300 of 1052 matches
Mail list logo
