S:
> return check_host_key_knownhosts(s, errp);
> default:
> --
> 2.39.2
Reviewed-by: Richard W.M. Jones
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
Fedora Windo
On Wed, Sep 11, 2024 at 02:46:18PM +0200, Maciej S. Szmigiero wrote:
> On 11.09.2024 14:37, Eric Blake wrote:
> >On Wed, Sep 11, 2024 at 07:33:59AM GMT, Eric Blake wrote:
> >>On Tue, Sep 10, 2024 at 03:15:28PM GMT, Pierrick Bouvier wrote:
> >>>Signed-off-by: Pierrick Bouvier
> >>>---
> >>
> >>A ge
The patches seem OK to me, but I don't really know enough about the
internals of qemu-nbd to give a line-by-line review. I did however
build and test qemu-nbd with the patches:
$ ./build/qemu-nbd /var/tmp/test.qcow2
$ nbdinfo nbd://localhost
...
can_multi_conn: false
$ ./build/
pretty much identical. I even learned about gnu_printf. So:
Reviewed-by: Richard W.M. Jones
Shouldn't there be a hunk which removes the definition of GCC_FMT_ATTR
from include/qemu/compiler.h? Maybe that's in another place in the
patch series.
Rich.
--
Richard Jones, Virtualization
On Wed, Mar 16, 2022 at 04:15:53PM -0500, Eric Blake wrote:
> On Wed, Mar 16, 2022 at 04:07:21PM -0500, Eric Blake wrote:
> > On Tue, Mar 15, 2022 at 01:14:41PM +, Richard W.M. Jones wrote:
> > > The patches seem OK to me, but I don't really know enough about the
> &g
y important implementation (the kernel) always fixes
this at 4000 (cryptsetup.git/lib/keymanage.c), so:
Reviewed-by: Richard W.M. Jones
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-builder quickly builds VMs from scratch
http://libguestfs.org/virt-builder.1.html
cious LUKS input, or if we're just
trying to sanity check the device hasn't been corrupted or improperly
prepared. The test above is the latter, I think.
Nevertheless as this is an improvement over the current situation:
Reviewed-by: Richard W.M. Jones
Rich.
--
Richard Jones, Virtualiz
priv.h | 143
> crypto/block-luks.c| 228 +++--
> tests/unit/test-crypto-block.c | 302 -
> 3 files changed, 542 insertions(+), 131 deletions(-)
> create mode 100644 crypto/block-luks-priv.h
I think there is on
On Tue, Sep 06, 2022 at 09:41:40AM +0100, Daniel P. Berrangé wrote:
> We already validate that LUKS keyslots don't overlap with the
> header, or with each other. This closes the remain hole in
remain -> remaining
> validation of LUKS file regions.
>
> Signed-off-by: Daniel P. Berrangé
> ---
>
dkit does this which is slightly different:
char cipher_name[33], cipher_mode[33], hash_spec[33];
/* Copy the header fields locally and ensure they are \0 terminated. */
memcpy (cipher_name, h->phdr.cipher_name, 32);
cipher_name[32] = 0;
memcpy (cipher_mode, h->phdr.cipher_mode, 32);
ci
Not sure if this is related, but builds are failing with:
FAILED: libblockdev.fa.p/block_export_fuse.c.o
cc -m64 -mcx16 -Ilibblockdev.fa.p -I. -I.. -Iqapi -Itrace -Iui -Iui/shader
-I/usr/include/fuse3 -I/usr/include/p11-kit-1 -I/usr/include/glib-2.0
-I/usr/lib64/glib-2.0/include -I/usr/includ
On Fri, Dec 03, 2021 at 04:20:23PM -0300, Eduardo Lima wrote:
> Hi Rich,
>
> Can you confirm if the patch you added for qemu in Fedora has still not been
> merged upstream? I could not find it on the git source tree.
>
> +Patch2: 0001-tcg-arm-Reduce-vector-alignment-requirement-for-NEON.patch
> +
On Fri, Dec 03, 2021 at 05:35:41PM -0300, Eduardo Lima wrote:
>
>
> On Fri, Dec 3, 2021 at 4:37 PM Richard W.M. Jones wrote:
>
> On Fri, Dec 03, 2021 at 04:20:23PM -0300, Eduardo Lima wrote:
> > Hi Rich,
> >
> > Can you confirm if the patch
s OK in the end.
The rest of the changes look good too, so:
Acked-by: Richard W.M. Jones
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
Fedora Windows cross-compiler. Compile Windows progr
On Thu, Dec 09, 2021 at 03:48:01PM +0100, Thomas Huth wrote:
> It's easier to do this in meson.build now.
>
> Signed-off-by: Thomas Huth
> ---
> v2: Added the missing "config_host_data.set('CONFIG_LIBSSH', libssh.found())"
>
> configure | 27 ---
> m
On Thu, Dec 09, 2021 at 04:08:24PM +0100, Thomas Huth wrote:
> On 09/12/2021 15.55, Richard W.M. Jones wrote:
> >On Thu, Dec 09, 2021 at 03:48:01PM +0100, Thomas Huth wrote:
> >>It's easier to do this in meson.build now.
> >>
> >>Signed-off-by: Thomas
qemu source tree with 'make clean; time make -j16'.
Before making this change the compile step took 449 & 447 seconds over
two consecutive runs.
After making this change, 428 & 422 seconds.
The saving is about 5%.
Thanks: Paolo Bonzini
Signed-off-by: Richard W.M. Jones
If you're interested in how I found this problem, it was done using
'perf report -a -g' & flamegraphs. This is the flamegraph of qemu (on
the host) when the guest is running the parallel compile:
http://oirase.annexia.org/tmp/qemu-riscv.svg
If you click into 'CPU_0/TCG' at the bottom left (all
v1 was here:
https://lists.nongnu.org/archive/html/qemu-devel/2023-10/msg02021.html
v2 is functionally exactly the same, except I changed
s/qemu cast/QOM cast/ in the comment, and added the Reviewed-by tag
received for the first version.
Rich.
qemu source tree with 'make clean; time make -j16'.
Before making this change the compile step took 449 & 447 seconds over
two consecutive runs.
After making this change, 428 & 422 seconds.
The saving is about 5%.
Thanks: Paolo Bonzini
Signed-off-by: Richard W.M. Jones
Reviewed-b
In v3:
- Use env_archcpu
- Rerun the benchmark to get new "after" figures
Rich.
qemu source tree with 'make clean; time make -j16'.
Before making this change the compile step took 449 & 447 seconds over
two consecutive runs.
After making this change: 428 & 421 seconds.
The saving is over 5%.
Thanks: Paolo Bonzini
Thanks: Philippe Mathieu-Daudé
Signed-off-by:
On Mon, Oct 09, 2023 at 08:36:28PM +0800, LIU Zhiwei wrote:
>
> On 2023/10/9 5:50, Richard W.M. Jones wrote:
> >RISCV_CPU(cs) uses a checked cast. When QOM cast debugging is enabled
> >this adds about 5% total overhead when emulating RV64 on x86-64 host.
> >
> >Usin
m-cast-debug.
>
> Inspired-by: Richard W.M. Jones
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> target/riscv/internals.h | 8
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/target/riscv/internals.h b/target/riscv/internals.h
> index b5f82
It was hard to tell from the comments whether the code applied to user
mode (CONFIG_USER_ONLY) or system mode. Fix the comments on the #else
and #endif directives to be clearer.
Signed-off-by: Richard W.M. Jones
---
accel/tcg/tb-maint.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions
On Thu, Jul 06, 2023 at 06:05:36PM +0100, Richard Henderson wrote:
> Share the setjmp cleanup between cpu_exec_step_atomic
> and cpu_exec_setjmp.
>
> Signed-off-by: Richard Henderson
Reviewed-by: Richard W.M. Jones
(I'm still testing the other one, but already up to 600
ed-by: Richard W.M. Jones
> Signed-off-by: Richard Henderson
Tested-by: Richard W.M. Jones
I tested it across two machines, total of 10,000 iterations successfully.
Great fix, thanks.
Rich.
> accel/tcg/internal.h | 30 -
> accel/tcg/cpu-exec.c | 4 +
> a
ed-by: Richard W.M. Jones
> Signed-off-by: Richard Henderson
> Tested-by: Richard W.M. Jones
I tested another 5,000 iterations successfully, so this one looks good
as well. I don't have an easy way to test qemu-user, so I only tested
qemu-system-x86_64.
Rich.
> ---
&g
I'm not sure if you meant v3 there, or if this is v2 rebased on top of
the main branch, but I tested it again and it passed 5,000 boots.
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
I filed this bug about recent Linux hanging very rarely when booting
on recent qemu:
https://gitlab.com/qemu-project/qemu/-/issues/1696
As I'm able to reproduce this bug at will (albeit I have to wait for
100s or 1000s of iterations of the test), I am able to observe the
qemu process after it han
On Thu, Mar 02, 2023 at 07:17:46PM +0530, Ayush Singh wrote:
> Hello Everyone,
>
> I am Ayush Singh, a 3rd-year university student from the Indian Institute of
> Technology (Indian School of Mines), Dhanbad, India. This email is just to
>
> I participated and successfully completed my GSoC 2022 P
-declaration]
4905 | qatomic_set(&prof->opt_time, prof->opt_time - profile_getclock());
| ^~~~
Signed-off-by: Richard W.M. Jones
---
tcg/tcg.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/tcg/tcg.c b/tcg/t
-declaration]
4905 | qatomic_set(&prof->opt_time, prof->opt_time - profile_getclock());
| ^~~~
Thanks: Philippe Mathieu-Daudé
Signed-off-by: Richard W.M. Jones
---
accel/tcg/tcg-accel-ops.c | 1 +
accel/tcg/trans
0
>
> Signed-off-by: Michael Young
Reviewed-by: Richard W.M. Jones
> ---
> include/hw/xen/xen_native.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/hw/xen/xen_native.h b/include/hw/xen/xen_native.h
> index 6f09c48823..04b1ef4d34 100644
On Fri, Dec 08, 2023 at 08:47:07AM +, Richard W.M. Jones wrote:
> (Adding Xen maintainers)
>
> On Thu, Dec 07, 2023 at 11:12:48PM +, Michael Young wrote:
> > Builds of qemu-8.2.0rc2 with xen-4.18.0 are currently failing
> > with errors like
> > ../h
On Fri, Dec 08, 2023 at 08:47:07AM +, Richard W.M. Jones wrote:
> (Adding Xen maintainers)
>
> On Thu, Dec 07, 2023 at 11:12:48PM +, Michael Young wrote:
> > Builds of qemu-8.2.0rc2 with xen-4.18.0 are currently failing
> > with errors like
> > ../h
7;CONFIG_XEN'] similar
> to what is already there for KVM, and fix xen_native.h.
Here's a Fedora scratch build with Xen 4.18.0 which includes this patch:
https://koji.fedoraproject.org/koji/taskinfo?taskID=110105806
Rich.
> Cc: Stefano Stabellini
> Cc: Richard W.M. Jones
Hey Paolo,
Quick question. I'm sure the transformation below is *not* correct,
because it doesn't preserve the invariant of the lockless structure.
Is there a way to do this while maintaining correctness? For example
putting barrier() after memset? (Note I'm also zeroing .pc which may
be a prob
On Mon, Oct 16, 2023 at 04:43:36PM +0100, Richard W.M. Jones wrote:
> Hey Paolo,
>
> Quick question. I'm sure the transformation below is *not* correct,
> because it doesn't preserve the invariant of the lockless structure.
> Is there a way to do this while maintaining
On Tue, Oct 31, 2023 at 02:17:56PM +0100, Kevin Wolf wrote:
> Am 17.10.2023 um 16:01 hat Philippe Mathieu-Daudé geschrieben:
> > Access QOM parent with the proper QOM VIRTIO_SCSI_COMMON() macro.
> >
> > Signed-off-by: Philippe Mathieu-Daudé
> > ---
> > hw/scsi/virtio-scsi.c | 2 +-
> > 1 file ch
On Tue, Oct 31, 2023 at 05:42:37PM +0100, Kevin Wolf wrote:
> Am 31.10.2023 um 14:48 hat Richard W.M. Jones geschrieben:
> > On Tue, Oct 31, 2023 at 02:17:56PM +0100, Kevin Wolf wrote:
> > > Am 17.10.2023 um 16:01 hat Philippe Mathieu-Daudé geschrieben:
> > > > Acc
On Fri, Sep 01, 2023 at 12:24:30PM +0200, Kevin Wolf wrote:
> Document the 'compression_type' option for qcow2, and mention that
> streamOptimized vmdk supports compression, too.
>
> Reported-by: Richard W.M. Jones
> Signed-off-by: Kevin Wolf
Looks good, so:
Review
ocket_listen().
> > >>
> > >> Drop the num argument from socket_get_fd() since this function is also
> > >> called by socket_connect() where a listen backlog value does not make
> > >> sense.
> > >>
> > >
On Tue, Oct 25, 2016 at 03:09:51PM +0800, Fam Zheng wrote:
> On Mon, 10/24 12:11, Kevin Wolf wrote:
> > Am 22.10.2016 um 03:00 hat Max Reitz geschrieben:
> > >
> > >
> > > I personally still don't like making locking a qdev property very much
> > > because it doesn't make sense to me*. But I reme
On Tue, Oct 25, 2016 at 04:54:28AM +0200, Max Reitz wrote:
> Currently, curl defines its own constant SECTOR_SIZE. There is no
> advantage over using the global BDRV_SECTOR_SIZE, so drop it.
>
> Cc: qemu-sta...@nongnu.org
> Signed-off-by: Max Reitz
> ---
> block/curl.c | 11 +--
> 1 file
On Tue, Oct 25, 2016 at 04:54:29AM +0200, Max Reitz wrote:
> While commit 38bbc0a580f9f10570b1d1b5d3e92f0e6feb2970 is correct in that
> the callback is supposed to return the number of bytes handled; what it
> does not mention is that libcurl will throw an error if the callback did
> not "handle" a
As well as testing patch 2 on its own, I also tested all 4 patches
together on top of current qemu from git.
In summary, it seems to work fine and doesn't break http or https as
far as I can tell.
Rich.
$ http_proxy= LIBGUESTFS_BACKEND=direct
LIBGUESTFS_HV=~/d/qemu/x86_64-softmmu/qemu-system-x8
On Mon, Oct 31, 2016 at 05:01:44PM -0500, Eric Blake wrote:
> On 10/31/2016 10:38 AM, Fam Zheng wrote:
> > This implements open flag sensible image locking for local file
> > and host device protocol.
> >
> > virtlockd in libvirt locks the first byte, so we start looking at the
> > file bytes fro
On Wed, Sep 07, 2016 at 03:36:38PM -0400, Stefan Hajnoczi wrote:
> On Tue, Sep 06, 2016 at 12:44:39PM +0430, Aarian P. Aleahmad wrote:
> > I am looking for a solution to cache a VM on a SSD without the guest
> > knowing about it. We can do it by caching the disk on which the VM's disk
> > is lcoate
On Fri, Sep 09, 2016 at 01:03:49PM +0200, Tomáš Golembiovský wrote:
> Hi,
>
> recently we (oVirt) have started discussing whether the way virt-v2v
> handles import from OVA files is good. And I would be interested in
> ideas how it can be improved. It is likely somebody already gave some
> thought
On Mon, Nov 28, 2016 at 05:49:04PM -0800, Li Qiang wrote:
> From: Li Qiang
>
> When the Intel 6300ESB watchdog is hot unplug. The timer allocated
> in realize isn't freed thus leaking memory leak. This patch avoid
> this through adding the exit function.
I will just note that the real hardware i
On Tue, Nov 29, 2016 at 04:56:55PM +0800, Li Qiang wrote:
> Hi
>
> 2016-11-29 16:39 GMT+08:00 Richard W.M. Jones :
>
> > On Mon, Nov 28, 2016 at 05:49:04PM -0800, Li Qiang wrote:
> > > From: Li Qiang
> > >
> > > When the Intel 6300ESB watchdog is hot
On Tue, Sep 20, 2016 at 01:35:29PM +0200, Tomáš Golembiovský wrote:
> The second patch tries to solve the situation when you have file:
>
> || some data ; image ; some more data ||
>
> In this case there is no way to say where the image ends and client may
> also access content in the "some m
When using 'qemu-img create', if the file being created already
exists, then qemu-img tries to read it first. This has some
unexpected effects:
$ rm test.qcow2
$ qemu-img create -f qcow2 -o compat=1.1,preallocation=off test.qcow2 1G
Formatting 'test.qcow2', fmt=qcow2 size=1073741824 compat=1.1
On Tue, Nov 08, 2016 at 03:05:24PM +0100, Kevin Wolf wrote:
> [ Cc: qemu-block ]
>
> Am 08.11.2016 um 11:58 hat Richard W.M. Jones geschrieben:
> > When using 'qemu-img create', if the file being created already
> > exists, then qemu-img tries to read it first
On Thu, Feb 23, 2017 at 05:07:47PM -0300, Eduardo Habkost wrote:
> Ping?
>
> As v1 was sitting on the list since Jan 19, if there are no
> objections I will merge this and include in my next pull request
> before soft freeze.
Do you have a copy which applies on top of current HEAD? I get
loads o
On Fri, Feb 24, 2017 at 09:26:30AM -0300, Eduardo Habkost wrote:
> On Thu, Feb 23, 2017 at 09:57:41PM +0000, Richard W.M. Jones wrote:
> > On Thu, Feb 23, 2017 at 05:07:47PM -0300, Eduardo Habkost wrote:
> > > Ping?
> > >
> > > As v1 was sitting on th
I'm please to announce libguestfs 1.36, a library and a set of tools
for accessing and modifying virtual machine disk images.
This release represents about 7 months of work by many contributors.
I'd like to call out in particular substantial code contributions
from: Pino Toscano, Tomáš Golembiovsk
v(lines);
> +}
> +} while (FindNextVolumeW(handle, guid, ARRAYSIZE(guid)));
> +
> +FindVolumeClose(handle);
> +return resp;
> }
>
> typedef enum {
> @@ -1416,7 +1507,7 @@ GList *ga_command_blacklist_init(GList *blacklist)
>
On Sat, Oct 08, 2016 at 04:14:06PM +0530, Ashijeet Acharya wrote:
> Introduce new object 'BlockdevOptionsSsh' in qapi/block-core.json to
> support blockdev-add for SSH network protocol driver. Use only 'struct
> InetSocketAddress' since SSH only supports connection over TCP.
>
> +##
> +# @Blockde
On Thu, Oct 20, 2016 at 05:15:24PM +0200, Pino Toscano wrote:
> Rewrite the implementation of the ssh block driver to use libssh instead
> of libssh. The libssh library has various advantages over libssh:
> - easier API for authentication (for example for using ssh-agent)
> - easier API for known_
On Thu, Oct 20, 2016 at 05:44:41PM +0200, Pino Toscano wrote:
> On Thursday, 20 October 2016 16:32:50 CEST Richard W.M. Jones wrote:
> > On Thu, Oct 20, 2016 at 05:15:24PM +0200, Pino Toscano wrote:
> > > Rewrite the implementation of the ssh block driver to use libssh inste
On Fri, Oct 21, 2016 at 01:16:11PM +0200, Pino Toscano wrote:
> Rewrite the implementation of the ssh block driver to use libssh instead
> of libssh2. The libssh library has various advantages over libssh2:
> - easier API for authentication (for example for using ssh-agent)
> - easier API for know
On Fri, Oct 21, 2016 at 05:30:39PM +0200, Pino Toscano wrote:
> On Friday, 21 October 2016 13:02:21 CEST Richard W.M. Jones wrote:
> > On Fri, Oct 21, 2016 at 01:16:11PM +0200, Pino Toscano wrote:
> > > Rewrite the implementation of the ssh block driver to use libssh instead
>
On Thu, Jul 21, 2016 at 09:44:52AM -0500, miny...@acm.org wrote:
> From: Corey Minyard
>
> Add an unrealize function to free the timer allocated in the
> realize function.
>
> Signed-off-by: Corey Minyard
> Cc: Richard W.M. Jones
> Cc: Marc-André Lureau
> ---
>
On Thu, Jul 21, 2016 at 09:44:51AM -0500, miny...@acm.org wrote:
> From: Corey Minyard
>
> Add an exit function to free the timer allocated in the
> realize function.
>
> Signed-off-by: Corey Minyard
> Cc: Richard W.M. Jones
> Cc: Marc-André Lureau
> ---
>
On Fri, Jul 22, 2016 at 05:26:27AM -0400, Marc-André Lureau wrote:
> btw, I do not how to test this yet either.
I have a little test framework for the watchdog device which cuts
through a lot of the BS with running the full watchdog daemon, and
also has some simple instructions to follow:
http:
On Fri, Aug 05, 2016 at 11:34:57AM +0200, Paolo Bonzini wrote:
> GCC compiles linuxboot_dma.c to 921 bytes, while clang needs 1527.
> This causes the API to break between a GCC-compiled ROM and
> one that was obtained with clang.
I don't understand this justification. Which API? Between which
bi
On Fri, Aug 05, 2016 at 08:02:25AM -0400, Paolo Bonzini wrote:
>
> > On Fri, Aug 05, 2016 at 11:34:57AM +0200, Paolo Bonzini wrote:
> > > GCC compiles linuxboot_dma.c to 921 bytes, while clang needs 1527.
> > > This causes the API to break between a GCC-compiled ROM and
> > > one that was obtained
Thanks for reposting this Paolo.
I tested it by applying it on top of qemu. In libguestfs sources we
have a benchmark program called utils/boot-benchmark/boot-benchmark.
Using the qemu package from Fedora (qemu-2.6.0-3.fc24.x86_64):
$ killall -STOP firefox
$ ./boot-benchmark
Result: 2341.
On Wed, Jun 14, 2017 at 08:53:18AM -0400, Jeff Cody wrote:
> Change from v2:
> Add warning message that this is an unsupported option that may
> be deprecated in the future.
>
> We need to be able to parse the 'filename' option for rbd and iscsi, because
> there may exist images in the wild that h
On Mon, Jun 26, 2017 at 12:12:05PM +0100, Daniel P. Berrange wrote:
> On Mon, Jun 26, 2017 at 10:28:38AM +0200, Kevin Wolf wrote:
> > [ Cc: qemu-devel; don't post to qemu-block only! ]
> >
> > Am 26.06.2017 um 09:57 hat Peter Lieven geschrieben:
> > > Hi,
> > >
> > > I am currently working on opt
; copy on read is refactored into its own filter driver.
>
> Reported-by: Richard W.M. Jones
> Signed-off-by: Kevin Wolf
Thanks Kevin. As this is essentially the same as the patch I tested
last night,
Reviewed-by: Richard W.M. Jones
Rich.
> block/io.c | 9 -
> 1
Hi Paolo,
I was looking for documentation on the limits of #controllers,
#channels, #targets, #LUNs, #disks in virtio-scsi, and couldn't find
any, so I thought I would create that documentation instead. I wonder
if you could check that the following is correct information. Also -
at the bottom o
On Tue, Apr 18, 2017 at 05:30:52PM +0200, Paolo Bonzini wrote:
> > When I changed libguestfs to use LUNs instead of targets (target=0
> > unit=i), I got a peculiar bug. It looks like there is some kind of
> > race when enumerating the device, where /sys is populated before the
> > device is actual
On Tue, Apr 18, 2017 at 06:17:03PM +0100, Richard W.M. Jones wrote:
> On Tue, Apr 18, 2017 at 05:30:52PM +0200, Paolo Bonzini wrote:
> > > When I changed libguestfs to use LUNs instead of targets (target=0
> > > unit=i), I got a peculiar bug. It looks like there is some ki
and eventually reports a timeout because I don't really
have a Ceph server]
So I would say that these patches, superficially at least, do seem to
work. Although I wasn't able to test them against a real Ceph server.
Tested-by: Richard W.M. Jones
Rich.
--
Richard Jones, Virtualizati
descriptor range.
This change partially implements socket activation for qemu-nbd. If
the environment variables are set correctly, then socket activation
will happen automatically, otherwise everything works as before. The
limitation is that LISTEN_FDS must be 1.
Signed-off-by: Richard W.M. Jones
Socket activation (sometimes known as systemd socket activation)
allows an Internet superserver to pass a pre-opened listening socket
to the process, instead of having qemu-nbd open a socket itself. This
is done via the LISTEN_FDS and LISTEN_PID environment variables, and a
standard file descripto
v2:
- A few small fixed identified by Dan Berrange.
The original cover letter is below.
Rich.
Socket activation (sometimes known as systemd socket activation)
allows an Internet superserver to pass a pre-opened listening socket
to the process, instead of having qemu-nbd open a socket itself.
descriptor range.
This change partially implements socket activation for qemu-nbd. If
the environment variables are set correctly, then socket activation
will happen automatically, otherwise everything works as before. The
limitation is that LISTEN_FDS must be 1.
Signed-off-by: Richard W.M. Jones
On Fri, Feb 03, 2017 at 03:16:43PM +, Stefan Hajnoczi wrote:
> On Thu, Feb 02, 2017 at 05:16:25PM +0000, Richard W.M. Jones wrote:
> > +if (*port == NULL) {
> > +*port = g_strdup_printf("%d", NBD_DEFAULT_PORT);;
>
> Please stringify NB
v2 -> v3:
- Changes suggested by Stefan.
- Retested it, using my socket activation code in virt-p2v:
https://www.redhat.com/archives/libguestfs/2017-February/msg00036.html
Rich.
descriptor range.
This change partially implements socket activation for qemu-nbd. If
the environment variables are set correctly, then socket activation
will happen automatically, otherwise everything works as before. The
limitation is that LISTEN_FDS must be 1.
Signed-off-by: Richard W.M. Jones
On Thu, Feb 02, 2017 at 08:42:33PM +0100, Markus Armbruster wrote:
> There's also the -drive file=json:... syntax. It's a bad fit for
> QemuOpts, because QemuOpts and JSON fight for the comma. I'd show you
> if I could get it to work.
I think this refers to the json: syntax for qemu URIs?
Anywa
On Fri, Feb 03, 2017 at 09:31:43AM -0800, Paolo Bonzini wrote:
>
>
> On 03/02/2017 09:09, Richard W.M. Jones wrote:
> > + const char *port,
> > + bool fork_process)
>
On Fri, Feb 03, 2017 at 10:58:15AM -0800, Paolo Bonzini wrote:
> On 03/02/2017 10:56, Richard W.M. Jones wrote:
> > On Fri, Feb 03, 2017 at 09:31:43AM -0800, Paolo Bonzini wrote:
> >> On 03/02/2017 09:09, Richard W.M. Jones wrote:
> >>> +if (fork_process) {
>
descriptor range.
This change partially implements socket activation for qemu-nbd. If
the environment variables are set correctly, then socket activation
will happen automatically, otherwise everything works as before. The
limitation is that LISTEN_FDS must be 1.
Signed-off-by: Richard W.M. Jones
descriptor range.
This change partially implements socket activation for qemu-nbd. If
the environment variables are set correctly, then socket activation
will happen automatically, otherwise everything works as before. The
limitation is that LISTEN_FDS must be 1.
Signed-off-by: Richard W.M. Jones
v3 -> v5:
- Use stringify() macro (thanks Markus).
- Remove --fork restriction again.
- Retest with virt-p2v.
Rich.
v3 -> v4:
- Remove restriction on --fork again.
- Retest the patch using virt-p2v.
Rich.
On Mon, Feb 06, 2017 at 05:10:13PM +0100, Paolo Bonzini wrote:
> Queued, thanks.
Could you change this comment s/!_WIN32/_WIN32/, or do you
want me to submit another patch?
> > +#else /* !_WIN32 */
> > +static unsigned int check_socket_activation(void)
> > +{
> > +return 0;
> > +}
> > +#endif
No I'm afraid this patch series does not fix the bug.
The stack trace is below.
Rich.
Thread 4 (Thread 0x7f8595cf1700 (LWP 11235)):
#0 0x7f86348e6700 in do_futex_wait () at /lib64/libpthread.so.0
#1 0x7f86348e6813 in __new_sem_wait_slow () at /lib64/libpthread.so.0
#2 0x5610e4585
On Tue, May 09, 2017 at 07:05:51AM -0700, Richard Henderson wrote:
> On 05/09/2017 06:27 AM, Daniel P. Berrange wrote:
> >This enables report of a signature in CPUID for the TCG
> >interpretor.
> >
> >Changed in v4:
> >
> > - Report 0x4001 in EAX for 0x4000 index (Eduardo)
> > - Report al
On Tue, May 09, 2017 at 12:03:30PM -0400, Jeff Cody wrote:
> On Tue, May 09, 2017 at 11:15:06AM +0100, Richard W.M. Jones wrote:
> >
> > No I'm afraid this patch series does not fix the bug.
> >
> > The stack trace is below.
> >
> > Rich.
> >
gt; I tested this by lowering CURL_NUM_STATES to 2. With this change, the
> buggy case triggers a couple times while booting a Fedora netinst image.
This series fixes the original bug, so:
Tested-by: Richard W.M. Jones
I think the Reported-by in patch 3 should credit Kun Wei for finding
On Mon, May 15, 2017 at 09:12:54PM +0200, Max Reitz wrote:
> On 2017-05-10 17:57, Richard W.M. Jones wrote:
> > On Wed, May 10, 2017 at 04:31:58PM +0200, Paolo Bonzini wrote:
> >> Since the last patch in v1 didn't work, I bit the bullet and converted
> >> the whole
can be used for both, but that's what this patch does. The
> main change is to replace get_listen_fds's "consume" argument with
> the FIRST_SOCKET_ACTIVATION_FD macro from the qemu-nbd code.
>
> Cc: "Richard W.M. Jones"
> Cc: Stefan Hajnoczi
&g
On Thu, Mar 16, 2017 at 05:36:40PM +0100, Paolo Bonzini wrote:
> qemu-ga's socket activation support was not obeying the LISTEN_PID
> environment variable, which avoids that a process uses a socket-activation
> file descriptor meant for its parent.
>
> Mess can for example ensue if a process forks
I'm pleased to announce libguestfs 1.34, a library and set of tools
for accessing and modifying virtual machine disk images.
This release took about 8 months of work by many contributors.
Amongst the new features are large performance improvements,
substantial enhancements to virt-p2v & virt-v2v,
801 - 900 of 1264 matches
Mail list logo
