On Mon, Dec 14, 2009 at 03:35:07PM +0200, Naphtali Sprei wrote:
> block.c | 29 +
> block.h |7 +--
> hw/xen_disk.c |3 ++-
> monitor.c |2 +-
> qemu-config.c |4 ++--
> qemu-img.c| 14 --
> qemu-nbd.c|2 +-
We're tracing a bug in "qemu-img convert" where it will silently fail
to convert certain types of VMDK file. The VMDK files produced by
VMWare vSphere / ESX 4.0, which have the VMDK subformat
"streamOptimized" are one notable case:
https://bugzilla.redhat.com/show_bug.cgi?id=548723
These two
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
virt-p2v converts physical machines to virtual machines. Boot with a
live CD or over the network (PXE) and turn machines into Xen guests.
http://et.redhat.com/~rjones/virt-p2v
>From 69701355561c328fac5e7986d6122c841
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
virt-p2v converts physical machines to virtual machines. Boot with a
live CD or over the network (PXE) and turn machines into Xen guests.
http://et.redhat.com/~rjones/virt-p2v
>From bc09a7473b0382fbac7c3702b668acc1b
Let's fix a buffer overflow, and add the Signed-off-by line ...
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
virt-top is 'top' for virtual machines. Tiny program with many
powerful monitoring features, net stats, disk stats, logging, etc.
http://et.red
Add Signed-off-by line.
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
libguestfs lets you edit virtual machines. Supports shell scripting,
bindings from many languages. http://et.redhat.com/~rjones/libguestfs/
See what it can do: http://et.redhat.com/~
On Sun, Dec 13, 2009 at 08:24:54AM +, Blue Swirl wrote:
> I guess e1c09175bc00dd8dfb2ad1b26e1858dcdc109b59 or
> 998bbd74b9d813b14a3a3b5009a5d5a48c7dce51 broke -serial stdio for all
> targets:
> qemu -serial stdio -monitor stdio
> chardev: opening backend "stdio" failed
> qemu: could not open se
On Thu, Jan 07, 2010 at 11:55:05AM +, Richard W.M. Jones wrote:
> chardev: opening backend "stdio" failed
> qemu: could not open serial device 'stdio': Invalid argument
Or sometimes:
chardev: opening backend "stdio" failed
qemu: could not open serial d
On Thu, Jan 07, 2010 at 01:32:09PM +0100, Gerd Hoffmann wrote:
> Hi,
>
>> So what seems to be happening here is there is an implicit monitor
>> being set up which grabs stdio. Because:
>>
>>#define STDIO_MAX_CLIENTS 1
>>
>> my own -serial stdio option subsequently fails. This is a regressio
On Thu, Jan 07, 2010 at 12:44:17PM +, Daniel P. Berrange wrote:
> On Thu, Jan 07, 2010 at 06:34:13AM -0600, Anthony Liguori wrote:
> > On 01/07/2010 05:55 AM, Richard W.M. Jones wrote:
> > >On Sun, Dec 13, 2009 at 08:24:54AM +, Blue Swirl wrote:
>
On Tue, Oct 13, 2009 at 01:26:25PM +0200, Bolle wrote:
> Did anybody had success to start a QEMU instance by a PHP script under
> the Apache web server ?
>
> I allow the Apache user with the help of sudoers to start the QEMU binary
> as root. I've hacked the "qemu-socket.c" to set the access mode
On Tue, Oct 20, 2009 at 12:43:44PM +0530, Amit Shah wrote:
> DEF("virtioconsole", HAS_ARG, QEMU_OPTION_virtiocon, \
> "-virtioconsole c\n" \
> -"set virtio console\n")
> +"define virtio console\n")
It would be much better to add a detectable string her
On Tue, Oct 20, 2009 at 05:31:23PM +0530, Amit Shah wrote:
> How about (deprecated)? (We need to have this in some general policy of
> deprecating command-line options.)
No, the important thing is that we can detect somehow that multiport
virtio console is possible for some random version of qemu
Current .gitmodules contains:
[submodule "roms/vgabios"]
path = roms/vgabios
url = ../vgabios.git
[submodule "roms/seabios"]
path = roms/seabios
url = ../seabios.git
but these URLs don't work for me. They resolve to URLs like
git://git.savannah.non
Hi,
I was looking for a way to collect information on the amount of data
being written and read from block devices. The attached patch adds a
few counters to the BlockDriverState structure to collect this
information, and a new "info blockstats" monitor command to display it.
This screensho
This is an updated patch for collecting block device statistics. Thanks
to several people on #qemu channel for giving me feedback about the
first version[1].
This patch collects per-block-device statistics and allows them to be
displayed in the monitor through a 'info blockstats' command. It
Anthony Liguori wrote:
Daniel P. Berrange wrote:
Or have 2 monitor interaction modes. One mode uses the command line style
suitable for people / scripting languages. The other umode ses a
binary XDR
protocol for serializing the args & returns values for formal control
APIs to use in a easy man
Avi Kivity wrote:
libqemumonitor.so is an excellent idea. perhaps the libvirt code can be
used as a base?
We should also provide bindings to the saner languages that management
apps are typically written in.
Libvirt has most of the major languages covered now. The only language
I'm aware o
On Tue, Aug 02, 2022 at 12:41:34PM -0400, Daniel P. Berrangé wrote:
> The latest glibc 2.36 has extended sys/mount.h so that it
> defines the FSCONFIG_* enum constants. These are historically
> defined in linux/mount.h, and thus if you include both headers
> the compiler complains:
>
> In file inc
On Tue, Aug 02, 2022 at 07:29:29PM +0100, Richard W.M. Jones wrote:
> Dan, which Fedora glibc package shows this problem? I have
> glibc-2.35.9000-31.fc37.x86_64 and qemu compiled fine. (Also nbdkit
> which includes linux/fs.h)
It would help if I enabled a *-linux-user target ...
Y
On Wed, Aug 03, 2022 at 12:07:19PM +0100, Alberto Faria wrote:
> On Wed, Aug 3, 2022 at 11:46 AM Dr. David Alan Gilbert
> wrote:
> >
> > * Alberto Faria (afa...@redhat.com) wrote:
> > > Make non-void static functions whose return values are ignored by
> > > all callers return void instead.
> > >
>
On Wed, Aug 03, 2022 at 01:25:34PM +0100, Peter Maydell wrote:
> On Wed, 3 Aug 2022 at 12:44, Daniel P. Berrangé wrote:
> > Inconsistent return value checking is designed-in behaviour for
> > QEMU's current Error handling coding pattern with error_abort/fatal.
>
> Yes; I habitually mark as false-
On Mon, Jul 31, 2023 at 11:40:36AM -0400, Stefan Hajnoczi wrote:
> 3. Using buffered I/O because O_DIRECT is not universally supported?
>
> If you can't use O_DIRECT, then qemu-img could be extended to manage its
> dirty page cache set carefully. This consists of picking a budget and
> writing bac
Repost of the same patch as a minute ago because I messed up a couple
of email addresses in the CC.
Rich.
int64_t *’ {aka ‘long long
unsigned int *’} but argument is of type ‘size_t *’ {aka ‘unsigned int *’}
49 | int blkio_get_uint64(struct blkio *b, const char *name, uint64_t
*value);
| ~~^
Signed-off-by: Richard W.M. Jones
---
On Tue, Jan 30, 2024 at 09:51:59AM +0100, Kevin Wolf wrote:
> Am 29.01.2024 um 19:53 hat Richard W.M. Jones geschrieben:
> > With GCC 14 the code failed to compile on i686 (and was wrong for any
> > version of GCC):
> >
> > ../block/blkio.c: In function ‘blkio_file_open
On Tue, Jan 30, 2024 at 01:04:46PM +0100, Kevin Wolf wrote:
> Am 30.01.2024 um 11:30 hat Richard W.M. Jones geschrieben:
> > On Tue, Jan 30, 2024 at 09:51:59AM +0100, Kevin Wolf wrote:
> > > Am 29.01.2024 um 19:53 hat Richard W.M. Jones geschrieben:
> > > > With GCC
int64_t *’ {aka ‘long long
unsigned int *’} but argument is of type ‘size_t *’ {aka ‘unsigned int *’}
49 | int blkio_get_uint64(struct blkio *b, const char *name, uint64_t
*value);
| ~~^
Signed-off-by: Richard W.M. Jones
---
gerror) {
> +warn_report("Failed to parse SSH URI parameters '%s'.",
> + uri_query);
> +break;
> +}
> +/*
> + * Pick out the query parameters that we understand, and ignore
l IPv6 address */
> -if (uri->server[0] == '[') {
> -host = qstring_from_substr(uri->server, 1,
> - strlen(uri->server) - 1);
> -} else {
> -host = qstring_from_str(uri->server);
> - }
> -
On Thu, Mar 28, 2024 at 10:06:01AM -0500, Eric Blake wrote:
> Adjusting cc list to add upstream NBD and drop developers unrelated to
> this part of the qemu series...
>
> On Thu, Mar 28, 2024 at 02:13:42PM +0000, Richard W.M. Jones wrote:
> > On Thu, Mar 28, 2024 at 03:06:03PM
On Thu, Mar 28, 2024 at 04:40:10PM +, Richard W.M. Jones wrote:
> libnbd absolutely does *not* get this right, eg:
>
> $ nbdinfo NBD://localhost
> nbdinfo: nbd_connect_uri: unknown NBD URI scheme: NBD: Invalid argument
>
> so that's a bug too.
Proposed fix:
ht
On Tue, Apr 23, 2024 at 10:11:50AM -0400, Cole Robinson wrote:
> Hi,
>
> hppa-firmware.img and hppa-firmware64.img in qemu.git are missing ELF
> build-id annotations. rpm builds on Fedora will error if an ELF binary
> doesn't have build-id:
>
> RPM build errors:
> Missing build-id in
> /tmp/r
On Thu, May 02, 2019 at 08:02:01PM +0200, Kashyap Chamarthy wrote:
> [Reviving this old thread as I don't think we came to a conclusion on
> this.]
I guess the best thing is to submit the obvious 1 line patch and see
what people think about it? (I agree the default ought to be changed.)
Rich.
-
tropy from and if omitted defaults to @option{/dev/random}.
> +entropy from and if omitted defaults to @option{/dev/urandom}.
>
> @item -object rng-egd,id=@var{id},chardev=@var{chardevid}
I think this is a very sensible change, removing a bit of superstition
about randomness.
Revie
The series seems fine, so:
Acked-by: Richard W.M. Jones
If it was me I'd be inclined to file a bug against Ubuntu and get them
to fix their broken package instead :-)
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programmin
I'm pleased to announce a new high performance Network Block Device
(NBD) client library called libnbd. It's written in C and there are
also bindings available for Python, OCaml and (soon) Rust.
0.9.8 is the third pre-release before the stable 1.0 version where we
freeze the API, so feedback on A
On Thu, Aug 15, 2019 at 01:50:24PM -0500, Eric Blake wrote:
> The NBD specification defines NBD_FLAG_CAN_MULTI_CONN, which can be
> advertised when the server promises cache consistency between
> simultaneous clients (basically, rules that determine what FUA and
> flush from one client are able to
On Fri, Jul 26, 2019 at 04:09:52PM +0200, Pino Toscano wrote:
> These two patches add the password and private key authentication
> methods to the ssh block driver, using secure objects for
> passwords/passphrases.
I was attempting to test this but couldn't work out the full command
line to use it
On Fri, Jul 26, 2019 at 09:24:34AM -0500, Eric Blake wrote:
> On a different topic, how much of this work overlaps with the nbdkit ssh
> plugin? Should we be duplicating efforts with both projects supporting
> ssh natively, or is it worth considering getting qemu out of the ssh
> business and inste
On Fri, Jul 26, 2019 at 04:45:03PM +0200, Pino Toscano wrote:
> On Friday, 26 July 2019 16:27:11 CEST Richard W.M. Jones wrote:
> > On Fri, Jul 26, 2019 at 04:09:52PM +0200, Pino Toscano wrote:
> > > These two patches add the password and private key authentication
> > &g
On Fri, Jul 26, 2019 at 10:06:43AM -0500, Eric Blake wrote:
> On 7/26/19 9:45 AM, Pino Toscano wrote:
> > On Friday, 26 July 2019 16:27:11 CEST Richard W.M. Jones wrote:
> >> On Fri, Jul 26, 2019 at 04:09:52PM +0200, Pino Toscano wrote:
> >>> These two patches ad
On Wed, Aug 07, 2019 at 02:30:18PM -0700, ivo welch wrote:
> hi richard---please forgive us. another quickie. we created an nbd
> device. just a block device...no partitions, etc. in the guest vm, we
> wrote a short C program that writes one sector (open file, fseek, fwrite,
> close file) and t
On Sat, Feb 08, 2020 at 01:25:28AM +0200, Mykola Ivanets wrote:
> From: Nikolay Ivanets
>
> I faced with situation where libguestfs cannot recognize partitions on a
> disk image which was partitioned on a system with "4K native" sector
> size support.
Do you have a small test case for this?
> I
On Mon, Feb 10, 2020 at 02:28:08PM +0200, Nikolay Ivanets wrote:
> пн, 10 лют. 2020 о 13:43 Richard W.M. Jones пише:
> >
> > On Sat, Feb 08, 2020 at 01:25:28AM +0200, Mykola Ivanets wrote:
> > > From: Nikolay Ivanets
> > >
> > > I faced with situation wh
On Mon, Feb 10, 2020 at 04:15:40PM +0200, Nikolay Ivanets wrote:
> пн, 10 лют. 2020 о 15:48 Kevin Wolf пише:
> >
> > Am 10.02.2020 um 12:43 hat Richard W.M. Jones geschrieben:
> > > On Sat, Feb 08, 2020 at 01:25:28AM +0200, Mykola Ivanets wrote:
> > > > From
On Mon, Feb 10, 2020 at 03:37:20PM -0600, Eric Blake wrote:
> For now, only 2 of those 16 bits are defined: NBD_INIT_SPARSE (the
> image has at least one hole) and NBD_INIT_ZERO (the image reads
> completely as zero); the two bits are orthogonal and can be set
> independently, although it is easy e
On Mon, Feb 10, 2020 at 04:29:53PM -0600, Eric Blake wrote:
> On 2/10/20 4:12 PM, Richard W.M. Jones wrote:
> >On Mon, Feb 10, 2020 at 03:37:20PM -0600, Eric Blake wrote:
> >>For now, only 2 of those 16 bits are defined: NBD_INIT_SPARSE (the
> >>image has at least one h
On Wed, Feb 12, 2020 at 06:09:11AM -0600, Eric Blake wrote:
> On 2/12/20 1:27 AM, Wouter Verhelst wrote:
> >Hi,
> >
> >On Mon, Feb 10, 2020 at 10:52:55PM +0000, Richard W.M. Jones wrote:
> >>But anyway ... could a flag indicating that the whole image is sparse
&g
On Tue, Feb 11, 2020 at 08:31:01PM -0600, Eric Blake wrote:
> The NBD URI specification [1] states that only one leading slash at
> the beginning of the URI path component is stripped, not all such
> slashes. This becomes important to a patch I just proposed to nbdkit
> [2], which would allow the
On Fri, Jan 27, 2023 at 03:26:15PM -0600, Eric Blake wrote:
> In https://bugzilla.redhat.com/show_bug.cgi?id=2055229, the question
> was raised on how to make qemu-storage-daemon sufficiently powerful to
> be a full-blown replacement to qemu-nbd. One of the features still
> lacking is the ability
On Mon, Jan 30, 2023 at 02:58:01PM +, Daniel P. Berrangé wrote:
> Obviously at startup QEMU can trivially inherit the FDs from whatever
> spawned it. The only task is to identify the FDs that are passed into,
> and systemd defined a mechanism for this using LISTEN_FDNAMES. IOW the
> socket acti
On Mon, Jan 30, 2023 at 04:45:08PM +, Daniel P. Berrangé wrote:
> which is LISTEN_FDS=2, LISTEN_FDNAMES=control,vnc
Colon for separating the elements not comma.
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog
[ Patch series also available here, along with this cover letter and the
script used to generate test results:
https://gitlab.com/rwmjones/qemu/-/commits/2023-nbd-multi-conn-v1 ]
This patch series adds multi-conn support to the NBD block driver in
qemu. It is only meant for discussion and tes
the zeroth slot in the conns[] array. Thus this does
not implement multi-conn yet.
Signed-off-by: Richard W.M. Jones
---
block/coroutines.h | 5 +-
block/nbd.c| 674 -
2 files changed, 358 insertions(+), 321 deletions(-)
diff --git a/block
on size of requests outstanding) the load on each
connection. But this implementation doesn't do any of that.
Signed-off-by: Richard W.M. Jones
---
block/nbd.c | 67 +++--
1 file changed, 49 insertions(+), 18 deletions(-)
diff --git a/block/nb
le or shortlived NBD
operations do not require multiple connections to be made.
Signed-off-by: Richard W.M. Jones
---
block/nbd.c | 128
1 file changed, 90 insertions(+), 38 deletions(-)
diff --git a/block/nbd.c b/block/nbd.c
index 84e8a
not advertise that
it is safe for multi-conn then this setting is forced to 1.
Signed-off-by: Richard W.M. Jones
---
block/nbd.c | 24
1 file changed, 24 insertions(+)
diff --git a/block/nbd.c b/block/nbd.c
index bf2894ad5c..5ffae0b798 100644
--- a/block/nbd.c
+++ b/block/nb
On Fri, Mar 10, 2023 at 01:04:12PM -0600, Eric Blake wrote:
> How many of these timing numbers can be repeated with TLS in the mix?
While I have been playing with TLS and kTLS recently, it's not
something that is especially important to v2v since all NBD traffic
goes over Unix domain sockets only
On Fri, Mar 10, 2023 at 04:17:17PM -0600, Eric Blake wrote:
> On Thu, Mar 09, 2023 at 11:39:43AM +0000, Richard W.M. Jones wrote:
> > + * safe for multi-conn, force it to 1.
> > + */
> > +if (!(s->info.flags & NBD_FLAG_CAN_MULTI_CONN)) {
&g
On Mon, Sep 27, 2021 at 04:18:34PM -0500, Eric Blake wrote:
> On Fri, Jul 23, 2021 at 11:33:03AM +0100, Richard W.M. Jones wrote:
> > Under SELinux, Unix domain sockets have two labels. One is on the
> > disk and can be set with commands such as chcon(1). There is a
> > diff
On Wed, Sep 29, 2021 at 10:01:55AM +0200, Michal Privoznik wrote:
> Apparently, parsing vmx.genid is not as easy as I thought. Anyway, it
> was brought up in a private thread that libvirt doesn't report correct
> UUIDs. For instance for the following input:
>
> vm.genid = "-8536691797830587195"
On Wed, Sep 29, 2021 at 10:33:43AM +0100, Daniel P. Berrangé wrote:
> On Wed, Sep 29, 2021 at 10:20:44AM +0100, Richard W.M. Jones wrote:
> > On Wed, Sep 29, 2021 at 10:01:55AM +0200, Michal Privoznik wrote:
> > > Apparently, parsing vmx.genid is not as easy as I thought. An
Looking at the qemu code the problem IMHO is:
https://gitlab.com/qemu-project/qemu/-/blob/6b54a31bf7b403672a798b6443b1930ae6c74dea/docs/specs/vmgenid.txt#L189
https://gitlab.com/qemu-project/qemu/-/blob/6b54a31bf7b403672a798b6443b1930ae6c74dea/hw/acpi/vmgenid.c#L37
This byte swapping makes no sen
On Wed, Sep 29, 2021 at 11:07:30AM +0100, Daniel P. Berrangé wrote:
> I'm not sure if we actually need the full driver or not for testing
> purposes. The the GenID is just in memory somewhere, and the somewhere
> is reported via ACPI table entry. For QEMU its easy as the data is
> exposed via fw_cf
On Wed, Sep 29, 2021 at 10:46:38AM +0100, Richard W.M. Jones wrote:
> I don't know why we decided to use a GUID for this. The feature
> itself (https://go.microsoft.com/fwlink/?LinkId=260709) defines it as
> an 128 bit / 8 byte number. The only connection to GUIDs is the size.
On Wed, Sep 29, 2021 at 11:10:35AM +0100, Daniel P. Berrangé wrote:
> On Wed, Sep 29, 2021 at 10:57:19AM +0100, Richard W.M. Jones wrote:
> > Looking at the qemu code the problem IMHO is:
> >
> > https://gitlab.com/qemu-project/qemu/-/blob/6b54a31bf7b403672a798b6443b193
On Wed, Sep 29, 2021 at 01:29:21PM -0500, Eric Blake wrote:
> On Wed, Sep 29, 2021 at 05:03:08PM +0200, Paolo Bonzini wrote:
> > On 29/09/21 15:58, Richard Henderson wrote:
> > >
> > > > /usr/bin/ld: /usr/lib64/libselinux.so: error adding symbols: file
> > > in
> > > > wrong format
> >
More data: I found a colleague who has a Hyper-V instance with a
Windows guest and he helped me to understand how Hyper-V represents
generation IDs. Hyper-V has had support for generation IDs since long
before Microsoft proposed the feature for standardization. Originally
(I think pre-2013) Hyp
On Wed, Sep 29, 2021 at 01:29:21PM -0500, Eric Blake wrote:
> On Wed, Sep 29, 2021 at 05:03:08PM +0200, Paolo Bonzini wrote:
> > On 29/09/21 15:58, Richard Henderson wrote:
> > >
> > > > /usr/bin/ld: /usr/lib64/libselinux.so: error adding symbols: file
> > > in
> > > > wrong format
> >
: https://bugzilla.redhat.com/show_bug.cgi?id=1984938
Signed-off-by: Richard W.M. Jones
Reviewed-by: Daniel P. Berrangé
Signed-off-by: Eric Blake
---
configure | 8 +++-
meson.build | 10 -
meson_options.txt
On Thu, Sep 30, 2021 at 09:47:01AM +0100, Daniel P. Berrangé wrote:
> On Thu, Sep 30, 2021 at 08:33:48AM +0100, Richard W.M. Jones wrote:
> > I propose we deprecate the guid parameter in:
> >
> > -device vmgenid,guid=8987940a-0951-2cc5-e815-10634ff550b9,id=vmgenid0
> &
On Thu, Sep 30, 2021 at 10:27:45AM -0400, Richard Henderson wrote:
> On 9/30/21 4:45 AM, Richard W.M. Jones wrote:
> > PKG_CONFIG_LIBDIR=/usr/lib/pkgconfig ../configure --extra-cflags=-m32
> > --disable-vhost-user
>
> Not --extra-cflags, use --cpu=i386.
That also bui
we incorrectly
> use the wrong probing during meson.
>
> Cc: Alex Bennée
> Cc: Paolo Bonzini
> Cc: Daniel P. Berrangé
> Cc: Richard W.M. Jones
> Signed-off-by: Richard Henderson
> ---
> tests/docker/dockerfiles/fedora-i386-cross.docker | 5 +++--
> 1 file chang
On Thu, Sep 30, 2021 at 02:00:11PM -0300, Willian Rampazzo wrote:
> On Thu, Sep 30, 2021 at 5:55 AM Vladimir Sementsov-Ogievskiy
> wrote:
> >
> > 9/30/21 11:47, Richard W.M. Jones wrote:
> > > Under SELinux, Unix domain sockets have two labels. One is on the
>
/master/docs/vm-generation-id-across-hypervisors.txt
On Thu, Sep 30, 2021 at 10:16:20AM +0100, Richard W.M. Jones wrote:
> I was going to suggest something like:
>
> aa-bb-cc..
> or
> aabbcc..
After thinking about this some more, the real implementation on
Windows guest and hos
On Mon, Oct 04, 2021 at 04:50:51PM +0200, Laszlo Ersek wrote:
> On 10/04/21 11:59, Richard W.M. Jones wrote:
> > It turns out that changing the qemu implementation is painful,
> > particularly if we wish to maintain backwards compatibility of the
> > command li
The commands below set up a sparse RAM disk, with an allocated block
at offset 32K and another one at offset 1M-32K. Then it tries to copy
this to a compressed qcow2 file using qemu-nbd + the qemu compress
filter:
$ qemu-img create -f qcow2 output.qcow2 1M
$ qemu-nbd -t --image-opts
driver=c
On Fri, Jan 28, 2022 at 12:39:11PM +0100, Hanna Reitz wrote:
> So I actually don’t know why it works for you. OTOH, I don’t
> understand why the block size affects you over NBD, because I would
> have expected qemu to internally auto-align requests when they are
> not aligned (in bdrv_co_pwritev_p
I hacked nbdcopy to ignore block alignment (the error actually comes
from libnbd refusing to send the unaligned request, not from
qemu-nbd), and indeed qemu-nbd accepts the unaligned request without
complaint.
Eric - maybe having some flag for nbdcopy to ignore unaligned requests
when we know th
On Fri, Jan 28, 2022 at 12:57:47PM +0100, Hanna Reitz wrote:
> On 28.01.22 12:48, Richard W.M. Jones wrote:
> >On Fri, Jan 28, 2022 at 12:39:11PM +0100, Hanna Reitz wrote:
> >>So I actually don’t know why it works for you. OTOH, I don’t
> >>understand why the bloc
On Fri, Jan 28, 2022 at 02:19:44PM +0100, Kevin Wolf wrote:
> Am 28.01.2022 um 13:30 hat Hanna Reitz geschrieben:
> > > > I just changed that line of code [2], as shown in [4]. I suppose
> > > > the better thing to do would be to have an option for the NBD server
> > > > to force-change the announ
On Fri, Jan 28, 2022 at 01:30:53PM +, Richard W.M. Jones wrote:
> I feel like this may be a bug in what qemu-nbd advertises. Currently
> it is:
Ignore this email, see other reply.
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my progr
On Fri, Jan 28, 2022 at 01:30:43PM +0100, Hanna Reitz wrote:
> On 28.01.22 13:18, Richard W.M. Jones wrote:
> >On Fri, Jan 28, 2022 at 12:57:47PM +0100, Hanna Reitz wrote:
> >>On 28.01.22 12:48, Richard W.M. Jones wrote:
> >>>On Fri, Jan 28, 2022 at 12:39:11PM +010
Sorry for very delayed reply ...
On Thu, Dec 02, 2021 at 07:57:38AM +0100, Markus Armbruster wrote:
> 1. QMP only
>
>Management applications need to use QMP for monitoring anyway. They
>may want to use it for initial configuration, too. Libvirt does.
>
>They still need to bootstrap
Reitz
> Cc: Richard W.M. Jones
> Signed-off-by: Stefan Hajnoczi
> Acked-by: Richard W.M. Jones
> Reviewed-by: Beraldo Leal
> Tested-by: Beraldo Leal
> Message-Id: <20211207160025.52466-1-stefa...@redhat.com>
> [AJB: migrate to lcitool qemu.yml and regenerate]
&
On Thu, Feb 10, 2022 at 05:47:14PM +, Dr. David Alan Gilbert (git) wrote:
> From: "Dr. David Alan Gilbert"
>
> There's a nice new Rust implementation out there; recommend people
> do new work on that.
>
> Signed-off-by: Dr. David Alan Gilbert
> ---
> docs/about/deprecated.rst | 17
On Tue, Feb 15, 2022 at 05:24:14PM -0600, Eric Blake wrote:
> Oh. The QMP command (which is immediately visible through
> nbd-server-add/block-storage-add to qemu and qemu-storage-daemon)
> gains "multi-conn":"on", but you may be right that qemu-nbd would want
> a command line option (either that,
On Fri, Aug 26, 2022 at 12:39:00PM +0100, Daniel P. Berrangé wrote:
> The 'qemu64' CPU model implements the least featureful x86_64 CPU that's
> possible. Historically this hasn't been an issue since it was rare for
> OS distros to build with a higher mandatory CPU baseline.
>
> With RHEL-9, howev
ddr: 0x%" PRIx64
> # tco.c
> tco_timer_reload(int ticks, int msec) "ticks=%d (%d ms)"
> tco_timer_expired(int timeouts_no, bool strap, bool no_reboot)
> "timeouts_no=%d no_reboot=%d/%d"
> +tco_io_write(uint64_t addr, uint32_t val) "addr=0x%" PRIx64 "
; via_pm_io_write(uint32_t addr, uint32_t val, int len) "addr 0x%x val 0x%x
> len 0x%x"
> via_superio_read(uint8_t addr, uint8_t val) "addr 0x%x val 0x%x"
> via_superio_write(uint8_t addr, uint32_t val) "addr 0x%x val 0x%x"
> +
> +# lpc_ich9.c
> +i
27;system_reset' in monitor */
> qapi_event_send_watchdog(WATCHDOG_ACTION_RESET);
> @@ -89,4 +92,5 @@ void watchdog_perform_action(void)
> void qmp_watchdog_set_action(WatchdogAction action, Error **errp)
> {
> watchdog_action = action;
> +trace_watchdog_set_
70..caabcac6e5 100644
> --- a/tests/qtest/tco-test.c
> +++ b/tests/qtest/tco-test.c
> @@ -60,7 +60,7 @@ static void test_init(TestData *d)
> QTestState *qs;
>
> qs = qtest_initf("-machine q35 %s %s",
> - d->noreboot ? "" : "
On Tue, Oct 04, 2022 at 09:53:32AM -0400, Stefan Hajnoczi wrote:
> qemu-nbd doesn't use io_uring to handle the backend IO,
Would this be fixed by your (not yet upstream) libblkio driver for
qemu?
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my prog
.
Thanks: Daniel Berrange, for diagnosing the problem
Signed-off-by: Richard W.M. Jones
---
tests/qtest/fuzz-lsi53c895a-test.c | 4 ++--
tests/qtest/rtl8139-test.c | 5 +++--
2 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/tests/qtest/fuzz-lsi53c895a-test.c
b/tests/qtest/fuzz
lab.com/qemu-project/qemu/-/issues/1518
> Signed-off-by: Marc-André Lureau
> Signed-off-by: Eric Auger
> Reported-by: Richard W.M. Jones
You can add:
Tested-by: Richard W.M. Jones
Reviewed-by: Richard W.M. Jones
> ---
>
> This is a respin of Marc-André's pat
On Tue, Feb 28, 2023 at 09:30:56PM +0100, Thomas Huth wrote:
> On 27/02/2023 18.40, Richard W.M. Jones wrote:
> >These two tests were failing with this error:
> >
> > stderr:
> > TAP parsing error: version number must be on the first line
> > [...]
> >
On Mon, Aug 05, 2024 at 01:48:12PM -0500, Eric Blake wrote:
> On Fri, Aug 02, 2024 at 02:26:04PM GMT, Eric Blake wrote:
> > I've requested a CVE from Red Hat, and hope to have an assigned number
> > soon. Meanwhile, we can get review started, to make sure this is
> > ready to include in 9.1. 'qem
does not even need iothreads. So remove everything that
> calls aio_wait_kick(), which is nice for coverage compared to adding the call
> to qemu_init_main_loop().
>
> Reported-by: Richard W.M. Jones
> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2434
> Signed-off-b
f..d0ce3c4ac55 100644
> --- a/hw/watchdog/watchdog.c
> +++ b/hw/watchdog/watchdog.c
> @@ -85,7 +85,7 @@ void watchdog_perform_action(void)
> break;
>
> default:
> -assert(0);
> +g_assert_not_reached();
> }
> }
>
Reviewed-by:
701 - 800 of 1264 matches
Mail list logo
