Re: [Qemu-devel] [PATCH v1 repost 2] block/curl: Improve type safety of s->timeout.

2014-10-26 Thread Richard W.M. Jones
On Sun, Oct 26, 2014 at 06:45:02PM +0800, Gonglei wrote: > On 2014/10/26 18:22, Richard W.M. Jones wrote: > > > It's just there to stop unreasonable timeouts or negative numbers. > > 10 s is 27 hours, and no webserver I know of would keep a > > connection open

Re: [Qemu-devel] [PATCH v1 repost 2] block/curl: Improve type safety of s->timeout.

2014-10-26 Thread Richard W.M. Jones
On Sun, Oct 26, 2014 at 06:55:21PM +0800, Gonglei wrote: > On 2014/10/26 18:48, Richard W.M. Jones wrote: > > > On Sun, Oct 26, 2014 at 06:45:02PM +0800, Gonglei wrote: > >> On 2014/10/26 18:22, Richard W.M. Jones wrote: > >> > >>> It's just there to

[Qemu-devel] [PATCH v2] block/curl: Improve type safety of s->timeout.

2014-10-26 Thread Richard W.M. Jones
v2: - Define the maximum timeout in a macro. - Reduce the maximum timeout to 1 s (instead of 10 s).

[Qemu-devel] [PATCH v2] block/curl: Improve type safety of s->timeout.

2014-10-26 Thread Richard W.M. Jones
uot;file.timeout":-1 }': timeout parameter is too large or negative: Invalid argument Signed-off-by: Richard W.M. Jones Reviewed-by: Laszlo Ersek --- block/curl.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/block/curl.c b/block/curl.c index b4157cc..

Re: [Qemu-devel] [PATCH RFC 2/2] block: Warn on insecure format probing

2014-10-31 Thread Richard W.M. Jones
Can you add something like: -drive ...,format=unsafe-probe so it does the probing anyway, even though we know it's unsafe? This will minimize the churn needed in libguestfs to make this work. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my prog

[Qemu-devel] [PATCH v2] curl: Allow a cookie or cookies to be sent with http/https

2014-08-29 Thread Richard W.M. Jones
Since v1: - Remove the conditional around g_strdup (thanks Matt Booth). Rich.

[Qemu-devel] [PATCH v2] curl: Allow a cookie or cookies to be sent with http/https requests.

2014-08-29 Thread Richard W.M. Jones
mp;dsName=datastore1";, "file.sslverify":"off", "file.cookie":"vmware_soap_session=\"52a01262-bf93-ccce-d379-8dabb3e55560\""}' image: [...] file format: raw virtual size: 8.0G (8589934592 bytes) disk size: unavailable Signed-off-by: Ri

Re: [Qemu-devel] [PATCH v2] curl: Allow a cookie or cookies to be sent with http/https requests.

2014-08-29 Thread Richard W.M. Jones
On Fri, Aug 29, 2014 at 09:10:10AM -0600, Eric Blake wrote: > On 08/29/2014 09:03 AM, Richard W.M. Jones wrote: > > In order to access VMware ESX efficiently, we need to send a session > > cookie. This patch is very simple and just allows you to send that > > session coo

Re: [Qemu-devel] tcmu-runner and QEMU

2014-08-30 Thread Richard W.M. Jones
For the benefit of those who have absolutely no idea what you're talking about, could you write a simpler summary of what you're trying to do? Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress

[Qemu-devel] qcow2, lazy_refcounts and killing qemu

2014-08-30 Thread Richard W.M. Jones
I found out a few days ago that if you: (1) Open a qcow2 file that has lazy_refcounts = on and a backing file, and (2) Write lots of stuff, and (3) Kill qemu with SIGTERM [which I believed, maybe incorrectly, is a "nice" way to kill qemu] .. then you can end up with a corrupt qcow2 file. In pa

Re: [Qemu-devel] tcmu-runner and QEMU

2014-08-30 Thread Richard W.M. Jones
On Sat, Aug 30, 2014 at 05:53:43PM +0200, Benoît Canet wrote: > The Saturday 30 Aug 2014 à 15:46:41 (+0100), Richard W.M. Jones wrote : > > For the benefit of those who have absolutely no idea what you're > > talking about, could you write a simpler summary of what you

Re: [Qemu-devel] tcmu-runner and QEMU

2014-08-30 Thread Richard W.M. Jones
BTW, what is "tcmu-runner"? The github repo you pointed to is ... opaque. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-builder quickly builds VMs from scratch http://libguestfs

Re: [Qemu-devel] qcow2, lazy_refcounts and killing qemu

2014-09-01 Thread Richard W.M. Jones
On Mon, Sep 01, 2014 at 02:41:02PM +0200, Greg Kurz wrote: > On Sat, 30 Aug 2014 15:53:13 +0100 > "Richard W.M. Jones" wrote: > > I can reproduce this easily, although of course the reproducer will > > involve libguestfs. > > > > Rich. > > >

Re: [Qemu-devel] qcow2, lazy_refcounts and killing qemu

2014-09-01 Thread Richard W.M. Jones
A test case, attached. Note that you have to look at the output of the final qemu-img info command. In the case where it goes wrong, the 'backing file:' and 'backing file format:' lines disappear completely. In the case where the bug is not reproduced, these lines are still present. It's 100% r

Re: [Qemu-devel] qcow2, lazy_refcounts and killing qemu

2014-09-01 Thread Richard W.M. Jones
> # Write stuff to the overlay. > guestfish < add-drive overlay.qcow2 format:qcow2 cachemode:unsafe To head off any suggestions, removing cachemode:unsafe doesn't fix it. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualizat

Re: [Qemu-devel] [PATCH v13 5/6] raw-posix: Add full preallocation option

2014-09-04 Thread Richard W.M. Jones
On Thu, Sep 04, 2014 at 02:35:22PM +0200, Kevin Wolf wrote: > Please change the code to always write zeros for FULL, How is this useful for anyone? You don't know if the underlying SAN is going to detect these zeroes or combine these blocks together. It's just slow for no reason. Rich. -- Rich

Re: [Qemu-devel] [PATCH v13 5/6] raw-posix: Add full preallocation option

2014-09-04 Thread Richard W.M. Jones
On Thu, Sep 04, 2014 at 02:52:57PM +0200, Kevin Wolf wrote: > Am 04.09.2014 um 14:45 hat Richard W.M. Jones geschrieben: > > On Thu, Sep 04, 2014 at 02:35:22PM +0200, Kevin Wolf wrote: > > > Please change the code to always write zeros for FULL, > > > > How is this

Re: [Qemu-devel] [PATCH v13 5/6] raw-posix: Add full preallocation option

2014-09-04 Thread Richard W.M. Jones
On Thu, Sep 04, 2014 at 03:17:51PM +0200, Kevin Wolf wrote: > Am 04.09.2014 um 15:07 hat Richard W.M. Jones geschrieben: > > On Thu, Sep 04, 2014 at 02:52:57PM +0200, Kevin Wolf wrote: > > > Am 04.09.2014 um 14:45 hat Richard W.M. Jones geschrieben: > > > > On Thu, Se

Re: [Qemu-devel] [PATCH v13 5/6] raw-posix: Add full preallocation option

2014-09-04 Thread Richard W.M. Jones
On Thu, Sep 04, 2014 at 05:23:21PM +0200, Kevin Wolf wrote: > The definition of "besteffort" depends on what you want to achieve. It > is policy, and we generally try to keep policy out of qemu. I think qemu *should* have a policy of make it work and don't fail - first - and then offer a million k

Re: [Qemu-devel] qcow2, lazy_refcounts and killing qemu

2014-09-05 Thread Richard W.M. Jones
On Fri, Sep 05, 2014 at 04:39:51PM +0100, Stefan Hajnoczi wrote: > Did you try older QEMU versions? I'm curious if this is something that > crept in later or is fundamentally broken in lazy_refcounts=on. At your prompting, I've done a bit more investigation. I was basing my observations on qemu

[Qemu-devel] Should qemu -kernel option be able to gunzip kernel? (aarch64)

2014-07-29 Thread Richard W.M. Jones
On Fedora/aarch64, the kernel in /boot is a gzip-compressed file: $ file /boot/vmlinuz-* /boot/vmlinuz-0-rescue-520be7dc677d4fab99d3d3ce91f90c84: gzip compressed data, max compression, from Unix /boot/vmlinuz-3.16.0-0.rc6.git3.1.rwmj2.fc22.aarch64:gzip compressed data, max compression, from

[Qemu-devel] [PATCH] aarch64: Allow -kernel option to take a gzip-compressed kernel.

2014-07-29 Thread Richard W.M. Jones
Signed-off-by: Richard W.M. Jones --- hw/arm/boot.c | 9 + hw/core/loader.c| 48 include/hw/loader.h | 1 + 3 files changed, 58 insertions(+) diff --git a/hw/arm/boot.c b/hw/arm/boot.c index 3d1f4a2..1086a05 100644 --- a/hw

[Qemu-devel] [PATCH v2] aarch64: Allow -kernel option to take a gzip-compressed kernel.

2014-07-30 Thread Richard W.M. Jones
linuz because it tries to execute the gzip-compressed data. This commit lets gzip-compressed kernels be uncompressed transparently. Currently this is only done when emulating aarch64. Signed-off-by: Richard W.M. Jones --- hw/arm/boot.c | 9 + hw/core/loader.c

[Qemu-devel] [PATCH v3] aarch64: Allow -kernel option to take a gzip-compressed kernel.

2014-07-30 Thread Richard W.M. Jones
linuz because it tries to execute the gzip-compressed data. This commit lets gzip-compressed kernels be uncompressed transparently. Currently this is only done when emulating aarch64. Signed-off-by: Richard W.M. Jones --- hw/arm/boot.c | 9 + hw/core/loader.c

[Qemu-devel] [PATCH v3] aarch64: Allow -kernel option to take a gzip-compressed

2014-07-30 Thread Richard W.M. Jones
Compared to v2: - In the case where a kernel was larger than max_sz bytes, load_image_gzipped could overwrite > max_sz bytes of memory (or overrun the buffer). Fixed. Rich.

Re: [Qemu-devel] questions about host side of virtio-serial

2014-07-31 Thread Richard W.M. Jones
On Wed, Jul 30, 2014 at 12:52:41PM -0600, Chris Friesen wrote: > Hi, > > I'm working on a native user of virtio-serial (ie, not going via the > qemu guest agent). > > The information at "http://www.linux-kvm.org/page/Virtio-serial_API"; > does a good job of describing the guest side of things, bu

Re: [Qemu-devel] about -enable-kvm options

2014-08-01 Thread Richard W.M. Jones
On Fri, Aug 01, 2014 at 11:15:29AM +0800, Gareth wrote: > Hi all > > What does '-enable-kvm' option mean? I have heard two versions of answers: It's a shortcut for: $qemu -machine accel=kvm > a) guest OS would have /dev/kvm device and which could help vm in guest OS > (nested vm) That's nest

[Qemu-devel] [PATCH v4] aarch64: Allow -kernel option to take a gzip-compressed

2014-08-02 Thread Richard W.M. Jones
No change compared to v3. I just rebased the patch on top of current HEAD and ensured that it still works. Any comments at all on this approach? It's the last patch I need to make libguestfs work on aarch64 ... Rich.

[Qemu-devel] [PATCH v4] aarch64: Allow -kernel option to take a gzip-compressed kernel.

2014-08-02 Thread Richard W.M. Jones
linuz because it tries to execute the gzip-compressed data. This commit lets gzip-compressed kernels be uncompressed transparently. Currently this is only done when emulating aarch64. Signed-off-by: Richard W.M. Jones --- hw/arm/boot.c | 9 + hw/core/loader.c

Re: [Qemu-devel] [PATCH v4] aarch64: Allow -kernel option to take a gzip-compressed kernel.

2014-08-04 Thread Richard W.M. Jones
On Mon, Aug 04, 2014 at 09:05:39AM +1000, Peter Crosthwaite wrote: > On Sun, Aug 3, 2014 at 1:45 AM, Richard W.M. Jones wrote: > > +max_bytes = UBOOT_MAX_GUNZIP_BYTES; > > Why does u-boot's maximum size limit apply here? We need some maximum to prevent people uploadi

[Qemu-devel] [PATCH v5 1/2] loader: Add load_image_gzipped function.

2014-08-04 Thread Richard W.M. Jones
As the name suggests this lets you load a ROM/disk image that is gzipped. It is uncompressed before storing it in guest memory. Signed-off-by: Richard W.M. Jones --- hw/core/loader.c| 48 include/hw/loader.h | 1 + 2 files changed, 49

[Qemu-devel] [PATCH v5 2/2] aarch64: Allow -kernel option to take a gzip-compressed kernel.

2014-08-04 Thread Richard W.M. Jones
linuz because it tries to execute the gzip-compressed data. This commit lets gzip-compressed kernels be uncompressed transparently. Currently this is only done when emulating aarch64. Signed-off-by: Richard W.M. Jones --- hw/arm/boot.c | 9 + 1 file changed, 9 insertions(+) diff --git a/h

[Qemu-devel] [PATCH v5 0/2] aarch64: Allow -kernel option to take a gzip-compressed kernel.

2014-08-04 Thread Richard W.M. Jones
Changes since v4: - Split the patch into a generic loader part, and specific arm64 support. - There is now a specific limit for the gzip loader, plus a comment to indicate that it's just there to stop an excessive malloc. The limit is now decoupled (and larger) than the u-boot limit,

Re: [Qemu-devel] [PATCH v5 1/2] loader: Add load_image_gzipped function.

2014-08-05 Thread Richard W.M. Jones
On Tue, Aug 05, 2014 at 10:57:26AM +0100, Alex Bennée wrote: > > Richard W.M. Jones writes: > > > As the name suggests this lets you load a ROM/disk image that is > > gzipped. It is uncompressed before storing it in guest memory. > > > > Signed-off-by: Richard W

[Qemu-devel] [PATCH v6 0/2] aarch64: Allow -kernel option to take a gzip-compressed kernel.

2014-08-05 Thread Richard W.M. Jones
Changes from v5: - Fixed warning/error about comparison of uint8_t and char literal. - Compile-tested on x86-64. - Compiled and re-tested on aarch64. Rich.

[Qemu-devel] [PATCH v6 2/2] aarch64: Allow -kernel option to take a gzip-compressed kernel.

2014-08-05 Thread Richard W.M. Jones
linuz because it tries to execute the gzip-compressed data. This commit lets gzip-compressed kernels be uncompressed transparently. Currently this is only done when emulating aarch64. Signed-off-by: Richard W.M. Jones Reviewed-by: Alex Bennée --- hw/arm/boot.c | 9 + 1 file changed, 9 inser

[Qemu-devel] [PATCH v6 1/2] loader: Add load_image_gzipped function.

2014-08-05 Thread Richard W.M. Jones
As the name suggests this lets you load a ROM/disk image that is gzipped. It is uncompressed before storing it in guest memory. Signed-off-by: Richard W.M. Jones --- hw/core/loader.c| 48 include/hw/loader.h | 1 + 2 files changed, 49

[Qemu-devel] aarch64 & gdb: warning: while parsing target description (at line 1): Could not load XML document "arm-core.xml"

2014-08-07 Thread Richard W.M. Jones
(gdb) set architecture aarch64 The target architecture is assumed to be aarch64 (gdb) target remote tcp::1234 Remote debugging using tcp::1234 warning: while parsing target description (at line 1): Could not load XML document "arm-core.xml" warning: Could not load XML target description; ignoring

Re: [Qemu-devel] aarch64 & gdb: warning: while parsing target description (at line 1): Could not load XML document "arm-core.xml"

2014-08-07 Thread Richard W.M. Jones
On Thu, Aug 07, 2014 at 12:18:49PM +0100, Peter Maydell wrote: > you didn't select a 32 bit CPU either explicitly or by default > on the QEMU command line? Note that '-machine type=virt' > defaults to a Cortex-A15 even in qemu-softmmu-aarch64 > (this is unfortunate but fallout from the fact that we

Re: [Qemu-devel] aarch64 & gdb: warning: while parsing target description (at line 1): Could not load XML document "arm-core.xml"

2014-08-07 Thread Richard W.M. Jones
On Thu, Aug 07, 2014 at 12:35:27PM +0100, Peter Maydell wrote: > On 7 August 2014 12:29, Richard W.M. Jones wrote: > > On Thu, Aug 07, 2014 at 12:18:49PM +0100, Peter Maydell wrote: > >> you didn't select a 32 bit CPU either explicitly or by default > >> on

Re: [Qemu-devel] aarch64 & gdb: warning: while parsing target description (at line 1): Could not load XML document "arm-core.xml"

2014-08-07 Thread Richard W.M. Jones
On Thu, Aug 07, 2014 at 02:53:33PM +0100, Peter Maydell wrote: > On 7 August 2014 14:43, Christopher Covington wrote: > > On 08/07/2014 08:03 AM, Peter Maydell wrote: > >> No, because at the moment our AArch64 TCG implementation > >> (and the way we configure KVM) assumes that the highest > >> exc

[Qemu-devel] [PATCH v7 1/2] loader: Add load_image_gzipped function.

2014-08-08 Thread Richard W.M. Jones
As the name suggests this lets you load a ROM/disk image that is gzipped. It is uncompressed before storing it in guest memory. Signed-off-by: Richard W.M. Jones Reviewed-by: Alex Bennée --- hw/core/loader.c| 48 include/hw/loader.h | 1

[Qemu-devel] [PATCH v7 2/2] aarch64: Allow -kernel option to take a gzip-compressed kernel.

2014-08-08 Thread Richard W.M. Jones
linuz because it tries to execute the gzip-compressed data. This commit lets gzip-compressed kernels be uncompressed transparently. Currently this is only done when emulating aarch64. Signed-off-by: Richard W.M. Jones Reviewed-by: Alex Bennée --- hw/arm/boot.c | 9 + 1 file changed, 9 inser

[Qemu-devel] [PATCH v7 0/2] aarch64: Allow -kernel option to take a gzip-compressed kernel.

2014-08-08 Thread Richard W.M. Jones
Since v6: - No changes to the code. - Rebased against HEAD. - Retested on aarch64. - Added Reviewed-by tag. Rich.

[Qemu-devel] [PATCH] qemu: json: Fix parsing of integers >= 0x8000000000000000

2011-05-20 Thread Richard W.M. Jones
(PXE) and turn machines into Xen guests. http://et.redhat.com/~rjones/virt-p2v >From 6d58224bff821c49e91f5fe46c0e72f85e2583c6 Mon Sep 17 00:00:00 2001 From: Richard W.M. Jones Date: Fri, 20 May 2011 18:55:12 +0100 Subject: [PATCH] json: Fix parsing of integers >= 0x8000 Because of

Re: [Qemu-devel] [PATCH] qemu: json: Fix parsing of integers >= 0x8000000000000000

2011-05-20 Thread Richard W.M. Jones
On Fri, May 20, 2011 at 01:11:05PM -0500, Anthony Liguori wrote: > On 05/20/2011 01:03 PM, Richard W.M. Jones wrote: > > > >There seem to be a few unsafe uses of strto* functions. This patch > >just fixes the one that affects me :-) > > Sending an integer of

Re: [Qemu-devel] [PATCH] qemu: json: Fix parsing of integers >= 0x8000000000000000

2011-05-20 Thread Richard W.M. Jones
I should add that not error checking and silently truncating numbers in qemu is still a bug. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming blog: http://rwmj.wordpress.com Fedora now supports 80 OCaml packages (the OPEN alternative to

Re: [Qemu-devel] [PATCH] qemu: json: Fix parsing of integers >= 0x8000000000000000

2011-05-20 Thread Richard W.M. Jones
On Fri, May 20, 2011 at 01:11:05PM -0500, Anthony Liguori wrote: > JSON only supports int64_t. By the way, where does this information come from? The JSON RFC fails to define the range of numbers at all, just leaving it completely up to the application, and if JSON is based on Javascript then it

Re: [Qemu-devel] [PATCH] qemu: json: Fix parsing of integers >= 0x8000000000000000

2011-05-20 Thread Richard W.M. Jones
On Fri, May 20, 2011 at 01:11:05PM -0500, Anthony Liguori wrote: > Your patch won't accept negative numbers, correct? 'strtoull' works OK with negative numbers. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones virt-p2v converts physical machines to virtual

Re: [Qemu-devel] [PATCH] qemu: json: Fix parsing of integers >= 0x8000000000000000

2011-05-23 Thread Richard W.M. Jones
Just refer everyone at this point the actual standard: http://www.ietf.org/rfc/rfc4627.txt It leaves it up to the application how to interpret and store integers. It would be standard-conforming to only allow "0" and "1". While qemu is technically correct, in practice it's being very unhelpful

Re: [Qemu-devel] [PATCH] qemu: json: Fix parsing of integers >= 0x8000000000000000

2011-05-23 Thread Richard W.M. Jones
On Mon, May 23, 2011 at 10:07:21AM -0500, Anthony Liguori wrote: > On 05/23/2011 09:29 AM, Markus Armbruster wrote: > >Anthony Liguori writes: > > > >JavaScript's implementation of JSON sets limits on the range of numbers, > >namely they need to fit into IEEE doubles. > > > >Our implementation set

Re: [Qemu-devel] [PATCH] qemu: json: Fix parsing of integers >= 0x8000000000000000

2011-05-23 Thread Richard W.M. Jones
On Mon, May 23, 2011 at 10:24:07AM -0500, Anthony Liguori wrote: > On 05/23/2011 10:19 AM, Richard W.M. Jones wrote: > >On Mon, May 23, 2011 at 10:07:21AM -0500, Anthony Liguori wrote: > >>On 05/23/2011 09:29 AM, Markus Armbruster wrote: > >>>Anthony Liguori w

Re: [Qemu-devel] Question on virtio disk maximum index and maximum partition

2011-06-14 Thread Richard W.M. Jones
On Wed, Jun 01, 2011 at 05:56:02AM +0100, Stefan Hajnoczi wrote: > Partitions are not at the virtio-blk level. The guest operating > system will see the virtio-blk disk and scan its partition table to > determine which partitions are available. The limit then depends on > the partitioning scheme

Re: [Qemu-devel] [RESEND][PATCH v3] Generalize -machine command line option

2011-07-25 Thread Richard W.M. Jones
On Mon, Jul 25, 2011 at 12:33:01PM +0200, Jan Kiszka wrote: > On 2011-07-25 11:41, Richard W.M. Jones wrote: > > On Sat, Jul 23, 2011 at 12:38:37PM +0200, Jan Kiszka wrote: > >> From: Jan Kiszka > >> > >> -machine somehow suggests that it selects the machine,

Re: [Qemu-devel] [RESEND][PATCH v3] Generalize -machine command line option

2011-07-25 Thread Richard W.M. Jones
On Mon, Jul 25, 2011 at 07:47:51AM -0500, Anthony Liguori wrote: > On 07/25/2011 07:44 AM, Alexander Graf wrote: > > > >On 25.07.2011, at 14:05, Peter Maydell wrote: > > > >>On 25 July 2011 12:48, Peter Maydell wrote: > >>>For ARM you absolutely should not be relying on the default > >>>machine ty

Re: [Qemu-devel] [PATCH] Allow to leave type on default in -machine

2011-07-25 Thread Richard W.M. Jones
On Mon, Jul 25, 2011 at 06:11:20PM +0200, Jan Kiszka wrote: > I was incorrectly pointing the core, the problem is solvable at the > level where we parse -machine: > > ---8< > > This allows to specify -machine options without setting an explicit > machine type. We will pick the default

Re: [Qemu-devel] [PATCH] Introduce QEMU_NEW()

2011-08-01 Thread Richard W.M. Jones
On Mon, Jul 25, 2011 at 11:51:12AM +0300, Avi Kivity wrote: > qemu_malloc() is type-unsafe as it returns a void pointer. Introduce > QEMU_NEW() (and QEMU_NEWZ()), which return the correct type. > > Signed-off-by: Avi Kivity > --- > > This is part of my memory API patchset, but doesn't really be

[Qemu-devel] libguestfs now uses virtio-scsi, supports large numbers of disks

2012-06-14 Thread Richard W.M. Jones
I switched libguestfs over to using virtio-scsi. One immediate benefit is support for large numbers of disks: up to 255 because we're using 1 target / disk and we reserve one disk for the appliance, in theory more could be supported if we used LUNs. This email just contains some notes that may be

[Qemu-devel] qemu-system-ppc64 hanging occasionally in disk writes

2012-06-14 Thread Richard W.M. Jones
I found last week that qemu-system-ppc64 (from git) hangs occasionally under load, and I have a reproducer for it now. Unfortunately the reproducer really takes a long time to run -- usually I can get a hang in under 12 hours. Here is the reproducer case: https://lists.fedoraproject.org/piper

[Qemu-devel] [Bug 1013241] [NEW] qemu-system-ppc64 hanging occasionally in disk writes

2012-06-14 Thread Richard W.M. Jones
Public bug reported: I found last week that qemu-system-ppc64 (from git) hangs occasionally under load, and I have a reproducer for it now. Unfortunately the reproducer really takes a long time to run -- usually I can get a hang in under 12 hours.

Re: [Qemu-devel] qemu-system-ppc64 hanging occasionally in disk writes

2012-06-14 Thread Richard W.M. Jones
On Thu, Jun 14, 2012 at 05:58:04PM +0200, Alexander Graf wrote: > [CC'ing qemu-ppc] > > On 06/14/2012 05:52 PM, Richard W.M. Jones wrote: > >I found last week that qemu-system-ppc64 (from git) hangs occasionally > >under load, and I have a reproducer for it now. Unfor

Re: [Qemu-devel] qemu-system-ppc64 hanging occasionally in disk writes

2012-06-14 Thread Richard W.M. Jones
On Thu, Jun 14, 2012 at 06:13:11PM +0100, Richard W.M. Jones wrote: > I will try this, but as discussed on IRC last week there's some > problem with the Fedora host kernel where /dev/kvm doesn't show up, > even though the kernel is supposedly compiled with KVM PR enabled. So &

Re: [Qemu-devel] qemu-system-ppc64 hanging occasionally in disk writes

2012-06-14 Thread Richard W.M. Jones
On Thu, Jun 14, 2012 at 11:34:37PM +0200, Alexander Graf wrote: > > /home/rjones/d/qemu/ppc64-softmmu/qemu-system-ppc64 \ > >-global virtio-blk-pci.scsi=off \ > >-nodefconfig \ > >-nodefaults \ > >-nographic \ > >-device virtio-scsi-pci,id=scsi \ > >-drive file=test1.img,cac

Re: [Qemu-devel] libguestfs now uses virtio-scsi, supports large numbers of disks

2012-06-15 Thread Richard W.M. Jones
On Fri, Jun 15, 2012 at 11:44:42AM +0100, Stefan Hajnoczi wrote: > On Thu, Jun 14, 2012 at 2:49 PM, Richard W.M. Jones wrote: > > I switched libguestfs over to using virtio-scsi.  One immediate > > benefit is support for large numbers of disks: up to 255 because we're >

Re: [Qemu-devel] qemu-system-ppc64 hanging occasionally in disk writes

2012-06-15 Thread Richard W.M. Jones
On Thu, Jun 14, 2012 at 06:13:11PM +0100, Richard W.M. Jones wrote: > I just tried virtio-scsi, but only the first disk shows up. I added > two disks. See below for detailed logs. This works fine on x86-64. > Should I file a separate bug for this? Here's that bug: https://bugs

[Qemu-devel] [Bug 1013691] [NEW] ppc64 + virtio-scsi: only first scsi disk shows up in the guest

2012-06-15 Thread Richard W.M. Jones
Public bug reported: When adding two virtio-scsi targets to a single guest, only the first disk is seen inside the guest. For some unknown reason the guest doesn't enumerate the second disk. For full qemu-system-ppc64 command line and 'dmesg' output, see: http://lists.nongnu.org/archive/html/qe

[Qemu-devel] [Bug 1013691] Re: ppc64 + virtio-scsi: only first scsi disk shows up in the guest

2012-06-15 Thread Richard W.M. Jones
Yes, that works fine, both disks seen by the guest. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1013691 Title: ppc64 + virtio-scsi: only first scsi disk shows up in the guest Status in QEMU: N

Re: [Qemu-devel] [PATCH v2 0/3] kvm:showing a splash picture when start

2011-06-23 Thread Richard W.M. Jones
On Thu, Jun 23, 2011 at 05:18:57PM +0800, Wayne Xia wrote: > Hi, > these 3 patch simply enable qemu-kvm to show a logo picture when it > s start up, following is how to configurate it: > invoke it with params: > -boot (splash_time=,) (splash_filename=,) > the splash_time is in the u

[Qemu-devel] [PATCH 1/1] Remove debugging messages.

2011-07-19 Thread Richard W.M. Jones
qemu probably needs some sort of --verbose or --debug option for when you really want to see everything that's going on. In the meantime, this patch removes some debugging messages when KVM is not available. Rich.

[Qemu-devel] [PATCH] Remove debugging messages.

2011-07-19 Thread Richard W.M. Jones
From: "Richard W.M. Jones" When using qemu -machine accel=kvm:tcg, if KVM is not available you get a load of debugging output: Could not access KVM kernel module: No such file or directory failed to initialize KVM: No such file or directory Back to tcg accelerator. Signed-off-b

Re: [Qemu-devel] [PATCH] Remove debugging messages.

2011-07-19 Thread Richard W.M. Jones
On Tue, Jul 19, 2011 at 11:49:22PM +0400, Michael Tokarev wrote: > 19.07.2011 23:23, Richard W.M. Jones wrote: > > From: "Richard W.M. Jones" > > > > When using qemu -machine accel=kvm:tcg, if KVM is not available you > > get a load of debugging output: &

Re: [Qemu-devel] [PATCH] Remove debugging messages.

2011-07-19 Thread Richard W.M. Jones
On Tue, Jul 19, 2011 at 03:04:22PM -0500, Anthony Liguori wrote: > On 07/19/2011 02:23 PM, Richard W.M. Jones wrote: > >From: "Richard W.M. Jones" > > > >When using qemu -machine accel=kvm:tcg, if KVM is not available you > >get a load of debugging output:

Re: [Qemu-devel] [PATCH] Remove debugging messages.

2011-07-20 Thread Richard W.M. Jones
On Tue, Jul 19, 2011 at 04:56:24PM -0500, Anthony Liguori wrote: > Can't libguestfs just ignore the messages? It does, but they get printed to stderr which confuses users and has caused several bug reports in the past. We'll probably have to redirect them somewhere. > >$ qemu -nographic -device

Re: [Qemu-devel] [PATCH] Remove debugging messages.

2011-07-20 Thread Richard W.M. Jones
On Wed, Jul 20, 2011 at 07:51:29AM -0500, Anthony Liguori wrote: > Given the large number of reports we've gotten in the past where > poor performance was caused by the expectation that a user had KVM > enabled and really didn't, I think it's more important to > overcommunicate to the user here. >

[Qemu-devel] [ANNOUNCE] libguestfs 1.12 released

2011-07-20 Thread Richard W.M. Jones
libguestfs is a library and a set of tools for reading, writing, managing, inspecting, rescuing and resizing disk images and offline and live virtual machines. I'm pleased to announce the release of libguestfs 1.12, the next stable branch of libguestfs. There are many changes and new features in

Re: [Qemu-devel] [RESEND][PATCH v3] Generalize -machine command line option

2011-07-25 Thread Richard W.M. Jones
On Sat, Jul 23, 2011 at 12:38:37PM +0200, Jan Kiszka wrote: > From: Jan Kiszka > > -machine somehow suggests that it selects the machine, but it doesn't. > Fix that before this command is set in stone. > > Actually, -machine should supersede -M and allow to introduce arbitrary > per-machine opti

Re: [Qemu-devel] [Question] dump memory when host pci device is used by guest

2011-10-21 Thread Richard W.M. Jones
On Fri, Oct 21, 2011 at 09:02:37AM -0400, Dave Anderson wrote: > It would be kind of cool if there was a "/dev/mem"-like interface > to a KVM guest's physical memory, so that you could sit on a KVM host > and enter "crash vmlinux-of-guest /dev/mem-of-guest" in order to > run live analysis of a gues

[Qemu-devel] [ANNOUNCE] libguestfs 1.14 released - tools for managing virtual machines and disk images

2011-10-27 Thread Richard W.M. Jones
libguestfs is a library and a set of tools for reading, writing, managing, inspecting, rescuing, resizing and aligning disk images, and offline and live virtual machines. I'm pleased to announce the release of libguestfs 1.14, the next stable release of libguestfs. There are many changes and new

Re: [Qemu-devel] Guest kernel device compatability auto-detection

2011-08-25 Thread Richard W.M. Jones
On Thu, Aug 25, 2011 at 08:33:04AM +0300, Avi Kivity wrote: > On 08/25/2011 08:21 AM, Sasha Levin wrote: > >Hi, > > > >Currently when we run the guest we treat it as a black box, we're not > >quite sure what it's going to start and whether it supports the same > >features we expect it to support wh

Re: [Qemu-devel] Guest kernel device compatability auto-detection

2011-08-25 Thread Richard W.M. Jones
On Thu, Aug 25, 2011 at 10:40:34AM +0300, Sasha Levin wrote: > From what I gathered libguestfs only provides access to the guests' > image. Correct. > Which part is doing the IKCONFIG or System.map probing? Or is it done in > a different way? You'll have to see what Matt's doing in the virt-v2v

Re: [Qemu-devel] Guest kernel device compatability auto-detection

2011-08-25 Thread Richard W.M. Jones
On Thu, Aug 25, 2011 at 08:48:25AM +0100, Richard W.M. Jones wrote: > On Thu, Aug 25, 2011 at 10:40:34AM +0300, Sasha Levin wrote: > > From what I gathered libguestfs only provides access to the guests' > > image. > > Correct. > > > Which part is doing the IK

Re: [Qemu-devel] Guest kernel device compatability auto-detection

2011-08-26 Thread Richard W.M. Jones
On Fri, Aug 26, 2011 at 09:22:45AM +0300, Sasha Levin wrote: > On Thu, 2011-08-25 at 16:25 +, Decker, Schorschi wrote: > > 2) implement the feature as an agent in the guest OS where the > > hypervisor can only query the guest OS agent, using a standard TCP/IP > > methodology. > > I was planning

Re: [Qemu-devel] Guest kernel device compatability auto-detection

2011-08-26 Thread Richard W.M. Jones
On Thu, Aug 25, 2011 at 04:48:36PM -0500, Anthony Liguori wrote: > One would be exposing a well supported device (like IDE emulation) > and having a magic mode that allowed you to basically promote the > device from IDE emulation to virtio-blk. Likewise, you could do > something like that to promo

Re: [Qemu-devel] Guest kernel device compatability auto-detection

2011-08-26 Thread Richard W.M. Jones
On Fri, Aug 26, 2011 at 09:08:02AM +0300, Sasha Levin wrote: > You're thinking about trying to expose all interfaces during boot and > seeing which ones the kernel bites? No, that's a bad idea. A current guest would register that as two disks. It might even try to write to them independently. Y

Re: [Qemu-devel] Guest kernel device compatability auto-detection

2011-08-26 Thread Richard W.M. Jones
On Fri, Aug 26, 2011 at 01:18:49PM +0300, Sasha Levin wrote: > On Fri, 2011-08-26 at 09:04 +0100, Richard W.M. Jones wrote: > > On Fri, Aug 26, 2011 at 09:22:45AM +0300, Sasha Levin wrote: > > > On Thu, 2011-08-25 at 16:25 +, Decker, Schorschi wrote: > > > >

[Qemu-devel] [PATCH] backends/baum.c: Fix compilation when SDL is not available.

2014-03-21 Thread Richard W.M. Jones
98:64: error: missing binary operator before token "(" #if defined(CONFIG_SDL) && SDL_COMPILEDVERSION < SDL_VERSIONNUM(2, 0, 0) Signed-off-by: Richard W.M. Jones --- backends/baum.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/backends/baum.

[Qemu-devel] aarch64: -device virtio-scsi-device, id=scsi: No 'virtio-bus' bus found for device 'virtio-scsi-device'

2014-03-25 Thread Richard W.M. Jones
Does anyone have any thoughts on what I'm missing / doing wrong here? [00616ms] /home/remote/rjones/d/qemu/aarch64-softmmu/qemu-system-aarch64 \ -global virtio-blk-device.scsi=off \ -nodefconfig \ -enable-fips \ -nodefaults \ -display none \ -machine accel=kvm:tcg \ -m

Re: [Qemu-devel] aarch64: -device virtio-scsi-device, id=scsi: No 'virtio-bus' bus found for device 'virtio-scsi-device'

2014-03-25 Thread Richard W.M. Jones
On Tue, Mar 25, 2014 at 02:53:19PM +0100, Paolo Bonzini wrote: > Il 25/03/2014 14:30, Richard W.M. Jones ha scritto: > >Does anyone have any thoughts on what I'm missing / doing wrong here? > > > >[00616ms] /home/remote/rjones/d/qemu/aarch64-softmmu/qemu-system-aarch64 \

[Qemu-devel] [PATCH] arm64: Set source for ret instruction correctly.

2013-12-23 Thread Richard W.M. Jones
From: "Richard W.M. Jones" Fixes https://bugs.launchpad.net/qemu/+bug/1263747 Signed-off-by: Richard W.M. Jones Tested-by: Richard W.M. Jones --- target-arm/translate-a64.c | 1 - 1 file changed, 1 deletion(-) diff --git a/target-arm/translate-a64.c b/target-arm/translate-a

Re: [Qemu-devel] [PATCH] arm64: Set source for ret instruction correctly.

2013-12-24 Thread Richard W.M. Jones
On Mon, Dec 23, 2013 at 10:17:15PM +, Peter Maydell wrote: > FWIW mainline's handling of this insn doesn't have this bug. OT: Is there a clear explanation of the various aarch64 trees? I noticed that upstream qemu has some files like target-arm/ translate-a64.c, but it didn't (and still doesn'

Re: [Qemu-devel] TRIM/DISCARD/UNMAP support on qemu-nbd

2014-01-02 Thread Richard W.M. Jones
On Mon, Dec 30, 2013 at 07:58:29PM +0800, Teng-Feng Yang wrote: > I have been studying QCOW2 file format for a couple of days, and I am > a little bit confused about whether QCOW2 supports UNMAP or not. > As I surf through internet, some mailing list discussion had mentioned > that qemu-nbd and nbd

Re: [Qemu-devel] TRIM/DISCARD/UNMAP support on qemu-nbd

2014-01-07 Thread Richard W.M. Jones
On Tue, Jan 07, 2014 at 03:48:54PM +0100, Paolo Bonzini wrote: > Il 02/01/2014 17:15, Richard W.M. Jones ha scritto: > > > > My (possibly weak) understanding of the upstream qemu code is that > > unmap/discard/trim is not supported in qcow2. It is only supported in >

Re: [Qemu-devel] TRIM/DISCARD/UNMAP support on qemu-nbd

2014-01-07 Thread Richard W.M. Jones
Using qcow2 format, it also doesn't appear to work: $ /tmp/sparsetest.sh Formatting '/tmp/test1', fmt=qcow2 size=104857600 encryption=off cluster_size=65536 lazy_refcounts=off Formatting '/tmp/test2', fmt=qcow2 size=104857600 encryption=off cluster_size=65536 lazy_refcounts=off 136K /tm

Re: [Qemu-devel] TRIM/DISCARD/UNMAP support on qemu-nbd

2014-01-07 Thread Richard W.M. Jones
On Tue, Jan 07, 2014 at 09:48:17PM +0100, Paolo Bonzini wrote: > Il 07/01/2014 21:27, Richard W.M. Jones ha scritto: > > Not much more what I said in the original email (especially see the > > attached script which you can download from the bottom of this page: > > https://

Re: [Qemu-devel] QEMU detachable overlays and Union Mounts

2014-01-08 Thread Richard W.M. Jones
On Wed, Jan 08, 2014 at 11:26:28AM +0530, kausik pal wrote: > If this message should go elsewhere, my apologies. > > It would be great if QEMU have the capability of detachable overlay or > union mount. > So administrators can keep each software as separate individual qcow2/qed > disks and can put

Re: [Qemu-devel] TRIM/DISCARD/UNMAP support on qemu-nbd

2014-01-08 Thread Richard W.M. Jones
On Wed, Jan 08, 2014 at 11:11:35PM +0100, Paolo Bonzini wrote: > Is guestfish using "discard=on"? No. Adding the discard=on parameter does indeed fix this: 13M/tmp/test1 17M/tmp/test2 However why isn't this the default? Is there a case where discard=on would be undesirable? It's extre

Re: [Qemu-devel] QEMU detachable overlays and Union Mounts

2014-01-08 Thread Richard W.M. Jones
On Wed, Jan 08, 2014 at 11:37:44PM +0530, kausik pal wrote: > Hi rich, > > Thanks for the answer. > > I was wondering how unidesk has solved the problem using disk layering. > They have the solution for VMware, so if similar feature can be built on > qemu for KVM hypervisor then we will have a gr

Re: [Qemu-devel] TRIM/DISCARD/UNMAP support on qemu-nbd

2014-01-08 Thread Richard W.M. Jones
On Wed, Jan 08, 2014 at 11:45:39PM +0100, Paolo Bonzini wrote: > Il 08/01/2014 23:24, Richard W.M. Jones ha scritto: > > It's extremely difficult to know when it's safe to add this parameter. > > Qemu gives no indication of when using discard=.. is safe (ie. won't &

Re: [Qemu-devel] [PATCH] block/curl: Implement the libcurl timer callback interface

2014-01-15 Thread Richard W.M. Jones
On Wed, Jan 15, 2014 at 05:23:58PM +, Peter Maydell wrote: > libcurl versions 7.16.0 and later have a timer callback interface which > must be implemented in order for libcurl to make forward progress (it > will sometimes rely on being called back on the timeout if there are > no file descripto

Re: [Qemu-devel] [PATCH] block/curl: Implement the libcurl timer callback interface

2014-01-16 Thread Richard W.M. Jones
On Wed, Jan 15, 2014 at 11:06:23PM +0100, Paolo Bonzini wrote: > Il 15/01/2014 18:23, Peter Maydell ha scritto: > > libcurl versions 7.16.0 and later have a timer callback interface which > > must be implemented in order for libcurl to make forward progress (it > > will sometimes rely on being call

<    1   2   3   4   5   6   7   8   9   10   >