[Qemu-devel] [Bug 1013241] Re: qemu-system-ppc64 hanging occasionally in disk writes

2012-06-19 Thread Richard W.M. Jones
I switched to using virtio-scsi (instead of virtio-blk). This appears to have solved this problem, although it brings another problem. I also tried vscsi, which fixes both problems. Therefore I will (not definitively) claim that the problem lies somewhere in virtio-blk, but a workaround seems

[Qemu-devel] [Bug 1013241] Re: qemu-system-ppc64 hanging occasionally in disk writes

2012-06-19 Thread Richard W.M. Jones
The problem with virtio-scsi is only a single disk shows up: https://bugs.launchpad.net/qemu/+bug/1013691 I've been using guest kernels 3.3.4 and 3.5.0-rc2+ (ie. Linus git), and both behave the same way. -- You received this bug notification because you are a member of qemu- devel-ml, which is

Re: [Qemu-devel] qemu-system-ppc64 hanging occasionally in disk writes

2012-06-28 Thread Richard W.M. Jones
On Thu, Jun 28, 2012 at 04:25:26PM +0200, Alexander Graf wrote: > On 06/15/2012 12:01 AM, Richard W.M. Jones wrote: > >On Thu, Jun 14, 2012 at 11:34:37PM +0200, Alexander Graf wrote: > >>>/home/rjones/d/qemu/ppc64-softmmu/qemu-system-ppc64 \ > >>>

[Qemu-devel] [PATCH] Replace 'struct siginfo' with 'siginfo_t'.

2012-07-05 Thread Richard W.M. Jones
From: "Richard W.M. Jones" glibc 2.16 will remove the undocumented definition of 'struct siginfo' from . This change is already present in glibc 2.15.90, so qemu compilation of certain targets (eg. cris-user) breaks. This struct was always typedef'd to be the same as

Re: [Qemu-devel] [PATCH] Replace 'struct siginfo' with 'siginfo_t'.

2012-07-05 Thread Richard W.M. Jones
On Thu, Jul 05, 2012 at 03:16:12PM +0100, Peter Maydell wrote: > On 5 July 2012 14:32, Richard W.M. Jones wrote: > > From: "Richard W.M. Jones" > > > > glibc 2.16 will remove the undocumented definition of 'struct siginfo' > > from . > >

[Qemu-devel] [Bug 1021649] [NEW] qemu 1.1.0 waits for a keypress at boot

2012-07-06 Thread Richard W.M. Jones
Public bug reported: qemu 1.1.0 waits for a keypress at boot. Please don't ever do this. Try the attached test script. When run it will initially print nothing, until you hit a key on the keyboard. Removing -nographic fixes the problem. Using virtio-scsi instead of virtio-blk fixes the proble

[Qemu-devel] [Bug 1021649] Re: qemu 1.1.0 waits for a keypress at boot

2012-07-06 Thread Richard W.M. Jones
Also affects upstream qemu from git. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1021649 Title: qemu 1.1.0 waits for a keypress at boot Status in QEMU: New Bug description: qemu 1.1.0 waits

[Qemu-devel] [Bug 1021649] Re: qemu 1.1.0 waits for a keypress at boot

2012-07-06 Thread Richard W.M. Jones
** Attachment added: "test-qemu.sh" https://bugs.launchpad.net/bugs/1021649/+attachment/3214808/+files/test-qemu.sh -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1021649 Title: qemu 1.1.0 waits

[Qemu-devel] [Bug 1021649] Re: qemu 1.1.0 waits for a keypress at boot

2012-07-06 Thread Richard W.M. Jones
Using -device sga fixes the problem, but also means I cannot see what it's trying to wait for. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1021649 Title: qemu 1.1.0 waits for a keypress at boot

[Qemu-devel] [Bug 1021649] Re: qemu 1.1.0 waits for a keypress at boot

2012-07-07 Thread Richard W.M. Jones
Yes, I tested it again and it does look like it's loading a Fedora ROM. Dammit ... ** Changed in: qemu Status: New => Invalid -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1021649 Title: qe

[Qemu-devel] [Bug 1021649] Re: qemu 1.1.0 waits for a keypress at boot

2012-07-08 Thread Richard W.M. Jones
Well that's very interesting because one of the patches we have added in Fedora is: http://pkgs.fedoraproject.org/gitweb/?p=qemu.git;a=blob;f=0001-qemu-kvm- Add-missing-default-machine- options.patch;h=e785a708d0bf0861c2f0f1777b8cc477d12fe145;hb=HEAD -- You received this bug notification because

Re: [Qemu-devel] [PATCH] Replace 'struct siginfo' with 'siginfo_t'.

2012-07-09 Thread Richard W.M. Jones
On Thu, Jul 05, 2012 at 02:32:44PM +0100, Richard W.M. Jones wrote: > From: "Richard W.M. Jones" > > glibc 2.16 will remove the undocumented definition of 'struct siginfo' > from . > > This change is already present in glibc 2.15.90, so qemu compilati

[Qemu-devel] ANNOUNCE: libguestfs 1.20 - tools for accessing and modifying virtual machine disk images

2012-12-13 Thread Richard W.M. Jones
I'm very pleased to announce the release of libguestfs 1.20. Libguestfs is a library and a comprehensive set of tools for accessing and modifying virtual machine (VM) disk images. For more information see http://libguestfs.org Libguestfs 1.20 represents 7 months of upstream work, dozens of major

Re: [Qemu-devel] [virt-tools-list] [PATCH] qemu:cpuid: speedup test by 3x times if grub2 is available

2013-02-14 Thread Richard W.M. Jones
On Thu, Feb 14, 2013 at 11:41:08AM -0200, Eduardo Habkost wrote: > (CCing virt-tools list in case they have any existing solutions or ideas > on how to make this easier for everybody) supermin? http://people.redhat.com/~rjones/supermin/ It already exists on Fedora, Debian & Ubuntu, although it m

Re: [Qemu-devel] [virt-tools-list] [PATCH] qemu:cpuid: speedup test by 3x times if grub2 is available

2013-02-14 Thread Richard W.M. Jones
On Thu, Feb 14, 2013 at 06:41:26PM +, Richard W.M. Jones wrote: > On Thu, Feb 14, 2013 at 11:41:08AM -0200, Eduardo Habkost wrote: > > (CCing virt-tools list in case they have any existing solutions or ideas > > on how to make this easier for everybody) > > supermin? htt

Re: [Qemu-devel] [virt-tools-list] [PATCH] qemu:cpuid: speedup test by 3x times if grub2 is available

2013-02-14 Thread Richard W.M. Jones
On Thu, Feb 14, 2013 at 05:07:48PM -0200, Eduardo Habkost wrote: > On Thu, Feb 14, 2013 at 06:41:26PM +0000, Richard W.M. Jones wrote: > > On Thu, Feb 14, 2013 at 11:41:08AM -0200, Eduardo Habkost wrote: > > > (CCing virt-tools list in case they have any existing solutions or ide

Re: [Qemu-devel] [PATCH v9 2/4] qemu: URI parsing library

2012-09-24 Thread Richard W.M. Jones
On Mon, Sep 24, 2012 at 02:42:02PM +0530, Bharata B Rao wrote: > qemu: URI parsing library > > From: Paolo Bonzini > > Add a new URI parsing library to QEMU. The code has been borrowed from > libxml2 and libvirt. Rather than duplicating the libxml2 code, I think it would be better to depend on

Re: [Qemu-devel] KVM call agenda for September 25th

2012-09-25 Thread Richard W.M. Jones
On Mon, Sep 24, 2012 at 01:48:26PM +0200, Paolo Bonzini wrote: > Il 24/09/2012 13:28, Juan Quintela ha scritto: > > Hi > > > > Please send in any agenda items you are interested in covering. > > URI parsing library for glusterfs: libxml2 vs. in-tree "fork" of the > same code. I can't make this c

Re: [Qemu-devel] KVM call agenda for September 25th

2012-09-25 Thread Richard W.M. Jones
On Tue, Sep 25, 2012 at 07:57:53AM -0500, Anthony Liguori wrote: > Paolo Bonzini writes: > > > Il 24/09/2012 13:28, Juan Quintela ha scritto: > >> Hi > >> > >> Please send in any agenda items you are interested in covering. > > > > URI parsing library for glusterfs: libxml2 vs. in-tree "fork" of

[Qemu-devel] qemu 1.2 segfault on shutdown (ioh->deleted == false, io->fd == -1)

2012-08-31 Thread Richard W.M. Jones
I'm tracking this bug here: https://bugzilla.redhat.com/show_bug.cgi?id=853408 Does anyone recognize this segfault on shutdown when using either a console or a virtio-serial char device? It's only caught in Fedora because we compile with 'fortify source' so the attempt to modify a negative offse

Re: [Qemu-devel] [PATCH V6 0/2] Add JSON output to qemu-img info

2012-09-03 Thread Richard W.M. Jones
On Mon, Aug 27, 2012 at 09:15:50AM +0200, Benoît Canet wrote: > This patchset add a JSON output mode to the qemu-img info command. > It's a rewrite from scratch of the original patchset by Wenchao Xia > following Anthony Liguori advices on JSON formating. I won't comment on the patch set, but some

Re: [Qemu-devel] [PATCH] socket: don't attempt to reconnect a TCP socket in server mode

2012-09-12 Thread Richard W.M. Jones
On Wed, Sep 05, 2012 at 02:01:36PM -0500, Anthony Liguori wrote: > Commit c3767ed0eb5d0bb25fe409ae5dec06e3411ff1b6 introduced a possible SEGV > when > using a socket chardev with server=on because it assumes that all TCP sockets > are in client mode. > > This patch adds a check to only reconnect

Re: [Qemu-devel] pvpanic plans?

2013-08-27 Thread Richard W.M. Jones
On Thu, Aug 22, 2013 at 03:09:06PM -0500, Anthony Liguori wrote: > Paolo Bonzini writes: > > Also, a virtio watchdog device makes little sense, IMHO. PV makes sense > > if emulation has insufficient performance, excessive CPU usage, or > > excessive complexity. We already have both an ISA and a

Re: [Qemu-devel] pvpanic plans?

2013-08-27 Thread Richard W.M. Jones
On Thu, Aug 22, 2013 at 01:25:32PM -0500, Anthony Liguori wrote: > I believe that the watchdogs we emulate today are not supported by a > majority of guests. BTW this is not true. The two watchdog devices are supported by all Linux guests. Windows guests do not support them, but Windows lacks[1]

Re: [Qemu-devel] pvpanic plans?

2013-08-27 Thread Richard W.M. Jones
On Tue, Aug 27, 2013 at 04:08:12PM +0300, Ronen Hod wrote: > So the right solution is to send a heart-beat to a management > application (using qemu-ga or whatever), and let it decide how to > handle it. Agreed. The qemu watchdog lets you do this already. You can (using the qemu monitor, or libv

Re: [Qemu-devel] [libvirt] pvpanic plans?

2013-08-27 Thread Richard W.M. Jones
On Tue, Aug 27, 2013 at 02:13:34PM +0100, Daniel P. Berrange wrote: > On Thu, Aug 22, 2013 at 09:16:57PM +0200, Paolo Bonzini wrote: > > Il 22/08/2013 19:53, Laszlo Ersek ha scritto: > > >> > We should just introduce a simple watchdog device based on virtio and > > >> > call it a day. Then it's cr

Re: [Qemu-devel] pvpanic plans?

2013-08-27 Thread Richard W.M. Jones
On Tue, Aug 27, 2013 at 08:26:53AM -0500, Anthony Liguori wrote: > That's why I think having a virtio-ilo makes sense. This is not a > solved problem today. What's the scope of virtio-ilo? If it's anything like a real ILO it's going to do a lot of not-very-related things, such as: - pvpanic-ty

Re: [Qemu-devel] [PULL 7/7] tcg-i386: Use new return-argument ld/st helpers

2013-08-28 Thread Richard W.M. Jones
On Mon, Aug 26, 2013 at 02:00:12PM -0700, Richard Henderson wrote: > Discontinue the jump-around-jump-to-jump scheme, trading it for a single > immediate move instruction. The two extra jumps always consume 7 bytes, > whereas the immediate move is either 5 or 7 bytes depending on where the > code_

Re: [Qemu-devel] [PATCH] tcg-i386: Remove abort from GETPC_LDST

2013-08-29 Thread Richard W.M. Jones
e of tail calls > all the way into the memory helper functions, leading to a stack > frame in which the memory helper function appeared to be called > directly from tcg. > > Signed-off-by: Richard Henderson This fixes the bug I saw. Tested-by: Richard W.M. Jones Rich. -- Rich

Re: [Qemu-devel] [PATCH] qapi-types.py: Fix enum struct sizes on i686

2013-09-02 Thread Richard W.M. Jones
i386-softmmu/qemu-system-i386 -S -nodefaults -nographic -M none -qmp stdio > > https://bugs.launchpad.net/qemu/+bug/1219207 > > Cc: qemu-sta...@nongnu.org > Signed-off-by: Cole Robinson Works for me, so you can add: Tested-by: Richard W.M. Jones Rich. -- Richard Jones, Virtualization Gro

Re: [Qemu-devel] Qemu Booting a PC without an MBR?

2013-09-02 Thread Richard W.M. Jones
On Fri, Aug 30, 2013 at 08:28:29AM +0200, Peter Lieven wrote: > Hi all, > > today I had the second incidence of a migrated system (copied with > DD) to qemu which won't boot. (stuck after booting from harddisk > message). You should probably have looked at virt-v2v, but you are where you are now,

Re: [Qemu-devel] Qemu Booting a PC without an MBR?

2013-09-02 Thread Richard W.M. Jones
Actually assuming it's a Linux guest, a third option would be: (3) Use an external kernel + initrd: guestfish -a disk.img -i > download /boot/vmlinuz-... /tmp/kernel > download /boot/initrd-... /tmp/initrd qemu -kernel /tmp/kernel -initrd /tmp/initrd -hda disk.img ... Rich. -- Richard Jones,

[Qemu-devel] [PATCH] q35: Fix typo in constant DEFUALT -> DEFAULT.

2013-09-02 Thread Richard W.M. Jones
From: "Richard W.M. Jones" Signed-off-by: Richard W.M. Jones --- hw/pci-host/q35.c | 2 +- include/hw/pci-host/q35.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/pci-host/q35.c b/hw/pci-host/q35.c index 12314d8..9ed0a3d 100644 --- a/hw/pci-host/q

Re: [Qemu-devel] [PATCH v3 00/29] tcg-aarch64 improvements

2013-09-03 Thread Richard W.M. Jones
On Mon, Sep 02, 2013 at 10:54:34AM -0700, Richard Henderson wrote: > I'm not sure if I posted v2 or not, but my branch is named -3, > therefore this is v3. ;-) > > The jumbo "fixme" patch from v1 has been split up. This has been > updated for the changes in the tlb helpers over the past few week

[Qemu-devel] [PATCH] ssh: Don't crash if either host or path is not specified.

2014-09-29 Thread Richard W.M. Jones
!= ((void *)0)' failed. Aborted A similar crash also happens if the file.host field is omitted. https://bugzilla.redhat.com/show_bug.cgi?id=1147343 Bug found and reported by Jun Li. Signed-off-by: Richard W.M. Jones --- block/ssh.c | 10 ++ 1 file changed, 10 insertions(+) diff

[Qemu-devel] [PATCH v2] ssh: Don't crash if either host or path is not specified.

2014-09-29 Thread Richard W.M. Jones
!= ((void *)0)' failed. Aborted A similar crash also happens if the file.host field is omitted. https://bugzilla.redhat.com/show_bug.cgi?id=1147343 Bug found and reported by Jun Li. Signed-off-by: Richard W.M. Jones --- block/ssh.c | 10 ++ 1 file changed, 10 insertions(+) diff

Re: [Qemu-devel] [PATCH v2 1/1] -machine vmport=off: Allow disabling of VMWare ioport emulation

2014-10-06 Thread Richard W.M. Jones
ore=on|off > diff --git a/vl.c b/vl.c > index 9d2aaaf..26fa864 100644 > --- a/vl.c > +++ b/vl.c > @@ -389,6 +389,10 @@ static QemuOptsList qemu_machine_opts = { > .name = PC_MACHINE_MAX_RAM_BELOW_4G, > .type = QEMU_OPT_SIZE, >

[Qemu-devel] [PATCH] block/curl: Improve type safety of s->timeout.

2014-10-06 Thread Richard W.M. Jones
pen 'json: { "file.driver":"https", "file.url":"https://foo/bar";, "file.timeout":-1 }': timeout parameter is too large or negative: Invalid argument Signed-off-by: Richard W.M. Jones --- block/curl.c | 8 ++-- 1 file changed, 6

Re: [Qemu-devel] [PATCH] block/curl: Improve type safety of s->timeout.

2014-10-06 Thread Richard W.M. Jones
On Mon, Oct 06, 2014 at 04:38:59PM +0200, Laszlo Ersek wrote: > On 10/06/14 16:32, Richard W.M. Jones wrote: > > qemu_opt_get_number returns a uint64_t, and curl_easy_setopt expects a > > long (not an int). > > > > Store the timeout (which is a positive number of

Re: [Qemu-devel] [Bug 1378554] [NEW] qemu segfault in virtio_scsi_handle_cmd_req_submit on ARM 32 bit

2014-10-08 Thread Richard W.M. Jones
; static void virtio_scsi_handle_cmd(VirtIODevice *vdev, VirtQueue *vq) > > ? Yes, that fixes it. Tested-by: Richard W.M. Jones Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com Fedora

Re: [Qemu-devel] [PATCH v9 1/3] block: Add support for Secure Shell (ssh) block device.

2013-04-11 Thread Richard W.M. Jones
Thanks. I've also developed patches to incorporate this feature into libvirt and libguestfs. Here are the latest versions of these: https://www.redhat.com/archives/libvir-list/2013-April/thread.html#00803 https://www.redhat.com/archives/libguestfs/2013-April/thread.html#00021 Rich. -- Richard

Re: [Qemu-devel] [PATCH] block/ssh: Add missing gcc format attributes

2013-04-18 Thread Richard W.M. Jones
On Thu, Apr 18, 2013 at 10:21:05PM +0200, Stefan Weil wrote: > Now gcc will check whether format string and variable arguments match. > > Signed-off-by: Stefan Weil ACK, this looks fine to me. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones virt-top is '

Re: [Qemu-devel] block/ssh: Compilation fails on Debian squeeze

2013-04-18 Thread Richard W.M. Jones
On Thu, Apr 18, 2013 at 10:42:09PM +0200, Stefan Weil wrote: > Am 18.04.2013 22:21, schrieb Stefan Weil: > > Now gcc will check whether format string and variable arguments match. > > > > Signed-off-by: Stefan Weil > > --- > > > > Please note: I could only run limited tests with the new code > > b

[Qemu-devel] [PATCH] ssh: Remove unnecessary use of strlen function.

2013-04-18 Thread Richard W.M. Jones
From: "Richard W.M. Jones" --- block/ssh.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/block/ssh.c b/block/ssh.c index 8f78e2e..7bc008d 100644 --- a/block/ssh.c +++ b/block/ssh.c @@ -387,15 +387,13 @@ static int check_host_key(BDRVSSHState *s, const c

[Qemu-devel] [PATCH] block/ssh: Require libssh2 >= 1.2.8.

2013-04-19 Thread Richard W.M. Jones
From: "Richard W.M. Jones" libssh2 >= 1.2.8 is required to enable this block device (because that version introduced the libssh2_session_handshake call). Change the test to use pkg-config exclusively. If the user requests --enable-libssh2 and the minimum version is not availa

[Qemu-devel] [PATCH v8 0/2] aarch64: Allow -kernel option to take a gzip-compressed kernel

2014-08-12 Thread Richard W.M. Jones
Changes since v7: - Rebase against current head & retest. - Don't use `allow_compressed_kernel' boolean, but use arm_feature test at point of use instead. - Added Reviewed-by tags (thanks Peter Crosthwaite). Rich.

[Qemu-devel] [PATCH v8 2/2] aarch64: Allow -kernel option to take a gzip-compressed kernel.

2014-08-12 Thread Richard W.M. Jones
linuz because it tries to execute the gzip-compressed data. This commit lets gzip-compressed kernels be uncompressed transparently. Currently this is only done when emulating aarch64. Signed-off-by: Richard W.M. Jones Reviewed-by: Alex Bennée Reviewed-by: Peter Crosthwaite --- hw/arm/boot.

[Qemu-devel] [PATCH v8 1/2] loader: Add load_image_gzipped function.

2014-08-12 Thread Richard W.M. Jones
As the name suggests this lets you load a ROM/disk image that is gzipped. It is uncompressed before storing it in guest memory. Signed-off-by: Richard W.M. Jones Reviewed-by: Alex Bennée Reviewed-by: Peter Crosthwaite --- hw/core/loader.c| 48

Re: [Qemu-devel] disk image: self-organized format or raw file

2014-08-12 Thread Richard W.M. Jones
On Tue, Aug 12, 2014 at 08:07:55AM -0600, Eric Blake wrote: > On 08/12/2014 07:45 AM, 吴兴博 wrote: > > [please don't top-post on technical lists] > > > Thanks for your information. It's really helpful. > > I think adding a bitmap alongside the raw file ( or just within that file) > > Umm, how do y

Re: [Qemu-devel] disk image: self-organized format or raw file

2014-08-12 Thread Richard W.M. Jones
On Tue, Aug 12, 2014 at 07:46:30PM +0100, Daniel P. Berrange wrote: > Taking the compression feature - arguably the biggest benefit of that > is when you distribute disk images. eg if someone provides a root disk > image on a web server, using compression in qcow2 can dramatically > lower the downl

Re: [Qemu-devel] disk image: self-organized format or raw file

2014-08-12 Thread Richard W.M. Jones
On Tue, Aug 12, 2014 at 03:23:38PM -0400, Xingbo Wu wrote: > would be very space efficient for distribution :). > Would you consider replace xz with lz4? it has faster decompression speed > (~500MB/s)[1] and client-side decompression would be made painless. No. The main benefit of xz is it has a

Re: [Qemu-devel] [PATCH v12 0/6] qcow2, raw: add preallocation=full and preallocation=falloc

2014-08-22 Thread Richard W.M. Jones
On Mon, Jul 28, 2014 at 04:48:46PM +0800, Hu Tao wrote: > ping... > > All the 6 patches have reviewed-by now. > > On Fri, Jul 11, 2014 at 02:09:57PM +0800, Hu Tao wrote: > > This series adds two preallocation mode to qcow2 and raw: > > > > Option preallocation=full preallocates disk space for i

Re: [Qemu-devel] [PATCH v12 0/6] qcow2, raw: add preallocation=full and preallocation=falloc

2014-08-22 Thread Richard W.M. Jones
On Fri, Aug 22, 2014 at 03:13:31PM +0200, Kevin Wolf wrote: > Am 22.08.2014 um 14:25 hat Richard W.M. Jones geschrieben: > > > > On Mon, Jul 28, 2014 at 04:48:46PM +0800, Hu Tao wrote: > > > ping... > > > > > > All the 6 patches have reviewed-by now.

Re: [Qemu-devel] [PATCH v12 0/6] qcow2, raw: add preallocation=full and preallocation=falloc

2014-08-22 Thread Richard W.M. Jones
On Fri, Aug 22, 2014 at 05:22:33PM +0200, Kevin Wolf wrote: > It's still useful because it happens to reduce the overhead in most > implementations and it's a relatively quick operation, but the best way > I know of to actually _fully_ preallocate is still writing zeros. Which > of the two the user

Re: [Qemu-devel] [PATCH v12 0/6] qcow2, raw: add preallocation=full and preallocation=falloc

2014-08-22 Thread Richard W.M. Jones
On Fri, Aug 22, 2014 at 04:34:40PM +0100, Richard W.M. Jones wrote: > - really really try as hard as possible to make sure that future >allocations will never fail (ie. write random non-zero data to the >file) s/will never fail/are not needed and will never fail/ Rich. --

Re: [Qemu-devel] [PATCH v12 0/6] qcow2, raw: add preallocation=full and preallocation=falloc

2014-08-22 Thread Richard W.M. Jones
On Fri, Aug 22, 2014 at 05:53:22PM +0200, Kevin Wolf wrote: > Am 22.08.2014 um 17:34 hat Richard W.M. Jones geschrieben: > > On Fri, Aug 22, 2014 at 05:22:33PM +0200, Kevin Wolf wrote: > > > It's still useful because it happens to reduce the overhead in most > >

Re: [Qemu-devel] [PATCH v12 0/6] qcow2, raw: add preallocation=full and preallocation=falloc

2014-08-25 Thread Richard W.M. Jones
On Mon, Aug 25, 2014 at 01:18:30PM +0800, Hu Tao wrote: > On Fri, Aug 22, 2014 at 05:00:08PM +0100, Richard W.M. Jones wrote: > > What is proposed to be called 'preallocation=falloc' should fall back > > to other methods (eg. writing random, writing zeroes). It should >

Re: [Qemu-devel] [PATCH v12 0/6] qcow2, raw: add preallocation=full and preallocation=falloc

2014-08-25 Thread Richard W.M. Jones
On Mon, Aug 25, 2014 at 01:18:30PM +0800, Hu Tao wrote: > What if user cares about time(writing zeroes or non-zeroes is > time-consuming) and wants falloc only sometimes? I think this is the > main difference between preallocation=falloc and preallocation=full. Also posix_fallocate in glibc falls

[Qemu-devel] [PATCH] curl: The macro that you have to uncomment to get debugging is DEBUG_CURL.

2014-08-26 Thread Richard W.M. Jones
Signed-off-by: Richard W.M. Jones --- block/curl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/curl.c b/block/curl.c index 2698ae3..46f1082 100644 --- a/block/curl.c +++ b/block/curl.c @@ -26,7 +26,7 @@ #include "qapi/qmp/qbool.h" #include -// #de

Re: [Qemu-devel] [PATCH v3] block.curl: adding 'timeout' option

2014-08-26 Thread Richard W.M. Jones
wait for the connection. > > Adding a new option to set this timeout gives the user this > flexibility. The previous default timeout of 5 seconds will be > used if this option is not present. > > Reviewed-by: Fam Zheng > Signed-off-by: Daniel Henrique Barboza You can add: Tes

[Qemu-devel] [PATCH] curl: Add override_accept_ranges flag to force sending range

2014-08-26 Thread Richard W.M. Jones
If you use this patch + Daniel Henrique Barboza's patch that adds a timeout, then you can access guest files on VMware ESX servers. Rich.

[Qemu-devel] [PATCH] curl: Add override_accept_ranges flag to force sending range requests.

2014-08-26 Thread Richard W.M. Jones
Some servers (notably VMware ESX) accept range requests, but don't send back the Accept-Ranges: bytes header in their initial response. For these servers you can set override_accept_ranges to 'on' which forces this block driver to send range requests anyway. Signed-off-by: Ric

Re: [Qemu-devel] [PATCH] curl: Add override_accept_ranges flag to force sending range requests.

2014-08-27 Thread Richard W.M. Jones
On Tue, Aug 26, 2014 at 08:57:30PM -0600, Eric Blake wrote: > On 08/26/2014 08:38 PM, Fam Zheng wrote: > > On Tue, 08/26 21:48, Richard W.M. Jones wrote: > >> Some servers (notably VMware ESX) accept range requests, but don't > >> send back the Accept-Ranges: bytes

Re: [Qemu-devel] [PATCH] curl: Add override_accept_ranges flag to force sending range requests.

2014-08-27 Thread Richard W.M. Jones
On Wed, Aug 27, 2014 at 08:37:22AM +0200, Markus Armbruster wrote: > Eric Blake writes: > > > On 08/26/2014 08:38 PM, Fam Zheng wrote: > >> On Tue, 08/26 21:48, Richard W.M. Jones wrote: > >>> Some servers (notably VMware ESX) accept range requests, but don&#x

[Qemu-devel] [PATCH] curl: Don't deref NULL pointer in call to aio_poll.

2014-08-27 Thread Richard W.M. Jones
Signed-off-by: Richard W.M. Jones --- block/curl.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/block/curl.c b/block/curl.c index 46f1082..8b69f28 100644 --- a/block/curl.c +++ b/block/curl.c @@ -355,7 +355,7 @@ static void curl_multi_timeout_do(void *arg) #endif

[Qemu-devel] [PATCH] curl: Don't deref NULL pointer in call to aio_poll.

2014-08-27 Thread Richard W.M. Jones
The original code in block/curl.c dereferences state *after* checking that it is NULL. That's obviously wrong, and indeed I can easily provoke a segfault when talking to a VMware vCenter server. I'm not as sure that this fix is the correct one, so please review it carefully. However it does at l

[Qemu-devel] [PATCH v2] curl: Don't deref NULL pointer in call to aio_poll.

2014-08-28 Thread Richard W.M. Jones
No change in the patch itself since v1. However I have added a longer explanation to the commit message. Rich.

[Qemu-devel] [PATCH v2] curl: Don't deref NULL pointer in call to aio_poll.

2014-08-28 Thread Richard W.M. Jones
uestfs to access a VMware vCenter Server and doing any kind of complex read-heavy operations. With this commit the segfault goes away. Signed-off-by: Richard W.M. Jones Reviewed-by: Paolo Bonzini --- block/curl.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/block/cu

[Qemu-devel] [PATCH] curl: Allow a cookie or cookies to be sent with http/https requests.

2014-08-28 Thread Richard W.M. Jones
mp;dsName=datastore1";, "file.sslverify":"off", "file.cookie":"vmware_soap_session=\"52a01262-bf93-ccce-d379-8dabb3e55560\""}' image: [...] file format: raw virtual size: 8.0G (8589934592 bytes) disk size: unavailable Signed-off-by: Ri

Re: [Qemu-devel] [PATCH v13 5/6] raw-posix: Add full preallocation option

2014-08-29 Thread Richard W.M. Jones
On Fri, Aug 29, 2014 at 04:33:12PM +0800, Hu Tao wrote: > +if (prealloc == PREALLOC_MODE_FULL) { > +/* posix_fallocate() doesn't set errno. */ > +result = -posix_fallocate(fd, 0, total_size); > +if (result != 0) { Is it better to test: result != ENOSYS && result != E

Re: [Qemu-devel] [PATCH v2] curl: Don't deref NULL pointer in call to aio_poll.

2014-08-29 Thread Richard W.M. Jones
On Fri, Aug 29, 2014 at 10:03:59AM +0100, Stefan Hajnoczi wrote: > On Thu, Aug 28, 2014 at 09:04:21AM +0100, Richard W.M. Jones wrote: > > diff --git a/block/curl.c b/block/curl.c > > index d4b85d2..f59615d 100644 > > --- a/block/curl.c > > +++ b/block/curl.c > >

Re: [Qemu-devel] [PATCH V9 0/2] Implement sync modes for drive-backup.

2013-07-29 Thread Richard W.M. Jones
On Mon, Jul 29, 2013 at 10:52:44AM +0200, Kevin Wolf wrote: > Am 26.07.2013 um 20:39 hat Ian Main geschrieben: > > This patch adds sync modes on top of the work that Stefan Hajnoczi has done. > > > > These patches apply on kevin/block. > > > > Hopefully all is in order as this is my first QEMU pa

Re: [Qemu-devel] [PATCH V9 0/2] Implement sync modes for drive-backup.

2013-07-29 Thread Richard W.M. Jones
On Mon, Jul 29, 2013 at 05:36:28PM +0800, Fam Zheng wrote: > On Mon, 07/29 10:02, Richard W.M. Jones wrote: > > On Mon, Jul 29, 2013 at 10:52:44AM +0200, Kevin Wolf wrote: > > > Am 26.07.2013 um 20:39 hat Ian Main geschrieben: > > > > This patch adds sync modes

Re: [Qemu-devel] [PATCH V9 0/2] Implement sync modes for drive-backup.

2013-07-29 Thread Richard W.M. Jones
On Mon, Jul 29, 2013 at 06:16:48PM +0800, Fam Zheng wrote: > Ian's patches are in master, on which I already rebased the first. I can > rebase the other one for you if you feel like to test it too. No that's fine, thanks. I just thought Ian had more patches which were not upstream, but if they're

[Qemu-devel] [PATCH] block/iscsi.c: Fix printf format error.

2013-07-31 Thread Richard W.M. Jones
From: "Richard W.M. Jones" The error on armv7hl was: block/iscsi.c: In function ‘is_request_lun_aligned’: block/iscsi.c:251:26: error: format ‘%ld’ expects argument of type ‘long int’, but argument 3 has type ‘int64_t’ [-Werror=format=] iscsilun-&

[Qemu-devel] [PATCH v2] block/iscsi.c: Fix printf format error.

2013-07-31 Thread Richard W.M. Jones
From: "Richard W.M. Jones" The error on armv7hl was: block/iscsi.c: In function ‘is_request_lun_aligned’: block/iscsi.c:251:26: error: format ‘%ld’ expects argument of type ‘long int’, but argument 3 has type ‘int64_t’ [-Werror=format=] iscsilun-&

[Qemu-devel] [PATCH v3] block/iscsi.c: Fix printf format error.

2013-07-31 Thread Richard W.M. Jones
From: "Richard W.M. Jones" The error on armv7hl was: block/iscsi.c: In function ‘is_request_lun_aligned’: block/iscsi.c:251:26: error: format ‘%ld’ expects argument of type ‘long int’, but argument 3 has type ‘int64_t’ [-Werror=format=] iscsilun-&

[Qemu-devel] Using virtio-mmio

2013-07-31 Thread Richard W.M. Jones
It's quite exciting the virtio-mmio made it into qemu. Are extra guest kernel components needed too? (I'm using 3.9.9-302.fc19.armv7hl but could try a later kernel) Anyway, I tried to get it to work, but can't quite work out the qemu command line. So far I have: $ ~/d/qemu/arm-softmmu/qemu-sys

Re: [Qemu-devel] Using virtio-mmio

2013-07-31 Thread Richard W.M. Jones
On Wed, Jul 31, 2013 at 11:01:11PM +0100, Peter Maydell wrote: > On 31 July 2013 22:56, Richard W.M. Jones wrote: > > It's quite exciting the virtio-mmio made it into qemu. Are extra > > guest kernel components needed too? (I'm using 3.9.9-302.fc19.armv7hl > &g

Re: [Qemu-devel] Using virtio-mmio

2013-08-01 Thread Richard W.M. Jones
On Thu, Aug 01, 2013 at 10:32:14AM +0100, Peter Maydell wrote: > On 31 July 2013 23:45, Richard W.M. Jones wrote: > > ~/d/qemu/arm-softmmu/qemu-system-arm \ > > -m 512 -M vexpress-a9 -machine kernel_irqchip=on \ > > The combination of 'vexpress-a9' and kernel_ir

Re: [Qemu-devel] Using virtio-mmio

2013-08-01 Thread Richard W.M. Jones
On Thu, Aug 01, 2013 at 11:58:15AM +0100, Peter Maydell wrote: > Unfortunately at this point you run into the classic > issue of trying to get an ARM kernel running, which > is that a huge class of config errors all have the > failure mode "just sits there with no serial output". > This is remarkab

Re: [Qemu-devel] [PATCH] Introduce cache images for the QCOW2 format

2013-08-14 Thread Richard W.M. Jones
On Wed, Aug 14, 2013 at 01:03:48PM +0100, Alex Bligh wrote: > > On 14 Aug 2013, at 12:52, Fam Zheng wrote: > > > Yes, this one sounds good to have. VMDK and VHDX have this kind of > > backing file status validation. > > ... though I'd prefer something safer than looking at mtime, for > instance

Re: [Qemu-devel] [PATCH 05/18] block/ssh: Drop superfluous libssh2_session_last_errno() calls

2014-05-14 Thread Richard W.M. Jones
On Tue, May 13, 2014 at 06:02:39PM +0200, Markus Armbruster wrote: > libssh2_session_last_error() already returns the error code. > > Cc: "Richard W.M. Jones" > Signed-off-by: Markus Armbruster > --- > block/ssh.c | 9 - > 1 file changed, 4 insertions(+),

Re: [Qemu-devel] [PATCH 09/18] block/ssh: Propagate errors to open and create methods

2014-05-14 Thread Richard W.M. Jones
The last four patches are just a refactoring to use qemu error handling, therefore ACK to all four of them. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-p2v converts physical ma

Re: [Qemu-devel] [PATCH 05/18] block/ssh: Drop superfluous libssh2_session_last_errno() calls

2014-05-14 Thread Richard W.M. Jones
On Wed, May 14, 2014 at 01:06:21PM +0200, Markus Armbruster wrote: > "Richard W.M. Jones" writes: > > > On Tue, May 13, 2014 at 06:02:39PM +0200, Markus Armbruster wrote: > >> libssh2_session_last_error() already returns the error code. > >> > >

Re: [Qemu-devel] [PATCH 05/18] block/ssh: Drop superfluous libssh2_session_last_errno() calls

2014-05-14 Thread Richard W.M. Jones
On Tue, May 13, 2014 at 06:02:39PM +0200, Markus Armbruster wrote: > libssh2_session_last_error() already returns the error code. > > Cc: "Richard W.M. Jones" > Signed-off-by: Markus Armbruster Reviewed-by: Richard W.M. Jones > block/ssh.c | 9 - > 1 file

Re: [Qemu-devel] [PATCH 06/18] block/ssh: Propagate errors through check_host_key()

2014-05-14 Thread Richard W.M. Jones
On Tue, May 13, 2014 at 06:02:40PM +0200, Markus Armbruster wrote: > Cc: "Richard W.M. Jones" > Signed-off-by: Markus Armbruster Reviewed-by: Richard W.M. Jones > block/ssh.c | 68 > - > 1 file chan

Re: [Qemu-devel] [PATCH 07/18] block/ssh: Propagate errors through authenticate()

2014-05-14 Thread Richard W.M. Jones
On Tue, May 13, 2014 at 06:02:41PM +0200, Markus Armbruster wrote: > Cc: "Richard W.M. Jones" > Signed-off-by: Markus Armbruster Reviewed-by: Richard W.M. Jones > block/ssh.c | 23 ++- > 1 file changed, 14 insertions(+), 9 deletions(-) > >

Re: [Qemu-devel] [PATCH 09/18] block/ssh: Propagate errors to open and create methods

2014-05-14 Thread Richard W.M. Jones
On Tue, May 13, 2014 at 06:02:43PM +0200, Markus Armbruster wrote: > Completes the conversion to Error started in commit 015a103^..d5124c0. > > Cc: "Richard W.M. Jones" > Signed-off-by: Markus Armbruster Reviewed-by: Richard W.M. Jones

Re: [Qemu-devel] [PATCH 08/18] block/ssh: Propagate errors through connect_to_ssh()

2014-05-14 Thread Richard W.M. Jones
On Tue, May 13, 2014 at 06:02:42PM +0200, Markus Armbruster wrote: > Cc: "Richard W.M. Jones" > Signed-off-by: Markus Armbruster Reviewed-by: Richard W.M. Jones > block/ssh.c | 34 +- > 1 file changed, 17 insertions(+), 17 deletions(-) &

Re: [Qemu-devel] [PATCH] -machine vmport=off: Allow disabling of VMWare ioport emulation

2014-05-19 Thread Richard W.M. Jones
option to allow it to be turned off. > > Signed-off-by: Dr. David Alan Gilbert Tested-by: Richard W.M. Jones I was able to use this option in order to install VMware ESXi as a guest under KVM. Here are my notes on how to do this: https://rwmj.wordpress.com/2014/05/19/notes-on-getting-vm

Re: [Qemu-devel] [PATCH] -machine vmport=off: Allow disabling of VMWare ioport emulation

2014-05-20 Thread Richard W.M. Jones
On Tue, May 20, 2014 at 09:47:26AM +0100, Dr. David Alan Gilbert wrote: > * Gerd Hoffmann (kra...@redhat.com) wrote: > > > /* init basic PC hardware */ > > > -pc_basic_device_init(isa_bus, gsi, &rtc_state, &floppy, > > > xen_enabled(), > > > -0x4); > > > +pc_basic_device_init

Re: [Qemu-devel] spec, RFC: TLS support for NBD

2014-10-17 Thread Richard W.M. Jones
On Sat, Oct 18, 2014 at 12:03:23AM +0200, Wouter Verhelst wrote: > Hi all, > > (added rjones from nbdkit fame -- hi there) [I'm happy to implement whatever you come up with, but I've added Florian Weimer to CC who is part of Red Hat's product security group] > So I think the following would make

[Qemu-devel] ANNOUNCE: libguestfs 1.28 released

2014-10-18 Thread Richard W.M. Jones
I'm pleased to announce libguestfs 1.28, a library and set of tools for accessing and modifying virtual machine disk images. This release took 7 months of work by a considerable number of people, and has many new features (see release notes below), including new 'virt-v2v' and 'virt-p2v' tools for

[Qemu-devel] [PATCH v1 repost] block/curl: Improve type safety of s->timeout.

2014-10-18 Thread Richard W.M. Jones
This patch is identical to the previous version, except that I have rebased it on top of current qemu HEAD. Previous discussion: https://lists.gnu.org/archive/html/qemu-devel/2014-10/threads.html#00518

[Qemu-devel] [PATCH v1 repost] block/curl: Improve type safety of s->timeout.

2014-10-18 Thread Richard W.M. Jones
pen 'json: { "file.driver":"https", "file.url":"https://foo/bar";, "file.timeout":-1 }': timeout parameter is too large or negative: Invalid argument Signed-off-by: Richard W.M. Jones Reviewed-by: Laszlo Ersek --- block/curl.c | 8 ++

Re: [Qemu-devel] spec, RFC: TLS support for NBD

2014-10-20 Thread Richard W.M. Jones
On Mon, Oct 20, 2014 at 01:56:43PM +0200, Florian Weimer wrote: > On 10/20/2014 01:51 PM, Markus Armbruster wrote: > >Furthermore, STARTTLS is vulnerable to active attacks: if you can get > >between the peers, you can make them fall back to unencrypted silently. > >How do you plan to guard against

[Qemu-devel] [PATCH v1 repost 2] block/curl: Improve type safety of s->timeout.

2014-10-26 Thread Richard W.M. Jones
No change since previous repost, except I have rebased it against git head. Three line change for obvious bug. Can I get another review? Previous discussion: https://lists.gnu.org/archive/html/qemu-devel/2014-10/threads.html#00518 Rich.

[Qemu-devel] [PATCH v1 repost 2] block/curl: Improve type safety of s->timeout.

2014-10-26 Thread Richard W.M. Jones
pen 'json: { "file.driver":"https", "file.url":"https://foo/bar";, "file.timeout":-1 }': timeout parameter is too large or negative: Invalid argument Signed-off-by: Richard W.M. Jones Reviewed-by: Laszlo Ersek --- block/curl.c | 8 ++

Re: [Qemu-devel] [PATCH v1 repost 2] block/curl: Improve type safety of s->timeout.

2014-10-26 Thread Richard W.M. Jones
On Sun, Oct 26, 2014 at 04:57:46PM +0800, Gonglei wrote: > On 2014/10/26 16:42, Richard W.M. Jones wrote: > > > qemu_opt_get_number returns a uint64_t, and curl_easy_setopt expects a > > long (not an int). > > > > Store the timeout (which is a positive number

  1   2   3   4   5   6   7   8   9   10   >