This patch creates a throttle initialization function to maximize the
code reusability. The same code is also used by fsdev.
Signed-off-by: Pradeep Jagadeesh
Reviewed-by: Alberto Garcia
Reviewed-by: Greg Kurz
Acked-by: Dr. David Alan Gilbert
---
hmp.c | 20 ++--
1 file
and fsdev files.
Pradeep Jagadeesh (6):
throttle: factor out duplicate code
qmp: Use ThrottleLimits structure
qmp: factor out throttle code to reuse code
hmp: create a throttle initialization function for code reuse
fsdev: QMP interface for throttling
fsdev: hmp interface for
This patch factors out code to use the ThrottleLimits
structure.
Signed-off-by: Pradeep Jagadeesh
---
qapi/block-core.json | 75 +++-
1 file changed, 3 insertions(+), 72 deletions(-)
diff --git a/qapi/block-core.json b/qapi/block-core.json
index
This patch factors out the duplicate throttle code that was still
present in block and fsdev devices.
Signed-off-by: Pradeep Jagadeesh
Reviewed-by: Alberto Garcia
Reviewed-by: Greg Kurz
Reviewed-by: Eric Blake
---
blockdev.c | 44 +-
fsdev
This patch introduces hmp interfaces for the fsdev
devices.
Signed-off-by: Pradeep Jagadeesh
Reviewed-by: Dr. David Alan Gilbert
Reviewed-by: Alberto Garcia
---
hmp-commands-info.hx | 18
hmp-commands.hx | 19
hmp.c| 61
This patch introduces qmp interfaces for the fsdev
devices. This provides two interfaces one
for querying info of all the fsdev devices. The second one
to set the IO limits for the required fsdev device.
Signed-off-by: Pradeep Jagadeesh
Reviewed-by: Dr. David Alan Gilbert
---
Makefile
This patch reuses the code to set throttle limits.
Signed-off-by: Pradeep Jagadeesh
---
blockdev.c | 53 +++--
1 file changed, 3 insertions(+), 50 deletions(-)
diff --git a/blockdev.c b/blockdev.c
index 9d33c25..2bd8ebd 100644
--- a/blockdev.c
On 9/23/2017 12:33 PM, Manos Pitsidianakis wrote:
On Fri, Sep 22, 2017 at 01:31:58PM +0200, Pradeep Jagadeesh wrote:
On 9/18/2017 6:20 PM, Manos Pitsidianakis wrote:
On Thu, Sep 14, 2017 at 06:40:05AM -0400, Pradeep Jagadeesh wrote:
This patch factors out the duplicate throttle code that was
Hi Alberto,
On Fri 16 Sep 2016 10:33:36 AM CEST, Pradeep Jagadeesh wrote:
Hi,
first of all, sorry for the late reply! Here are my comments:
--- a/fsdev/qemu-fsdev-opts.c
+++ b/fsdev/qemu-fsdev-opts.c
@@ -37,6 +37,82 @@ static QemuOptsList qemu_fsdev_opts = {
}, {
.name
Hi Greg,
On Wed, 21 Sep 2016 12:22:25 +0200
Pradeep Jagadeesh wrote:
Hi Greg,
Thanks for having a look at patchset.
See the replies below.
On Fri, 16 Sep 2016 04:33:36 -0400
Pradeep Jagadeesh wrote:
Uses throttling APIs to limit I/O bandwidth and number of operations on the
fsdev
Uses throttling APIs to limit I/O bandwidth and number of operations on the
devices which use 9p-local driver.
Signed-off-by: Pradeep Jagadeesh
---
fsdev/Makefile.objs | 1 +
fsdev/file-op-9p.h | 3 +
fsdev/qemu-fsdev-opts.c | 76 +++
fsdev/qemu
populated into the virtio-net structures.
Could some one please guide/suggest where to look into, in qemu code base?
Thanks & Regards,
Pradeep
Hi Marcin,
Hope you have compiled the qemu with virtfs enabled.i.e --enable-virtfs
And the cli looks like this. But I am working on x86 not ARM.
-fsdev local,id=root,path=${ROOTFS},security_model=none,writeout=immediate
-device virtio-9p-pci,fsdev=root,mount_tag=/dev/root
-Regards,
Pradeep
On 28 September 2016 at 10:29, Stefan Hajnoczi wrote:
> On Mon, Sep 26, 2016 at 05:41:55PM +0200, Pradeep Kiruvale wrote:
> > I want to add couple of new cli options for the virtio-net driver and use
> > them inside the
> > virtio-net driver to throttle the packets. I did go
Hi Stefan,
On 28 September 2016 at 10:29, Stefan Hajnoczi wrote:
> On Mon, Sep 26, 2016 at 05:41:55PM +0200, Pradeep Kiruvale wrote:
> > I want to add couple of new cli options for the virtio-net driver and use
> > them inside the
> > virtio-net driver to throttle the pack
migrated.
Please clarify.
Regards,
Pradeep
On 26 April 2017 at 18:14, Dr. David Alan Gilbert
wrote:
> * Pradeep Kiruvale (pradeepkiruv...@gmail.com) wrote:
> > Hi All,
> >
> > Is it possible to enable/disable to migration features on the fly for a
> > qemu VM?
> > I mean through qmp interface kind of a in
and fsdev files.
Pradeep Jagadeesh (4):
Throttle: Create IOThrottle structure
fsdev: QMP interface for throttling
qmp: refactor duplicate code
throttle: factor out duplicate code
Makefile| 3 ++
Makefile.objs | 4 +-
blockdev.c
This patchset factor out the duplicate throttle code that was present in
block and fsdev devices.
Signed-off-by: Pradeep Jagadeesh
---
blockdev.c | 44 +-
fsdev/qemu-fsdev-throttle.c | 43 +
include
This patchset introduces a new io throttle structure. This will be
used in both block and fsdev devices.
Signed-off-by: Pradeep Jagadeesh
---
qapi/block-core.json | 76 ++
qapi/iothrottle.json | 86
This patchset factor out the duplicate qmp throttle interface code
that was present in both block and fsdev device files.
Signed-off-by: Pradeep Jagadeesh
---
blockdev.c | 53 +++--
fsdev/qemu-fsdev-throttle.c | 51
This patchset enables qmp interfaces for the fsdev
devices. This provides two interfaces one
for querying info of all the fsdev devices. The second one
to set the IO limits for the required fsdev device.
Signed-off-by: Pradeep Jagadeesh
---
Makefile| 3 ++
Makefile.objs
On 5/3/2017 8:22 AM, Greg Kurz wrote:
s/Throttle/throttle
On Tue, 2 May 2017 10:29:43 -0400
Pradeep Jagadeesh wrote:
This patchset introduces a new io throttle structure. This will be
s/patchset/patch
OK
used in both block and fsdev devices.
Signed-off-by: Pradeep Jagadeesh
On 5/3/2017 12:13 AM, Eric Blake wrote:
On 05/02/2017 09:29 AM, Pradeep Jagadeesh wrote:
This patchset enables qmp interfaces for the fsdev
devices. This provides two interfaces one
for querying info of all the fsdev devices. The second one
to set the IO limits for the required fsdev device
On 5/3/2017 7:21 PM, Greg Kurz wrote:
On Tue, 2 May 2017 17:15:02 -0500
Eric Blake wrote:
On 05/02/2017 09:29 AM, Pradeep Jagadeesh wrote:
This patchset factor out the duplicate qmp throttle interface code
that was present in both block and fsdev device files.
Instead of adding the
On 5/3/2017 6:32 PM, Eric Blake wrote:
On 05/03/2017 10:40 AM, Pradeep Jagadeesh wrote:
On 5/3/2017 12:13 AM, Eric Blake wrote:
On 05/02/2017 09:29 AM, Pradeep Jagadeesh wrote:
This patchset enables qmp interfaces for the fsdev
devices. This provides two interfaces one
for querying info of
and fsdev files.
Pradeep Jagadeesh (6):
throttle: factor out duplicate code
qmp: Create IOThrottle structure
throttle: move out function to reuse the code
hmp: create a throttle initialization function for code reusability
fsdev: hmp interface for throttling
fsdev: QMP interface for
This patch introduces hmp interfaces for the fsdev
devices.
Signed-off-by: Pradeep Jagadeesh
---
hmp-commands-info.hx | 18 +++
hmp-commands.hx | 19
hmp.c| 62
hmp.h| 4
This patch creates a throttle initialization function to maximize the
code reusability. The same code is also used by fsdev.
Acked-by: Dr. David Alan Gilbert
Signed-off-by: Pradeep Jagadeesh
---
hmp.c | 19 +--
1 file changed, 13 insertions(+), 6 deletions(-)
diff --git a
This patch move out the throttle code to util/throttle.c to maximize
the reusability of the code.The same code is also used by fsdev.
Signed-off-by: Pradeep Jagadeesh
---
blockdev.c | 53 +++-
include/qemu/throttle-options.h | 3 +++
util
This patch factor out the duplicate throttle code that was present in
block and fsdev devices.
Signed-off-by: Pradeep Jagadeesh
Reviewed-by: Alberto Garcia
---
blockdev.c | 44 +--
fsdev/qemu-fsdev-throttle.c | 44
This patch introduces qmp interfaces for the fsdev
devices. This provides two interfaces one
for querying info of all the fsdev devices. The second one
to set the IO limits for the required fsdev device.
Signed-off-by: Pradeep Jagadeesh
---
Makefile| 4 +++
fsdev/qemu-fsdev
This patch enables qmp interfaces for the fsdev
devices. This provides two interfaces one
for querying info of all the fsdev devices. The second one
to set the IO limits for the required fsdev device.
Signed-off-by: Pradeep Jagadeesh
Reviewed-by: Greg Kurz
Reviewed-by: Eric Blake
Reviewed-by
On 8/29/2017 4:36 PM, Alberto Garcia wrote:
On Tue 29 Aug 2017 04:23:01 PM CEST, Pradeep Jagadeesh wrote:
These patches provide the qmp interface, to query the io throttle
status of the all fsdev devices that are present in a vm.
also, it provides an interface to set the io throttle parameters
On 8/30/2017 2:07 PM, Alberto Garcia wrote:
On Tue 29 Aug 2017 04:23:01 PM CEST, Pradeep Jagadeesh wrote:
These patches provide the qmp interface, to query the io throttle
status of the all fsdev devices that are present in a vm.
I'm trying to read from an 9p share that has limits set
On 8/30/2017 4:54 PM, Alberto Garcia wrote:
On Wed 30 Aug 2017 02:10:53 PM CEST, Pradeep Jagadeesh wrote:
I'm trying to read from an 9p share that has limits set with hmp
fsdev_set_io_throttle and I'm having some problems.
Here's one simple way to reproduce it:
1) L
On 8/30/2017 5:10 PM, Alberto Garcia wrote:
On Wed 30 Aug 2017 05:07:29 PM CEST, Pradeep Jagadeesh wrote:
Thanks for the steps, I did reproduce the issue easily. Looking into
the code, may be we also need to try the same with the block devices.
I did some tests and it was working fine, so
On 8/31/2017 3:34 PM, Alberto Garcia wrote:
On Wed 30 Aug 2017 05:12:22 PM CEST, Pradeep Jagadeesh wrote:
On 8/30/2017 5:10 PM, Alberto Garcia wrote:
On Wed 30 Aug 2017 05:07:29 PM CEST, Pradeep Jagadeesh wrote:
Thanks for the steps, I did reproduce the issue easily. Looking into
the code
On 8/31/2017 3:34 PM, Alberto Garcia wrote:
On Wed 30 Aug 2017 05:12:22 PM CEST, Pradeep Jagadeesh wrote:
On 8/30/2017 5:10 PM, Alberto Garcia wrote:
On Wed 30 Aug 2017 05:07:29 PM CEST, Pradeep Jagadeesh wrote:
Thanks for the steps, I did reproduce the issue easily. Looking into
the code
On 8/30/2017 11:38 AM, Alberto Garcia wrote:
On Tue 29 Aug 2017 04:23:06 PM CEST, Pradeep Jagadeesh wrote:
+static void print_fsdev_throttle_config(Monitor *mon, IOThrottle *fscfg,
+ Error *err)
+{
+monitor_printf(mon, "%s",
This patch factor out the duplicate throttle code that was present in
block and fsdev devices.
Signed-off-by: Pradeep Jagadeesh
Reviewed-by: Alberto Garcia
---
blockdev.c | 44 +--
fsdev/qemu-fsdev-throttle.c | 44
This patch introduces hmp interfaces for the fsdev
devices.
Signed-off-by: Pradeep Jagadeesh
---
hmp-commands-info.hx | 18
hmp-commands.hx | 19 +
hmp.c| 60
hmp.h| 4
This patch introduces qmp interfaces for the fsdev
devices. This provides two interfaces one
for querying info of all the fsdev devices. The second one
to set the IO limits for the required fsdev device.
Signed-off-by: Pradeep Jagadeesh
---
Makefile| 4 ++
fsdev/qemu-fsdev
and fsdev files.
Pradeep Jagadeesh (6):
throttle: factor out duplicate code
qmp: Create IOThrottle structure
throttle: move out function to reuse the code
hmp: create a throttle initialization function for code reusability
fsdev: QMP interface for throttling
fsdev: hmp interface for
This patch enables qmp interfaces for the fsdev
devices. This provides two interfaces one
for querying info of all the fsdev devices. The second one
to set the IO limits for the required fsdev device.
Signed-off-by: Pradeep Jagadeesh
Reviewed-by: Greg Kurz
Reviewed-by: Eric Blake
Reviewed-by
This patch creates a throttle initialization function to maximize the
code reusability. The same code is also used by fsdev.
Acked-by: Dr. David Alan Gilbert
Signed-off-by: Pradeep Jagadeesh
---
hmp.c | 19 +--
1 file changed, 13 insertions(+), 6 deletions(-)
diff --git a
This patch move out the throttle code to util/throttle.c to maximize
the reusability of the code.The same code is also used by fsdev.
Signed-off-by: Pradeep Jagadeesh
Reviewed-by: Alberto Garcia
---
blockdev.c | 53 +++-
include/qemu
On 9/5/2017 9:53 AM, Alberto Garcia wrote:
On Mon 04 Sep 2017 06:07:47 PM CEST, Pradeep Jagadeesh wrote:
+void hmp_info_fsdev_iothrottle(Monitor *mon, const QDict *qdict)
+{
+Error *err = NULL;
+IOThrottleList *fsdev_list, *info;
+fsdev_list = qmp_query_fsdev_io_throttle(&
On 9/5/2017 11:07 AM, Alberto Garcia wrote:
On Tue 05 Sep 2017 10:28:02 AM CEST, Pradeep Jagadeesh wrote:
+void hmp_info_fsdev_iothrottle(Monitor *mon, const QDict *qdict)
+{
+Error *err = NULL;
+IOThrottleList *fsdev_list, *info;
+fsdev_list = qmp_query_fsdev_io_throttle(&
On 9/5/2017 11:34 AM, Alberto Garcia wrote:
On Tue 05 Sep 2017 11:13:09 AM CEST, Pradeep Jagadeesh wrote:
a) Declare an Error, pass it _and then handle it_ (if you don't
handle it, you're leaking it):
Here you have no other way to know if qmp_query_fsdev_io_throttle()
fails, so
On 9/5/2017 11:19 PM, Eric Blake wrote:
On 09/04/2017 11:07 AM, Pradeep Jagadeesh wrote:
These patches provide the qmp interface, to query the io throttle
status of the all fsdev devices that are present in a vm.
also, it provides an interface to set the io throttle parameters of a
fsdev to a
Signed-off-by: Pradeep Jagadeesh
---
fsdev/Makefile.objs | 2 +-
fsdev/file-op-9p.h | 3 ++
fsdev/qemu-fsdev-opts.c | 77 -
fsdev/qemu-fsdev-throttle.c | 118
fsdev/qemu-fsdev-throttle.h | 39
Signed-off-by: Pradeep Jagadeesh
---
fsdev/Makefile.objs | 2 +-
fsdev/file-op-9p.h | 3 ++
fsdev/qemu-fsdev-opts.c | 77 -
fsdev/qemu-fsdev-throttle.c | 118
fsdev/qemu-fsdev-throttle.h | 39
On 10/13/2017 4:26 PM, Eric Blake wrote:
[adding Markus, and block list]
On 10/13/2017 09:16 AM, Alberto Garcia wrote:
On Mon 02 Oct 2017 04:33:28 PM CEST, Pradeep Jagadeesh wrote:
This patch factors out code to use the ThrottleLimits
structure.
{ 'struct': 'BlockIOThro
On 10/13/2017 4:29 PM, Alberto Garcia wrote:
On Mon 02 Oct 2017 04:33:29 PM CEST, Pradeep Jagadeesh wrote:
-if (arg->has_iops_rd_max_length) {
-cfg.buckets[THROTTLE_OPS_READ].burst_length = arg->iops_rd_max_length;
-}
-if (arg->has_iops_wr_max_length) {
-cf
On 11/2/2017 12:00 PM, Alberto Garcia wrote:
On Thu 02 Nov 2017 11:55:26 AM CET, Pradeep Jagadeesh wrote:
-if (arg->has_iops_rd_max_length) {
-cfg.buckets[THROTTLE_OPS_READ].burst_length = arg->iops_rd_max_length;
-}
-if (arg->has_iops_wr_max_length) {
-cf
On 11/6/2017 10:35 AM, Manos Pitsidianakis wrote:
On Fri, Oct 13, 2017 at 09:26:17AM -0500, Eric Blake wrote:
[adding Markus, and block list]
On 10/13/2017 09:16 AM, Alberto Garcia wrote:
On Mon 02 Oct 2017 04:33:28 PM CEST, Pradeep Jagadeesh wrote:
This patch factors out code to use the
On 10/13/2017 4:26 PM, Eric Blake wrote:
[adding Markus, and block list]
On 10/13/2017 09:16 AM, Alberto Garcia wrote:
On Mon 02 Oct 2017 04:33:28 PM CEST, Pradeep Jagadeesh wrote:
This patch factors out code to use the ThrottleLimits
structure.
{ 'struct': 'BlockIOThro
201 - 258 of 258 matches
Mail list logo
