r-humanmonitor1-2008-193209-fc6O',server,nowait -serial
unix:'/tmp/serial-2008-193209-fc6O',server,nowait -drive
file='/home/pradeep/autotest/client/tests/kvm/images/rhel6.1-64.qed',index=0,if=virtio,cache=none
-device virtio-net-pci,netdev=idQhUaOc,mac='9a:
09-fc6O',server,nowait -serial
unix:'/tmp/serial-2008-193209-fc6O',server,nowait -drive
file='/home/pradeep/autotest/client/tests/kvm/images/rhel6.1-64.qed',index=0,if=virtio,cache=none
-device virtio-net-pci,netdev=idQhUaOc,mac='9a:b7:ea:c9:0e:0d',id='i
** Changed in: qemu
Assignee: (unassigned) => pradeep (psuriset)
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/888016
Title:
RHEL 6.1 guest fails to boot with vhost
Status in QEMU:
, which i dont want to.
Is there a way to check, if device is already enrolled or not in the very
beginning of "device_add"
call.
Thanks
Pradeep
Migration of guest(both local and remote) fails with 2.6.37-rc8 host
Test Procedure:
---
A is the source host, B is the destination host:
1. Start the VM on B with the exact same parameters as the VM on A, in
migration-listen mode:
B: -incoming tcp:0: (or other PORT))
2. S
> Note: it might be a good idea to make peer link status match
> tap in this case, so the guest gets an event
> and updates the carrier state. For now
> stay bug for bug compatible with what we used to have.
>
> Signed-off-by: Michael S. Tsirkin
> Reported-by: pradeep
>
On Tue, 8 Feb 2011 17:41:12 +0200
"Michael S. Tsirkin" wrote:
> On Tue, Feb 08, 2011 at 05:40:58PM +0530, pradeep wrote:
> > On Mon, 7 Feb 2011 15:50:01 +0200
> > "Michael S. Tsirkin" wrote:
> >
> > > qemu makes it possible to disable link a
Uses throttling APIs to limit I/O bandwidth and number of operations on the
devices which use 9p-local driver.
Signed-off-by: Pradeep
fsdev/file-op-9p.h | 3 +
fsdev/qemu-fsdev-opts.c | 52 +
hw/9pfs/9p-local.c | 18 -
hw/9pfs/9p-throttle.c | 199
e1000) speed,I did
not find any ways to do that.
If I devide the packet into smaller packets in qemu_deliver_packet()
function
I am not able to transfer the other half of the packet.
Please let me know how can I resolve this.
Thanks in advance
Pradeep
Hi All,
I am new to qemu-kvm.But have good knowledge about virtulization and cloud
computing.I would like to do some projects in qemu-kvm.Please let me know
how can I start.
Please suggest me some small projects which I can take up and finish in 2-3
weeks.
Regards,
Pradeep
Hi Stefan,
Thanks I will follow your suggestion.
Regards,
Pradeep
On 24 April 2014 14:10, Stefan Hajnoczi wrote:
> On Wed, Apr 09, 2014 at 07:28:15PM +0200, Pradeep Kiruvale wrote:
> > I am new to qemu-kvm.But have good knowledge about virtulization and
> cloud
> > comp
/qemu-ifdown \
-drive file=ubuntu_15.qcow,id=disk,if=none \
-device ide-hd,drive=disk -serial stdio -serial vc \
-device intel-hda,addr=1b.0 -device hda-duplex
Please let me know am I missing something here? how can I resolve this.
Thanks & Regards,
Pradeep
Hi All,
Is virtio-9p-pci device only supports the fsdev deices? I am trying to use
-drive option for applying QoS for block device using Virtio-9p-pci device,
but failing to create/add a device other than fsdev. Can you please help me
on this?
Regards,
Pradeep
.
Regards,
Pradeep
On 30 March 2016 at 16:13, Greg Kurz wrote:
> On Wed, 30 Mar 2016 14:10:38 +0200
> Pradeep Kiruvale wrote:
>
> > Hi All,
> >
> > Is virtio-9p-pci device only supports the fsdev deices? I am trying to
> use
> > -drive option for applying QoS
cation,
> you may try to use KSM (Kernel Same-page Merging) in the host.
>
> We are using these things also, we want to reduce the foot print as much
as possible.
Regards,
Pradeep
> > Regards,
> > Pradeep
> >
> > On 31 March 2016 at 18:12, Greg Kurz wrote:
> >
&
command inside guest it creates
multiple threads to write/read. I can see those on host using iotop is this
expected behavior?
Regards,
Pradeep
n I add the PIDs to the
tasks file the cgroup still does not do IO control.
Is it possible to reduce these number of threads? I see different number of
threads doing IO at different runs.
Regards,
Pradeep
On 8 April 2016 at 10:10, Greg Kurz wrote:
> On Thu, 7 Apr 2016 11:48:27 +0200
nor
> the
> throttle setttings.
>
*I started the qemu with cgroup as below*
*cgexec -g blkio:/test qemu...*
*Is there any other way of starting the qemu in cgroup?*
Regards,
Pradeep
>
> > Regards,
> > Pradeep
> >
>
> Cheers.
>
> --
> Greg
>
&g
Hi Greg,
Yes, it was nothing to do with the virtio-9p. I was writing at 4k Blocks
now I changed it to 1K Block. This works fine for me.
Thanks for your help.
Regards,
Pradeep
On 8 April 2016 at 16:58, Greg Kurz wrote:
> On Fri, 8 Apr 2016 14:55:29 +0200
> Pradeep Kiruvale wrote:
&g
suggestions/opinions are very much helpful.
Regards,
Pradeep
Hi Stefan,
Thanks for the reply and adding Alberto.
I am going through those APIs already.
Thanks & Regards,
Pradeep
On 26 April 2016 at 11:21, Stefan Hajnoczi wrote:
> On Tue, Apr 19, 2016 at 02:09:24PM +0200, Pradeep Kiruvale wrote:
> > We are planning to implement the io-l
On 26 April 2016 at 14:08, Alberto Garcia wrote:
> On Tue 19 Apr 2016 02:09:24 PM CEST, Pradeep Kiruvale wrote:
>
> > We are planning to implement the io-limits for the virtio-9p driver
> > i.e for fsdev devices.
> > So, I am looking into the code base and how it has d
On 27 April 2016 at 10:38, Alberto Garcia wrote:
> On Wed, Apr 27, 2016 at 09:29:02AM +0200, Pradeep Kiruvale wrote:
>
> > Thanks for the reply. I am still in the early phase, I will let you
> > know if any changes are needed for the APIs.
> >
> > We might also have
On 27 April 2016 at 19:12, Greg Kurz wrote:
> On Wed, 27 Apr 2016 16:39:58 +0200
> Pradeep Kiruvale wrote:
>
> > On 27 April 2016 at 10:38, Alberto Garcia wrote:
> >
> > > On Wed, Apr 27, 2016 at 09:29:02AM +0200, Pradeep Kiruvale wrote:
> > >
> >
On 2 May 2016 at 14:57, Greg Kurz wrote:
> On Thu, 28 Apr 2016 11:45:41 +0200
> Pradeep Kiruvale wrote:
>
> > On 27 April 2016 at 19:12, Greg Kurz wrote:
> >
> > > On Wed, 27 Apr 2016 16:39:58 +0200
> > > Pradeep Kiruvale wrote:
> > >
> >
On 4 May 2016 at 17:40, Greg Kurz wrote:
> On Mon, 2 May 2016 17:49:26 +0200
> Pradeep Kiruvale wrote:
>
> > On 2 May 2016 at 14:57, Greg Kurz wrote:
> >
> > > On Thu, 28 Apr 2016 11:45:41 +0200
> > > Pradeep Kiruvale wrote:
> > >
>
On 6 May 2016 at 09:02, Greg Kurz wrote:
> On Fri, 6 May 2016 08:01:09 +0200
> Pradeep Kiruvale wrote:
>
> > On 4 May 2016 at 17:40, Greg Kurz wrote:
> >
> > > On Mon, 2 May 2016 17:49:26 +0200
> > > Pradeep Kiruvale wrote:
> > >
Thanks Alberto.
Regards,
Pradeep
On 6 May 2016 at 14:16, Alberto Garcia wrote:
> On Fri 06 May 2016 09:39:13 AM CEST, Pradeep Kiruvale wrote:
>
> >> The throttling API is currently only used by block devices, and the
> >> only documentation out-there is the code its
understand.
Regards,
Pradeep
On 7 June 2016 at 15:48, Greg Kurz wrote:
> On Tue, 7 Jun 2016 10:20:51 +0200
> Pradeep Kiruvale wrote:
> > Hi All,
> >
> > I am trying to add the throttle to the virtio-9p devices using the
> throttle
> > APIs that are already exists in the qemu.
> >
&
On 10/24/2016 3:00 PM, Alberto Garcia wrote:
On Sat 22 Oct 2016 05:07:22 PM CEST, Pradeep Jagadeesh wrote:
This adds the support for the 9p-local driver. For now this
functionality can be enabled only through qemu cli options. QMP
interface and support to other drivers need further
On 10/24/2016 11:28 PM, Greg Kurz wrote:
Re-post (I had hit the send button by error :)
On Sat, 22 Oct 2016 11:07:22 -0400
Pradeep Jagadeesh wrote:
Signed-off-by: Pradeep Jagadeesh
---
Hi Pradeep,
I see that Berto already did a thorough review for this patch and I agree for
all the
+}
If you create fsdev_throttle_parse_opts() as I suggest, I'd rather print
the error message here as the other error messages in this function.
I re-wrote as suggested by you.
I think I haven't forgotten anything, everything else looks fine. I'd
still like to have all the throtting parameters merged so we don't need
to duplicate them, but that can be done in the future (I can even take
care of it if I find a bit of time).
Thanks for the patch!
-Pradeep
Berto
.help = "length of the bps-write-max burst period, in
seconds",
+},{
+.name = "throttling.iops-size",
+ .type = QEMU_OPT_NUMBER,
+.help = "when limiting by iops max size of an I/O in
bytes",
},
{ /*End of
On 10/30/2016 2:35 PM, Greg Kurz wrote:
On Sun, 30 Oct 2016 14:04:49 +0100
Pradeep Jagadeesh wrote:
More remarks below.
fsdev/Makefile.objs | 1 +
fsdev/file-op-9p.h | 3 +
fsdev/qemu-fsdev-opts.c | 76 +++
fsdev/qemu-fsdev-throttle.c | 147
be enabled only through qemu cli options.
QMP interface and support to other drivers need further extensions.
To make it simple for other drivers, the throttle code has been put in
separate files.
Signed-off-by: Pradeep Jagadeesh
---
fsdev/Makefile.objs | 2 +-
fsdev/file-op-9p.h
Hi All,
I am planning to implement throttling functionality for virtio-net driver
using the throttling APIs that exist inside qemu.
Please let me know if someone already working on the same. Asking because I
do not want to just replicate the work.
Thanks & Regards,
Pradeep
Hi Alberto,
Thanks for your reply.
>
> > I am planning to implement throttling functionality for virtio-net
> > driver using the throttling APIs that exist inside qemu.
>
> Hi Pradeep,
>
> the problem with implementing throttling for the network is that
> it'
Uses throttling APIs to limit I/O bandwidth and number of operations on the
devices which use 9p-local driver.
Signed-off-by: Pradeep Jagadeesh
---
fsdev/file-op-9p.h | 3 +
fsdev/qemu-fsdev-opts.c | 52 +
hw/9pfs/9p-local.c | 18 -
hw/9pfs/9p-throttle.c | 201
t; without duplicating the command line options.
> > >
> > > Signed-off-by: Greg Kurz
> >
> > Did you check if it's possible / easy to do defining a normal array
> > instead of a macro and using qemu_opts_append() or something similar?
> >
> > Ber
On 23 November 2016 at 13:13, Greg Kurz wrote:
> On Tue, 22 Nov 2016 16:02:12 +0100
> Pradeep Kiruvale wrote:
>
> > On 22 November 2016 at 14:55, Greg Kurz wrote:
> >
> > > On Tue, 22 Nov 2016 14:51:12 +0100
> > > Alberto Garcia wrote:
> > >
Hi Greg,
Thanks for looking into the patch. Please look at the replies inline.
Regards,
Pradeep
-Original Message-
From: Greg Kurz [mailto:gr...@kaod.org]
Sent: Friday, September 09, 2016 5:29 PM
To: Pradeep Jagadeesh
Cc: Aneesh Kumar K.V; Pradeep Jagadeesh; Alberto Garcia; qemu-devel
Replies inline Greg.
Thanks & Regards,
Pradeep
-Original Message-
From: Greg Kurz [mailto:gr...@kaod.org]
Sent: Monday, September 12, 2016 4:19 PM
To: Pradeep Jagadeesh
Cc: Pradeep Jagadeesh; Aneesh Kumar K.V; Alberto Garcia; qemu-devel@nongnu.org;
Claudio Fontana; Eric Blake
Sub
Hi Greg,
Replies inline
Cheers,
Pradeep
-Original Message-
From: Greg Kurz [mailto:gr...@kaod.org]
Sent: Tuesday, September 13, 2016 10:52 AM
To: Pradeep Jagadeesh
Cc: Pradeep Jagadeesh; Aneesh Kumar K.V; Alberto Garcia; qemu-devel@nongnu.org;
Claudio Fontana; Eric Blake
Subject: Re
-Original Message-
From: Greg Kurz [mailto:gr...@kaod.org]
Sent: Tuesday, September 13, 2016 2:30 PM
To: Pradeep Jagadeesh
Cc: Pradeep Jagadeesh; Aneesh Kumar K.V; Alberto Garcia; qemu-devel@nongnu.org;
Claudio Fontana; Eric Blake
Subject: Re: [PATCH v2] 9pfs: add support for IO limits
Uses throttling APIs to limit I/O bandwidth and number of operations on the
fsdev devices.
Signed-off-by: Pradeep Jagadeesh
---
fsdev/Makefile.objs | 1 +
fsdev/file-op-9p.h | 3 +
fsdev/qemu-fsdev-opts.c | 76 ++
fsdev/qemu-fsdev-throttle.c | 191
Hi Alberto,
Thanks for having look at the patch.
My replies are inline.
On Fri 16 Sep 2016 10:33:36 AM CEST, Pradeep Jagadeesh wrote:
Hi,
first of all, sorry for the late reply! Here are my comments:
No problem!
--- a/fsdev/qemu-fsdev-opts.c
+++ b/fsdev/qemu-fsdev-opts.c
@@ -37,6 +37,82
Hi Greg,
Thanks for having a look at patchset.
See the replies below.
On Fri, 16 Sep 2016 04:33:36 -0400
Pradeep Jagadeesh wrote:
Uses throttling APIs to limit I/O bandwidth and number of operations on the
fsdev devices.
Signed-off-by: Pradeep Jagadeesh
---
Hi Pradeep,
Please find some
Hi Greg,
Sorry for the late reply, was out of office.
I agree with all comments and fix them all.
Also will send the patch soon.
-Pradeep
Hi Pradeep,
There are still a couple of issues to address with this v8, even if we're not
that far from the final version.
On Sun, 30 Oct 2016 11:
Uses throttling APIs to limit I/O bandwidth and number of operations on the
devices which use 9p-local driver.
Signed-off-by: Pradeep Jagadeesh
---
fsdev/Makefile.objs | 2 +-
fsdev/file-op-9p.h | 3 ++
fsdev/qemu-fsdev-opts.c | 77 +++-
fsdev
On Mon 07 Nov 2016 04:45:55 PM CET, Pradeep Jagadeesh wrote:
--- a/fsdev/qemu-fsdev-opts.c
+++ b/fsdev/qemu-fsdev-opts.c
@@ -37,8 +37,83 @@ static QemuOptsList qemu_fsdev_opts = {
}, {
.name = "sock_fd",
.type = QEMU_
Uses throttling APIs to limit I/O bandwidth and number of operations on the
devices which use 9p-local driver.
Signed-off-by: Pradeep Jagadeesh
---
fsdev/Makefile.objs | 2 +-
fsdev/file-op-9p.h | 3 ++
fsdev/qemu-fsdev-opts.c | 77 -
fsdev
On 11/9/2016 11:23 AM, Alberto Garcia wrote:
On Wed 09 Nov 2016 10:50:40 AM CET, Pradeep Jagadeesh wrote:
Uses throttling APIs to limit I/O bandwidth and number of operations
on the devices which use 9p-local driver.
Signed-off-by: Pradeep Jagadeesh
It looks good now, thanks!
+void
Uses throttling APIs to limit I/O bandwidth and number of operations on the
devices which use 9p-local driver.
Signed-off-by: Pradeep Jagadeesh
Reviewed-by: Alberto Garcia"
---
fsdev/Makefile.objs | 2 +-
fsdev/file-op-9p.h | 3 ++
fsdev/qemu-fsdev-opts.c
On 11/12/2016 3:13 PM, Greg Kurz wrote:
On Fri, 11 Nov 2016 03:54:27 -0500
Pradeep Jagadeesh wrote:
Uses throttling APIs to limit I/O bandwidth and number of operations on the
devices which use 9p-local driver.
Signed-off-by: Pradeep Jagadeesh
Reviewed-by: Alberto Garcia"
---
Hi Pr
On 11/14/2016 6:57 PM, Greg Kurz wrote:
On Mon, 14 Nov 2016 10:03:40 +0100
Pradeep Jagadeesh wrote:
On 11/12/2016 3:13 PM, Greg Kurz wrote:
On Fri, 11 Nov 2016 03:54:27 -0500
Pradeep Jagadeesh wrote:
Uses throttling APIs to limit I/O bandwidth and number of operations on the
devices which
On 11/15/2016 10:58 AM, Greg Kurz wrote:
On Tue, 15 Nov 2016 10:13:59 +0100
Pradeep Jagadeesh wrote:
On 11/14/2016 6:57 PM, Greg Kurz wrote:
On Mon, 14 Nov 2016 10:03:40 +0100
Pradeep Jagadeesh wrote:
On 11/12/2016 3:13 PM, Greg Kurz wrote:
On Fri, 11 Nov 2016 03:54:27 -0500
Pradeep
Hi Greg,
On 10/7/2016 9:48 AM, Greg Kurz wrote:
On Thu, 22 Sep 2016 07:59:19 -0400
Pradeep Jagadeesh wrote:
Uses throttling APIs to limit I/O bandwidth and number of operations on the
devices which use 9p-local driver.
Signed-off-by: Pradeep Jagadeesh
---
Hi Pradeep,
So where are we
Hi Stefan,
Thanks for the reply.
On 30 September 2016 at 15:49, Stefan Hajnoczi wrote:
> On Thu, Sep 29, 2016 at 04:11:27PM +0200, Pradeep Kiruvale wrote:
> > Hi Stefan,
> >
> > On 28 September 2016 at 10:29, Stefan Hajnoczi
> wrote:
> >
> > > On Mon, Se
On 10 October 2016 at 11:26, Pradeep Kiruvale
wrote:
> Hi Stefan,
>
> Thanks for the reply.
>
> On 30 September 2016 at 15:49, Stefan Hajnoczi wrote:
>
>> On Thu, Sep 29, 2016 at 04:11:27PM +0200, Pradeep Kiruvale wrote:
>> > Hi Stefan,
>> >
>>
On 14 October 2016 at 15:26, Stefan Hajnoczi wrote:
> On Mon, Oct 10, 2016 at 03:00:20PM +0200, Pradeep Kiruvale wrote:
> > On 10 October 2016 at 11:26, Pradeep Kiruvale >
> > wrote:
> >
> > > Hi Stefan,
> > >
> > > Thanks for the reply
Hi Alberto,
On Fri 16 Sep 2016 10:33:36 AM CEST, Pradeep Jagadeesh wrote:
Hi,
first of all, sorry for the late reply! Here are my comments:
--- a/fsdev/qemu-fsdev-opts.c
+++ b/fsdev/qemu-fsdev-opts.c
@@ -37,6 +37,82 @@ static QemuOptsList qemu_fsdev_opts = {
}, {
.name
On 10/18/2016 6:19 PM, Alberto Garcia wrote:
On Mon 17 Oct 2016 11:19:11 AM CEST, Pradeep Jagadeesh wrote:
+typedef struct FsThrottle {
+ThrottleState ts;
+ThrottleTimers tt;
+AioContext *aioctx;
+ThrottleConfig cfg;
+bool enabled;
+CoQueue throttled_reqs[2
On 10/18/2016 6:19 PM, Alberto Garcia wrote:
On Mon 17 Oct 2016 11:19:11 AM CEST, Pradeep Jagadeesh wrote:
+typedef struct FsThrottle {
+ThrottleState ts;
+ThrottleTimers tt;
+AioContext *aioctx;
+ThrottleConfig cfg;
+bool enabled;
+CoQueue throttled_reqs[2
On 10/20/2016 3:32 PM, Greg Kurz wrote:
On Thu, 20 Oct 2016 14:50:29 +0200
Alberto Garcia wrote:
On Wed 19 Oct 2016 06:29:45 PM CEST, Pradeep Jagadeesh wrote:
One more update is, I had a look at bdrv_io_limits_intercept and I
just removed lock and retained other two things
pending_reqs
On 10/20/2016 2:50 PM, Alberto Garcia wrote:
On Wed 19 Oct 2016 06:29:45 PM CEST, Pradeep Jagadeesh wrote:
One more update is, I had a look at bdrv_io_limits_intercept and I
just removed lock and retained other two things
pending_reqs,any_timer_armed It works fine.
So you managed to make it
Signed-off-by: Pradeep Jagadeesh
---
fsdev/Makefile.objs | 1 +
fsdev/file-op-9p.h | 3 +
fsdev/qemu-fsdev-opts.c | 76
fsdev/qemu-fsdev-throttle.c | 166
fsdev/qemu-fsdev-throttle.h | 37 ++
hw
On 10/7/2016 9:48 AM, Greg Kurz wrote:
On Thu, 22 Sep 2016 07:59:19 -0400
Pradeep Jagadeesh wrote:
Uses throttling APIs to limit I/O bandwidth and number of operations on the
devices which use 9p-local driver.
Signed-off-by: Pradeep Jagadeesh
---
Hi Pradeep,
So where are we with this
Alberto,
Thanks for reviewing the patch.
On Thu 20 Oct 2016 04:14:23 PM CEST, Pradeep Jagadeesh wrote:
+static void fsdev_throttle_schedule_next_request(FsThrottle *fst, bool
is_write)
+{
+bool must_wait;
+
+if (qemu_co_queue_empty(&fst->throttled_reqs[is_write])) {
+
Signed-off-by: Pradeep Jagadeesh
---
fsdev/Makefile.objs | 1 +
fsdev/file-op-9p.h | 3 +
fsdev/qemu-fsdev-opts.c | 76 +++
fsdev/qemu-fsdev-throttle.c | 147
fsdev/qemu-fsdev-throttle.h | 37
Signed-off-by: Pradeep Jagadeesh
---
fsdev/Makefile.objs | 1 +
fsdev/file-op-9p.h | 3 +
fsdev/qemu-fsdev-opts.c | 76 +++
fsdev/qemu-fsdev-throttle.c | 147
fsdev/qemu-fsdev-throttle.h | 37
On Fri 21 Oct 2016 06:21:59 PM CEST, Pradeep Jagadeesh
wrote:
+static bool fsdev_throttle_check_for_wait(FsThrottle *fst, bool is_write)
+{
+ return throttle_schedule_timer(&fst->ts, &fst->tt, is_write);
^
There's an extra whitespace there.
Remo
This patch factor out the duplicate throttle code that was present in
block and fsdev devices.
Signed-off-by: Pradeep Jagadeesh
---
blockdev.c | 44 +---
fsdev/qemu-fsdev-throttle.c | 43 +--
fsdev/qemu
This patch enables qmp interfaces for the fsdev
devices. This provides two interfaces one
for querying info of all the fsdev devices. The second one
to set the IO limits for the required fsdev device.
Signed-off-by: Pradeep Jagadeesh
Reviewed-by: Greg Kurz
Reviewed-by: Eric Blake
---
qapi
and fsdev files.
Pradeep Jagadeesh (5):
throttle: factor out duplicate code
qmp: Create IOThrottle structure
qmp: refactor duplicate code
fsdev: hmp interface for throttling
fsdev: QMP interface for throttling
Makefile| 3 +
blockdev.c
This patch enables qmp interfaces for the fsdev
devices. This provides two interfaces one
for querying info of all the fsdev devices. The second one
to set the IO limits for the required fsdev device.
Signed-off-by: Pradeep Jagadeesh
---
Makefile| 3 ++
fsdev/qemu-fsdev
This patch introduces hmp interfaces for the fsdev
throttle functionality
Signed-off-by: Pradeep Jagadeesh
---
hmp-commands-info.hx | 18 ++
hmp-commands.hx | 19 +++
hmp.c| 66
hmp.h
This patch factor out the duplicate qmp throttle interface code
that was present in both block and fsdev device files.
Signed-off-by: Pradeep Jagadeesh
---
blockdev.c | 53 +++-
hmp.c | 21 ++-
include
On 6/20/2017 6:05 PM, Greg Kurz wrote:
On Mon, 19 Jun 2017 09:11:34 -0400
Pradeep Jagadeesh wrote:
This patch factor out the duplicate qmp throttle interface code
that was present in both block and fsdev device files.
The text is obviously wrong. I don't see any duplicate code below
On 4/12/2017 5:01 PM, Alberto Garcia wrote:
On Thu 30 Mar 2017 02:10:10 PM CEST, Pradeep Jagadeesh wrote:
+##
+# == QAPI IOThrottle definitions
+##
+# @IOThrottle:
+#
+# A set of parameters describing block
+#
"describing block ..." ? There's missing text here.
Hmm..I will fix
On 6/8/2017 6:49 PM, Greg Kurz wrote:
On Thu, 18 May 2017 15:30:06 +0200
Pradeep Jagadeesh wrote:
On 5/17/2017 7:09 PM, Eric Blake wrote:
On 05/17/2017 11:29 AM, Greg Kurz wrote:
First point: is fsdev a Linux-only feature, or can it be compiled on
BSD? If it is Linux-only, then compiling
On 6/8/2017 4:20 PM, Greg Kurz wrote:
On Fri, 12 May 2017 10:03:02 +0200
Pradeep Jagadeesh wrote:
On 5/11/2017 9:50 AM, Greg Kurz wrote:
On Wed, 10 May 2017 04:41:22 -0400
Pradeep Jagadeesh wrote:
This patch factor out the duplicate qmp throttle interface code
that was present in both
sing "make docker" options?
Thanks
Pradeep
On 2/1/2017 3:44 PM, Alberto Garcia wrote:
On Tue 24 Jan 2017 10:24:06 AM CET, Pradeep Jagadeesh
wrote:
Pradeep Jagadeesh (2):
fsdev: add IO throttle support to fsdev devices
throttle: removed duplicate throtlle code from block and fsdev files
I cannot find the second patch in this
On 2/1/2017 4:08 PM, Alberto Garcia wrote:
Hello, and sorry for being late reviewing these patches :)
On Tue 24 Jan 2017 10:24:07 AM CET, Pradeep Jagadeesh
wrote:
This patchset adds the io throttle support for the 9p-local driver.
For now this functionality can be used only through qemu cli
support
-Throttling support for other fsdev/9p drivers.
Thanks,
Pradeep
Pradeep Jagadeesh (2):
fsdev: add IO throttle support to fsdev devices
throttle: removed duplicate throtlle code from block and fsdev files
blockdev.c | 81 ++-
fsdev
This patch removes the redundant throttle code that was present in
block and fsdev device files. Now the common code is moved
to a single file.
Signed-off-by: Pradeep Jagadeesh
https://lists.gnu.org/archive/html/qemu-devel/2017-01/msg04637.html
---
blockdev.c | 81
.
Signed-off-by: Pradeep Jagadeesh
---
fsdev/Makefile.objs | 2 +-
fsdev/file-op-9p.h | 3 ++
fsdev/qemu-fsdev-opts.c | 77 -
fsdev/qemu-fsdev-throttle.c | 118
fsdev/qemu-fsdev-throttle.h | 39
On 2/3/2017 11:10 AM, Alberto Garcia wrote:
On Fri 03 Feb 2017 11:04:57 AM CET, Pradeep Jagadeesh wrote:
This patchset adds the io throttle support for the 9p-local driver.
For now this functionality can be used only through qemu cli options.
QMP interface and support to other 9p drivers need
support
-Throttling support for other fsdev/9p drivers.
Thanks,
Pradeep
Pradeep Jagadeesh (2):
fsdev: add IO throttle support to fsdev devices
throttle: factor out duplicate code
blockdev.c | 81 ++-
fsdev/Makefile.objs | 2 +-
fsdev
This patch removes the redundant throttle code that was present in
block and fsdev device files. Now the common code is moved
to a single file.
Signed-off-by: Pradeep Jagadeesh
https://lists.gnu.org/archive/html/qemu-devel/2017-01/msg04637.html
---
blockdev.c | 81
.
Signed-off-by: Pradeep Jagadeesh
---
fsdev/Makefile.objs | 2 +-
fsdev/file-op-9p.h | 3 ++
fsdev/qemu-fsdev-opts.c | 77 -
fsdev/qemu-fsdev-throttle.c | 118
fsdev/qemu-fsdev-throttle.h | 39
On 2/3/2017 11:38 AM, Alberto Garcia wrote:
On Fri 03 Feb 2017 11:04:58 AM CET, Pradeep Jagadeesh wrote:
This patch removes the redundant throttle code that was present in
block and fsdev device files. Now the common code is moved to a single
file.
Here it says that this patch moves common
On 2/3/2017 1:22 PM, Alberto Garcia wrote:
On Fri 03 Feb 2017 12:57:23 PM CET, Pradeep Jagadeesh wrote:
This patch removes the redundant throttle code that was present in
block and fsdev device files. Now the common code is moved
to a single file.
Signed-off-by: Pradeep Jagadeesh
Reviewed
On 2/3/2017 1:44 PM, Alberto Garcia wrote:
On Fri 03 Feb 2017 01:27:25 PM CET, Pradeep Jagadeesh wrote:
Signed-off-by: Pradeep Jagadeesh
Reviewed-by: Alberto Garcia
https://lists.gnu.org/archive/html/qemu-devel/2017-01/msg04637.html
This line doesn't belong in the commit me
On 2/3/2017 1:53 PM, Alberto Garcia wrote:
On Fri 03 Feb 2017 01:46:31 PM CET, Pradeep Jagadeesh wrote:
The false positive is not related to what Greg said :-) What you have
to put is not that URL but the Reviewed-by: line with Stefan's name
and e-mail.
Haha OK. I will change it and sen
On 2/6/2017 3:58 PM, Greg Kurz wrote:
On Fri, 3 Feb 2017 06:57:23 -0500
Pradeep Jagadeesh wrote:
This patch removes the redundant throttle code that was present in
block and fsdev device files. Now the common code is moved
to a single file.
Signed-off-by: Pradeep Jagadeesh
https
On 2/6/2017 8:36 PM, Eric Blake wrote:
On 02/03/2017 05:57 AM, Pradeep Jagadeesh wrote:
This patchset adds the throttle support for the 9p-local driver.
For now this functionality can be enabled only through qemu cli options.
QMP interface and support to other drivers need further extensions
On 5/4/2017 5:19 PM, Eric Blake wrote:
On 05/04/2017 10:12 AM, Pradeep Jagadeesh wrote:
+IOThrottle throttle = {
+.has_id = true,
+.id = (char *) qdict_get_str(qdict, "id"),
+.bps = qdict_get_int(qdict, "bps"),
+.bps_rd = qdict_ge
This patch factor out the duplicate qmp throttle interface code
that was present in both block and fsdev device files.
Signed-off-by: Pradeep Jagadeesh
---
blockdev.c | 53 +++-
hmp.c | 21
1 - 100 of 258 matches
Mail list logo
