Hi Erlon,
Erlon Cruz writes:
> Hi Alex,
>
>
>> Could you please post
>>
>> * the exact command line you were using
>>
>
> ./ppc64-softmmu/qemu-system-ppc64 -machine type=pseries,usb=off -m 512
> -net nic,vlan=0 -net tap -nographic -cdrom
> /exports/isos/SLES-11-SP2-DVD-ppc64-GM-DVD1.iso -hda
On Thu, 27 Sep 2012 12:13:05 +0200, Gleb Natapov wrote:
> On Thu, Sep 27, 2012 at 03:35:53PM +0530, Nikunj A Dadhania wrote:
> >
> > If the user does not set bootindex, qemu would decide the bootindex?
> >
> No. Firmware decides. QEMU just tells to firmware that it d
On Thu, 27 Sep 2012 11:51:36 +0200, Gleb Natapov wrote:
> On Thu, Sep 27, 2012 at 11:33:31AM +0200, Alexander Graf wrote:
> >
> > On 27.09.2012, at 11:29, Benjamin Herrenschmidt wrote:
> >
> > > On Thu, 2012-09-27 at 14:51 +0530, Avik Sil wrote:
> > >> Hi,
> > >>
> > >> We would like to get a m
On Thu, 4 Oct 2012 14:37:22 +0200, Alexander Graf wrote:
>
> Imagine you have 2 controllers:
>
> * vio
> * virtio
>
> and you specify -boot c. Which device are you going to boot from?
> >>>
> >>> Currently, by default SLOF boots from the first disk it discover
On Fri, 5 Oct 2012 10:34:16 +1000, David Gibson wrote:
> On Thu, Oct 04, 2012 at 04:25:28PM +0530, Avik Sil wrote:
> > On 09/27/2012 03:21 PM, Gleb Natapov wrote:
> > >On Thu, Sep 27, 2012 at 11:33:31AM +0200, Alexander Graf wrote:
> > >>
> > >>On 27.09.2012, at 11:29, Benjamin Herrenschmidt wrote
On Fri, 05 Oct 2012 09:25:25 -0500, Anthony Liguori wrote:
> Alexander Graf writes:
>
> > On 05.10.2012, at 16:00, Avik Sil wrote:
> >
> >> On 10/05/2012 05:39 PM, Alexander Graf wrote:
> >>>
> >>> On 05.10.2012, at 13:41, Nikunj A Dadhan
, then the read
> done with the result (don't bound check and read again, that would be
> indeed racy).
How about the below patch:
From: Nikunj A Dadhania
This implements capabilities exchange between host and client.
As at the moment no capability is supported, put zero flags everyw
Benjamin Herrenschmidt writes:
> On Mon, 2013-08-26 at 10:02 +0530, Nikunj A Dadhania wrote:
>
>>
>> From: Nikunj A Dadhania
>>
>> This implements capabilities exchange between host and client.
>> As at the moment no capability is supported, put
Alexander Graf writes:
> Am 26.08.2013 um 08:22 schrieb Benjamin Herrenschmidt
> :
>
>> On Mon, 2013-08-26 at 06:44 +0100, Alexander Graf wrote:
+cap.flags = 0;
+cap.migration.ecl = 0;
+cap.reserve.type = 0;
+cap.migration.common.server_support = 0;
+
Alexander Graf writes:
> Am 26.08.2013 um 05:32 schrieb Nikunj A Dadhania :
>
>> Benjamin Herrenschmidt writes:
>> From: Nikunj A Dadhania
>>
>> This implements capabilities exchange between host and client.
>
> Client?
vscsi host implemented by VIOS and v
Alexander Graf writes:
> Am 26.08.2013 um 05:32 schrieb Nikunj A Dadhania :
>
>> Benjamin Herrenschmidt writes:
>>
>>> On Sun, 2013-08-25 at 17:41 +0100, Alexander Graf wrote:
>>>>> +vcap = &req->iu.mad.capabilities;
>>>>>
Alexander Graf writes:
> On 26.08.2013, at 12:58, Nikunj A Dadhania wrote:
>
>> This implements capabilities exchange between host and client.
>> As at the moment no capability is supported, put zero flags everywhere
>> and return.
>>
>> Signed-off-by:
Paolo Bonzini writes:
> Il 26/08/2013 11:06, Nikunj A Dadhania ha scritto:
>>>> +fprintf(stderr, "vscsi_send_capabilities: size out of bound !\n");
>>>> +goto error_out;
>>>> +}
>>>
>>> I am not 100% familiar
Alexander Graf writes:
+rc = spapr_vio_dma_read(&s->vdev, buffer, &cap, len);
+if (rc) {
+fprintf(stderr, "vscsi_send_capabilities: DMA read failure !\n");
>>>
>>> At this point cap contains random host data, no?
>>
>> Yes, and we zero it out in this case.
>
> The
Alexander Graf writes:
> On 26.08.2013, at 13:46, Nikunj A Dadhania wrote:
>
>> Alexander Graf writes:
>>
>>> On 26.08.2013, at 12:58, Nikunj A Dadhania wrote:
>>>
>>>> This implements capabilities exchange between host and client.
>>&g
Alexander Graf writes:
>> +static int vscsi_send_capabilities(VSCSIState *s, vscsi_req *req)
>> +{
>> +struct viosrp_capabilities *vcap;
>> +struct capabilities cap = { };
>> +uint16_t len, req_len;
>> +uint64_t buffer;
>> +int rc;
>> +
>> +vcap = &req->iu.mad.capabilities;
This implements capabilities exchange between vscsi host and client. As
at the moment no capability is supported, put zero flags everywhere and
return.
Signed-off-by: Nikunj A Dadhania
---
hw/scsi/spapr_vscsi.c | 54 +++
1 file changed, 54
Hi Alex/Peter,
The below patch is already been picked in master and ppc-next and has
broken pseries booting from virtio-blk device
Greg Kurz writes:
> On Tue, 23 Sep 2014 07:26:32 +0300
> "Michael S. Tsirkin" wrote:
>
>> >
>> > This commit prevents pseries to boot. SLOF complains with the fol
Greg Kurz writes:
> On Mon, 29 Sep 2014 19:15:05 +0300
> "Michael S. Tsirkin" wrote:
>
> It may be possible to change the way SLOF configures the virtq so
> that it wouldn't suffer from the device being reset. We have some
> time left before 2.2. I have a tentative patch for SLOF that I'll
> be g
From: Avik Sil
This is required to enable boot menu display during booting
Signed-off-by: Avik Sil
Signed-off-by: Nikunj A Dadhania
---
hw/ppc/spapr.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c
index ff37319..c6760a1 100644
--- a/hw/ppc/spapr.c
PAPR compliant guest calls this in absence of kdump. After
receiving this call qemu could trigger a guest dump. This guest dump
can be used to analyse using crash tool.
Signed-off-by: Nikunj A Dadhania
---
hw/ppc/spapr_rtas.c | 34 ++
1 file changed, 34
Useful for identifying the guest/host uniquely within the
guest. Adding following properties to the guest root node.
vm,uuid - uuid of the guest
host-model - Host model number
host-serial - Host machine serial number
hypervisor type - Tells its "kvm"
Signed-off-by: Nikunj A Dadhania
-
Alexey Kardashevskiy writes:
> On 06/10/2014 05:56 PM, Nikunj A Dadhania wrote:
>> Useful for identifying the guest/host uniquely within the
>> guest. Adding following properties to the guest root node.
>>
>> vm,uuid - uuid of the guest
>> host-model - Host m
Alexey Kardashevskiy writes:
> On 06/10/2014 05:56 PM, Nikunj A Dadhania wrote:
>> PAPR compliant guest calls this in absence of kdump. After
>> receiving this call qemu could trigger a guest dump. This guest dump
>> can be used to analyse using crash tool.
>>
Useful for identifying the guest/host uniquely within the
guest. Adding following properties to the guest root node.
vm,uuid - uuid of the guest
host-model - Host model number
host-serial - Host machine serial number
hypervisor type - Tells its "kvm"
Signed-off-by: Nikunj A Dadhani
PAPR compliant guest calls this in absence of kdump. After
receiving this call qemu could trigger a guest dump. This guest dump
can be used to analyse using crash tool.
Signed-off-by: Nikunj A Dadhania
---
v2: indentation fixes
hw/ppc/spapr_rtas.c | 32
1 file
Alexander Graf writes:
> On 12.06.14 14:09, Nikunj A Dadhania wrote:
>> PAPR compliant guest calls this in absence of kdump. After
>> receiving this call qemu could trigger a guest dump. This guest dump
>> can be used to analyse using crash tool.
>>
>>
Alexander Graf writes:
> On 17.06.14 11:30, Nikunj A Dadhania wrote:
>> Alexander Graf writes:
>>
>>> On 12.06.14 14:09, Nikunj A Dadhania wrote:
>>>> PAPR compliant guest calls this in absence of kdump. After
>>>> receiving this call qemu could t
Alexander Graf writes:
> On 17.06.14 11:59, Nikunj A Dadhania wrote:
>> Alexander Graf writes:
>>> On 17.06.14 11:30, Nikunj A Dadhania wrote:
>>>> Alexander Graf writes:
>>>>>> +spapr_rtas_register("ibm,os-term", rtas_ibm_os_te
Nikunj A Dadhania writes:
> Alexander Graf writes:
>
>> On 17.06.14 11:59, Nikunj A Dadhania wrote:
>>> Alexander Graf writes:
>>>> On 17.06.14 11:30, Nikunj A Dadhania wrote:
>>>>> Alexander Graf writes:
>
>>>&
Paolo Bonzini writes:
> Il 14/06/2013 12:32, Nikunj A Dadhania ha scritto:
>> Nikunj A Dadhania writes:
>>> commit 08521e28c7e6e8cc1f53424a0f845f58d2ed9546
>>> Author: Paolo Bonzini
>>> Date: Fri May 24 12:54:01 2013 +0200
>>&
Alexey Kardashevskiy writes:
> The PAPR+ specification defines a ibm,client-architecture-support (CAS)
> RTAS call which purpose is to provide a negotiation mechanism for
> the guest and the hypervisor to work out the best compatibility parameters.
> During the negotiation process, the guest prov
Nikunj A Dadhania writes:
> The PCI MMIO might be disabled or the device in the reset state.
> Make sure we do not dump these memory regions.
>
> Signed-off-by: Nikunj A Dadhania
> Acked-by: Alex Williamson
> CC: Paolo Bonzini
> ---
>
> Resending, missed to CC Paolo
Ping?
Regards
Nikunj
Greg Kurz writes:
> On Mon, 8 Sep 2014 19:05:02 +0300
> "Michael S. Tsirkin" wrote:
>
>> commit cc943c36faa192cd4b32af8fe5edb31894017d35
>> pci: Use bus master address space for delivering MSI/MSI-X messages
>> breaks virtio-net for rhel6.[56] x86 guests because they don't
>> enable bus mast
Greg Kurz writes:
>> > > I did some debugging: it looks like the guest kernel calls the OF
>> > > quisece call to flush pending DMA and disables bus master on the
>> > > virtio-blk device (PCI_COMMAND == 0x3).
>> >
>> > Getting confused, above you are talking about virtio-net and here it is
>> >
"Michael S. Tsirkin" writes:
> On Wed, Sep 10, 2014 at 01:44:49PM +0530, Nikunj A Dadhania wrote:
>> Greg Kurz writes:
>>
>> > On Mon, 8 Sep 2014 19:05:02 +0300
>> > "Michael S. Tsirkin" wrote:
>> >
>> >> commit cc94
The PCI MMIO might be disabled or the device in the reset state.
Make sure we do not dump these memory regions.
Signed-off-by: Nikunj A Dadhania
---
hw/misc/vfio.c| 2 +-
include/exec/memory.h | 27 +++
memory.c | 16
Alex Williamson writes:
> On Fri, 2014-09-12 at 10:12 +0530, Nikunj A Dadhania wrote:
>> The PCI MMIO might be disabled or the device in the reset state.
>> Make sure we do not dump these memory regions.
>>
>> Signed-off-by: Nikunj A Dadhania
>> ---
>
The PCI MMIO might be disabled or the device in the reset state.
Make sure we do not dump these memory regions.
Signed-off-by: Nikunj A Dadhania
---
V1:
* Make the flag generic in place of using vfio_mmap (Alex)
hw/misc/vfio.c| 1 +
include/exec/memory.h | 19
The PCI MMIO might be disabled or the device in the reset state.
Make sure we do not dump these memory regions.
Signed-off-by: Nikunj A Dadhania
Acked-by: Alex Williamson
CC: Paolo Bonzini
---
Resending, missed to CC Paolo
V1:
* Make the flag generic in place of using vfio_mmap (Alex
his breaks libvirt which uses -nodefaults and adds
the keyboard and mouse separately. The machine got 2 USB Keyboards
and 2 USB Mouses.
CC: Paolo Bonzini
CC: Mark Wu
CC: Andreas Färber
Signed-off-by: Nikunj A Dadhania
---
Removed the debug statement and fixed indentation breakage:
hw/p
Andreas Färber writes:
> Am 03.04.2014 18:56, schrieb Nikunj A Dadhania:
>> The following commit caused the regression in qemu-system-ppc64
>>
>> 7effdaa3: spapr: Fix return value of vga initialization
>> d44229c5: Fix vga_interface_type for command line argument &#x
his breaks libvirt which uses -nodefaults and adds
the keyboard and mouse separately. The machine got 2 USB Keyboards
and 2 USB Mouses.
CC: Paolo Bonzini
CC: Mark Wu
CC: Andreas Färber
Signed-off-by: Nikunj A Dadhania
---
hw/ppc/spapr.c | 6 +-
include/sysemu/sysemu.h |
Paolo Bonzini writes:
> Il 03/04/2014 18:56, Nikunj A Dadhania ha scritto:
>> The following commit caused the regression in qemu-system-ppc64
>>
>> 7effdaa3: spapr: Fix return value of vga initialization
>> d44229c5: Fix vga_interface_type for command line argument &#
Paolo Bonzini writes:
> Il 03/04/2014 21:24, Nikunj A Dadhania ha scritto:
>>> > Does libvirt use "-nodefaults -machine usb=true"? It should create the
>>> > OHCI controller separately instead of using "-machine".
>> I see it creating:
>
Markus Armbruster writes:
> Nikunj A Dadhania writes:
>
> Have you considered extending QEMUMachineInitArgs instead of adding this
> function?
Did not think of this option earlier. You mean doing something like
this?
diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c
index 3a13231..93
Paolo Bonzini writes:
> Il 04/04/2014 07:28, Nikunj A Dadhania ha scritto:
>>>> >>
>>>> >> And -usb is translated to adding "pci-ohci" controller for spapr
>>> >
>>> > Yeah, but with -nodefaults it's better to use -dev
"Richard W.M. Jones" writes:
> However attached are:
>
> - the libvirt XML
> - the qemu command line
>
> which may help to reproduce the bug. I'm using upstream qemu + 91
> patches provided by Tom, as detailed earlier in this thread.
I have verified this, resolved in current SLOF tree, Alexey
Hi Peter,
Peter Maydell writes:
>>
>> That'd be awesome! FWIW "upstream" SLOF is at the following git URL:
>>
>> git://github.com/aik/SLOF.git
>
> That would result in the following updates to our mirror:
>
> - [deleted] benh
> - [deleted] debug_mem_alloc
This is fine, there
Nikunj A Dadhania writes:
> Hi Peter,
>
> Peter Maydell writes:
>>>
>>> That'd be awesome! FWIW "upstream" SLOF is at the following git URL:
>>>
>>> git://github.com/aik/SLOF.git
>>
>> That would result in the followi
Alexey Kardashevskiy writes:
>
> "channel@0" -> ""? This is a generic scsi bus, cannot change this.
> "disk@3,2" -> "disk@8302"? This is a generic scsi-cd, cannot
> change this either
>
>
>> On top of this, fix the remaining QEMU->OF differences using a callback
>> in QEMUMachine. Th
Stefan Hajnoczi writes:
> On Fri, Mar 07, 2014 at 12:34:28PM +1100, Alexey Kardashevskiy wrote:
>> On 02/21/2014 07:24 PM, Alexander Graf wrote:
>> >
>> > On 21.02.2014, at 07:09, Alexey Kardashevskiy wrote:
>> >
>> >> On 02/10/2014 05:52 PM, Alexey Kardashevskiy wrote:
>> >> Ping?
>> >
>> >
Alexander Graf writes:
> On 23.01.15 23:51, dval...@suse.de wrote:
>> From: Dinar Valeev
>>
>> In order to use -boot once=X option we need to have default list
>> where restore to on reset.
>>
>> Signed-off-by: Dinar Valeev
>
> Alexey, Nijunj, where is the default boot order stored usually?
MIO.
>
> To fix this, an in-kernel implementation of these hypercalls has been made,
> however, the hypercalls still need to be enabled from qemu. This performs
> the necessary calls to do so.
>
> Signed-off-by: David Gibson
Reviewed-by: Nikunj A Dadhania
Nikunj A Dadhania writes:
> Current DEFAULT_RAM_SIZE(128MB) enforced by QEMU would not work for
> all machines. Introduce a default_ram_size as part of MachineClass.
>
> The below patches has following behaviour:
>
> 1) If the user does not provide "-m" option, mac
capabilities.
CC: Alex Williamson
CC: Alexander Graf
Signed-off-by: Nikunj A Dadhania
---
hw/vfio/pci.c| 2 ++
include/hw/pci/pci.h | 2 ++
2 files changed, 4 insertions(+)
diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c
index 6b80539..95d666e 100644
--- a/hw/vfio/pci.c
+++ b/hw/vfio/pci.c
@@ -3
devices need to identify with its own ibm,loc-code
available on the host.
2) Emulated devices encode as following: qemu_:.
Signed-off-by: Nikunj A Dadhania
---
hw/ppc/spapr_hcall.c | 10 +
hw/ppc/spapr_pci.c| 49 +++
hw/vfio
Alexey Kardashevskiy writes:
> On 03/26/2015 05:42 PM, Nikunj A Dadhania wrote:
>> Each hardware instance has a platform unique location code. The OF
>> device tree that describes a part of a hardware entity must include
>> the “ibm,loc-code” property with a value that re
David Gibson writes:
> On Thu, Mar 26, 2015 at 12:12:12PM +0530, Nikunj A Dadhania wrote:
>> Each hardware instance has a platform unique location code. The OF
>> device tree that describes a part of a hardware entity must include
>> the “ibm,loc-code” property with a valu
Alexey Kardashevskiy writes:
>> diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c
>> index 95d666e..dd97258 100644
>> --- a/hw/vfio/pci.c
>> +++ b/hw/vfio/pci.c
>> @@ -3319,6 +3319,24 @@ static void
>> vfio_unregister_req_notifier(VFIOPCIDevice *vdev)
>> vdev->req_enabled = false;
>> }
>>
>> +b
David Gibson writes:
> On Fri, Mar 27, 2015 at 10:04:27AM +0530, Nikunj A Dadhania wrote:
>> David Gibson writes:
>>
>> > On Thu, Mar 26, 2015 at 12:12:12PM +0530, Nikunj A Dadhania wrote:
>> >> Each hardware instance has a platform unique location
devices need to identify with its own ibm,loc-code
available on the host.
2) Emulated devices encode as following: qemu_:.
Signed-off-by: Nikunj A Dadhania
---
Changelog
v1:
* Dropped is_vfio patch and using TYPE_SPAPR_PCI_VFIO_HOST_BRIDGE
to recognise vfio devices
* Removed wrapper for
Alexey Kardashevskiy writes:
> On 03/27/2015 08:49 PM, Nikunj A Dadhania wrote:
>> Each hardware instance has a platform unique location code. The OF
>> device tree that describes a part of a hardware entity must include
>> the “ibm,loc-code” property with a value that re
David Gibson writes:
> On Mon, Mar 30, 2015 at 01:18:01PM +1100, Alexey Kardashevskiy wrote:
>> On 03/27/2015 08:49 PM, Nikunj A Dadhania wrote:
>> >Each hardware instance has a platform unique location code. The OF
>> >device tree that describes a part of a hardware
Nikunj A Dadhania writes:
> David Gibson writes:
>
>> On Mon, Mar 30, 2015 at 01:18:01PM +1100, Alexey Kardashevskiy wrote:
>>> On 03/27/2015 08:49 PM, Nikunj A Dadhania wrote:
>>> >Each hardware instance has a platform unique location code. The OF
>>&g
Alexey Kardashevskiy writes:
> On 03/30/2015 04:34 PM, Nikunj A Dadhania wrote:
>> Nikunj A Dadhania writes:
>>
>>> David Gibson writes:
>>>
>>>> On Mon, Mar 30, 2015 at 01:18:01PM +1100, Alexey Kardashevskiy wrote:
>>>>> On 03/27/
passthru devices need to identify with its own ibm,loc-code
available on the host.
2) Emulated devices encode as following:
qemu_::.
Signed-off-by: Nikunj A Dadhania
---
Changelog
v2:
* Using rtas call for getting ibm,loc-code
* Added sPAPRPHBState::get_loc_code
* Refactored the return type of
David Gibson writes:
> On Tue, Mar 31, 2015 at 01:00:57PM +1100, Alexey Kardashevskiy wrote:
>> On 03/30/2015 10:02 PM, Nikunj A Dadhania wrote:
>> >Each hardware instance has a platform unique location code. The OF
>> >device tree that describes a part of a hardware
Alexey Kardashevskiy writes:
> On 03/31/2015 04:15 PM, Nikunj A Dadhania wrote:
>> David Gibson writes:
>>
>>> On Tue, Mar 31, 2015 at 01:00:57PM +1100, Alexey Kardashevskiy wrote:
>>>> On 03/30/2015 10:02 PM, Nikunj A Dadhania wrote:
>>>>> Ea
Alex Williamson writes:
> On Thu, 2015-03-26 at 12:12 +0530, Nikunj A Dadhania wrote:
>> From PCIDevice there is no way to know if the device has a backing
>> vfio device.
>>
>> sPAPR guests inherits the "ibm,loc-code" from the pci pass through
>> devi
Michael Roth writes:
> Quoting Alexey Kardashevskiy (2015-03-29 22:08:17)
>> On 03/30/2015 01:25 PM, David Gibson wrote:
>> > On Mon, Mar 30, 2015 at 01:18:01PM +1100, Alexey Kardashevskiy wrote:
>> >> On 03/27/2015 08:49 PM, Nikunj A Dadhania wrote:
>> >&
identify with its own ibm,loc-code
available on the host.
2) Emulated devices encode as following:
qemu_::.
Signed-off-by: Nikunj A Dadhania
---
hw/ppc/spapr_pci.c | 85 +++---
1 file changed, 75 insertions(+), 10 deletions(-)
diff --git a/hw/ppc
backward compatibility, a flag
"qemu,phb-enumerated" is added to the phb, suggesting to SLOF to not
do device node creation.
Signed-off-by: Nikunj A Dadhania
---
hw/ppc/spapr_pci.c | 93 --
1 file changed, 84 insertions(+), 9 deletions(-)
very complicated
with use of RTAS/HCALL
Nikunj A Dadhania (2):
spapr: enumerate and add PCI device tree
spapr: populate ibm,loc-code
hw/ppc/spapr_pci.c | 166 -
1 file changed, 153 insertions(+), 13 deletions(-)
--
1.8.3.1
Nikunj A Dadhania writes:
> The patch series creates PCI DT nodes in QEMU. The new
> hotplug code needs the device node creation in Qemu. While during
> boot, nodes were created in SLOF. It makes more sense to consolidate
> the code to one place for better maintainability.
Based
Hi Michael,
Couple of issues I found during my testing with pci enumerations patches
yesterday:
Michael Roth writes:
> This enables hotplug of PCI devices to a PHB. Upon hotplug we
> generate the OF-nodes required by PAPR specification and
> IEEE 1275-1994 "PCI Bus Binding to Open Firmware" for
Nikunj A Dadhania writes:
> Nikunj A Dadhania writes:
>
>> Current DEFAULT_RAM_SIZE(128MB) enforced by QEMU would not work for
>> all machines. Introduce a default_ram_size as part of MachineClass.
>>
>> The below patches has following behaviour:
>>
&g
Nikunj A Dadhania writes:
> Nikunj A Dadhania writes:
>
>> Nikunj A Dadhania writes:
>>
>>> Current DEFAULT_RAM_SIZE(128MB) enforced by QEMU would not work for
>>> all machines. Introduce a default_ram_size as part of MachineClass.
>>>
>>>
the default_ram_size.
Add helpers [K,M,G,T,P,E]_BYTE for better readability and easy usage
Signed-off-by: Nikunj A Dadhania
---
hw/core/machine.c | 9 +
include/hw/boards.h | 1 +
include/qemu-common.h | 6 ++
vl.c | 30 --
4
Signed-off-by: Nikunj A Dadhania
Reviewed-by: Igor Mammedov
---
hw/ppc/spapr.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c
index 61ddc79..6616650 100644
--- a/hw/ppc/spapr.c
+++ b/hw/ppc/spapr.c
@@ -1794,6 +1794,7 @@ static void spapr_machine_class_init
fault behaviour of "-m" is not changed
On the side note, there are other cleanup of removing ram_size, slots
and maxmem from vl.c. All these are being parsed by generic code. This
can be moved to machine specific property. I will take a stab at it
next.
Nikunj A Dadhania (2):
machine
David Gibson writes:
> On Wed, Apr 22, 2015 at 04:05:34PM +0530, Nikunj A Dadhania wrote:
>> Each hardware instance has a platform unique location code. The OF
>> device tree that describes a part of a hardware entity must include
>> the “ibm,loc-code” property with a valu
David Gibson writes:
> On Wed, Apr 22, 2015 at 04:05:33PM +0530, Nikunj A Dadhania wrote:
>> All the PCI enumeration and device node creation was off-loaded to
>> SLOF. With PCI hotplug support, code needed to be added to add device
>> node. This creates multiple copy of the
Alexey Kardashevskiy writes:
> On 04/22/2015 08:35 PM, Nikunj A Dadhania wrote:
>> All the PCI enumeration and device node creation was off-loaded to
>> SLOF. With PCI hotplug support, code needed to be added to add device
>> node. This creates multiple copy of the code one
to avoid multiple indentation (Alexey Kardashevskiy)
Nikunj A Dadhania (2):
spapr: enumerate and add PCI device tree
spapr: populate ibm,loc-code
hw/ppc/spapr_pci.c | 183 +
1 file changed, 170 insertions(+), 13 deletions(-)
--
1.8.3.1
backward compatibility, a flag
"qemu,phb-enumerated" is added to the phb, suggesting to SLOF to not
do device node creation.
Signed-off-by: Nikunj A Dadhania
---
hw/ppc/spapr_pci.c | 111 -
1 file changed, 102 insertions(+), 9 deletion
identify with its own ibm,loc-code
available on the host.
2) Emulated devices encode as following:
qemu_::.
Signed-off-by: Nikunj A Dadhania
---
hw/ppc/spapr_pci.c | 86 +++---
1 file changed, 75 insertions(+), 11 deletions(-)
diff --git a/hw/ppc
Hi Paolo,
David Gibson writes:
> On Tue, Apr 28, 2015 at 01:30:29PM +0200, Thomas Huth wrote:
>> On Tue, 28 Apr 2015 12:23:25 +0530
>> Nikunj A Dadhania wrote:
> [snip]
>> Looks good to me.
>>
>> Reviewed-by: Thomas Huth
>
> Same here,
>
> Rev
Hi Paolo,
Paolo Bonzini writes:
> On 29/04/2015 10:14, Nikunj A Dadhania wrote:
>>
>> Hi Paolo,
>>
>> David Gibson writes:
>>> On Tue, Apr 28, 2015 at 01:30:29PM +0200, Thomas Huth wrote:
>>>> On Tue, 28 Apr 2015 12:23:25 +0530
>>>>
Hi Paolo,
Paolo Bonzini writes:
> On 29/04/2015 11:06, Nikunj A Dadhania wrote:
>> > so David can push both patches.
>> >
>> > But isn't 1G a bit too much? At least on x86 you can easily boot with
>> > 512M.
>>
>> I understood this n
Alexey Kardashevskiy writes:
> On 05/07/2015 05:21 PM, Nikunj A Dadhania wrote:
>> Each hardware instance has a platform unique location code. The OF
>> device tree that describes a part of a hardware entity must include
>> the “ibm,loc-code” property with a value that re
Alexey Kardashevskiy writes:
> On 05/19/2015 02:51 PM, Nikunj A Dadhania wrote:
>> Alexey Kardashevskiy writes:
>>
>>> On 05/07/2015 05:21 PM, Nikunj A Dadhania wrote:
>>>> Each hardware instance has a platform unique location code. The OF
>>>>
Alexey Kardashevskiy writes:
> On 05/19/2015 02:51 PM, Nikunj A Dadhania wrote:
>> Alexey Kardashevskiy writes:
>>
>>> On 05/07/2015 05:21 PM, Nikunj A Dadhania wrote:
>>>> Each hardware instance has a platform unique location code. The OF
>>>>
Alexey Kardashevskiy writes:
> On 05/19/2015 04:56 PM, Nikunj A Dadhania wrote:
>> Alexey Kardashevskiy writes:
>>
>>> On 05/19/2015 02:51 PM, Nikunj A Dadhania wrote:
>>>> Alexey Kardashevskiy writes:
>>>>
>>>>> On 05/07/2015 0
backward compatibility, a flag
"qemu,phb-enumerated" is added to the phb, suggesting to SLOF to not
do device node creation.
Signed-off-by: Nikunj A Dadhania
[ Squashed Michael's drc_index changes ]
Signed-off-by: Michael Roth
Signed-off-by: Nikunj A Dadhania
---
hw/ppc/sp
de to avoid multiple indentation (Alexey Kardashevskiy)
Nikunj A Dadhania (4):
spapr_pci: encode missing 64-bit memory address space
spapr_pci: encode class code including Prog IF register
spapr_pci: enumerate and add PCI device tree
spapr_pci: populate ibm,loc-code
hw/p
identify with its own ibm,loc-code
available on the host. In failure cases use:
vfio_::.
2) Emulated devices encode as following:
qemu_::.
Signed-off-by: Nikunj A Dadhania
---
hw/ppc/spapr_pci.c | 81 ++
1 file changed, 69 insertions
Current code missed the Prog IF register. All Class Code, Subclass,
and Prog IF registers are needed to identify the accurate device type.
For example: USB controllers use the PROG IF for denoting: USB
FullSpeed, HighSpeed or SuperSpeed.
Signed-off-by: Nikunj A Dadhania
Reviewed-by: Thomas Huth
The properties reg/assigned-resources need to encode 64-bit memory
address space as part of phys.hi dword.
00 if configuration space
01 if IO region,
10 if 32-bit MEM region
11 if 64-bit MEM region
Signed-off-by: Nikunj A Dadhania
Reviewed-by: Thomas Huth
---
hw/ppc/spapr_pci.c | 10
Alexey Kardashevskiy writes:
> On 05/19/2015 06:14 PM, Nikunj A Dadhania wrote:
>> Alexey Kardashevskiy writes:
>>
>>> On 05/19/2015 04:56 PM, Nikunj A Dadhania wrote:
>>>> Alexey Kardashevskiy writes:
>>>>
>>>>> On 05/19/2015
1 - 100 of 1016 matches
Mail list logo
