Re: [PATCH 0/2] SMBIOS type 9 descriptor implementation

Friendly ping on review for this patchset! It's been ~2 weeks since it was sent out, please let us know if there's any changes that should be done to upstream it! Thanks, Nabih Estefan Nabih Estefan (he/him) | Software Engineer | nabiheste...@google.com | 857-308-9574 On Wed, Fe

[PATCH 2/2] Implement SMBIOS type 9 v2.6

From: Felix Wu Signed-off-by: Felix Wu Signed-off-by: Nabih Estefan --- hw/smbios/smbios.c | 49 +--- include/hw/firmware/smbios.h | 4 +++ qemu-options.hx | 2 +- 3 files changed, 51 insertions(+), 4 deletions(-) diff --git a/hw

[PATCH 1/2] Implement base of SMBIOS type 9 descriptor.

From: Felix Wu Version 2.1+. Signed-off-by: Felix Wu Signed-off-by: Nabih Estefan --- hw/smbios/smbios.c | 99 include/hw/firmware/smbios.h | 13 + qemu-options.hx | 3 ++ 3 files changed, 115 insertions(+) diff --git a/hw

[PATCH 0/2] SMBIOS type 9 descriptor implementation

This patch series implements SMBIOS type 9 descriptor, system slots. For each system slot, we can assign one descriptor for it if needed. In versions later than 2.6, a new PCI device field was added to make sure the descriptor is associated with a certain device, if provided. For ease of usage, qem

[PATCH 1/2] hw/arm/smmuv3: Check StreamIDs against SMMU_IDR1.SIDSIZE value

and redefining the value of SMMU_IDR1.SIDSIZE because the check is hardcoded to the constant SMMU_IDR1_SIDSIZE rather than the register value. Signed-off-by: Roque Arcudia Hernandez Signed-off-by: Nabih Estefan --- hw/arm/smmuv3.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff

[PATCH 2/2] hw/arm/smmu-common: Create virtual function for implementation defined StreamID

constructed via inheritance. The default implementation of these functions will match the current ones where the BDF is used directly as StreamID. Signed-off-by: Roque Arcudia Hernandez Signed-off-by: Nabih Estefan --- hw/arm/smmu-common.c | 12 include/hw/arm/smmu-common.h | 16

[PATCH 0/2] ARM SMMUv3 StreamID Implementation

This patch series modifies the ARM SMMUv3 to be able to work with an implementation specific StreamID that does not match exactly the PCIe BDF. The way to achieve this is by converting the smmu_get_sid and smmu_iommu_mr functions to virtual functions that can be overridden by inheritance, making su

[PATCH 0/2] ARM GICv3 ITS DeviceID modification implementation

This patch series modifies the ARM GICv3 ITS to use the already existing send_msi virtual function when writing the GITS_TRANSLATER in order to be able to modify the final DeviceID to an implementation specific version that requires extra information besides the BDF that comes in the requester_id.

[PATCH 1/2] hw/intc/arm_gicv3_its_common: Increase DeviceID to 32 bits

Arcudia Hernandez Signed-off-by: Nabih Estefan --- hw/intc/arm_gicv3_its_kvm.c| 2 +- include/hw/intc/arm_gicv3_its_common.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/intc/arm_gicv3_its_kvm.c b/hw/intc/arm_gicv3_its_kvm.c index 3befc960db..4eaf1cfcad 100644

[PATCH 2/2] hw/intc/arm_gicv3_its: Use send_msi in the GITS_TRANSLATER write

From: Roque Arcudia Hernandez This is trying to achieve 2 things: To be able to redefine the send_msi in a derived class of arm_gicv3_its and/or to expose a method call interface to inject interrupts from another device. Signed-off-by: Roque Arcudia Hernandez Signed-off-by: Nabih Estefan

[PATCH] hw/nvme/ns: Add NVMe NGUID property

GUID will be part of the Namespace Identification Descriptor list and the Identify Namespace data. Signed-off-by: Roque Arcudia Hernandez Signed-off-by: Nabih Estefan --- docs/system/devices/nvme.rst | 7 ++ hw/nvme/ctrl.c | 12 +++ hw/nvme/meson.build | 2

[PATCH v2] hw/nvme/ns: Add NVMe NGUID property

GUID will be part of the Namespace Identification Descriptor list and the Identify Namespace data. Signed-off-by: Roque Arcudia Hernandez Signed-off-by: Nabih Estefan Reviewed-by: Klaus Jensen --- docs/system/devices/nvme.rst | 7 ++ hw/nvme/ctrl.c | 12 +++ hw/nvme/meson.build

[PATCH v16 1/6] hw/net: Add NPCMXXX GMAC device

[Broadcom BCM54612E] (mii_bus:phy_addr=stmmac-0:00, irq=POLL) stmmaceth f0802000.eth eth0: Link is Up - 1Gbps/Full - flow control rx/tx Change-Id: If71c6d486b95edcccba109ba454870714d7e0940 Signed-off-by: Hao Wu Signed-off-by: Nabih Estefan Diaz Reviewed-by: Tyrone Ting --- hw/net/meson.build

[PATCH v16 3/6] tests/qtest: Creating qtest for GMAC Module

From: Nabih Estefan Diaz - Created qtest to check initialization of registers in GMAC Module. - Implemented test into Build File. Change-Id: I8b2fe152d3987a7eec4cf6a1d25ba92e75a5391d Signed-off-by: Nabih Estefan Reviewed-by: Tyrone Ting --- tests/qtest/meson.build | 1 + tests/qtest

[PATCH v16 2/6] hw/arm: Add GMAC devices to NPCM7XX SoC

From: Hao Wu Change-Id: Id8a3461fb5042adc4c3fd6f4fbd1ca0d33e22565 Signed-off-by: Hao Wu Signed-off-by: Nabih Estefan Reviewed-by: Tyrone Ting --- hw/arm/npcm7xx.c | 37 +++-- include/hw/arm/npcm7xx.h | 2 ++ 2 files changed, 37 insertions(+), 2

[PATCH v16 5/6] hw/net: GMAC Tx Implementation

From: Nabih Estefan Diaz - Implementation of Transmit function for packets - Implementation for reading and writing from and to descriptors in memory for Tx Added relevant trace-events NOTE: This function implements the steps detailed in the datasheet for transmitting messages from the GMAC

[PATCH v16 4/6] hw/net: GMAC Rx Implementation

From: Nabih Estefan Diaz - Implementation of Receive function for packets - Implementation for reading and writing from and to descriptors in memory for Rx When RX starts, we need to flush the queued packets so that they can be received by the GMAC device. Without this it won't work wit

[PATCH v16 0/6] Implementation of NPI Mailbox and GMAC Networking Module

From: Nabih Estefan Diaz [Changes since v15] Dropped PCI MBox patches. They were presenting a lot of problems with endianness and are not directly related to the GMAC. Breaking them apart to debug separately and let the GMAC itself be upstreamed faster. [Changes since v14] Expanded comment

[PATCH v16 6/6] tests/qtest: Adding PCS Module test to GMAC Qtest

From: Nabih Estefan Diaz - Add PCS Register check to npcm_gmac-test Change-Id: I34821beb5e0b1e89e2be576ab58eabe41545af12 Signed-off-by: Nabih Estefan Reviewed-by: Tyrone Ting --- tests/qtest/npcm_gmac-test.c | 132 +++ 1 file changed, 132 insertions(+) diff

[PATCH v16 3/6] tests/qtest: Creating qtest for GMAC Module

From: Nabih Estefan Diaz - Created qtest to check initialization of registers in GMAC Module. - Implemented test into Build File. Change-Id: I8b2fe152d3987a7eec4cf6a1d25ba92e75a5391d Signed-off-by: Nabih Estefan Reviewed-by: Tyrone Ting --- tests/qtest/meson.build | 1 + tests/qtest

[PATCH v16 2/6] hw/arm: Add GMAC devices to NPCM7XX SoC

From: Hao Wu Change-Id: Id8a3461fb5042adc4c3fd6f4fbd1ca0d33e22565 Signed-off-by: Hao Wu Signed-off-by: Nabih Estefan Reviewed-by: Tyrone Ting --- hw/arm/npcm7xx.c | 37 +++-- include/hw/arm/npcm7xx.h | 2 ++ 2 files changed, 37 insertions(+), 2

[PATCH v16 5/6] hw/net: GMAC Tx Implementation

From: Nabih Estefan Diaz - Implementation of Transmit function for packets - Implementation for reading and writing from and to descriptors in memory for Tx Added relevant trace-events NOTE: This function implements the steps detailed in the datasheet for transmitting messages from the GMAC

[PATCH v16 6/6] tests/qtest: Adding PCS Module test to GMAC Qtest

From: Nabih Estefan Diaz - Add PCS Register check to npcm_gmac-test Change-Id: I34821beb5e0b1e89e2be576ab58eabe41545af12 Signed-off-by: Nabih Estefan Reviewed-by: Tyrone Ting --- tests/qtest/npcm_gmac-test.c | 132 +++ 1 file changed, 132 insertions(+) diff

[PATCH v16 4/6] hw/net: GMAC Rx Implementation

From: Nabih Estefan Diaz - Implementation of Receive function for packets - Implementation for reading and writing from and to descriptors in memory for Rx When RX starts, we need to flush the queued packets so that they can be received by the GMAC device. Without this it won't work wit

[PATCH v16 0/6] Implementation of GMAC Networking Module

From: Nabih Estefan Diaz [Changes since v15] Dropped PCI MBox patches. They were presenting a lot of problems with endianness and are not directly related to the GMAC. Breaking them apart to debug separately and let the GMAC itself be upstreamed faster. [Changes since v14] Expanded comment

[PATCH v16 1/6] hw/net: Add NPCMXXX GMAC device

[Broadcom BCM54612E] (mii_bus:phy_addr=stmmac-0:00, irq=POLL) stmmaceth f0802000.eth eth0: Link is Up - 1Gbps/Full - flow control rx/tx Change-Id: If71c6d486b95edcccba109ba454870714d7e0940 Signed-off-by: Hao Wu Signed-off-by: Nabih Estefan Diaz Reviewed-by: Tyrone Ting --- hw/net/meson.build

[PATCH 1/1] tests/qtest: Fixing GMAC test to run in 7xx

Fixing the nocm_gmac-test.c file to run on a nuvoton 7xx machine instead of 8xx. Also fixing comments referencing this and values expecting 8xx. Change-Id: I07b91e8be473e6a1ece65a2202608b52ed4025b8 Signed-Off-By: Nabih Estefan --- tests/qtest/meson.build | 4 ++-- tests/qtest/npcm_gmac

[PATCH 0/1] Sending small fix for NPCM GMAC test to properly test on Nuvoton 7xx

Nabih Estefan (1): tests/qtest: Fixing GMAC test to run in 7xx tests/qtest/meson.build | 4 ++-- tests/qtest/npcm_gmac-test.c | 12 ++-- 2 files changed, 4 insertions(+), 12 deletions(-) -- 2.43.0.594.gd9cf4e227d-goog

[PATCH v2 0/1] Sending small fix for NPCM GMAC test to properly test on Nuvoton 7xx

Removing testing for PCS registers since that doesn't exist on 7xx. Nabih Estefan (1): tests/qtest: Fixing GMAC test to run in 7xx obmc-phosphor-image-gsj.static.mtd | Bin 0 -> 33554432 bytes tests/qtest/meson.build| 4 +- tests/qtest/npcm_gmac-test.c

[PATCH v2 0/1] Sending small fix for NPCM GMAC test to properly test on Nuvoton 7xx

Removing testing for PCS registers since that doesn't exist on 7xx. Nabih Estefan (1): tests/qtest: Fixing GMAC test to run in 7xx obmc-phosphor-image-gsj.static.mtd | Bin 0 -> 33554432 bytes tests/qtest/meson.build| 4 +- tests/qtest/npcm_gmac-test.c

[PATCH v3 0/1] Sending small fix for NPCM GMAC test to properly test on Nuvoton 7xx

Accidentally added extra file to v2 that broke email sending (and was not meant to be upstreamed). Sending our v3 to skip that confusion. Removing testing for PCS registers since that doesn't exist on 7xx. Nabih Estefan (1): tests/qtest: Fixing GMAC test to run in 7xx tests/qtest/meson.

[PATCH v3 1/1] tests/qtest: Fixing GMAC test to run in 7xx

Fixing the nocm_gmac-test.c file to run on a nuvoton 7xx machine instead of 8xx. Also fixing comments referencing this and values expecting 8xx. Change-Id: Iabd0fba14910c3f1e883c4a9521350f3db9ffab8 Signed-Off-By: Nabih Estefan Reviewed-by: Tyrone Ting --- tests/qtest/meson.build | 4

[PATCH v13 0/9] Implementation of NPI Mailbox and GMAC Networking Module

From: Nabih Estefan Diaz [Changes since v12] Fix errors found when testing in big-endian host. [Changes since v11] Branch couldn't be merged with master because of issues in patchset 6. Fixed. [Changes since v10] Fixed macOS build issue. Changed imports to not be linux-specific. [Ch

[PATCH v13 7/9] hw/net: GMAC Rx Implementation

From: Nabih Estefan Diaz - Implementation of Receive function for packets - Implementation for reading and writing from and to descriptors in memory for Rx When RX starts, we need to flush the queued packets so that they can be received by the GMAC device. Without this it won't work wit

[PATCH v13 3/9] hw/misc: Add qtest for NPCM7xx PCI Mailbox

From: Hao Wu This patches adds a qtest for NPCM7XX PCI Mailbox module. It sends read and write requests to the module, and verifies that the module contains the correct data after the requests. Change-Id: I2e1dbaecf8be9ec7eab55cb54f7fdeb0715b8275 Signed-off-by: Hao Wu Signed-off-by: Nabih

[PATCH v13 1/9] hw/misc: Add Nuvoton's PCI Mailbox Module

with the core CPU is emulated via a chardev and will be in a follow-up patch. Change-Id: Iaca22f81c4526927d437aa367079ed038faf43f2 Signed-off-by: Hao Wu Signed-off-by: Nabih Estefan Reviewed-by: Tyrone Ting --- hw/misc/meson.build| 1 + hw/misc/npcm7xx_pci_mbox.c | 324

[PATCH v13 6/9] tests/qtest: Creating qtest for GMAC Module

From: Nabih Estefan Diaz - Created qtest to check initialization of registers in GMAC Module. - Implemented test into Build File. Change-Id: I8b2fe152d3987a7eec4cf6a1d25ba92e75a5391d Signed-off-by: Nabih Estefan Reviewed-by: Tyrone Ting --- tests/qtest/meson.build | 1 + tests/qtest

[PATCH v13 8/9] hw/net: GMAC Tx Implementation

From: Nabih Estefan Diaz - Implementation of Transmit function for packets - Implementation for reading and writing from and to descriptors in memory for Tx Added relevant trace-events NOTE: This function implements the steps detailed in the datasheet for transmitting messages from the GMAC

[PATCH v13 9/9] tests/qtest: Adding PCS Module test to GMAC Qtest

From: Nabih Estefan Diaz - Add PCS Register check to npcm_gmac-test Change-Id: I34821beb5e0b1e89e2be576ab58eabe41545af12 Signed-off-by: Nabih Estefan Reviewed-by: Tyrone Ting --- tests/qtest/npcm_gmac-test.c | 132 +++ 1 file changed, 132 insertions(+) diff

[PATCH v13 4/9] hw/net: Add NPCMXXX GMAC device

[Broadcom BCM54612E] (mii_bus:phy_addr=stmmac-0:00, irq=POLL) stmmaceth f0802000.eth eth0: Link is Up - 1Gbps/Full - flow control rx/tx Change-Id: If71c6d486b95edcccba109ba454870714d7e0940 Signed-off-by: Hao Wu Signed-off-by: Nabih Estefan Diaz Reviewed-by: Tyrone Ting --- hw/net/meson.build

[PATCH v13 2/9] hw/arm: Add PCI mailbox module to Nuvoton SoC

From: Hao Wu This patch wires the PCI mailbox module to Nuvoton SoC. Change-Id: I14c42c628258804030f0583889882842bde0d972 Signed-off-by: Hao Wu Signed-off-by: Nabih Estefan Reviewed-by: Tyrone Ting --- docs/system/arm/nuvoton.rst | 2 ++ hw/arm/npcm7xx.c| 17

[PATCH v13 5/9] hw/arm: Add GMAC devices to NPCM7XX SoC

From: Hao Wu Change-Id: Id8a3461fb5042adc4c3fd6f4fbd1ca0d33e22565 Signed-off-by: Hao Wu Signed-off-by: Nabih Estefan Reviewed-by: Tyrone Ting --- hw/arm/npcm7xx.c | 36 ++-- include/hw/arm/npcm7xx.h | 2 ++ 2 files changed, 36 insertions(+), 2

[PATCH v14 4/9] hw/net: Add NPCMXXX GMAC device

[Broadcom BCM54612E] (mii_bus:phy_addr=stmmac-0:00, irq=POLL) stmmaceth f0802000.eth eth0: Link is Up - 1Gbps/Full - flow control rx/tx Change-Id: If71c6d486b95edcccba109ba454870714d7e0940 Signed-off-by: Hao Wu Signed-off-by: Nabih Estefan Diaz Reviewed-by: Tyrone Ting --- hw/net/meson.build

[PATCH v14 6/9] tests/qtest: Creating qtest for GMAC Module

From: Nabih Estefan Diaz - Created qtest to check initialization of registers in GMAC Module. - Implemented test into Build File. Change-Id: I8b2fe152d3987a7eec4cf6a1d25ba92e75a5391d Signed-off-by: Nabih Estefan Reviewed-by: Tyrone Ting --- tests/qtest/meson.build | 1 + tests/qtest

[PATCH v14 3/9] hw/misc: Add qtest for NPCM7xx PCI Mailbox

From: Hao Wu This patches adds a qtest for NPCM7XX PCI Mailbox module. It sends read and write requests to the module, and verifies that the module contains the correct data after the requests. Change-Id: I2e1dbaecf8be9ec7eab55cb54f7fdeb0715b8275 Signed-off-by: Hao Wu Signed-off-by: Nabih

[PATCH v14 0/9] Implementation of NPI Mailbox and GMAC Networking Module

From: Nabih Estefan Diaz [Changes since v13] Added a couple clarifying comments and documentation about chardev device expected protocol for ease of review. [Changes since v12] Fix errors found when testing in big-endian host. [Changes since v11] Branch couldn't be merged with master be

[PATCH v14 8/9] hw/net: GMAC Tx Implementation

From: Nabih Estefan Diaz - Implementation of Transmit function for packets - Implementation for reading and writing from and to descriptors in memory for Tx Added relevant trace-events NOTE: This function implements the steps detailed in the datasheet for transmitting messages from the GMAC

[PATCH v14 1/9] hw/misc: Add Nuvoton's PCI Mailbox Module

with the core CPU is emulated via a chardev and will be in a follow-up patch. Change-Id: Iaca22f81c4526927d437aa367079ed038faf43f2 Signed-off-by: Hao Wu Signed-off-by: Nabih Estefan Reviewed-by: Tyrone Ting --- hw/misc/meson.build| 1 + hw/misc/npcm7xx_pci_mbox.c | 333

[PATCH v14 5/9] hw/arm: Add GMAC devices to NPCM7XX SoC

From: Hao Wu Change-Id: Id8a3461fb5042adc4c3fd6f4fbd1ca0d33e22565 Signed-off-by: Hao Wu Signed-off-by: Nabih Estefan Reviewed-by: Tyrone Ting --- hw/arm/npcm7xx.c | 36 ++-- include/hw/arm/npcm7xx.h | 2 ++ 2 files changed, 36 insertions(+), 2

[PATCH v14 9/9] tests/qtest: Adding PCS Module test to GMAC Qtest

From: Nabih Estefan Diaz - Add PCS Register check to npcm_gmac-test Change-Id: I34821beb5e0b1e89e2be576ab58eabe41545af12 Signed-off-by: Nabih Estefan Reviewed-by: Tyrone Ting --- tests/qtest/npcm_gmac-test.c | 132 +++ 1 file changed, 132 insertions(+) diff

[PATCH v14 7/9] hw/net: GMAC Rx Implementation

From: Nabih Estefan Diaz - Implementation of Receive function for packets - Implementation for reading and writing from and to descriptors in memory for Rx When RX starts, we need to flush the queued packets so that they can be received by the GMAC device. Without this it won't work wit

[PATCH v14 2/9] hw/arm: Add PCI mailbox module to Nuvoton SoC

From: Hao Wu This patch wires the PCI mailbox module to Nuvoton SoC. Change-Id: I14c42c628258804030f0583889882842bde0d972 Signed-off-by: Hao Wu Signed-off-by: Nabih Estefan Reviewed-by: Tyrone Ting --- docs/system/arm/nuvoton.rst | 2 ++ hw/arm/npcm7xx.c| 17

[PATCH v15 3/9] hw/misc: Add qtest for NPCM7xx PCI Mailbox

From: Hao Wu This patches adds a qtest for NPCM7XX PCI Mailbox module. It sends read and write requests to the module, and verifies that the module contains the correct data after the requests. Change-Id: I2e1dbaecf8be9ec7eab55cb54f7fdeb0715b8275 Signed-off-by: Hao Wu Signed-off-by: Nabih

[PATCH v15 0/9] Implementation of NPI Mailbox and GMAC Networking Module

From: Nabih Estefan Diaz [Changes since v14] Expanded comment on chardev device and fixed comment formatting [Changes since v13] Added a couple clarifying comments and documentation about chardev device expected protocol for ease of review. [Changes since v12] Fix errors found when testing in

[PATCH v15 2/9] hw/arm: Add PCI mailbox module to Nuvoton SoC

From: Hao Wu This patch wires the PCI mailbox module to Nuvoton SoC. Change-Id: I14c42c628258804030f0583889882842bde0d972 Signed-off-by: Hao Wu Signed-off-by: Nabih Estefan Reviewed-by: Tyrone Ting --- docs/system/arm/nuvoton.rst | 2 ++ hw/arm/npcm7xx.c| 17

[PATCH v15 1/9] hw/misc: Add Nuvoton's PCI Mailbox Module

with the core CPU is emulated via a chardev and will be in a follow-up patch. This patch also adds documentation on the PCIe Protocol used by the chardev device. Change-Id: Iaca22f81c4526927d437aa367079ed038faf43f2 Signed-off-by: Hao Wu Signed-off-by: Nabih Estefan Reviewed-by: Tyrone Ting

[PATCH v15 9/9] tests/qtest: Adding PCS Module test to GMAC Qtest

From: Nabih Estefan Diaz - Add PCS Register check to npcm_gmac-test Change-Id: I34821beb5e0b1e89e2be576ab58eabe41545af12 Signed-off-by: Nabih Estefan Reviewed-by: Tyrone Ting --- tests/qtest/npcm_gmac-test.c | 132 +++ 1 file changed, 132 insertions(+) diff

[PATCH v15 7/9] hw/net: GMAC Rx Implementation

From: Nabih Estefan Diaz - Implementation of Receive function for packets - Implementation for reading and writing from and to descriptors in memory for Rx When RX starts, we need to flush the queued packets so that they can be received by the GMAC device. Without this it won't work wit

[PATCH v15 5/9] hw/arm: Add GMAC devices to NPCM7XX SoC

From: Hao Wu Change-Id: Id8a3461fb5042adc4c3fd6f4fbd1ca0d33e22565 Signed-off-by: Hao Wu Signed-off-by: Nabih Estefan Reviewed-by: Tyrone Ting --- hw/arm/npcm7xx.c | 36 ++-- include/hw/arm/npcm7xx.h | 2 ++ 2 files changed, 36 insertions(+), 2

[PATCH v15 6/9] tests/qtest: Creating qtest for GMAC Module

From: Nabih Estefan Diaz - Created qtest to check initialization of registers in GMAC Module. - Implemented test into Build File. Change-Id: I8b2fe152d3987a7eec4cf6a1d25ba92e75a5391d Signed-off-by: Nabih Estefan Reviewed-by: Tyrone Ting --- tests/qtest/meson.build | 1 + tests/qtest

[PATCH v15 4/9] hw/net: Add NPCMXXX GMAC device

[Broadcom BCM54612E] (mii_bus:phy_addr=stmmac-0:00, irq=POLL) stmmaceth f0802000.eth eth0: Link is Up - 1Gbps/Full - flow control rx/tx Change-Id: If71c6d486b95edcccba109ba454870714d7e0940 Signed-off-by: Hao Wu Signed-off-by: Nabih Estefan Diaz Reviewed-by: Tyrone Ting --- hw/net/meson.build

[PATCH v15 8/9] hw/net: GMAC Tx Implementation

From: Nabih Estefan Diaz - Implementation of Transmit function for packets - Implementation for reading and writing from and to descriptors in memory for Tx Added relevant trace-events NOTE: This function implements the steps detailed in the datasheet for transmitting messages from the GMAC

[PATCH] hw/net: Fix Coverity Issue for npcm-gmac

There is an extra `buf=` set that is not used by npcm-gmac. Remove it for coverity to be happy. Signed-off-by: Nabih Estefan --- hw/net/npcm_gmac.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/net/npcm_gmac.c b/hw/net/npcm_gmac.c index 1b71e2526e..b397fd5064 100644 --- a/hw/net

[PATCH] hw/net: Fix Coverity Issue for nocm-gmac

There is an extra `buf=` set that is not used by npcm-gmac. Remove it for coverity to be happy. Signed-off-by: Nabih Estefan --- hw/net/npcm_gmac.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/net/npcm_gmac.c b/hw/net/npcm_gmac.c index 1b71e2526e..b397fd5064 100644 --- a/hw/net

[PATCH] hw/net: Fix Coverity Issue for npcm-gmac

There is an extra `buf=` set that is not used by npcm-gmac. Remove it for coverity to be happy. Signed-off-by: Nabih Estefan --- hw/net/npcm_gmac.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/net/npcm_gmac.c b/hw/net/npcm_gmac.c index 1b71e2526e..b397fd5064 100644 --- a/hw/net

[PATCH] hw/net: Fix Coverity Issue for nocm-gmac

There is an extra `buf=` set that is not used by npcm-gmac. Remove it for coverity to be happy. Signed-off-by: Nabih Estefan --- hw/net/npcm_gmac.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/net/npcm_gmac.c b/hw/net/npcm_gmac.c index 1b71e2526e..b397fd5064 100644 --- a/hw/net

[PATCH] hw/net: Fix Coverity Issue for npcm-gmac

There is an extra `buf=` set that is not used by npcm-gmac. Remove it for coverity to be happy. Signed-off-by: Nabih Estefan --- hw/net/npcm_gmac.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/net/npcm_gmac.c b/hw/net/npcm_gmac.c index 1b71e2526e..b397fd5064 100644 --- a/hw/net

[PATCH] hw/net: Fix Coverity Issue for npcm-gmac

There is an extra `buf=` set that is not used by npcm-gmac. Remove it for coverity to be happy. Signed-off-by: Nabih Estefan --- hw/net/npcm_gmac.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/net/npcm_gmac.c b/hw/net/npcm_gmac.c index 1b71e2526e..b397fd5064 100644 --- a/hw/net

[PATCH 14/14] tests/qtest: Adding PCS Module test to GMAC Qtest

From: Nabih Estefan Diaz - Add PCS Register check to npcm_gmac-test Signed-off-by: Nabih Estefan Diaz --- tests/qtest/npcm_gmac-test.c | 135 ++- 1 file changed, 134 insertions(+), 1 deletion(-) diff --git a/tests/qtest/npcm_gmac-test.c b/tests/qtest

[PATCH 09/14] include/hw/net: Implemented Classes and Masks for GMAC Descriptors

From: Nabih Estefan Diaz - Implemeted classes for GMAC Receive and Transmit Descriptors - Implemented Masks for said descriptors Signed-off-by: Nabih Estefan Diaz --- include/hw/net/npcm_gmac.h | 27 +++ 1 file changed, 27 insertions(+) diff --git a/include/hw/net

[PATCH 01/14] hw/misc: Add Nuvoton's PCI Mailbox Module

From: Hao Wu The PCI Mailbox Module is a high-bandwidth communcation module between a Nuvoton BMC and CPU. It features 16KB RAM that are both accessible by the BMC and core CPU. and supports interrupt for both sides. This patch implements the BMC side of the PCI mailbox module. Communication wit

[PATCH 00/14] Implementation of NPI Mailbox and GMAC Networking Module

From: Nabih Estefan Diaz Creates NPI Mailbox Module with data verification for read and write (internal and external), wiring to the Nuvoton SoC, and QTests. Also creates the GMAC Networking Module. Implements read and write functionalities with cooresponding descriptors and registers. Also

[PATCH 08/14] \tests/qtest: Creating qtest for GMAC Module

From: Nabih Estefan Diaz - Created qtest to check initialization of registers in GMAC Module. - Implemented test into Build File. Signed-off-by: Nabih Estefan Diaz --- tests/qtest/meson.build | 11 +- tests/qtest/npcm_gmac-test.c | 209 +++ 2 files

[PATCH 03/14] hw/misc: Add qtest for NPCM7xx PCI Mailbox

From: Hao Wu This patches adds a qtest for NPCM7XX PCI Mailbox module. It sends read and write requests to the module, and verifies that the module contains the correct data after the requests. Signed-off-by: Hao Wu --- tests/qtest/meson.build | 1 + tests/qtest/npcm7xx_pci_mbox-

[PATCH 11/14] hw/net: GMAC Rx Implementation

From: Nabih Estefan Diaz - Implementation of Receive function for packets - Implementation for reading and writing from and to descriptors in memory for Rx NOTE: At this point in development we believe this function is working as intended, and the kernel supports these findings, but we need

[PATCH 10/14] hw/net: General GMAC Implementation

From: Nabih Estefan Diaz - General GMAC Register handling - GMAC IRQ Handling - Added traces in some methods for debugging - Lots of declarations for accessing information on GMAC Descriptors (npcm_gmac.h file) NOTE: With code on this state, the GMAC can boot-up properly and will show up in

[PATCH 07/14] hw/arm: Add GMAC devices to NPCM7XX SoC

From: Hao Wu Signed-off-by: Hao Wu --- hw/arm/npcm7xx.c | 38 -- include/hw/arm/npcm7xx.h | 3 +++ 2 files changed, 39 insertions(+), 2 deletions(-) diff --git a/hw/arm/npcm7xx.c b/hw/arm/npcm7xx.c index c69e936669..15c58ef4a9 100644 --- a/hw/arm/np

[PATCH 13/14] hw/arm: Connect to chardev backend for NPCM8XX

From: Hao Wu As NPCM8XX SoCs have 2 mailboxes, we can't use -global to connect the mailboxes to their specific chardevs. So we add the search for chardev code here, similar to what we did for the GMAC devices. Signed-off-by: Hao Wu --- hw/arm/npcm8xx.c | 11 +++ 1 file changed, 11 inse

[PATCH 06/14] hw/arm: Add GMAC devices to NPCM8XX SoC

From: Hao Wu Signed-off-by: Hao Wu --- hw/arm/npcm8xx.c | 12 include/hw/arm/npcm8xx.h | 118 +++ 2 files changed, 118 insertions(+), 12 deletions(-) create mode 100644 include/hw/arm/npcm8xx.h diff --git a/hw/arm/npcm8xx.c b/hw/arm/npcm8xx.c

[PATCH 02/14] hw/arm: Add PCI mailbox module to Nuvoton SoC

From: Hao Wu This patch wires the PCI mailbox module to Nuvoton SoC. hw/misc: Add chardev to PCI mailbox This patches adds a chardev to PCI mailbox that can be used to receive external read and write request from the host. Signed-off-by: Hao Wu --- hw/arm/npcm7xx.c | 16 ++

[PATCH 04/14] hw/net: Add NPCM8XX PCS Module

From: Hao Wu The PCS exists in NPCM8XX's GMAC1 and is used to control the SGMII PHY. This implementation contains all the default registers and the soft reset feature that are required to load the Linux kernel driver. Further features have not been implemented yet. Signed-off-by: Hao Wu --- hw

[PATCH 12/14] hw/net: GMAC Tx Implementation

From: Nabih Estefan Diaz - Implementation of Transmit function for packets - Implementation for reading and writing from and to descriptors in memory for Tx NOTE: This function implements the steps detailed in the datasheet for transmitting messages from the GMAC. Signed-off-by: Nabih

[PATCH 05/14] hw/net: Add NPCMXXX GMAC device

driver - Added trace for NPCM_GMAC reset - Added nd_table to npcm8xx.c for GMAC bootup Signed-off-by: Nabih Estefan Diaz hw/net: Add BCM54612E PHY regs for GMAC This patch adds default values for PHYs to make the driver happy. The device is derived from an actual Izumi machine. Signed-off-by: Hao Wu

[PATCH v2 00/11] Implementation of NPI Mailbox and GMAC Networking Module

From: Nabih Estefan Diaz [Changes since v1] Fixed some errors in formatting. Fixed a merge error that I didn't see in v1. Removed Nuvoton 8xx references since that is a separate patch set. [Original Cover] Creates NPI Mailbox Module with data verification for read and write (internal

[PATCH v2 02/11] hw/arm: Add PCI mailbox module to Nuvoton SoC

From: Hao Wu This patch wires the PCI mailbox module to Nuvoton SoC. Google-Rebase-Count: 5 Google-Bug-Id: 262938292 Signed-off-by: Hao Wu Change-Id: Ifd858a7ed760557faa15a7a1cef66b2056f06e2e --- docs/system/arm/nuvoton.rst | 2 ++ hw/arm/npcm7xx.c| 3 ++- include/hw/arm/npcm7xx.h

[PATCH v2 03/11] hw/misc: Add qtest for NPCM7xx PCI Mailbox

From: Hao Wu This patches adds a qtest for NPCM7XX PCI Mailbox module. It sends read and write requests to the module, and verifies that the module contains the correct data after the requests. Signed-off-by: Hao Wu --- tests/qtest/meson.build | 1 + tests/qtest/npcm7xx_pci_mbox-

[PATCH v2 04/11] hw/net: Add NPCMXXX GMAC device

driver - Added trace for NPCM_GMAC reset - Added nd_table to npcm8xx.c for GMAC bootup Signed-off-by: Nabih Estefan Diaz hw/net: Add BCM54612E PHY regs for GMAC This patch adds default values for PHYs to make the driver happy. The device is derived from an actual Izumi machine. Signed-off-by: Hao Wu

[PATCH v2 01/11] hw/misc: Add Nuvoton's PCI Mailbox Module

From: Hao Wu The PCI Mailbox Module is a high-bandwidth communcation module between a Nuvoton BMC and CPU. It features 16KB RAM that are both accessible by the BMC and core CPU. and supports interrupt for both sides. This patch implements the BMC side of the PCI mailbox module. Communication wit

[PATCH v2 07/11] include/hw/net: Implemented Classes and Masks for GMAC Descriptors

From: Nabih Estefan Diaz - Implemeted classes for GMAC Receive and Transmit Descriptors - Implemented Masks for said descriptors Signed-off-by: Nabih Estefan Diaz --- hw/net/npcm_gmac.c | 183 +++ hw/net/trace-events | 9 ++ include/hw

[PATCH v2 06/11] \tests/qtest: Creating qtest for GMAC Module

From: Nabih Estefan Diaz - Created qtest to check initialization of registers in GMAC Module. - Implemented test into Build File. Signed-off-by: Nabih Estefan Diaz --- tests/qtest/meson.build | 11 +- tests/qtest/npcm_gmac-test.c | 209 +++ 2 files

[PATCH v2 05/11] hw/arm: Add GMAC devices to NPCM7XX SoC

From: Hao Wu Signed-off-by: Hao Wu --- hw/arm/npcm7xx.c | 36 ++-- include/hw/arm/npcm7xx.h | 2 ++ 2 files changed, 36 insertions(+), 2 deletions(-) diff --git a/hw/arm/npcm7xx.c b/hw/arm/npcm7xx.c index c9e87162cb..12e11250e1 100644 --- a/hw/arm/npcm7

[PATCH v2 11/11] tests/qtest: Adding PCS Module test to GMAC Qtest

From: Nabih Estefan Diaz - Add PCS Register check to npcm_gmac-test Signed-off-by: Nabih Estefan Diaz --- tests/qtest/npcm_gmac-test.c | 134 ++- 1 file changed, 133 insertions(+), 1 deletion(-) diff --git a/tests/qtest/npcm_gmac-test.c b/tests/qtest

[PATCH v2 08/11] hw/net: General GMAC Implementation

From: Nabih Estefan Diaz - General GMAC Register handling - GMAC IRQ Handling - Added traces in some methods for debugging - Lots of declarations for accessing information on GMAC Descriptors (npcm_gmac.h file) NOTE: With code on this state, the GMAC can boot-up properly and will show up in

[PATCH v2 10/11] hw/net: GMAC Tx Implementation

From: Nabih Estefan Diaz - Implementation of Transmit function for packets - Implementation for reading and writing from and to descriptors in memory for Tx NOTE: This function implements the steps detailed in the datasheet for transmitting messages from the GMAC. Signed-off-by: Nabih

[PATCH v2 09/11] hw/net: GMAC Rx Implementation

From: Nabih Estefan Diaz - Implementation of Receive function for packets - Implementation for reading and writing from and to descriptors in memory for Rx NOTE: At this point in development we believe this function is working as intended, and the kernel supports these findings, but we need

Re: [PATCH v5 00/11] Implementation of NPI Mailbox and GMAC Networking Module

Hello, Since all patches for this change have been reviewed, is it possible to apply it to the current branch so it can be fully upstreamed? Thank you! Nabih Estefan (he/him) | Software Engineer | nabiheste...@google.com | 857-308-9574 Nabih Estefan (he/him) | Software Engineer | nabiheste

[PATCH v10 10/10] tests/qtest: Adding PCS Module test to GMAC Qtest

From: Nabih Estefan Diaz - Add PCS Register check to npcm_gmac-test Change-Id: I34821beb5e0b1e89e2be576ab58eabe41545af12 Signed-off-by: Nabih Estefan Reviewed-by: Tyrone Ting --- tests/qtest/npcm_gmac-test.c | 132 +++ 1 file changed, 132 insertions(+) diff

[PATCH v10 01/10] hw/misc: Add Nuvoton's PCI Mailbox Module

with the core CPU is emulated via a chardev and will be in a follow-up patch. Change-Id: Iaca22f81c4526927d437aa367079ed038faf43f2 Signed-off-by: Hao Wu Signed-off-by: Nabih Estefan Reviewed-by: Tyrone Ting --- hw/arm/npcm7xx.c | 15 +- hw/misc/meson.build| 1

[PATCH v10 00/10] Implementation of NPI Mailbox and GMAC Networking Module

From: Nabih Estefan Diaz [Changes since v9] More cleanup and fixes based on suggestions from Peter Maydell (peter.mayd...@linaro.org) suggestions. [Changes since v8] Suggestions and Fixes from Peter Maydell (peter.mayd...@linaro.org), also cleaned up changes so nothing is deleted in a later

[PATCH v10 05/10] hw/arm: Add GMAC devices to NPCM7XX SoC

From: Hao Wu Change-Id: Id8a3461fb5042adc4c3fd6f4fbd1ca0d33e22565 Signed-off-by: Hao Wu Signed-off-by: Nabih Estefan Reviewed-by: Tyrone Ting --- hw/arm/npcm7xx.c | 36 ++-- include/hw/arm/npcm7xx.h | 2 ++ 2 files changed, 36 insertions(+), 2

  1   2   3   >