Re: [Qemu-devel] [PULL 03/17] qemu-img: sort block formats in help message

2014-05-13 Thread Mike Day
mat is unique in the list. It may not be needed. Mike

[Qemu-devel] [PATCH] Remove g_sequence_lookup from qemu-img help function

2014-05-13 Thread Mike Day
ned-off-by: Mike Day --- qemu-img.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index 04ce02a..bf5e74c 100644 --- a/qemu-img.c +++ b/qemu-img.c @@ -70,11 +70,8 @@ static void add_format_to_seq(void *opaque, const char *fmt_name) { GSequence *seq = opa

[Qemu-devel] [PATCH] Remove g_sequence_lookup from qemu-img help function

2014-05-13 Thread Mike Day
Signed-off-by: Mike Day --- qemu-img.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index 04ce02a..1ad899e 100644 --- a/qemu-img.c +++ b/qemu-img.c @@ -70,11 +70,8 @@ static void add_format_to_seq(void *opaque, const char *fmt_name) { G

Re: [Qemu-devel] [PULL 03/17] qemu-img: sort block formats in help message

2014-05-14 Thread Mike Day
older glib but > it would be nice to eliminate duplicates later, too. I agree. I can submit an additional patch that uses an older API. What, exactly is the cause of duplicate entries in the list? I've only seen it one time but its disconcerting when it happens. Mike

Re: [Qemu-devel] [PATCH] qemu-img: sort block formats in help message

2014-05-14 Thread Mike Day
ly (this adds a new patch >on top the applies the reverse diff). > > In this case #1 seems like a good choice. I followed your advice and went with #1, I think its already been pulled. Mike

Re: [Qemu-devel] [PULL 03/17] qemu-img: sort block formats in help message

2014-05-14 Thread Mike Day
_iterate_format): > That makes sense, thanks for the background! Mike

Re: [Qemu-devel] [PATCH v2] qemu-img fails to delete last snapshot

2014-05-15 Thread Mike Day
Could not delete snapshot 'snapone': (Failed to remove snapshot from snapshot list: File too large) This is the error that is fixed by 65f33bc Mike

Re: [Qemu-devel] [PATCH] [v2 PATCH] qemu-img: sort block formats in help message

2014-05-16 Thread Mike Day
her reports of breakage. g_strcmp would be trivial to replace, of course. thanks! Mike

[Qemu-devel] [Bug 1307473] Re: guest hang due to missing clock interrupt

2014-07-15 Thread Mike Lowe
I need to amend comment #39, moving from 3.13.0-30 to 3.13.0-27 did not eliminate the problem. It would seem that it takes a couple of hours following a reboot for the symptoms to manifest with 3.13.0-27. -- You received this bug notification because you are a member of qemu- devel-ml, which is

[Qemu-devel] [PATCH] linux-user: fix readlink handling with magic exe symlink

2014-08-07 Thread Mike Frysinger
From: Mike Frysinger The current code always returns the length of the path when it should be returning the number of bytes it wrote to the output string. Further, readlink is not supposed to append a NUL byte, but the current snprintf logic will always do just that. Even further, if you pass

Re: [Qemu-devel] [PATCH] linux-user: fix readlink handling with magic exe symlink

2014-08-08 Thread Mike Frysinger
-user layer in QEMU implements the Linux syscall ABI, and all of my comments/code are geared towards that. hence, i'm closely implementing what Linux does (since that's what Linux C libraries rely on exactly), not what POSIX allows. -mike signature.asc Description: This is a digitally signed message part.

[Qemu-devel] [PATCH] configure: check for -Wendif-labels support

2011-05-17 Thread Mike Frysinger
Older gcc compilers do not support -Wendif-labels, so move it from the hardcoded list to the dynamically detected list. Signed-off-by: Mike Frysinger --- configure |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/configure b/configure index 019bc8d..8b775a4 100755

[Qemu-devel] [PATCH] ignore patch related files

2011-05-17 Thread Mike Frysinger
Signed-off-by: Mike Frysinger --- .gitignore |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/.gitignore b/.gitignore index 08013fc..e6557c3 100644 --- a/.gitignore +++ b/.gitignore @@ -58,6 +58,10 @@ QMP/qmp-commands.txt *.orig .pc patches +*.diff +*.patch +*.rej

[Qemu-devel] [PATCH] ignore more gdb related files

2011-05-17 Thread Mike Frysinger
Signed-off-by: Mike Frysinger --- .gitignore |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/.gitignore b/.gitignore index e6557c3..306baee 100644 --- a/.gitignore +++ b/.gitignore @@ -35,6 +35,8 @@ qemu-io qemu-monitor.texi QMP/qmp-commands.txt .gdbinit

[Qemu-devel] [PATCH] ignore new compiled vscclient tool

2011-05-17 Thread Mike Frysinger
Signed-off-by: Mike Frysinger --- .gitignore |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/.gitignore b/.gitignore index 306baee..e5a51f3 100644 --- a/.gitignore +++ b/.gitignore @@ -11,6 +11,7 @@ trace-dtrace.dtrace *-darwin-user *-linux-user *-bsd-user +libcacard

[Qemu-devel] [PATCH] linux-user: add pselect6 syscall support

2011-05-17 Thread Mike Frysinger
Some architectures (like Blackfin) only implement pselect6 (and skip select/newselect). So add support for it using existing newselect code. Signed-off-by: Mike Frysinger --- linux-user/syscall.c | 145 +++--- 1 files changed, 126 insertions(+), 19

[Qemu-devel] [PATCH v2] ignore patch related files

2011-05-17 Thread Mike Frysinger
Signed-off-by: Mike Frysinger --- v2 - drop *.orig as it has been merged already .gitignore |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/.gitignore b/.gitignore index 08013fc..790dc12 100644 --- a/.gitignore +++ b/.gitignore @@ -58,6 +58,9 @@ QMP/qmp

Re: [Qemu-devel] [PATCH] ignore patch related files

2011-05-17 Thread Mike Frysinger
On Tue, May 17, 2011 at 18:17, Peter Maydell wrote: > On 17 May 2011 22:10, Mike Frysinger wrote: >> --- a/.gitignore >> +++ b/.gitignore >> @@ -58,6 +58,10 @@ QMP/qmp-commands.txt >>  *.orig >>  .pc >>  patches >> +*.diff >> +*.patch >>

[Qemu-devel] Derivative snapshots or snapshots for versioning

2011-05-24 Thread Mike Young
tion: "qemu-img create ­f qcow2 ­b original_volume.img snapshot1.img", but now I wish to create a snapshot2 from snapshot1.img. Is there a way to do this? Also, is there a way to generate 100% snapshot of the original volume (an exact replica), so that a 40G original results in a 40G snapshot? Thanks, Mike

Re: [Qemu-devel] Derivative snapshots or snapshots for versioning

2011-05-25 Thread Mike Young
Thanks Stefan! On 5/25/11 1:21 AM, "Stefan Hajnoczi" wrote: >On Tue, May 24, 2011 at 5:14 PM, Mike Young >wrote: >> I'm trying to see if I can I do a derivative snapshot as a means of >> versioning. I wish to do this vs dd or cp as it's much faster. I do

Re: [Qemu-devel] [RFC]QEMU disk I/O limits

2011-05-31 Thread Mike Snitzer
merging taking place which can change the definition > >of IOPS as seen by guest? > > No, with qcow2, it may take multiple real IOPs for what the guest > sees as an IOP. > > That's really the main argument I'm making here. The only entity > that knows what a guest IOP corresponds to is QEMU. On the backend, > it may end up being a network request, multiple BIOs to physical > disks, file access, etc. Couldn't QEMU give a hint to the kernel about the ratio of guest IOP to real IOPs? Or is QEMU blind to the real IOPs that correspond to a guest IOP? If QEMU is trully blind to the amount of real IOPs then couldn't QEMU driven throttling cause physical resources to be oversubscribed (underestimating the backend work it is creating)? Mike

[Qemu-devel] [PATCH] Don't translate pointer when in restore_sigcontext

2011-05-31 Thread Mike McCormack
Fixes crash in i386 when user emulation base address is non-zero. 21797 rt_sigreturn(8,1082124603,1,0,1082126048,1082126248)Exit reason and status: signal 11 Signed-off-by: Mike McCormack --- linux-user/signal.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/linux

Re: [Qemu-devel] [PATCH] linux-user: add pselect6 syscall support

2011-06-03 Thread Mike Frysinger
On Fri, Jun 3, 2011 at 14:10, riku voipio wrote: > On 05/18/2011 03:14 AM, Mike Frysinger wrote: >> Some architectures (like Blackfin) only implement pselect6 (and skip >> select/newselect).  So add support for it using existing newselect code. > > There is a blackfin qemu

[Qemu-devel] [PATCH v2] linux-user: add pselect6 syscall support

2011-06-03 Thread Mike Frysinger
Some architectures (like Blackfin) only implement pselect6 (and skip select/newselect). So add support for it. Signed-off-by: Mike Frysinger --- v2 - handle null sigptr in a valid 6th sig struct linux-user/syscall.c | 149 +++-- 1 files

Re: [Qemu-devel] QEMU desired libiscsi.so clashes with libiscsi.so from iscsi-initiator-utils

2012-03-06 Thread Mike Christie
enaming my library if that is what it takes. >> > IMO the only sane option here is to have a separate package, > containing libiscsi _only_. > > It can be a sub-package of existing iscsi-related things, ie > contained within the existing open-iscsi _source_ repository. > &g

Re: [Qemu-devel] QEMU desired libiscsi.so clashes with libiscsi.so from iscsi-initiator-utils

2012-03-06 Thread Mike Christie
On 03/06/2012 01:58 PM, Mike Christie wrote: > On 03/06/2012 06:19 AM, Hannes Reinecke wrote: >> On 03/06/2012 12:06 PM, ronnie sahlberg wrote: >>> Sorry about this. >>> >>> First, libiscsi is a really good name for a general purpose >>> multiplatform l

Re: [Qemu-devel] QEMU desired libiscsi.so clashes with libiscsi.so from iscsi-initiator-utils

2012-03-06 Thread Mike Christie
On 03/06/2012 07:51 PM, ronnie sahlberg wrote: > Hi Mike, > > Thanks! > > That would be great if you rename it to something less generic and > specific to libiscsi-utils. > That means I can continue using libiscsi as the name for my > multiplatform library. > >

Re: [Qemu-devel] [PATCH] linux-user/syscall.c: Enforce pselect6 sigset size restrictions

2011-06-28 Thread Mike Frysinger
Acked-by: Mike Frysinger -mike signature.asc Description: This is a digitally signed message part.

[Qemu-devel] simulation paper with Blackfin and QEMU + GNU sim

2011-07-01 Thread Mike Frysinger
-sim.pdf then we presented it at OLS this year: http://docs.blackfin.uclinux.org/lib/exe/fetch.php?media=presentations:ols-2011-sim.odp -mike

[Qemu-devel] [Bug 807893] Re: qemu privilege escalation

2011-07-17 Thread Mike Cao
en fixed ald. Best Regards, Mike -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/807893 Title: qemu privilege escalation Status in QEMU: Confirmed Bug description: If qemu is started as ro

[Qemu-devel] [PATCH] vl: Fix compile issue with Werror option

2013-12-19 Thread Mike Qiu
uninitialized in this function [-Werror=maybe-uninitialized] len = strlen(bootpath) + 1; ^ cc1: all warnings being treated as errors make: *** [vl.o] Error 1 This patch is to solve this issue. Signed-off-by: Mike Qiu --- vl.c | 2 +- 1 file changed, 1 insertion

Re: [Qemu-devel] [RFC PATCH v2] PPC: smp: autodetect numbers of threads per core

2014-01-09 Thread Mike Day
threads = threads > 0 ? threads : 1; > +} > if (cpus == 0) { > cpus = cores * threads * sockets; > } -- Mike Day | "Endurance is a Virtue"

Re: [Qemu-devel] [RFC PATCH v2] PPC: smp: autodetect numbers of threads per core

2014-01-10 Thread Mike Day
3. machine_init - creates CPUs which may or may be not "host". The patch as it its now is very simple and well-contained. I wonder how much it would expand if we added a max thread count to the cpu class. It seems like the need for a max thread count is idiomatic to powerpc. Mike -- Mike Day | "Endurance is a Virtue"

Re: [Qemu-devel] [RFC PATCH v2] PPC: smp: autodetect numbers of threads per core

2014-01-10 Thread Mike Day
ax" is a more user-friendly option. In my understanding this is strictly a usability issue. Mike -- Mike Day | "Endurance is a Virtue"

Re: [Qemu-devel] [RFC PATCH v2] PPC: smp: autodetect numbers of threads per core

2014-01-10 Thread Mike Day
On Fri, Jan 10, 2014 at 9:13 AM, Alexey Kardashevskiy wrote: > On 01/11/2014 01:00 AM, Alexander Graf wrote: >> Can't we determine the number of "default threads" at a common place, >> preferably derived from cpu type? > > We can do anything. I asked how exactly as I really (really) do not > unde

Re: [Qemu-devel] [RFC PATCH v2] PPC: smp: autodetect numbers of threads per core

2014-01-10 Thread Mike Day
entual situation where each cpu type has several or more child classes to represent different configurations (threads, cores). That would be a lot more complicated than now. Mike

Re: [Qemu-devel] [PULL 14/28] exec: make address spaces 64-bit wide

2014-01-14 Thread Mike Day
and 64-bit BARs are required to be supported. It is legal to construct a 64-bit BAR by masking all the high bits to zero. Presumably it would be OK to mask the 16 high bits to zero as well, constructing a 48-bit address. Mike -- Mike Day | "Endurance is a Virtue"

Re: [Qemu-devel] [PULL 14/28] exec: make address spaces 64-bit wide

2014-01-14 Thread Mike Day
On Tue, Jan 14, 2014 at 9:05 AM, Michael S. Tsirkin wrote: > On Tue, Jan 14, 2014 at 08:50:54AM -0500, Mike Day wrote: >> >> Also, both 32-bit and 64-bit BARs are required to be supported. It is >> legal to construct a 64-bit BAR by masking all the high bits to >> zero

Re: [Qemu-devel] [PULL 14/28] exec: make address spaces 64-bit wide

2014-01-14 Thread Mike Day
ow bit clear is RAM. So the address above is RAM as was pointed out earlier in the thread. If you got an ambitious address in the future you could test the low bit. But MMIO is deprecated according to http://wiki.osdev.org/PCI so you probably won't see it, at least for 64-bit addresses. Mike

Re: [Qemu-devel] [PULL 14/28] exec: make address spaces 64-bit wide

2014-01-14 Thread Mike Day
On Tue, Jan 14, 2014 at 12:49 PM, Mike Day wrote: >>> > > >>>>>>> >>> > > >>>>>>>>> Prior to this change, there was no re-map with the >>> > > >>>>>>>>> febe >

Re: [Qemu-devel] [PULL 14/28] exec: make address spaces 64-bit wide

2014-01-14 Thread Mike Day
ated, or at least > discouraged, MMIO is not. Thanks, You're right, sorry I missed that. It doesn't solve the problem. Mike

Re: [Qemu-devel] [PATCH v2 01/14] spapr: populate DRC entries for root dt node

2014-01-20 Thread Mike Day
;s "-device" which is not > (yet) true for PHB but could be. Thanks. We discussed this approach (hot-plug the whole bus) during the design phase and at one point started to work on it. I don't think we established whether or not the Linux sys/bus/pci/* file system would work with it. Mike

Re: [Qemu-devel] [PULL 14/28] exec: make address spaces 64-bit wide

2014-01-20 Thread Mike Day
intx-mmap-timeout-ms before the device has a chance to finish restoring the correct value to the BAR? Mike

Re: [Qemu-devel] [PATCH v2 01/14] spapr: populate DRC entries for root dt node

2014-01-20 Thread Mike Day
On Mon, Jan 20, 2014 at 12:24 PM, Michael Roth wrote: > Quoting Alexey Kardashevskiy (2014-01-19 20:58:20) > > Would need to look at it a bit more closely to say for certain, but after > discussing it a bit Tyrel/Mike, I think the main considerations would be: > > 1) PHB hotplug

[Qemu-devel] [PATCH] [RFC] Convert Qemu Timer List and Active Timers to RCU

2014-02-12 Thread Mike Day
Allow readers to use RCU when reading Qemu timer lists. Applies to Paolo Bonzini's RCU branch, https://github.com/bonzini/qemu/tree/rcu. This patch is for comment and review only. The rcu branch needs to be rebased on upstream. Signed-off-by: Mike Day --- include/qemu/timer.h

Re: [Qemu-devel] [PATCH] [RFC] Convert Qemu Timer List and Active Timers to RCU

2014-02-13 Thread Mike Day
contention, it tries to reduce the cost of > synchronization primitives, especially the locking and unlocking of the list > around the invocation of timer callbacks. Yes, the assumption is that the active timers are a read-mostly list, so rcu is a win. Mike

Re: [Qemu-devel] [PATCH] [RFC] Convert Qemu Timer List and Active Timers to RCU

2014-02-15 Thread Mike Day
but you appear to have >introduced a rcu_read_lock() outside the loop, but then >unlock it within the loop. If the loop iterates more than once, >won't it do more unlocks than locks? Yes, I think the right fix is to omit the last rcu_read_unlock. -- Mike Day | "Endurance is a Virtue"

Re: [Qemu-devel] [PATCH] [RFC] Convert Qemu Timer List and Active Timers to RCU

2014-02-17 Thread Mike Day
to this yesterday. We still need the mutex here (active_timers_lock) to provide synchronization for list updates. The difference now is that we don't need to hold the mutex for traversing the list. But to update the list we still need to hold the mutex. Mike

[Qemu-devel] [PATCH 0/2] [RFC] Convert Clock lists to RCU (V2)

2014-02-27 Thread Mike Day
The first patch in the series convers the clock->timerlists->active_timers list to RCU. The second patch converts clock->timerlists to RCU and also protects access to timerlists->active_timers->timer_list. Mike Day (2): [RFC] Convert active timers list to use RCU V2 [RFC

[Qemu-devel] [PATCH 1/2] [RFC] Convert active timers list to use RCU V2

2014-02-27 Thread Mike Day
b.com/bonzini/qemu/tree/rcu V2: - Addresses comments from Alex Bligh Signed-off-by: Mike Day --- include/qemu/timer.h | 19 +++ qemu-timer.c | 69 ++-- 2 files changed, 44 insertions(+), 44 deletions(-) diff --git a/include/qemu/ti

[Qemu-devel] [PATCH 2/2] [RFC] Convert Clock Timerlists to RCU V2

2014-02-27 Thread Mike Day
anch: https://github.com/bonzini/qemu/tree/rcu and also requires the previously submitted patch 03fba95 "Convert active timers list to use RCU for read operations V2." V2: - timerlists modifications split to a separate patch (this one). - Addressed Alex Blighs comments. Signed-off-by: Mike Day -

Re: [Qemu-devel] [PATCH 2/2] [RFC] Convert Clock Timerlists to RCU V2

2014-03-03 Thread Mike Day
On Fri, Feb 28, 2014 at 3:05 PM, Alex Bligh wrote: >> Rather than introduce a second mutex for timerlists, which would >> require nested mutexes to in orderwrite to the timerlists, use one >> QemuMutex in the QemuClock structure for all write access to any list >> hanging off the QemuClock struct

Re: [Qemu-devel] [PATCH v7 1/2] target-ppc: add PowerPCCPU::cpu_dt_id

2014-03-03 Thread Mike Day
alized from @cpu_index by default and can be fixed later > to meet the device tree requirements. > > This adds an API to handle @cpu_dt_id. > > This removes kvmppc_fixup_cpu() as it is not more needed, @cpu_dt_id > is calculated in ppc_cpu_realize(). > > This will be used

Re: [Qemu-devel] [PATCH v7 2/2] target-ppc: spapr: e500: fix to use cpu_dt_id

2014-03-03 Thread Mike Day
s @cpu_index fixup as @cpu_dt_id is used instead so QEMU monitor > can accept command-line CPU indexes again. > > This changes kvm_arch_vcpu_id() to use ppc_get_vcpu_dt_id() as at the moment > KVM CPU id and device tree ID are calculated using the same algorithm. > Signed-off-by: Ale

Re: [Qemu-devel] [PATCH v3] virtio: Introduce virtio-testdev

2014-01-30 Thread Mike Day
fig space back to zero > 3) EXIT:exit() from qemu with a status code > +static uint32_t virtio_testdev_get_features(VirtIODevice *vdev, uint32_t f) > +{ > +return f; > +} > + Is this meant to be a stub currently? Mike -- Mike Day | "Endurance is a Virtue"

[Qemu-devel] [PATCH] A hexdump function that also displays UTF-8 strings contained in the dumped buffer.

2013-11-11 Thread Mike Day
69 62 36 64 6a 01 06 03 gb5dh...ib6dj... 0020: 6b 62 37 64 6c 01 07 03 6d 62 38 64 6e 01 08 03 kb7dl...mb8dn... 0030: 6f 62 39 64 70 01 09 03 71 62 78 64ob9dp...qbxd Signed-off-by: Mike Day --- include/qemu-common.h | 2 ++ util/hexdump.c| 48

[Qemu-devel] Curses enabled for Windows 32 binary

2013-11-12 Thread Mike Levin
@gmail.com if interested helping me with this project. Thanks. Mike Levin

Re: [Qemu-devel] [PATCH v6] spapr_hcall: add address-translation-mode-on-interrupt resource in H_SET_MODE

2014-04-15 Thread Mike Day
On Tue, Apr 8, 2014 at 2:28 AM, Alexander Graf wrote: > On 22.03.14 14:03, Alexey Kardashevskiy wrote: >> >> This adds handling of the RESOURCE_ADDR_TRANS_MODE resource from >> the H_SET_MODE, for POWER8 (PowerISA 2.07) only. >> >> Signed-off-by: Alexey Kardas

[Qemu-devel] [PATCH] virtfs-proxy-helper: fix call to accept

2014-04-19 Thread Mike Frysinger
From: Tim Comer The current code calls accept() without initializing the size parameter which means the accept call might write too much to the stack. URL: https://bugs.gentoo.org/486714 Signed-off-by: Tim Comer Signed-off-by: Mike Frysinger --- fsdev/virtfs-proxy-helper.c | 1 + 1 file

[Qemu-devel] Monitor Readline - no terminal echo after exit

2014-04-23 Thread Mike Day
look for this code? Otherwise I'll start looking through main_loop and friends and vl.c for init and destroy routines. Mike -- Mike Day | "Endurance is a Virtue"

Re: [Qemu-devel] Monitor Readline - no terminal echo after exit

2014-04-24 Thread Mike Day
ncluding the last line, at least in readline mode. I've run out of time looking at this today, but would but would be happy if anyone has further ideas. Mike

[Qemu-devel] [PATCH] -nographic sometimes adds an extra chardev for stdio

2014-04-28 Thread Mike Day
checking for the existing chardev before adding another. Signed-off-by: Mike Day --- To reproduce, use -mon and -nographic together. I was able to reproduce it using # qemu-system-x86_64 -enable-kvm -m 1G -chardev stdio,id=mon0 \ # -mon chardev=mon0,mode=readline -nographic --- vl.c | 22

Re: [Qemu-devel] [PATCH] -nographic sometimes adds an extra chardev for stdio

2014-04-28 Thread Mike Day
hink its ugly versus intrusive, but I'm not familiar with this part of qemu. There is another case with -monitor where you can configure two chardevs for stdio and it does the same thing. I left that one alone, its more complicated. Mike

Re: [Qemu-devel] [PATCH] -nographic sometimes adds an extra chardev for stdio

2014-04-29 Thread Mike Day
On Tue, Apr 29, 2014 at 3:09 AM, Gerd Hoffmann wrote: > > I don't feel like adding more band-aid to paper over the fundamental > issue. Too much band-aid tends to cause other unwanted side effects. Fair enough, I tend to agree. thanks for the review. Mike

Re: [Qemu-devel] [PATCH] -nographic sometimes adds an extra chardev for stdio

2014-04-29 Thread Mike Day
parts of qemu from fighting for stdio. That does seem to be a more fundamental solution. Thanks for the review. Mike

Re: [Qemu-devel] [PULL 14/16] qemu-img: Improve error messages

2014-04-30 Thread Mike Day
27;not found' case >> for help() to provide the "--help" option. >> > > Oops! Thanks for noticing this and sending the fix. One of you guys going to send in the trivial patch to restore help? (Or is it upstream in another patch?) thanks, Mike

Re: [Qemu-devel] [PULL 14/16] qemu-img: Improve error messages

2014-04-30 Thread Mike Day
block branch. Excellent, thank you! Mike

[Qemu-devel] [PATCH] qemu-img: sort block formats in help message

2014-05-02 Thread Mike Day
ind a specific format in the list. Signed-off-by: Mike Day --- qemu-img.c | 33 - 1 file changed, 32 insertions(+), 1 deletion(-) diff --git a/qemu-img.c b/qemu-img.c index 96f4463..d8b7ef4 100644 --- a/qemu-img.c +++ b/qemu-img.c @@ -32,6 +32,7 @@ #in

Re: [Qemu-devel] [PATCH] qemu-img: sort block formats in help message

2014-05-05 Thread Mike Day
cit > casts of void*. The casts are ugly, and I don't know how to get rid of them here beyond a pragma. Due to the block and glib APIs I have to cast away a const in the second parameter. I'm bracketed on both ends: g_sequence_* needs that second parameter to be void * (pointer), while the the block api (bdrv_iterate_format) defines the this function pointer type as (*)(void *, const char *). Ideas? Mike

[Qemu-devel] [PATCH] [v2 PATCH] qemu-img: sort block formats in help message

2014-05-05 Thread Mike Day
ind a specific format in the list. v2: Incorporated feedback from Stefan Hajnoczi Signed-off-by: Mike Day --- qemu-img.c | 27 --- 1 file changed, 24 insertions(+), 3 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index 96f4463..a559108 100644 --- a/qemu-img.c +++ b

Re: [Qemu-devel] [PATCH] Update QEMU checkpatch.pl to current linux version

2014-05-06 Thread Mike Day
formed email addresses. The other changes I believe, are either experimental or providing tools for filtering or typing messages. Mike

[Qemu-devel] Configure virtio-scsi options via libvirt

2014-05-06 Thread Mike Perez
Hi everyone, I would like be able to configure virtio-scsi options num_queues, max_sectors, and cmd_per_lun via libvirt. Are there any plans to have this support? -- Mike Perez

Re: [Qemu-devel] [PATCH 1/6] xics: add flags for interrupts

2014-05-07 Thread Mike Day
+#define XICS_FLAGS_MSI 0x2 (nit) typo in the above comment Mike -- Mike Day | "Endurance is a Virtue"

Re: [Qemu-devel] [PATCH 2/6] xics: add find_server

2014-05-07 Thread Mike Day
Alexey Kardashevskiy writes: > PAPR allows having multiple interrupr servers. > typo above in the commit log entry, Mike -- Mike Day | "Endurance is a Virtue"

Re: [Qemu-devel] [PATCH v4 2/3] qemu-timer: make qemu_timer_mod_ns() and qemu_timer_del() thread-safe

2013-10-07 Thread Mike Day
a >> sensible option. > > I agree. Keeping the write side on the BQL is sane, but RCU-protecting > the read side actually makes the rules simpler. > > Mike, would you like to give it a shot? Yes, I will. I'll have a patchset for review within a couple of days. Mike

[Qemu-devel] [RFC] SPAPR-PCI Hotplug Support in Qemu

2013-10-10 Thread Mike Day
phb_add_pci_dt https://github.com/mdroth/qemu/blob/spapr-pci-hotplug/hw/ppc/spapr_pci.c#L900 [4] dlpar_pci_add_bus http://git.kernel.org/cgit/linux/kernel/git/stable/linux-stable.git/tree/drivers/pci/hotplug/rpadlpar_core.c?id=8bf3379a74bc9132751bfa685bad2da318fd59d7#n165 -- Mike Day | + 1 919

Re: [Qemu-devel] [RFC] SPAPR-PCI Hotplug Support in Qemu

2013-10-10 Thread Mike Day
Adding Anthony's corrected address. On Thu, Oct 10, 2013 at 6:25 PM, Mike Day wrote: [RFC] SPAPR-PCI Hotplug Support in Qemu > > Background: > ppc64 has a unique bus structure for PCI slots: each slot is connected > to its PHB by a pci switch. This is true in some IBM ha

[Qemu-devel] [PATCH v2] net/net: Change the default mac address of nic

2013-10-14 Thread Mike Qiu
s bug. Signed-off-by: Mike Qiu --- net/net.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/net/net.c b/net/net.c index c330c9a..2796d04 100644 --- a/net/net.c +++ b/net/net.c @@ -21,6 +21,8 @@ * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALIN

[Qemu-devel] [PATCH] hmp: Add '\n' in monitor_printf()

2013-10-14 Thread Mike Qiu
not locked, tray closed There will be no additional lines between scsi0-hd0 scsi0-cd2, and break the info style. This patch is to solve this. Signed-off-by: Mike Qiu --- hmp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hmp.c b/hmp.c index 5891507..2d2e5f8 100644 --- a/h

[Qemu-devel] [PATCH v2] net/net: Change the default mac address of nic

2013-10-14 Thread Mike Qiu
hat each guest has one nic. In this situation, all the guest's nic has the same mac address. This patch is to solve this bug. Signed-off-by: Mike Qiu --- net/net.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/net/net.c b/net/net.c index c330c9a..9e72764 1006

[Qemu-devel] [PATCH v2] hmp: solve '\n' in monitor_printf()

2013-10-16 Thread Mike Qiu
s patch is to solve this. Signed-off-by: Mike Qiu --- hmp.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/hmp.c b/hmp.c index 5891507..32ee285 100644 --- a/hmp.c +++ b/hmp.c @@ -366,8 +366,6 @@ void hmp_info_block(Monitor *mon, const QDict *qdict)

Re: [Qemu-devel] [PATCH] usb-ohci: add vmstate descriptor

2014-03-06 Thread Mike Day
Alexey Kardashevskiy writes: > This adds migration support for OHCI. > > Signed-off-by: Alexey Kardashevskiy Reviewed-by: Mike Day > --- > hw/usb/hcd-ohci.c | 12 > 1 file changed, 12 insertions(+) > > diff --git a/hw/usb/hcd-ohci.c b/hw/usb/hcd-ohci.c

[Qemu-devel] [PATCH 0/2][RFC] Convert Clock lists to RCU (V3)

2014-03-06 Thread Mike Day
The first patch in the series converts the clock->timerlists->active_timers list to RCU. It also creates QemuMutex in the parent QemuClock data structure. The second patch converts clock->timerlists to RCU. Mike Day (2): [RFC] Convert active timers list to use RCU V3 [RFC] Conv

[Qemu-devel] [PATCH 1/2] [RFC] Convert active timers list to use RCU V3

2014-03-06 Thread Mike Day
ff-by: Mike Day --- include/qemu/timer.h | 19 + qemu-timer.c | 111 +-- 2 files changed, 72 insertions(+), 58 deletions(-) diff --git a/include/qemu/timer.h b/include/qemu/timer.h index 5afcffc..f69ec49 100644 --- a/include/qemu/ti

[Qemu-devel] [PATCH 2/2] [RFC] Convert Clock Timerlists to RCU V3

2014-03-06 Thread Mike Day
se RCU for read operations V3." V3: - timerlists modifications split to a separate patch (this one). - Addressed comments from Alex Bligh and Paolo Bonzini. Signed-off-by: Mike Day --- qemu-timer.c | 31 ++- 1 file changed, 26 insertions(+), 5 deletions(-) di

Re: [Qemu-devel] spapr-pci: convert init() callback to realize()

2014-03-12 Thread Mike Day
lize() does not "return" any value, instead it puts the extended > error into **errp. > > Signed-off-by: Alexey Kardashevskiy Reviewed-by: Mike Day > --- > Changes: > v5: > * finish_finalize() moved to a separate patch > --- > hw/ppc/spapr_pci.c | 44 ++

Re: [Qemu-devel] spapr-pci: convert init() callback to realize()

2014-03-12 Thread Mike Day
lize() does not "return" any value, instead it puts the extended > error into **errp. > > Signed-off-by: Alexey Kardashevskiy Reviewed-by: Mike Day > --- > Changes: > v5: > * finish_finalize() moved to a separate patch > --- > hw/ppc/spapr_pci.c | 44 ++

Re: [Qemu-devel] spapr-pci: introduce a finish_realize() callback

2014-03-12 Thread Mike Day
h_realize() > call at the end of the spapr_finalize(). > > Signed-off-by: Alexey Kardashevskiy Reviewed-by: Mike Day > --- > Changes: > v5: > * this is a new patch in the series, it was a part of a previous patch > --- > hw/ppc/spapr_pci.c | 46 > +++

Re: [Qemu-devel] spapr-pci: converts fprintf to error_report

2014-03-12 Thread Mike Day
On 21/11/13 15:08 +1100, Alexey Kardashevskiy wrote: > Signed-off-by: Alexey Kardashevskiy Reviewed-by: Mike Day > --- > hw/ppc/spapr_pci.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/hw/ppc/spapr_pci.c b/hw/ppc/spapr_pci.c > index 96

Re: [Qemu-devel] spapr-iommu: extend SPAPR_TCE_TABLE class

2014-03-13 Thread Mike Day
his reworks the H_PUT_TCE handler to make use of the new put_tce() > callback. > > Signed-off-by: Alexey Kardashevskiy Reviewed-by: Mike Day > --- > hw/ppc/spapr_iommu.c | 21 + > include/hw/ppc/spapr.h | 13 + > 2 files changed, 30 insertions(

Re: [Qemu-devel] qemu patch for adding functionality to rtas_ibm_get_system_parameter

2014-03-13 Thread Mike Day
above. You should be able to fix these issues quickly and resubmit this patch. Mike Tomohiro B Berry writes: > Hi all, > > rtas_ibm_get_system_parameter did not previously have the functionality to > return the appropriate string when called with the > SPLPAR_CHARACTERISTI

Re: [Qemu-devel] qemu patch for adding functionality to rtas_ibm_get_system_parameter [Version 2]

2014-03-14 Thread Mike Day
ave..." is an example of the type of text that shouldn't be in the commit log. There is still a line wrap - If you are not doing so consider running your patch through scripts/chechpatch.pl before submitting it. Also consider using git-format-patch to generate the patch you will send if yo

Re: [Qemu-devel] [PATCH v5 3/3] spapr_hcall: add address-translation-mode-on-interrupt resource in H_SET_MODE

2014-03-20 Thread Mike Day
Alexey Kardashevskiy writes: > This adds handling of the RESOURCE_ADDR_TRANS_MODE resource from > the H_SET_MODE, for POWER8 (PowerISA 2.07) only. > > Signed-off-by: Alexey Kardashevskiy Reviewed-by: Mike Day > --- > hw/ppc/spapr_hcall.c | 26 ++ &

[Qemu-devel] [Bug 1368815] Re: qemu-img convert intermittently corrupts output images

2015-01-26 Thread Mike Perez
** Changed in: cinder Status: In Progress => Triaged ** Changed in: cinder Assignee: Tony Breeds (o-tony) => (unassigned) -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1368815 Title: q

[Qemu-devel] [Bug 1385934] Re: USB with passthrougth guest cannot enumerate USB host

2014-12-30 Thread Mike Frysinger
looks like 79ae25af1569a50a0ec799901a1bb280c088f121 (which is in qemu-2.2.0) makes it work again for my test case. not sure if the OP wants to verify as well or just close this out now. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

Re: [Qemu-devel] virtio_blk: fix defaults for max_hw_sectors and max_segment_size

2014-11-21 Thread Mike Snitzer
On Fri, Nov 21 2014 at 4:54am -0500, Christoph Hellwig wrote: > On Thu, Nov 20, 2014 at 02:00:59PM -0500, Mike Snitzer wrote: > > virtio_blk incorrectly established -1U as the default for these > > queue_limits. Set these limits to sane default values to avoid crashing > >

Re: [Qemu-devel] virtio_blk: fix defaults for max_hw_sectors and max_segment_size

2014-11-26 Thread Mike Snitzer
On Wed, Nov 26 2014 at 2:48pm -0500, Jens Axboe wrote: > On 11/21/2014 08:49 AM, Mike Snitzer wrote: > > On Fri, Nov 21 2014 at 4:54am -0500, > > Christoph Hellwig wrote: > > > >> On Thu, Nov 20, 2014 at 02:00:59PM -0500, Mike Snitzer wrote: > >>>

Re: [Qemu-devel] virtio_blk: fix defaults for max_hw_sectors and max_segment_size

2014-11-26 Thread Mike Snitzer
On Wed, Nov 26 2014 at 3:54pm -0500, Jens Axboe wrote: > On 11/26/2014 01:51 PM, Mike Snitzer wrote: > > On Wed, Nov 26 2014 at 2:48pm -0500, > > Jens Axboe wrote: > > > >> > >> That code isn't even in mainline, as far as I can tell... > >

Re: [Qemu-devel] virtio_blk: fix defaults for max_hw_sectors and max_segment_size

2014-11-26 Thread Mike Snitzer
On Wed, Nov 26 2014 at 4:53pm -0500, Jens Axboe wrote: > On 11/26/2014 02:51 PM, Mike Snitzer wrote: > > > > But while you're here, I wouldn't mind getting your take on virtio-blk > > setting max_hw_sectors to -1U. > > > > As I said in my original

[Qemu-devel] [PATCH] scripts/qemu-binfmt-conf.sh: rewrite to make user friendly & easier to maintain

2014-06-05 Thread Mike Frysinger
people can easily run it and integrate into their system, and make it easier for CPU maintainers to add new targets. There's also a few fixes smattered about, but considering the whole file has been written from scratch, not sure they need splitting out. Signed-off-by: Mike Frysinger --- scri

<    1   2   3   4   5   6   7   8   9   10   >