Carvalho Chehab;
Co-authored-by: Jonathan Cameron
Co-authored-by: Shiju Jose
Co-authored-by: Mauro Carvalho Chehab
Signed-off-by: Jonathan Cameron
Signed-off-by: Shiju Jose
Signed-off-by: Mauro Carvalho Chehab
Acked-by: Igor Mammedov
Acked-by: Markus Armbruster
---
MAINTAINERS
Move the check logic into a common function and simplify the
code which checks if GHES is enabled and was properly setup.
Signed-off-by: Mauro Carvalho Chehab
Reviewed-by: Jonathan Cameron
Reviewed-by: Igor Mammedov
---
hw/acpi/ghes-stub.c| 7 ---
hw/acpi/ghes.c | 38
errors to
the guest via ACPI APEI Generic Hardware Error Source (GHES).
Co-authored-by: Mauro Carvalho Chehab
Co-authored-by: Jonathan Cameron
Signed-off-by: Jonathan Cameron
Signed-off-by: Mauro Carvalho Chehab
Reviewed-by: Igor Mammedov
---
hw/acpi/aml-build.c| 10
The GHES migration logic should now support HEST table location too.
Signed-off-by: Mauro Carvalho Chehab
Reviewed-by: Jonathan Cameron
Reviewed-by: Igor Mammedov
---
hw/acpi/generic_event_device.c | 29 +
1 file changed, 29 insertions(+)
diff --git a/hw/acpi
Em Fri, 28 Feb 2025 17:33:18 +0800
Jonathan Cameron escreveu:
> On Thu, 27 Feb 2025 17:00:55 +0100
> Mauro Carvalho Chehab wrote:
>
> > - The HEST table now accept two sources;
> > - The DSDT tables now have a GED error device.
> >
> > @@ -1,39 +1,39 @@
>
B)
{
Name (_HID, "PNP0C0C" /* Power Button Device */) // _HID:
Hardware ID
Name (_UID, Zero) // _UID: Unique ID
}
+
+Device (GEDD)
+{
+Name (_HID, "PNP0C33" /* Error Device */) // _HID: Hardware ID
+
Create a new property (x-has-hest-addr) and use it to detect if
the GHES table offsets can be calculated from the HEST address
(qemu 10.0 and upper) or via the legacy way via an offset obtained
from the hardware_errors firmware file.
Signed-off-by: Mauro Carvalho Chehab
Reviewed-by: Jonathan
We'll be adding a new GED device for HEST GPIO notification and
increasing the number of entries at the HEST table.
Blocklist testing HEST and DSDT tables until such changes
are completed.
Signed-off-by: Mauro Carvalho Chehab
Acked-by: Igor Mammedov
Reviewed-by: Jonathan Cameron
---
Such script allows customizing the error data, allowing to change
all fields at the record. Please use:
$ ghes_inject.py arm -h
For more details about its usage.
Signed-off-by: Mauro Carvalho Chehab
Reviewed-by: Jonathan Cameron
---
MAINTAINERS| 3 +
scripts
Some error injection notify methods are async, like GPIO
notify. Add a notifier to be used when the error record is
ready to be sent to the guest OS.
Signed-off-by: Mauro Carvalho Chehab
Reviewed-by: Jonathan Cameron
Acked-by: Igor Mammedov
---
hw/acpi/ghes.c | 5 -
include/hw
Adds support to ARM virtualization to allow handling
generic error ACPI Event via GED & error source device.
It is aligned with Linux Kernel patch:
https://lore.kernel.org/lkml/1272350481-27951-8-git-send-email-ying.hu...@intel.com/
Co-authored-by: Mauro Carvalho Chehab
Co-authored-by: Jona
The GHES migration logic should now support HEST table location too.
Signed-off-by: Mauro Carvalho Chehab
Reviewed-by: Jonathan Cameron
Reviewed-by: Igor Mammedov
---
hw/acpi/generic_event_device.c | 29 +
1 file changed, 29 insertions(+)
diff --git a/hw/acpi
Now that we have everything in place, enable using HEST GPA
instead of etc/hardware_errors GPA.
Signed-off-by: Mauro Carvalho Chehab
Reviewed-by: Jonathan Cameron
Reviewed-by: Igor Mammedov
---
hw/acpi/generic_event_device.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a
errors to
the guest via ACPI APEI Generic Hardware Error Source (GHES).
Co-authored-by: Mauro Carvalho Chehab
Co-authored-by: Jonathan Cameron
Signed-off-by: Jonathan Cameron
Signed-off-by: Mauro Carvalho Chehab
Reviewed-by: Igor Mammedov
---
hw/acpi/aml-build.c| 10
B)
{
Name (_HID, "PNP0C0C" /* Power Button Device */) // _HID:
Hardware ID
Name (_UID, Zero) // _UID: Unique ID
}
+
+Device (GEDD)
+{
+Name (_HID, "PNP0C33" /* Error Device */) // _HID: Hardware ID
+
Move the check logic into a common function and simplify the
code which checks if GHES is enabled and was properly setup.
Signed-off-by: Mauro Carvalho Chehab
Reviewed-by: Jonathan Cameron
Reviewed-by: Igor Mammedov
---
hw/acpi/ghes-stub.c| 7 ---
hw/acpi/ghes.c | 38
igned-off-by: Mauro Carvalho Chehab
---
hw/acpi/ghes.c | 6 --
include/hw/acpi/ghes.h | 2 ++
2 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/hw/acpi/ghes.c b/hw/acpi/ghes.c
index b85bb48195a0..b709c177cdea 100644
--- a/hw/acpi/ghes.c
+++ b/hw/acpi/ghes.c
@@ -390,8 +
While the HEST layout didn't change, there are some internal
changes related to how offsets are calculated and how memory error
events are triggered.
Update specs to reflect such changes.
Signed-off-by: Mauro Carvalho Chehab
Reviewed-by: Jonathan Cameron
Reviewed-by: Igor Mammedov
---
the same time, change the logic to be more flexible,
allowing the number of sources to be defined when building the
HEST table by the caller.
Signed-off-by: Mauro Carvalho Chehab
Reviewed-by: Jonathan Cameron
Reviewed-by: Igor Mammedov
---
hw/acpi/ghes.c | 39
Currently, aarch64 can generate a HEST table when loaded with
-machine ras=on. Add support for it.
Signed-off-by: Mauro Carvalho Chehab
Reviewed-by: Igor Mammedov
Reviewed-by: Jonathan Cameron
---
tests/qtest/bios-tables-test.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
block structures.
Yet, keep the old code, as this is needed for migration purposes
from older QEMU versions.
Signed-off-by: Mauro Carvalho Chehab
Reviewed-by: Jonathan Cameron
Reviewed-by: Igor Mammedov
---
hw/acpi/ghes.c | 100 +
include/hw/acpi
replicates what OSPM does.
As the next patches will be adding a more generic logic, add a
new use_hest_addr, set to false, in preparation for such changes.
Signed-off-by: Mauro Carvalho Chehab
Reviewed-by: Jonathan Cameron
Reviewed-by: Igor Mammedov
---
hw/acpi/ghes.c | 39
Carvalho Chehab;
Co-authored-by: Jonathan Cameron
Co-authored-by: Shiju Jose
Co-authored-by: Mauro Carvalho Chehab
Signed-off-by: Jonathan Cameron
Signed-off-by: Shiju Jose
Signed-off-by: Mauro Carvalho Chehab
Acked-by: Igor Mammedov
Acked-by: Markus Armbruster
---
MAINTAINERS
Such file will be used to track HEST table changes.
For now, disallow HEST table check until we update it to the
current data.
Signed-off-by: Mauro Carvalho Chehab
Acked-by: Igor Mammedov
Reviewed-by: Jonathan Cameron
---
tests/data/acpi/aarch64/virt/HEST | 0
tests/qtest/bios
Create a new property (x-has-hest-addr) and use it to detect if
the GHES table offsets can be calculated from the HEST address
(qemu 10.0 and upper) or via the legacy way via an offset obtained
from the hardware_errors firmware file.
Signed-off-by: Mauro Carvalho Chehab
Reviewed-by: Jonathan
Now that HEST table is checked for aarch64, add the current
firmware file.
Signed-off-by: Mauro Carvalho Chehab
Acked-by: Igor Mammedov
Reviewed-by: Jonathan Cameron
---
tests/data/acpi/aarch64/virt/HEST | Bin 0 -> 132 bytes
tests/qtest/bios-tables-test-allowed-diff.h | 1 -
We'll be adding a new GED device for HEST GPIO notification and
increasing the number of entries at the HEST table.
Blocklist testing HEST and DSDT tables until such changes
are completed.
Signed-off-by: Mauro Carvalho Chehab
Acked-by: Igor Mammedov
Reviewed-by: Jonathan Cameron
---
Store HEST table address at GPA, placing its the start of the table at
hest_addr_le variable.
Signed-off-by: Mauro Carvalho Chehab
Reviewed-by: Jonathan Cameron
Reviewed-by: Igor Mammedov
---
hw/acpi/ghes.c | 22 --
include/hw/acpi/ghes.h | 6 +-
2 files
Such script allows customizing the error data, allowing to change
all fields at the record. Please use:
$ ghes_inject.py arm -h
For more details about its usage.
Signed-off-by: Mauro Carvalho Chehab
Reviewed-by: Jonathan Cameron
---
MAINTAINERS| 3 +
scripts
from
whitelist and updating/adding such tables to tests/data/acpi)
Mauro Carvalho Chehab (20):
tests/acpi: virt: add an empty HEST file
tests/qtest/bios-tables-test: extend to also check HEST table
tests/acpi: virt: update HEST file with its current data
Revert "hw/acpi/ghes: Make ghes_
Hi Phillipe,
Em Fri, 7 Mar 2025 22:05:27 +0100
Philippe Mathieu-Daudé escreveu:
> Hi Mauro,
>
> On 7/3/25 20:14, Mauro Carvalho Chehab wrote:
> > Using the QMP GHESv2 API requires preparing a raw data array
> > containing a CPER record.
> >
> > Add a helper s
Signed-off-by: Mauro Carvalho Chehab
---
hw/i386/acpi-build.c | 42 ++
hw/i386/pc.c | 7 +++
include/hw/i386/x86.h | 2 ++
3 files changed, 47 insertions(+), 4 deletions(-)
diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c
index
plug logic there
may not initialize ags during acpi table build time.
Signed-off-by: Mauro Carvalho Chehab
---
hw/acpi/ghes.c | 16
hw/arm/virt-acpi-build.c | 12
include/hw/acpi/ghes.h | 25 +
3 files changed, 29 insertions(+), 24
proving it further.
It can be tested with:
$ ./scripts/ghes_inject.py arm
(Ok, this would be generating an ARM processor event , but
I guess Linux would at least mark the event as read, even if
it doesn't recognize it)
Mauro Carvalho Chehab (3):
acpi/ghes: move use_hest_addr out of
::-:22 \
-qmp tcp:localhost:4445,server=on,wait=off \
-append 'earlycon nomodeset root=/dev/vda1 fsck.mode=skip tp_printk
maxcpus=4 console=ttyS0 console=tty0'
TODO: add a notifier logic.
Signed-off-by: Mauro Carvalho Chehab
---
hw/i386/Kconfig | 1 +
hw/i386/ac
Em Wed, 5 Mar 2025 02:21:26 +0100
Philippe Mathieu-Daudé escreveu:
> From: Gavin Shan
>
> acpi_ghes_memory_errors() is the only caller, no need to expose
> the function. Besides, the last 'return' in this function isn't
> necessary and remove it.
>
> No functional changes intended.
Please re
Em Wed, 26 Feb 2025 16:52:26 +0100
Igor Mammedov escreveu:
> On Fri, 21 Feb 2025 15:35:17 +0100
> Mauro Carvalho Chehab wrote:
>
> > diff --git a/hw/acpi/generic_event_device.c b/hw/acpi/generic_event_device.c
> > index 5346cae573b7..14d8513a5440 100
Em Thu, 27 Feb 2025 08:19:27 +0100
Mauro Carvalho Chehab escreveu:
> Em Wed, 26 Feb 2025 16:52:26 +0100
> Igor Mammedov escreveu:
>
> > On Fri, 21 Feb 2025 15:35:17 +0100
> > Mauro Carvalho Chehab wrote:
> >
>
> > > diff --git a/hw/acpi/
Em Thu, 27 Feb 2025 10:22:55 +0100
Igor Mammedov escreveu:
> On Wed, 26 Feb 2025 17:14:06 +0100
> Mauro Carvalho Chehab wrote:
>
> > Em Tue, 25 Feb 2025 10:43:27 +0100
> > Igor Mammedov escreveu:
> >
> > > On Fri, 21 Feb 2025 07:02:21 +010
Em Thu, 27 Feb 2025 14:30:28 +0100
Igor Mammedov escreveu:
> On Thu, 27 Feb 2025 12:03:30 +0100
> Mauro Carvalho Chehab wrote:
>
> > Now that the ghes preparation patches were merged, let's add support
> > for error injection.
> >
> > On this versio
Em Thu, 27 Feb 2025 14:16:03 +0100
Igor Mammedov escreveu:
> On Thu, 27 Feb 2025 14:10:38 +0100
> Igor Mammedov wrote:
>
> > On Thu, 27 Feb 2025 12:03:47 +0100
> > Mauro Carvalho Chehab wrote:
> >
> > squash this patch into the next one
> >
> >
Em Thu, 27 Feb 2025 16:51:24 +0100
Mauro Carvalho Chehab escreveu:
> Em Thu, 27 Feb 2025 14:16:03 +0100
> Igor Mammedov escreveu:
>
> > On Thu, 27 Feb 2025 14:10:38 +0100
> > Igor Mammedov wrote:
> >
> > > On Thu, 27 Feb 2025 12:03:47 +010
the same time, change the logic to be more flexible,
allowing the number of sources to be defined when building the
HEST table by the caller.
Signed-off-by: Mauro Carvalho Chehab
Reviewed-by: Jonathan Cameron
Reviewed-by: Igor Mammedov
---
hw/acpi/ghes.c | 39
Adds support to ARM virtualization to allow handling
generic error ACPI Event via GED & error source device.
It is aligned with Linux Kernel patch:
https://lore.kernel.org/lkml/1272350481-27951-8-git-send-email-ying.hu...@intel.com/
Co-authored-by: Mauro Carvalho Chehab
Co-authored-by: Jona
Carvalho Chehab;
Co-authored-by: Jonathan Cameron
Co-authored-by: Shiju Jose
Co-authored-by: Mauro Carvalho Chehab
Signed-off-by: Jonathan Cameron
Signed-off-by: Shiju Jose
Signed-off-by: Mauro Carvalho Chehab
Acked-by: Igor Mammedov
Acked-by: Markus Armbruster
---
MAINTAINERS
Currently, aarch64 can generate a HEST table when loaded with
-machine ras=on. Add support for it.
Signed-off-by: Mauro Carvalho Chehab
Reviewed-by: Igor Mammedov
---
tests/qtest/bios-tables-test.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/qtest/bios-tables
Some error injection notify methods are async, like GPIO
notify. Add a notifier to be used when the error record is
ready to be sent to the guest OS.
Signed-off-by: Mauro Carvalho Chehab
Reviewed-by: Jonathan Cameron
---
hw/acpi/ghes.c | 5 -
include/hw/acpi/ghes.h | 3 +++
2 files
Now that we have everything in place, enable using HEST GPA
instead of etc/hardware_errors GPA.
Signed-off-by: Mauro Carvalho Chehab
---
hw/acpi/generic_event_device.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/acpi/generic_event_device.c b/hw/acpi
Such script allows customizing the error data, allowing to change
all fields at the record. Please use:
$ ghes_inject.py arm -h
For more details about its usage.
Signed-off-by: Mauro Carvalho Chehab
Reviewed-by: Jonathan Cameron
---
MAINTAINERS| 3 +
scripts
Store HEST table address at GPA, placing its the start of the table at
hest_addr_le variable.
Signed-off-by: Mauro Carvalho Chehab
Reviewed-by: Jonathan Cameron
Reviewed-by: Igor Mammedov
---
hw/acpi/ghes.c | 22 --
include/hw/acpi/ghes.h | 6 +-
2 files
ce (GEDD)
+{
+Name (_HID, "PNP0C33" /* Error Device */) // _HID: Hardware ID
+Name (_UID, Zero) // _UID: Unique ID
+}
}
}
Signed-off-by: Mauro Carvalho Chehab
Reviewed-by: Jonathan Cameron
---
tests/data/acpi/aarch64/virt/DSDT | Bin 5196 -> 5240
Move the check logic into a common function and simplify the
code which checks if GHES is enabled and was properly setup.
Signed-off-by: Mauro Carvalho Chehab
Reviewed-by: Jonathan Cameron
Reviewed-by: Igor Mammedov
---
hw/acpi/ghes-stub.c| 7 ---
hw/acpi/ghes.c | 38
Now that HEST table is checked for aarch64, add the current
firmware file.
Signed-off-by: Mauro Carvalho Chehab
Acked-by: Igor Mammedov
---
tests/data/acpi/aarch64/virt/HEST | Bin 0 -> 132 bytes
tests/qtest/bios-tables-test-allowed-diff.h | 1 -
2 files changed, 1 delet
The GHES migration logic should now support HEST table location too.
Signed-off-by: Mauro Carvalho Chehab
Reviewed-by: Jonathan Cameron
Reviewed-by: Igor Mammedov
---
hw/acpi/generic_event_device.c | 29 +
1 file changed, 29 insertions(+)
diff --git a/hw/acpi
Such file will be used to track HEST table changes.
For now, disallow HEST table check until we update it to the
current data.
Signed-off-by: Mauro Carvalho Chehab
Acked-by: Igor Mammedov
---
tests/data/acpi/aarch64/virt/HEST | 0
tests/qtest/bios-tables-test-allowed-diff.h | 1 +
2
Create a new property (x-has-hest-addr) and use it to detect if
the GHES table offsets can be calculated from the HEST address
(qemu 10.0 and upper) or via the legacy way via an offset obtained
from the hardware_errors firmware file.
Signed-off-by: Mauro Carvalho Chehab
Reviewed-by: Jonathan
errors to
the guest via ACPI APEI Generic Hardware Error Source (GHES).
Co-authored-by: Mauro Carvalho Chehab
Co-authored-by: Jonathan Cameron
Signed-off-by: Jonathan Cameron
Signed-off-by: Mauro Carvalho Chehab
Reviewed-by: Igor Mammedov
---
hw/acpi/aml-build.c| 10
While the HEST layout didn't change, there are some internal
changes related to how offsets are calculated and how memory error
events are triggered.
Update specs to reflect such changes.
Signed-off-by: Mauro Carvalho Chehab
---
docs/specs/acpi_hest_ghes.rst
block structures.
Yet, keep the old code, as this is needed for migration purposes
from older QEMU versions.
Signed-off-by: Mauro Carvalho Chehab
Reviewed-by: Jonathan Cameron
Reviewed-by: Igor Mammedov
---
hw/acpi/ghes.c | 100 +
include/hw/acpi
replicates what OSPM does.
As the next patches will be adding a more generic logic, add a
new use_hest_addr, set to false, in preparation for such changes.
Signed-off-by: Mauro Carvalho Chehab
---
hw/acpi/ghes.c | 39 ---
hw/arm/virt-acpi-build.c
d one removing from
whitelist and updating/adding such tables to tests/data/acpi)
Mauro Carvalho Chehab (19):
tests/acpi: virt: add an empty HEST file
tests/qtest/bios-tables-test: extend to also check HEST table
tests/acpi: virt: update HEST file with its current data
acpi/ghes: Cleanu
We'll be adding a new GED device for HEST GPIO notification and
increasing the number of entries at the HEST table.
Blocklist testing HEST and DSDT tables until such changes
are completed.
Signed-off-by: Mauro Carvalho Chehab
Acked-by: Igor Mammedov
---
tests/qtest/bios-tables-test-al
Hi Michael,
Gentile ping.
Regards,
Mauro
Em Fri, 7 Mar 2025 20:14:29 +0100
Mauro Carvalho Chehab escreveu:
> Hi Michael,
>
> I'm sending v8 to avoid a merge conflict with v7 due to this
> changeset:
>
>611f3bdb20f7 ("hw/acpi/ghes: Make static")
>
501 - 563 of 563 matches
Mail list logo
