Re: [PATCH 1/4] MAINTAINERS: drop audio maintainership

2024-05-27 Thread Matias Ezequiel Vara Larsen
On Thu, May 16, 2024 at 02:03:38PM +0200, Gerd Hoffmann wrote: > Remove myself from audio (both devices and backend) entries. > Flip status to "Orphan" for entries which have nobody else listed. > > Signed-off-by: Gerd Hoffmann > --- > MAINTAINERS | 19 --- > 1 file changed, 4 in

Re: [PATCH v9 00/12] Add VIRTIO sound card

2023-09-25 Thread Matias Ezequiel Vara Larsen
On Thu, Sep 14, 2023 at 12:24:13PM +0200, Stefano Garzarella wrote: > On Thu, Sep 14, 2023 at 01:02:05PM +0300, Manos Pitsidianakis wrote: > > On Thu, 14 Sep 2023 12:54, Stefano Garzarella wrote: > > > We are seeing something strange with the virtio-sound Linux driver. > > > It seems that the driv

Re: [PATCH v3 07/20] virtio: add vhost-user-base and a generic vhost-user-device

2023-09-05 Thread Matias Ezequiel Vara Larsen
On Mon, Jul 10, 2023 at 04:35:09PM +0100, Alex Bennée wrote: > In theory we shouldn't need to repeat so much boilerplate to support > vhost-user backends. This provides a generic vhost-user-base QOM > object and a derived vhost-user-device for which the user needs to > provide the few bits of infor

Re: [PATCH v8 00/12] Add VIRTIO sound card

2023-09-06 Thread Matias Ezequiel Vara Larsen
On Mon, Aug 28, 2023 at 10:54:57PM +0300, Emmanouil Pitsidianakis wrote: > This patch series adds an audio device implementing the recent virtio > sound spec (1.2) and a corresponding PCI wrapper device. > > v8 can be found online at: > > https://gitlab.com/epilys/qemu/-/tree/virtio-snd-v8 > He

Re: [PATCH v3 07/20] virtio: add vhost-user-base and a generic vhost-user-device

2023-09-06 Thread Matias Ezequiel Vara Larsen
On Tue, Sep 05, 2023 at 06:01:56PM +0100, Alex Bennée wrote: > > Matias Ezequiel Vara Larsen writes: > > > On Mon, Jul 10, 2023 at 04:35:09PM +0100, Alex Bennée wrote: > >> In theory we shouldn't need to repeat so much boilerplate to support > >> vhost-

Re: [PATCH v1 1/1] virtio-snd: add max size bounds check in input cb

2024-07-09 Thread Matias Ezequiel Vara Larsen
Thanks Manos for sending this, On Mon, Jul 08, 2024 at 10:09:49AM +0300, Manos Pitsidianakis wrote: > When reading input audio in the virtio-snd input callback, > virtio_snd_pcm_in_cb(), we do not check whether the iov can actually fit > the data buffer. This is because we use the buffer->size fie

Re: [PATCH] virtio: Always reset vhost devices

2024-07-10 Thread Matias Ezequiel Vara Larsen
Hello Hanna, On Wed, Jul 10, 2024 at 01:23:10PM +0200, Hanna Czenczek wrote: > Requiring `vhost_started` to be true for resetting vhost devices in > `virtio_reset()` seems like the wrong condition: Most importantly, the > preceding `virtio_set_status(vdev, 0)` call will (for vhost devices) end > u

Re: Call for GSoC internship project ideas

2025-02-06 Thread Matias Ezequiel Vara Larsen
On Tue, Jan 28, 2025 at 11:16:43AM -0500, Stefan Hajnoczi wrote: > Dear QEMU and KVM communities, > QEMU will apply for the Google Summer of Code internship > program again this year. Regular contributors can submit project > ideas that they'd like to mentor by replying to this email by > February

Re: Call for GSoC internship project ideas

2025-02-07 Thread Matias Ezequiel Vara Larsen
On Thu, Feb 06, 2025 at 10:10:54AM -0500, Stefan Hajnoczi wrote: > I have added your project idea to the wiki. Please make further > changes directly on the wiki. > > https://wiki.qemu.org/Google_Summer_of_Code_2025#Adding_Kani_proofs_for_Virtqueues_in_Rust-vmm > > Thanks, > Stefan > Thanks, M

Re: Call for GSoC internship project ideas

2025-02-07 Thread Matias Ezequiel Vara Larsen
On Thu, Feb 06, 2025 at 10:02:43AM -0500, Stefan Hajnoczi wrote: > On Thu, Feb 6, 2025 at 4:34 AM Matias Ezequiel Vara Larsen > wrote: > > === Adding Kani proofs for Virtqueues in Rust-vmm === > > > > '''Summary:''' Verify conformance of the

[PATCH] vhost-user-snd: Use virtio_get_config_size()

2025-02-13 Thread Matias Ezequiel Vara Larsen
`control` is added to the virtio_snd_config structure. This breaks vhost-user-device backends that do not implement the `controls` field. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2805 Suggested-by: Stefano Garzarella Signed-off-by: Matias Ezequiel Vara Larsen --- hw/virtio/vhost-user

Re: [PATCH] vhost-user-snd: Use virtio_get_config_size()

2025-02-14 Thread Matias Ezequiel Vara Larsen
On Thu, Feb 13, 2025 at 05:22:22PM +0100, Stefano Garzarella wrote: > On Thu, 13 Feb 2025 at 16:43, Stefano Garzarella wrote: > > > > Unrelated to this patch, but since we are talking about > > VIRTIO_SND_F_CTLS, I think it would be good to send a patch to Linux to > > make it clear that `controls

Re: [PATCH] vhost-user-snd: Use virtio_get_config_size()

2025-02-14 Thread Matias Ezequiel Vara Larsen
2025 at 02:25:13PM +0100, Matias Ezequiel Vara Larsen wrote: > > Use virtio_get_config_size() rather than sizeof(struct > > virtio_snd_config) for the config_size in the vhost-user-snd frontend. > > The frontend shall rely on device features for the size of the device > > config

Re: [PATCH] vhost-user-snd: Use virtio_get_config_size()

2025-02-14 Thread Matias Ezequiel Vara Larsen
On Thu, Feb 13, 2025 at 04:07:47PM +0100, Philippe Mathieu-Daudé wrote: > On 13/2/25 14:25, Matias Ezequiel Vara Larsen wrote: > > Use virtio_get_config_size() rather than sizeof(struct > > virtio_snd_config) for the config_size in the vhost-user-snd frontend. > > The frontend

[PATCH v2] vhost-user-snd: correct the calculation of config_size

2025-02-17 Thread Matias Ezequiel Vara Larsen
t/qemu/-/issues/2805 Reviewed-by: Philippe Mathieu-Daudé Suggested-by: Stefano Garzarella Signed-off-by: Matias Ezequiel Vara Larsen --- Changes in v2: - Addressed comments from Stefano Garzarella about commit msg and the property name. --- hw/virtio/vhost-user-snd.c | 18 +-