Re: [Qemu-devel] [PATCH] block: Set cdrom device read only flag

2012-08-07 Thread Markus Armbruster
Kevin Wolf writes: > Am 02.08.2012 09:20, schrieb Kevin Shanahan: >> On Thu, Aug 02, 2012 at 02:49:52PM +0930, Kevin Shanahan wrote: >>> On Thu, Aug 02, 2012 at 11:46:13AM +0930, Kevin Shanahan wrote: On Thu, Aug 02, 2012 at 11:02:42AM +0930, Kevin Shanahan wrote: > Set the block driver

Re: [Qemu-devel] [PATCH] block: Set cdrom device read only flag

2012-08-07 Thread Markus Armbruster
ronnie sahlberg writes: > Since pretty much every cdrom drive use scsi today, shouldnt the > readonly/writeable flag for MMC devices rather > be done down in the hw/scsi* code rather than the generic block code? There are two separate things that can be read-only: device models and BlockDriverS

Re: [Qemu-devel] [PATCH 1/1] hmp: allow "bool" parameter to be optional

2012-08-07 Thread Markus Armbruster
Pavel Hrdina writes: > On 08/07/2012 03:52 PM, Andreas Färber wrote: >> Am 07.08.2012 15:03, schrieb Pavel Hrdina: >>> Signed-off-by: Pavel Hrdina >> This is in need of a more detailed commit message: What exactly is this >> fixing? Or is this a preparation for a particular new command? >> >> An

[Qemu-devel] For all targets and machine types: "start to monitor" smoke test

2012-08-07 Thread Markus Armbruster
Very basic smoke test: start QEMU with -monitor stdio, quit immediately. Wouldn't it be nice if that worked for all targets and machine types? Many targets have mandatory options (fun oxymoron), such as -kernel or -pflash. Can't stop me, I just try a bunch until something works. Many targets exp

Re: [Qemu-devel] For all targets and machine types: "start to monitor" smoke test

2012-08-07 Thread Markus Armbruster
Anthony Liguori writes: > Markus Armbruster writes: > >> Very basic smoke test: start QEMU with -monitor stdio, quit immediately. >> Wouldn't it be nice if that worked for all targets and machine types? >> >> Many targets have mandatory options (fun oxymo

Re: [Qemu-devel] For all targets and machine types: "start to monitor" smoke test

2012-08-07 Thread Markus Armbruster
Peter Maydell writes: > On 7 August 2012 20:55, Markus Armbruster wrote: >> Anthony Liguori writes: >>> Perhaps we could add a QEMUMachine parameter that indicates that the >>> machine doesn't start without special options. >> >> Recommend to make

Re: [Qemu-devel] For all targets and machine types: "start to monitor" smoke test

2012-08-08 Thread Markus Armbruster
Peter Maydell writes: > On 7 August 2012 20:26, Markus Armbruster wrote: >> qemu-system-arm lm3s811evb >> qemu-system-arm lm3s6965evb >> qemu-system-arm: /work/armbru/qemu/hw/qdev.c:310: >> qdev_get_gpio_in: Assertion `n >= 0 && n < dev->nu

Re: [Qemu-devel] For all targets and machine types: "start to monitor" smoke test

2012-08-08 Thread Markus Armbruster
Andreas Färber writes: > Am 07.08.2012 21:26, schrieb Markus Armbruster: >> Very basic smoke test: start QEMU with -monitor stdio, quit immediately. > [...] >> Summary of results: >> >> * Bad unexplained > [...] >> qemu-system-ppc64 prep >>

Re: [Qemu-devel] For all targets and machine types: "start to monitor" smoke test

2012-08-08 Thread Markus Armbruster
Blue Swirl writes: > On Tue, Aug 7, 2012 at 7:26 PM, Markus Armbruster wrote: >> Very basic smoke test: start QEMU with -monitor stdio, quit immediately. >> Wouldn't it be nice if that worked for all targets and machine types? >> >> Many targets have mandatory

Re: [Qemu-devel] For all targets and machine types: "start to monitor" smoke test

2012-08-08 Thread Markus Armbruster
Markus Armbruster writes: > Peter Maydell writes: > >> On 7 August 2012 20:55, Markus Armbruster wrote: >>> Anthony Liguori writes: >>>> Perhaps we could add a QEMUMachine parameter that indicates that the >>>> machine doesn't start witho

Re: [Qemu-devel] For all targets and machine types: "start to monitor" smoke test

2012-08-08 Thread Markus Armbruster
Peter Maydell writes: > On 8 August 2012 08:50, Markus Armbruster wrote: >> Markus Armbruster writes: >>> The string should be suitable for inserting into -help. >> >> Sufficiently common cases can also be delegated to generic code: >> >> * Maximum nu

Re: [Qemu-devel] For all targets and machine types: "start to monitor" smoke test

2012-08-08 Thread Markus Armbruster
Max Filippov writes: > On Tue, Aug 7, 2012 at 11:26 PM, Markus Armbruster wrote: >> Very basic smoke test: start QEMU with -monitor stdio, quit immediately. >> Wouldn't it be nice if that worked for all targets and machine types? >> >> Many targets have mandatory

Re: [Qemu-devel] Funny -m arguments can crash

2012-08-08 Thread Markus Armbruster
Blue Swirl writes: > On Mon, Jul 30, 2012 at 12:56 PM, Markus Armbruster wrote: >> Blue Swirl writes: >> >>> On Sat, Jul 28, 2012 at 6:41 AM, Markus Armbruster >>> wrote: >>>> Blue Swirl writes: >>>> >>>>> On Wed, Jul

Re: [Qemu-devel] Funny -m arguments can crash

2012-08-08 Thread Markus Armbruster
Peter Maydell writes: > On 8 August 2012 10:04, Markus Armbruster wrote: >> Next problem: minimum RAM size. >> >> For instance, -M pc -m X, where X < 32KiB dies "qemu: fatal: Trying to >> execute code outside RAM or ROM at [...] Aborted (core dumped)&qu

Re: [Qemu-devel] [PATCH] target-xtensa: make default CPU depend on target endianness

2012-08-08 Thread Markus Armbruster
Max Filippov writes: > This makes usable default for -cpu option both for qemu-system-xtensa > and qemu-system-xtensaeb fixing the following error: > > $ qemu-system-xtensaeb -M sim > Unable to find CPU definition > > Signed-off-by: Max Filippov Tested-by: Markus Armbruster

Re: [Qemu-devel] For all targets and machine types: "start to monitor" smoke test

2012-08-08 Thread Markus Armbruster
Markus Armbruster writes: > Andreas Färber writes: > >> Am 07.08.2012 21:26, schrieb Markus Armbruster: >>> Very basic smoke test: start QEMU with -monitor stdio, quit immediately. >> [...] >>> Summary of results: >>> >>> * Bad unexplaine

Re: [Qemu-devel] [PATCH] target-xtensa: make 'sim' to be the default machine

2012-08-09 Thread Markus Armbruster
Max Filippov writes: > This fixes the following error: > > $ qemu-system-xtensa -cpu help > Segmentation fault main() attempts to cope with "no machine found", it just screws it up: if (machine->hw_version) { qemu_set_version(machine->hw_version); } [...] if (machine

Re: [Qemu-devel] [PATCH] vl.c: Exit QEMU early if no machine is found

2012-08-09 Thread Markus Armbruster
l on how to reproduce the SEGV. This does the trick: $ qemu-system-xtensa -cpu help Reviewed-by: Markus Armbruster

Re: [Qemu-devel] [PATCH] target-xtensa: make 'sim' to be the default machine

2012-08-09 Thread Markus Armbruster
Dunrong Huang writes: > 2012/8/9 Markus Armbruster : >> Max Filippov writes: >> >>> This fixes the following error: >>> >>> $ qemu-system-xtensa -cpu help >>> Segmentation fault >> >> main() attempts to cope with

[Qemu-devel] [PATCH 07/23] musicpal: Suppress unused default drives

2012-08-09 Thread Markus Armbruster
Cc: Jan Kiszka Suppress default floppy, CD-ROM and SD card drives. Signed-off-by: Markus Armbruster --- hw/musicpal.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/musicpal.c b/hw/musicpal.c index ad725b5..05930f5 100644 --- a/hw/musicpal.c +++ b/hw/musicpal.c @@ -1658,6 +1658,9

[Qemu-devel] [PATCH 06/23] kzm: Suppress unused default drives

2012-08-09 Thread Markus Armbruster
Cc: Peter Chubb Suppress default floppy, CD-ROM and SD card drives. Signed-off-by: Markus Armbruster --- hw/kzm.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/kzm.c b/hw/kzm.c index 6a5e9df..e7e4ef0 100644 --- a/hw/kzm.c +++ b/hw/kzm.c @@ -144,6 +144,9 @@ static QEMUMachine

[Qemu-devel] [PATCH 09/23] xilinx-zynq: Suppress unused default drives

2012-08-09 Thread Markus Armbruster
Cc: Peter Crosthwaite Suppress default floppy and CD-ROM drives. SD card was already suppressed. Signed-off-by: Markus Armbruster --- hw/xilinx_zynq.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/xilinx_zynq.c b/hw/xilinx_zynq.c index 7e6c273..ebca914 100644 --- a/hw

[Qemu-devel] [PATCH 16/23] mips_jazz: Suppress unused default drives

2012-08-09 Thread Markus Armbruster
Cc: Hervé Poussineau Suppress default SD card drive for machines magnum, pica61. Signed-off-by: Markus Armbruster --- hw/mips_jazz.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/mips_jazz.c b/hw/mips_jazz.c index db927f1..c6a1ace 100644 --- a/hw/mips_jazz.c +++ b/hw/mips_jazz.c

[Qemu-devel] [PATCH 01/23] alpha_dp264: Suppress unused default drives

2012-08-09 Thread Markus Armbruster
Suppress default floppy and SD-card drives. Signed-off-by: Markus Armbruster --- hw/alpha_dp264.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/alpha_dp264.c b/hw/alpha_dp264.c index 9eb939f..3dd6252 100644 --- a/hw/alpha_dp264.c +++ b/hw/alpha_dp264.c @@ -169,6 +169,8 @@ static

[Qemu-devel] [PATCH 02/23] nseries palm spitz: Suppress unused default drives

2012-08-09 Thread Markus Armbruster
Cc: Andrzej Zaborowski Suppress default floppy and CD-ROM drives for machines n800, n810, cheetah, akita, spitz, borzoi, terrier. Signed-off-by: Markus Armbruster --- hw/nseries.c | 4 hw/palm.c| 2 ++ hw/spitz.c | 8 3 files changed, 14 insertions(+) diff --git a/hw

[Qemu-devel] [PATCH 18/23] mips_fulong2e, mips_mipssim: Suppress unused default drives

2012-08-09 Thread Markus Armbruster
Suppress default floppy and SD card drive for machines fulong2e, mipssim. Suppress default CD-ROM drive for machine mipssim. Signed-off-by: Markus Armbruster --- hw/mips_fulong2e.c | 2 ++ hw/mips_mipssim.c | 3 +++ 2 files changed, 5 insertions(+) diff --git a/hw/mips_fulong2e.c b/hw

[Qemu-devel] [PATCH 17/23] mips_malta mips_r4k: Suppress unused default drives

2012-08-09 Thread Markus Armbruster
Cc: Aurelien Jarno Suppress default SD card drive for machines malta, mips. Suppress default floppy drive for machine mips. Signed-off-by: Markus Armbruster --- hw/mips_malta.c | 1 + hw/mips_r4k.c | 2 ++ 2 files changed, 3 insertions(+) diff --git a/hw/mips_malta.c b/hw/mips_malta.c

[Qemu-devel] [PATCH 08/23] exynos4: Suppress unused default drives

2012-08-09 Thread Markus Armbruster
Cc: Evgeny Voevodin Cc: Maksim Kozlov Cc: Igor Mitsyanko Cc: Dmitry Solodkiy Suppress default floppy, CD-ROM and SD card drives for machines nuri, smdkc210. Signed-off-by: Markus Armbruster --- hw/exynos4_boards.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/hw

[Qemu-devel] [PATCH 22/23] sparc: Suppress unused default drives

2012-08-09 Thread Markus Armbruster
-1000, SS-2000, SS-2, sun4u, sun4v, Niagara. Signed-off-by: Markus Armbruster --- hw/leon3.c | 3 +++ hw/sun4m.c | 15 +++ hw/sun4u.c | 3 +++ 3 files changed, 21 insertions(+) diff --git a/hw/leon3.c b/hw/leon3.c index 878d3aa..d4c97dc 100644 --- a/hw/leon3.c +++ b/hw/leon3.c

[Qemu-devel] [PATCH 13/23] lm32: Suppress unused default drives

2012-08-09 Thread Markus Armbruster
Cc: Michael Walle Suppress default floppy and CD-ROM drives for machines lm32-evr, lm32-uclinux, milkymist. Suppress default SD card drive for machines lm32-evr, lm32-uclinux. Signed-off-by: Markus Armbruster --- hw/lm32_boards.c | 6 ++ hw/milkymist.c | 2 ++ 2 files changed, 8

[Qemu-devel] [PATCH 21/23] sh4: Suppress unused default drives

2012-08-09 Thread Markus Armbruster
Cc: Magnus Damm Suppress default floppy, CD-ROM and SD card drives for machines r2d, shix. Signed-off-by: Markus Armbruster --- hw/r2d.c | 3 +++ hw/shix.c | 3 +++ 2 files changed, 6 insertions(+) diff --git a/hw/r2d.c b/hw/r2d.c index 0f16e81..fc7f681 100644 --- a/hw/r2d.c +++ b/hw/r2d.c

[Qemu-devel] [PATCH 15/23] microblaze: Suppress unused default drives

2012-08-09 Thread Markus Armbruster
Cc: Peter Crosthwaite Suppress default floppy, CD-ROM and SD card drives for machines petalogix-ml605 and petalogix-s3adsp1800. Signed-off-by: Markus Armbruster --- hw/petalogix_ml605_mmu.c | 3 +++ hw/petalogix_s3adsp1800_mmu.c | 3 +++ 2 files changed, 6 insertions(+) diff --git a/hw

[Qemu-devel] [PATCH 05/23] omap_sx1: Suppress unused default drives

2012-08-09 Thread Markus Armbruster
Cc: Peter Maydell Suppress default floppy and CD-ROM drives for machines sx1, sx1-v1. Signed-off-by: Markus Armbruster --- hw/omap_sx1.c | 4 1 file changed, 4 insertions(+) diff --git a/hw/omap_sx1.c b/hw/omap_sx1.c index abca341..3ca716e 100644 --- a/hw/omap_sx1.c +++ b/hw/omap_sx1.c

[Qemu-devel] [PATCH 04/23] integratorcp, realview, stellaris, versatilepb: Suppress unused default drives

2012-08-09 Thread Markus Armbruster
-a9, lm3s811evb, lm3s6965evb. Suppress default SD card drive for lm3s811evb. Signed-off-by: Markus Armbruster --- hw/integratorcp.c | 2 ++ hw/realview.c | 6 ++ hw/stellaris.c| 5 + hw/versatilepb.c | 2 ++ 4 files changed, 15 insertions(+) diff --git a/hw/integratorcp.c b/hw

[Qemu-devel] [PATCH 14/23] m68k: Suppress unused default drives

2012-08-09 Thread Markus Armbruster
Cc: Paul Brook --- hw/an5206.c | 3 +++ hw/dummy_m68k.c | 3 +++ hw/mcf5208.c| 3 +++ 3 files changed, 9 insertions(+) diff --git a/hw/an5206.c b/hw/an5206.c index 25407c0..80158581 100644 --- a/hw/an5206.c +++ b/hw/an5206.c @@ -86,6 +86,9 @@ static QEMUMachine an5206_machine = { .n

[Qemu-devel] [PATCH 03/23] highbank: Suppress unused default drives

2012-08-09 Thread Markus Armbruster
Cc: Mark Langsdorf Suppress default floppy, CD-ROM and SD-card drives. Signed-off-by: Markus Armbruster --- hw/highbank.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/highbank.c b/hw/highbank.c index 11aa131..ffb4132 100644 --- a/hw/highbank.c +++ b/hw/highbank.c @@ -326,6 +326,9

[Qemu-devel] [PATCH 20/23] ppc: Suppress unused default drives

2012-08-09 Thread Markus Armbruster
ref405ep, taihu, bamboo, mac88, g3beige, prep, virtex-ml507. Signed-off-by: Markus Armbruster --- hw/ppc405_boards.c | 6 ++ hw/ppc440_bamboo.c | 3 +++ hw/ppc_newworld.c | 2 ++ hw/ppc_oldworld.c | 2 ++ hw/ppc_prep.c | 1 + hw/virtex_ml507.c | 3 +++ 6 files changed, 17 insertions(+) diff

[Qemu-devel] [PATCH 10/23] collie gumstix mainstone tosa vexpress z2: Suppress unused default drives

2012-08-09 Thread Markus Armbruster
Suppress default floppy and CD-ROM drives for machines collie, connex, verdex, mainstone, tosa, vexpress-a9, vexpress-a15, z2. Suppress default SD card drive for machine collie. Signed-off-by: Markus Armbruster --- hw/collie.c| 3 +++ hw/gumstix.c | 4 hw/mainstone.c | 2 ++ hw

[Qemu-devel] [PATCH 12/23] pc xen: Suppress unused default drives

2012-08-09 Thread Markus Armbruster
Cc: Anthony Liguori Cc: Stefano Stabellini Suppress default SD card drive for machines pc-*, isapc, xenfv, xenpv. Signed-off-by: Markus Armbruster --- hw/pc_piix.c| 11 +++ hw/xen_machine_pv.c | 1 + 2 files changed, 12 insertions(+) diff --git a/hw/pc_piix.c b/hw/pc_piix.c

[Qemu-devel] [PATCH 11/23] axis-dev88: Suppress unused default drives

2012-08-09 Thread Markus Armbruster
Cc: Edgar E. Iglesias Suppress default floppy, CD-ROM and SD card drives. Signed-off-by: Markus Armbruster --- hw/axis_dev88.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/axis_dev88.c b/hw/axis_dev88.c index eab6327..9a9da15 100644 --- a/hw/axis_dev88.c +++ b/hw/axis_dev88.c

Re: [Qemu-devel] [PATCH 20/23] ppc: Suppress unused default drives

2012-08-09 Thread Markus Armbruster
Andreas Färber writes: > Am 09.08.2012 15:31, schrieb Markus Armbruster: >> Cc: Alexander Graf >> Cc: Andreas Färber >> Cc: qemu-...@nongnu.org >> >> Suppress default floppy drive for machines ref405ep, taihu, bamboo, >> mac99, g3beige, virtex-ml507. &

[Qemu-devel] [PATCH 23/23] xtensa: Suppress unused default drives

2012-08-09 Thread Markus Armbruster
Cc: Max Filippov Suppress default floppy, CD-ROM and SD card drives for machines lx60, lx200, sim. Signed-off-by: Markus Armbruster --- hw/xtensa_lx60.c | 6 ++ hw/xtensa_sim.c | 3 +++ 2 files changed, 9 insertions(+) diff --git a/hw/xtensa_lx60.c b/hw/xtensa_lx60.c index c4f616f

[Qemu-devel] [PATCH 19/23] or32-sim: Suppress unused default drives

2012-08-09 Thread Markus Armbruster
Suppress default floppy, CD-ROM and SD card drive. Signed-off-by: Markus Armbruster --- hw/openrisc_sim.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/openrisc_sim.c b/hw/openrisc_sim.c index 55e97f0..13631ea 100644 --- a/hw/openrisc_sim.c +++ b/hw/openrisc_sim.c @@ -139,6 +139,9

[Qemu-devel] [PATCH 00/23] Suppress unused default drives

2012-08-09 Thread Markus Armbruster
v Cc: Mark Langsdorf Cc: Max Filippov Cc: Michael Walle Cc: Paul Brook Cc: Peter Chubb Cc: Peter Crosthwaite Cc: Peter Maydell Cc: Stefano Stabellini Cc: qemu-...@nongnu.org Markus Armbruster (23): alpha_dp264: Suppress unused default drives nseries palm spitz: Suppress unused default d

Re: [Qemu-devel] [PATCH 00/23] Suppress unused default drives

2012-08-09 Thread Markus Armbruster
Peter Maydell writes: > On 9 August 2012 15:08, Markus Armbruster wrote: >> Peter Maydell writes: >>> For clarity: what are the negative effects that result from >>> machines not saying no_floppy &c ? >> >> "info block" shows the unused d

Re: [Qemu-devel] [PATCH 00/23] Suppress unused default drives

2012-08-09 Thread Markus Armbruster
Peter Maydell writes: > On 9 August 2012 14:31, Markus Armbruster wrote: >> We create a number of default drives for machines to use: floppy, >> CD-ROM, SD card. Machines can suppress the ones they don't use, but >> few do. Fix that. > > For clarity: what are

Re: [Qemu-devel] [PATCH] armv7m: Guard against no -kernel argument

2012-08-09 Thread Markus Armbruster
"Peter A. G. Crosthwaite" writes: > A -kernel argument must be specified for this machine. Gaurd against no > -kernel > argument. Previously gave an unhelpful "bad address" error message. > > Signed-off-by: Peter A. G. Crosthwaite Tested-by: Markus Armbruster

Re: [Qemu-devel] [PATCH 11/34] qmp: query-block: add 'valid_encryption_key' field

2012-08-10 Thread Markus Armbruster
Revisited this one on review of v2, replying here for context. Luiz Capitulino writes: > On Thu, 02 Aug 2012 13:35:54 +0200 > Markus Armbruster wrote: > >> Luiz Capitulino writes: >> >> > Signed-off-by: Luiz Capitulino >> > --- >> > b

Re: [Qemu-devel] [PATCH 12/34] hmp: hmp_cont(): don't rely on QERR_DEVICE_ENCRYPTED

2012-08-10 Thread Markus Armbruster
Luiz Capitulino writes: > On Thu, 02 Aug 2012 13:53:08 +0200 > Markus Armbruster wrote: > >> Luiz Capitulino writes: >> >> > This commit changes hmp_cont() to loop through all block devices >> > and proactively set an encryption key for any en

Re: [Qemu-devel] [PATCH 12/35] hmp: hmp_cont(): don't rely on QERR_DEVICE_ENCRYPTED

2012-08-10 Thread Markus Armbruster
Luiz Capitulino writes: > This commit changes hmp_cont() to loop through all block devices > and proactively set an encryption key for any encrypted device > without a valid one. > > This change is needed because QERR_DEVICE_ENCRYPTED is going to be > dropped by a future commit. I'm afraid this

Re: [Qemu-devel] [PATCH 13/35] hmp_change(): don't access DeviceEncrypted's data

2012-08-10 Thread Markus Armbruster
Luiz Capitulino writes: > It's not needed. The device name is already known and > monitor_read_block_device_key() knows how to do the rest. This overly > simplifies hmp_change(). "overly"? My usual complaint about commit messages is that they fail to explain the change's purpose. Yours explain

Re: [Qemu-devel] [PATCH 14/35] net: inet_connect(), inet_connect_opts(): add in_progress argument

2012-08-10 Thread Markus Armbruster
Luiz Capitulino writes: > It's used to indicate the special case where a valid file-descriptor > is returned (ie. success) but the connection can't be completed > w/o blocking. Why callers need that isn't obvious from this patch. It's used in PATCH 16. Either squash the two to make it obvious,

Re: [Qemu-devel] [PATCH 15/35] migration: don't rely on any QERR_SOCKET_*

2012-08-10 Thread Markus Armbruster
Luiz Capitulino writes: > Use the in_progress argument for QERR_SOCKET_CONNECT_IN_PROGRESS. The > other errors are handled the same by checking if the error is set and > then calling migrate_fd_error() if it's. > > It's also necessary to change inet_connect_opts() not to set > QERR_SOCKET_CONNECT

Re: [Qemu-devel] [PATCH 1/2] avoid asprintf (not available on mingw64)

2012-08-10 Thread Markus Armbruster
Gerd Hoffmann writes: > Signed-off-by: Gerd Hoffmann > --- > hw/msix.c |5 ++--- > 1 files changed, 2 insertions(+), 3 deletions(-) > > diff --git a/hw/msix.c b/hw/msix.c > index 800fc32..04345f2 100644 > --- a/hw/msix.c > +++ b/hw/msix.c > @@ -307,9 +307,8 @@ int msix_init_exclusive_bar(PC

Re: [Qemu-devel] [PATCH 11/34] qmp: query-block: add 'valid_encryption_key' field

2012-08-10 Thread Markus Armbruster
Luiz Capitulino writes: > On Fri, 10 Aug 2012 09:56:11 +0200 > Markus Armbruster wrote: > >> Revisited this one on review of v2, replying here for context. >> >> Luiz Capitulino writes: >> >> > On Thu, 02 Aug 2012 13:35:54 +0200 >> > M

Re: [Qemu-devel] [PATCH 12/34] hmp: hmp_cont(): don't rely on QERR_DEVICE_ENCRYPTED

2012-08-10 Thread Markus Armbruster
Luiz Capitulino writes: > On Fri, 10 Aug 2012 10:42:23 +0200 > Markus Armbruster wrote: > >> Luiz Capitulino writes: >> >> > On Thu, 02 Aug 2012 13:53:08 +0200 >> > Markus Armbruster wrote: >> > >> >> Luiz Capitulino writes: >&

Re: [Qemu-devel] [PATCH 11/34] qmp: query-block: add 'valid_encryption_key' field

2012-08-10 Thread Markus Armbruster
Luiz Capitulino writes: > On Fri, 10 Aug 2012 18:35:26 +0200 > Markus Armbruster wrote: > >> Luiz Capitulino writes: >> >> > On Fri, 10 Aug 2012 09:56:11 +0200 >> > Markus Armbruster wrote: >> > >> >> Revisited this one on review of

Re: [Qemu-devel] [PATCH v3 00/35]: add new error format

2012-08-11 Thread Markus Armbruster
sc": "Device 'virtio0' is not removable" } } > > Internally, we go from: > > void error_set(Error **err, const char *fmt, ...); > > to: > > void error_set(Error **err, ErrorClass err_class, const char *fmt, ...); Glad to see this change in good shape in time for the release. Thanks, Luiz! Reviewed-by: Markus Armbruster

Re: [Qemu-devel] [PATCH 11/34] qmp: query-block: add 'valid_encryption_key' field

2012-08-11 Thread Markus Armbruster
Luiz Capitulino writes: > On Fri, 10 Aug 2012 19:17:22 +0200 > Markus Armbruster wrote: > >> Luiz Capitulino writes: >> >> > On Fri, 10 Aug 2012 18:35:26 +0200 >> > Markus Armbruster wrote: >> > >> >> Luiz Capitulino writes: >

Re: [Qemu-devel] [PATCH] block: Set cdrom device read only flag

2012-08-13 Thread Markus Armbruster
Kevin Wolf writes: > Am 12.08.2012 04:48, schrieb Kevin Shanahan: >> So qmp_change_blockdev uses bdrv_is_read_only() to check whether to >> try and open the backing file read only, which uses the ->read_only >> member of struct BlockDriverState to decide whether to pass the >> BDRV_O_RDRW flag to

Re: [Qemu-devel] Funny -m arguments can crash

2012-08-13 Thread Markus Armbruster
Avi Kivity writes: > On 08/08/2012 12:04 PM, Markus Armbruster wrote: >>> >>> Yes please, maybe with a notice to the user. >> >> Next problem: minimum RAM size. >> >> For instance, -M pc -m X, where X < 32KiB dies "qemu: fatal: Trying t

Re: [Qemu-devel] [PATCH 11/34] qmp: query-block: add 'valid_encryption_key' field

2012-08-13 Thread Markus Armbruster
Luiz Capitulino writes: > On Sat, 11 Aug 2012 09:45:14 +0200 > Markus Armbruster wrote: > >> Luiz Capitulino writes: >> >> > On Fri, 10 Aug 2012 19:17:22 +0200 >> > Markus Armbruster wrote: >> > >> >> Luiz Capitulino writes: >

Re: [Qemu-devel] Funny -m arguments can crash

2012-08-13 Thread Markus Armbruster
Anthony Liguori writes: > Markus Armbruster writes: > >> Avi Kivity writes: >> >>> On 08/08/2012 12:04 PM, Markus Armbruster wrote: >>>>> >>>>> Yes please, maybe with a notice to the user. >>>> >>>> Next pro

Re: [Qemu-devel] [PATCH] json-parser: don't replicate tokens at each level of recursion

2012-08-13 Thread Markus Armbruster
Michael Roth writes: > Currently, when parsing a stream of tokens we make a copy of the token > list at the beginning of each level of recursion so that we do not > modify the original list in cases where we need to fall back to an > earlier state. > > In the worst case, we will only read 1 or 2

Re: [Qemu-devel] Funny -m arguments can crash

2012-08-14 Thread Markus Armbruster
Anthony Liguori writes: > Markus Armbruster writes: > >> Avi Kivity writes: >> >>> On 08/08/2012 12:04 PM, Markus Armbruster wrote: >>>>> >>>>> Yes please, maybe with a notice to the user. >>>> >>>> Next pro

Re: [Qemu-devel] Funny -m arguments can crash

2012-08-14 Thread Markus Armbruster
Avi Kivity writes: > On 08/14/2012 11:44 AM, Markus Armbruster wrote: [...] >> And another one: >> >> $ qemu-system-x86_64 -nodefaults --enable-kvm -vnc :0 -monitor >> stdio -m 900k >> QEMU 1.1.50 monitor - type 'help' for more information &g

Re: [Qemu-devel] [PATCH 15/35] migration: don't rely on any QERR_SOCKET_*

2012-08-14 Thread Markus Armbruster
Juan Quintela writes: > Markus Armbruster wrote: >> Luiz Capitulino writes: >> >>> Use the in_progress argument for QERR_SOCKET_CONNECT_IN_PROGRESS. The >>> other errors are handled the same by checking if the error is set and >>> then calling mig

Re: [Qemu-devel] [PATCH uq/master] kvmvapic: Disable if there is insufficient memory

2012-08-14 Thread Markus Armbruster
e-kvm -vnc :0 -m 640k Segmentation fault (core dumped) > Reported-by: Markus Armbruster > Signed-off-by: Jan Kiszka Tested-by: Markus Armbruster

[Qemu-devel] [PATCH 0/2] Fix two bugs related to ram_size

2012-08-14 Thread Markus Armbruster
There are more, but let's start with these two. Markus Armbruster (2): vl: Round argument of -m up to multiple of 8KiB pc: Fix RTC CMOS info on RAM for ram_size < 1MiB hw/pc.c | 27 +++ vl.c| 4 +++- 2 files changed, 18 insertions(+), 13 d

[Qemu-devel] [PATCH 1/2] vl: Round argument of -m up to multiple of 8KiB

2012-08-14 Thread Markus Armbruster
4: /work/armbru/qemu/exec.c:2255: register_subpage: Assertion `existing->mr->subpage || existing->mr == &io_mem_unassigned' failed Signed-off-by: Markus Armbruster --- See also http://lists.nongnu.org/archive/html/qemu-devel/2012-06/msg02813.html vl.c | 4 +++- 1 file changed, 3 in

[Qemu-devel] [PATCH 2/2] pc: Fix RTC CMOS info on RAM for ram_size < 1MiB

2012-08-14 Thread Markus Armbruster
pc_cmos_init() always claims 640KiB base memory, and ram_size - 1MiB extended memory. The latter can underflow to "lots of extended memory". Fix both, and clean up some. Note: SeaBIOS currently requires 1MiB of RAM, and doesn't check whether it got enough. Signed-off-by: Ma

Re: [Qemu-devel] [PATCH 1/2] vl: Round argument of -m up to multiple of 8KiB

2012-08-14 Thread Markus Armbruster
Avi Kivity writes: > On 08/14/2012 02:58 PM, Markus Armbruster wrote: >> Partial pages make little sense and don't work. Ensure the RAM size >> is a multiple of any possible target's page size. >> >> index d01256a..b411d45 100644 >> --- a/vl.c >&g

Re: [Qemu-devel] [PATCH] block-migration: deprecate block migration for the 1.2 release

2012-08-14 Thread Markus Armbruster
Anthony Liguori writes: > Luiz Capitulino writes: > >> On Tue, 14 Aug 2012 08:32:31 -0500 >> Anthony Liguori wrote: >> >>> To be replaced with live block copy. >>> >>> Signed-off-by: Anthony Liguori >>> --- >>> migration.c |9 + >>> 1 files changed, 9 insertions(+), 0 deletions(-

Re: [Qemu-devel] [PATCH 2/2] pc: Fix RTC CMOS info on RAM for ram_size < 1MiB

2012-08-15 Thread Markus Armbruster
Blue Swirl writes: > On Tue, Aug 14, 2012 at 11:58 AM, Markus Armbruster wrote: >> pc_cmos_init() always claims 640KiB base memory, and ram_size - 1MiB >> extended memory. The latter can underflow to "lots of extended >> memory". Fix both, and clean up some

[Qemu-devel] [PATCH v2 1/2] vl: Round argument of -m up to multiple of 8KiB

2012-08-15 Thread Markus Armbruster
t;mr->subpage || existing->mr == &io_mem_unassigned' failed. Signed-off-by: Markus Armbruster --- vl.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/vl.c b/vl.c index d01256a..dd6b861 100644 --- a/vl.c +++ b/vl.c @@ -2708,12 +2708,11 @@ int main(int ar

[Qemu-devel] [PATCH v2 2/2] pc: Fix RTC CMOS info on RAM for ram_size < 1MiB

2012-08-15 Thread Markus Armbruster
pc_cmos_init() always claims 640KiB base memory, and ram_size - 1MiB extended memory. The latter can underflow to "lots of extended memory". Fix both, and clean up some. Note: SeaBIOS currently requires 1MiB of RAM, and doesn't check whether it got enough. Signed-off-by: Ma

[Qemu-devel] [PATCH v2 0/2] Fix two bugs related to ram_size

2012-08-15 Thread Markus Armbruster
There are more, but let's start with these two. v2: * Use QEMU_ALIGN_UP (Avi) * Cover size overflow * Coding style (Blue) Markus Armbruster (2): vl: Round argument of -m up to multiple of 8KiB pc: Fix RTC CMOS info on RAM for ram_size < 1MiB hw/p

Re: [Qemu-devel] [PATCH v2 0/2] Fix two bugs related to ram_size

2012-08-15 Thread Markus Armbruster
Sent the wrong one. v3 coming. Sorry for the inconvenience.

[Qemu-devel] [PATCH v3 2/2] pc: Fix RTC CMOS info on RAM for ram_size < 1MiB

2012-08-15 Thread Markus Armbruster
pc_cmos_init() always claims 640KiB base memory, and ram_size - 1MiB extended memory. The latter can underflow to "lots of extended memory". Fix both, and clean up some. Note: SeaBIOS currently requires 1MiB of RAM, and doesn't check whether it got enough. Signed-off-by: Ma

[Qemu-devel] [PATCH v3 1/2] vl: Round argument of -m up to multiple of 8KiB

2012-08-15 Thread Markus Armbruster
t;mr->subpage || existing->mr == &io_mem_unassigned' failed. Signed-off-by: Markus Armbruster --- vl.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/vl.c b/vl.c index d01256a..a63e16b 100644 --- a/vl.c +++ b/vl.c @@ -2701,6 +2701,7 @@ int main(int ar

[Qemu-devel] [PATCH v3 0/2] Fix two bugs related to ram_size

2012-08-15 Thread Markus Armbruster
There are more, but let's start with these two. v1 -> v3: * Use QEMU_ALIGN_UP (Avi) * Cover size overflow * Coding style (Blue) Markus Armbruster (2): vl: Round argument of -m up to multiple of 8KiB pc: Fix RTC CMOS info on RAM for ram_size < 1MiB h

Re: [Qemu-devel] [PATCH 20/23] ppc: Suppress unused default drives

2012-08-15 Thread Markus Armbruster
Alexander Graf writes: > On 09.08.2012, at 16:54, Markus Armbruster wrote: > >> Andreas Färber writes: >> >>> Am 09.08.2012 15:31, schrieb Markus Armbruster: >>>> Cc: Alexander Graf >>>> Cc: Andreas Färber >>>> Cc: qemu-...@n

Re: [Qemu-devel] [PATCH 00/23] Suppress unused default drives

2012-08-15 Thread Markus Armbruster
Paul Brook writes: >> > *can* use it for something entirely else, if=sd notwithstanding: >> > (qemu) device_add lsi >> > (qemu) device_add scsi-cd,drive=sd0 >> >> If/when we get a PCI SD card controller model, would all the PCI >> using machines need to be added to take the 'no default s

[Qemu-devel] [PATCH v2 for-1.2 12/27] xilinx-zynq: Suppress unused default drives

2012-08-15 Thread Markus Armbruster
Cc: Peter Crosthwaite Suppress default floppy and CD-ROM drives. SD card was already suppressed. Signed-off-by: Markus Armbruster --- hw/xilinx_zynq.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/hw/xilinx_zynq.c b/hw/xilinx_zynq.c index 1f16a34..b532953 100644 --- a/hw/xilinx_zynq.c

[Qemu-devel] [PATCH v2 for-1.2 04/27] alpha_dp264: Suppress unused default drives

2012-08-15 Thread Markus Armbruster
Suppress default floppy and SD-card drives. Signed-off-by: Markus Armbruster --- hw/alpha_dp264.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/hw/alpha_dp264.c b/hw/alpha_dp264.c index 06661e3..836fb41 100644 --- a/hw/alpha_dp264.c +++ b/hw/alpha_dp264.c @@ -169,9 +169,7 @@ static

[Qemu-devel] [PATCH v2 for-1.2 07/27] integratorcp, realview, stellaris, versatilepb: Suppress unused default drives

2012-08-15 Thread Markus Armbruster
-a9, lm3s811evb, lm3s6965evb. Suppress default SD card drive for lm3s811evb. Signed-off-by: Markus Armbruster --- hw/integratorcp.c | 2 -- hw/realview.c | 6 -- hw/stellaris.c| 5 - hw/versatilepb.c | 2 -- 4 files changed, 15 deletions(-) diff --git a/hw/integratorcp.c b/hw

[Qemu-devel] [PATCH v2 for-1.2 11/27] exynos4: Suppress unused default drives

2012-08-15 Thread Markus Armbruster
Cc: Evgeny Voevodin Cc: Maksim Kozlov Cc: Igor Mitsyanko Cc: Dmitry Solodkiy Suppress default floppy, CD-ROM and SD card drives for machines nuri, smdkc210. Signed-off-by: Markus Armbruster --- hw/exynos4_boards.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/hw/exynos4_boards.c

[Qemu-devel] [PATCH v2 for-1.2 22/27] or32-sim: Suppress unused default drives

2012-08-15 Thread Markus Armbruster
Suppress default floppy, CD-ROM and SD card drive. Signed-off-by: Markus Armbruster --- hw/openrisc_sim.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/hw/openrisc_sim.c b/hw/openrisc_sim.c index 2b77846..55e97f0 100644 --- a/hw/openrisc_sim.c +++ b/hw/openrisc_sim.c @@ -139,9 +139,6

[Qemu-devel] [PATCH v2 for-1.2 24/27] sh4: Suppress unused default drives

2012-08-15 Thread Markus Armbruster
Cc: Magnus Damm Suppress default floppy, CD-ROM and SD card drives for machines r2d, shix. Signed-off-by: Markus Armbruster --- hw/r2d.c | 3 --- hw/shix.c | 3 --- 2 files changed, 6 deletions(-) diff --git a/hw/r2d.c b/hw/r2d.c index e4812ea..0f16e81 100644 --- a/hw/r2d.c +++ b/hw/r2d.c

[Qemu-devel] [PATCH v2 for-1.2 26/27] unicore32: Suppress unused default drives

2012-08-15 Thread Markus Armbruster
Cc: Guan Xuetao Suppress default floppy, CD-ROM and SD card drives for machine puv3. Signed-off-by: Markus Armbruster --- hw/puv3.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/hw/puv3.c b/hw/puv3.c index bf03336..8aad17f 100644 --- a/hw/puv3.c +++ b/hw/puv3.c @@ -124,9 +124,6

[Qemu-devel] [PATCH v2 for-1.2 05/27] nseries palm spitz: Suppress unused default drives

2012-08-15 Thread Markus Armbruster
Cc: Andrzej Zaborowski Suppress default floppy and CD-ROM drives for machines n800, n810, cheetah, akita, spitz, borzoi, terrier. Signed-off-by: Markus Armbruster --- hw/nseries.c | 4 hw/palm.c| 2 -- hw/spitz.c | 8 3 files changed, 14 deletions(-) diff --git a/hw

[Qemu-devel] [PATCH v2 for-1.2 10/27] musicpal: Suppress unused default drives

2012-08-15 Thread Markus Armbruster
Cc: Jan Kiszka Suppress default floppy, CD-ROM and SD card drives. Signed-off-by: Markus Armbruster --- hw/musicpal.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/hw/musicpal.c b/hw/musicpal.c index 3861056..ad725b5 100644 --- a/hw/musicpal.c +++ b/hw/musicpal.c @@ -1658,9 +1658,6

[Qemu-devel] [PATCH v2 for-1.2 00/27] Suppress unused default drives

2012-08-15 Thread Markus Armbruster
in v1) Markus Armbruster (27): puv3: Require -kernel leon mips_fulong2e: Give QEMUMachine internal linkage hw: Make default drives opt-in instead of opt-out for boards alpha_dp264: Suppress unused default drives nseries palm spitz: Suppress unused default drives highbank: Suppress u

[Qemu-devel] [PATCH v2 for-1.2 03/27] hw: Make default drives opt-in instead of opt-out for boards

2012-08-15 Thread Markus Armbruster
to screw up there. The next few commits will clean up the existing unused default drives. Signed-off-by: Markus Armbruster --- hw/alpha_dp264.c | 3 +++ hw/an5206.c | 3 +++ hw/axis_dev88.c | 3 +++ hw/boards.h | 6 +++--- hw

[Qemu-devel] [PATCH v2 for-1.2 16/27] lm32: Suppress unused default drives

2012-08-15 Thread Markus Armbruster
Cc: Michael Walle Suppress default floppy and CD-ROM drives for machines lm32-evr, lm32-uclinux, milkymist. Suppress default SD card drive for machines lm32-evr, lm32-uclinux. Signed-off-by: Markus Armbruster --- hw/lm32_boards.c | 6 -- hw/milkymist.c | 2 -- 2 files changed, 8

[Qemu-devel] [PATCH v2 for-1.2 23/27] ppc: Suppress unused default drives

2012-08-15 Thread Markus Armbruster
card drive for machines ref405ep, taihu, bamboo, mac99, g3beige, prep, mpc8544ds, pseries, virtex-ml507. Signed-off-by: Markus Armbruster --- hw/ppc405_boards.c | 6 -- hw/ppc440_bamboo.c | 3 --- hw/ppc_newworld.c | 2 -- hw/ppc_oldworld.c | 2 -- hw/ppc_prep.c | 1

[Qemu-devel] [PATCH v2 for-1.2 15/27] pc xen: Suppress unused default drives

2012-08-15 Thread Markus Armbruster
Cc: Anthony Liguori Cc: Stefano Stabellini Suppress default SD card drive for machines pc-*, isapc, xenfv, xenpv. Signed-off-by: Markus Armbruster --- hw/pc_piix.c| 11 --- hw/xen_machine_pv.c | 1 - 2 files changed, 12 deletions(-) diff --git a/hw/pc_piix.c b/hw/pc_piix.c

[Qemu-devel] [PATCH v2 for-1.2 19/27] mips_jazz: Suppress unused default drives

2012-08-15 Thread Markus Armbruster
Cc: Hervé Poussineau Suppress default SD card drive for machines magnum, pica61. Signed-off-by: Markus Armbruster --- hw/mips_jazz.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/hw/mips_jazz.c b/hw/mips_jazz.c index 0e203cb..d5dffb6 100644 --- a/hw/mips_jazz.c +++ b/hw/mips_jazz.c

[Qemu-devel] [PATCH v2 for-1.2 14/27] axis-dev88: Suppress unused default drives

2012-08-15 Thread Markus Armbruster
Cc: Edgar E. Iglesias Suppress default floppy, CD-ROM and SD card drives. Signed-off-by: Markus Armbruster --- hw/axis_dev88.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/hw/axis_dev88.c b/hw/axis_dev88.c index 982b921..eab6327 100644 --- a/hw/axis_dev88.c +++ b/hw/axis_dev88.c

[Qemu-devel] [PATCH v2 for-1.2 13/27] collie gumstix mainstone tosa vexpress z2: Suppress unused default drives

2012-08-15 Thread Markus Armbruster
Suppress default floppy and CD-ROM drives for machines collie, connex, verdex, mainstone, tosa, vexpress-a9, vexpress-a15, z2. Suppress default SD card drive for machine collie. Signed-off-by: Markus Armbruster --- hw/collie.c| 3 --- hw/gumstix.c | 4 hw/mainstone.c | 2 -- hw

  1   2   3   4   5   6   7   8   9   10   >