Also add a new net/checksum.h header
Signed-off-by: Mark McLoughlin
---
Makefile|4 +-
hw/e1000.c |1 +
hw/virtio-net.c |1 +
hw/xen_nic.c|1 +
net-checksum.c | 86 ---
net.h |7
net
Signed-off-by: Mark McLoughlin
---
Makefile |1 +
net/tap-bsd.c | 62 +
net/tap.c | 50 +++--
net/tap.h |2 +
4 files changed, 69 insertions(+), 46 deletions(-)
create mode
Signed-off-by: Mark McLoughlin
---
hw/virtio-net.c |1 +
net.c | 75 --
net.h |5 ---
net/tap-win32.c | 48 +-
net/tap.h | 42 ++
sysemu.h
Signed-off-by: Mark McLoughlin
---
net.c |2 +-
net/tap-linux.h | 51 +++
tap-linux.h | 51 ---
3 files changed, 52 insertions(+), 52 deletions(-)
create mode 100644 net/tap
TUNSETOFFLOAD is only available on Linux
Signed-off-by: Mark McLoughlin
---
net/tap-aix.c |5 +
net/tap-bsd.c |5 +
net/tap-linux.c | 26 ++
net/tap-solaris.c |5 +
net/tap.c | 21 +
net/tap.h
Signed-off-by: Mark McLoughlin
---
Makefile |1 +
net/tap-solaris.c | 185 +
net/tap.c | 168 +---
net/tap.h |2 +
4 files changed, 191 insertions(+), 165 deletions
TUNSETSNDBUF is only available on linux
Signed-off-by: Mark McLoughlin
---
net/tap-aix.c |6 ++
net/tap-bsd.c |5 +
net/tap-linux.c | 23 +++
net/tap-solaris.c |5 +
net/tap.c | 25 +
net/tap.h
ng to update
the guest kernels.
Signed-off-by: Anthony Liguori
Signed-off-by: Mark McLoughlin
---
hw/virtio-net.c | 29 +
1 files changed, 29 insertions(+), 0 deletions(-)
diff --git a/hw/virtio-net.c b/hw/virtio-net.c
index 3fb10a2..e00c404 100644
--- a/hw/virtio-
So I can add a tap-linux.c and use CONFIG_LINUX to pull it in
in Makefile
Signed-off-by: Mark McLoughlin
---
configure |4
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/configure b/configure
index 43d87c5..4ccdebe 100755
--- a/configure
+++ b/configure
@@ -1897,6
We query the guest's feature set to see if it supports offload and,
if so, we enable those features on the tap interface.
Signed-off-by: Mark McLoughlin
---
hw/virtio-net.c | 18 ++
1 files changed, 18 insertions(+), 0 deletions(-)
diff --git a/hw/virtio-net.c b/hw/v
Okay, this makes the tap options available on AIX even though there's
no support, but if we want to do it right we should have not compile
the tap code at all on AIX using e.g. CONFIG_TAP.
Signed-off-by: Mark McLoughlin
---
Makefile |1 +
net.c |2 --
net/tap-aix.c |
host
which does support it.
Signed-off-by: Mark McLoughlin
---
net.c | 42 --
qemu-options.hx |4 +++-
2 files changed, 35 insertions(+), 11 deletions(-)
diff --git a/net.c b/net.c
index fccabdb..d62ab7b 100644
--- a/net.c
+++ b/net.c
Signed-off-by: Mark McLoughlin
---
Makefile|1 +
net/tap-linux.c | 78 +++
net/tap.c | 47 -
3 files changed, 79 insertions(+), 47 deletions(-)
create mode 100644 net/tap-linux.c
diff
Only supported on Linux
Signed-off-by: Mark McLoughlin
---
net/tap-aix.c |5 +
net/tap-bsd.c |5 +
net/tap-linux.c | 12
net/tap-solaris.c |5 +
net/tap.c |7 +--
net/tap.h |1 +
6 files changed, 29 insertions(+), 6
This API allows virtio-net to enable various offload features on a
tap interface - e.g. to tell the host kernel it can pass up partial
checksums to userspace.
Signed-off-by: Mark McLoughlin
---
net.c | 24
net.h |1 +
tap-linux.h |7 +++
3
s not associated with a vlan.
Signed-off-by: Gleb Natapov
Signed-off-by: Mark McLoughlin
---
savevm.c |7 +--
1 files changed, 1 insertions(+), 6 deletions(-)
diff --git a/savevm.c b/savevm.c
index 99aa15a..ac1ef42 100644
--- a/savevm.c
+++ b/savevm.c
@@ -114,8 +114,6 @@ stati
Trivial patch to allow supplying a receive_raw function.
A future cleanup should combine this function pointer parameters into a
table.
Signed-off-by: Mark McLoughlin
---
hw/dp8393x.c |2 +-
hw/etraxfs_eth.c |2 +-
hw/mcf_fec.c |2 +-
hw/mipsnet.c |2 +-
hw/qdev.c
On Thu, 2009-10-22 at 15:34 -0500, Anthony Liguori wrote:
> Mark McLoughlin wrote:
> > Hey,
> > We've been meaning to split net.c up for quite a while now,
> > so here goes with a first cut at.
> >
> > There shouldn't be anything too cont
On Thu, 2009-10-22 at 20:53 +0200, Juan Quintela wrote:
> Mark McLoughlin wrote:
> > Hey,
> > We've been meaning to split net.c up for quite a while now,
> > so here goes with a first cut at.
>
> If you have to respin this series, please use
>
> git
Hi,
Any ideas on this segfault a Fedora 12 user (Gene, cc-ed) is seeing?
Thread 1 (Thread 2849):
#0 0x7f25fcd10f70 in memset () from /lib64/libc.so.6
No symbol table info available.
#1 0x004babc6 in audio_capture_mix_and_clear (samples=-1099358712,
rpos=, hw=) at audio/audio.c:
On Fri, 2009-10-23 at 17:41 +0400, malc wrote:
> On Fri, 23 Oct 2009, malc wrote:
>
> > On Fri, 23 Oct 2009, Mark McLoughlin wrote:
> >
> > > Hi,
> > >
> > > Any ideas on this segfault a Fedora 12 user (Gene, cc-ed) is seeing?
>
> [..s
On Fri, 2009-10-23 at 20:25 +0400, Michael Tokarev wrote:
> I've two questions:
>
> o what's the intended usage of all-vlan-equal case, when kvm (or qemu)
>reflects packets from one interface to another? It's what bridge
>in linux is for, I think.
I don't think it's necessarily an intend
On Fri, 2009-10-23 at 08:44 -0500, Anthony Liguori wrote:
> Mark McLoughlin wrote:
> > On Thu, 2009-10-22 at 15:34 -0500, Anthony Liguori wrote:
> >
> >> This series doesn't build for me. I get dependency errors even after a
> >> full rebuild. I
[v2: handle building in a separate dir]
Signed-off-by: Mark McLoughlin
---
Makefile | 10 +++---
configure |2 +-
net.h |2 +-
net-queue.c => net/queue.c |2 +-
net-queue.h => net/queue.h |0
5 files chang
Now that we disable any receiver whose queue is full, we do not require
senders to handle a zero return by supplying a sent callback.
This is a second step towards allowing can_receive() handlers to return
true even if no buffer space is available.
Signed-off-by: Mark McLoughlin
---
net
time.
Reported-by: Scott Tsai
Tested-by: Sven Rudolph
Signed-off-by: Mark McLoughlin
---
net/tap.c | 33 +++--
1 files changed, 15 insertions(+), 18 deletions(-)
diff --git a/net/tap.c b/net/tap.c
index 60354e4..f32226b 100644
--- a/net/tap.c
+++ b/net/tap.c
@@
Hey,
Scott points out that the current behaviour of draining the
entire queue in tap_send() doesn't work with non-virtio NICs because
we drop a packet when the NIC queue fills up.
This series of patches first disables this behaviour, fixes
various aspects of the queueing logic and
buffer space is available.
Signed-off-by: Mark McLoughlin
---
net.c | 49 ++---
net.h |1 +
2 files changed, 39 insertions(+), 11 deletions(-)
diff --git a/net.c b/net.c
index 661bbc1..9dea615 100644
--- a/net.c
+++ b/net.c
@@ -423,11 +423,13
le it.
This patch should be a performance improvement since we no longer have
to go through the mainloop for each packet.
Signed-off-by: Mark McLoughlin
---
net/tap.c | 33 ++---
1 files changed, 18 insertions(+), 15 deletions(-)
diff --git a/net/tap.c b/net/tap.c
ceive(), but instead just allow
receive() to return zero when this condition occurs and have the caller
handle queueing the packet.
Signed-off-by: Mark McLoughlin
---
hw/virtio-net.c | 21 -
1 files changed, 12 insertions(+), 9 deletions(-)
diff --git a/hw/virtio-net.c b/h
time.
Reported-by: Scott Tsai
Tested-by: Sven Rudolph
Signed-off-by: Mark McLoughlin
---
net.c | 18 --
1 files changed, 8 insertions(+), 10 deletions(-)
diff --git a/net.c b/net.c
index 3d3829d..7466961 100644
--- a/net.c
+++ b/net.c
@@ -1378,17 +1378,15 @@ static void tap_se
On Wed, 2009-10-28 at 11:36 +0800, Scott Tsai wrote:
> > Scott, Sven, if you could test the tap-drain-queue branch from
> > my tree, that would be great:
> > http://repo.or.cz/w/qemu/markmc.git
> >
> > Thanks,
> > Mark.
>
> Mark,
> I've tested http://repo.or.cz/w/qemu/markmc.git and it
.
Signed-off-by: Mark McLoughlin
---
hw/virtio-net.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/hw/virtio-net.c b/hw/virtio-net.c
index 93294af..4b09a93 100644
--- a/hw/virtio-net.c
+++ b/hw/virtio-net.c
@@ -837,6 +837,7 @@ VirtIODevice *virtio_net_init(DeviceState *dev
Hi Anthony,
Thanks for merging this stuff ...
In the process of merging it all into qemu-kvm, I noticed a couple of
problems:
1) bb6e63644 lacked the change to add the type code to
qemu_new_vlan_client() so that and the subsequent 14 commits are
unbuildable
2) 93d
On Wed, 2009-10-28 at 10:26 -0500, Anthony Liguori wrote:
> Mark McLoughlin wrote:
> > Hi Anthony,
> > Thanks for merging this stuff ...
> >
> > In the process of merging it all into qemu-kvm, I noticed a couple of
> > problems:
> >
> > 1) bb6
Hi Dustin,
On Wed, 2009-10-28 at 14:22 -0500, Dustin Kirkland wrote:
> I believe that we have identified a regression in qemu-kvm-0.11.0.
Regression versus which previous version of qemu-kvm?
> The kvm process crashes for older guests with virtio networking, when
> the guest's incoming network c
On Thu, 2009-10-29 at 20:00 +0800, Scott Tsai wrote:
> Excerpts from Mark McLoughlin's message of Thu Oct 29 17:16:43 +0800 2009:
> > Assuming this is something like the virtio-net in 2.6.26, there was no
> > receivable buffers support so (as Scott points out) it must be that
> > we've read a packe
On Thu, 2009-10-29 at 09:11 -0500, Anthony Liguori wrote:
> Mark McLoughlin wrote:
> >
> >>tap_set_offload(csum: 1, tso4: 1, tso6: 1, ecn: 1)
> >> being called and get an mtu of 1500 on virbr0 using his birdge.sh script.
> >>
> >> virtio_net_recei
On Thu, 2009-10-29 at 09:39 -0500, Anthony Liguori wrote:
> Mark McLoughlin wrote:
> > On Thu, 2009-10-29 at 09:11 -0500, Anthony Liguori wrote:
> >
> >> Mark McLoughlin wrote:
> >>
> >>>> tap_set_offload(csum: 1, tso4: 1, tso6: 1, ecn:
On Thu, 2009-10-29 at 09:46 -0500, Dustin Kirkland wrote:
> On Thu, 2009-10-29 at 09:34 -0500, Dustin Kirkland wrote:
> > In the mean time, Hardy's kernel is in git here:
> >
> > http://kernel.ubuntu.com/git?p=ubuntu/ubuntu-hardy.git;a=summary
>
> I'll save you a few clicks...
>
> http://kernel.
On Thu, 2009-10-29 at 10:01 -0500, Dustin Kirkland wrote:
> On Thu, 2009-10-29 at 14:48 +0000, Mark McLoughlin wrote:
> > Ah, it all makes sense now.
> >
> > I was getting confused between HOST_* and GUEST_*
> >
> > this should have been:
> >
>
On Thu, 2009-10-29 at 10:13 -0500, Dustin Kirkland wrote:
> On Thu, 2009-10-29 at 15:01 +0000, Mark McLoughlin wrote:
> > Sorry, should be VIRTIO_NET_F_CSUM ... the rest is correct
>
> Brilliant!
>
> Works like a champ. I'll send a patch in a subsequent email. Would
On Fri, 2009-10-30 at 11:21 -0500, Anthony Liguori wrote:
> Mark McLoughlin wrote:
> > Okay, let's try re-enabling the drain-entire-queue behaviour, with a
> > difference - before each subsequent packet, use qemu_can_send_packet()
> > to check that we can send it. This
Hi,
On Fri, 2009-10-30 at 11:04 +0100, juha.riihim...@nokia.com wrote:
> On Oct 22, 2009, at 19:43, ext Mark McLoughlin wrote:
>
> > Hey,
> >Over a year ago we added some code to qemu-kvm.git which takes
> > advantage of the recent tun/tap IFF_VNET_HDR f
On Fri, 2009-10-30 at 16:15 -0500, Dustin Kirkland wrote:
> On Thu, Oct 29, 2009 at 10:34 AM, Dustin Kirkland
> wrote:
> > whitelist host virtio networking features
> >
> > This patch is a followup to 8eca6b1bc770982595db2f7207c65051572436cb,
> > fixing crashes when guests with 2.6.25 virtio drive
Hey,
Just a heads up - on 32 bit hosts where qemu was using preadv and
pwritev, we were seeing data corruption due to file offset being
truncated:
https://bugzilla.redhat.com/533063
https://bugzilla.redhat.com/526549
The glibc headers fix is posted here:
http://sources.redh
On Tue, 2009-11-10 at 15:44 +, Paul Brook wrote:
> On Thursday 08 October 2009, Mark McLoughlin wrote:
> > Hi,
> > Here's a series of patches which gets the ball rolling on adding
> > a -netdev option.
> >...
> > The idea is to de-emphas
On Fri, 2009-11-06 at 15:58 +0100, Juan Quintela wrote:
> commit b04c4134d6de28c249277de19e523bfbe4aebbd6
> broke incoming migration. After talking with Gleb, code was intended
> to be the way is in this fix. This fixes migration here.
Tried to reproduce and it works fine for me. More details?
On Tue, 2009-11-10 at 18:03 +0100, Juan Quintela wrote:
> Mark McLoughlin wrote:
> > On Fri, 2009-11-06 at 15:58 +0100, Juan Quintela wrote:
> >> commit b04c4134d6de28c249277de19e523bfbe4aebbd6
> >> broke incoming migration. After talking with Gleb, code was intend
On Thu, 2009-11-12 at 03:31 +, Armin Garcia wrote:
> I have the next problem I configure the tun/tap and all great any error,
> I have an IP from my dhcp, I can see my virtual machine (winxp) from my
> other computers, but In my virtual machine I cant connect to internet,
> I mean, whe
No doubt this is the worst idea ever, but the requirement is simple -
some way to iterate all NICs in the system.
Signed-off-by: Mark McLoughlin
---
hw/qdev.c | 20
hw/qdev.h |3 +++
2 files changed, 23 insertions(+), 0 deletions(-)
diff --git a/hw/qdev.c b/hw/qdev.c
Probably the second worst idea in the world, ever.
While iterating over all NICs in the system, we need to be
able to query their 'net-client' and 'macaddr' properties.
Signed-off-by: Mark McLoughlin
---
hw/qdev-properties.c | 31 ---
hw/qdev
Since 1cc33683, this field is not set for most devices, so just
remove it and its remaining few uses.
Signed-off-by: Mark McLoughlin
---
hw/dp8393x.c | 10 +-
hw/etraxfs_eth.c | 10 +-
hw/mcf_fec.c | 10 +-
hw/mipsnet.c | 10 +-
hw/usb-net.c
Hi,
The recent "fix" to qemu_announce_self() will segfault if you use
-netdev. The real root cause of the regression was the removal of the
assignment to NICInfo::vc that used to live in qdev_get_vlan_client().
Now that NICs are qdev-ified, we should just iterate over the
qdev tre
Now that we have a sane way of iterating over NICs.
Signed-off-by: Mark McLoughlin
---
savevm.c | 43 ++-
1 files changed, 26 insertions(+), 17 deletions(-)
diff --git a/savevm.c b/savevm.c
index 039740c..3736588 100644
--- a/savevm.c
+++ b/savevm.c
vlan.
Another advantage is that we can easily get the client associated with
a qdev.
Signed-off-by: Mark McLoughlin
---
hw/qdev-properties.c | 25 +
hw/qdev.h|5 +
net.h|8 +---
3 files changed, 35 insertions(+), 3 deletions(-
Signed-off-by: Mark McLoughlin
---
hw/dp8393x.c| 10 +-
hw/e1000.c | 10 +-
hw/eepro100.c | 10 +-
hw/etraxfs_eth.c| 11 +--
hw/mcf_fec.c| 10 +-
hw/mipsnet.c| 15 ++-
hw/musicpal.c
No valid users left except the announce_self() code which currently
crashes when used with -netdev.
Note the assertion in the xen code. Need to figure out how to support
the -netdev arg with xen.
Signed-off-by: Mark McLoughlin
---
hw/integratorcp.c|3 +-
hw/mcf5208.c |3
On Thu, 2009-11-12 at 20:29 +, Mark McLoughlin wrote:
...
> +printf("qemu_announce_self_iter() mac = %p\n", mac);
> +
> +len = announce_self_create(buf, mac);
> +
> +printf("sending packet from %s\n", client->name);
Ooops, some debugging
Hi Gerd,
Thanks for looking, you're absolutely right that this approach just
isn't right with e.g. -device
On Mon, 2009-11-16 at 10:28 +0100, Gerd Hoffmann wrote:
> On 11/12/09 21:29, Mark McLoughlin wrote:
> > No doubt this is the worst idea ever, but the requirement is simpl
460fec67ee introduced a use-after free in slirp.
Cc: Jan Kiszka
Signed-off-by: Mark McLoughlin
---
Untested fix, but it's obvious.
Also, this is needed on stable-0.11.
slirp/mbuf.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/slirp/mbuf.c b/slirp/mbuf.c
Hi,
I wrote up some notes on the QCOW format:
http://www.gnome.org/~markmc/qcow-image-format.html
Perhaps worth including in QEMU itself?
Cheers,
Mark.
___
Qemu-devel mailing list
Qemu-devel@nongnu.org
http://lists.nongnu.org/mailm
mentation html page. I can
> also commit it in the QEMU sources if you want.
>
> Regards,
>
> Fabrice.
>
> Mark McLoughlin wrote:
> > Hi,
> > I wrote up some notes on the QCOW format:
> >
> > http://www.gnome.org/~markmc/qcow-image-form
Hi,
I wrote up some notes on the QCOW format:
http://www.gnome.org/~markmc/qcow-image-format.html
Perhaps worth including in QEMU itself?
Cheers,
Mark.
___
Qemu-devel mailing list
Qemu-devel@nongnu.org
http://lists.nongnu.org/mailm
101 - 164 of 164 matches
Mail list logo
