Re: [Qemu-devel] [PATCH 0/2] netdev fixes

2011-07-20 Thread Mark McLoughlin
rge them himself), there's plenty of time. > > > Or who should initially receive related patches now? > > > > Jan > > I think running ./scripts/get_maintainer.pl is generally > a good idea. For net you'd get: > > [qemu]$ ./scripts/get_maintainer.pl -f net.c net/ > Anthony Liguori (maintainer:Network device > layer,commit_signer:4/16=25%) > Mark McLoughlin (maintainer:Network device layer) This is clearly out of date - feel free to remove it Cheers, Mark.

[Qemu-devel] Open Source Virtualization and Cloud at FOSDEM

2011-11-11 Thread Mark McLoughlin
Hey, Here's one for the calendar - a 2 day track at FOSDEM devoted to Open Source Virtualization and Cloud. Hope to see you there! :) Cheers, Mark. Forwarded Message > From: Thierry Carrez > To: openst...@lists.launchpad.net > Subject: [Openstack] OpenStack at FOSDEM > Date:

[Qemu-devel] Re: [PATCH 0/6] Assorted netdev fixes

2010-02-11 Thread Mark McLoughlin
lients() checks only VLAN clients, fix > net: info network shows only VLAN clients, fix > net: Monitor command set_link finds only VLAN clients, fix Nice. They all look good to me Acked-by: Mark McLoughlin Cheers, Mark.

[Qemu-devel] [PATCH] net: initialize vnet_hdr in net_tap_init()

2009-11-24 Thread Mark McLoughlin
u? Thanks, Mark. From: Mark McLoughlin Subject: [PATCH] net: initialize vnet_hdr in net_tap_init() Don't assume that all tap_open() implementations will set it to zero if VNET_HDR support isn't found. Fixes tap networking on host kernels lacking IFF_VNET_HDR support. Reported-by: Pi

[Qemu-devel] Re: [PATCH] Fix TAP networking on host kernels without IFF_VNET_HDR support

2009-11-24 Thread Mark McLoughlin
On Tue, 2009-11-24 at 10:06 +0100, Pierre Riteau wrote: > vnet_hdr is initialized at 1 by default. We need to reset it to 0 if > the kernel doesn't support IFF_VNET_HDR. > > Signed-off-by: Pierre Riteau Thanks Pierre, I see why this is needed now Acked-by: Mark McLoughlin Cheers, Mark.

Re: [Qemu-devel] Re: [PATCH] Fix TAP networking on host kernels without IFF_VNET_HDR support

2009-11-24 Thread Mark McLoughlin
On Tue, 2009-11-24 at 12:17 +0100, Pierre Riteau wrote: > On 24 nov. 2009, at 11:28, Mark McLoughlin wrote: > > > On Tue, 2009-11-24 at 10:06 +0100, Pierre Riteau wrote: > >> vnet_hdr is initialized at 1 by default. We need to reset it to 0 if > >> the kerne

Re: [Qemu-devel] Re: [PATCH] Fix TAP networking on host kernels without IFF_VNET_HDR support

2009-11-25 Thread Mark McLoughlin
On Tue, 2009-11-24 at 22:27 +0100, Pierre Riteau wrote: > On 24 nov. 2009, at 12:22, Mark McLoughlin wrote: > > > On Tue, 2009-11-24 at 12:17 +0100, Pierre Riteau wrote: > >> Isn't there a way to detect whether the kernel supports the > >> TUNSETOFFLOAD ioctl a

Re: [Qemu-devel] [PATCH] Check for TUNSETOFFLOAD support before trying to enable offload features

2009-11-25 Thread Mark McLoughlin
On Wed, 2009-11-25 at 11:04 +0100, Pierre Riteau wrote: > This avoids the "TUNSETOFFLOAD ioctl() failed: Invalid argument" message > on kernels without TUNSETOFFLOAD support. > > Signed-off-by: Pierre Riteau Acked-by: Mark McLoughlin Thanks, Mark. > --- > net/t

[Qemu-devel] [PATCH 03/44] net: move socket backend code from net.c to net/socket.c

2009-11-25 Thread Mark McLoughlin
Signed-off-by: Mark McLoughlin --- Makefile |1 + net.c| 530 +-- net/socket.c | 561 ++ net/socket.h | 33 4 files changed, 596 insertions(+), 529 deletions

[Qemu-devel] [PATCH 00/44] Fix announce_self(), misc net fixes and cleanups

2009-11-25 Thread Mark McLoughlin
Hi, Here's a new series of patches mainly to fix qemu_announce_self() with -netdev as discussed earlier on the list. I would have liked to have split the series in three, but there would be conflicts between each, so here goes: 1) Patches 01 to 05 - net.c cleanups These p

[Qemu-devel] [PATCH 02/44] net: move vde code from net.c to net/vde.c

2009-11-25 Thread Mark McLoughlin
Signed-off-by: Mark McLoughlin --- Makefile |1 + net.c | 102 +- net/vde.c | 124 + net/vde.h | 36 ++ 4 files changed, 162 insertions(+), 101 deletions

[Qemu-devel] [PATCH 04/44] net: move dump backend code from net.c to net/dump.c

2009-11-25 Thread Mark McLoughlin
Signed-off-by: Mark McLoughlin --- Makefile |1 + net.c | 127 +-- net/dump.c | 151 net/dump.h | 33 + 4 files changed, 186 insertions(+), 126 deletions

[Qemu-devel] [PATCH 01/44] net: move slirp code from net.c to net/slirp.c

2009-11-25 Thread Mark McLoughlin
Signed-off-by: Mark McLoughlin --- Makefile|1 + monitor.c |1 + net.c | 718 +--- net.h |8 +- net/slirp.c | 752 +++ net/slirp.h | 51 vl.c

[Qemu-devel] [PATCH 06/44] net: remove NICInfo::vc

2009-11-25 Thread Mark McLoughlin
Since 1cc33683, this field is not set for most devices, so just remove it and its remaining few uses. Signed-off-by: Mark McLoughlin --- hw/dp8393x.c | 10 +- hw/etraxfs_eth.c | 10 +- hw/mcf_fec.c | 10 +- hw/mipsnet.c | 10 +- hw/usb-net.c

[Qemu-devel] [PATCH 09/44] net: introduce qemu_new_net_client()

2009-11-25 Thread Mark McLoughlin
A replacement for qemu_new_vlan_client(), using NetClientInfo to replace most arguments. Signed-off-by: Mark McLoughlin --- net.c | 70 +--- net.h |5 2 files changed, 54 insertions(+), 21 deletions(-) diff --git a/net.c b

[Qemu-devel] [PATCH 17/44] net: introduce NICState and qemu_new_nic()

2009-11-25 Thread Mark McLoughlin
Common state for all NICs. The opaque member will replace the opaque member in VLANClientState since only NICs need it. The conf member will allow us to iterate over NICs, access the MAC addr for the NIC and send a packet from each NIC in qemu_announce_self(). Signed-off-by: Mark McLoughlin

[Qemu-devel] [PATCH 10/44] qdev: move DO_UPCAST() into osdep.h

2009-11-25 Thread Mark McLoughlin
Nothing qdev specific about this, make it available throughtout. Signed-off-by: Mark McLoughlin --- hw/qdev.h | 10 -- osdep.h | 10 ++ 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/hw/qdev.h b/hw/qdev.h index 41642ee..8d53754 100644 --- a/hw/qdev.h

[Qemu-devel] [PATCH 11/44] net: convert tap to NetClientInfo

2009-11-25 Thread Mark McLoughlin
Signed-off-by: Mark McLoughlin --- net/tap.c | 82 +--- 1 files changed, 45 insertions(+), 37 deletions(-) diff --git a/net/tap.c b/net/tap.c index b2e5908..d34feec 100644 --- a/net/tap.c +++ b/net/tap.c @@ -47,7 +47,7 @@ #define

[Qemu-devel] [PATCH 28/44] net: convert mipsnet to NICState

2009-11-25 Thread Mark McLoughlin
Signed-off-by: Mark McLoughlin --- hw/mipsnet.c | 45 +++-- 1 files changed, 27 insertions(+), 18 deletions(-) diff --git a/hw/mipsnet.c b/hw/mipsnet.c index 67160a4..a066f63 100644 --- a/hw/mipsnet.c +++ b/hw/mipsnet.c @@ -35,7 +35,8 @@ typedef struct

[Qemu-devel] [PATCH 34/44] net: move parse_macaddr() to net/util.[ch]

2009-11-25 Thread Mark McLoughlin
Signed-off-by: Mark McLoughlin --- Makefile |2 +- net.c | 35 ++- net/util.c | 60 net/util.h | 32 4 files changed, 95 insertions(+), 34 deletions

[Qemu-devel] [PATCH 35/44] net: convert xen to NICState

2009-11-25 Thread Mark McLoughlin
Signed-off-by: Mark McLoughlin --- hw/xen_nic.c | 46 +- 1 files changed, 29 insertions(+), 17 deletions(-) diff --git a/hw/xen_nic.c b/hw/xen_nic.c index bcf161c..08055b8 100644 --- a/hw/xen_nic.c +++ b/hw/xen_nic.c @@ -41,6 +41,7 @@ #include

[Qemu-devel] [PATCH 22/44] net: convert pcnet to NICState

2009-11-25 Thread Mark McLoughlin
Signed-off-by: Mark McLoughlin --- hw/lance.c | 14 +++--- hw/pcnet.c | 43 +++ hw/pcnet.h |7 --- 3 files changed, 38 insertions(+), 26 deletions(-) diff --git a/hw/lance.c b/hw/lance.c index 0a96644..98033a4 100644 --- a/hw/lance.c

[Qemu-devel] [PATCH 12/44] net: convert tap-win32 to NetClientInfo

2009-11-25 Thread Mark McLoughlin
Signed-off-by: Mark McLoughlin --- net/tap-win32.c | 39 +++ 1 files changed, 23 insertions(+), 16 deletions(-) diff --git a/net/tap-win32.c b/net/tap-win32.c index ea66471..ef63782 100644 --- a/net/tap-win32.c +++ b/net/tap-win32.c @@ -630,25 +630,24

[Qemu-devel] [PATCH 21/44] net: convert ne2000 to NICState

2009-11-25 Thread Mark McLoughlin
Signed-off-by: Mark McLoughlin --- hw/ne2000-isa.c | 22 ++ hw/ne2000.c | 35 +-- hw/ne2000.h |2 +- 3 files changed, 36 insertions(+), 23 deletions(-) diff --git a/hw/ne2000-isa.c b/hw/ne2000-isa.c index 729e8e2..0260f84

[Qemu-devel] [PATCH 07/44] net: remove NICInfo::private

2009-11-25 Thread Mark McLoughlin
Was used by hot-unplug, but not anymore. Signed-off-by: Mark McLoughlin --- net.h |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/net.h b/net.h index bc8392b..9ffcfe3 100644 --- a/net.h +++ b/net.h @@ -124,7 +124,6 @@ struct NICInfo { char *devaddr; VLANState

[Qemu-devel] [PATCH 05/44] net: clean up includes in net.c

2009-11-25 Thread Mark McLoughlin
This is probably a little drastic, but the includes in this file are now totally out of control when compared with what includes are actually needed. This may break the build on e.g. *BSD, but it will be easily fixed by re-instating an include. Signed-off-by: Mark McLoughlin --- net.c | 74

[Qemu-devel] [PATCH 13/44] net: convert slirp to NetClientInfo

2009-11-25 Thread Mark McLoughlin
Signed-off-by: Mark McLoughlin --- net/slirp.c | 61 +++--- 1 files changed, 37 insertions(+), 24 deletions(-) diff --git a/net/slirp.c b/net/slirp.c index d6d5772..3f91c4b 100644 --- a/net/slirp.c +++ b/net/slirp.c @@ -64,8 +64,8 @@ struct

[Qemu-devel] [PATCH 26/44] net: convert LAN9118 to NICState

2009-11-25 Thread Mark McLoughlin
Signed-off-by: Mark McLoughlin --- hw/lan9118.c | 45 + 1 files changed, 25 insertions(+), 20 deletions(-) diff --git a/hw/lan9118.c b/hw/lan9118.c index 6394f3a..ba982d1 100644 --- a/hw/lan9118.c +++ b/hw/lan9118.c @@ -137,7 +137,7 @@ typedef

[Qemu-devel] [PATCH 39/44] net: fix qemu_announce_self()

2009-11-25 Thread Mark McLoughlin
Now that we have a way to iterate NICs. Signed-off-by: Mark McLoughlin --- savevm.c | 26 +- 1 files changed, 13 insertions(+), 13 deletions(-) diff --git a/savevm.c b/savevm.c index 4668843..3cfc5aa 100644 --- a/savevm.c +++ b/savevm.c @@ -123,24 +123,24 @@ static

[Qemu-devel] [PATCH 41/44] net: fix TAP networking on host kernels without IFF_VNET_HDR support

2009-11-25 Thread Mark McLoughlin
From: Pierre Riteau vnet_hdr is initialized at 1 by default. We need to reset it to 0 if the kernel doesn't support IFF_VNET_HDR. Signed-off-by: Pierre Riteau Signed-off-by: Mark McLoughlin --- net/tap-linux.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/ne

[Qemu-devel] [PATCH 14/44] net: convert vde to NetClientInfo

2009-11-25 Thread Mark McLoughlin
Signed-off-by: Mark McLoughlin --- net/vde.c | 45 - 1 files changed, 28 insertions(+), 17 deletions(-) diff --git a/net/vde.c b/net/vde.c index 4d09967..42b4633 100644 --- a/net/vde.c +++ b/net/vde.c @@ -34,7 +34,7 @@ #include "sys

[Qemu-devel] [PATCH 33/44] net: convert xilinx_ethlite to NICState

2009-11-25 Thread Mark McLoughlin
Signed-off-by: Mark McLoughlin --- hw/xilinx_ethlite.c | 35 --- 1 files changed, 20 insertions(+), 15 deletions(-) diff --git a/hw/xilinx_ethlite.c b/hw/xilinx_ethlite.c index b7129d5..37e33ec 100644 --- a/hw/xilinx_ethlite.c +++ b/hw/xilinx_ethlite.c @@ -51,7

[Qemu-devel] [PATCH 36/44] net: remove qemu_new_vlan_client()

2009-11-25 Thread Mark McLoughlin
... and VLANClientState::opaque and qemu_find_vlan_client(). All of these are now unused Signed-off-by: Mark McLoughlin --- net.c | 44 net.h | 13 - 2 files changed, 0 insertions(+), 57 deletions(-) diff --git a/net.c b/net.c index

[Qemu-devel] [PATCH 38/44] net: add qemu_foreach_nic()

2009-11-25 Thread Mark McLoughlin
Signed-off-by: Mark McLoughlin --- net.c | 20 net.h |2 ++ 2 files changed, 22 insertions(+), 0 deletions(-) diff --git a/net.c b/net.c index a1ec243..c71699d 100644 --- a/net.c +++ b/net.c @@ -326,6 +326,26 @@ qemu_find_vlan_client_by_name(Monitor *mon, int vlan_id

[Qemu-devel] [PATCH 40/44] net: print correct error for '-netdev ""'

2009-11-25 Thread Mark McLoughlin
Reported-by: Markus Armbruster Signed-off-by: Mark McLoughlin --- net.c | 16 +++- 1 files changed, 11 insertions(+), 5 deletions(-) diff --git a/net.c b/net.c index c71699d..13bdbb2 100644 --- a/net.c +++ b/net.c @@ -1055,12 +1055,18 @@ int net_client_init(Monitor *mon, QemuOpts

[Qemu-devel] [PATCH 32/44] net: convert usb-net to NICState

2009-11-25 Thread Mark McLoughlin
Signed-off-by: Mark McLoughlin --- hw/usb-net.c | 57 +++-- 1 files changed, 31 insertions(+), 26 deletions(-) diff --git a/hw/usb-net.c b/hw/usb-net.c index 7b8cc7a..2556e05 100644 --- a/hw/usb-net.c +++ b/hw/usb-net.c @@ -610,7 +610,6

[Qemu-devel] [PATCH 43/44] net: initialize vnet_hdr in net_init_tap()

2009-11-25 Thread Mark McLoughlin
net_tap_init() always sets vnet_hdr using qemu_opt_get_bool(), but initialize it in net_init_tap() just to reduce confusion. Signed-off-by: Mark McLoughlin --- net/tap.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/net/tap.c b/net/tap.c index a327a9a..0d8b424 100644

[Qemu-devel] [PATCH 25/44] net: convert etrax to NICState

2009-11-25 Thread Mark McLoughlin
Signed-off-by: Mark McLoughlin --- hw/etraxfs_eth.c | 45 +++-- 1 files changed, 27 insertions(+), 18 deletions(-) diff --git a/hw/etraxfs_eth.c b/hw/etraxfs_eth.c index 2cc2332..dedd107 100644 --- a/hw/etraxfs_eth.c +++ b/hw/etraxfs_eth.c @@ -319,7

[Qemu-devel] [PATCH 42/44] net: check for TUNSETOFFLOAD support before trying to enable offload features

2009-11-25 Thread Mark McLoughlin
From: Pierre Riteau This avoids the "TUNSETOFFLOAD ioctl() failed: Invalid argument" message on kernels without TUNSETOFFLOAD support. Signed-off-by: Pierre Riteau Signed-off-by: Mark McLoughlin --- net/tap-linux.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) di

[Qemu-devel] [PATCH 27/44] net: convert mcf_fec to NICState

2009-11-25 Thread Mark McLoughlin
Signed-off-by: Mark McLoughlin --- hw/mcf_fec.c | 58 +- 1 files changed, 33 insertions(+), 25 deletions(-) diff --git a/hw/mcf_fec.c b/hw/mcf_fec.c index 8242c8a..4e7fbed 100644 --- a/hw/mcf_fec.c +++ b/hw/mcf_fec.c @@ -25,7 +25,8 @@ do

[Qemu-devel] [PATCH 37/44] net: remove VLANClientState members now in NetClientInfo

2009-11-25 Thread Mark McLoughlin
Add a NetClientInfo pointer to VLANClientState and use that for the typecode and function pointers. Signed-off-by: Mark McLoughlin --- hw/dp8393x.c|4 ++-- hw/virtio-net.c |2 +- net.c | 45 - net.h | 10

[Qemu-devel] [PATCH 23/44] net: convert eepro100 to NICState

2009-11-25 Thread Mark McLoughlin
Signed-off-by: Mark McLoughlin --- hw/eepro100.c | 43 --- 1 files changed, 24 insertions(+), 19 deletions(-) diff --git a/hw/eepro100.c b/hw/eepro100.c index 8734907..eb16a51 100644 --- a/hw/eepro100.c +++ b/hw/eepro100.c @@ -195,7 +195,7 @@ typedef

[Qemu-devel] [PATCH 30/44] net: convert smc91c111 to NICState

2009-11-25 Thread Mark McLoughlin
Signed-off-by: Mark McLoughlin --- hw/smc91c111.c | 35 --- 1 files changed, 20 insertions(+), 15 deletions(-) diff --git a/hw/smc91c111.c b/hw/smc91c111.c index b7398c9..c1a88c9 100644 --- a/hw/smc91c111.c +++ b/hw/smc91c111.c @@ -18,7 +18,7 @@ typedef

[Qemu-devel] [PATCH 19/44] net: convert e1000 to NICState

2009-11-25 Thread Mark McLoughlin
Signed-off-by: Mark McLoughlin --- hw/e1000.c | 47 ++- 1 files changed, 26 insertions(+), 21 deletions(-) diff --git a/hw/e1000.c b/hw/e1000.c index 00f6a57..683fdcc 100644 --- a/hw/e1000.c +++ b/hw/e1000.c @@ -75,7 +75,7 @@ enum { typedef

[Qemu-devel] [PATCH 20/44] net: convert rtl8139 to NICState

2009-11-25 Thread Mark McLoughlin
Signed-off-by: Mark McLoughlin --- hw/rtl8139.c | 43 --- 1 files changed, 24 insertions(+), 19 deletions(-) diff --git a/hw/rtl8139.c b/hw/rtl8139.c index c166db0..931cde9 100644 --- a/hw/rtl8139.c +++ b/hw/rtl8139.c @@ -459,7 +459,7 @@ typedef struct

[Qemu-devel] [PATCH 15/44] net: convert socket to NetClientInfo

2009-11-25 Thread Mark McLoughlin
Signed-off-by: Mark McLoughlin --- net/socket.c | 74 +++-- 1 files changed, 45 insertions(+), 29 deletions(-) diff --git a/net/socket.c b/net/socket.c index 551fc2b..7331d87 100644 --- a/net/socket.c +++ b/net/socket.c @@ -33,7 +33,7

[Qemu-devel] [PATCH 18/44] net: convert virtio to NICState

2009-11-25 Thread Mark McLoughlin
Signed-off-by: Mark McLoughlin --- hw/virtio-net.c | 73 +- 1 files changed, 39 insertions(+), 34 deletions(-) diff --git a/hw/virtio-net.c b/hw/virtio-net.c index 2f147e5..4f8d89e 100644 --- a/hw/virtio-net.c +++ b/hw/virtio-net.c @@ -31,7

[Qemu-devel] [PATCH 08/44] net: introduce NetClientInfo

2009-11-25 Thread Mark McLoughlin
This structure holds data which is common to all instances of a given net client type/model. Signed-off-by: Mark McLoughlin --- net.h | 11 +++ 1 files changed, 11 insertions(+), 0 deletions(-) diff --git a/net.h b/net.h index 9ffcfe3..56c5849 100644 --- a/net.h +++ b/net.h @@ -42,6

[Qemu-devel] [PATCH 24/44] net: convert dp8393x to NICState

2009-11-25 Thread Mark McLoughlin
Signed-off-by: Mark McLoughlin --- hw/dp8393x.c | 41 + 1 files changed, 25 insertions(+), 16 deletions(-) diff --git a/hw/dp8393x.c b/hw/dp8393x.c index 5143cc8..be9714d 100644 --- a/hw/dp8393x.c +++ b/hw/dp8393x.c @@ -154,7 +154,8 @@ typedef struct

[Qemu-devel] [PATCH 16/44] net: convert dump to NetClientInfo

2009-11-25 Thread Mark McLoughlin
Signed-off-by: Mark McLoughlin --- net/dump.c | 47 +++ 1 files changed, 27 insertions(+), 20 deletions(-) diff --git a/net/dump.c b/net/dump.c index 05a102b..4ed3f5f 100644 --- a/net/dump.c +++ b/net/dump.c @@ -28,7 +28,7 @@ #include "qemu-

[Qemu-devel] [PATCH 29/44] net: convert musicpal to NICState

2009-11-25 Thread Mark McLoughlin
Signed-off-by: Mark McLoughlin --- hw/musicpal.c | 31 ++- 1 files changed, 18 insertions(+), 13 deletions(-) diff --git a/hw/musicpal.c b/hw/musicpal.c index 264669f..4a33e28 100644 --- a/hw/musicpal.c +++ b/hw/musicpal.c @@ -151,7 +151,7 @@ typedef struct

[Qemu-devel] [PATCH 44/44] net: fix vnet_hdr handling in solaris tap code

2009-11-25 Thread Mark McLoughlin
Print an error if the user specifies vnet_hdr=1 on the cmdline. Signed-off-by: Mark McLoughlin --- net/tap-solaris.c | 11 +++ 1 files changed, 11 insertions(+), 0 deletions(-) diff --git a/net/tap-solaris.c b/net/tap-solaris.c index ef4e60c..e14fe36 100644 --- a/net/tap-solaris.c

[Qemu-devel] [PATCH 31/44] net: convert stellaris to NICState

2009-11-25 Thread Mark McLoughlin
Signed-off-by: Mark McLoughlin --- hw/stellaris_enet.c | 34 +++--- 1 files changed, 19 insertions(+), 15 deletions(-) diff --git a/hw/stellaris_enet.c b/hw/stellaris_enet.c index 2252f1a..d1d755e 100644 --- a/hw/stellaris_enet.c +++ b/hw/stellaris_enet.c @@ -66,7

Re: [Qemu-devel] [PATCH 09/44] net: introduce qemu_new_net_client()

2009-11-26 Thread Mark McLoughlin
On Wed, 2009-11-25 at 20:36 +, Blue Swirl wrote: > On Wed, Nov 25, 2009 at 6:49 PM, Mark McLoughlin wrote: > > A replacement for qemu_new_vlan_client(), using NetClientInfo to > > replace most arguments. > > > +VLANClientState *qemu_new_net_cl

Re: [Qemu-devel] [PATCH, try 2] qemu/tap: add -net tap,dev= option

2009-12-09 Thread Mark McLoughlin
the long run. > > Signed-off-by: Arnd Bergmann Looks fine to me Acked-by: Mark McLoughlin Cheers, Mark.

Re: [Qemu-devel] vmware video broken in git

2009-12-10 Thread Mark McLoughlin
Hi Dave, On Fri, 2009-12-11 at 14:59 +1000, Dave Airlie wrote: > Hi guys, > > Building 0.11.0, qemu -vga vmware -sdl works fine. > with git I just get a blank screen. > > I'm trying to bisect but I keep running into a big chunk of NIC changes > where none of the drivers compile, so I thought may

Re: [Qemu-devel] Spice project is now open

2009-12-11 Thread Mark McLoughlin
On Fri, 2009-12-11 at 13:04 -0600, Anthony Liguori wrote: > But to introduce another protocol where a user has to make a choice to > use Spice over VNC, I think we need a really good justification for > that. It's really about complexity. A user shouldn't have to know > about Spice or VNC. Th

Re: [Qemu-devel] Spice project is now open

2009-12-11 Thread Mark McLoughlin
On Fri, 2009-12-11 at 13:38 -0600, Anthony Liguori wrote: > Mark McLoughlin wrote: > > On Fri, 2009-12-11 at 13:04 -0600, Anthony Liguori wrote: > > > >> But to introduce another protocol where a user has to make a choice to > >> use Spice over VNC, I think we

Re: [Qemu-devel] Re: Spice project is now open

2009-12-14 Thread Mark McLoughlin
On Mon, 2009-12-14 at 15:10 +, Daniel P. Berrange wrote: > The model I had in mind was for the proxy to define a VNC extension that > allows the client to query what 'desktops' are available and request > switching between them at any time. The list of desktop would of course > be authorized p

Re: [Qemu-devel] [RfC PATCH v3 00/10] qdev-ify network cards

2009-10-19 Thread Mark McLoughlin
amed macaddr_t to MACAddr and made it a struct. > * Adapted to netdev changes merged recently. > * Also convert ne2k_pci. > * Some new qdev properties and common bits for nics to ease > conversion. > * load pxe rom unconditionally (ne2k_pci only). Very nice, I like it. Acked-by: Mark McLoughlin Cheers, Mark.

Re: [Qemu-devel] [PATCH] qemu: work around for "posix-aio-compat"

2009-10-20 Thread Mark McLoughlin
On Thu, 2009-10-08 at 22:37 +0200, Michael S. Tsirkin wrote: > With commit ee3993069ff55fa6f1c64daf1e09963e340db8e4, > "posix-aio-compat: avoid signal race when spawning a thread" > winxp installation on a raw format file fails > during disk format, with a message "your > disk may be damaged". > >

[Qemu-devel] [PATCH 03/19] net: make tap_receive() re-use tap_receive_iov() code

2009-10-21 Thread Mark McLoughlin
In future we will want to prepend a virtio_net header if the NIC didn't supply one but IFF_VNET_HDR is enabled on the interface. This is most easily achived by using writev() in all cases. Signed-off-by: Mark McLoughlin --- net.c | 23 +++ 1 files changed, 15 inser

[Qemu-devel] [PATCH 00/19]

2009-10-21 Thread Mark McLoughlin
Hey, Over a year ago we added some code to qemu-kvm.git which takes advantage of the recent tun/tap IFF_VNET_HDR feature in order to allow virtio-net to send and receive packets with partial checksums and segmentation offloaded: http://article.gmane.org/gmane.comp.emulators.kvm.devel/20

[Qemu-devel] [PATCH 01/19] net: remove unused includes of if_tun.h and if_tap.h

2009-10-21 Thread Mark McLoughlin
Looks like these are just artifacts of vl.c being split up. Signed-off-by: Mark McLoughlin --- qemu-char.c |6 -- savevm.c|6 -- vl.c|6 -- 3 files changed, 0 insertions(+), 18 deletions(-) diff --git a/qemu-char.c b/qemu-char.c index 8084a67..7b39ace 100644

[Qemu-devel] [PATCH 08/19] net: add tap_has_vnet_hdr() and tap_using_vnet_hdr() APIs

2009-10-21 Thread Mark McLoughlin
These lamely named functions allow virtio-net to query whether IFF_VNET_HDR is enabled on a tap interface and inform the tap code that virtio-net will supply packets with a vnet header. Signed-off-by: Mark McLoughlin --- net.c | 39 +++ net.h |3 +++ 2

[Qemu-devel] [PATCH 04/19] net: enable IFF_VNET_HDR on tap fds if available

2009-10-21 Thread Mark McLoughlin
. Signed-off-by: Mark McLoughlin --- net.c | 83 +- tap-linux.h | 14 ++ 2 files changed, 84 insertions(+), 13 deletions(-) diff --git a/net.c b/net.c index 728941a..356a280 100644 --- a/net.c +++ b/net.c @@ -1245,14 +1245,20

[Qemu-devel] [PATCH 02/19] net: import linux tap ioctl definitions

2009-10-21 Thread Mark McLoughlin
Making features dependent on the availability of newer versions if_tun.h is going to get seriously clumsy, so let's just import the definitions we need. It's only a small handful. If and when we're comfortable depending on 2.6.30 headers, we can remove this again. Signed-off-by:

[Qemu-devel] [PATCH 06/19] net: add a vnet_hdr=on|off parameter

2009-10-21 Thread Mark McLoughlin
host which does support it. Signed-off-by: Mark McLoughlin --- net.c | 42 -- qemu-options.hx |4 +++- 2 files changed, 35 insertions(+), 11 deletions(-) diff --git a/net.c b/net.c index fccabdb..d62ab7b 100644 --- a/net.c +++ b/net.c

[Qemu-devel] [PATCH 07/19] net: add a client type code

2009-10-21 Thread Mark McLoughlin
This is so as to allow APIs which operate on specific client types without having to add a function table entry which is only implemented by a single client type. Signed-off-by: Mark McLoughlin --- hw/dp8393x.c |3 ++- hw/etraxfs_eth.c |3 ++- hw/mcf_fec.c |3 ++- hw

[Qemu-devel] [PATCH 13/19] net: implement tap support for receive_raw()

2009-10-21 Thread Mark McLoughlin
tap_receive_raw() always prepends a vnet header if IFF_VNET_HDR is enabled. tap_receive() only prepends when the a header is required but the NIC doesn't supply one. Signed-off-by: Mark McLoughlin --- net.c | 23 +++ 1 files changed, 19 insertions(+), 4 deletions(-)

[Qemu-devel] [PATCH 05/19] net: refactor tap initialization

2009-10-21 Thread Mark McLoughlin
such things ending up in writeconfig output? Signed-off-by: Mark McLoughlin --- net.c | 97 +++-- 1 files changed, 52 insertions(+), 45 deletions(-) diff --git a/net.c b/net.c index 356a280..fccabdb 100644 --- a/net.c +++ b/net.c

[Qemu-devel] [PATCH 15/19] net: add tap_set_offload()

2009-10-21 Thread Mark McLoughlin
This API allows virtio-net to enable various offload features on a tap interface - e.g. to tell the host kernel it can pass up partial checksums to userspace. Signed-off-by: Mark McLoughlin --- net.c | 24 net.h |1 + tap-linux.h |7 +++ 3

[Qemu-devel] [PATCH 14/19] virtio-net: add vnet_hdr support

2009-10-21 Thread Mark McLoughlin
the source host supports IFF_VNET_HDR but the destination host doesn't, we can't then stop the guest from using those features. In this scenario, we just fail the migration. Signed-off-by: Mark McLoughlin --- hw/virtio-net.c | 49 ++--- 1 fil

[Qemu-devel] [PATCH 19/19] virtio-net: add tap_has_ufo flag to saved state

2009-10-21 Thread Mark McLoughlin
If we tell the guest we support UFO and then migrate to host which doesn't support it, we will find ourselves in grave difficulties. Prevent this scenario by adding a flag to virtio-net's savevm format which indicates whether the device requires host UFO support. Signed-off-by: Mark

[Qemu-devel] [PATCH 10/19] net: add an API for 'raw' packets

2009-10-21 Thread Mark McLoughlin
In the case where a NIC and backend agree on a packet header format, this API allows injecting packets which lack the agreed upon header. We need this for sending our gratuitous ARP. Signed-off-by: Mark McLoughlin --- net-queue.h |1 + net.c | 37

[Qemu-devel] [PATCH 12/19] net: use qemu_send_packet_raw() in qemu_announce_self()

2009-10-21 Thread Mark McLoughlin
s not associated with a vlan. Signed-off-by: Gleb Natapov Signed-off-by: Mark McLoughlin --- savevm.c |7 +-- 1 files changed, 1 insertions(+), 6 deletions(-) diff --git a/savevm.c b/savevm.c index 99aa15a..ac1ef42 100644 --- a/savevm.c +++ b/savevm.c @@ -114,8 +114,6 @@ stati

[Qemu-devel] [PATCH 09/19] net: add flags parameter to packet queue interface

2009-10-21 Thread Mark McLoughlin
This allows for the addition of a raw flag, and leaves the way open for other flags too. Signed-off-by: Mark McLoughlin --- net-queue.c | 26 ++ net-queue.h |6 ++ net.c | 14 -- 3 files changed, 36 insertions(+), 10 deletions(-) diff --git

[Qemu-devel] [PATCH 16/19] virtio-net: enable tap offload if guest supports it

2009-10-21 Thread Mark McLoughlin
We query the guest's feature set to see if it supports offload and, if so, we enable those features on the tap interface. Signed-off-by: Mark McLoughlin --- hw/virtio-net.c | 18 ++ 1 files changed, 18 insertions(+), 0 deletions(-) diff --git a/hw/virtio-net.c b/hw/v

[Qemu-devel] [PATCH 17/19] Work around dhclient brokenness

2009-10-21 Thread Mark McLoughlin
ng to update the guest kernels. Signed-off-by: Anthony Liguori Signed-off-by: Mark McLoughlin --- hw/virtio-net.c | 29 + 1 files changed, 29 insertions(+), 0 deletions(-) diff --git a/hw/virtio-net.c b/hw/virtio-net.c index 19d00a6..4590594 100644 --- a/hw/virtio-

[Qemu-devel] [PATCH 18/19] Enable UFO on virtio-net and tap devices

2009-10-21 Thread Mark McLoughlin
From: Sridhar Samudrala Enable UFO on the host tap device if supported and allow setting UFO on virtio-net in the guest. Signed-off-by: Sridhar Samudrala Signed-off-by: Mark McLoughlin --- hw/virtio-net.c | 11 +-- net.c | 36 net.h

[Qemu-devel] [PATCH 11/19] net: add receive_raw parameter to qemu_new_vlan_client()

2009-10-21 Thread Mark McLoughlin
Trivial patch to allow supplying a receive_raw function. A future cleanup should combine this function pointer parameters into a table. Signed-off-by: Mark McLoughlin --- hw/dp8393x.c |2 +- hw/etraxfs_eth.c |2 +- hw/mcf_fec.c |2 +- hw/mipsnet.c |2 +- hw/qdev.c

[Qemu-devel] [PATCH 01/19] net: remove unused includes of if_tun.h and if_tap.h

2009-10-22 Thread Mark McLoughlin
Looks like these are just artifacts of vl.c being split up. Signed-off-by: Mark McLoughlin --- qemu-char.c |6 -- savevm.c|6 -- vl.c|6 -- 3 files changed, 0 insertions(+), 18 deletions(-) diff --git a/qemu-char.c b/qemu-char.c index 0fd402c..1625703 100644

[Qemu-devel] [PATCH 04/19] net: enable IFF_VNET_HDR on tap fds if available

2009-10-22 Thread Mark McLoughlin
. Signed-off-by: Mark McLoughlin --- net.c | 83 +- tap-linux.h | 14 ++ 2 files changed, 84 insertions(+), 13 deletions(-) diff --git a/net.c b/net.c index 728941a..356a280 100644 --- a/net.c +++ b/net.c @@ -1245,14 +1245,20

[Qemu-devel] [PATCH 07/19] net: add a client type code

2009-10-22 Thread Mark McLoughlin
This is so as to allow APIs which operate on specific client types without having to add a function table entry which is only implemented by a single client type. Signed-off-by: Mark McLoughlin --- hw/dp8393x.c |3 ++- hw/etraxfs_eth.c |3 ++- hw/mcf_fec.c |3 ++- hw

[Qemu-devel] [PATCH 13/19] net: implement tap support for receive_raw()

2009-10-22 Thread Mark McLoughlin
tap_receive_raw() always prepends a vnet header if IFF_VNET_HDR is enabled. tap_receive() only prepends when the a header is required but the NIC doesn't supply one. Signed-off-by: Mark McLoughlin --- net.c | 23 +++ 1 files changed, 19 insertions(+), 4 deletions(-)

[Qemu-devel] [PATCH 02/19] net: import linux tap ioctl definitions

2009-10-22 Thread Mark McLoughlin
Making features dependent on the availability of newer versions if_tun.h is going to get seriously clumsy, so let's just import the definitions we need. It's only a small handful. If and when we're comfortable depending on 2.6.30 headers, we can remove this again. Signed-off-by:

[Qemu-devel] [PATCH 00/19 v2] Add virtio-net/tap support for partial csums and GSO

2009-10-22 Thread Mark McLoughlin
Hey, Over a year ago we added some code to qemu-kvm.git which takes advantage of the recent tun/tap IFF_VNET_HDR feature in order to allow virtio-net to send and receive packets with partial checksums and segmentation offloaded: http://article.gmane.org/gmane.comp.emulators.kvm.devel/204

[Qemu-devel] [PATCH 03/19] net: make tap_receive() re-use tap_receive_iov() code

2009-10-22 Thread Mark McLoughlin
In future we will want to prepend a virtio_net header if the NIC didn't supply one but IFF_VNET_HDR is enabled on the interface. This is most easily achived by using writev() in all cases. Signed-off-by: Mark McLoughlin --- net.c | 23 +++ 1 files changed, 15 inser

[Qemu-devel] [PATCH 10/19] net: add an API for 'raw' packets

2009-10-22 Thread Mark McLoughlin
In the case where a NIC and backend agree on a packet header format, this API allows injecting packets which lack the agreed upon header. We need this for sending our gratuitous ARP. Signed-off-by: Mark McLoughlin --- net-queue.h |1 + net.c | 37

[Qemu-devel] [PATCH 08/19] net: add tap_has_vnet_hdr() and tap_using_vnet_hdr() APIs

2009-10-22 Thread Mark McLoughlin
These lamely named functions allow virtio-net to query whether IFF_VNET_HDR is enabled on a tap interface and inform the tap code that virtio-net will supply packets with a vnet header. Signed-off-by: Mark McLoughlin --- net.c | 39 +++ net.h |3 +++ 2

[Qemu-devel] [PATCH 05/19] net: refactor tap initialization

2009-10-22 Thread Mark McLoughlin
such things ending up in writeconfig output? Signed-off-by: Mark McLoughlin --- net.c | 97 +++-- 1 files changed, 52 insertions(+), 45 deletions(-) diff --git a/net.c b/net.c index 356a280..fccabdb 100644 --- a/net.c +++ b/net.c

[Qemu-devel] [PATCH 14/19] virtio-net: add vnet_hdr support

2009-10-22 Thread Mark McLoughlin
the source host supports IFF_VNET_HDR but the destination host doesn't, we can't then stop the guest from using those features. In this scenario, we just fail the migration. [v2: - add has_vnet_hdr uint32_t field for ease of vmstate conversion - use qemu_error() ] Signed-off-by: Mark M

[Qemu-devel] [PATCH 18/19] Enable UFO on virtio-net and tap devices

2009-10-22 Thread Mark McLoughlin
From: Sridhar Samudrala Enable UFO on the host tap device if supported and allow setting UFO on virtio-net in the guest. Signed-off-by: Sridhar Samudrala Signed-off-by: Mark McLoughlin --- hw/virtio-net.c | 11 +-- net.c | 36 net.h

[Qemu-devel] [PATCH 09/19] net: add flags parameter to packet queue interface

2009-10-22 Thread Mark McLoughlin
This allows for the addition of a raw flag, and leaves the way open for other flags too. Signed-off-by: Mark McLoughlin --- net-queue.c | 26 ++ net-queue.h |6 ++ net.c | 14 -- 3 files changed, 36 insertions(+), 10 deletions(-) diff --git

[Qemu-devel] [PATCH 19/19] virtio-net: add tap_has_ufo flag to saved state

2009-10-22 Thread Mark McLoughlin
fo uint8_t field for ease of vmstate conversion - use qemu_error() ] Signed-off-by: Mark McLoughlin --- hw/virtio-net.c | 23 +-- 1 files changed, 21 insertions(+), 2 deletions(-) diff --git a/hw/virtio-net.c b/hw/virtio-net.c index 31ac9ef..15b6f45 100644 --- a/hw/virtio-n

[Qemu-devel] [PATCH 00/15] Some networking code re-organization

2009-10-22 Thread Mark McLoughlin
Hey, We've been meaning to split net.c up for quite a while now, so here goes with a first cut at. There shouldn't be anything too controversial here, apart from CONFIG_LINUX maybe. I've build tested this on F11, F12 and mingw and also done some basic runtime testing.

[Qemu-devel] [PATCH 03/15] net: move tap-win32.c under net/

2009-10-22 Thread Mark McLoughlin
Signed-off-by: Mark McLoughlin --- Makefile|2 +- net/tap-win32.c | 690 +++ tap-win32.c | 690 --- 3 files changed, 691 insertions(+), 691 deletions(-) create mode 100644

[Qemu-devel] [PATCH 06/15] net: split all the tap code out into net/tap.c

2009-10-22 Thread Mark McLoughlin
Signed-off-by: Mark McLoughlin --- Makefile |1 + net.c | 692 +--- net.h |2 + net/tap.c | 759 + 4 files changed, 763 insertions(+), 691 deletions(-) create mode

[Qemu-devel] [PATCH 13/15] net: move tap_probe_vnet_hdr() to tap-linux.c

2009-10-22 Thread Mark McLoughlin
Only Linux has support for IFF_VNET_HDR Signed-off-by: Mark McLoughlin --- net/tap-aix.c |4 net/tap-bsd.c |5 + net/tap-linux.c | 12 net/tap-solaris.c |5 + net/tap.c | 12 net/tap.h |1 + 6 files changed, 27

[Qemu-devel] [PATCH 01/15] net: move net-queue.[ch] under net/

2009-10-22 Thread Mark McLoughlin
Signed-off-by: Mark McLoughlin --- Makefile|6 +- net-queue.c | 260 --- net-queue.h | 71 net.h |2 +- net/queue.c | 260 +++ net/queue.h | 71

  1   2   >