Re: [Qemu-devel] TSC in qem[-kvm] 1.1+ and in-kernel irqchip

2012-08-09 Thread Marcelo Tosatti
On Thu, Aug 09, 2012 at 10:27:43PM +0400, Michael Tokarev wrote: > As a follow-up to the patch "tsc: use kvmclock for > calibration". > > There's another problem reported by several users. > The sympthom is that grub does not show boot menu, > it boots default entry right away without any pause. >

Re: [Qemu-devel] [PATCH 13/15] hotplug: introduce qdev_unplug_complete() to remove device from views

2012-08-13 Thread Marcelo Tosatti
On Thu, Aug 09, 2012 at 10:00:16AM +0200, Paolo Bonzini wrote: > Il 09/08/2012 09:28, liu ping fan ha scritto: > >> > VCPU threadI/O thread > >> > = > >> > get MMIO request > >> > rcu_read_lock() > >

Re: [Qemu-devel] [PATCH 14/15] qom: object_unref call reclaimer

2012-08-13 Thread Marcelo Tosatti
On Wed, Aug 08, 2012 at 02:25:55PM +0800, Liu Ping Fan wrote: > From: Liu Ping Fan > > iohandler/bh/timer may use DeviceState when its refcnt=0, > postpone the reclaimer till they have done with it. > > Signed-off-by: Liu Ping Fan > --- > qom/object.c |9 - > 1 files changed, 8 ins

Re: [Qemu-devel] [PATCH 13/15] hotplug: introduce qdev_unplug_complete() to remove device from views

2012-08-13 Thread Marcelo Tosatti
On Fri, Aug 10, 2012 at 02:42:58PM +0800, liu ping fan wrote: > On Thu, Aug 9, 2012 at 4:00 PM, Paolo Bonzini wrote: > > Il 09/08/2012 09:28, liu ping fan ha scritto: > >>> > VCPU threadI/O thread > >>> > =

Re: [Qemu-devel] [PATCH 04/15] memory: MemoryRegion topology must be stable when updating

2012-08-13 Thread Marcelo Tosatti
On Thu, Aug 09, 2012 at 03:28:44PM +0800, liu ping fan wrote: > On Wed, Aug 8, 2012 at 5:13 PM, Avi Kivity wrote: > > On 08/08/2012 09:25 AM, Liu Ping Fan wrote: > >> From: Liu Ping Fan > >> > >> Using mem_map_lock to protect among updaters. So we can get the intact > >> snapshot of mem topology

Re: [Qemu-devel] [PATCH v8] kvm: notify host when the guest is panicked

2012-08-13 Thread Marcelo Tosatti
On Wed, Aug 08, 2012 at 10:43:01AM +0800, Wen Congyang wrote: > We can know the guest is panicked when the guest runs on xen. > But we do not have such feature on kvm. > > Another purpose of this feature is: management app(for example: > libvirt) can do auto dump when the guest is panicked. If man

Re: [Qemu-devel] [PATCH v8] kvm: notify host when the guest is panicked

2012-08-13 Thread Marcelo Tosatti
On Mon, Aug 13, 2012 at 01:48:39PM -0600, Eric Blake wrote: > On 08/13/2012 12:21 PM, Marcelo Tosatti wrote: > > On Wed, Aug 08, 2012 at 10:43:01AM +0800, Wen Congyang wrote: > >> We can know the guest is panicked when the guest runs on xen. > >> But we do n

Re: [Qemu-devel] [PATCH] kvm-all.c: Move init of irqchip_inject_ioctl out of kvm_irqchip_create()

2012-08-13 Thread Marcelo Tosatti
On Sun, Aug 12, 2012 at 02:13:52PM +0100, Peter Maydell wrote: > Ping? I don't think this one quite made it into Avi's pullreq... Please post this with the rest of the code to support the new s->irqchip_inject_ioctl value. > thanks > -- PMM > > On 6 August 2012 18:05, Peter Maydell wrote: > > M

Re: [Qemu-devel] [PATCH v8] kvm: notify host when the guest is panicked

2012-08-14 Thread Marcelo Tosatti
On Tue, Aug 14, 2012 at 10:47:48AM +0300, Gleb Natapov wrote: > On Mon, Aug 13, 2012 at 05:24:52PM -0300, Marcelo Tosatti wrote: > > On Mon, Aug 13, 2012 at 01:48:39PM -0600, Eric Blake wrote: > > > On 08/13/2012 12:21 PM, Marcelo Tosatti wrote: > > > > On Wed, Au

Re: [Qemu-devel] [PATCH v8] kvm: notify host when the guest is panicked

2012-08-14 Thread Marcelo Tosatti
On Tue, Aug 14, 2012 at 05:55:54PM +0300, Yan Vugenfirer wrote: > > On Aug 14, 2012, at 1:42 PM, Jan Kiszka wrote: > > > On 2012-08-14 10:56, Daniel P. Berrange wrote: > >> On Mon, Aug 13, 2012 at 03:21:32PM -0300, Marcelo Tosatti wrote: > >>> On Wed, A

Re: [Qemu-devel] [PATCH uq/master 1/2] kvm: i8254: Cache kernel clock offset in KVMPITState

2012-08-14 Thread Marcelo Tosatti
On Tue, Aug 14, 2012 at 10:24:03AM +0200, Jan Kiszka wrote: > To prepare the final fix for clock calibration issues with the in-kernel > PIT, we want to cache the offset between vmclock and the clock used by > the in-kernel PIT. So far, we only need to update it when the VM state > changes between

Re: [Qemu-devel] [PATCH v2 uq/master] kvmvapic: Disable if there is insufficient memory

2012-08-14 Thread Marcelo Tosatti
On Tue, Aug 14, 2012 at 01:43:12PM +0200, Jan Kiszka wrote: > We need at least 1M of RAM to map the option ROM. Otherwise, we will > corrupt host memory or even crash: > > $ qemu-system-x86_64 -nodefaults --enable-kvm -vnc :0 -m 640k > Segmentation fault (core dumped) > > Reported-and-tes

Re: [Qemu-devel] [PATCH v8] kvm: notify host when the guest is panicked

2012-08-14 Thread Marcelo Tosatti
On Tue, Aug 14, 2012 at 01:53:01PM -0500, Anthony Liguori wrote: > Marcelo Tosatti writes: > > > On Tue, Aug 14, 2012 at 05:55:54PM +0300, Yan Vugenfirer wrote: > >> > >> On Aug 14, 2012, at 1:42 PM, Jan Kiszka wrote: > >> > >> > On 2012-08

Re: [Qemu-devel] [PATCH] update-linux-headers.sh: Pull in asm-generic/kvm_para.h

2012-08-14 Thread Marcelo Tosatti
On Wed, Jul 25, 2012 at 04:29:07PM +0100, Peter Maydell wrote: > Add asm-generic/kvm_para.h to the set of non-architecture specific > KVM kernel headers we copy into QEMU. This header may be included > by an architecture's kvm_para.h header. > > Signed-off-by: Peter Maydell > --- > scripts/updat

Re: [Qemu-devel] [PATCH v8] kvm: notify host when the guest is panicked

2012-08-14 Thread Marcelo Tosatti
On Tue, Aug 14, 2012 at 02:35:34PM -0500, Anthony Liguori wrote: > Marcelo Tosatti writes: > > > On Tue, Aug 14, 2012 at 01:53:01PM -0500, Anthony Liguori wrote: > >> Marcelo Tosatti writes: > >> > >> > On Tue, Aug 14, 2012 at 05:55:54PM +0300, Yan Vu

[Qemu-devel] [PATCH 1/4] kvm: i8254: Cache kernel clock offset in KVMPITState

2012-08-14 Thread Marcelo Tosatti
-kernel PIT state while the VM is running. Signed-off-by: Jan Kiszka Signed-off-by: Marcelo Tosatti --- hw/kvm/i8254.c | 38 -- 1 files changed, 24 insertions(+), 14 deletions(-) diff --git a/hw/kvm/i8254.c b/hw/kvm/i8254.c index c5d3711..c235d80 100644

[Qemu-devel] [PATCH 3/4] kvmvapic: Disable if there is insufficient memory

2012-08-14 Thread Marcelo Tosatti
Signed-off-by: Marcelo Tosatti --- hw/apic_common.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/hw/apic_common.c b/hw/apic_common.c index 58e63b0..371f95d 100644 --- a/hw/apic_common.c +++ b/hw/apic_common.c @@ -299,7 +299,9 @@ static int apic_init_common

[Qemu-devel] [PATCH 0/4] [PULL] qemu-kvm.git uq/master queue

2012-08-14 Thread Marcelo Tosatti
The following changes since commit 873359d411eeb380906761e46839a2b705dbcf75: Merge branch 'linux-user.next' of git://git.linaro.org/people/pmaydell/qemu-arm (2012-08-14 19:50:22 +) are available in the git repository at: git://git.kernel.org/pub/scm/virt/kvm/qemu-kvm.git uq/master Jan

[Qemu-devel] [PATCH 4/4] update-linux-headers.sh: Pull in asm-generic/kvm_para.h

2012-08-14 Thread Marcelo Tosatti
From: Peter Maydell Add asm-generic/kvm_para.h to the set of non-architecture specific KVM kernel headers we copy into QEMU. This header may be included by an architecture's kvm_para.h header. Reviewed-by: Jan Kiszka Signed-off-by: Peter Maydell Signed-off-by: Marcelo Tosatti --- sc

[Qemu-devel] [PATCH 2/4] kvm: i8254: Finish time conversion fix

2012-08-14 Thread Marcelo Tosatti
by applying the offset also on kvm_pit_put. Now we also need to update the offset when we write the state while the VM is stopped as it keeps on changing in that state. Signed-off-by: Jan Kiszka Signed-off-by: Marcelo Tosatti --- hw/kvm/i8254.c | 14 ++ 1 files changed, 10

Re: [Qemu-devel] [PATCH v8] kvm: notify host when the guest is panicked\

2012-08-14 Thread Marcelo Tosatti
On Tue, Aug 14, 2012 at 05:59:06PM -0500, Anthony Liguori wrote: > Marcelo Tosatti writes: > > > On Tue, Aug 14, 2012 at 02:35:34PM -0500, Anthony Liguori wrote: > >> Marcelo Tosatti writes: > >> > >> > On Tue, Aug 14, 2012 at 01:53:01PM -0500, Anth

Re: [Qemu-devel] [PATCH 0/4] [PULL] qemu-kvm.git uq/master queue

2012-08-15 Thread Marcelo Tosatti
On Wed, Aug 15, 2012 at 08:46:21AM +0100, Peter Maydell wrote: > On 15 August 2012 00:59, Marcelo Tosatti wrote: > > The following changes since commit 873359d411eeb380906761e46839a2b705dbcf75: > > > > Merge branch 'linux-user.next' of > > git://git.linaro.

Re: [Qemu-devel] Hard freeze for 1.2 today

2012-08-15 Thread Marcelo Tosatti
On Wed, Aug 15, 2012 at 09:22:20AM -0500, anth...@codemonkey.ws wrote: > > Hi, > > Today is the hard freeze for 1.2. If you have any pull requests and/or > patches targetted for the hard freeze, please send them by 3pm > US/Central time today and clearly mark them "for-1.2". > > If there are ex

Re: [Qemu-devel] [PATCH v2] kvm-all.c: Move init of irqchip_inject_ioctl out of kvm_irqchip_create()

2012-08-15 Thread Marcelo Tosatti
On Wed, Aug 15, 2012 at 12:08:13PM +0100, Peter Maydell wrote: > Move the init of the irqchip_inject_ioctl field of KVMState out of > kvm_irqchip_create() and into kvm_init(), so that kvm_set_irq() > can be used even when no irqchip is created (for architectures > that support async interrupt notif

Re: [Qemu-devel] [PATCH v2] kvm-all.c: Move init of irqchip_inject_ioctl out of kvm_irqchip_create()

2012-08-23 Thread Marcelo Tosatti
On Tue, Aug 21, 2012 at 12:27:51PM +0200, Jan Kiszka wrote: > On 2012-08-21 10:25, Peter Maydell wrote: > > On 21 August 2012 09:19, Jan Kiszka wrote: > >> On 2012-08-15 13:08, Peter Maydell wrote: > >>> Move the init of the irqchip_inject_ioctl field of KVMState out of > >>> kvm_irqchip_create()

Re: [Qemu-devel] [PATCH v3 uq/master 0/6] kvm: Get coalesced MMIO flushing out of the hot-path

2012-08-23 Thread Marcelo Tosatti
On Thu, Aug 23, 2012 at 01:02:28PM +0200, Jan Kiszka wrote: > This is just a repost, now targeting uq/master as agreed. No changes > compared to v2 except that "i82378: Remove bogus MMIO coalescing" was > dropped as it is already in QEMU upstream by now. > > Original description: > > We currently

Re: [Qemu-devel] [PATCH uq/master] kvm: Rename irqchip_inject_ioctl to irq_set_ioctl

2012-08-24 Thread Marcelo Tosatti
On Fri, Aug 24, 2012 at 01:34:47PM +0200, Jan Kiszka wrote: > This variable is no longer bound to irqchip, and the IOCTL sets the IRQ > level, does not directly inject it. No functional changes. > > Signed-off-by: Jan Kiszka > --- > kvm-all.c | 10 +- > 1 files changed, 5 insertions(+)

Re: [Qemu-devel] [PATCHv2 2/4] pc: refactor compat code

2012-08-28 Thread Marcelo Tosatti
On Mon, Aug 27, 2012 at 03:20:13PM +0300, Michael S. Tsirkin wrote: > In preparation to adding PV EOI migration for 1.2, > trivially refactor some some compat code > to make it easier to add version specific > cpuid tweaks. > > Signed-off-by: Michael S. Tsirkin > --- > hw/pc_piix.c | 44

Re: [Qemu-devel] [PATCHv2 2/4] pc: refactor compat code

2012-08-28 Thread Marcelo Tosatti
On Tue, Aug 28, 2012 at 07:31:24PM +0300, Michael S. Tsirkin wrote: > On Tue, Aug 28, 2012 at 01:23:18PM -0300, Marcelo Tosatti wrote: > > On Mon, Aug 27, 2012 at 03:20:13PM +0300, Michael S. Tsirkin wrote: > > > In preparation to adding PV EOI migration for 1.2, > > > t

Re: [Qemu-devel] [PATCH uq/master] kvm: Allow to set shadow MMU size

2012-02-06 Thread Marcelo Tosatti
On Wed, Jan 25, 2012 at 06:14:15PM +0100, Jan Kiszka wrote: > Introduce the KVM-specific machine option kvm_shadow_mem. It allows to > set a custom shadow MMU size for the virtual machine. This is useful for > stress testing e.g. > > Only x86 supports this for now, but it is in principle a generic

Re: [Qemu-devel] [PATCH] KVM: Fix compilation on non-x86

2012-02-06 Thread Marcelo Tosatti
On Wed, Jan 25, 2012 at 06:33:03PM +0100, Alexander Graf wrote: > Commit 84b058d broke compilation for KVM on non-x86 targets, which > don't have KVM_CAP_IRQ_ROUTING defined. > > Fix by not using the unavailable constant when it's not around. > > Signed-off-by: Alexander Graf Applied, thanks.

Re: [Qemu-devel] [PATCH uq/master] kvm: Implement kvm_irqchip_in_kernel like kvm_enabled

2012-02-07 Thread Marcelo Tosatti
On Tue, Jan 31, 2012 at 07:17:52PM +0100, Jan Kiszka wrote: > To both avoid that kvm_irqchip_in_kernel always has to be paired with > kvm_enabled and that the former ends up in a function call, implement it > like the latter. This means keeping the state in a global variable and > defining kvm_irqc

Re: [Qemu-devel] [PATCH uq/master] apic: Fix legacy vmstate loading for KVM

2012-02-08 Thread Marcelo Tosatti
On Sun, Feb 05, 2012 at 12:45:20PM +0100, Jan Kiszka wrote: > From: Jan Kiszka > > Also in case of loading pre-vmstate machines, we also need to open-code > the reading of the timer expires value and instead call the post_load > callback to apply it (or not). This fixes loading of legacy states i

Re: [Qemu-devel] [PATCH 0/4] uq/master: Introduce KVM PIT support

2012-02-08 Thread Marcelo Tosatti
On Sun, Feb 05, 2012 at 11:46:26AM +0100, Jan Kiszka wrote: > This adds another piece of qemu-kvm to upstream: The accelerated > in-kernel model of the i8254. It does this in the same fashion as the > interrupt controllers were already introduced. And it even has one bug > less than qemu-kvm: PC sp

[Qemu-devel] [PATCH 1/3] kvm: Allow to set shadow MMU size

2012-02-08 Thread Marcelo Tosatti
-off-by: Jan Kiszka Signed-off-by: Marcelo Tosatti --- qemu-config.c |4 qemu-options.hx |5 - target-i386/kvm.c | 13 + 3 files changed, 21 insertions(+), 1 deletions(-) diff --git a/qemu-config.c b/qemu-config.c index b030205..95bf5e5 100644 --- a/qemu

[Qemu-devel] [PATCH 3/3] apic: Fix legacy vmstate loading for KVM

2012-02-08 Thread Marcelo Tosatti
Kiszka Signed-off-by: Marcelo Tosatti --- hw/apic_common.c |7 ++- 1 files changed, 6 insertions(+), 1 deletions(-) diff --git a/hw/apic_common.c b/hw/apic_common.c index 26991b4..8373d79 100644 --- a/hw/apic_common.c +++ b/hw/apic_common.c @@ -188,6 +188,7 @@ static void apic_reset_common

[Qemu-devel] [PATCH 0/3] [PULL] qemu-kvm.git uq/master queue

2012-02-08 Thread Marcelo Tosatti
The following changes since commit cf4dc461a4cfc3e056ee24edb26154f4d34a6278: Restore consistent formatting (2012-02-07 22:11:04 +0400) are available in the git repository at: git://git.kernel.org/pub/scm/virt/kvm/qemu-kvm.git uq/master Jan Kiszka (3): kvm: Allow to set shadow MMU size

[Qemu-devel] [PATCH 2/3] kvm: Implement kvm_irqchip_in_kernel like kvm_enabled

2012-02-08 Thread Marcelo Tosatti
-off-by: Jan Kiszka Signed-off-by: Marcelo Tosatti --- hw/pc.c |4 ++-- hw/pc_piix.c |6 +++--- kvm-all.c | 13 - kvm-stub.c|5 - kvm.h |8 +--- target-i386/kvm.c |4 ++-- 6 files changed, 16 insertions(+), 24

Re: [Qemu-devel] [PATCH v6 05/16] target-i386: Use Hypervisor level in -machine pc, accel=kvm.

2012-10-10 Thread Marcelo Tosatti
On Wed, Oct 10, 2012 at 09:03:20AM -0400, Don Slutz wrote: > >>Did you mean 3 patch sets (or more)? Or just a different order? > >>-Don Slutz > >Different order. Patches should be logically related (think of what > >information the reviewer needs). Please write changelogs for > >every patch. >

Re: [Qemu-devel] [patch v4 00/16] push mmio dispatch out of big lock

2012-10-25 Thread Marcelo Tosatti
On Thu, Oct 25, 2012 at 06:13:51PM +0100, Peter Maydell wrote: > On 25 October 2012 18:07, Avi Kivity wrote: > > On 10/25/2012 04:04 PM, Peter Maydell wrote: > >> Is there a clear up to date description somewhere of the design and > >> locking strategy here somewhere? I'd rather not have to try to

Re: [Qemu-devel] [PATCH 00/15] QEMU KVM_GET_SUPPORTED_CPUID cleanups and fixes

2012-10-26 Thread Marcelo Tosatti
On Thu, Oct 04, 2012 at 05:48:52PM -0300, Eduardo Habkost wrote: > Most of this series are just cleanups that will help when making -cpu > check/enforce work properly, with some fixes. > > In addition to code movements, the main changes are: > - x2apic won't be enabled if in-kernel irqchip is dis

Re: [Qemu-devel] [QEMU PATCH] i386: cpu: add missing CPUID[EAX=7, ECX=0] flag names

2012-10-26 Thread Marcelo Tosatti
On Tue, Oct 09, 2012 at 12:43:52PM -0400, Don Slutz wrote: > On 10/09/12 10:03, Eduardo Habkost wrote: > >This makes QEMU recognize the following CPU flag names: > > > > Flags| Corresponding KVM kernel commit > > -+ > > FSGSBASE

Re: [Qemu-devel] [PATCH v7 1/1] target-i386: Add missing kvm bits.

2012-10-26 Thread Marcelo Tosatti
On Fri, Oct 12, 2012 at 03:43:23PM -0400, Don Slutz wrote: > Currently "-cpu host,-kvmclock,-kvm_nopiodelay,-kvm_mmu" does not > turn off all bits in CPUID 0x4001 EAX. > > The missing ones are KVM_FEATURE_STEAL_TIME and > KVM_FEATURE_CLOCKSOURCE_STABLE_BIT. > > This adds the names kvm_steal_t

[Qemu-devel] acpi_piix4 migration issue

2012-10-28 Thread Marcelo Tosatti
qemu-kvm 1.2 -> qemu-1.3 migration fails with Unknown savevm section type 48 load of migration failed Due to a fix in acpi_piix4 in qemu-kvm (attached at the end of the message). The problem is that qemu-kvm correctly uses 2 bytes for sts and 2 bytes for en fields (which is their allocated si

Re: [Qemu-devel] [QEMU PATCH 0/3] Fix -cpu host and enforce/check to use GET_SUPPORTED_CPUID

2012-10-29 Thread Marcelo Tosatti
On Wed, Oct 24, 2012 at 07:44:04PM -0200, Eduardo Habkost wrote: > This depends on a previous series I have submitted: > Subject: [QEMU PATCH 00/15] QEMU KVM_GET_SUPPORTED_CPUID cleanups and fixes > Message-Id: <1349383747-19383-1-git-send-email-ehabk...@redhat.com> > http://article.gmane.org

Re: [Qemu-devel] [PATCH v7 00/17] target-i386: Add way to expose VMWare CPUID

2012-10-29 Thread Marcelo Tosatti
=displayKC&externalId=1009458 > > Changes from v6 to v7: > Subject changed from "Allow changing of Hypervisor CPUIDs." to > "target-i386: Add way to expose VMWare CPUID" > Split out 01/16 target-i386: Add missing kvm bits. > It is no longer related to

[Qemu-devel] [PATCH] acpi_piix4: fix migration of gpe fields

2012-10-30 Thread Marcelo Tosatti
Migrate 16 bytes for en/sts fields (which is the correct size), increase version to 3, and document how to support incoming migration from qemu-kvm 1.2. Signed-off-by: Marcelo Tosatti diff --git a/hw/acpi_piix4.c b/hw/acpi_piix4.c index 15275cf..519269a 100644 --- a/hw/acpi_piix4.c +++ b/hw

Re: [Qemu-devel] [PATCH v11] kvm: notify host when the guest is panicked

2012-10-30 Thread Marcelo Tosatti
On Thu, Oct 25, 2012 at 11:42:32AM +0800, Hu Tao wrote: > We can know the guest is panicked when the guest runs on xen. > But we do not have such feature on kvm. > > Another purpose of this feature is: management app(for example: > libvirt) can do auto dump when the guest is panicked. If managemen

Re: [Qemu-devel] [PATCH] update-linux-headers.sh: Handle new kernel uapi/ directories

2012-10-30 Thread Marcelo Tosatti
On Tue, Oct 30, 2012 at 07:33:16PM +0100, Jan Kiszka wrote: > On 2012-10-30 10:48, Peter Maydell wrote: > > Ping? > > > > (patchwork url http://patchwork.ozlabs.org/patch/193125/) > > Should obviously go in soon. > > Jan Applied to uq/master, thanks.

Re: [Qemu-devel] [PATCH] kvm: First step to push iothread lock out of inner run loop

2012-06-22 Thread Marcelo Tosatti
On Sat, Jun 23, 2012 at 12:55:49AM +0200, Jan Kiszka wrote: > Should have declared this [RFC] in the subject and CC'ed kvm... > > On 2012-06-23 00:45, Jan Kiszka wrote: > > This sketches a possible path to get rid of the iothread lock on vmexits > > in KVM mode. On x86, the the in-kernel irqchips

Re: [Qemu-devel] [PATCH] kvm: First step to push iothread lock out of inner run loop

2012-06-23 Thread Marcelo Tosatti
On Fri, Jun 22, 2012 at 09:22:59PM -0300, Marcelo Tosatti wrote: > On Sat, Jun 23, 2012 at 12:55:49AM +0200, Jan Kiszka wrote: > > Should have declared this [RFC] in the subject and CC'ed kvm... > > > > On 2012-06-23 00:45, Jan Kiszka wrote: > > > This sketche

Re: [Qemu-devel] [PATCH] kvm: First step to push iothread lock out of inner run loop

2012-06-26 Thread Marcelo Tosatti
On Sat, Jun 23, 2012 at 12:55:49AM +0200, Jan Kiszka wrote: > Should have declared this [RFC] in the subject and CC'ed kvm... > > On 2012-06-23 00:45, Jan Kiszka wrote: > > This sketches a possible path to get rid of the iothread lock on vmexits > > in KVM mode. On x86, the the in-kernel irqchips

Re: [Qemu-devel] [PATCH] kvm: First step to push iothread lock out of inner run loop

2012-06-27 Thread Marcelo Tosatti
On Wed, Jun 27, 2012 at 08:41:49AM +0100, Stefan Hajnoczi wrote: > On Wed, Jun 27, 2012 at 8:39 AM, Stefan Hajnoczi wrote: > > On Tue, Jun 26, 2012 at 8:34 PM, Marcelo Tosatti > > wrote: > >> On Sat, Jun 23, 2012 at 12:55:49AM +0200, Jan Ki

Re: [Qemu-devel] [PATCH] kvm: First step to push iothread lock out of inner run loop

2012-06-27 Thread Marcelo Tosatti
On Sat, Jun 23, 2012 at 11:22:07AM +0200, Jan Kiszka wrote: > On 2012-06-23 02:22, Marcelo Tosatti wrote: > > On Sat, Jun 23, 2012 at 12:55:49AM +0200, Jan Kiszka wrote: > >> Should have declared this [RFC] in the subject and CC'ed kvm... > >> > >> On 2012-

Re: [Qemu-devel] [PATCH] kvm: First step to push iothread lock out of inner run loop

2012-06-28 Thread Marcelo Tosatti
On Wed, Jun 27, 2012 at 08:41:49AM +0100, Stefan Hajnoczi wrote: > On Wed, Jun 27, 2012 at 8:39 AM, Stefan Hajnoczi wrote: > > On Tue, Jun 26, 2012 at 8:34 PM, Marcelo Tosatti > > wrote: > >> On Sat, Jun 23, 2012 at 12:55:49AM +0200, Jan Ki

Re: [Qemu-devel] [PATCH] kvm: First step to push iothread lock out of inner run loop

2012-06-28 Thread Marcelo Tosatti
On Thu, Jun 28, 2012 at 09:10:39AM -0500, Anthony Liguori wrote: > > > >1. read_lock(memmap_lock) > >2. MemoryRegionSection mrs = lookup(addr) > >3. qom_ref(mrs.mr->dev) > >4. read_unlock(memmap_lock) > > > >5. mutex_lock(dev->lock) > >6. dispatch(&mrs, addr, data, size) > >7. mutex_unlock(d

Re: [Qemu-devel] [PATCH] kvm: First step to push iothread lock out of inner run loop

2012-06-28 Thread Marcelo Tosatti
On Thu, Jun 28, 2012 at 09:10:39AM -0500, Anthony Liguori wrote: > On 06/26/2012 02:34 PM, Marcelo Tosatti wrote: > >On Sat, Jun 23, 2012 at 12:55:49AM +0200, Jan Kiszka wrote: > >>Should have declared this [RFC] in the subject and CC'ed kvm... > >> > >

Re: [Qemu-devel] [PATCH] kvm: Don't abort on kvm_irqchip_add_msi_route()

2012-06-29 Thread Marcelo Tosatti
On Mon, Jun 25, 2012 at 09:40:39AM -0600, Alex Williamson wrote: > Anyone using these functions has to be prepared that irqchip > support may not be present. It shouldn't be up to the core > code to determine whether this is a fatal error. Currently > code written as: > > virq = kvm_irqchip_add_

Re: [Qemu-devel] race condition in qemu-kvm-1.0.1

2012-07-03 Thread Marcelo Tosatti
On Wed, Jun 27, 2012 at 12:35:22PM +0200, Peter Lieven wrote: > Hi, > > we recently came across multiple VMs racing and stopping working. It > seems to happen when the system is at 100% cpu. > One way to reproduce this is: > qemu-kvm-1.0.1 with vnc-thread enabled > > cmdline (or similar): > /usr/

Re: [Qemu-devel] [RFC PATCH] Expose tsc deadline timer feature to guest

2012-07-03 Thread Marcelo Tosatti
On Mon, Jul 02, 2012 at 11:08:14AM +, Liu, Jinsong wrote: > Eduardo, Jan, Andreas > > As we sync 3 months ago, I wait until qemu1.1 done, then re-write patch based > on qemu1.1. > Now it's time to re-write my patch based on qemu1.1. > > Attached is a RFC patch for exposing tsc deadline timer

Re: [Qemu-devel] race condition in qemu-kvm-1.0.1

2012-07-04 Thread Marcelo Tosatti
On Wed, Jul 04, 2012 at 12:03:58PM +0200, Peter Lieven wrote: > On 07/03/12 17:54, Marcelo Tosatti wrote: > >On Wed, Jun 27, 2012 at 12:35:22PM +0200, Peter Lieven wrote: > >>Hi, > >> > >>we recently came across multiple VMs racing and stopping working. It >

Re: [Qemu-devel] [PATCH] memory: add -dont-dump-guest option to reduce core dump size

2012-07-05 Thread Marcelo Tosatti
On Mon, May 21, 2012 at 01:53:36PM -0400, Jason Baron wrote: > On Fri, May 04, 2012 at 05:23:51PM -0400, Jason Baron wrote: > > Add a command line parameter to not dump guest memory in the core dump, the > > command line is: -dont-dump-guest. This brought the core dump down from > > 383MB to 13 MB

[Qemu-devel] [PATCH] RTC: enable lost_tick_policy=slew as default

2012-12-11 Thread Marcelo Tosatti
RTC interrupt reinjection has no known negative effect. Lack of RTC interrupt reinjection, though, has negative effects: time drift for Windows guests which use it as a timer source. Based on that, enable lost_tick_policy=slew option as default. Signed-off-by: Marcelo Tosatti diff --git a

[Qemu-devel] [PATCH] RTC: enable lost_tick_policy=slew as default (v2)

2012-12-12 Thread Marcelo Tosatti
RTC interrupt reinjection has no known negative effect. Lack of RTC interrupt reinjection, though, has negative effects: time drift for Windows guests which use it as a timer source. Based on that, enable lost_tick_policy=slew option as default. Signed-off-by: Marcelo Tosatti v2: do not

[Qemu-devel] [PATCH] define qemukvm-1.2 machine type

2012-12-12 Thread Marcelo Tosatti
To allow migration from qemu-kvm-1.2, where cirrus device has 16 megabytes of RAM. Signed-off-by: Marcelo Tosatti diff --git a/hw/pc_piix.c b/hw/pc_piix.c index 19e342a..ead4b6b 100644 --- a/hw/pc_piix.c +++ b/hw/pc_piix.c @@ -347,6 +347,26 @@ static QEMUMachine pc_machine_v1_2

Re: [Qemu-devel] [PATCH] define qemukvm-1.2 machine type

2012-12-13 Thread Marcelo Tosatti
On Thu, Dec 13, 2012 at 09:35:13AM +0100, Paolo Bonzini wrote: > Il 12/12/2012 23:39, Marcelo Tosatti ha scritto: > > > > To allow migration from qemu-kvm-1.2, where cirrus device has 16 megabytes > > of RAM. > > > > Signed-off-by: Marcelo Tosatti > >

[Qemu-devel] [PATCH] fix dma.c MemoryRegion convertion

2012-12-14 Thread Marcelo Tosatti
s WinXP-32 installation. Signed-off-by: Marcelo Tosatti diff --git a/hw/dma.c b/hw/dma.c index c2d7b21..e7de522 100644 --- a/hw/dma.c +++ b/hw/dma.c @@ -56,6 +56,7 @@ static struct dma_cont { uint8_t mask; uint8_t flip_flop; int dshift; +int iobase; struct dma_regs regs[4];

Re: [Qemu-devel] [PATCH] fix dma.c MemoryRegion convertion

2012-12-16 Thread Marcelo Tosatti
On Sat, Dec 15, 2012 at 01:45:38PM +, Julien Grall wrote: > On Fri, Dec 14, 2012 at 11:39 PM, Marcelo Tosatti wrote: > > > > > > The high byte of the ioport address is necessary to compute > > the register address, see "82371AB PCI ISA IDE Xcelerator (PIIX4)&qu

Re: [Qemu-devel] [PATCH] MAINTAINERS: Take over kvm maintenance

2012-12-19 Thread Marcelo Tosatti
n > x86_64, ppc and s390x KVM hosts, including the stubs. > > Andreas > > > diff --git a/MAINTAINERS b/MAINTAINERS > > index 2ede20d..0e574f9 100644 > > --- a/MAINTAINERS > > +++ b/MAINTAINERS > > @@ -132,7 +132,7 @@ Guest CPU Cores (KVM): > >

Re: [Qemu-devel] [PATCH] MAINTAINERS: Take over kvm maintenance

2012-12-19 Thread Marcelo Tosatti
On Wed, Dec 19, 2012 at 08:05:10PM +0100, Andreas Färber wrote: > Am 19.12.2012 17:33, schrieb Marcelo Tosatti: > > On Wed, Dec 19, 2012 at 05:00:40PM +0100, Andreas Färber wrote: > >> Am 19.12.2012 16:46, schrieb Gleb Natapov: > >>> > >>>

Re: [Qemu-devel] [PATCH v12 0/8] pv event to notify host when the guest is panicked

2012-12-25 Thread Marcelo Tosatti
On Thu, Dec 20, 2012 at 03:53:59PM +0800, Hu Tao wrote: > Hi, > > Any comments? As far as i can see, items 2 and 3 of https://lkml.org/lkml/2012/11/12/588 Have not been addressed. https://lkml.org/lkml/2012/11/20/653 contains discussions on those items. 2) Format of the interface for other ar

Re: [Qemu-devel] [PATCH v12 0/8] pv event to notify host when the guest is panicked

2012-12-25 Thread Marcelo Tosatti
On Thu, Dec 20, 2012 at 03:53:59PM +0800, Hu Tao wrote: > Hi, > > Any comments? Did you verify possibilities listed at https://lkml.org/lkml/2012/11/20/653 ? If so, a summary in the patchset would be helpful. > On Wed, Dec 12, 2012 at 02:13:43PM +0800, Hu Tao wrote: > > This series implements

Re: [Qemu-devel] [PATCH 4/7 v2] KVM regsync: Add register bitmap parameter to do_kvm_cpu_synchronize_state

2013-01-24 Thread Marcelo Tosatti
On Thu, Jan 24, 2013 at 01:40:49PM +0100, Alexander Graf wrote: > > read_reg(x) > > if x not cached > > arch_get_regs(RUNTIME_STATE) (*) > > > > write_reg(x, val) > > read_reg(x) > > cpustate->x = val; > > mark_dirty(x) > > > > Which is basically the pattern used in KV

Re: [Qemu-devel] [PATCH 4/7 v2] KVM regsync: Add register bitmap parameter to do_kvm_cpu_synchronize_state

2013-01-24 Thread Marcelo Tosatti
On Thu, Jan 24, 2013 at 06:44:50PM -0200, Marcelo Tosatti wrote: > On Thu, Jan 24, 2013 at 01:40:49PM +0100, Alexander Graf wrote: > > > read_reg(x) > > > if x not cached > > > arch_get_regs(RUNTIME_STATE) (*) > > > > > > write_reg(x, va

Re: [Qemu-devel] [PATCH] target-i386: kvm: prevent buffer overflow if -cpu foo, [x]level is too big

2013-01-25 Thread Marcelo Tosatti
On Thu, Jan 24, 2013 at 12:05:48AM +0100, Igor Mammedov wrote: > Stack corruption may occur if too big 'level' or 'xlevel' values passed > on command line with KVM enabled, due to limited size of cpuid_data > in kvm_arch_init_vcpu(). > > reproduces with: > qemu -enable-kvm -cpu qemu64,level=42949

Re: [Qemu-devel] [PATCH 4/7 v2] KVM regsync: Add register bitmap parameter to do_kvm_cpu_synchronize_state

2013-01-29 Thread Marcelo Tosatti
On Mon, Jan 28, 2013 at 12:49:26PM -0500, Jason J. Herne wrote: > On 01/24/2013 07:01 PM, Marcelo Tosatti wrote: > >On Thu, Jan 24, 2013 at 06:44:50PM -0200, Marcelo Tosatti wrote: > > > >What 'subtle errors' are you thinking of? > > > >It should be easy

Re: [Qemu-devel] [PATCH V5] target-i386: Enabling IA32_TSC_ADJUST for QEMU KVM guest VMs

2013-02-06 Thread Marcelo Tosatti
On Wed, Feb 06, 2013 at 10:22:32PM +, Auld, Will wrote: > Marcelo, Hi, > > I have been watching for this patch in the upstream but have not seen it yet. > What version of QEMU should it be in? > > Thanks, > > Will Will, its in the GIT tree: https://github.com/qemu/qemu/commit/f28558d3d37ad

Re: [Qemu-devel] [PATCH v12 rebased 1/8] preserve cpu runstate

2013-02-07 Thread Marcelo Tosatti
On Wed, Jan 23, 2013 at 03:19:22PM +0800, Hu Tao wrote: > This patch enables preservation of cpu runstate during save/load vm. > So when a vm is restored from snapshot, the cpu runstate is restored, > too. > > See following example: > > # save two vms: one is running, the other is paused > (qemu)

Re: [Qemu-devel] [PATCH v12 rebased] kvm: notify host when the guest is panicked

2013-02-07 Thread Marcelo Tosatti
Hi, On Wed, Jan 23, 2013 at 03:19:21PM +0800, Hu Tao wrote: > We can know the guest is panicked when the guest runs on xen. > But we do not have such feature on kvm. > > Another purpose of this feature is: management app(for example: > libvirt) can do auto dump when the guest is panicked. If mana

Re: [Qemu-devel] [PATCH v12 rebased 2/8] start vm after resetting it

2013-02-07 Thread Marcelo Tosatti
On Wed, Jan 23, 2013 at 03:19:23PM +0800, Hu Tao wrote: > From: Wen Congyang > > The guest should run after resetting it, but it does not run if its > old state is RUN_STATE_INTERNAL_ERROR or RUN_STATE_PAUSED. > > We don't set runstate to RUN_STATE_PAUSED when resetting the guest, > so the runst

Re: [Qemu-devel] [PATCH 4/7 v2] KVM regsync: Add register bitmap parameter to do_kvm_cpu_synchronize_state

2013-02-11 Thread Marcelo Tosatti
On Fri, Feb 01, 2013 at 10:47:37AM -0500, Jason J. Herne wrote: > On 01/24/2013 07:40 AM, Alexander Graf wrote: > >I think for now the best choice for get_regs() would be to ignore the > >FULL/RESET bits and always keep the syncing as it happens today under the > >RUNTIME umbrella only. So all of

Re: [Qemu-devel] [PATCH v2][QEMU] vmxcap: Report APIC register emulation and RDTSCP control

2013-02-20 Thread Marcelo Tosatti
On Mon, Feb 18, 2013 at 07:56:54AM +0100, Jan Kiszka wrote: > From: Jan Kiszka > > Signed-off-by: Jan Kiszka > --- > > This time I've checked twice that I'm no longer missing a field. Applied, thanks.

Re: [Qemu-devel] [PATCH 1/1] kvmclock: fix guest stop notification

2012-09-20 Thread Marcelo Tosatti
of 0 for the 'running' parameter when the VM is stopped, making > all the code added previously dead code. > > This patch reworks the code so that it's called when 'running' is 0, > which indicates the VM was stopped. > > CC: Eric B Munson > CC: Raghaven

Re: [Qemu-devel] [PATCH 1/1] kvmclock: fix guest stop notification

2012-09-20 Thread Marcelo Tosatti
running' is 0, > which indicates the VM was stopped. > > CC: Eric B Munson > CC: Raghavendra K T > CC: Andreas Färber > CC: Marcelo Tosatti > CC: Paolo Bonzini > CC: Laszlo Ersek > Signed-off-by: Amit Shah > --- > hw/kvm/clock.c | 21 +++--

Re: [Qemu-devel] [PATCH 1/1] kvmclock: fix guest stop notification

2012-09-30 Thread Marcelo Tosatti
On Thu, Sep 20, 2012 at 09:46:41AM -0300, Marcelo Tosatti wrote: > On Thu, Sep 20, 2012 at 01:55:20PM +0530, Amit Shah wrote: > > Commit f349c12c0434e29c79ecde89029320c4002f7253 added the guest stop > > notification, but it did it in a way that the stop notification would >

Re: [Qemu-devel] qemu-kvm: remove "boot=on|off" drive parameter compatibility

2012-10-01 Thread Marcelo Tosatti
On Mon, Oct 01, 2012 at 08:19:29AM -0500, Anthony Liguori wrote: > Jan Kiszka writes: > > > On 2012-10-01 11:31, Marcelo Tosatti wrote: > > > > It's not just about default configs. We need to validate if the > > migration formats are truly compatible (qemu-kv

Re: [Qemu-devel] [PATCH v10] kvm: notify host when the guest is panicked

2012-10-01 Thread Marcelo Tosatti
On Mon, Oct 01, 2012 at 03:57:40PM -0300, Luiz Capitulino wrote: > On Wed, 29 Aug 2012 13:18:54 +0800 > Wen Congyang wrote: > > > We can know the guest is panicked when the guest runs on xen. > > But we do not have such feature on kvm. > > What's the status of this series? > > It got lost in my

[Qemu-devel] [patch 4/6] Use global properties to emulate -no-kvm-pit-reinjection

2012-10-03 Thread Marcelo Tosatti
Commit 80019541e9c13fab476bee35edcef3e11646222c from qemu-kvm.git. From: Jan Kiszka Use global properties to emulate -no-kvm-pit-reinjection Signed-off-by: Marcelo Tosatti Index: qemu-compat-kvm/vl.c === --- qemu-compat-kvm.orig

[Qemu-devel] [patch 6/6] Emulate qemu-kvms -tdf option

2012-10-03 Thread Marcelo Tosatti
Commit d527b774878defc27f317cdde19b5c54fd0d5666 from qemu-kvm.git. From: Jan Kiszka Add a warning that there is no effect anymore. Signed-off-by: Marcelo Tosatti Index: qemu-compat-kvm/vl.c === --- qemu-compat-kvm.orig/vl.c

[Qemu-devel] [patch 5/6] Emulate qemu-kvms drive parameter boot=on|off

2012-10-03 Thread Marcelo Tosatti
Commit 841280b6c224ea2c6edc2f5afc2add513c85181d from qemu-kvm.git. From: Jan Kiszka We do not want to maintain this option forever. It will be removed after a grace period of a few releases. So warn the user that this option has no effect and will become invalid soon. Signed-off-by: Marcelo

[Qemu-devel] [patch 0/6] qemu-kvm compat

2012-10-03 Thread Marcelo Tosatti
As discussed on yesterdays qemu call, follows qemu-kvm compat patches for qemu: - command line compatibility - allow configurable ram size for cirrus

[Qemu-devel] [patch 1/6] cirrus_vga: allow configurable vram size

2012-10-03 Thread Marcelo Tosatti
Allow RAM size to be configurable for cirrus, to allow migration compatibility from qemu-kvm. Signed-off-by: Marcelo Tosatti Index: qemu-compat-kvm/hw/cirrus_vga.c === --- qemu-compat-kvm.orig/hw/cirrus_vga.c +++ qemu-compat-kvm

[Qemu-devel] [patch 3/6] Use machine options to emulate -no-kvm-pit

2012-10-03 Thread Marcelo Tosatti
Commit e81dda195556e72f8cd294998296c1051aab30a8 from qemu-kvm.git. From: Jan Kiszka Leave the related command line option in place, just issuing a warning that it has no function anymore. Signed-off-by: Marcelo Tosatti Index: qemu-compat-kvm/vl.c

[Qemu-devel] [patch 2/6] Use machine options to emulate -no-kvm-irqchip

2012-10-03 Thread Marcelo Tosatti
Commit 3ad763fcba5bd0ec5a79d4a9b6baeef119dd4a3d from qemu-kvm.git. From: Jan Kiszka Upstream is moving towards this mechanism, so start using it in qemu-kvm already to configure the specific defaults: kvm enabled on, just like in-kernel irqchips. Signed-off-by: Marcelo Tosatti Index

Re: [Qemu-devel] [PATCH 1/1] kvmclock: fix guest stop notification

2012-10-03 Thread Marcelo Tosatti
On Sun, Sep 30, 2012 at 09:50:07PM -0400, Amos Kong wrote: > - Original Message - > > On Thu, Sep 20, 2012 at 09:46:41AM -0300, Marcelo Tosatti wrote: > > > On Thu, Sep 20, 2012 at 01:55:20PM +0530, Amit Shah wrote: > > > > Commit f349c12c0434e29c79ecde8902

Re: [Qemu-devel] [patch 2/6] Use machine options to emulate -no-kvm-irqchip

2012-10-03 Thread Marcelo Tosatti
On Wed, Oct 03, 2012 at 09:40:17AM -0500, Anthony Liguori wrote: > Marcelo Tosatti writes: > > > Commit 3ad763fcba5bd0ec5a79d4a9b6baeef119dd4a3d from qemu-kvm.git. > > > > From: Jan Kiszka > > > > Upstream is moving towards this mechanism, so start

Re: [Qemu-devel] [patch 0/6] qemu-kvm compat

2012-10-03 Thread Marcelo Tosatti
On Wed, Oct 03, 2012 at 09:45:07AM -0500, Anthony Liguori wrote: > Marcelo Tosatti writes: > > > As discussed on yesterdays qemu call, follows qemu-kvm compat patches > > for qemu: > > > > - command line compatibility > > - allow configurable ram siz

Re: [Qemu-devel] [patch 2/6] Use machine options to emulate -no-kvm-irqchip

2012-10-03 Thread Marcelo Tosatti
On Wed, Oct 03, 2012 at 07:24:48PM +0200, Jan Kiszka wrote: > On 2012-10-03 19:16, Anthony Liguori wrote: > > Jan Kiszka writes: > > > >> On 2012-10-03 17:03, Marcelo Tosatti wrote: > >>> On Wed, Oct 03, 2012 at 09:40:17AM -0500, Anthony Liguori w

Re: [Qemu-devel] [patch 2/6] Use machine options to emulate -no-kvm-irqchip

2012-10-04 Thread Marcelo Tosatti
On Thu, Oct 04, 2012 at 04:30:26PM +0200, Jan Kiszka wrote: > On 2012-10-04 16:21, Anthony Liguori wrote: > > -no-kvm should be included too. > > Reminds me that we still need to agree on the final default accel strategy. Default accel=kvm for x86_64 targets, no fallback. Markus's argument is pr

Re: [Qemu-devel] [patch 2/6] Use machine options to emulate -no-kvm-irqchip

2012-10-04 Thread Marcelo Tosatti
On Thu, Oct 04, 2012 at 05:36:38PM +0200, Andreas Färber wrote: > Am 04.10.2012 16:30, schrieb Jan Kiszka: > > On 2012-10-04 16:21, Anthony Liguori wrote: > >> -no-kvm should be included too. > > > > Reminds me that we still need to agree on the final default accel strategy. > > > >> > >> I just

  1   2   3   4   5   6   7   8   9   10   >