Re: [PATCH v3 4/4] scripts: add script to compare compatible properties

2022-11-17 Thread Maksim Davydov
On 11/9/22 00:16, John Snow wrote: On Thu, Nov 3, 2022 at 6:29 AM Maksim Davydov wrote: This script run QEMU to obtain compat_props of machines and default values of different types and produce appropriate table. This table can be used to compare machine types to choose the most suitable

[PULL 0/4] machine development tool

2024-03-04 Thread Maksim Davydov
evelopment ---- Maksim Davydov (4): qom: add default value qmp: add dump machine type compatibility properties python/qemu/machine: add method to retrieve QEMUMachine::binary field scripts: add script to compare compatibility properties MAINTAINERS | 5 + hw/core/machine-

[PULL 3/4] python/qemu/machine: add method to retrieve QEMUMachine::binary field

2024-03-04 Thread Maksim Davydov
Add a supportive property to access the path to the QEMU binary Signed-off-by: Maksim Davydov Reviewed-by: John Snow Reviewed-by: Philippe Mathieu-Daudé --- python/qemu/machine/machine.py | 5 + 1 file changed, 5 insertions(+) diff --git a/python/qemu/machine/machine.py b/python/qemu

[PULL 1/4] qom: add default value

2024-03-04 Thread Maksim Davydov
qmp_qom_list_properties can print default values if they are available as qmp_device_list_properties does, because both of them use the ObjectPropertyInfo structure with default_value field. This can be useful when working with "not device" types (e.g. memory-backend). Signed-off-

[PULL 2/4] qmp: add dump machine type compatibility properties

2024-03-04 Thread Maksim Davydov
nding supported machines for their comparison via new optional argument of "query-machines" command. Since information on compatibility properties can increase the command output by a factor of 40, add an argument to enable it, default off. Signed-off-by: Maksim Davydov Reviewed-by: Vla

[PULL 4/4] scripts: add script to compare compatibility properties

2024-03-04 Thread Maksim Davydov
│ ├──┼──┼┼┤ │virtio-mem│ unplugged-inaccessible │ False│ auto│ ╘══╧══╧╧

[PATCH] migration/ram: add additional check

2024-03-04 Thread Maksim Davydov
If a migration stream is broken, the address and flag reading can return zero. Thus, an irrelevant flag error will be returned instead of EIO. It can be fixed by additional check after the reading. Signed-off-by: Maksim Davydov --- migration/ram.c | 6 ++ 1 file changed, 6 insertions

Re: [PULL 0/4] machine development tool

2024-03-07 Thread Maksim Davydov
On 3/6/24 04:57, Peter Xu wrote: On Tue, Mar 05, 2024 at 03:43:41PM +0100, Markus Armbruster wrote: Peter Maydell writes: On Mon, 4 Mar 2024 at 13:52, Maksim Davydov wrote: The following changes since commit e1007b6bab5cf97705bf4f2aaec1f607787355b8: Merge tag 'pull-request-2024-

[PATCH v9 3/4] python/qemu/machine: add method to retrieve QEMUMachine::binary field

2024-02-22 Thread Maksim Davydov
Add a supportive property to access the path to the QEMU binary Signed-off-by: Maksim Davydov Reviewed-by: John Snow Reviewed-by: Philippe Mathieu-Daudé --- python/qemu/machine/machine.py | 5 + 1 file changed, 5 insertions(+) diff --git a/python/qemu/machine/machine.py b/python/qemu

[PATCH v9 4/4] scripts: add script to compare compatibility properties

2024-02-22 Thread Maksim Davydov
│ ├──┼──┼┼┤ │virtio-mem│ unplugged-inaccessible │ False│ auto│ ╘══╧══╧╧

[PATCH v9 0/4] compare machine type compat_props

2024-02-22 Thread Maksim Davydov
rder patches v1 -> previous iteration: * new default value print concept * QEMU python library is used to collect qmp data * remove auxiliary patches (that was used to fix `->get` sematics) * print compat_props in the correct order * delete `absract` field to reduce output JSON size Maksim Da

[PATCH v9 2/4] qmp: add dump machine type compatibility properties

2024-02-22 Thread Maksim Davydov
nding supported machines for their comparison via new optional argument of "query-machines" command. Since information on compatibility properties can increase the command output by a factor of 40, add an argument to enable it, default off. Signed-off-by: Maksim Davydov Reviewed-by: Vla

[PATCH v9 1/4] qom: add default value

2024-02-22 Thread Maksim Davydov
qmp_qom_list_properties can print default values if they are available as qmp_device_list_properties does, because both of them use the ObjectPropertyInfo structure with default_value field. This can be useful when working with "not device" types (e.g. memory-backend). Signed-off-

Re: [PULL 0/4] machine development tool

2024-03-18 Thread Maksim Davydov
On 3/8/24 06:47, Peter Xu wrote: On Thu, Mar 07, 2024 at 12:06:59PM +0300, Maksim Davydov wrote: On 3/6/24 04:57, Peter Xu wrote: On Tue, Mar 05, 2024 at 03:43:41PM +0100, Markus Armbruster wrote: Peter Maydell writes: On Mon, 4 Mar 2024 at 13:52, Maksim Davydov wrote: The following

[PULL v2 1/4] qom: add default value

2024-03-18 Thread Maksim Davydov
qmp_qom_list_properties can print default values if they are available as qmp_device_list_properties does, because both of them use the ObjectPropertyInfo structure with default_value field. This can be useful when working with "not device" types (e.g. memory-backend). Signed-off-

[PULL v2 2/4] qmp: add dump machine type compatibility properties

2024-03-18 Thread Maksim Davydov
nding supported machines for their comparison via new optional argument of "query-machines" command. Since information on compatibility properties can increase the command output by a factor of 40, add an argument to enable it, default off. Signed-off-by: Maksim Davydov Reviewed-by: Vla

[PULL v2 4/4] scripts: add script to compare compatibility properties

2024-03-18 Thread Maksim Davydov
│ ├──┼──┼┼┤ │virtio-mem│ unplugged-inaccessible │ False│ auto│ ╘══╧══╧╧

[PULL v2 3/4] python/qemu/machine: add method to retrieve QEMUMachine::binary field

2024-03-18 Thread Maksim Davydov
Add a supportive property to access the path to the QEMU binary Signed-off-by: Maksim Davydov Reviewed-by: John Snow Reviewed-by: Philippe Mathieu-Daudé --- python/qemu/machine/machine.py | 5 + 1 file changed, 5 insertions(+) diff --git a/python/qemu/machine/machine.py b/python/qemu

[PULL v2 0/4] machine development tool

2024-03-18 Thread Maksim Davydov
evelopment ---- Maksim Davydov (4): qom: add default value qmp: add dump machine type compatibility properties python/qemu/machine: add method to retrieve QEMUMachine::binary field scripts: add script to compare compatibility properties MAINTAINERS | 5 + hw/core/m

Re: [PATCH v4 4/4] scripts: add script to compare compatible properties

2023-01-12 Thread Maksim Davydov
On 12/12/22 13:53, Dr. David Alan Gilbert wrote: * Maksim Davydov (davydov-...@yandex-team.ru) wrote: This script run QEMU to obtain compat_props of machines and default values of different types and produce appropriate table. This table can be used to compare machine types to choose the most

[PATCH v5 2/4] python/qmp: increase read buffer size

2023-01-12 Thread Maksim Davydov
Current 256KB is not enough for some real cases. As a possible solution limit can be chosen to be the same as libvirt (10MB) Signed-off-by: Maksim Davydov Reviewed-by: John Snow --- python/qemu/qmp/qmp_client.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/python

[PATCH v5 0/4] compare machine type compat_props

2023-01-12 Thread Maksim Davydov
field to reduce output JSON size Maksim Davydov (4): qom: add default value python/qmp: increase read buffer size qmp: add dump machine type compatible properties scripts: add script to compare compatible properties hw/core/machine-qmp-cmds.c| 23 +- python/qemu/qmp/qmp_c

[PATCH v5 4/4] scripts: add script to compare compatible properties

2023-01-12 Thread Maksim Davydov
─┼──┼┤ │ virtio-blk-device:write-zeroes│False │ True│ ├───┼──┼┤ │ x86_64-cpu:x-intel-pt-auto-level

[PATCH v5 1/4] qom: add default value

2023-01-12 Thread Maksim Davydov
qmp_qom_list_properties can print default values if they are available as qmp_device_list_properties does, because both of them use the ObjectPropertyInfo structure with default_value field. This can be useful when working with "not device" types. Signed-off-by: Maksim Davydov R

[PATCH v5 3/4] qmp: add dump machine type compatible properties

2023-01-12 Thread Maksim Davydov
nding supported machines for their comparison via new optional argument of "query-machines" command. Signed-off-by: Maksim Davydov Reviewed-by: Vladimir Sementsov-Ogievskiy --- hw/core/machine-qmp-cmds.c | 23 +++- qapi/machine.json | 54 +

Re: [PATCH v3 2/7] target/i386: Add new EPYC CPU versions with updated cache_info

2023-04-25 Thread Maksim Davydov
/ } +}, +.cache_info = &epyc_rome_v3_cache_info +}, { /* end of list */ } } }, -- Best regards, Maksim Davydov

Re: [PATCH v3 2/7] target/i386: Add new EPYC CPU versions with updated cache_info

2023-04-26 Thread Maksim Davydov
On 4/25/23 18:35, Moger, Babu wrote: Hi Maksim, On 4/25/23 07:51, Maksim Davydov wrote: On 4/24/23 19:33, Babu Moger wrote: From: Michael Roth Introduce new EPYC cpu versions: EPYC-v4 and EPYC-Rome-v3. The only difference vs. older models is an updated cache_info with the

[PATCH] target/i386: EPYC-Rome model without XSAVES

2023-05-24 Thread Maksim Davydov
olution of fixing this erratum Signed-off-by: Maksim Davydov --- target/i386/cpu.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/target/i386/cpu.c b/target/i386/cpu.c index a61cd6d99d1f..1242bd541a53 100644 --- a/target/i386/cpu.c +++ b/target/i386/cpu.c @@ -4466,6 +4466,16 @@ st

[PATCH] chardev: fix segfault in finalize

2022-08-25 Thread Maksim Davydov
` command. Signed-off-by: Maksim Davydov --- chardev/msmouse.c | 4 +++- chardev/wctablet.c | 4 +++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/chardev/msmouse.c b/chardev/msmouse.c index eb9231dcdb..2cc1b16561 100644 --- a/chardev/msmouse.c +++ b/chardev/msmouse.c @@ -146,7 +146,9

[PATCH v3 0/4] compare machine type compat_props

2022-11-03 Thread Maksim Davydov
to collect qmp data * remove auxiliary patches (that was used to fix `->get` sematics) * print compat_props in the correct order * delete `absract` field to reduce output JSON size Maksim Davydov (4): qom: add default value python/qmp: increase read buffer size qmp: add dump machin

[PATCH v3 2/4] python/qmp: increase read buffer size

2022-11-03 Thread Maksim Davydov
After modification of "query-machines" command the buffer size should be more than 452kB to contain output with compat-props. Signed-off-by: Maksim Davydov Reviewed-by: Vladimir Sementsov-Ogievskiy --- python/qemu/qmp/qmp_client.py | 4 ++-- 1 file changed, 2 insertions(+), 2

[PATCH v3 4/4] scripts: add script to compare compatible properties

2022-11-03 Thread Maksim Davydov
─┼──┼┤ │ virtio-blk-device:write-zeroes│False │ True│ ├───┼──┼┤ │ x86_64-cpu:x-intel-pt-auto-level

[PATCH v3 1/4] qom: add default value

2022-11-03 Thread Maksim Davydov
qmp_qom_list_properties can print default values if they are available as qmp_device_list_properties does, because both of them use the ObjectPropertyInfo structure with default_value field. This can be useful when working with "not device" types. Signed-off-by: Maksim Davydov R

[PATCH v3 3/4] qmp: add dump machine type compatible properties

2022-11-03 Thread Maksim Davydov
nding supported machines for their comparison via new optional argument of "query-machines" command. Signed-off-by: Maksim Davydov Reviewed-by: Vladimir Sementsov-Ogievskiy --- hw/core/machine-qmp-cmds.c | 22 ++- qapi/machine.json | 54 +

Re: [PATCH v3 4/4] scripts: add script to compare compatible properties

2022-11-08 Thread Maksim Davydov
On 11/8/22 18:37, Vladimir Sementsov-Ogievskiy wrote: On 11/3/22 13:27, Maksim Davydov wrote: This script run QEMU to obtain compat_props of machines and default values of different types and produce appropriate table. This table can be used to compare machine types to choose the most

Re: [PATCH v5 4/4] scripts: add script to compare compatible properties

2023-02-06 Thread Maksim Davydov
Ping On 1/12/23 18:28, Maksim Davydov wrote: This script run QEMU to obtain compat_props of machines and default values of different types and produce appropriate table. This table can be used to compare machine types to choose the most suitable machine. Also this table in json or csv format

[PATCH v4 2/4] python/qmp: increase read buffer size

2022-12-07 Thread Maksim Davydov
Current 256KB is not enough for some real cases. As a possible solution limit can be chosen to be the same as libvirt (10MB) Signed-off-by: Maksim Davydov --- python/qemu/qmp/qmp_client.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/python/qemu/qmp/qmp_client.py b

[PATCH v4 3/4] qmp: add dump machine type compatible properties

2022-12-07 Thread Maksim Davydov
nding supported machines for their comparison via new optional argument of "query-machines" command. Signed-off-by: Maksim Davydov Reviewed-by: Vladimir Sementsov-Ogievskiy --- hw/core/machine-qmp-cmds.c | 22 ++- qapi/machine.json | 54 +

[PATCH v4 0/4] compare machine type compat_props

2022-12-07 Thread Maksim Davydov
d descriptions * reorder patches v1 -> previous iteration: * new default value print concept * QEMU python library is used to collect qmp data * remove auxiliary patches (that was used to fix `->get` sematics) * print compat_props in the correct order * delete `absract` field to reduce outpu

[PATCH v4 4/4] scripts: add script to compare compatible properties

2022-12-07 Thread Maksim Davydov
─┼──┼┤ │ virtio-blk-device:write-zeroes│False │ True│ ├───┼──┼┤ │ x86_64-cpu:x-intel-pt-auto-level

[PATCH v4 1/4] qom: add default value

2022-12-07 Thread Maksim Davydov
qmp_qom_list_properties can print default values if they are available as qmp_device_list_properties does, because both of them use the ObjectPropertyInfo structure with default_value field. This can be useful when working with "not device" types. Signed-off-by: Maksim Davydov R

[PATCH v8 3/4] python/qemu/machine: add method to retrieve QEMUMachine::binary field

2024-01-25 Thread Maksim Davydov
Add a supportive property to access the path to the QEMU binary Signed-off-by: Maksim Davydov Reviewed-by: John Snow Reviewed-by: Philippe Mathieu-Daudé --- python/qemu/machine/machine.py | 5 + 1 file changed, 5 insertions(+) diff --git a/python/qemu/machine/machine.py b/python/qemu

[PATCH v8 0/4] compare machine type compat_props

2024-01-25 Thread Maksim Davydov
teration: * new default value print concept * QEMU python library is used to collect qmp data * remove auxiliary patches (that was used to fix `->get` sematics) * print compat_props in the correct order * delete `absract` field to reduce output JSON size Maksim Davydov (4): qom: qom-list-properti

[PATCH v8 2/4] qmp: add dump machine type compatibility properties

2024-01-25 Thread Maksim Davydov
nding supported machines for their comparison via new optional argument of "query-machines" command. Signed-off-by: Maksim Davydov Reviewed-by: Vladimir Sementsov-Ogievskiy --- hw/core/machine-qmp-cmds.c | 23 - qapi/machine.json | 64 +

[PATCH v8 1/4] qom: qom-list-properties: add default value

2024-01-25 Thread Maksim Davydov
qmp_qom_list_properties can print default values if they are available as qmp_device_list_properties does, because both of them use the ObjectPropertyInfo structure with default_value field. This can be useful when working with "not device" types (e.g. memory-backend). Signed-off-

[PATCH v8 4/4] scripts: add script to compare compatibility properties

2024-01-25 Thread Maksim Davydov
│ ├──┼──┼┼┤ │virtio-mem│ unplugged-inaccessible │ False│ auto│ ╘══╧══╧╧

[PATCH] target/i386: Add x-amd-ccx-size property

2024-05-21 Thread Maksim Davydov
, but for others the default value will remain. Signed-off-by: Maksim Davydov --- target/i386/cpu.c | 19 +-- target/i386/cpu.h | 3 +++ 2 files changed, 16 insertions(+), 6 deletions(-) diff --git a/target/i386/cpu.c b/target/i386/cpu.c index cfe7c92d6b..bbf8fb137c 100644 --- a/t

[PATCH 2/4] qmp: add dump machine type compatible properties

2022-09-08 Thread Maksim Davydov
nding supported machines for their comparison via new optional argument of "query-machines" command. Signed-off-by: Maksim Davydov --- hw/core/machine-qmp-cmds.c | 22 ++- qapi/machine.json | 54 +++-- tests/qtest/fuzz/qos_fuzz.c |

[PATCH 1/4] qom: add devault value

2022-09-08 Thread Maksim Davydov
qmp_qom_list_properties can print default values if they are available as qmp_device_list_properties does, because both of them use the ObjectPropertyInfo structure with default_value field. This can be useful when working with "not device" types. Signed-off-by: Maksim Davydov --- q

[PATCH 0/4] compare machine type compat_props

2022-09-08 Thread Maksim Davydov
anges: * new default value print concept * QEMU python library is used to collect qmp data * remove auxiliary patches (that was used to fix ->get sematics) * print compat_props in the correct order * delete `absract` field to reduce output JSON size Maksim Davydov (4): qom: add devault value qmp:

[PATCH 3/4] python/qmp: increase read buffer size

2022-09-08 Thread Maksim Davydov
After modification of "query-machines" command the buffer size should be more than 452kB to contain output with compat-props. Signed-off-by: Maksim Davydov --- python/qemu/qmp/qmp_client.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/python/qemu/qmp/qmp_c

[PATCH 4/4] scripts: add script to compare compatible properties

2022-09-08 Thread Maksim Davydov
│ False │ [True, False] │ ├┼───┼───┤ │ x86_64-cpu-x-hv-synic-kvm-only │ True │ False │ ╘╧═══╧═══╛ Signed-off-by: Maksim Davydov --- scripts/co

Re: [PATCH] chardev: fix segfault in finalize

2022-09-14 Thread Maksim Davydov
+ vsementsov@- pbonzini@   26.08.2022, 11:21, "Marc-André Lureau" :Hi  On Thu, Aug 25, 2022 at 9:02 PM Maksim Davydov <davydov-...@yandex-team.ru> wrote:If finalize chardev-msmouse or chardev-wctable is called immediately afterinit it cases QEMU to crash with segfault. This

[PATCH v2 2/4] python/qmp: increase read buffer size

2022-09-14 Thread Maksim Davydov
After modification of "query-machines" command the buffer size should be more than 452kB to contain output with compat-props. Signed-off-by: Maksim Davydov Reviewed-by: Vladimir Sementsov-Ogievskiy --- python/qemu/qmp/qmp_client.py | 4 ++-- 1 file changed, 2 insertions(+), 2

[PATCH v2 0/4] compare machine type compat_props

2022-09-14 Thread Maksim Davydov
* delete `absract` field to reduce output JSON size Maksim Davydov (4): qom: add devault value python/qmp: increase read buffer size qmp: add dump machine type compatible properties scripts: add script to compare compatible properties hw/core/machine-qmp-cmds.c| 22 +- python

[PATCH v2 4/4] scripts: add script to compare compatible properties

2022-09-14 Thread Maksim Davydov
──┼───┼───┤ │ x86_64-cpu-topoext │ False │ [True, False] │ ├┼───┼───┤ │ x86_64-cpu-x-hv-synic-kvm-only │ True │ False │ ╘╧═══╧═══╛ Signed-off-by: Maksim Davydov --- scripts/co

[PATCH v2 1/4] qom: add devault value

2022-09-14 Thread Maksim Davydov
qmp_qom_list_properties can print default values if they are available as qmp_device_list_properties does, because both of them use the ObjectPropertyInfo structure with default_value field. This can be useful when working with "not device" types. Signed-off-by: Maksim Davydov R

[PATCH v2 3/4] qmp: add dump machine type compatible properties

2022-09-14 Thread Maksim Davydov
nding supported machines for their comparison via new optional argument of "query-machines" command. Signed-off-by: Maksim Davydov Reviewed-by: Vladimir Sementsov-Ogievskiy --- hw/core/machine-qmp-cmds.c | 22 ++- qapi/machine.json | 54 +

Re: [PATCH v2 4/4] scripts: add script to compare compatible properties

2022-09-19 Thread Maksim Davydov
 Hi!14.09.2022, 21:25, "Vladimir Sementsov-Ogievskiy" :On 9/14/22 13:55, Maksim Davydov wrote: This script run QEMU to obtain compat_props of machines and default values of different types and produce appropriate table. This table can be used to compare machine types to choose the mos

Re: [PATCH v2 4/4] scripts: add script to compare compatible properties

2022-09-19 Thread Maksim Davydov
Hi! 16.09.2022, 08:57, "Markus Armbruster" :Maksim Davydov <davydov-...@yandex-team.ru> writes:  This script run QEMU to obtain compat_props of machines and default values of different types and produce appropriate table. This table can be used to compare machine types to choose t

Re: [PATCH] chardev: fix segfault in finalize

2022-09-20 Thread Maksim Davydov
Hi!Could you send a pull request? 26.08.2022, 11:21, "Marc-André Lureau" :Hi  On Thu, Aug 25, 2022 at 9:02 PM Maksim Davydov <davydov-...@yandex-team.ru> wrote:If finalize chardev-msmouse or chardev-wctable is called immediately afterinit it cases QEMU to crash with segfault. This

Re: [PATCH 12/12] io/channel-socket: qio_channel_socket_flush(): improve msg validation

2023-09-26 Thread Maksim Davydov
o_copy_sent += serr->ee_data - serr->ee_info + 1; -- Best regards, Maksim Davydov

Re: [PATCH v2 0/8] coverity fixes

2023-09-27 Thread Maksim Davydov
| 5 + subprojects/libvhost-user/libvhost-user.c | 1 + util/filemonitor-inotify.c| 25 +++ 8 files changed, 52 insertions(+), 22 deletions(-) all patches: Reviewed-by: Maksim Davydov

Re: [PATCH v6 2/4] qmp: add dump machine type compatible properties

2023-12-13 Thread Maksim Davydov
Thanks for reviewing Sorry for replying late On 12/1/23 12:49, Markus Armbruster wrote: I apologize for the lateness of my review. Maksim Davydov writes: To control that creating new machine type doesn't affect the previous types (their compat_props) and to check complex compat_

Re: [PATCH v6 4/4] scripts: add script to compare compatible properties

2023-12-13 Thread Maksim Davydov
On 12/1/23 12:51, Markus Armbruster wrote: Review, anyone? Only Vladimir Maksim Davydov writes: This script runs QEMU to obtain compat_props of machines and default values of different types of drivers to produce comparison table. This table can be used to compare machine types to

[PATCH v7 2/4] qmp: add dump machine type compatibility properties

2023-12-14 Thread Maksim Davydov
nding supported machines for their comparison via new optional argument of "query-machines" command. Signed-off-by: Maksim Davydov Reviewed-by: Vladimir Sementsov-Ogievskiy --- hw/core/machine-qmp-cmds.c | 23 - qapi/machine.json | 64 +

[PATCH v7 3/4] python/qemu/machine: add method to retrieve QEMUMachine::binary field

2023-12-14 Thread Maksim Davydov
Add a supportive property to access the path to the QEMU binary Signed-off-by: Maksim Davydov Reviewed-by: John Snow Reviewed-by: Philippe Mathieu-Daud?? --- python/qemu/machine/machine.py | 5 + 1 file changed, 5 insertions(+) diff --git a/python/qemu/machine/machine.py b/python/qemu

[PATCH v7 1/4] qom: qom-list-properties: add default value

2023-12-14 Thread Maksim Davydov
qmp_qom_list_properties can print default values if they are available as qmp_device_list_properties does, because both of them use the ObjectPropertyInfo structure with default_value field. This can be useful when working with "not device" types (e.g. memory-backend). Signed-off-

[PATCH v7 0/4] compare machine type compat_props

2023-12-14 Thread Maksim Davydov
t * QEMU python library is used to collect qmp data * remove auxiliary patches (that was used to fix `->get` sematics) * print compat_props in the correct order * delete `absract` field to reduce output JSON size Maksim Davydov (4): qom: qom-list-properties: add default value qmp: add du

[PATCH v7 4/4] scripts: add script to compare compatibility properties

2023-12-14 Thread Maksim Davydov
│ ├──┼──┼┼┤ │virtio-mem│ unplugged-inaccessible │ False│ auto│ ╘══╧══╧═

[PATCH v6 3/4] python: add binary

2023-11-08 Thread Maksim Davydov
Add a supportive property to access the path to the qemu binary Signed-off-by: Maksim Davydov --- python/qemu/machine/machine.py | 5 + 1 file changed, 5 insertions(+) diff --git a/python/qemu/machine/machine.py b/python/qemu/machine/machine.py index 31cb9d617d..78436403b2 100644 --- a

[PATCH v6 1/4] qom: add default value

2023-11-08 Thread Maksim Davydov
qmp_qom_list_properties can print default values if they are available as qmp_device_list_properties does, because both of them use the ObjectPropertyInfo structure with default_value field. This can be useful when working with "not device" types (e.g. memory-backend). Signed-off-

[PATCH v6 0/4] compare machine type compat_props

2023-11-08 Thread Maksim Davydov
sed to collect qmp data * remove auxiliary patches (that was used to fix `->get` sematics) * print compat_props in the correct order * delete `absract` field to reduce output JSON size Maksim Davydov (4): qom: add default value qmp: add dump machine type compatible properties python: add bi

[PATCH v6 2/4] qmp: add dump machine type compatible properties

2023-11-08 Thread Maksim Davydov
nding supported machines for their comparison via new optional argument of "query-machines" command. Signed-off-by: Maksim Davydov Reviewed-by: Vladimir Sementsov-Ogievskiy --- hw/core/machine-qmp-cmds.c | 23 +++- qapi/machine.json | 54 +

[PATCH v6 4/4] scripts: add script to compare compatible properties

2023-11-08 Thread Maksim Davydov
│ ├──┼──┼┼┤ │virtio-mem│ unplugged-inaccessible │ False│ auto│ ╘══╧══╧╧

Re: [PATCH v6 3/4] python: add binary

2023-11-14 Thread Maksim Davydov
Thanks for reviewing! I'll change patch subject to more appropriate one and fix the docstring On 11/10/23 10:03, Philippe Mathieu-Daudé wrote: On 8/11/23 16:38, Maksim Davydov wrote: Add a supportive property to access the path to the qemu binary Signed-off-by: Maksim Davydov ---   p

Re: [PATCH v4 7/7] target/i386: Add EPYC-Genoa model to support Zen 4 processor series

2024-11-08 Thread Maksim Davydov
PUID_SVM_SVME_ADDR_CHK, +.xlevel = 0x8022, +.model_id = "AMD EPYC-Genoa Processor", +.cache_info = &epyc_genoa_cache_info, +}, }; /* -- Best regards, Maksim Davydov

Re: [PATCH v4 7/7] target/i386: Add EPYC-Genoa model to support Zen 4 processor series

2024-11-13 Thread Maksim Davydov
Hi! Thank you very much! I'm looking forward to your Genoa/Turin series. And I've sent patch series to KVM: https://lore.kernel.org/lkml/20241113133042.702340-1-davydov-...@yandex-team.ru/ On 11/12/24 19:23, Moger, Babu wrote: Hi Maksim, On 11/12/24 04:09, Maksim Davydov wrote:

Re: [PATCH v4 7/7] target/i386: Add EPYC-Genoa model to support Zen 4 processor series

2024-11-12 Thread Maksim Davydov
On 11/8/24 23:56, Moger, Babu wrote: Hi Maxim, Thanks for looking into this. I will fix the bits I mentioned below in upcoming Genoa/Turin model update. I have few comments below. On 11/8/2024 12:15 PM, Maksim Davydov wrote: Hi! I compared EPYC-Genoa CPU model with CPUID output from

Re: [PATCH 5/7] target/i386/kvm: reset AMD PMU registers during VM reset

2024-11-07 Thread Maksim Davydov
index = index - MSR_F15H_PERF_CTL0; +if (index & 0x1) { +env->msr_gp_counters[index] = msrs[i].data; +} else { + env->msr_gp_evtsel[index] = msrs[i].data; +} +break; case HV_X64_MSR_HYPERCALL: env->msr_hv_hypercall = msrs[i].data; break; -- Best regards, Maksim Davydov

Re: [PATCH 5/7] target/i386/kvm: reset AMD PMU registers during VM reset

2024-11-08 Thread Maksim Davydov
On 11/8/24 04:19, dongli.zh...@oracle.com wrote: Hi Maksim, On 11/7/24 1:00 PM, Maksim Davydov wrote: On 11/4/24 12:40, Dongli Zhang wrote: QEMU uses the kvm_get_msrs() function to save Intel PMU registers from KVM and kvm_put_msrs() to restore them to KVM. However, there is no support

Re: [PATCH v4 0/5] target/i386: Update EPYC CPU models for Cache property, RAS, SVM feature bits

2024-11-15 Thread Maksim Davydov
SVM feature bits which are required in nested guests. 4. Add perfmon-v2 on Genoa. 5. Add missing feature bit fs-gs-base-ns(WRMSR to {FS,GS,KERNEL_G}S_BASE is non-serializing). Seems good for me. I've tested cache changes. If needed, Reviewed-by: Maksim Davydov Dropped EPYC-Turin mode