=0x563b4c44bb80) at
../util/qemu-thread-posix.c:541
#5 0x7f7fe9b5b3f9 in ?? ()
#6 0x in ?? ()
It's enough to check migrate_multifd_is_allowed() in multifd cleanup() and
multifd setup() though there are so many other places using
migrate_use_multifd().
Signed-off-by: Li Zh
Signed-off-by: Li Zhijian
---
migration/rdma.c | 2 +-
softmmu/cpus.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/migration/rdma.c b/migration/rdma.c
index 7fb9646f6ef..e99e2e16a73 100644
--- a/migration/rdma.c
+++ b/migration/rdma.c
@@ -1133,7 +1133,7 @@ static int
t /lib64/libc.so.6 '
Signed-off-by: Li Zhijian
---
migration/rdma.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/migration/rdma.c b/migration/rdma.c
index b6cc4bef4a8..0f22b8227c0 100644
--- a/migration/rdma.c
+++ b/migration/rdma.c
@@ -1143,6 +1143,7 @@ static int qemu_rdma_reg_who
xed completion queue.
It helps us to poll the specific CQE we are really interesting in.
Signed-off-by: Li Zhijian
---
V2 Introduce send completion queue
---
migration/rdma.c | 94
1 file changed, 79 insertions(+), 15 deletions(-)
diff --git a/m
make the code more clear
Signed-off-by: Li Zhijian
---
migration/rdma.c | 50
1 file changed, 25 insertions(+), 25 deletions(-)
diff --git a/migration/rdma.c b/migration/rdma.c
index 16fe0688858..527972d4970 100644
--- a/migration/rdma.c
+++ b
on 2021/9/14 21:19, Peter Maydell wrote:
On Tue, 14 Sept 2021 at 12:56, Juan Quintela wrote:
The following changes since commit c6f5e042d89e79206cd1ce5525d3df219f13c3cc:
Merge remote-tracking branch
'remotes/pmaydell/tags/pull-target-arm-20210913-3' into staging (2021-09-13
21:06:15 +01
on 2021/9/9 21:42, Peter Maydell wrote:
On Thu, 9 Sept 2021 at 11:36, Juan Quintela wrote:
Fails to build, FreeBSD:
../src/migration/rdma.c:1146:23: error: use of undeclared identifier
'IBV_ADVISE_MR_ADVICE_PREFETCH_WRITE'
int advice = wr ? IBV_ADVISE_MR_ADVICE_PREFETCH_WRITE :
the responder does page fault as little as possible.
Signed-off-by: Li Zhijian
Reviewed-by: Marcel Apfelbaum
---
V3: Fix FreeBSD compiling errors
V2: use IBV_ADVISE_MR_FLAG_FLUSH instead of IB_UVERBS_ADVISE_MR_FLAG_FLUSH
and add Reviewed-by tag. # Marcel
---
meson.build| 6
in some modern HCA hardware/drivers.
For the (2), IB provides advise API to prefetch pages in specific memory
region. It can help driver reduce the page fault on responder(destination)
side during RDMA_WRITE.
V3: fix FreeBSD compling error
Li Zhijian (2):
migration/rdma: Try to register On
]: http://pmem.io/rpma/manpages/v0.9.0/rpma_mr_reg.3
CC: Marcel Apfelbaum
Signed-off-by: Li Zhijian
Reviewed-by: Marcel Apfelbaum
---
V2: add ODP sanity check and remove goto
---
migration/rdma.c | 73 ++
migration/trace-events | 1 +
2 files changed
on 2021/9/10 20:55, Philippe Mathieu-Daudé wrote:
BTW: Does QEMU provide any mean to set http(s)_proxy to building vm ?
Currently, i have to
hack the code like:
-self.ssh_root_check("pkg install -y %s\n" % " ".join(self.pkgs))
+self.ssh_root_check("setenv HTTP_PROXY http://myp
Signed-off-by: Li Zhijian
---
hw/acpi/nvdimm.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/hw/acpi/nvdimm.c b/hw/acpi/nvdimm.c
index e3d5fe19392..ff317263e85 100644
--- a/hw/acpi/nvdimm.c
+++ b/hw/acpi/nvdimm.c
@@ -355,10 +355,10
evice path
/sys/class/infiniband_verbs/uverbs2, infiniband class device path
/sys/class/infiniband/rxe_eth0, transport: (2) Ethernet
rdma_get_cm_event != EVENT_ESTABLISHED after rdma_connect: No space left on
device
Signed-off-by: Li Zhijian
---
migration/rdma.c | 4 ++--
1 file changed, 2 inser
how about do switch inside colo_compare_inconsistency_notify(), like:
colo_compare_inconsistency_notify(CompareState *s)
{
if (s->remote_notify)
remote_notify
else
local_notity
}
Thanks
Zhijian
On 6/2/19 11:42 AM, Zhang Chen wrote:
From: Zhang Ch
: Caio Carrara
CC: Cleber Rosa
CC: Eduardo Habkost
CC: Philippe Mathieu-Daudé
Signed-off-by: Li Zhijian
---
V2: fix typos
---
tests/acceptance/linux_initrd.py | 14 --
1 file changed, 8 insertions(+), 6 deletions(-)
diff --git a/tests/acceptance/linux_initrd.py b/tests/acceptance
a
CC: Eduardo Habkost
CC: Philippe Mathieu-Daudé
Signed-off-by: Li Zhijian
---
V2: fix typos
---
tests/acceptance/linux_initrd.py | 37 -
1 file changed, 36 insertions(+), 1 deletion(-)
diff --git a/tests/acceptance/linux_initrd.py b/tests/acceptance/linux_init
,
qemu_mutex_unlock(&decomp_done_lock);
}
+ /*
+ * we must set ram_bulk_stage to fasle, otherwise in
a typo: s/fasle/false
Reviewed-by: Li Zhijian
+ * migation_bitmap_find_dirty the bitmap will be unused and
+ * all the pages in ram cache wil be flushed to the ram of
+ * secondary VM.
+ */
+st
On 9/23/20 9:41 AM, Zhang, Chen wrote:
-Original Message-
From: Li Zhijian
Sent: Tuesday, September 22, 2020 5:55 PM
To: Zhang, Chen ; jasow...@redhat.com
Cc: qemu-devel@nongnu.org; Li Zhijian
Subject: [PATCH 1/3] colo-compare: return -1 if no packet is queued
Return 0 will
On 9/23/20 2:47 PM, Zhang, Chen wrote:
-Original Message-
From: Li Zhijian
Sent: Tuesday, September 22, 2020 2:47 PM
To: Zhang, Chen ; Jason Wang
; qemu-dev
Cc: Zhang Chen
Subject: Re: [PATCH 3/4] net/colo-compare.c: Add secondary old packet
detection
On 9/18/20 5:22 PM, Zhang
On 9/18/20 5:22 PM, Zhang Chen wrote:
From: Zhang Chen
This parameter need compare with the return of qemu_clock_get_ms(),
it is uinit64_t. So we need fix this issue here.
Reported-by: Derek Su
Signed-off-by: Zhang Chen
Reviewed-by: Li Zhijian
---
net/colo-compare.c | 12
suspended. COLO need to know the host time here.
Reported-by: Derek Su
Signed-off-by: Zhang Chen
Reviewed-by: Li Zhijian
---
net/colo-compare.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/net/colo-compare.c b/net/colo-compare.c
index 7cba573dae..3b72309d08
On 9/18/20 5:22 PM, Zhang Chen wrote:
From: Zhang Chen
Detect queued secondary packet to sync VM state in time.
Signed-off-by: Zhang Chen
---
net/colo-compare.c | 25 -
1 file changed, 16 insertions(+), 9 deletions(-)
diff --git a/net/colo-compare.c b/net/colo-c
On 9/19/20 11:10 AM, leirao wrote:
The seq of tcp has been filled in fill_pkt_tcp_info, it
can be used directly here.
Signed-off-by: leirao
Reviewed-by: Li Zhijian
---
net/colo-compare.c | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/net/colo-compare.c b
On 9/19/20 11:10 AM, leirao wrote:
we should set ram_bulk_stage to false after ram_state_init,
otherwise the bitmap will be unused in migration_bitmap_find_dirty.
all pages in ram cache will be flushed to the ram of secondary guest
for each checkpoint.
Signed-off-by: leirao
---
migration/r
Signed-off-by: Li Zhijian
---
net/colo.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/net/colo.c b/net/colo.c
index a6c66d829a..ef00609848 100644
--- a/net/colo.c
+++ b/net/colo.c
@@ -133,14 +133,11 @@ void reverse_connection_key(ConnectionKey *key)
Connection
Li Zhijian (3):
colo-compare: return -1 if no packet is enqueued
colo-compare: fix missing compare_seq init
colo-compare: check mark in mutual exclusion
net/colo-compare.c | 7 +++
net/colo.c | 5 +
2 files changed, 4 insertions(+), 8 deletions(-)
--
2.28.0
Return 0 will trigger a packet comparison
Signed-off-by: Li Zhijian
---
net/colo-compare.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/net/colo-compare.c b/net/colo-compare.c
index 3a45d64175..039b515611 100644
--- a/net/colo-compare.c
+++ b/net/colo-compare.c
@@ -289,6 +289,7 @@ static
Signed-off-by: Li Zhijian
---
net/colo-compare.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/net/colo-compare.c b/net/colo-compare.c
index 039b515611..19633fc684 100644
--- a/net/colo-compare.c
+++ b/net/colo-compare.c
@@ -481,13 +481,11 @@ sec
On 8/26/20 10:54 PM, Li Qiang wrote:
Li Zhijian 于2020年8月21日周五 下午7:34写道：
we go here either (!(*iov)[i].iov_base) or (len != l), so we need to consider
to unmap the 'i'th item as well when the 'i'th item is not nil
Signed-off-by: Li Zhijian
---
v2: address Gerd's
we go here either (!(*iov)[i].iov_base) or (len != l), so we need to consider
to unmap the 'i'th item as well when the 'i'th item is not nil
CC: Li Qiang
Signed-off-by: Li Zhijian
---
v2: address Gerd's comments
v3: leave (*iov)[i].iov_len as the real mapped len (
...@fujitsu.com
[2]
https://lore.kernel.org/r/cahecvy7hxswn4ow_kog+q+tn6f_kmeichevz1qgm-fbxbpp...@mail.gmail.com
CC: Peter Xu
CC: Philippe Mathieu-Daudé
CC: Fabiano Rosas
CC: Thomas Huth
CC: Daniel P. Berrangé
CC: Yu Zhang
Signed-off-by: Li Zhijian
---
docs/about/deprecated.rst | 15
It helps to figure out where the first dvsec register is located. In
addition, replace offset and size hardcore with existing macros.
Signed-off-by: Li Zhijian
---
hw/mem/cxl_type3.c | 19 +--
1 file changed, 13 insertions(+), 6 deletions(-)
diff --git a/hw/mem/cxl_type3.c b/hw
ult) value in reboot so that the OS can read its clean status.
Signed-off-by: Li Zhijian
---
hw/mem/cxl_type3.c | 14 +-
1 file changed, 13 insertions(+), 1 deletion(-)
diff --git a/hw/mem/cxl_type3.c b/hw/mem/cxl_type3.c
index ad2fe7d463fb..3fe136053390 100644
--- a/hw/mem/cxl_typ
registers could be changed by the firmware or OS, let them have
their initial value in reboot so that the OS can read their clean status.
Fixes: e1706ea83da0 ("hw/cxl/device: Add a memory device (8.2.8.5)")
Signed-off-by: Li Zhijian
---
root_port, usp and dsp have the same issue, if this p
/-/issues/2277
Fixes: 2b3912f135 ("block: Mark bdrv_first_blk() and bdrv_is_root_node()
GRAPH_RDLOCK")
Signed-off-by: Li Zhijian
---
migration/colo.c | 17 +
1 file changed, 9 insertions(+), 8 deletions(-)
diff --git a/migration/colo.c b/migration/colo.c
index 84632a603e..
/-/issues/2277
Fixes: 2b3912f135 ("block: Mark bdrv_first_blk() and bdrv_is_root_node()
GRAPH_RDLOCK")
Signed-off-by: Li Zhijian
---
V2: fix missing bql_unlock() in error path.
---
migration/colo.c | 18 ++
1 file changed, 10 insertions(+), 8 deletions(-)
diff --git a
It seems that this error does not need to be propagated to the upper,
directly output the error to avoid the leaks
Closes: https://gitlab.com/qemu-project/qemu/-/issues/2283
Signed-off-by: Li Zhijian
---
backends/cryptodev-builtin.c | 9 +
1 file changed, 5 insertions(+), 4 deletions
- Explicitly show the missing module name: replication
- Fix capability name to x-colo
Signed-off-by: Li Zhijian
---
migration/migration.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/migration/migration.c b/migration/migration.c
index 6502e169a3..b4a09c561c 100644
Make the code more tight.
Cc: Michael Tokarev
Signed-off-by: Li Zhijian
---
This change/comment suggested by "Michael Tokarev " came
a bit late at that time, let's update it together in these minor set
this time.
---
migration/colo.c | 3 +--
1 file changed, 1 insertion(
: Li Zhijian
---
migration/colo.c | 9 ++---
migration/migration.c | 6 +++---
2 files changed, 5 insertions(+), 10 deletions(-)
diff --git a/migration/colo.c b/migration/colo.c
index 5600a43d78..991806c06a 100644
--- a/migration/colo.c
+++ b/migration/colo.c
@@ -929,16 +929,13 @@ out
There is no user for this member. All '-M cxl-fmw.N' options have
been parsed and saved to CXLState.fixed_windows.
Signed-off-by: Li Zhijian
---
hw/cxl/cxl-host.c| 1 -
include/hw/cxl/cxl.h | 1 -
2 files changed, 2 deletions(-)
diff --git a/hw/cxl/cxl-host.c b/hw/cxl/cxl-ho
Rosas
Reviewed-by: Peter Xu
Reviewed-by: Zhang Chen
Signed-off-by: Li Zhijian
---
V2: Fix compilation failed, reported by Fabiano Rosas
Collected reviewed-by tags
---
include/migration/colo.h | 2 +-
migration/colo-stubs.c | 3 +--
migration/colo.c | 9 ++---
migration
- Explicitly show the missing module name: replication
- Fix capability name to x-colo
Reviewed-by: Peter Xu
Reviewed-by: Zhang Chen
Signed-off-by: Li Zhijian
---
V2: Collected reviewed-by tags
---
migration/migration.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a
Make the code more tight.
Suggested-by: Michael Tokarev
Reviewed-by: Peter Xu
Reviewed-by: Zhang Chen
Signed-off-by: Li Zhijian
---
V2: Collected reviewed-by tags
This change/comment suggested by "Michael Tokarev " came
a bit late at that time, let's update it together in these
r function to dynamically request an available MSIX number.
Fixes: 43efb0bfad2b ("hw/cxl/mbox: Wire up interrupts for background
completion")
Signed-off-by: Li Zhijian
---
hw/cxl/cxl-device-utils.c | 3 ++-
hw/mem/cxl_type3.c | 15 ++-
include/hw/cxl/cxl_device.h |
X MSIX number
Fixes: 43efb0bfad2b ("hw/cxl/mbox: Wire up interrupts for background
completion")
Signed-off-by: Li Zhijian
---
V2: just increase msix number and add enum to maintainer their values #
Jonathan
---
hw/cxl/cxl-device-utils.c | 6 ++
hw/mem/cxl_type3.c | 10 +++
msix_uninit_exclusive_bar() should be paired with msix_init_exclusive_bar()
Ensure proper resource cleanup by adding the missing
`msix_uninit_exclusive_bar()` call for the Type3 CXL device.
Signed-off-by: Li Zhijian
---
hw/mem/cxl_type3.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a
Address a memory leak issue by ensuring `regs->special_ops` is freed when
`msix_init_exclusive_bar()` encounters an error during CXL Type3 device
initialization.
Additionally, this patch renames err_address_space_free to err_msix_uninit
for better clarity and logical flow
Signed-off-by:
failure scenarios as successful and
potentially leading to redundant cleanup operations in ct3_exit().
Signed-off-by: Li Zhijian
---
hw/mem/cxl_type3.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/mem/cxl_type3.c b/hw/mem/cxl_type3.c
index 9eb3d0979cf5..c3b6a1d6a612
b0bfad2b ("hw/cxl/mbox: Wire up interrupts for background
completion")
Signed-off-by: Li Zhijian
---
V3:
Just increate the device's msix number, A new enumeration will be introduced
in later patch. # Jonathan
V2:
Just increase msix number and add enum to maintainer their v
device privately; other endpoints should refrain from
using it, despite its public accessibility to all of them.
Signed-off-by: Li Zhijian
---
V3: new patch to introduce a T3 specific enumeration # Jonathan
---
hw/cxl/cxl-device-utils.c | 12 +---
hw/cxl/switch-mailbox-cci.c | 4
Recently, we removed ipv6 restriction[0] from RDMA migration, add a
test for it.
[0]
https://lore.kernel.org/qemu-devel/20250326095224.9918-1-jinpu.w...@ionos.com/
Cc: Jack Wang
Cc: Michael R. Galaxy
Cc: Peter Xu
Cc: Yu Zhang
Signed-off-by: Li Zhijian
---
This test is added based on [1
This qtest requirs there is RXE link in the host.
Here is an example to show how to add this RXE link:
$ ./new-rdma-link.sh
192.168.22.93
Signed-off-by: Li Zhijian
---
The RDMA migration was broken again...due to lack of sufficient test/qtest.
It's urgly to add and execute a scri
lling control error
RDMA migration implemented its own protocol/method to send pages to
destination side, hand over to RDMA first to prevent pages being saved by
other protocol.
Fixes: bc38dc2f5f3 ("migration: refactor ram_save_target_page functions")
Signed-off-by: Li Zhijian
---
migr
transport.
For scenario D2, ensure compatibility within migrate_caps_check().
Reviewed-by: Peter Xu
Signed-off-by: Li Zhijian
---
V4:
- Remove Reviewed-tag and cover above D2 scenario
V3:
- collect Reviewed tag
- reorder: 5th -> 2nd
---
migration/migr
It's believed that RDMA + postcopy-ram has been broken for a while.
Rather than spending time re-enabling it, let's simply disable it as a
trade-off.
Reviewed-by: Peter Xu
Signed-off-by: Li Zhijian
---
V3:
- collect Reviewed tag
- reoder: 6th -> 3th
---
migration/options.c | 4
/x86_64/migration/precopy/rdma/plain # SKIP No rdma link available
# End of rdma tests
Note: Remove the newly added RXE link by executing 'modprobe -r rdma_rxe'
or by specifying 'clean' within this script.
Reviewed-by: Peter Xu
Signed-off-by: Li Zhijian
---
V5:
check comman
to prevent recently added code from being deleted
again.
- collect Reviewed tags from Peter
Changes since V1[0]:
Add some saparate patches to refactor and cleanup based on V1
[0]
https://lore.kernel.org/qemu-devel/20250218074345.638203-1-lizhij...@fujitsu.com/
Li Zhijian (6):
migration: Prio
lling control error
RDMA migration implemented its own protocol/method to send pages to
destination side, hand over to RDMA first to prevent pages being saved by
other protocol.
Fixes: bc38dc2f5f3 ("migration: refactor ram_save_target_page functions")
Reviewed-by: Peter Xu
Signed-off
Since we have disabled RDMA + postcopy, it's safe to remove
the migration_in_postcopy() that follows the migrate_rdma().
Reviewed-by: Peter Xu
Signed-off-by: Li Zhijian
---
V3:
reorder: 7th->4th
---
migration/rdma.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff
Reviewed-by: Peter Xu
Signed-off-by: Li Zhijian
---
V3:
squash previous 2nd, 3th, 4th into one patch
---
migration/ram.c | 34 +++---
migration/rdma.c | 7 ++-
migration/rdma.h | 3 +--
3 files changed, 10 insertions(+), 34 deletions(-)
diff --git a/migrati
er.sh clean' to revert the 'setup'
# End of rdma tests
Cc: Philippe Mathieu-Daudé
Cc: Stefan Hajnoczi
Reviewed-by: Peter Xu
Signed-off-by: Li Zhijian
---
Hi Fabiano,
Please replace this patch in your new PR.
---
V6:
- make scripts/rdma-migration-helper.sh rubost, including
uce a scripts/rdma-migration-helper.sh to
- setup a new RXE if it's root
- detect existing RoCE link
to make the qtest work smoothly.
Test will be skip if there is no available RoCE link.
# Start of rdma tests
# Running /x86_64/migration/precopy/rdma/plain
ok 1 /x86_64/migration/precopy/rdma
Refactor the page saving logic by integrating the control_save_page()
function directly into ram_save_target_page(). This change consolidates the
RDMA migration decision-making process into a single function, enhancing
clarity and maintainability.
Signed-off-by: Li Zhijian
---
migration/ram.c
test with root privilege
# End of rdma tests
Signed-off-by: Li Zhijian
---
MAINTAINERS | 1 +
scripts/rdma-migration-helper.sh | 41 +
tests/qtest/migration/precopy-tests.c | 64 +++
3 files changed, 106 insertions(+)
cre
qemu_rdma_save_page() no longer returns RAM_SAVE_CONTROL_NOT_SUPP
since commit a4832d299dd ("migration/rdma: Check sooner if we are in postcopy
for save_page()")
Signed-off-by: Li Zhijian
---
migration/rdma.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a
Similar to migration_channels_and_transport_compatible(), introduce a
new helper migration_capabilities_and_transport_compatible() to check if
the capabilites is compatible with the transport.
Currently, only move the capabilities vs RDMA transport to this
function.
Signed-off-by: Li Zhijian
lling control error
RDMA migration implemented its own protocol/method to send pages to
destination side, hand over to RDMA first to prevent pages being saved by
other protocol.
Fixes: bc38dc2f5f3 ("migration: refactor ram_save_target_page functions")
Signed-off-by: Li Zhijian
---
migr
It's believed that RDMA + postcopy-ram has been broken for a while.
Rather than spending time re-enabling it, let's simply disable it as a
trade-off.
Signed-off-by: Li Zhijian
---
migration/migration.c | 4
1 file changed, 4 insertions(+)
diff --git a/migration/migration.c b
() now takes responsibility for
determining whether RDMA operations can proceed, based on the state of
migration.
Signed-off-by: Li Zhijian
---
migration/ram.c | 19 ++-
migration/rdma.c | 4 +---
migration/rdma.h | 3 +--
3 files changed, 12 insertions(+), 14 deletions(-)
diff
Since we have disabled RDMA + postcopy, it's safe to remove
the migration_in_postcopy() that follows the migration_rdma().
Signed-off-by: Li Zhijian
---
migration/ram.c | 2 +-
migration/rdma.c | 5 +++--
2 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/migration/ra
- It fix the RDMA migration broken issue
- disable RDMA + postcopy
- some cleanups
- Add a qtest for RDMA at last
Changs since V1[0]:
Add some saparate patches to refactor and cleanup based on V1
[0]
https://lore.kernel.org/qemu-devel/20250218074345.638203-1-lizhij...@fujitsu.com/
Li Zhijian
test with root privilege
# End of rdma tests
Reviewed-by: Peter Xu
Signed-off-by: Li Zhijian
---
MAINTAINERS | 1 +
scripts/rdma-migration-helper.sh | 41 +
tests/qtest/migration/precopy-tests.c | 64 +++
3 files changed,
nnels and capabilities vs transport.
For scenario D2, ensure compatibility within migrate_caps_check().
Signed-off-by: Li Zhijian
---
V4:
- Remove Reviewed-tag and cover above D2 scenario
V3:
- collect Reviewed tag
- reorder: 5th -> 2nd
---
migration/migr
r and cleanup based on V1
[0]
https://lore.kernel.org/qemu-devel/20250218074345.638203-1-lizhij...@fujitsu.com/
Li Zhijian (6):
migration: Prioritize RDMA in ram_save_target_page()
migration: check RDMA and capabilities are compatible on both sides
migration: disable RDMA + postcopy-ram
Since we have disabled RDMA + postcopy, it's safe to remove
the migration_in_postcopy() that follows the migrate_rdma().
Signed-off-by: Li Zhijian
---
V3:
reorder: 7th->4th
---
migration/rdma.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/migration/
P.
Signed-off-by: Li Zhijian
---
V3:
squash previous 2nd, 3th, 4th into one patch
---
migration/ram.c | 34 +++---
migration/rdma.c | 7 ++-
migration/rdma.h | 3 +--
3 files changed, 10 insertions(+), 34 deletions(-)
diff --git a/migration/ram.c b/migration/r
lling control error
RDMA migration implemented its own protocol/method to send pages to
destination side, hand over to RDMA first to prevent pages being saved by
other protocol.
Fixes: bc38dc2f5f3 ("migration: refactor ram_save_target_page functions")
Reviewed-by: Peter Xu
Signed-off
It's believed that RDMA + postcopy-ram has been broken for a while.
Rather than spending time re-enabling it, let's simply disable it as a
trade-off.
Reviewed-by: Peter Xu
Signed-off-by: Li Zhijian
---
V3:
- collect Reviewed tag
- reoder: 6th -> 3th
---
migration/options.c | 4
-off-by: Li Zhijian
---
V3:
- collect Reviewed tag
- reorder: 5th -> 2nd
---
migration/migration.c | 36 ++--
1 file changed, 26 insertions(+), 10 deletions(-)
diff --git a/migration/migration.c b/migration/migration.c
index c597aa707e5..2eacae25e0e 100
test with root privilege
# End of rdma tests
Reviewed-by: Peter Xu
Signed-off-by: Li Zhijian
---
MAINTAINERS | 1 +
scripts/rdma-migration-helper.sh | 41 +
tests/qtest/migration/precopy-tests.c | 64 +++
3 files changed,
P.
Signed-off-by: Li Zhijian
---
V3:
squash previous 2nd, 3th, 4th into one patch
---
migration/ram.c | 34 +++---
migration/rdma.c | 7 ++-
migration/rdma.h | 3 +--
3 files changed, 10 insertions(+), 34 deletions(-)
diff --git a/migration/ram.c b/migration/r
lling control error
RDMA migration implemented its own protocol/method to send pages to
destination side, hand over to RDMA first to prevent pages being saved by
other protocol.
Fixes: bc38dc2f5f3 ("migration: refactor ram_save_target_page functions")
Reviewed-by: Peter Xu
Signed-off
It's believed that RDMA + postcopy-ram has been broken for a while.
Rather than spending time re-enabling it, let's simply disable it as a
trade-off.
Reviewed-by: Peter Xu
Signed-off-by: Li Zhijian
---
V3:
- collect Reviewed tag
- reoder: 6th -> 3th
---
migration/migration.
ng deleted
again.
- collect Reviewed tags from Peter
Changes since V1[0]:
Add some saparate patches to refactor and cleanup based on V1
[0]
https://lore.kernel.org/qemu-devel/20250218074345.638203-1-lizhij...@fujitsu.com/
Li Zhijian (6):
migration: Prioritize RDMA in ram_save_target_page()
migr
Since we have disabled RDMA + postcopy, it's safe to remove
the migration_in_postcopy() that follows the migrate_rdma().
Signed-off-by: Li Zhijian
---
V3:
reorder: 7th->4th
---
migration/rdma.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/migration/
Reverse the logical condition for HDM passthrough support in
pci_expander_bridge. This patch ensures the HDM passthrough condition
is evaluated only when hdm_for_passthrough is set to true, aligning
behavior with intended semantics and comments.
Signed-off-by: Li Zhijian
---
This change
Recently, we removed ipv6 restriction[0] from RDMA migration, add a
test for it.
[0]
https://lore.kernel.org/qemu-devel/20250326095224.9918-1-jinpu.w...@ionos.com/
Cc: Jack Wang
Cc: Michael R. Galaxy
Cc: Peter Xu
Cc: Yu Zhang
Reviewed-by: Jack Wang
Signed-off-by: Li Zhijian
---
V3
Recently, we removed ipv6 restriction[0] from RDMA migration, add a
test for it.
[0]
https://lore.kernel.org/qemu-devel/20250326095224.9918-1-jinpu.w...@ionos.com/
Cc: Jack Wang
Cc: Michael R. Galaxy
Cc: Peter Xu
Cc: Yu Zhang
Reviewed-by: Jack Wang
Signed-off-by: Li Zhijian
---
V2
an error state waiting migration to abort!
qemu-system-x86_64: failed to save SaveStateEntry with id(name): 2(ram): -1
qemu-system-x86_64: Channel error: Operation not permitted
Reported-by: Peter Xu
Signed-off-by: Li Zhijian
---
tests/qtest/migration/precopy-tests.c | 34
Recently, we removed ipv6 restriction[0] from RDMA migration, add a
test for it.
[0]
https://lore.kernel.org/qemu-devel/20250326095224.9918-1-jinpu.w...@ionos.com/
Cc: Jack Wang
Cc: Michael R. Galaxy
Cc: Peter Xu
Cc: Yu Zhang
Reviewed-by: Jack Wang
Signed-off-by: Li Zhijian
---
V4
ving the allocation after the check (as previously attempted),
use g_autoptr for automatic cleanup. This ensures the array is freed even
on early returns, and also removes the need for the explicit free at the
end of the function.
Signed-off-by: Li Zhijian
---
Cc: Daniel P. Berrangé
Cc: Ani Sinha
Ani
ving the GPtrArray allocation after the empty range check,
ensuring memory is only allocated when actually needed.
Signed-off-by: Li Zhijian
---
hw/acpi/aml-build.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c
index f8f93a9f66c8..cf19
ping
Any body could help to review/queue this patch ?
On 2021/6/29 22:05, Igor Mammedov wrote:
On Thu, 24 Jun 2021 19:04:15 +0800
Li Zhijian wrote:
Signed-off-by: Li Zhijian
Reviewed-by: Igor Mammedov
---
hw/acpi/nvdimm.c | 12 ++--
1 file changed, 6 insertions(+), 6
i have to apply below extra changes
From a8d027d3dfe70fb33363ad5934e163999fc29eec Mon Sep 17 00:00:00 2001
From: Li Zhijian
Date: Thu, 8 Jul 2021 17:52:40 +0800
Subject: [PATCH] fix libpmem configuration
Signed-off-by: Li Zhijian
---
configure | 2 +-
1 file changed, 1 insertion(+), 1
201 - 295 of 295 matches
Mail list logo
