Re: [Qemu-devel] [PATCH] qemu-char: (Re-)connect for tcp_chr_write() unconnected writing

2012-08-06 Thread Lei Li
Ping? On 07/20/2012 07:09 AM, Anthony Liguori wrote: Lei Li writes: tcp_chr_write() did not deal with writing to an unconnected connection and return the original length of the data, it's not right and would cause false writing. So (re-)connect it and return 0 for this situation. Signe

Re: [Qemu-devel] [RFC PATCH 1/4] qemu-char: Convert MemCharDriver to circular buffer

2012-08-06 Thread Lei Li
On 08/02/2012 05:30 AM, Anthony Liguori wrote: Lei Li writes: Signed-off-by: Lei Li --- qemu-char.c | 96 +++--- qemu-char.h |2 +- 2 files changed, 78 insertions(+), 20 deletions(-) diff --git a/qemu-char.c b/qemu-char.c index

[Qemu-devel] [PATCH 1/6] qemu-char: Convert MemCharDriver to circular buffer

2012-08-22 Thread Lei Li
Signed-off-by: Lei Li --- qemu-char.c | 96 +++--- qemu-char.h |2 +- 2 files changed, 78 insertions(+), 20 deletions(-) diff --git a/qemu-char.c b/qemu-char.c index 398baf1..b21b93a 100644 --- a/qemu-char.c +++ b/qemu-char.c @@ -2528,38

[Qemu-devel] [RFC v2 ATCH 0/4] char: expose MemoryCharDriver to users and provide QMP interface

2012-08-22 Thread Lei Li
the new rule for the name of qmp command from Eric. For the comments of MemCharDriver improvment, which I am working on and will send out within v3 with the rest feature implemented in few days. Lei Li (6): qemu-char: Convert MemCharDriver to circular buffer monitor: Adjust qmp_human_mo

[Qemu-devel] [PATCH 2/6] monitor: Adjust qmp_human_monitor_command to new MemCharDriver

2012-08-22 Thread Lei Li
Signed-off-by: Lei Li --- monitor.c |8 +++- 1 files changed, 7 insertions(+), 1 deletions(-) diff --git a/monitor.c b/monitor.c index 480f583..ab4650b 100644 --- a/monitor.c +++ b/monitor.c @@ -642,7 +642,13 @@ char *qmp_human_monitor_command(const char *command_line, bool

[Qemu-devel] [PATCH 5/6] Fix enumeration typo error

2012-08-22 Thread Lei Li
Signed-off-by: Lei Li --- qapi-schema-guest.json |2 +- qapi-schema.json |4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/qapi-schema-guest.json b/qapi-schema-guest.json index d955cf1..ed0eb69 100644 --- a/qapi-schema-guest.json +++ b/qapi-schema-guest.json

[Qemu-devel] [PATCH 4/6] QAPI: Introduce memchar_read QMP command

2012-08-22 Thread Lei Li
Signed-off-by: Lei Li --- hmp-commands.hx | 16 hmp.c| 15 +++ hmp.h|1 + qapi-schema.json | 23 +++ qemu-char.c | 32 qmp-commands.hx | 31

[Qemu-devel] [PATCH 6/6] Expose MemCharDriver via command line

2012-08-22 Thread Lei Li
Signed-off-by: Lei Li --- qemu-char.c | 24 qemu-config.c |3 +++ qemu-options.hx | 10 ++ 3 files changed, 37 insertions(+), 0 deletions(-) diff --git a/qemu-char.c b/qemu-char.c index ff6651b..36f4ecc 100644 --- a/qemu-char.c +++ b/qemu-char.c

[Qemu-devel] [PATCH 3/6] QAPI: Introduce memchar_write QMP command

2012-08-22 Thread Lei Li
Signed-off-by: Lei Li --- hmp-commands.hx | 16 hmp.c| 15 +++ hmp.h|1 + qapi-schema.json | 28 qemu-char.c | 36 qmp-commands.hx | 33

Re: [Qemu-devel] [PATCH 3/6] QAPI: Introduce memchar_write QMP command

2012-08-22 Thread Lei Li
On 08/23/2012 01:42 PM, Eric Blake wrote: On 08/22/2012 11:14 PM, Lei Li wrote: Signed-off-by: Lei Li Subject line uses '_', but the QMP command uses '-' [1] --- hmp-commands.hx | 16 hmp.c| 15 +++ hmp.h

Re: [Qemu-devel] [PATCH 4/6] QAPI: Introduce memchar_read QMP command

2012-08-23 Thread Lei Li
On 08/23/2012 01:46 PM, Eric Blake wrote: On 08/22/2012 11:14 PM, Lei Li wrote: Signed-off-by: Lei Li Again, subject line should use '-' not '_' for QMP. --- hmp-commands.hx | 16 hmp.c| 15 +++ hmp.h|1

Re: [Qemu-devel] [PATCH v2] chardev: add hotplug support.

2012-10-14 Thread Lei Li
On 10/12/2012 08:39 PM, Gerd Hoffmann wrote: This patch adds chardev_add and chardev_del monitor commands. chardev_del is pretty straight forward, it just takes an id argument and zaps the chardev specified. chardev_add is more tricky as there are tons of arguments for the different backends.

Re: [Qemu-devel] [PATCH v3 9/9] chardev: add hotplug support.

2012-10-16 Thread Lei Li
On 10/15/2012 04:06 PM, Gerd Hoffmann wrote: This patch adds chardev_add and chardev_del monitor commands. They work simliar to the netdev_{add,del} commands. The hmp version of chardev_add accepts like the -chardev command line option does. The qmp version expects the arguments being passed a

[Qemu-devel] [PATCH 1/5] qemu-char: Add new char backend CircularMemCharDriver

2012-10-21 Thread Lei Li
Signed-off-by: Lei Li --- qemu-char.c | 72 +++ 1 files changed, 72 insertions(+), 0 deletions(-) diff --git a/qemu-char.c b/qemu-char.c index b082bae..b174da1 100644 --- a/qemu-char.c +++ b/qemu-char.c @@ -2588,6 +2588,78 @@ size_t

[Qemu-devel] [PATCH 2/5] Expose CirMemCharDriver via command line

2012-10-21 Thread Lei Li
Signed-off-by: Lei Li --- qemu-char.c | 36 qemu-config.c |3 +++ qemu-options.hx | 10 ++ 3 files changed, 49 insertions(+), 0 deletions(-) diff --git a/qemu-char.c b/qemu-char.c index b174da1..381bf60 100644 --- a/qemu-char.c +++ b

[Qemu-devel] [PATCH 0/5 V4] char: add CirMemCharDriver and provide QMP interface

2012-10-21 Thread Lei Li
ommand so that can interact with multiple chardevs via a single monitor socket. - Make the circular buffer backend and the current MemCharDriver live in parallel, expose a new char backend with circular buffer CirMemCharDriver suggested by Luiz. - Other fixs from Eric and Markus. Chan

[Qemu-devel] [PATCH 4/5] QAPI: Introduce memchar-read QMP command

2012-10-21 Thread Lei Li
Signed-off-by: Lei Li --- hmp-commands.hx | 25 + hmp.c| 17 + hmp.h|1 + qapi-schema.json | 27 +++ qemu-char.c | 52 qmp-commands.hx

[Qemu-devel] [PATCH 3/5] QAPI: Introduce memchar-write QMP command

2012-10-21 Thread Lei Li
Signed-off-by: Lei Li --- hmp-commands.hx | 22 + hmp.c| 19 +++ hmp.h|1 + qapi-schema.json | 69 ++ qemu-char.c | 46 qmp-commands.hx

[Qemu-devel] [PATCH 5/5] HMP: Introduce console command

2012-10-21 Thread Lei Li
Signed-off-by: Lei Li --- hmp-commands.hx | 23 +++ hmp.c | 53 + hmp.h |1 + monitor.c | 15 +++ monitor.h |3 +++ 5 files changed, 95 insertions(+), 0 deletions

Re: [Qemu-devel] [PATCH 1/5] qemu-char: Add new char backend CircularMemCharDriver

2012-10-22 Thread Lei Li
On 10/22/2012 10:08 PM, Eric Blake wrote: On 10/21/2012 10:47 AM, Lei Li wrote: Signed-off-by: Lei Li --- qemu-char.c | 72 +++ 1 files changed, 72 insertions(+), 0 deletions(-) diff --git a/qemu-char.c b/qemu-char.c index b082bae

Re: [Qemu-devel] [PATCH 3/5] QAPI: Introduce memchar-write QMP command

2012-10-22 Thread Lei Li
On 10/23/2012 02:37 AM, Luiz Capitulino wrote: On Mon, 22 Oct 2012 00:47:59 +0800 Lei Li wrote: Signed-off-by: Lei Li --- hmp-commands.hx | 22 + hmp.c| 19 +++ hmp.h|1 + qapi-schema.json | 69

Re: [Qemu-devel] [PATCH 1/5] qemu-char: Add new char backend CircularMemCharDriver

2012-10-22 Thread Lei Li
On 10/23/2012 02:14 AM, Luiz Capitulino wrote: On Mon, 22 Oct 2012 00:47:57 +0800 Lei Li wrote: Signed-off-by: Lei Li This patch should be squashed in the next one. More comments below. --- qemu-char.c | 72 +++ 1 files changed

Re: [Qemu-devel] [PATCH 5/5] HMP: Introduce console command

2012-10-24 Thread Lei Li
On 10/23/2012 02:59 AM, Luiz Capitulino wrote: On Mon, 22 Oct 2012 00:48:01 +0800 Lei Li wrote: Signed-off-by: Lei Li --- hmp-commands.hx | 23 +++ hmp.c | 53 + hmp.h |1 + monitor.c

Re: [Qemu-devel] [PATCH 5/5] HMP: Introduce console command

2012-10-25 Thread Lei Li
On 10/24/2012 08:55 PM, Luiz Capitulino wrote: On Wed, 24 Oct 2012 15:17:21 +0800 Lei Li wrote: On 10/23/2012 02:59 AM, Luiz Capitulino wrote: On Mon, 22 Oct 2012 00:48:01 +0800 Lei Li wrote: Signed-off-by: Lei Li --- hmp-commands.hx | 23 +++ hmp.c

[Qemu-devel] [PATCH 1/4] qemu-char: Add new char backend CirMemCharDriver

2012-10-25 Thread Lei Li
Signed-off-by: Lei Li --- qemu-char.c | 136 +++ qemu-config.c |3 + qemu-options.hx | 10 3 files changed, 149 insertions(+), 0 deletions(-) diff --git a/qemu-char.c b/qemu-char.c index b082bae..45d2a86 100644 --- a/qemu

[Qemu-devel] [PATCH 2/4] QAPI: Introduce memchar-write QMP command

2012-10-25 Thread Lei Li
Signed-off-by: Lei Li --- hmp-commands.hx | 17 + hmp.c| 15 +++ hmp.h|1 + qapi-schema.json | 47 +++ qemu-char.c | 44 qmp-commands.hx

[Qemu-devel] [PATCH 3/4] QAPI: Introduce memchar-read QMP command

2012-10-25 Thread Lei Li
Signed-off-by: Lei Li --- hmp-commands.hx | 19 ++ hmp.c| 19 ++ hmp.h|1 + qapi-schema.json | 27 ++ qemu-char.c | 55 ++ qmp-commands.hx | 40

[Qemu-devel] [PATCH 1/4] qemu-char: Add new char backend CirMemCharDriver

2012-10-25 Thread Lei Li
Signed-off-by: Lei Li --- qemu-char.c | 136 +++ qemu-config.c |3 + qemu-options.hx | 10 3 files changed, 149 insertions(+), 0 deletions(-) diff --git a/qemu-char.c b/qemu-char.c index b082bae..45d2a86 100644 --- a/qemu

[Qemu-devel] [PATCH 0/4 V5] char: Add CirMemCharDriver and provide QMP interface

2012-10-25 Thread Lei Li
ar buffer backend and the current MemCharDriver live in parallel, expose a new char backend with circular buffer CirMemCharDriver suggested by Luiz. - Other fixs from Eric and Markus. Changes since v1: - Exposing the MemCharDriver via command line. - Support base64 data format suggested

[Qemu-devel] [PATCH 2/4] QAPI: Introduce memchar-write QMP command

2012-10-25 Thread Lei Li
Signed-off-by: Lei Li --- hmp-commands.hx | 17 + hmp.c| 15 +++ hmp.h|1 + qapi-schema.json | 47 +++ qemu-char.c | 44 qmp-commands.hx

[Qemu-devel] [PATCH 4/4] HMP: Introduce console command

2012-10-25 Thread Lei Li
Signed-off-by: Lei Li --- hmp-commands.hx | 25 + hmp.c | 52 hmp.h |1 + monitor.c | 15 +++ monitor.h |3 +++ 5 files changed, 96 insertions(+), 0 deletions

[Qemu-devel] [PATCH 3/4] QAPI: Introduce memchar-read QMP command

2012-10-25 Thread Lei Li
Signed-off-by: Lei Li --- hmp-commands.hx | 19 ++ hmp.c| 19 ++ hmp.h|1 + qapi-schema.json | 27 ++ qemu-char.c | 55 ++ qmp-commands.hx | 40

[Qemu-devel] [PATCH 4/4] HMP: Introduce console command

2012-10-25 Thread Lei Li
Signed-off-by: Lei Li --- hmp-commands.hx | 25 + hmp.c | 52 hmp.h |1 + monitor.c | 15 +++ monitor.h |3 +++ 5 files changed, 96 insertions(+), 0 deletions

[Qemu-devel] [PATCH 0/4 V5] char: Add CirMemCharDriver and provide QMP interface

2012-10-25 Thread Lei Li
ar buffer backend and the current MemCharDriver live in parallel, expose a new char backend with circular buffer CirMemCharDriver suggested by Luiz. - Other fixs from Eric and Markus. Changes since v1: - Exposing the MemCharDriver via command line. - Support base64 data format suggested

Re: [Qemu-devel] [PATCH 1/4] qemu-char: Add new char backend CirMemCharDriver

2012-10-25 Thread Lei Li
On 10/26/2012 04:05 AM, Eric Blake wrote: On 10/25/2012 01:54 PM, Lei Li wrote: Signed-off-by: Lei Li --- qemu-char.c | 136 +++ qemu-config.c |3 + qemu-options.hx | 10 3 files changed, 149 insertions(+), 0 deletions

Re: [Qemu-devel] [PATCH 0/4 V5] char: Add CirMemCharDriver and provide QMP interface

2012-10-25 Thread Lei Li
Please ignore this thread and review the other thread also titled V5. Sorry for the mis-sending mostly caused by the unconsciousness at midnight... On 10/26/2012 03:48 AM, Lei Li wrote: This patch series attempts to add new char backend CirMemCharDriver with a circular buffer and expose it to

[Qemu-devel] [PATCH 0/4 V6] char: Add CirMemCharDriver and provide QMP interface

2012-10-26 Thread Lei Li
cement. - Add HMP 'console' command so that can interact with multiple chardevs via a single monitor socket. - Make the circular buffer backend and the current MemCharDriver live in parallel, expose a new char backend with circular buffer CirMemCharDriver suggested by Luiz. - Other

[Qemu-devel] [PATCH 1/4] qemu-char: Add new char backend CirMemCharDriver

2012-10-26 Thread Lei Li
Signed-off-by: Lei Li --- qemu-char.c | 140 +++ qemu-config.c |3 + qemu-options.hx | 10 3 files changed, 153 insertions(+), 0 deletions(-) diff --git a/qemu-char.c b/qemu-char.c index b082bae..c3ec43d 100644 --- a/qemu

[Qemu-devel] [PATCH 4/4] HMP: Introduce console command

2012-10-26 Thread Lei Li
Signed-off-by: Lei Li --- hmp-commands.hx | 25 + hmp.c | 52 hmp.h |1 + monitor.c | 15 +++ monitor.h |3 +++ 5 files changed, 96 insertions(+), 0 deletions

[Qemu-devel] [PATCH 2/4] QAPI: Introduce memchar-write QMP command

2012-10-26 Thread Lei Li
Signed-off-by: Lei Li --- hmp-commands.hx | 17 + hmp.c| 15 +++ hmp.h|1 + qapi-schema.json | 47 +++ qemu-char.c | 44 qmp-commands.hx

[Qemu-devel] [PATCH 3/4] QAPI: Introduce memchar-read QMP command

2012-10-26 Thread Lei Li
Signed-off-by: Lei Li --- hmp-commands.hx | 19 ++ hmp.c| 19 ++ hmp.h|1 + qapi-schema.json | 27 ++ qemu-char.c | 55 ++ qmp-commands.hx | 40

Re: [Qemu-devel] [PATCH 3/4] QAPI: Introduce memchar-read QMP command

2012-10-28 Thread Lei Li
On 10/27/2012 01:39 AM, Luiz Capitulino wrote: On Fri, 26 Oct 2012 19:21:51 +0800 Lei Li wrote: Signed-off-by: Lei Li --- hmp-commands.hx | 19 ++ hmp.c| 19 ++ hmp.h|1 + qapi-schema.json | 27

Re: [Qemu-devel] [PATCH 2/4] QAPI: Introduce memchar-write QMP command

2012-10-28 Thread Lei Li
On 10/27/2012 01:17 AM, Luiz Capitulino wrote: On Fri, 26 Oct 2012 19:21:50 +0800 Lei Li wrote: Signed-off-by: Lei Li --- hmp-commands.hx | 17 + hmp.c| 15 +++ hmp.h|1 + qapi-schema.json | 47

Re: [Qemu-devel] [PATCH 4/4] HMP: Introduce console command

2012-10-28 Thread Lei Li
On 10/27/2012 01:43 AM, Luiz Capitulino wrote: On Fri, 26 Oct 2012 19:21:52 +0800 Lei Li wrote: Signed-off-by: Lei Li I still don't understand how this command, in its current form, is different from memchar-write. One more comment below. Hi Luiz, Yes, I have replied to it in

Re: [Qemu-devel] [PATCH 1/4] qemu-char: Add new char backend CirMemCharDriver

2012-10-28 Thread Lei Li
On 10/27/2012 12:47 AM, Luiz Capitulino wrote: On Fri, 26 Oct 2012 19:21:49 +0800 Lei Li wrote: Signed-off-by: Lei Li --- qemu-char.c | 140 +++ qemu-config.c |3 + qemu-options.hx | 10 3 files changed, 153

[Qemu-devel] [PATCH 1/4] qemu-char: Add new char backend CirMemCharDriver

2012-10-30 Thread Lei Li
Signed-off-by: Lei Li --- qemu-char.c | 131 +++ qemu-config.c |3 + qemu-options.hx | 10 3 files changed, 144 insertions(+), 0 deletions(-) diff --git a/qemu-char.c b/qemu-char.c index afe2bfb..11c320f 100644 --- a/qemu

[Qemu-devel] [PATCH 4/4] HMP: Introduce console command

2012-10-30 Thread Lei Li
Signed-off-by: Lei Li --- hmp-commands.hx | 21 + hmp.c | 51 +++ hmp.h |1 + monitor.c | 15 +++ monitor.h |3 +++ 5 files changed, 91 insertions(+), 0 deletions

Re: [Qemu-devel] [PATCH 2/4] QAPI: Introduce memchar-write QMP command

2012-10-30 Thread Lei Li
On 10/29/2012 09:23 PM, Luiz Capitulino wrote: On Mon, 29 Oct 2012 12:10:24 +0800 Lei Li wrote: On 10/27/2012 01:17 AM, Luiz Capitulino wrote: On Fri, 26 Oct 2012 19:21:50 +0800 Lei Li wrote: Signed-off-by: Lei Li --- hmp-commands.hx | 17 + hmp.c

Re: [Qemu-devel] [PATCH 4/4] HMP: Introduce console command

2012-10-30 Thread Lei Li
On 10/29/2012 09:26 PM, Luiz Capitulino wrote: On Mon, 29 Oct 2012 12:18:03 +0800 Lei Li wrote: On 10/27/2012 01:43 AM, Luiz Capitulino wrote: On Fri, 26 Oct 2012 19:21:52 +0800 Lei Li wrote: Signed-off-by: Lei Li I still don't understand how this command, in its current for

Re: [Qemu-devel] [PATCH 3/4] QAPI: Introduce memchar-read QMP command

2012-10-30 Thread Lei Li
On 10/29/2012 09:17 PM, Luiz Capitulino wrote: On Mon, 29 Oct 2012 12:09:38 +0800 Lei Li wrote: On 10/27/2012 01:39 AM, Luiz Capitulino wrote: On Fri, 26 Oct 2012 19:21:51 +0800 Lei Li wrote: Signed-off-by: Lei Li --- hmp-commands.hx | 19 ++ hmp.c

[Qemu-devel] [PATCH 0/4 V7] char: Add CirMemCharDriver and provide QMP interface

2012-10-30 Thread Lei Li
y infrastructure enhancement. - Add HMP 'console' command so that can interact with multiple chardevs via a single monitor socket. - Make the circular buffer backend and the current MemCharDriver live in parallel, expose a new char backend with circular buffer CirMemCha

[Qemu-devel] [PATCH 2/4] QAPI: Introduce memchar-write QMP command

2012-10-30 Thread Lei Li
Signed-off-by: Lei Li --- hmp-commands.hx | 15 +++ hmp.c| 13 + hmp.h|1 + qapi-schema.json | 41 + qemu-char.c | 48 qmp-commands.hx

[Qemu-devel] [PATCH 3/4] QAPI: Introduce memchar-read QMP command

2012-10-30 Thread Lei Li
Signed-off-by: Lei Li --- hmp-commands.hx | 19 ++ hmp.c| 17 hmp.h|1 + qapi-schema.json | 27 - qemu-char.c | 57 ++ qmp-commands.hx | 34

[Qemu-devel] [Bug 1086745] Re: serial port data THRE comes too early

2012-12-05 Thread Lei Li
Could you please give more details, like the steps to reproduce this problems. Thanks. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1086745 Title: serial port data THRE comes too early Status in

[Qemu-devel] [PATCH 1/4] qemu-char: Add new char backend CirMemCharDriver

2012-12-06 Thread Lei Li
Signed-off-by: Lei Li --- qemu-char.c | 131 +++ qemu-config.c |3 + qemu-options.hx | 10 3 files changed, 144 insertions(+), 0 deletions(-) diff --git a/qemu-char.c b/qemu-char.c index 242b799..3e45ce6 100644 --- a/qemu

[Qemu-devel] [PATCH 0/4 V8] char: Add CirMemCharDriver and provide QMP interface

2012-12-06 Thread Lei Li
urrent MemCharDriver live in parallel, expose a new char backend with circular buffer CirMemCharDriver suggested by Luiz. - Other fixs from Eric and Markus. Changes since v1: - Exposing the MemCharDriver via command line. - Support base64 data format suggested by Anthony and Eric. - Foll

[Qemu-devel] [PATCH 3/4] QAPI: Introduce memchar-read QMP command

2012-12-06 Thread Lei Li
Signed-off-by: Lei Li --- hmp-commands.hx | 19 ++ hmp.c| 17 hmp.h|1 + qapi-schema.json | 25 +++ qemu-char.c | 57 ++ qmp-commands.hx | 34

[Qemu-devel] [PATCH 2/4] QAPI: Introduce memchar-write QMP command

2012-12-06 Thread Lei Li
Signed-off-by: Lei Li --- hmp-commands.hx | 15 +++ hmp.c| 13 + hmp.h|1 + qapi-schema.json | 41 + qemu-char.c | 48 qmp-commands.hx

[Qemu-devel] [PATCH 4/4] HMP: Introduce console command

2012-12-06 Thread Lei Li
Signed-off-by: Lei Li --- hmp-commands.hx | 21 + hmp.c | 52 hmp.h |1 + monitor.c | 15 +++ monitor.h |3 +++ 5 files changed, 92 insertions(+), 0 deletions

[Qemu-devel] [PATCH] qemu-char: inheriting ptys and imporve output from -serial pty

2012-12-14 Thread Lei Li
redirected to /dev/pts/7 Referred link: https://bugs.launchpad.net/qemu/+bug/938552 Reported-by: Craig Ringer Signed-off-by: Lei Li --- qemu-char.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/qemu-char.c b/qemu-char.c index 242b799..2b0f5f4 100644 --- a/qemu-c

[Qemu-devel] [PATCH] qemu-char: inherit ptys and imporve output from -serial pty

2012-12-20 Thread Lei Li
redirected to /dev/pts/7 Referred link: https://bugs.launchpad.net/qemu/+bug/938552 Reported-by: Craig Ringer Signed-off-by: Lei Li --- qemu-char.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/qemu-char.c b/qemu-char.c index 242b799..2b0f5f4 100644 --- a/qemu-c

Re: [Qemu-devel] [PATCH] qemu-char: inherit ptys and imporve output from -serial pty

2012-12-20 Thread Lei Li
Sorry, s/imporve/improve... On 12/20/2012 10:49 PM, Lei Li wrote: When controlling a qemu instance from another program, it's hard to know which serial port or monitor device is redirected to which pty. With more than one device using "pty" a lot of guesswork is involved. $ .

[Qemu-devel] [PATCH V2] qemu-char: Inherit ptys and improve output from -serial pty

2012-12-20 Thread Lei Li
pty -monitor pty char device compat_monitor0 redirected to /dev/pts/5 char device serial0 redirected to /dev/pts/6 char device serial1 redirected to /dev/pts/7 Referred link: https://bugs.launchpad.net/qemu/+bug/938552 Signed-off-by: Lei Li --- qemu-char.c |8 +++- 1 files changed, 7 ins

[Qemu-devel] [RFC] Time resync by qemu-ga

2012-12-27 Thread Lei Li
Hi guys, I am working on the time drift issue as background info here. http://mid.gmane.org/87pq5r5otp@codemonkey.ws As Anthony proposed, one part of the solutions is that we want to add a qemu-ga command to resync the guest clock by reading the wallclock time when the tick overflow the lim

Re: [Qemu-devel] [RESEND PATCH for 1.4 v10 0/3] char: Add CirMemCharDriver and provide QMP interface

2013-01-23 Thread Lei Li
On 01/23/2013 11:47 PM, Luiz Capitulino wrote: On Wed, 23 Jan 2013 17:06:09 +0800 Lei Li wrote: Hi Anthony, Resubmit this series with your comments squashed in and Luiz's new comments fixed up. I will push console command part in another thread. There are two bugs in this series.

Re: [Qemu-devel] [PATCH 1/3] qemu-char: Add new char backend CirMemCharDriver

2013-01-23 Thread Lei Li
On 01/23/2013 11:31 PM, Luiz Capitulino wrote: On Wed, 23 Jan 2013 11:15:40 +0800 Lei Li wrote: +static int cirmem_chr_write(CharDriverState *chr, const uint8_t *buf, int len) +{ +CirMemCharDriver *d = chr->opaque; +int i; + +if (!buf || (len < 0)) { +return -1; +

Re: [Qemu-devel] [PATCH 3/3] QAPI: Introduce memchar-read QMP command

2013-01-24 Thread Lei Li
On 01/23/2013 11:42 PM, Luiz Capitulino wrote: On Wed, 23 Jan 2013 17:06:12 +0800 Lei Li wrote: Signed-off-by: Lei Li --- hmp-commands.hx | 21 + hmp.c| 17 + hmp.h|1 + qapi-schema.json | 36

Re: [Qemu-devel] [RESEND PATCH for 1.4 v10 0/3] char: Add CirMemCharDriver and provide QMP interface

2013-01-24 Thread Lei Li
On 01/24/2013 08:48 PM, Luiz Capitulino wrote: On Thu, 24 Jan 2013 15:18:04 +0800 Lei Li wrote: On 01/23/2013 11:47 PM, Luiz Capitulino wrote: On Wed, 23 Jan 2013 17:06:09 +0800 Lei Li wrote: Hi Anthony, Resubmit this series with your comments squashed in and Luiz's new comments fix

[Qemu-devel] [PATCH 1/3] qemu-char: Add new char backend CirMemCharDriver

2013-01-24 Thread Lei Li
Signed-off-by: Lei Li --- qemu-char.c | 114 +++ qemu-options.hx | 10 + 2 files changed, 124 insertions(+), 0 deletions(-) diff --git a/qemu-char.c b/qemu-char.c index 9ba0573..8045869 100644 --- a/qemu-char.c +++ b/qemu-char.c

[Qemu-devel] [RESEND PATCH for 1.4 v11 0/3] char: Add CirMemCharDriver and provide QMP interface

2013-01-24 Thread Lei Li
Add HMP 'console' command so that can interact with multiple chardevs via a single monitor socket. - Make the circular buffer backend and the current MemCharDriver live in parallel, expose a new char backend with circular buffer CirMemCharDriver suggested by Luiz. - Oth

[Qemu-devel] [PATCH 3/3] QAPI: Introduce memchar-read QMP command

2013-01-24 Thread Lei Li
Signed-off-by: Lei Li --- hmp-commands.hx | 21 + hmp.c| 21 + hmp.h|1 + qapi-schema.json | 36 qemu-char.c | 48 qmp

[Qemu-devel] [PATCH 2/3] QAPI: Introduce memchar-write QMP command

2013-01-24 Thread Lei Li
Signed-off-by: Lei Li --- hmp-commands.hx | 18 ++ hmp.c| 13 + hmp.h|1 + qapi-schema.json | 38 ++ qemu-char.c | 42 ++ qmp-commands.hx | 33

[Qemu-devel] [PATCH 0/2 v2] Time resync support by qemu-ga

2013-01-27 Thread Lei Li
e and add guest-get-time command into one. - Documents improvment based on the suggestions from Eric and Mike. - Change the name of 'HostTimeInfo' to 'TimeInfo'. - Better use-case and logic for 'guest-set-time' command suggested by Eric. - Error han

[Qemu-devel] [PATCH 1/2] qga: add guest-get-time command

2013-01-27 Thread Lei Li
Signed-off-by: Lei Li --- include/qapi/qmp/qerror.h |3 +++ qga/commands-posix.c | 30 ++ qga/qapi-schema.json | 38 ++ 3 files changed, 71 insertions(+), 0 deletions(-) diff --git a/include/qapi/qmp/qerror.h b

[Qemu-devel] [PATCH 0/2 v2] Time resync support by qemu-ga

2013-01-27 Thread Lei Li
e and add guest-get-time command into one. - Documents improvment based on the suggestions from Eric and Mike. - Change the name of 'HostTimeInfo' to 'TimeInfo'. - Better use-case and logic for 'guest-set-time' command suggested by Eric. - Error han

[Qemu-devel] [PATCH 1/2] qga: add guest-get-time command

2013-01-27 Thread Lei Li
Signed-off-by: Lei Li --- include/qapi/qmp/qerror.h |3 +++ qga/commands-posix.c | 30 ++ qga/qapi-schema.json | 38 ++ 3 files changed, 71 insertions(+), 0 deletions(-) diff --git a/include/qapi/qmp/qerror.h b

[Qemu-devel] [PATCH 2/2] qga: add guest-set-time command

2013-01-27 Thread Lei Li
Signed-off-by: Lei Li --- qga/commands-posix.c | 76 ++ qga/qapi-schema.json | 42 +++ 2 files changed, 118 insertions(+), 0 deletions(-) diff --git a/qga/commands-posix.c b/qga/commands-posix.c index 2fef2b6..5424c50

[Qemu-devel] [PATCH] qga: cast to int for DWORD type

2013-01-27 Thread Lei Li
This patch fixes a compiler warning when cross-build: qga/service-win32.c: In function 'printf_win_error': qga/service-win32.c:32:5: warning: format '%d' expects argument of type 'int', but argument 3 has type 'DWORD' [-Wformat]

Re: [Qemu-devel] [PATCH 1/2] qga: add guest-get-time command

2013-01-29 Thread Lei Li
On 01/29/2013 02:29 AM, Eric Blake wrote: On 01/27/2013 11:14 AM, Lei Li wrote: Signed-off-by: Lei Li --- include/qapi/qmp/qerror.h |3 +++ qga/commands-posix.c | 30 ++ qga/qapi-schema.json | 38 ++ 3 files

Re: [Qemu-devel] [PATCH 1/2] qga: add guest-get-time command

2013-01-29 Thread Lei Li
On 01/29/2013 04:24 AM, Anthony Liguori wrote: Eric Blake writes: On 01/27/2013 11:14 AM, Lei Li wrote: Signed-off-by: Lei Li --- include/qapi/qmp/qerror.h |3 +++ qga/commands-posix.c | 30 ++ qga/qapi-schema.json | 38

Re: [Qemu-devel] [PATCH 2/2] qga: add guest-set-time command

2013-01-29 Thread Lei Li
On 01/29/2013 04:45 AM, Eric Blake wrote: On 01/27/2013 11:14 AM, Lei Li wrote: Signed-off-by: Lei Li --- qga/commands-posix.c | 76 ++ qga/qapi-schema.json | 42 +++ 2 files changed, 118 insertions(+), 0 deletions

Re: [Qemu-devel] [PATCH 1/2] qga: add guest-get-time command

2013-01-30 Thread Lei Li
Sorry, missing replied... It should be the reply to Eric here. On 01/30/2013 03:37 PM, Lei Li wrote: On 01/29/2013 04:24 AM, Anthony Liguori wrote: Eric Blake writes: On 01/27/2013 11:14 AM, Lei Li wrote: Signed-off-by: Lei Li --- include/qapi/qmp/qerror.h |3 +++ qga/commands

Re: [Qemu-devel] [PATCH 3/5] QAPI: Introduce memchar-write QMP command

2012-09-20 Thread Lei Li
On 09/20/2012 02:05 AM, Luiz Capitulino wrote: On Wed, 12 Sep 2012 19:57:24 +0800 Lei Li wrote: Signed-off-by: Lei Li --- hmp-commands.hx | 23 ++ hmp.c| 19 +++ hmp.h|1 + qapi-schema.json | 69

Re: [Qemu-devel] [PATCH 2/6] monitor: Adjust qmp_human_monitor_command to new MemCharDriver

2012-09-03 Thread Lei Li
On 08/31/2012 02:51 AM, Luiz Capitulino wrote: On Thu, 23 Aug 2012 13:14:22 +0800 Lei Li wrote: Signed-off-by: Lei Li --- monitor.c |8 +++- 1 files changed, 7 insertions(+), 1 deletions(-) diff --git a/monitor.c b/monitor.c index 480f583..ab4650b 100644 --- a/monitor.c +++ b

[Qemu-devel] [PATCH 1/5] qemu-char: Add new char device CirMemCharDriver

2012-09-12 Thread Lei Li
Signed-off-by: Lei Li --- qemu-char.c | 84 +++ 1 files changed, 84 insertions(+), 0 deletions(-) diff --git a/qemu-char.c b/qemu-char.c index 767da93..0470085 100644 --- a/qemu-char.c +++ b/qemu-char.c @@ -2591,6 +2591,90 @@ size_t

[Qemu-devel] [RFC v3 ATCH 0/5] char: expose CirMemCharDriver and provide QMP interface

2012-09-12 Thread Lei Li
live in parallel, expose a new char backend with circular buffer CirMemCharDriver suggested by Luiz. - Other fixs from Eric and Markus. Changes since v1: - Exposing the MemCharDriver via command line. - Support base64 data format suggested by Anthony and Eric. - F

[Qemu-devel] [PATCH 4/5] QAPI: Introduce memchar-read QMP command

2012-09-12 Thread Lei Li
Signed-off-by: Lei Li --- hmp-commands.hx | 25 + hmp.c| 18 ++ hmp.h|1 + qapi-schema.json | 27 +++ qemu-char.c | 48 qmp-commands.hx

[Qemu-devel] [PATCH 2/5] Expose CirMemCharDriver via command line

2012-09-12 Thread Lei Li
Signed-off-by: Lei Li --- qemu-char.c | 31 +++ qemu-config.c |3 +++ qemu-options.hx | 10 ++ 3 files changed, 44 insertions(+), 0 deletions(-) diff --git a/qemu-char.c b/qemu-char.c index 0470085..6e84acc 100644 --- a/qemu-char.c +++ b/qemu

[Qemu-devel] [PATCH 5/5] HMP: Introduce console command

2012-09-12 Thread Lei Li
Signed-off-by: Lei Li --- hmp.c | 42 ++ monitor.c | 18 ++ monitor.h |2 ++ 3 files changed, 62 insertions(+), 0 deletions(-) diff --git a/hmp.c b/hmp.c index 4397981..a016a5c 100644 --- a/hmp.c +++ b/hmp.c @@ -1205,3 +1205,45

[Qemu-devel] [PATCH 3/5] QAPI: Introduce memchar-write QMP command

2012-09-12 Thread Lei Li
Signed-off-by: Lei Li --- hmp-commands.hx | 23 ++ hmp.c| 19 +++ hmp.h|1 + qapi-schema.json | 69 ++ qemu-char.c | 48 + qmp-commands.hx

[Qemu-devel] [PATCH 0/2 v3] Time resync support by qemu-ga

2013-03-01 Thread Lei Li
guest-get-time command into one. - Documents improvment based on the suggestions from Eric and Mike. - Change the name of 'HostTimeInfo' to 'TimeInfo'. - Better use-case and logic for 'guest-set-time' command suggested by Eric. - Error handel improvment from Luiz. Lei Li (2): qga: add guest-get-time command qga: add guest-set-time command

[Qemu-devel] [PATCH 1/2] qga: add guest-get-time command

2013-03-01 Thread Lei Li
Signed-off-by: Lei Li --- qga/commands-posix.c | 16 qga/qapi-schema.json | 16 2 files changed, 32 insertions(+) diff --git a/qga/commands-posix.c b/qga/commands-posix.c index 0ad73f3..f159e25 100644 --- a/qga/commands-posix.c +++ b/qga/commands-posix.c

[Qemu-devel] [PATCH 2/2] qga: add guest-set-time command

2013-03-01 Thread Lei Li
Signed-off-by: Lei Li --- qga/commands-posix.c | 55 qga/qapi-schema.json | 27 ++ 2 files changed, 82 insertions(+) diff --git a/qga/commands-posix.c b/qga/commands-posix.c index f159e25..e246a0d 100644 --- a/qga

Re: [Qemu-devel] [PATCH 1/2] qga: add guest-get-time command

2013-03-03 Thread Lei Li
On 03/02/2013 01:02 AM, Eric Blake wrote: On 03/01/2013 02:32 AM, Lei Li wrote: Signed-off-by: Lei Li --- qga/commands-posix.c | 16 qga/qapi-schema.json | 16 2 files changed, 32 insertions(+) diff --git a/qga/commands-posix.c b/qga/commands-posix.c

Re: [Qemu-devel] [PATCH 2/2] qga: add guest-set-time command

2013-03-04 Thread Lei Li
On 03/02/2013 01:38 AM, Eric Blake wrote: On 03/01/2013 02:33 AM, Lei Li wrote: Signed-off-by: Lei Li --- qga/commands-posix.c | 55 qga/qapi-schema.json | 27 ++ 2 files changed, 82 insertions(+) diff --git a

[Qemu-devel] [PATCH 0/2 v4] Time resync support by qemu-ga

2013-03-04 Thread Lei Li
r use-case and logic for 'guest-set-time' command suggested by Eric. - Error handel improvment from Luiz. Lei Li (2): qga: add guest-get-time command qga: add guest-set-time command

[Qemu-devel] [PATCH 1/2] qga: add guest-get-time command

2013-03-04 Thread Lei Li
Signed-off-by: Lei Li --- qga/commands-posix.c | 16 qga/qapi-schema.json | 13 + 2 files changed, 29 insertions(+) diff --git a/qga/commands-posix.c b/qga/commands-posix.c index 0ad73f3..6fc6003 100644 --- a/qga/commands-posix.c +++ b/qga/commands-posix.c @@ -119,6

[Qemu-devel] [PATCH 2/2] qga: add guest-set-time command

2013-03-04 Thread Lei Li
Signed-off-by: Lei Li --- qga/commands-posix.c | 54 qga/qapi-schema.json | 27 ++ 2 files changed, 81 insertions(+) diff --git a/qga/commands-posix.c b/qga/commands-posix.c index 6fc6003..0515f5f 100644 --- a/qga

[Qemu-devel] [PATCH 1/2] qga: add guest-get-time command

2013-03-05 Thread Lei Li
Signed-off-by: Lei Li --- qga/commands-posix.c | 16 qga/qapi-schema.json | 13 + 2 files changed, 29 insertions(+) diff --git a/qga/commands-posix.c b/qga/commands-posix.c index 7a0202e..1426262 100644 --- a/qga/commands-posix.c +++ b/qga/commands-posix.c @@ -119,6

[Qemu-devel] [PATCH 0/2 v5] Time resync support by qemu-ga

2013-03-05 Thread Lei Li
Eric and Mike. - Change the name of 'HostTimeInfo' to 'TimeInfo'. - Better use-case and logic for 'guest-set-time' command suggested by Eric. - Error handel improvment from Luiz. Lei Li (2): qga: add guest-get-time command qga: add guest-set-time command

  1   2   3   4   5   >