Am 30.08.2012 20:47, schrieb Jeff Cody:
> I believe the bs->keep_read_only flag is supposed to reflect
> the initial open state of the device. If the device is initially
> opened R/O, then commit operations, or reopen operations changing
> to R/W, are prohibited.
>
> Currently, the keep_read_only
Am 05.09.2012 14:56, schrieb Henning Schild:
> Find a hopefully proper patch attached. Take it or leave it.
>
> Signed-off-by: Henning Schild
Reviewed-by: Kevin Wolf
Aurelien, I think in the past you committed some changes in this area.
Does this look good to you and can y
Am 05.09.2012 15:08, schrieb Jeff Cody:
> On 09/05/2012 08:47 AM, Kevin Wolf wrote:
>> Am 30.08.2012 20:47, schrieb Jeff Cody:
>>> I believe the bs->keep_read_only flag is supposed to reflect
>>> the initial open state of the device. If the device is initial
This should be fixed as of commit 65bd155c (included in 1.2.0-rc1).
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1028908
Title:
qemu-img fails to convert VMDK image
Status in QEMU:
New
Bug des
Am 30.08.2012 20:47, schrieb Jeff Cody:
> This is based heavily on Supriya Kannery's bdrv_reopen()
> patch series.
>
> This provides a transactional method to reopen multiple
> images files safely.
>
> Image files are queue for reopen via bdrv_reopen_queue(), and the
> reopen occurs when bdrv_reo
Am 30.08.2012 20:47, schrieb Jeff Cody:
> This is derived from the Supriya Kannery's reopen patches.
>
> This contains the raw-posix driver changes for the bdrv_reopen_*
> functions. All changes are staged into a temporary scratch buffer
> during the prepare() stage, and copied over to the live s
Am 06.09.2012 09:23, schrieb Paolo Bonzini:
> Il 05/09/2012 11:57, Bharata B Rao ha scritto:
What could be the issue here ? In general, how do I ensure that my
aio calls get completed correctly in such scenarios where bdrv_read etc
are called from coroutine context rather than from m
Am 05.09.2012 18:43, schrieb Jeff Cody:
>>> +}
>>> +
>>> +int fcntl_flags = O_APPEND | O_ASYNC | O_NONBLOCK;
>>> +#ifdef O_NOATIME
>>> +fcntl_flags |= O_NOATIME;
>>> +#endif
>>> +if ((raw_s->open_flags & ~fcntl_flags) == (s->open_flags &
>>> ~fcntl_flags)) {
>>> +/* dup the
Am 06.09.2012 11:38, schrieb Paolo Bonzini:
> Il 06/09/2012 11:06, Kevin Wolf ha scritto:
>>>> If it works, I think this change would be preferrable to using a "magic"
>>>> BH in every driver.
>> The way it works in posix-aio-compat is that the request
Am 06.09.2012 12:18, schrieb Paolo Bonzini:
> Il 06/09/2012 12:07, Kevin Wolf ha scritto:
>>> The AIOCB is already invalid at the time the callback is entered, so we
>>> could release it before the call. However, not all implementation of
>>> AIO are ready for that
Am 06.09.2012 07:39, schrieb Gerd Hoffmann:
> ---
> hw/qxl.c |6 +++---
> ui/spice-display.c | 25 ++---
> ui/spice-display.h |3 ++-
> 3 files changed, 19 insertions(+), 15 deletions(-)
SoB is missing in this one.
Kevin
Am 05.09.2012 21:18, schrieb Anthony Liguori:
> This includes a de_DE translation from Kevin Wolf and an it translation from
> Paolo Bonzini.
Nope, the de_DE one is still your fake translation.
Kevin
Am 30.08.2012 20:47, schrieb Jeff Cody:
> Add bdrv_find_child(), and bdrv_delete_intermediate().
>
> bdrv_find_child(): given 'bs' and the active (topmost) BDS of an image chain,
> find the image that is the immediate top of 'bs'
>
> bdrv_delete_intermediate():
>
Am 30.08.2012 20:47, schrieb Jeff Cody:
> This adds the live commit coroutine. This iteration focuses on the
> commit only below the active layer, and not the active layer itself.
>
> The behaviour is similar to block streaming; the sectors are walked
> through, and anything that exists above 'ba
Am 30.08.2012 20:47, schrieb Jeff Cody:
> The command for live block commit is added, which has the following
> arguments:
>
> device: the block device to perform the commit on (mandatory)
> base: the base image to commit into; optional (if not specified,
> it is the underlying original
Am 07.09.2012 11:36, schrieb Paolo Bonzini:
> Il 07/09/2012 05:24, Bharata B Rao ha scritto:
>>> gluster:///volname/image?transport=unix&sockpath=/path/to/unix/sock
>> ^why 3 /// here ? volname is not a path, but image is.
>
> Because the host is the local computer, i.e. empty.
>
>>
Am 06.09.2012 17:47, schrieb Daniel P. Berrange:
> On Thu, Sep 06, 2012 at 09:10:04PM +0530, Bharata B Rao wrote:
>> On Thu, Sep 06, 2012 at 11:29:36AM +0300, Avi Kivity wrote:
>>> On 08/14/2012 12:58 PM, Kevin Wolf wrote:
>>>>
>>>>> While we are at
Am 06.09.2012 16:59, schrieb Jeff Cody:
> On 09/06/2012 09:23 AM, Kevin Wolf wrote:
>> Am 30.08.2012 20:47, schrieb Jeff Cody:
>>> Add bdrv_find_child(), and bdrv_delete_intermediate().
>>>
>>> bdrv_find_child(): given 'bs' and t
Am 06.09.2012 21:17, schrieb Hervé Poussineau:
> Attached patches have 3 goals:
> - patches 1-4 fix the NT 3.1 floppy driver problem.
> - patches 5-6 implement the VERIFY command
> - patches 7-8 are some simple cleanup
Any specific reason for resending and reordering my patches? They are
already r
Am 06.09.2012 17:34, schrieb Corey Bryant:
>
>
> On 09/06/2012 05:23 AM, Kevin Wolf wrote:
>> Am 05.09.2012 18:43, schrieb Jeff Cody:
>>>>> +}
>>>>> +
>>>>> +int fcntl_flags = O_APPEND | O_ASYNC | O_NONBLOCK;
>>>&g
Am 07.09.2012 10:42, schrieb Markus Armbruster:
>> @@ -1628,51 +1625,6 @@ static int qcow2_load_vmstate(BlockDriverState *bs,
>> uint8_t *buf,
>> return ret;
>> }
>>
>> -static QEMUOptionParameter qcow2_create_options[] = {
>> -{
>> -.name = BLOCK_OPT_SIZE,
>> -.type =
Am 05.09.2012 05:28, schrieb Alexander Graf:
>
> On 04.09.2012, at 16:08, Jason Baron wrote:
>
>> While testing q35, I found that windows 7 (specifically, windows 7 ultimate
>> with sp1 x64), wouldn't install because it can't find the cdrom or disk
>> drive.
>> The failure message is: 'A require
Am 05.09.2012 15:24, schrieb riegama...@gmail.com:
> From: Dunrong Huang
>
> If we failed to create temporary snapshot, the error message did not match
> with the error, for example:
>
> $ TMPDIR=/tmp/bad_path qemu-system-x86_64 -enable-kvm debian.qcow2 -snapshot
> qemu-system-x86_64: -enable-kv
Am 05.09.2012 13:09, schrieb Benoît Canet:
> This patchset add a JSON output mode to the qemu-img info command.
> It's a rewrite from scratch of the original patchset by Wenchao Xia
> following Anthony Liguori advices on JSON formating.
>
> the --output=(json|human) option is now mandatory on the
Am 07.09.2012 17:50, schrieb Paolo Bonzini:
> Il 27/08/2012 17:00, Paolo Bonzini ha scritto:
>> The part where I need
>> a second opinion and/or ack is patch 12 and 13. They fix the case of
>> a disk being unplugged while NBD export is active. To do this I add a
>> NotifierList to a BlockDriverSt
Am 04.09.2012 16:23, schrieb Kevin Wolf:
> Am 31.08.2012 19:30, schrieb Eric Blake:
>> On 08/31/2012 10:26 AM, Daniel P. Berrange wrote:
>>> From: "Daniel P. Berrange"
>>>
>>> The encryption password is only required if I/O is going to be
>>>
Am 10.09.2012 13:11, schrieb Daniel P. Berrange:
> From: "Daniel P. Berrange"
>
> The encryption password is only required if I/O is going to be
> performed on a disk image. The 'qemu-img info' command merely
> reports metadata, so it should not ask for a decryption password
>
> Signed-off-by: D
Am 10.08.2012 17:39, schrieb Dong Xu Wang:
> Document for add-cow format, the usage and spec of add-cow are introduced.
>
> Signed-off-by: Dong Xu Wang
> ---
> docs/specs/add-cow.txt | 123
>
> 1 files changed, 123 insertions(+), 0 deletions(-)
Am 10.08.2012 17:39, schrieb Dong Xu Wang:
> add-cow and qcow2 file format will share the same cache code, so rename
> block-cache.c to block-cache.c. And related structure and qcow2 code also
> are changed.
>
> Signed-off-by: Dong Xu Wang
> ---
> block.h|3 +
> block/Makefil
Am 10.08.2012 17:39, schrieb Dong Xu Wang:
> add-cow file format core code. It use block-cache.c as cache code.
>
> Signed-off-by: Dong Xu Wang
> ---
> block/Makefile.objs |1 +
> block/add-cow.c | 613
> +++
> block/add-cow.h | 85
Am 10.09.2012 04:25, schrieb Dong Xu Wang:
> On Fri, Sep 7, 2012 at 4:19 AM, Michael Roth
> wrote:
>> On Fri, Aug 10, 2012 at 11:39:44PM +0800, Dong Xu Wang wrote:
>>> +typedef struct AddCowHeader {
>>> +uint64_tmagic;
>>> +uint32_tversion;
>>> +
>>> +uint32_tb
Am 10.08.2012 17:39, schrieb Dong Xu Wang:
> Add qemu-iotests support for add-cow.
>
> Signed-off-by: Dong Xu Wang
> ---
> tests/qemu-iotests/017 |2 +-
> tests/qemu-iotests/020 |2 +-
> tests/qemu-iotests/check |4 ++--
> tests/qemu-iotests/common|6 ++
>
Am 05.09.2012 15:26, schrieb riegama...@gmail.com:
> From: Dunrong Huang
>
> The caller would not delete temporary file after failed get_tmp_filename().
>
> Signed-off-by: Dunrong Huang
Thanks, applied to the block branch.
Kevin
Am 24.07.2012 13:03, schrieb Paolo Bonzini:
> Extract it out of the implementation of "info block".
>
> Signed-off-by: Paolo Bonzini
> ---
> block.c | 104
> +++
> block.h |1 +
> 2 files changed, 53 insertions(+), 52 deletions(-)
Am 24.07.2012 13:03, schrieb Paolo Bonzini:
> Mirroring runs without the backing file so that it can be copied outside
> QEMU. However, we need to add it at the time the job is completed and
> QEMU switches to the target. Factor out the common bits of opening an
> image and completing a mirroring
Am 24.07.2012 13:04, schrieb Paolo Bonzini:
> Targets of a mirroring operation will not have a device. Once we have
> -blockdev or equivalent, "detached" block devices and non-anonymous
> backing files also will not have a device.
>
> Signed-off-by: Paolo Bonzini
> ---
> qapi-schema.json |5
Am 11.09.2012 15:46, schrieb Paolo Bonzini:
>
>> Once again, combining code motion and code changes in one patch makes
>> it harder to review.
>
> bdrv_ensure_backing_file() is a new standalone function that happens to be
> usable in bdrv_open as well. But I can separate the changes/fixes to a
>
Am 11.09.2012 15:49, schrieb Paolo Bonzini:
>
>
> - Messaggio originale -
>> Da: "Kevin Wolf"
>> A: "Paolo Bonzini"
>> Cc: qemu-devel@nongnu.org, ebl...@redhat.com, jc...@redhat.com,
>> stefa...@linux.vnet.ibm.com
>> Inviato:
Am 24.07.2012 13:04, schrieb Paolo Bonzini:
> Assert that write_compressed is never used with the dirty bitmap.
> Setting the bits early is wrong, because a coroutine might concurrently
> examine them and copy incomplete data from the source.
>
> Signed-off-by: Paolo Bonzini
Looks good, but I th
Am 11.09.2012 16:57, schrieb Jeff Cody:
> On 08/30/2012 02:47 PM, Jeff Cody wrote:
>> This is based heavily on Supriya Kannery's bdrv_reopen()
>> patch series.
>>
>> This provides a transactional method to reopen multiple
>> images files safely.
>>
>> Image files are queue for reopen via bdrv_reope
Am 11.09.2012 17:36, schrieb Jeff Cody:
> On 09/11/2012 11:14 AM, Kevin Wolf wrote:
>> Am 11.09.2012 16:57, schrieb Jeff Cody:
>>> On 08/30/2012 02:47 PM, Jeff Cody wrote:
>>>> This is based heavily on Supriya Kannery's bdrv_reopen()
>>>> patch
Am 11.09.2012 16:10, schrieb Paolo Bonzini:
>
>
> - Messaggio originale -
>> Da: "Kevin Wolf"
>> A: "Paolo Bonzini"
>> Cc: qemu-devel@nongnu.org, ebl...@redhat.com, jc...@redhat.com,
>> stefa...@linux.vnet.ibm.com
>> Inviato:
Am 12.09.2012 09:28, schrieb Dong Xu Wang:
>>> +static bool is_allocated(BlockDriverState *bs, int64_t sector_num)
>>> +{
>>> +BDRVAddCowState *s = bs->opaque;
>>> +BlockCache *c = s->bitmap_cache;
>>> +int64_t cluster_num = sector_num / SECTORS_PER_CLUSTER;
>>> +uint8_t *table
Am 11.09.2012 22:28, schrieb Blue Swirl:
> On Mon, Sep 10, 2012 at 8:26 AM, Wenchao Xia
> wrote:
>> This patch contains the major APIs in the library.
>> Important APIs:
>> 1 QBroker. These structure was used to retrieve errors, every thread must
>> create one first, later maybe thread relate
Am 12.09.2012 01:50, schrieb Michael S. Tsirkin:
> On Tue, Sep 11, 2012 at 01:00:13PM -0400, Don Slutz wrote:
>> Add LSI53C1030, SAS1068, SAS1068e. Based on code from "VirtualBox Open
>> Source Edition".
>> Based on QEMU MegaRAID SAS 8708EM2.
>>
>> This is a common VMware disk controller.
>
> I
Am 24.07.2012 13:04, schrieb Paolo Bonzini:
> This patch adds the implementation of a new job that mirrors a disk to
> a new image while letting the guest continue using the old image.
> The target is treated as a "black box" and data is copied from the
> source to the target in the background. Th
Am 24.07.2012 13:04, schrieb Paolo Bonzini:
> This adds the monitor commands that start the mirroring job.
>
> Signed-off-by: Paolo Bonzini
> ---
> blockdev.c | 133
> --
> hmp-commands.hx | 21 +
> hmp.c| 28 ++
Am 13.09.2012 15:24, schrieb Paolo Bonzini:
> Il 13/09/2012 15:15, Kevin Wolf ha scritto:
>>>> +flags = bs->open_flags | BDRV_O_RDWR;
>> Do we take care to make the image read-only again after completion?
>
> Not at the file-descriptor level, but bs->read_o
Am 13.09.2012 18:12, schrieb Paolo Bonzini:
> Il 13/09/2012 17:49, Jeff Cody ha scritto:
>> Block drivers should always open the files in writeback mode (see commit
>> e1e9b0ac), so raw-posix/raw-win32 should not parse the BDRV_O_CACHE_WB
>> flag.
>>
>> Signed-off-by: Jeff Cody
>> ---
>> block/ra
Am 13.09.2012 18:57, schrieb Jeff Cody:
> On 09/13/2012 12:02 PM, Paolo Bonzini wrote:
>> Il 13/09/2012 17:49, Jeff Cody ha scritto:
>>> +
>>> +/*
>>> + * If we didn't have BDRV_O_NOCACHE set before, we may not have
>>> allocated
>>> + * aligned_buf
>>> + */
>>> +ret = raw_allo
Am 13.09.2012 23:45, schrieb Jeff Cody:
> On 09/13/2012 04:29 PM, Paolo Bonzini wrote:
>> Il 13/09/2012 21:44, Paolo Bonzini ha scritto:
>>> Il 13/09/2012 21:04, Jeff Cody ha scritto:
>> Perhaps we _should_ preserve that in bs->open_flags, while still using
>> the initial value of BDRV_O_CA
Am 14.09.2012 09:50, schrieb Paolo Bonzini:
> Il 14/09/2012 09:27, Kevin Wolf ha scritto:
>> I can't see how bs->file is needed here for writethrough semantics.
>> bdrv_open_common() sets bs->enable_write_cache to false and
>> bdrv_co_do_writev() checks it and flu
Am 13.09.2012 16:58, schrieb Christian Theune:
> Hi,
>
> we're currently still on 0.13, looking forward to a large update soon. :)
>
> We haven't been using live migration up until now, but are
> investigating it to multiple downtimes (restarting updated hosts and
> restarting updated guests) w
From: Stefan Weil
Report from smatch:
block/curl.c:546 curl_close(21) info: redundant null check on s->url calling
free()
The check was redundant, and free was also wrong because the memory
was allocated using g_strdup.
Signed-off-by: Stefan Weil
Signed-off-by: Kevin Wolf
---
block/cur
The following changes since commit e0a1e32dbc41e6b2aabb436a9417dfd32177a3dc:
Merge branch 'usb.64' of git://git.kraxel.org/qemu (2012-09-11 18:06:56 +0200)
are available in the git repository at:
git://repo.or.cz/qemu/kevin.git for-anthony
Benoît Canet (2):
qapi: Add SnapshotInfo and
the power condition defined in
Table 558. If this field has a value other than 0h then the Start
and LoEj bits shall be ignored.
Signed-off-by: Ronnie Sahlberg
Signed-off-by: Kevin Wolf
---
hw/ide/atapi.c |6 ++
1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/hw/ide/atapi.
s the size of smart_attributes and simplifies the for loops.
Signed-off-by: Stefan Weil
Signed-off-by: Kevin Wolf
---
hw/ide/core.c | 11 ++-
1 files changed, 2 insertions(+), 9 deletions(-)
diff --git a/hw/ide/core.c b/hw/ide/core.c
index d65ef3d..d6fb69c 100644
--- a/hw/ide/core.c
+
From: Pavel Hrdina
The tray status should change also if you eject empty block device.
Signed-off-by: Pavel Hrdina
Signed-off-by: Kevin Wolf
---
block.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/block.c b/block.c
index 470bdcc..c754353 100644
--- a/block.c
From: Dunrong Huang
The caller would not delete temporary file after failed get_tmp_filename().
Signed-off-by: Dunrong Huang
Signed-off-by: Kevin Wolf
---
block.c |6 +-
1 files changed, 5 insertions(+), 1 deletions(-)
diff --git a/block.c b/block.c
index c754353..e78039b 100644
block fixes this.
It also avoids calling function write with 0 bytes of data.
Signed-off-by: Stefan Weil
Signed-off-by: Kevin Wolf
---
block/vdi.c | 25 -
1 files changed, 12 insertions(+), 13 deletions(-)
diff --git a/block/vdi.c b/block/vdi.c
index c4f1529..550cf58
From: Benoît Canet
Signed-off-by: Benoit Canet
Signed-off-by: Kevin Wolf
---
qapi-schema.json | 64 ++
1 files changed, 64 insertions(+), 0 deletions(-)
diff --git a/qapi-schema.json b/qapi-schema.json
index a9f465a..1c168c5 100644
--- a
d Fedora 16 and 17 to verify that they continue to work with
this change.
Signed-off-by: Jason Baron
Acked-by: Alexander Graf
Signed-off-by: Kevin Wolf
---
hw/ide/ahci.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/hw/ide/ahci.c b/hw/ide/ahci.c
index 5ea3cad.
From: "Daniel P. Berrange"
The encryption password is only required if I/O is going to be
performed on a disk image. The 'qemu-img info' command merely
reports metadata, so it should not ask for a decryption password
Signed-off-by: Daniel P. Berrange
Signed-off-by: Kevin W
],
"virtual-size": 1073741824,
"filename": "snap.qcow2",
"cluster-size": 65536,
"format": "qcow2",
"actual-size": 985587712,
"dirty-flag": false
}
Signed-off-by: Benoit Canet
Signed-off-by: Ke
From: MORITA Kazutaka
This patch sets data to be sent to Sheepdog correctly and fixes savevm
and loadvm operations on a Sheepdog image.
Signed-off-by: MORITA Kazutaka
Signed-off-by: Kevin Wolf
---
block/sheepdog.c |3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a
Am 14.09.2012 16:12, schrieb Alexander Graf:
>
> On 14.09.2012, at 16:08, Jason Baron wrote:
>
>> On Fri, Sep 14, 2012 at 03:56:17PM +0200, Alexander Graf wrote:
>>> On 14.09.2012, at 15:50, Jason Baron wrote:
>>>
On Fri, Sep 14, 2012 at 12:29:17AM +0200, Alexander Graf wrote:
> On 13.09
Am 14.09.2012 15:17, schrieb Paolo Bonzini:
> Hi all,
>
> here is a proposal for moving around 150 C files currently in the
> toplevel directory to separate, well-delimited subdirectories. Header
> files would be moved for now in include/, preparing for subsequent
> reorganization of headers.
>
Am 16.09.2012 13:41, schrieb Michael Tokarev:
> The text describing `create' qemu-img subcommand refers to backing_file,
> but it is not mentioned anywhere in the syntax for this subcommand.
>
> Signed-off-by: Michael Tokarev
No, -b is deprecated, you should be using -o backing_file=...
What de
Am 16.09.2012 12:13, schrieb Peter Lieven:
> Hi,
>
> when trying to block migrate a VM from one node to another, the source
> VM crashed with the following assertion:
> block.c:3829: bdrv_set_in_use: Assertion `bs->in_use != in_use' failed.
>
> Is this sth already addresses/known?
Not that I'm
Am 17.09.2012 18:43, schrieb Paolo Bonzini:
> Il 07/09/2012 18:11, Kevin Wolf ha scritto:
>> I was planning to review it in more detail next week, but I just had a
>> quick look. I'm not sure if automatically shutting down the NBD server
>> when the guest stops usi
Am 18.09.2012 11:09, schrieb Paolo Bonzini:
>>> Luckily removable media are usually not too interesting, so a
>>> slightly suboptimal behavior is okay as long as it does not break the
>>> important use cases---mostly migration without shared storage, where also
>>> uninteresting images have to be m
Am 18.09.2012 11:48, schrieb Paolo Bonzini:
> Il 18/09/2012 11:40, Kevin Wolf ha scritto:
>>>>>> Note that after completing the refactoring, we'll only have one combined
>>>>>> bdrv_close/delete function and so there won't be BlockDriverStates
&
Am 18.09.2012 12:28, schrieb Peter Lieven:
> On 09/17/12 22:12, Peter Lieven wrote:
>> On 09/17/12 10:41, Kevin Wolf wrote:
>>> Am 16.09.2012 12:13, schrieb Peter Lieven:
>>>> Hi,
>>>>
>>>> when trying to block migrate a VM from one node to
: Kevin Wolf
---
block/qcow2-cluster.c | 23 +--
block/qcow2.c | 32 +---
block/qcow2.h |7 +--
3 files changed, 31 insertions(+), 31 deletions(-)
diff --git a/block/qcow2-cluster.c b/block/qcow2-cluster.c
index c4752ee
Not exactly bisectable, but one large patch isn't much better either :-(
m->error is used to allow bdrv_drain() to stop with l2meta in error
state rather than go into an endless loop.
Signed-off-by: Kevin Wolf
---
block/qcow2.c | 44
block
uired, allocate new clusters
Changing the code to reflect this doesn't change the behaviour because
overlaps cannot exist for clusters that are kept in step 2. It does
however make it easier for later patches to work on clusters that belong
to an allocation that is still in flight.
Signed-off
Signed-off-by: Kevin Wolf
---
block/qcow2-cluster.c | 29 +
block/qcow2.c | 31 ---
block/qcow2.h | 10 ++
3 files changed, 67 insertions(+), 3 deletions(-)
diff --git a/block/qcow2-cluster.c b/block/qcow2
nge this, while we're touching it.
Signed-off-by: Kevin Wolf
---
block/qcow2.c | 26 +++---
1 files changed, 15 insertions(+), 11 deletions(-)
diff --git a/block/qcow2.c b/block/qcow2.c
index e001436..88a2020 100644
--- a/block/qcow2.c
+++ b/block/qcow2.c
@@ -739,16 +
Signed-off-by: Kevin Wolf
---
block/qcow2-cluster.c | 70 +---
1 files changed, 42 insertions(+), 28 deletions(-)
diff --git a/block/qcow2-cluster.c b/block/qcow2-cluster.c
index 7a038ac..468ef1b 100644
--- a/block/qcow2-cluster.c
+++ b/block/qcow2
This makes it easier to address the areas for which a COW must be
performed. As a nice side effect, the COW code in
qcow2_alloc_cluster_link_l2 becomes really trivial.
Signed-off-by: Kevin Wolf
---
block/qcow2-cluster.c | 85 +++--
block/qcow2.h
Signed-off-by: Kevin Wolf
---
block/qcow2-cluster.c | 26 --
block/qcow2.h | 11 +++
2 files changed, 27 insertions(+), 10 deletions(-)
diff --git a/block/qcow2-cluster.c b/block/qcow2-cluster.c
index 4d5c3da..440fdbf 100644
--- a/block/qcow2
an do better: Just cancel
the COW instead of waiting for it and then overwriting the same area
with the second write request.
Signed-off-by: Kevin Wolf
---
block/qcow2-cluster.c | 127 +++--
block/qcow2.c | 21
block/qcow2.h |
r.
We can do both at the same time and then we actually do gain
performance (iozone initial writer test up from 22 to 35 MB/s).
Signed-off-by: Kevin Wolf
---
This patch is not correct at all and potentially corrupts images, it's
ugly too, but it works good enough to try out what gains
ned-off-by: Kevin Wolf
---
block/qcow2-cluster.c | 39 +++
block/qcow2.c |2 ++
block/qcow2.h | 19 +++
3 files changed, 60 insertions(+), 0 deletions(-)
diff --git a/block/qcow2-cluster.c b/block/qcow2-cluster.c
ind
24491836
patch 65536 819341949122631252124631796
base 1048576 256 22344 38437 105823 106135 37743 32167
patch 1048576 256 35989 38542 105231 105994 38301 33036
Kevin Wolf (16):
qcow2: Round QCowL2Meta.offset down to clust
still running after bdrv_drain_all
(e.g. when the VM is stopped).
Signed-off-by: Kevin Wolf
---
block.c |5 +++
block/qcow2.c | 89 +
block/qcow2.h |8 +
block_int.h |3 ++
4 files changed, 93 insertions(+), 12 dele
The offset within the cluster is already present as n_start and this is
what the code uses. QCowL2Meta.offset is only needed at a cluster
granularity.
Signed-off-by: Kevin Wolf
---
block/qcow2-cluster.c |4 ++--
block/qcow2.h | 22 ++
2 files changed, 24
There's no real reason to have an l2meta for normal requests that don't
allocate anything. Before we can get rid of it, we must return the host
cluster offset in a different way.
Signed-off-by: Kevin Wolf
---
block/qcow2-cluster.c | 10 ++
block/qcow2.c
As soon as delayed COW is introduced, the l2meta struct is needed even
after completion of the request, so it can't live on the stack.
Signed-off-by: Kevin Wolf
---
block/qcow2.c | 26 +++---
1 files changed, 15 insertions(+), 11 deletions(-)
diff --git a/block/qcow
Am 17.09.2012 17:22, schrieb Bharata B Rao:
> sockets: Make inet_parse() non static.
>
> From: Bharata B Rao
>
> Make inet_parse() non-static so that other subsystems like gluster
> can use it to parse inet addresses. As a pre-requisite, define and
> globalize the qemu_inet_opts.
>
> Signed-off
This is closer to where the dirty flag is really needed, and it avoids
having checks for special cases related to cluster allocation directly
in the writev loop.
Signed-off-by: Kevin Wolf
---
block/qcow2-cluster.c |5 -
block/qcow2.c |7 +--
block/qcow2.h |2
Am 17.09.2012 17:23, schrieb Bharata B Rao:
> sockets: Change inet_parse() to accept address specification without port
>
> From: Bharata B Rao
>
> inet_parse() expects address:port. Change it to work without explicit port
> specification. In addition, don't depend solely on the return value of
Am 17.09.2012 17:26, schrieb Bharata B Rao:
> block: Support GlusterFS as a QEMU block backend.
>
> From: Bharata B Rao
>
> This patch adds gluster as the new block backend in QEMU. This gives
> QEMU the ability to boot VM images from gluster volumes. Its already
> possible to boot from VM image
Am 18.09.2012 15:31, schrieb Paolo Bonzini:
> Il 18/09/2012 15:22, Kevin Wolf ha scritto:
>> Am 17.09.2012 17:23, schrieb Bharata B Rao:
>>> sockets: Change inet_parse() to accept address specification without port
>>>
>>> From: Bharata B Rao
>>>
>
Am 18.09.2012 16:24, schrieb Paolo Bonzini:
> Il 18/09/2012 13:40, Kevin Wolf ha scritto:
>> +qemu_co_mutex_unlock(&s->lock);
>> +qemu_co_rwlock_rdlock(&s->l2meta_flush);
>
> Should this lock be taken in process_l2meta? It's a bit
Am 18.09.2012 16:27, schrieb Paolo Bonzini:
> Il 18/09/2012 13:40, Kevin Wolf ha scritto:
>> +again:
>> +QLIST_FOREACH(m, &s->cluster_allocs, next_in_flight) {
>> +if (m->sleeping) {
>> +qemu_coroutine_enter(m->co, NULL);
>>
Am 18.09.2012 16:33, schrieb Paolo Bonzini:
> Il 18/09/2012 13:40, Kevin Wolf ha scritto:
>> static void run_dependent_requests(BDRVQcowState *s, QCowL2Meta *m)
>> {
>> -/* Take the request off the list of running requests */
>> -if (m->nb_clusters != 0
Am 18.09.2012 16:44, schrieb Paolo Bonzini:
> Il 18/09/2012 13:40, Kevin Wolf ha scritto:
>> +qemu_co_mutex_unlock(&s->lock);
>> +qemu_co_rwlock_wrlock(&m->l2_writeback_lock);
>
> Can anybody else take the lock as reader again at this point? If not,
Am 18.09.2012 19:49, schrieb Michael Tokarev:
> On 14.09.2012 16:39, Kevin Wolf wrote:
>> The following changes since commit e0a1e32dbc41e6b2aabb436a9417dfd32177a3dc:
>>
>> Merge branch 'usb.64' of git://git.kraxel.org/qemu (2012-09-11 18:06:56
>>
Am 28.02.2013 um 02:52 hat Eric Blake geschrieben:
> On 02/27/2013 10:25 AM, Kevin Wolf wrote:
> > Instead of constantly keeping complaining that we need this big -blockdev
> > things, let's start attacking individual parts of the project. Here is the
> > first part,
901 - 1000 of 24367 matches
Mail list logo
