[Qemu-devel] [PULL 00/19] Block patches

2012-09-24 Thread Kevin Wolf
The following changes since commit d3e8f95753114a827f9cd8e819b1d5cc8333f76b: w32: Add implementation of gmtime_r, localtime_r (2012-09-23 17:09:30 +) are available in the git repository at: git://repo.or.cz/qemu/kevin.git for-anthony Jeff Cody (18): block: correctly set the keep_r

[Qemu-devel] [PATCH 13/19] block: qcow2 image file reopen

2012-09-24 Thread Kevin Wolf
From: Jeff Cody These are the stubs for the file reopen drivers for the qcow2 format. There is currently nothing that needs to be done by the qcow2 driver in reopen. Signed-off-by: Jeff Cody Signed-off-by: Kevin Wolf --- block/qcow2.c | 10 ++ 1 files changed, 10 insertions(+), 0

[Qemu-devel] [PATCH 03/19] block: make bdrv_set_enable_write_cache() modify open_flags

2012-09-24 Thread Kevin Wolf
across reopens. Signed-off-by: Jeff Cody Signed-off-by: Kevin Wolf --- block.c |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/block.c b/block.c index 4c0e7f5..458bcc9 100644 --- a/block.c +++ b/block.c @@ -2168,6 +2168,13 @@ int bdrv_enable_write_cache(BlockDrive

[Qemu-devel] [PATCH 15/19] block: vmdk image file reopen

2012-09-24 Thread Kevin Wolf
From: Jeff Cody This patch supports reopen for VMDK image files. VMDK extents are added to the existing reopen queue, so that the transactional model of reopen is maintained with multiple image files. Signed-off-by: Jeff Cody Signed-off-by: Kevin Wolf --- block/vmdk.c | 35

[Qemu-devel] [PATCH 11/19] block: raw image file reopen

2012-09-24 Thread Kevin Wolf
From: Jeff Cody These are the stubs for the file reopen drivers for the raw format. There is currently nothing that needs to be done by the raw driver in reopen. Signed-off-by: Jeff Cody Signed-off-by: Kevin Wolf --- block/raw.c | 10 ++ 1 files changed, 10 insertions(+), 0

[Qemu-devel] [PATCH 10/19] block: raw-posix image file reopen

2012-09-24 Thread Kevin Wolf
Upon _abort(), the duplicate/new fd is closed. Signed-off-by: Jeff Cody Signed-off-by: Kevin Wolf --- block/raw-posix.c | 114 + 1 files changed, 114 insertions(+), 0 deletions(-) diff --git a/block/raw-posix.c b/block/raw-posix.c index 0f

[Qemu-devel] [PATCH 02/19] block: correctly set the keep_read_only flag

2012-09-24 Thread Kevin Wolf
ant: [ base ] kro = 0, ro = 1 | v [ snap-1 ] kro = 0, ro = 1 | v [ snap-2 ] kro = 0, ro = 1 | v [ active ] kro = 0, ro = 0 Signed-off-by: Jeff Cody Signed-off-by: Kevin Wolf --- block.c | 14 +++--- block.h |1 + 2 files changed, 8 insertions(+), 7 deleti

[Qemu-devel] [PATCH 08/19] block: use BDRV_O_NOCACHE instead of s->aligned_buf in raw-posix.c

2012-09-24 Thread Kevin Wolf
From: Jeff Cody Rather than check for a non-NULL aligned_buf to determine if raw_aio_submit needs to check for alignment, check for the presence of BDRV_O_NOCACHE in the bs->open_flags. Signed-off-by: Jeff Cody Signed-off-by: Kevin Wolf --- block/raw-posix.c |2 +- 1 files changed

[Qemu-devel] [PATCH 18/19] block: convert bdrv_commit() to use bdrv_reopen()

2012-09-24 Thread Kevin Wolf
From: Jeff Cody Currently, bdrv_commit() reopens images r/w itself, via risky _delete() and _open() calls. Use the new safe method for drive reopen. Signed-off-by: Jeff Cody Signed-off-by: Kevin Wolf --- block.c | 48 +--- 1 files changed, 5

[Qemu-devel] [PATCH 09/19] block: purge s->aligned_buf and s->aligned_buf_size from raw-posix.c

2012-09-24 Thread Kevin Wolf
From: Jeff Cody The aligned_buf pointer and aligned_buf size are no longer used in raw_posix.c, so remove all references to them. Signed-off-by: Jeff Cody Signed-off-by: Kevin Wolf --- block/raw-posix.c | 21 + 1 files changed, 1 insertions(+), 20 deletions(-) diff

[Qemu-devel] [PATCH 19/19] block: remove keep_read_only flag from BlockDriverState struct

2012-09-24 Thread Kevin Wolf
From: Jeff Cody The keep_read_only flag is no longer used, in favor of the bdrv flag BDRV_O_ALLOW_RDWR. Signed-off-by: Jeff Cody Signed-off-by: Kevin Wolf --- block.c |2 -- block_int.h |1 - 2 files changed, 0 insertions(+), 3 deletions(-) diff --git a/block.c b/block.c index

[Qemu-devel] [PATCH 17/19] block: vpc image file reopen

2012-09-24 Thread Kevin Wolf
From: Jeff Cody There is currently nothing that needs to be done for VPC image file reopen. Signed-off-by: Jeff Cody Signed-off-by: Kevin Wolf --- block/vpc.c |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/block/vpc.c b/block/vpc.c index c0b82c4..b6bf52f

[Qemu-devel] [PATCH 01/19] blockdev: preserve readonly and snapshot states across media changes

2012-09-24 Thread Kevin Wolf
ags to be correct. Signed-off-by: Kevin Shanahan Signed-off-by: Kevin Wolf --- blockdev.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/blockdev.c b/blockdev.c index 7c83baa..e5d450f 100644 --- a/blockdev.c +++ b/blockdev.c @@ -527,6 +527,8 @@ DriveInfo *drive_init(Qe

[Qemu-devel] [PATCH 04/19] block: Framework for reopening files safely

2012-09-24 Thread Kevin Wolf
eopen * flags for the reopen * opaque pointer for any driver-specific data that needs to be persistent from _prepare to _commit/_abort * reopen queue pointer, if the driver needs to queue additional BDS for a reopen Signed-off-by: Jeff Cody Signed-off-by: Kevin Wolf --- bl

Re: [Qemu-devel] linux aio and cache mode

2012-09-25 Thread Kevin Wolf
Am 25.09.2012 00:40, schrieb ching: > On 09/24/2012 08:30 PM, Kevin Wolf wrote: >> Am 24.09.2012 13:32, schrieb ching: >>> Hi all, >>> >>> My host is qemu-1.1.1 and x64 kernel 3.5.4. The guest is using aio="native" >>> >>> I am

[Qemu-devel] [PATCH] block-migration: Flush requests in blk_mig_cleanup

2012-09-25 Thread Kevin Wolf
When cancelling block migration, all in-flight requests of the block migration must be completed before the data can be freed. This was visible as failing assertions and segfaults. Reported-by: Peter Lieven Signed-off-by: Kevin Wolf --- block-migration.c |2 ++ 1 files changed, 2

Re: [Qemu-devel] Block Migration Assertion in qemu-kvm 1.2.0

2012-09-25 Thread Kevin Wolf
Am 19.09.2012 07:49, schrieb Peter Lieven: > On 09/18/12 12:31, Kevin Wolf wrote: >> Am 18.09.2012 12:28, schrieb Peter Lieven: >>> On 09/17/12 22:12, Peter Lieven wrote: >>>> On 09/17/12 10:41, Kevin Wolf wrote: >>>>> Am 16.09.2012 12:13, schrieb Peter

Re: [Qemu-devel] KVM call agenda for September 25th

2012-09-25 Thread Kevin Wolf
Am 25.09.2012 14:57, schrieb Anthony Liguori: > Paolo Bonzini writes: > >> Il 24/09/2012 13:28, Juan Quintela ha scritto: >>> Hi >>> >>> Please send in any agenda items you are interested in covering. >> >> URI parsing library for glusterfs: libxml2 vs. in-tree "fork" of the >> same code. > > Th

Re: [Qemu-devel] linux aio and cache mode

2012-09-26 Thread Kevin Wolf
Am 26.09.2012 01:22, schrieb ching: > On 09/25/2012 09:33 PM, Kevin Wolf wrote: >> Am 25.09.2012 00:40, schrieb ching: >>> On 09/24/2012 08:30 PM, Kevin Wolf wrote: >>>> Am 24.09.2012 13:32, schrieb ching: >>>>> Hi all, >>>>> >>

Re: [Qemu-devel] [PATCH v9 4/4] block: Support GlusterFS as a QEMU block backend.

2012-09-26 Thread Kevin Wolf
Am 24.09.2012 11:13, schrieb Bharata B Rao: > block: Support GlusterFS as a QEMU block backend. > > From: Bharata B Rao > > This patch adds gluster as the new block backend in QEMU. This gives > QEMU the ability to boot VM images from gluster volumes. Its already > possible to boot from VM image

Re: [Qemu-devel] [PATCH v2] Add infrastructure for QIDL-based device serialization

2012-09-26 Thread Kevin Wolf
Am 25.09.2012 23:12, schrieb Anthony Liguori: > Michael Roth writes: > >> On Tue, Sep 25, 2012 at 08:37:16AM +0200, Paolo Bonzini wrote: >>> Il 24/09/2012 20:14, Michael Roth ha scritto: I went with qUppercase because it avoids all the previous issues with using leading undersco

Re: [Qemu-devel] [PATCH 04/25] ahci: add ide device initialization helper

2012-09-26 Thread Kevin Wolf
Am 26.09.2012 10:15, schrieb Markus Armbruster: > Jason Baron writes: >> I think that -drive if=ide should result in a disk attached piix3-ide. >> Not in an ide disk attached to the ahci controller (which is current q35 >> bahavior, and is 'broken' b/c we don't want that to change after q35 is >>

Re: [Qemu-devel] [RFC PATCH 00/17] Support for multiple "AIO contexts"

2012-09-26 Thread Kevin Wolf
Am 25.09.2012 14:55, schrieb Paolo Bonzini: > This series removes the globals from async.c/aio-posix.c so that > multiple AIO contexts (mini event loops) can be added. Right now, > all block devices still use qemu_bh_new, but switching them to > aio_bh_new would let you associate different files w

Re: [Qemu-devel] [PATCH v2 1/7] block: add support functions for live commit, to find and delete images.

2012-09-26 Thread Kevin Wolf
Am 25.09.2012 18:29, schrieb Jeff Cody: > Add bdrv_find_overlay(), and bdrv_drop_intermediate(). > > bdrv_find_overlay(): given 'bs' and the active (topmost) BDS of an image > chain, > find the image that is the immediate top of 'bs' > > bdrv_drop_intermediate(): >

Re: [Qemu-devel] [PATCH v2 2/7] block: add live block commit functionality

2012-09-26 Thread Kevin Wolf
at exists above 'base' is committed back down > into base. At the end, intermediate images are deleted, and the > chain stitched together. Images are restored to their original open > flags upon completion. > > Signed-off-by: Jeff Cody Reviewed-by: Kevin Wolf

Re: [Qemu-devel] [PATCH v2 5/7] QAPI: add command for live block commit, 'block-commit'

2012-09-26 Thread Kevin Wolf
Am 25.09.2012 18:29, schrieb Jeff Cody: > The command for live block commit is added, which has the following > arguments: > > device: the block device to perform the commit on (mandatory) > base: the base image to commit into; optional (if not specified, > it is the underlying original

Re: [Qemu-devel] [PATCH v2 7/7] block: after creating a live snapshot, make old image read-only

2012-09-26 Thread Kevin Wolf
Am 25.09.2012 18:29, schrieb Jeff Cody: > Currently, after a live snapshot of a drive, the image that has > been 'demoted' to be below the new active layer remains r/w. > This patch reopens it read-only. > > Note that we do not check for error on the reopen(), because we > will not abort the snaps

Re: [Qemu-devel] [RFC PATCH 00/17] Support for multiple "AIO contexts"

2012-09-26 Thread Kevin Wolf
Am 26.09.2012 15:32, schrieb Paolo Bonzini: > Il 26/09/2012 14:28, Kevin Wolf ha scritto: >> Do you have a git tree where I could see what things would look like in >> the end? > > I will push it to aio-context on git://github.com/bonzini/qemu.git as > soon as github co

Re: [Qemu-devel] [PATCH v2 5/7] QAPI: add command for live block commit, 'block-commit'

2012-09-26 Thread Kevin Wolf
Am 26.09.2012 16:25, schrieb Jeff Cody: > On 09/26/2012 10:13 AM, Kevin Wolf wrote: >> Am 25.09.2012 18:29, schrieb Jeff Cody: >>> The command for live block commit is added, which has the following >>> arguments: >>> >>> device: the block device

Re: [Qemu-devel] [RFC PATCH 00/17] Support for multiple "AIO contexts"

2012-09-27 Thread Kevin Wolf
Am 26.09.2012 17:48, schrieb Paolo Bonzini: > Il 26/09/2012 16:31, Kevin Wolf ha scritto: > >>>> In fact, after removing io_flush, I don't really see what makes AIO >>>> fd handlers special any more. >>> >>> Note that while the handlers aren

Re: [Qemu-devel] [PATCH v2 02/45] blockdev: rename block_stream_cb to a generic block_job_cb

2012-09-27 Thread Kevin Wolf
Am 26.09.2012 17:56, schrieb Paolo Bonzini: > From: Jeff Cody > > Signed-off-by: Jeff Cody This should also be signed off by you, not only by Jeff. Kevin

Re: [Qemu-devel] [PATCH v2 03/45] block: fix documentation of block_job_cancel_sync

2012-09-27 Thread Kevin Wolf
Am 26.09.2012 17:56, schrieb Paolo Bonzini: > Do this in a separate commit before we move the functions to > blockjob.h. > > Signed-off-by: Paolo Bonzini > --- > v1->v2: split out of the next patch > > block_int.h | 4 ++-- > 1 file modificato, 2 inserzioni(+), 2 rimozioni(-) > > diff

Re: [Qemu-devel] [PATCH v2 03/45] block: fix documentation of block_job_cancel_sync

2012-09-27 Thread Kevin Wolf
Am 27.09.2012 14:08, schrieb Paolo Bonzini: > Il 27/09/2012 14:03, Kevin Wolf ha scritto: >>>> /** >>>> - * block_job_cancel: >>>> + * block_job_cancel_sync: >>>> * @job: The job to be canceled. >>>> * >>>

Re: [Qemu-devel] [PATCH v2 06/45] block: add support for job pause/resume

2012-09-27 Thread Kevin Wolf
Am 26.09.2012 17:56, schrieb Paolo Bonzini: > Job pausing reuses the existing support for cancellable sleeps. A pause > happens at the next sleeping point and lasts until the coroutine is > re-entered explicitly. Cancellation was already doing a forced resume, > so implement it explicitly in term

Re: [Qemu-devel] [PATCH v2 09/45] block: rename block_job_complete to block_job_completed

2012-09-27 Thread Kevin Wolf
Am 26.09.2012 17:56, schrieb Paolo Bonzini: > The imperative will be used for the QMP command. > > Signed-off-by: Paolo Bonzini I would still be glad if we found a better name. Having two functions block_job_complete() and block_job_completed() sounds like a great source for confusion. Kevin

Re: [Qemu-devel] [PATCH v2 06/45] block: add support for job pause/resume

2012-09-27 Thread Kevin Wolf
Am 27.09.2012 14:27, schrieb Paolo Bonzini: > Il 27/09/2012 14:18, Kevin Wolf ha scritto: >>>> >>>> Signed-off-by: Paolo Bonzini >> I think there's a problem with terminology at least. What does "paused" >> really mean? Is it that the job h

Re: [Qemu-devel] [PATCH v2 14/45] block: introduce block job error

2012-09-27 Thread Kevin Wolf
Am 26.09.2012 17:56, schrieb Paolo Bonzini: > The following behaviors are possible: > > 'report': The behavior is the same as in 1.1. An I/O error, > respectively during a read or a write, will complete the job immediately > with an error code. > > 'ignore': An I/O error, respectively during a r

Re: [Qemu-devel] [PATCH v2 06/45] block: add support for job pause/resume

2012-09-27 Thread Kevin Wolf
Am 27.09.2012 14:57, schrieb Paolo Bonzini: > Il 27/09/2012 14:45, Kevin Wolf ha scritto: >> Am 27.09.2012 14:27, schrieb Paolo Bonzini: >>> Il 27/09/2012 14:18, Kevin Wolf ha scritto: >>>>>> >>>>>> Signed-off-by: Paolo Bonzini >>>&

Re: [Qemu-devel] [PATCH v2 00/45] Block job improvements for 1.3

2012-09-27 Thread Kevin Wolf
Am 26.09.2012 17:56, schrieb Paolo Bonzini: > Hi all, this is the resubmission of my block job patches, originally > meant for 1.2. This still does not include a persistent dirty bitmap, > which I hope to post in October. > > The patches are organized as follows: > > 01-13 preparatory work for

[Qemu-devel] [PATCH 07/30] block: Support GlusterFS as a QEMU block backend.

2012-09-28 Thread Kevin Wolf
er+tcp://[1:2:3:4:5:6:7:8]/testvol/dir/a.img file=gluster+tcp://[1:2:3:4:5:6:7:8]:24007/testvol/dir/a.img file=gluster+tcp://server.domain.com:24007/testvol/dir/a.img file=gluster+unix:///testvol/dir/a.img?socket=/tmp/glusterd.socket file=gluster+rdma://1.2.3.4:24007/testvol/a.img Signed-off-by

[Qemu-devel] [PATCH 11/30] block: helper function, to find the base image of a chain

2012-09-28 Thread Kevin Wolf
From: Jeff Cody This is a simple helper function, that will return the base image of a given image chain. Signed-off-by: Jeff Cody Reviewed-by: Eric Blake Signed-off-by: Kevin Wolf --- block.c | 16 block.h |1 + 2 files changed, 17 insertions(+), 0 deletions(-) diff

[Qemu-devel] [PATCH 09/30] block: add live block commit functionality

2012-09-28 Thread Kevin Wolf
down into base. At the end, intermediate images are deleted, and the chain stitched together. Images are restored to their original open flags upon completion. Signed-off-by: Jeff Cody Reviewed-by: Eric Blake Signed-off-by: Kevin Wolf --- block/Makefile.objs |1 + block/commit.c

[Qemu-devel] [PATCH 17/30] block: add block_job_query

2012-09-28 Thread Kevin Wolf
From: Paolo Bonzini Extract it out of the implementation of info block-jobs. Signed-off-by: Paolo Bonzini Reviewed-by: Eric Blake Signed-off-by: Kevin Wolf --- blockdev.c | 15 ++- blockjob.c | 11 +++ blockjob.h |8 3 files changed, 21 insertions(+), 13

[Qemu-devel] [PATCH 18/30] qmp: add 'busy' member to BlockJobInfo

2012-09-28 Thread Kevin Wolf
From: Paolo Bonzini Because pausing a job is asynchronous, we need to know whether it has completed. This is described by the "busy" field of BlockJob; copy it to BlockJobInfo. Signed-off-by: Paolo Bonzini Reviewed-by: Eric Blake Signed-off-by: Kevin Wolf --- blockjob.c

[Qemu-devel] [PATCH 30/30] qemu-iotests: add tests for streaming error handling

2012-09-28 Thread Kevin Wolf
Eric Blake Signed-off-by: Kevin Wolf --- tests/qemu-iotests/030| 220 + tests/qemu-iotests/030.out|4 +- tests/qemu-iotests/iotests.py |7 ++ 3 files changed, 229 insertions(+), 2 deletions(-) diff --git a/tests/qemu-iotests/030 b/

[Qemu-devel] [PATCH 27/30] stream: add on-error argument

2012-09-28 Thread Kevin Wolf
From: Paolo Bonzini This patch adds support for error management to streaming. Signed-off-by: Paolo Bonzini Reviewed-by: Eric Blake Signed-off-by: Kevin Wolf --- block/stream.c | 28 +++- block_int.h |3 ++- blockdev.c | 11 --- hmp.c

Re: [Qemu-devel] [PATCH v3 0/6] Live block commit

2012-09-28 Thread Kevin Wolf
Am 27.09.2012 19:29, schrieb Jeff Cody: > This series adds the basic case, of a live commit between two > images below the active layer, e.g.: > > [base] <--- [snp-1] <--- [snp-2] <--- [snp-3] <--- [active] > > can be collapsed down via commit, into: > > [base] <--- [active] > > or, > > [base]

Re: [Qemu-devel] [PULL for Kevin 00/19] Block job improvements part 1

2012-09-28 Thread Kevin Wolf
Am 28.09.2012 17:22, schrieb Paolo Bonzini: > Kevin, > > the following changes since commit ac05f3492421caeb05809ffa02c6198ede179e43: > > add a boot parameter to set reboot timeout (2012-09-25 20:05:04 -0500) > > are available in the git repository at: > > git://github.com/bonzini/qemu.git

Re: [Qemu-devel] [PATCH v10 0/5] GlusterFS support in QEMU - v10

2012-09-28 Thread Kevin Wolf
Am 27.09.2012 15:55, schrieb Bharata B Rao: > Hi, > > This is v10 of the patchset to support GlusterFS backend from QEMU. > > Changes in v10 > -- > - Included another fix to qemu_aio_wait() from Paolo in the series. > - A few more fixes to the volume and image parsing code. > - Remove

[Qemu-devel] [PATCH 14/30] qerror/block: introduce QERR_BLOCK_JOB_NOT_ACTIVE

2012-09-28 Thread Kevin Wolf
From: Paolo Bonzini The DeviceNotActive text is not a particularly good match, add a separate text while keeping the same class. Signed-off-by: Paolo Bonzini Reviewed-by: Eric Blake Signed-off-by: Kevin Wolf --- blockdev.c |4 ++-- qerror.h |3 +++ 2 files changed, 5 insertions

[Qemu-devel] [PATCH 16/30] block: move job APIs to separate files

2012-09-28 Thread Kevin Wolf
From: Paolo Bonzini Signed-off-by: Paolo Bonzini Reviewed-by: Eric Blake Signed-off-by: Kevin Wolf --- Makefile.objs |5 +- block.c | 128 + block.h |2 + block/Makefile.objs |5 +- block/commit.c |1

[Qemu-devel] [PATCH 20/30] qmp: add block-job-pause and block-job-resume

2012-09-28 Thread Kevin Wolf
-by: Eric Blake Signed-off-by: Kevin Wolf --- blockdev.c | 35 +-- hmp-commands.hx | 35 --- hmp.c| 23 ++- hmp.h|2 ++ qapi-schema.json | 46

[Qemu-devel] [PATCH 02/30] block: after creating a live snapshot, make old image read-only

2012-09-28 Thread Kevin Wolf
ils. This patch depends on the bdrv_reopen() series. Signed-off-by: Jeff Cody Signed-off-by: Kevin Wolf --- blockdev.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/blockdev.c b/blockdev.c index e5d450f..0267fa3 100644 --- a/blockdev.c +++ b/blockdev.c @@ -805

[Qemu-devel] [PATCH 05/30] aio: Another fix to the walking_handlers logic

2012-09-28 Thread Kevin Wolf
From: Paolo Bonzini The AIO dispatch loop will call QLIST_REMOVE and g_free even if there are other pending calls to qemu_aio_wait outside the current one. Signed-off-by: Paolo Bonzini Signed-off-by: Bharata B Rao Signed-off-by: Kevin Wolf --- aio.c | 10 +- 1 files changed, 5

[Qemu-devel] [PATCH 28/30] blkdebug: process all set_state rules in the old state

2012-09-28 Thread Kevin Wolf
"2" [set-state] event = "..." state = "2" new_state = "1" for example the state will remain locked at 1. This can be fixed by first processing all rules, and then setting the state. Signed-off-by: Paolo Bonzini Reviewed-by: Eric Bl

[Qemu-devel] [PATCH 24/30] iostatus: change is_read to a bool

2012-09-28 Thread Kevin Wolf
From: Paolo Bonzini Do this while we are touching this part of the code, before introducing more uses of "int is_read". Signed-off-by: Paolo Bonzini Reviewed-by: Eric Blake Signed-off-by: Kevin Wolf --- block.c |4 ++-- block.h |4 ++-- blockdev.c |

[Qemu-devel] [PATCH 23/30] iostatus: move BlockdevOnError declaration to QAPI

2012-09-28 Thread Kevin Wolf
From: Paolo Bonzini This will let block-stream reuse the enum. Places that used the enums are renamed accordingly. Signed-off-by: Paolo Bonzini Reviewed-by: Eric Blake Signed-off-by: Kevin Wolf --- block.c |6 +++--- block.h |5 - block/commit.c| 14

[Qemu-devel] [PATCH 03/30] aio: Fix qemu_aio_wait() to maintain correct walking_handlers count

2012-09-28 Thread Kevin Wolf
From: Paolo Bonzini Fix qemu_aio_wait() to ensure that registered aio handlers don't get deleted when they are still active. This is ensured by maintaning the right count of walking_handlers. Signed-off-by: Paolo Bonzini Signed-off-by: Bharata B Rao Signed-off-by: Kevin Wolf ---

[Qemu-devel] [PATCH 19/30] block: add support for job pause/resume

2012-09-28 Thread Kevin Wolf
cannot be canceled without first resuming them. This ensures that I/O errors are never missed by management. Signed-off-by: Paolo Bonzini Reviewed-by: Eric Blake Signed-off-by: Kevin Wolf --- blockdev.c |4 blockjob.c | 35 ++- blockjob.h

[Qemu-devel] [PATCH 26/30] block: introduce block job error

2012-09-28 Thread Kevin Wolf
act, it is already possible now that a series of BLOCK_IO_ERROR events are reported with rerror=stop, because vm_stop calls bdrv_drain_all and this can generate further errors. Signed-off-by: Paolo Bonzini Reviewed-by: Eric Blake Signed-off-by: Kevin Wolf --- QMP/qmp-events.txt | 22 ++

[Qemu-devel] [PATCH 06/30] configure: Add a config option for GlusterFS as block backend

2012-09-28 Thread Kevin Wolf
From: Bharata B Rao GlusterFS support in QEMU depends on libgfapi, libgfrpc and libgfxdr provided by GlusterFS. Signed-off-by: Bharata B Rao Signed-off-by: Kevin Wolf --- configure | 35 +++ 1 files changed, 35 insertions(+), 0 deletions(-) diff --git a

[Qemu-devel] [PATCH 25/30] iostatus: reorganize io error code

2012-09-28 Thread Kevin Wolf
Bonzini Reviewed-by: Eric Blake Signed-off-by: Kevin Wolf --- block.c | 46 ++ block.h |5 +++-- hw/ide/core.c | 20 +--- hw/scsi-disk.c | 23 +++ hw/virtio-blk.c | 19

[Qemu-devel] [PATCH 15/30] block: fix documentation of block_job_cancel_sync

2012-09-28 Thread Kevin Wolf
From: Paolo Bonzini Do this in a separate commit before we move the functions to blockjob.h. Signed-off-by: Paolo Bonzini Reviewed-by: Eric Blake Signed-off-by: Kevin Wolf --- block_int.h | 12 +--- 1 files changed, 5 insertions(+), 7 deletions(-) diff --git a/block_int.h b

[Qemu-devel] [PATCH 29/30] qemu-iotests: map underscore to dash in QMP argument names

2012-09-28 Thread Kevin Wolf
name. Hence provide automatic conversion of underscores to dashes. Signed-off-by: Paolo Bonzini Reviewed-by: Eric Blake Signed-off-by: Kevin Wolf --- tests/qemu-iotests/iotests.py |8 +++- 1 files changed, 7 insertions(+), 1 deletions(-) diff --git a/tests/qemu-iotests/iotests.py b

[Qemu-devel] [PATCH 12/30] QAPI: add command for live block commit, 'block-commit'

2012-09-28 Thread Kevin Wolf
ned-off-by: Jeff Cody Reviewed-by: Eric Blake Signed-off-by: Kevin Wolf --- QMP/qmp-events.txt |6 +++- blockdev.c | 58 qapi-schema.json | 34 ++ qmp-commands.hx|6 + 4 files ch

[Qemu-devel] [PATCH 01/30] block-migration: Flush requests in blk_mig_cleanup

2012-09-28 Thread Kevin Wolf
When cancelling block migration, all in-flight requests of the block migration must be completed before the data can be freed. This was visible as failing assertions and segfaults. Reported-by: Peter Lieven Signed-off-by: Kevin Wolf --- block-migration.c |2 ++ 1 files changed, 2

[Qemu-devel] [PATCH 10/30] blockdev: rename block_stream_cb to a generic block_job_cb

2012-09-28 Thread Kevin Wolf
From: Jeff Cody Signed-off-by: Jeff Cody Reviewed-by: Eric Blake Signed-off-by: Kevin Wolf --- blockdev.c |6 +++--- trace-events |2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/blockdev.c b/blockdev.c index 0267fa3..f910ac5 100644 --- a/blockdev.c +++ b

[Qemu-devel] [PATCH 13/30] qemu-iotests: add initial tests for live block commit

2012-09-28 Thread Kevin Wolf
ned for the following argument errors: * top == base * top is nonexistent * base is nonexistent * top == active layer (this is currently not supported) * top and base arguments are reversed * top argument is omitted Signed-off-by: Jeff Cody Reviewed-by: Eric Blake Signed-of

[Qemu-devel] [PATCH 22/30] iostatus: rename BlockErrorAction, BlockQMPEventAction

2012-09-28 Thread Kevin Wolf
of the enum values for now. Signed-off-by: Paolo Bonzini Reviewed-by: Eric Blake Signed-off-by: Kevin Wolf --- block.c |8 block.h | 12 ++-- block_int.h |2 +- hw/ide/core.c |2 +- hw/scsi-disk.c |2 +- hw/virtio-blk.c |2 +- 6

[Qemu-devel] [PATCH 08/30] block: add support functions for live commit, to find and delete images.

2012-09-28 Thread Kevin Wolf
<- active to bottom <- base <- active Signed-off-by: Jeff Cody Reviewed-by: Eric Blake Signed-off-by: Kevin Wolf --- block.c | 143 +++ block.h |4 ++ 2 files changed, 147 insertions(+), 0 d

[Qemu-devel] [PATCH 21/30] qemu-iotests: add test for pausing a streaming operation

2012-09-28 Thread Kevin Wolf
state. However, this also happens with the existing test_stream testcase, and is better fixed in qemu-io. Signed-off-by: Paolo Bonzini Reviewed-by: Eric Blake Signed-off-by: Kevin Wolf --- tests/qemu-iotests/030 | 40 ++-- tests/qemu-iotests/030.out |4

[Qemu-devel] [PULL 00/30] Block patches

2012-09-28 Thread Kevin Wolf
ete images. block: add live block commit functionality blockdev: rename block_stream_cb to a generic block_job_cb block: helper function, to find the base image of a chain QAPI: add command for live block commit, 'block-commit' qemu-iotests: add initial tests for live

[Qemu-devel] [PATCH 2/3] stream: complete early if end of backing file is reached

2012-08-29 Thread Kevin Wolf
-drive if=virtio,cache=none,file=image.qcow2 (qemu) block_stream virtio0 (qemu) info block-jobs The qemu-iotests 030 streaming test still passes. Signed-off-by: Stefan Hajnoczi Reviewed-by: Paolo Bonzini Signed-off-by: Kevin Wolf --- block/stream.c |6 ++ 1 files changed, 6

[Qemu-devel] [PATCH 3/3] qemu-iotests: add backing file smaller than image test case

2012-08-29 Thread Kevin Wolf
From: Stefan Hajnoczi This new test case checks that streaming completes successfully when the backing file is smaller than the image file. Signed-off-by: Stefan Hajnoczi Reviewed-by: Paolo Bonzini Signed-off-by: Kevin Wolf --- tests/qemu-iotests/030 | 33

[Qemu-devel] [PULL 0/3] Block patches for 1.2-rc2

2012-08-29 Thread Kevin Wolf
The following changes since commit 18fec301cd2a38f72a5eeba2656a0c5b4fa69fb7: tcg/mips: fix broken CONFIG_TCG_PASS_AREG0 code (2012-08-28 20:38:39 +0200) are available in the git repository at: http://repo.or.cz/r/qemu/kevin.git for-anthony Stefan Hajnoczi (3): qed: refuse unaligned zer

[Qemu-devel] [PATCH 1/3] qed: refuse unaligned zero writes with a backing file

2012-08-29 Thread Kevin Wolf
block.c:bdrv_co_do_write_zeroes() and falls back to a regular write. The qemu-iotests 034 test cases covers this scenario. Signed-off-by: Stefan Hajnoczi Reviewed-by: Paolo Bonzini Signed-off-by: Kevin Wolf --- block/qed.c | 11 +++ 1 files changed, 11 insertions(+), 0 deletions(-) diff --git a

Re: [Qemu-devel] [PATCH] sheepdog: fix savevm and loadvm

2012-08-30 Thread Kevin Wolf
Am 29.08.2012 20:39, schrieb MORITA Kazutaka: > This patch sets data to be sent to Sheepdog correctly and fixes savevm > and loadvm operations on a Sheepdog image. > > Signed-off-by: MORITA Kazutaka Thanks, applied to the block branch. Kevin

Re: [Qemu-devel] [PATCH] ahci: properly reset PxCMD on HBA reset

2012-08-31 Thread Kevin Wolf
Am 23.08.2012 23:09, schrieb Jason Baron: > While testing q35, I found that windows 7 (specifically, windows 7 ultimate > with sp1 x64), wouldn't install because it can't find the cdrom or disk drive. > The failure message is: 'A required cd/dvd device driver is missing. If you > have a driver flop

Re: [Qemu-devel] [PATCH 02/18] block: add error parameter to bdrv_snapshot_create() and related functions

2012-08-31 Thread Kevin Wolf
Am 31.08.2012 08:26, schrieb Markus Armbruster: > Luiz Capitulino writes: > >> On Wed, 15 Aug 2012 09:41:43 +0200 >> Pavel Hrdina wrote: >> >>> Signed-off-by: Pavel Hrdina >>> --- >>> block.c| 25 + >>> block.h| 3 ++- >>> block/qcow2-sn

Re: [Qemu-devel] VHDX support

2012-08-31 Thread Kevin Wolf
Am 30.08.2012 09:36, schrieb Alex Bligh: > Is anyone currently working on VHDX (as opposed to VHD) support, as used > by the most recent version of Hyper-V? If not, would you be interested > in patches? I'm not aware of anyone working on it yet. Patches are welcome, of course. Kevin

Re: [Qemu-devel] [PATCH] ahci: add migration support

2012-08-31 Thread Kevin Wolf
Am 30.08.2012 20:00, schrieb Jason Baron: > Add support for ahci migration. This patch builds upon the patches posted > previously by Andreas Faerber: > > http://lists.gnu.org/archive/html/qemu-devel/2012-08/msg01538.html > > (I hope I am giving Andreas proper credit for his work.) > > I've test

Re: [Qemu-devel] [PATCH 3/7] block: raw-posix image file reopen

2012-08-31 Thread Kevin Wolf
Am 31.08.2012 16:42, schrieb Jeff Cody: > On 08/30/2012 06:15 PM, Eric Blake wrote: >> On 08/30/2012 11:47 AM, Jeff Cody wrote: >>> This is derived from the Supriya Kannery's reopen patches. >>> >>> This contains the raw-posix driver changes for the bdrv_reopen_* >>> functions. All changes are sta

[Qemu-devel] [Bug 1042654] Re: Floppy disks and network not working on NT 3.1 on Qemu 1.2 rc1

2012-08-31 Thread Kevin Wolf
waiting you get as result unknown command. Fixed status0 register handling for read/write/format commands. Signed-off-by: Pavel Hrdina Signed-off-by: Kevin Wolf -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU

Re: [Qemu-devel] [PATCH] ahci: add migration support

2012-08-31 Thread Kevin Wolf
Am 31.08.2012 17:41, schrieb Jason Baron: > On Fri, Aug 31, 2012 at 04:47:37PM +0200, Kevin Wolf wrote: >> Am 30.08.2012 20:00, schrieb Jason Baron: >>> Add support for ahci migration. This patch builds upon the patches posted >>> previously by Andreas Faerber: >>&

[Qemu-devel] [PATCH 0/3] fdc: Fix FD_SR0_SEEK flag

2012-09-04 Thread Kevin Wolf
Pavel, does this make sense to you? It seems to fix the NT 3.1 floppy driver. Kevin Wolf (3): fdc: Remove status0 parameter from fdctrl_set_fifo() fdc: Fix false FD_SR0_SEEK fdc-test: Check READ ID hw/fdc.c | 38 ++ tests/fdc-test.c | 68

[Qemu-devel] [PATCH 2/3] fdc: Fix false FD_SR0_SEEK

2012-09-04 Thread Kevin Wolf
FD_SR0_SEEK where appropriate. Signed-off-by: Kevin Wolf --- hw/fdc.c |5 ++--- tests/fdc-test.c |2 +- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/hw/fdc.c b/hw/fdc.c index 78ae064..8ea3341 100644 --- a/hw/fdc.c +++ b/hw/fdc.c @@ -1149,8 +1149,7 @@ static void

[Qemu-devel] [PATCH 1/3] fdc: Remove status0 parameter from fdctrl_set_fifo()

2012-09-04 Thread Kevin Wolf
in st0 = 0, but still triggers the interrupt. Signed-off-by: Kevin Wolf --- hw/fdc.c | 33 - 1 files changed, 16 insertions(+), 17 deletions(-) diff --git a/hw/fdc.c b/hw/fdc.c index 08830c1..78ae064 100644 --- a/hw/fdc.c +++ b/hw/fdc.c @@ -1079,15 +1079,12

[Qemu-devel] [PATCH 3/3] fdc-test: Check READ ID

2012-09-04 Thread Kevin Wolf
ST0 shouldn't include 0x20 (FD_SR0_SEEK) after READ ID. Signed-off-by: Kevin Wolf --- tests/fdc-test.c | 66 ++ 1 files changed, 66 insertions(+), 0 deletions(-) diff --git a/tests/fdc-test.c b/tests/fdc-test.c index ff96560..b825959 1

Re: [Qemu-devel] [PATCH] ide: Fix error messages from static code analysis (no real error)

2012-09-04 Thread Kevin Wolf
Am 03.09.2012 22:13, schrieb Stefan Weil: > Report from smatch: > hw/ide/core.c:1472 ide_exec_cmd(423) error: buffer overflow > 'smart_attributes' 8 <= 29 > hw/ide/core.c:1474 ide_exec_cmd(425) error: buffer overflow > 'smart_attributes' 8 <= 29 > hw/ide/core.c:1475 ide_exec_cmd(426) error: buffe

Re: [Qemu-devel] [PATCH V6 2/2] qemu-img: Add json output option to the info command.

2012-09-04 Thread Kevin Wolf
Am 27.08.2012 09:15, schrieb Benoît Canet: > This option --output=[human|json] make qemu-img info output on > human or JSON representation at the choice of the user. > > example: > { > "snapshots": [ > { > "vm-clock-nsec": 637102488, > "name": "vm-20120821145509

Re: [Qemu-devel] [PATCH 4/6] libqblock internal used functions

2012-09-04 Thread Kevin Wolf
Am 04.09.2012 15:49, schrieb Paolo Bonzini: > Il 04/09/2012 13:38, Eric Blake ha scritto: >> Since qemu does not support it now, yes, you can ignore it for now. But >> please make sure that you aren't hard-coding it into the API - that is, >> make sure that the API can someday grow to support larg

Re: [Qemu-devel] [PATCH] block/curl: Fix wrong free statement

2012-09-04 Thread Kevin Wolf
Am 01.09.2012 11:06, schrieb Stefan Weil: > Report from smatch: > block/curl.c:546 curl_close(21) info: redundant null check on s->url calling > free() > > The check was redundant, and free was also wrong because the memory > was allocated using g_strdup. > > Signed-off-by: Stefan Weil Thanks,

Re: [Qemu-devel] [PATCH] Don't require encryption password for 'qemu-img info' command

2012-09-04 Thread Kevin Wolf
Am 31.08.2012 19:30, schrieb Eric Blake: > On 08/31/2012 10:26 AM, Daniel P. Berrange wrote: >> From: "Daniel P. Berrange" >> >> The encryption password is only required if I/O is going to be >> performed on a disk image. The 'qemu-img info' command merely >> reports metadata, so it should not ask

Re: [Qemu-devel] [PATCH] vdi: Fix warning from clang

2012-09-04 Thread Kevin Wolf
Am 17.08.2012 15:23, schrieb Stefan Weil: > ccc-analyzer reports these warnings: > > block/vdi.c:704:13: warning: Dereference of null pointer > bmap[i] = VDI_UNALLOCATED; > ^ > block/vdi.c:702:13: warning: Dereference of null pointer > bmap[i] = i; >

Re: [Qemu-devel] [PATCH 1/1] block: fix block tray status

2012-09-04 Thread Kevin Wolf
Am 09.08.2012 12:44, schrieb Pavel Hrdina: > The tray status should change also if you eject empty block device. > > Signed-off-by: Pavel Hrdina Thanks, applied to block-next. Kevin

[Qemu-devel] [Bug 1044727] Re: -kernel does not work for multiboot ELF kernels

2012-09-04 Thread Kevin Wolf
Henning, please submit your patch to the qemu-devel mailing list. See http://wiki.qemu.org/Contribute/SubmitAPatch for more details on how patch submission works for qemu. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.l

Re: [Qemu-devel] [PATCH V7 2/2] qemu-img: Add json output option to the info command.

2012-09-05 Thread Kevin Wolf
Am 05.09.2012 11:25, schrieb Benoît Canet: > This option --output=[human|json] make qemu-img info output on > human or JSON representation at the choice of the user. > > example: > { > "snapshots": [ > { > "vm-clock-nsec": 637102488, > "name": "vm-20120821145509

Re: [Qemu-devel] [PATCH v6 2/2] block: Support GlusterFS as a QEMU block backend

2012-09-05 Thread Kevin Wolf
Am 05.09.2012 09:41, schrieb Bharata B Rao: > On Thu, Aug 09, 2012 at 06:32:16PM +0530, Bharata B Rao wrote: >> +static void qemu_gluster_complete_aio(GlusterAIOCB *acb) >> +{ >> +int ret; >> + >> +if (acb->canceled) { >> +qemu_aio_release(acb); >> +return; >> +} >> + >>

Re: [Qemu-devel] [Qemu-trivial] [PATCH] block: output more error messages if failed to create temporary snapshot

2012-09-05 Thread Kevin Wolf
Am 05.09.2012 11:40, schrieb Stefan Hajnoczi: > On Wed, Sep 05, 2012 at 04:26:14PM +0800, riegama...@gmail.com wrote: >> From: Dunrong Huang >> >> If we failed to create temporary snapshot, the error message did not match >> with the error, for example: >> >> $ TMPDIR=/tmp/bad_path qemu-system-x86

Re: [Qemu-devel] [PATCH] fix entry pointer for ELF kernels loaded with -kernel option

2012-09-05 Thread Kevin Wolf
Am 05.09.2012 11:05, schrieb Henning Schild: > This patch fixes a bug in qemu which prevents Multiboot ELF kernels > from being loaded with the -kernel option. Find a full description of > the problem here https://bugs.launchpad.net/qemu/+bug/1044727 . The logic looks good to me, but there ar

<    4   5   6   7   8   9   10   11   12   13   >