Just create lots of images and try out each of the creation options that
qcow2 provides (except backing_file/fmt for now)
I'm not totally happy with the behaviour of qemu-img in each of the
cases, but let's be explicit and update the test when we do change
things later.
Signed-off-by:
Am 14.01.2013 11:26, schrieb Miroslav Rezanina:
> There can be a need to turn output to stdout off. This patch adds a -q option
> that enable "Quiet mode". In Quiet mode, only errors are printed out.
>
> Signed-off-by: Miroslav Rezanina
This patch introduces trailing whitespace in some lines.
K
Am 14.01.2013 11:26, schrieb Miroslav Rezanina:
> This patch adds new qemu-img subcommand that compares content of two disk
> images.
>
> Signed-off-by: Miroslav Rezanina
> ---
> qemu-img-cmds.hx |6 ++
> qemu-img.c | 266
> ++
> 2
Am 28.01.2013 18:04, schrieb Benoît Canet:
> Protocols like quorum will be able to queue multiple reopens.
>
> Signed-off-by: Benoit Canet
-EPARSE for the subject line.
Also, what's the difference between this and a normal reopen?
Kevin
Am 28.01.2013 18:04, schrieb Benoît Canet:
> Signed-off-by: Benoit Canet
> ---
> blockdev.c |3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/blockdev.c b/blockdev.c
> index 0ce45c5..b1f388b 100644
> --- a/blockdev.c
> +++ b/blockdev.c
> @@ -800,7 +800,8 @@ void qmp_t
Am 25.01.2013 19:11, schrieb Eric Blake:
> On 01/23/2013 07:57 PM, Wenchao Xia wrote:
>> Compared to bdrv_can_snapshot(), this function return whether
>> bs* is ready to read snapshot info from instead of write. If yes,
>> caller can then query snapshot information, but taking snapshot
>> is not
Am 24.01.2013 03:57, schrieb Wenchao Xia:
> This patch add function bdrv_query_snapshot_infolist(), which will
> return snapshot info of an image in qmp object format. The implementation
> code are mostly copied from qemu-img.c with modification to fit more
> for qmp based block layer API.
> To
Am 14.01.2013 11:26, schrieb Miroslav Rezanina:
> Adding documentation for new qemu-img subcommand compare.
>
> Signed-off-by: Miroslav Rezanina
> ---
> qemu-img.c|7 ++-
> qemu-img.texi | 32
> 2 files changed, 38 insertions(+), 1 deletions(-)
Ah,
Am 28.01.2013 18:04, schrieb Benoît Canet:
> Signed-off-by: Benoit Canet
> ---
> block.c |2 +-
> include/block/block.h |1 +
> 2 files changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/block.c b/block.c
> index 41a9ac0..843583f 100644
> --- a/block.c
> +++ b/block.c
Am 24.01.2013 03:57, schrieb Wenchao Xia:
> Now qemu-img call block layer function to get image info and check
> if error happens.
>
> Signed-off-by: Wenchao Xia
> Reviewed-by: Eric Blake
Merge this with patch 5.
Kevin
Am 24.01.2013 03:57, schrieb Wenchao Xia:
> This patch add function bdrv_query_image_info(), which will return
> image info in qmp object format. The implementation code are mostly
> copied from qemu-img.c, but use block layer function to get snapshot
> info.
Don't copy code, reuse it.
Can you
Am 24.01.2013 03:57, schrieb Wenchao Xia:
> Now that we have bdrv_query_image_info, rename this function to make it
> more obvious what it is doing.
>
> Reviewed-by: Eric Blake
> Signed-off-by: Wenchao Xia
Should this provide an option to give information on each image in the
backing file cha
Am 29.01.2013 14:04, schrieb Kevin Wolf:
> Am 24.01.2013 03:57, schrieb Wenchao Xia:
>> Now that we have bdrv_query_image_info, rename this function to make it
>> more obvious what it is doing.
>>
>> Reviewed-by: Eric Blake
>> Signed-off-by: Wenchao Xia
>
Am 29.01.2013 14:07, schrieb Benoît Canet:
>> Wait, what's happening here? I don't understand this patch and how it's
>> related to snapshotting non-file protocols (if this is even what you
>> mean). What is your exact scenario, what does the existing code do in
>> it, and how does this change impr
Am 29.01.2013 14:09, schrieb Benoît Canet:
> Le Tuesday 29 Jan 2013 à 13:22:12 (+0100), Kevin Wolf a écrit :
>> Am 28.01.2013 18:04, schrieb Benoît Canet:
>>> Protocols like quorum will be able to queue multiple reopens.
>>>
>>> Signed-off-by: Benoit Canet
Am 24.01.2013 03:57, schrieb Wenchao Xia:
> This patch move it from savevm.c to block.c and export it. To make
> it clear about id and name in searching, the API was changed a bit
> to distinguish them. Caller can choose to search by id or name now.
>
> Signed-off-by: Wenchao Xia
Please keep c
Am 29.01.2013 14:43, schrieb Markus Armbruster:
>> +echo "=== Check correct interpretation of suffixes for image size ==="
>> +echo
>> +sizes="1024 1024b 1k 1K 1M 1G 1T "
>> +sizes+="1024.0 1024.0b 1.5k 1.5K 1.5M 1.5G 1.5T"
>> +
>> +echo "== 1. Traditional size parameter =="
>> +echo
>> +for s in $
Am 29.01.2013 14:45, schrieb Benoît Canet:
> Le Tuesday 29 Jan 2013 à 14:25:42 (+0100), Kevin Wolf a écrit :
>> Am 29.01.2013 14:07, schrieb Benoît Canet:
>>>> Wait, what's happening here? I don't understand this patch and how it's
>>>> related to
Am 29.01.2013 11:01, schrieb Kevin Wolf:
> Just create lots of images and try out each of the creation options that
> qcow2 provides (except backing_file/fmt for now)
>
> I'm not totally happy with the behaviour of qemu-img in each of the
> cases, but let's be explicit an
Am 29.01.2013 16:03, schrieb Benoît Canet:
>> base1 [file] --- base1 [qcow2] --- snap1.qcow2 --\
>> base2 [file] --- base2 [qcow2] --- snap2.qcow2 --->-- quorum
>> base3 [file] --- base3 [qcow2] --- snap3.qcow2 --/
>
> I tried to default snapshot creation to qcow2 in quorum.c and specify
> quorum
Am 24.01.2013 03:57, schrieb Wenchao Xia:
> This function will simply return the uri or filename used
> to open the image.
>
> Reviewed-by: Eric Blake
> Signed-off-by: Wenchao Xia
The only user of this function in the series is in block.c and could
have called it without making it public.
Ke
Am 29.01.2013 17:12, schrieb Eric Blake:
> On 01/29/2013 03:01 AM, Kevin Wolf wrote:
>> Just create lots of images and try out each of the creation options that
>> qcow2 provides (except backing_file/fmt for now)
>>
>> I'm not totally happy with the behaviour of
Am 19.01.2013 17:01, schrieb Blue Swirl:
> Perform input tests on random data.
>
> Improvement to code coverage for qapi/string-input-visitor.c
> is about 3 percentage points.
>
> Signed-off-by: Blue Swirl
Does this test pass for you? It consistently segfaults for me.
/string-visitor/input/fuz
Am 01.02.2013 22:51, schrieb Stefan Weil:
> Only C99 comments remain unfixed.
>
> Signed-off-by: Stefan Weil
> ---
> block/vpc.c | 94
> +--
> 1 file changed, 52 insertions(+), 42 deletions(-)
> @@ -578,8 +589,8 @@ static int calculate_
Am 01.02.2013 22:51, schrieb Stefan Weil:
> Signed-off-by: Stefan Weil
> ---
> block/vpc.c |3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/block/vpc.c b/block/vpc.c
> index 1c55c21..4565723 100644
> --- a/block/vpc.c
> +++ b/block/vpc.c
> @@ -21,6 +21,9 @@
> * LIABILITY, WHETHER
Am 01.02.2013 22:51, schrieb Stefan Weil:
> * Always read the footer at the end of the image.
> The footer exists for all kinds of VHD images, so there is no need
> to read its copy at the start of dynamic VHD images.
>
> * Return error codes from bdrv_pread like in other block drivers.
>
> *
Am 01.02.2013 22:51, schrieb Stefan Weil:
> The size calculated from the CHS values is not the real image (disk) size,
> but usually a smaller value (this is caused by rounding effects).
>
> Only older operating systems use CHS. Such guests won't be able to use
> the whole disk.
>
> This patch fi
Am 05.02.2013 12:10, schrieb Stefan Weil:
> Am 05.02.2013 11:54, schrieb Kevin Wolf:
>> Am 01.02.2013 22:51, schrieb Stefan Weil:
>>> The size calculated from the CHS values is not the real image (disk) size,
>>> but usually a smaller value (this is caused by rounding e
Am 01.02.2013 22:51, schrieb Stefan Weil:
> QEMU now gets the correct size for VHD images, so this workaround is no
> longer needed.
>
> Signed-off-by: Stefan Weil
This isn't about qemu, but about VPC. Whether we need this code is
probably closely related to whether patch 5 is correct.
Kevin
Am 29.01.2013 17:24, schrieb Eric Blake:
> On 01/29/2013 07:27 AM, Benoît Canet wrote:
>>> base1 [file] --- base1 [qcow2] --- snap1.qcow2 --\
>>> base2 [file] --- base2 [qcow2] --- snap2.qcow2 --->-- quorum
>>> base3 [file] --- base3 [qcow2] --- snap3.qcow2 --/
>
> For that matter, I think it woul
Am 05.02.2013 16:12, schrieb Markus Armbruster:
> Stefan Hajnoczi writes:
>
>> Linux block devices can be set read-only with "blockdev --setro
>> ". The same thing can be done for LVM volumes using "lvchange
>> --permission r ". This read-only setting is independent of
>> device node permission
Am 06.02.2013 11:58, schrieb Stefan Hajnoczi:
> The qemu-img check printf() statement that shows BlockFragInfo results
> is poorly formatted. Introduce a local variable to shorten the lines
> and restore proper indentation.
>
> The next patch adds a field to BlockFragInfo so it is beneficial to
>
Am 05.02.2013 19:54, schrieb Stefan Hajnoczi:
> Show how many clusters are compressed. This can be used to monitor how
> many compressed clusters remain and whether to recompress the image.
>
> Suggested-by: Cole Robinson
> Signed-off-by: Stefan Hajnoczi
> diff --git a/qemu-img.c b/qemu-img.c
Am 06.02.2013 14:35, schrieb Eric Blake:
> On 02/06/2013 04:30 AM, Kevin Wolf wrote:
>
>>>
>>> -if (result.bfi.total_clusters != 0 && result.bfi.allocated_clusters !=
>>> 0) {
>>> -printf("%" PRId64
Am 06.02.2013 14:40, schrieb Eric Blake:
> On 02/06/2013 04:43 AM, Kevin Wolf wrote:
>>
>> Instead of getting a longer and longer output line for each new number
>> we add, maybe we could use the chance to introduce multiline output:
>>
>> Total number o
Am 06.02.2013 15:56, schrieb Eric Blake:
> On 02/06/2013 06:45 AM, Kevin Wolf wrote:
>>>> Can you add a space before the '=' while touching this?
>>>
>>> Perhaps he can, but as this is user-visible output, and we don't yet
>>> have
Am 28.01.2013 12:59, schrieb Federico Simoncelli:
> This patch adds the support for reporting the image end offset (in
> bytes). This is particularly useful after a conversion (or a rebase)
> where the destination is a block device in order to find the first
> unused byte at the end of the image.
>
Am 06.02.2013 17:39, schrieb Paolo Bonzini:
> In order to finish the implementation of thin provisioning, we need to
> add a -drive option to describe how guest discard requests are mapped to
> host requests.
>
> We have three possibilities:
>
> - hide them and make them always succeed
> - transl
Am 06.02.2013 21:02, schrieb Luiz Capitulino:
> This reverts commit 9ca111544c64b5abed2e79cf52e19a8f227b347b.
>
> That commit has added a weird side effect to QMP: on shutdown,
> QMP emits the DEVICE_TRAY_MOVED event for all empty drives
> that have closed trays.
>
> This happens because the tray
Am 07.02.2013 14:15, schrieb Luiz Capitulino:
> On Thu, 07 Feb 2013 14:12:10 +0100
> Kevin Wolf wrote:
>> I think the right solution is to move the bdrv_dev_change_media_cb()
>> call to those callers of bdrv_close() that actually need it. I haven't
>> checked it ye
Am 07.02.2013 20:26, schrieb Stefan Weil:
> From: Stefan Weil
>
> The size calculated from the CHS values is not the real image (disk) size,
> but usually a smaller value. This is caused by rounding effects.
>
> Only older operating systems use CHS. Such guests won't be able to use
> the whole d
Am 28.01.2013 18:07, schrieb Benoît Canet:
> Signed-off-by: Benoit Canet
> ---
> block/Makefile.objs |1 +
> block/quorum.c | 45 +
> 2 files changed, 46 insertions(+)
> create mode 100644 block/quorum.c
>
> diff --git a/block/Makefile.objs
Am 28.01.2013 18:07, schrieb Benoît Canet:
> Signed-off-by: Benoit Canet
> ---
> block/quorum.c | 22 ++
> 1 file changed, 22 insertions(+)
>
> diff --git a/block/quorum.c b/block/quorum.c
> index 8dc6e4c..d8fffbe 100644
> --- a/block/quorum.c
> +++ b/block/quorum.c
> @@ -1
Am 28.01.2013 18:07, schrieb Benoît Canet:
> Signed-off-by: Benoit Canet
> ---
> block/quorum.c | 111
>
> 1 file changed, 111 insertions(+)
>
> diff --git a/block/quorum.c b/block/quorum.c
> index d8fffbe..5d8470b 100644
> --- a/block/q
Am 28.01.2013 18:07, schrieb Benoît Canet:
> Signed-off-by: Benoit Canet
> ---
> block/quorum.c | 38 +-
> 1 file changed, 37 insertions(+), 1 deletion(-)
>
> diff --git a/block/quorum.c b/block/quorum.c
> index 5d8470b..e3c6aad 100644
> --- a/block/quorum.c
Am 28.01.2013 18:07, schrieb Benoît Canet:
> Use gnutls's SHA-256 to compare versions.
>
> Signed-off-by: Benoit Canet
> ---
> block/quorum.c | 303
> +++-
> configure | 22
> 2 files changed, 324 insertions(+), 1 deletion(-)
>
>
Am 28.01.2013 18:07, schrieb Benoît Canet:
> Check that every bs file return the same length.
> If not return -EIO to disable the quorum and
> avoid length discrepancy.
>
> Signed-off-by: Benoit Canet
> ---
> block/quorum.c | 20
> 1 file changed, 20 insertions(+)
>
> dif
Am 28.01.2013 18:07, schrieb Benoît Canet:
> Signed-off-by: Benoit Canet
> ---
> block/quorum.c | 53 +
> 1 file changed, 53 insertions(+)
>
> diff --git a/block/quorum.c b/block/quorum.c
> index 1c50ed5..459434f 100644
> --- a/block/quorum.c
Am 28.01.2013 18:07, schrieb Benoît Canet:
> Makes a vote to select error if any.
>
> Signed-off-by: Benoit Canet
> ---
> block/quorum.c | 34 ++
> 1 file changed, 34 insertions(+)
>
> diff --git a/block/quorum.c b/block/quorum.c
> index 459434f..306a2df 100644
Am 08.02.2013 18:43, schrieb Stefan Weil:
> Am 08.02.2013 13:14, schrieb Jeff Cody:
>> On Fri, Feb 08, 2013 at 09:38:47AM +0100, Kevin Wolf wrote:
>>> Am 07.02.2013 20:26, schrieb Stefan Weil:
>>>> From: Stefan Weil
>>>>
>>>> The size calc
Am 09.02.2013 17:44, schrieb Stefan Hajnoczi:
> bdrv_co_io_em(), bdrv_co_flush(), and bdrv_co_discard() yield the
> coroutine when waiting for aio to complete. They do not check that the
> request has actually finished.
>
> In simple cases this works, but it returns early when we get spurious
> w
Am 11.02.2013 14:17, schrieb Stefan Hajnoczi:
> On Mon, Feb 11, 2013 at 1:42 PM, Paolo Bonzini wrote:
>> Il 11/02/2013 13:29, Kevin Wolf ha scritto:
>>> The bug is not in this function but in process_incoming_migration(). It
>>> should never blindly enter a coroutine w
Am 11.02.2013 14:27, schrieb Stefan Hajnoczi:
> On Sun, Feb 10, 2013 at 11:12:11PM +0100, Hervé Poussineau wrote:
>>
>> Signed-off-by: Hervé Poussineau
>> ---
>> hw/ide/core.c |4 +++-
>> 1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/hw/ide/core.c b/hw/ide/core.c
>> index
Am 11.02.2013 13:42, schrieb Paolo Bonzini:
> Il 11/02/2013 13:29, Kevin Wolf ha scritto:
>> The bug is not in this function but in process_incoming_migration(). It
>> should never blindly enter a coroutine which is in an unknown state.
>
> process_incoming_migration()
Am 11.02.2013 17:01, schrieb Stefan Hajnoczi:
> The incoming migration is processed in a coroutine and uses an fd read
> handler to enter the yielded coroutine when data becomes available.
>
> The read handler was set too broadly, so that spurious coroutine entries
> were be triggered if other cor
Am 11.02.2013 20:38, schrieb Jeff Cody:
> I've done some testing back and forth between VPC, Win Server 2012
> Hyper-V, and qemu/kvm with and without this patch applied.
First of all, thanks a lot for doing all the testing!
> The short: this patch will break Virtual PC VHD compatibility (as it
>
Am 11.02.2013 22:14, schrieb Anthony Liguori:
> Paolo Bonzini writes:
>
>> Il 11/02/2013 21:13, Anthony Liguori ha scritto:
>>> Applied. Thanks.
>>>
>>> Regards,
>>>
>>> Anthony Liguori
>>
>> I guess this was a mistake, please revert.
>
> No, it wasn't. The patch was reviewed and tested. What
Am 11.02.2013 22:33, schrieb Stefan Weil:
> Does the patch really break Virtual PC VHD compatibility?
>
> Or does VPC simply pass the size calculated from CHSto the
> guest - no matter how the disk image was created?In this case
> I see no need that QEMU must show the same behaviour.
> It's import
Am 12.02.2013 08:00, schrieb Miroslav Rezanina:
> There can be a need to turn output to stdout off. This patch adds a -q option
> that enable "Quiet mode". In Quiet mode, only errors are printed out.
>
> Signed-off-by: Miroslav Rezanina
It feels a bit odd that the quiet flag takes effect in JSON
Am 12.02.2013 08:00, schrieb Miroslav Rezanina:
> Signed-off-by: Miroslav Rezanina
What happened to the commit message here? Previous versions had
"qemu-img: Add compare subcommand" as their subject and what is now the
subject was the body. Made much more sense.
Stefan, if you apply the series,
Am 12.02.2013 08:00, schrieb Miroslav Rezanina:
> Simple test for qemu-img compare to check it's working correctly.
>
> Signed-off-by: Miroslav Rezanina
> ---
> tests/qemu-iotests/048 | 77
>
> tests/qemu-iotests/048.out | 25 ++
>
ged, 626 insertions(+), 70 deletions(-)
> create mode 100755 tests/qemu-iotests/048
> create mode 100644 tests/qemu-iotests/048.out
I had only minor comments that could as well be addressed on top.
Reviewed-by: Kevin Wolf
| 42 --
> include/block/block.h| 1 +
> qapi-schema.json | 6 +-
> qemu-img.c | 12 ++++----
> tests/qemu-iotests/044.out | 1 +
> tests/qemu-iotests/common.rc | 2 +-
> 6 files changed, 52 insertions(+), 12 deletions(-)
Reviewed-by: Kevin Wolf
Am 13.02.2013 09:09, schrieb Miroslav Rezanina:
> Simple test for qemu-img compare to check it's working correctly.
>
> Signed-off-by: Miroslav Rezanina
> ---
> tests/qemu-iotests/048 | 78
>
> tests/qemu-iotests/048.out | 31
emu-img.texi | 56 ++
> tests/qemu-iotests/048 | 78
> tests/qemu-iotests/048.out | 31 +++
> tests/qemu-iotests/group |1 +
> 9 files changed, 633 insertions(+), 70 deletions(-)
> create mode 100755 tests/qemu-iotests/048
> create mode 100644 tests/qemu-iotests/048.out
Reviewed-by: Kevin Wolf
uired, allocate new clusters
Changing the code to reflect this doesn't change the behaviour because
overlaps cannot exist for clusters that are kept in step 2. It does
however make it easier for later patches to work on clusters that belong
to an allocation that is still in flight.
Signed-off-by:
The old code detected an overlapping allocation even when the
allocations didn't actually overlap, but were only adjacent.
Signed-off-by: Kevin Wolf
---
block/qcow2-cluster.c |2 +-
tests/qemu-iotests/038.out | 10 +-
2 files changed, 6 insertions(+), 6 deletions(-)
ds to make things look more
uniform. A later patch will turn the whole thing into a loop and then
it actually starts making sense.
Signed-off-by: Kevin Wolf
---
block/qcow2-cluster.c | 82 +
1 files changed, 28 insertions(+), 54 deletions(-)
diff --
Not exactly bisectable, but one large patch isn't much better either :-(
m->error is used to allow bdrv_drain() to stop with l2meta in error
state rather than go into an endless loop.
Signed-off-by: Kevin Wolf
---
block/qcow2.c | 44
block
still running after bdrv_drain_all
(e.g. when the VM is stopped).
Signed-off-by: Kevin Wolf
---
block.c |5 ++
block/qcow2.c | 131 ++---
block/qcow2.h |8 +++
include/block/block_int.h |3 +
4 files ch
This patch is mainly to separate the indentation change from the
semantic changes. All that really changes here is that everything moves
into a while loop, all 'goto done' become 'break' and at the end of the
loop a new 'break is inserted.
Signed-off-by: Kevin Wolf
-
ned-off-by: Kevin Wolf
---
block/qcow2-cluster.c | 39 +++
block/qcow2.c |2 ++
block/qcow2.h | 19 +++
3 files changed, 60 insertions(+), 0 deletions(-)
diff --git a/block/qcow2-cluster.c b/block/qcow2-cluster.c
ind
handle_copied() uses its bytes parameter now to determine how many
clusters it should try to find.
Signed-off-by: Kevin Wolf
---
block/qcow2-cluster.c | 24 ++--
1 files changed, 18 insertions(+), 6 deletions(-)
diff --git a/block/qcow2-cluster.c b/block/qcow2-cluster.c
Just create lots of images and try out each of the creation options that
qcow2 provides (except backing_file/fmt for now)
I'm not totally happy with the behaviour of qemu-img in each of the
cases, but let's be explicit and update the test when we do change
things later.
Signed-off-by:
is non-deterministic therefore.
Kevin Wolf (23):
qcow2: Handle dependencies earlier
qcow2: Improve check for overlapping allocations
qcow2: Change handle_dependency to byte granularity
qcow2: Decouple cluster allocation from cluster reuse code
qcow2: Factor out handle_alloc()
qco
The interface works completely on a byte granularity now and duplicated
parameters are removed.
Signed-off-by: Kevin Wolf
---
block/qcow2-cluster.c | 29 -
block/qcow2.h |5 +
2 files changed, 21 insertions(+), 13 deletions(-)
diff --git a/block
Signed-off-by: Kevin Wolf
---
block/qcow2-cluster.c | 240 +++--
trace-events |1 +
2 files changed, 152 insertions(+), 89 deletions(-)
diff --git a/block/qcow2-cluster.c b/block/qcow2-cluster.c
index 5c4b7cc..919cb39 100644
--- a/block
an do better: Just cancel
the COW instead of waiting for it and then overwriting the same area
with the second write request.
Signed-off-by: Kevin Wolf
---
block/qcow2-cluster.c | 150
block/qcow2.c | 16 +
block/qcow2.h |
We already communicate the same information in *bytes.
Signed-off-by: Kevin Wolf
---
block/qcow2-cluster.c | 19 +++
1 files changed, 15 insertions(+), 4 deletions(-)
diff --git a/block/qcow2-cluster.c b/block/qcow2-cluster.c
index 919cb39..2492235 100644
--- a/block/qcow2
Signed-off-by: Kevin Wolf
---
block/qcow2-cluster.c | 133 ++---
trace-events |1 +
2 files changed, 94 insertions(+), 40 deletions(-)
diff --git a/block/qcow2-cluster.c b/block/qcow2-cluster.c
index 0642ffa..cdbce20 100644
--- a/block
This moves some code that prepares the allocation of new clusters to
where the actual allocation happens. This is the minimum required to be
able to move it to a separate function in the next patch.
Signed-off-by: Kevin Wolf
---
block/qcow2-cluster.c | 35
Signed-off-by: Kevin Wolf
---
block/qcow2-cluster.c | 47 +++
block/qcow2.c | 28 +---
block/qcow2.h | 14 ++
3 files changed, 86 insertions(+), 3 deletions(-)
diff --git a/block/qcow2
Signed-off-by: Kevin Wolf
---
tests/qemu-iotests/046 | 19 +++
tests/qemu-iotests/046.out | 16
2 files changed, 35 insertions(+), 0 deletions(-)
diff --git a/tests/qemu-iotests/046 b/tests/qemu-iotests/046
index e0176f4..6c73675 100755
--- a/tests/qemu
Instead of expecting a single l2meta, have a list of them. This allows
to still have a single I/O request for the guest data, even though
multiple l2meta may be needed in order to describe both a COW overwrite
and a new cluster allocation (typical sequential write case).
Signed-off-by: Kevin Wolf
te of one cluster with the allocation of the next cluster.
Only by avoiding splitting requests this way Delayed COW actually starts
improving performance noticably.
Signed-off-by: Kevin Wolf
---
block/qcow2-cluster.c | 66 ++--
1 files changed, 30 inser
Look only for clusters that start at a given physical offset.
Signed-off-by: Kevin Wolf
---
block/qcow2-cluster.c | 26 ++
1 files changed, 18 insertions(+), 8 deletions(-)
diff --git a/block/qcow2-cluster.c b/block/qcow2-cluster.c
index 5ce2c88..90fe36c 100644
--- a
Signed-off-by: Kevin Wolf
---
block/qcow2-cluster.c | 40
block/qcow2.h | 11 +++
2 files changed, 39 insertions(+), 12 deletions(-)
diff --git a/block/qcow2-cluster.c b/block/qcow2-cluster.c
index 0e804ba..a3b2447 100644
--- a/block
Now *bytes is used to return the length of the area that can be written
to without performing an allocation or COW.
Signed-off-by: Kevin Wolf
---
block/qcow2-cluster.c | 23 +--
1 files changed, 13 insertions(+), 10 deletions(-)
diff --git a/block/qcow2-cluster.c b/block
Things can be simplified a bit now. No semantic changes.
Signed-off-by: Kevin Wolf
---
block/qcow2-cluster.c | 110 +++-
1 files changed, 53 insertions(+), 57 deletions(-)
diff --git a/block/qcow2-cluster.c b/block/qcow2-cluster.c
index e32bfe3
handle_alloc() is now called with the offset at which the actual new
allocation starts instead of the offset at which the whole write request
starts, part of which may already be processed.
Signed-off-by: Kevin Wolf
---
block/qcow2-cluster.c | 44
oczi (2):
> block: use Error in do_check_io_limits()
> block: refuse negative iops and bps values
>
> blockdev.c | 24 ++--
> 1 file changed, 18 insertions(+), 6 deletions(-)
Reviewed-by: Kevin Wolf
Am 13.02.2013 22:17, schrieb Blue Swirl:
> On Wed, Feb 13, 2013 at 1:22 PM, Kevin Wolf wrote:
>> Look only for clusters that start at a given physical offset.
>>
>> Signed-off-by: Kevin Wolf
>> ---
>> block/qcow2-cluster.c | 26 ++
&
Am 14.02.2013 11:43, schrieb Stefan Hajnoczi:
> On Wed, Feb 13, 2013 at 02:21:50PM +0100, Kevin Wolf wrote:
>> iozone results with and without this series show significant difference
>> for allocating writes:
>>
>>
On Thu, Feb 14, 2013 at 03:48:51PM +0100, Stefan Hajnoczi wrote:
> On Wed, Feb 13, 2013 at 02:21:53PM +0100, Kevin Wolf wrote:
> > Signed-off-by: Kevin Wolf
> > ---
> > block/qcow2-cluster.c | 40
> > block/qcow2.h
On Thu, Feb 14, 2013 at 09:40:22PM +, Blue Swirl wrote:
> On Thu, Feb 14, 2013 at 9:40 AM, Kevin Wolf wrote:
> > Am 13.02.2013 22:17, schrieb Blue Swirl:
> >> On Wed, Feb 13, 2013 at 1:22 PM, Kevin Wolf wrote:
> >>> Look only for clusters that st
On Fri, Feb 15, 2013 at 12:54:51PM +0100, Paolo Bonzini wrote:
> Il 15/02/2013 12:18, Peter Lieven ha scritto:
> >>>
> >>> +task = iscsi_readcapacity16_task(iscsilun->iscsi, iscsilun->lun,
> >>> + iscsi_readcapacity16_cb, &itask);
> >>
> >> You can use iscsi_read
On Fri, Feb 15, 2013 at 02:36:37PM +0100, Stefan Hajnoczi wrote:
> On Wed, Feb 13, 2013 at 02:22:08PM +0100, Kevin Wolf wrote:
> > /**
> > + * true if the request is sleeping in the COW delay and the coroutine
> > may
> > + * be reentered i
On Fri, Feb 15, 2013 at 10:16:11PM +0100, Stefan Weil wrote:
> It looks like most (but not all) versions of gcc emit built-in code
> for ffs() even for compilations without optimisation. I have to provide
> additional compiler options (e.g. -fno-builtin-ffs) to get a real
> function call.
> Only th
The F18 mingw cross compiler warns on this one. Probably a good idea to
fix it.
Signed-off-by: Kevin Wolf
---
main-loop.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/main-loop.c b/main-loop.c
index 6f52ac3..c9fd77a 100644
--- a/main-loop.c
+++ b/main-loop.c
@@ -330,7
On Tue, Feb 19, 2013 at 09:30:41AM +0100, Stefan Hajnoczi wrote:
> On Mon, Feb 18, 2013 at 05:57:03PM -0600, Anthony Liguori wrote:
> > 'de_DE' is only missing:
> >
> > - Zoom to Fit
- Auf Fenstergröße skalieren
> > - Grab on Hover
- Tastatur automatisch einfangen
> > Kevin/Stefan/et al, could
601 - 700 of 24367 matches
Mail list logo
