[PATCH] hmp: allow filtering `info tlb` entries by address on i386

2024-08-24 Thread Josh Junon
This change adds an optional virtual address parameter to the `info tlb` monitor command on i386 targets, only printing a specific entry if found. Signed-off-by: Josh Junon --- hmp-commands-info.hx | 5 + target/i386/monitor.c | 45 +++ 2 files

[PATCH] qmp: Add 'memtranslate' QMP command

2024-07-30 Thread Josh Junon
perly handling higher-half virtual addresses correctly, namely when used over QMP/the monitor. The use and assumption of signed integers caused issues when parsing otherwise valid virtual addresses that instead caused signed integer overflow or ERANGE errors. Signed-off-by: Josh Junon --- docs/devel/

[PATCH] qmp: Fix higher half vaddrs for [p]memsave

2024-07-31 Thread Josh Junon
Previously, int64_t's were used when parsing virtual / physical addresses for the [p]memsave commands over QMP (HMP was unaffected). This caused issues when the virtual addresses were in the higher half of a 64-bit address space, as various portions of the parsing code would consider them out of bo

Re: [PATCH] qmp: Fix higher half vaddrs for [p]memsave

2024-08-02 Thread Josh Junon
On Fri, Aug 02, 2024 at 01:39:15PM +0200, Markus Armbruster wrote: > Josh Junon writes: > > > Previously, int64_t's were used when parsing virtual / physical > > addresses for the [p]memsave commands over QMP (HMP was unaffected). > > This caused issues when the

[PATCH v2] qmp: Use unsigned integers for address parameters

2024-08-02 Thread Josh Junon
Fixes higher-half address parsing for QMP commands `[p]memsave` and `dump-guest-memory`. Signed-off-by: Josh Junon --- dump/dump.c | 4 ++-- qapi/dump.json| 2 +- qapi/machine.json | 11 +-- system/cpus.c | 8 4 files changed, 16 insertions(+), 9 deletions

[PATCH v3] qmp: Use unsigned integers for address parameters

2024-08-02 Thread Josh Junon
Fixes higher-half address parsing for QMP commands `[p]memsave`. Signed-off-by: Josh Junon --- qapi/machine.json | 11 +-- system/cpus.c | 10 +- 2 files changed, 14 insertions(+), 7 deletions(-) diff --git a/qapi/machine.json b/qapi/machine.json index fcfd249e2d

Re: [PATCH v3] qmp: Use unsigned integers for address parameters

2024-08-02 Thread Josh Junon
On Fri, Aug 02, 2024 at 04:18:40PM +0200, Markus Armbruster wrote: > Let's go back to v1's title > > qmp: Fix higher half vaddrs for [p]memsave > > Josh Junon writes: > > > Fixes higher-half address parsing for QMP commands > > `[p]mem