On Mon, Sep 28, 2015 at 04:38:03PM +0300, Riku Voipio wrote:
> Applied to linux-user tree, thanks.
Thanks.
> For next time, use three dashes "---" to separate version-to-version
> change descriptions from commit messages. This way git will
> automatically leave them out when doing git am.
Ok, I'
On Fri, Sep 04, 2015 at 01:48:39PM +0100, Peter Maydell wrote:
> On 3 September 2015 at 06:27, Jonathan Neuschäfer
> wrote:
> > Currently, __target_cmsg_nxthdr compares a pointer derived from
> > target_cmsg against the msg_control field of target_msgh (through
> > subtra
On Mon, Sep 21, 2015 at 12:45:21PM -0700, Riku Voipio wrote:
> On Mon, Sep 21, 2015 at 06:13:57AM -0700, Peter Maydell wrote:
> > On 20 September 2015 at 22:34, Jonathan Neuschäfer
[...]
> > > What's the status of this patch?
>
> > It's waiting for Riku to
address space were not the same. This patch adds a g2h()
address translation around the msg_control value.
Signed-off-by: Jonathan Neuschäfer
---
linux-user/syscall_defs.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/linux-user/syscall_defs.h b/linux-user/syscall_defs.h
index
After following your advice, I found two more bugs in related code,
which I had to fix. I probably missed something, but my test case
(wine), which receives two headers via a single recvmsg call, is now
working properly. Perhaps an isolated test case would be nice.
I'll send my new patch soon.
Regards,
Jonathan Neuschäfer
et_cmsghdr)" twice anymore.
Signed-off-by: Jonathan Neuschäfer
--
Changes since v1:
- Follow Peter Maydell's advice on how to fix the first bug
- The "two more related bugs"
---
linux-user/syscall.c | 14 +-
linux-user/syscall_defs.h | 9 +
2 file
On Tue, Sep 01, 2015 at 04:45:12PM +0100, Peter Maydell wrote:
> Code-wise this looks good; thanks. There are a few minor style
> nits caught by scripts/checkpatch.pl, which it would be nice if
> you can fix. (They're mostly things that were present in the code
> already, but we like to fix the sty
et_cmsghdr)" twice anymore.
Signed-off-by: Jonathan Neuschäfer
--
Changes since v2:
- The patch is now clean WRT checkpatch.pl
Changes since v1:
- Follow Peter Maydell's advice on how to fix the first bug
- The "two more related bugs"
---
linux-user/syscall.c | 14 +--
t; Signed-off-by: Li Qiang
> ---
> hw/audio/ac97.c | 8
> 1 file changed, 8 insertions(+)
Regards,
Jonathan Neuschäfer
signature.asc
Description: PGP signature
tmp += 1
atomic_set(&sl->sequence, tmp)
atomic_set(&sl->sequence, tmp)
... where sl->sequence will effectively only be incremented once (as far
as I can see).
Regards,
Jonathan Neuschäfer
signature.asc
Description: PGP signature
On Fri, Sep 30, 2016 at 11:45:19PM +0100, Alex Bennée wrote:
>
> Jonathan Neuschäfer writes:
>
> > On Fri, Sep 30, 2016 at 10:30:56PM +0100, Alex Bennée wrote:
> >> From: Paolo Bonzini
> >>
> >> There is a data race if the sequence is written concu
nformation I removed (e.g. basic
> block unchaining) was obsolete.
>
> Signed-off-by: Paolo Bonzini
> ---
[...]
> +@item Threading:
> +On Linux, QEMU can emulate the @code{clone} and create a real host
s/@code{clone}/@code{clone} syscall/ ?
Thanks for reworking the documentation!
iliang
[...]
> +COLO Proxy:
> +Delivers packets to Primary and Seconday, and then compare the responses from
"Secondary"
> +both side. Then decide whether to start a checkpoint according to some rules.
"both sides"
Thanks,
Jonathan Neuschäfer
signature.asc
Description: PGP signature
Signed-off-by: Jonathan Neuschäfer
---
CODING_STYLE | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/CODING_STYLE b/CODING_STYLE
index e7fde15..a03a994 100644
--- a/CODING_STYLE
+++ b/CODING_STYLE
@@ -9,7 +9,7 @@ patches before submitting.
Of course, the most important aspect
On Thu, Sep 29, 2016 at 06:14:49PM -0300, Eduardo Habkost wrote:
> Add a new test case to ensure the existing behavior of the
> feature parsing code wlil be kept.
s/wlil/will/
>
> Signed-off-by: Eduardo Habkost
Jonathan Neuschäfer
signature.asc
Description: PGP signature
On Thu, Sep 29, 2016 at 03:14:45PM -0700, Peter Maydell wrote:
> On 29 September 2016 at 13:46, Jonathan Neuschäfer
> wrote:
> > Signed-off-by: Jonathan Neuschäfer
> > ---
> > CODING_STYLE | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> >
Signed-off-by: Jonathan Neuschäfer
---
v2:
- Preserve the poetic sound of "Many a flamewar", which Peter Maydell
pointed out.
---
CODING_STYLE | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/CODING_STYLE b/CODING_STYLE
index e7fde15..f53180b 100644
--- a/CODING_S
tatic void passthru_exitfn(CCIDCardState *base)
> {
> -return 0;
> +return;
> }
Have you compile-tested this change? I think you'll have to adjust the
definition of exitfn in CCIDCardClass, and ccid_card_exitfn (in
hw/usb/dev-smartcard-reader.c) as well.
Regards,
Jonathan Neuschäfer
signature.asc
Description: PGP signature
18 matches
Mail list logo
