[PATCH v5 2/2] hw: hyperv: vmbus: Fix 32bit compilation

2020-07-15 Thread Jon Doron
Signed-off-by: Jon Doron --- hw/hyperv/vmbus.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/hyperv/vmbus.c b/hw/hyperv/vmbus.c index 34392e892a..c28bb4201b 100644 --- a/hw/hyperv/vmbus.c +++ b/hw/hyperv/vmbus.c @@ -383,7 +383,8 @@ static ssize_t gpadl_iter_io

[PATCH v1 0/1] hyperv: Enable SCONTROL if SYNIC is enabled

2020-07-17 Thread Jon Doron
with the value of 0x1, aka HV_SYNIC_CONTROL_ENABLE. It's important to note that this diverges from the value states in the HyperV TLFS of 0. Jon Doron (1): hyperv: Enable SCONTROL if SYNIC is enabled target/i386/kvm.c | 2 ++ 1 file changed, 2 insertions(+) -- 2.24.1

[PATCH v1 1/1] hyperv: Enable SCONTROL if SYNIC is enabled

2020-07-17 Thread Jon Doron
with the value of 0x1, aka HV_SYNIC_CONTROL_ENABLE. It's important to note that this diverges from the value states in the HyperV TLFS of 0. Signed-off-by: Jon Doron --- target/i386/kvm.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/target/i386/kvm.c b/target/i386/kvm.c

Re: [PATCH v1 1/1] hyperv: Enable SCONTROL if SYNIC is enabled

2020-08-10 Thread Jon Doron
I think both patches are On Mon, Aug 10, 2020, 20:27 Paolo Bonzini wrote: > On 17/07/20 14:56, Jon Doron wrote: > > Based on an analysis of the HyperV firmwares (Gen1 and Gen2) it seems > > like the SCONTROL is not being set to the ENABLED state as like we have > > thought

Re: [Bug 1885247] [NEW] Build error in Intel 32-bit hosts

2020-06-26 Thread Jon Doron
Is there a container I can download which has your build environment? On Fri, Jun 26, 2020 at 12:27 PM Philippe Mathieu-Daudé wrote: > > On 6/26/20 11:20 AM, Thomas Huth wrote: > > On 26/06/2020 11.13, Philippe Mathieu-Daudé wrote: > >> On 6/26/20 9:37 AM, Aleksandar Markovic wrote: > >>> пет, 26

Re: Who uses TYPE_VMBUS_DEVICE?

2020-10-12 Thread Jon Doron
Hi Eduardo, Sorry for the late reply, in general there are also hv-net and hv-scsi implementations from Roman Kagan, which have not been merged in... I have a WIP component which does not use vmbus but Windows needs it to exist and function in order for it to work (it's the synthetic debugger int

[PATCH v1 3/5] vmbus: add vmbus protocol definitions

2020-04-03 Thread Jon Doron
Add a header with data structures and constants used in Hyper-V VMBus hypervisor <-> guest interactions. Based on the respective stuff from Linux kernel. Signed-off-by: Roman Kagan Signed-off-by: Jon Doron --- include/hw/vmbus/vmbus-proto.h | 222 +

[PATCH v1 1/5] hyperv: expose API to determine if synic is enabled

2020-04-03 Thread Jon Doron
Signed-off-by: Jon Doron --- hw/hyperv/hyperv.c | 8 include/hw/hyperv/hyperv.h | 1 + 2 files changed, 9 insertions(+) diff --git a/hw/hyperv/hyperv.c b/hw/hyperv/hyperv.c index 8ca3706f5b..ddf4f32c60 100644 --- a/hw/hyperv/hyperv.c +++ b/hw/hyperv/hyperv.c @@ -37,6 +37,13

[PATCH v1 0/5] hyperv: VMBus implementation

2020-04-03 Thread Jon Doron
This is a rebase of the old patchset from Roman for HyperV VMBus implementation. How to use: -device vmbus-bridge Later on new paravirtualized devices can be implemented on top of it (Network/SCSI/etc.) Jon Doron (5): hyperv: expose API to determine if synic is enabled hyperv: SControl is

[PATCH v1 2/5] hyperv: SControl is optional to enable SynIc

2020-04-03 Thread Jon Doron
pending flag. When the guest polls from the message slot, incase the pending flag is set it will write to the HV_X64_MSR_EOM indicating it has cleared the slow and we can try and push our message again. Signed-off-by: Jon Doron --- hw/hyperv/hyperv.c | 242

[PATCH v1 5/5] i386: Hyper-V VMBus ACPI DSDT entry

2020-04-03 Thread Jon Doron
particular, in parallel port conflicting with vmbus. TODO: discover and use spare IRQs to avoid conflicts. Signed-off-by: Evgeny Yakovlev Signed-off-by: Roman Kagan Signed-off-by: Jon Doron --- hw/i386/acpi-build.c | 42 ++ 1 file changed, 42 insertions(+) diff

[PATCH v1 4/5] vmbus: vmbus implementation

2020-04-03 Thread Jon Doron
-off-by: Roman Kagan Signed-off-by: Jon Doron --- Makefile.objs|1 + hw/Kconfig |1 + hw/Makefile.objs |1 + hw/i386/Kconfig |1 + hw/i386/pc_q35.c |2 + hw/vmbus/Kconfig |3 + hw/vmbus/Makefile.objs |1 + h

Re: [PATCH v1 5/5] i386: Hyper-V VMBus ACPI DSDT entry

2020-04-03 Thread Jon Doron
version of the patchset? Thanks, -- Jon. On Fri, Apr 3, 2020 at 5:56 PM Maciej S. Szmigiero wrote: > > Hi Jon, > > On 03.04.2020 16:23, Jon Doron wrote: > > Guest OS uses ACPI to discover vmbus presence. Add a corresponding > > entry to DSDT in case vmbus has been enabled

Re: [PATCH v1 5/5] i386: Hyper-V VMBus ACPI DSDT entry

2020-04-03 Thread Jon Doron
Thank you Maciej it seems like your version is really ahead I'll do the required work and merge it so i can submit a v2 with the latest patchset from Roman On Fri, Apr 3, 2020 at 6:06 PM Jon Doron wrote: > > Thank you Maciej, I based it on top of what Denis (d...@openvz.org) gave me

[PATCH v2 0/7] hyperv: VMBus implementation

2020-04-04 Thread Jon Doron
exposes this in the guest. More information about VMBus can be found in the file vmbuskernelmodeclientlibapi.h in Microsoft's WDK. Jon Doron (7): hyperv: expose API to determine if synic is enabled hyperv: SControl is optional to enable SynIc vmbus: add vmbus protocol defini

[PATCH v2 1/7] hyperv: expose API to determine if synic is enabled

2020-04-04 Thread Jon Doron
Signed-off-by: Jon Doron --- hw/hyperv/hyperv.c | 8 include/hw/hyperv/hyperv.h | 1 + 2 files changed, 9 insertions(+) diff --git a/hw/hyperv/hyperv.c b/hw/hyperv/hyperv.c index 8ca3706f5b..ddf4f32c60 100644 --- a/hw/hyperv/hyperv.c +++ b/hw/hyperv/hyperv.c @@ -37,6 +37,13

[PATCH v2 4/7] vmbus: vmbus implementation

2020-04-04 Thread Jon Doron
-off-by: Roman Kagan Signed-off-by: Maciej S. Szmigiero Signed-off-by: Jon Doron --- Makefile.objs|1 + hw/hyperv/Kconfig|5 + hw/hyperv/Makefile.objs |1 + hw/hyperv/trace-events | 18 + hw/hyperv/vmbus.c

[PATCH v2 3/7] vmbus: add vmbus protocol definitions

2020-04-04 Thread Jon Doron
Add a header with data structures and constants used in Hyper-V VMBus hypervisor <-> guest interactions. Based on the respective stuff from Linux kernel. Signed-off-by: Roman Kagan Signed-off-by: Maciej S. Szmigiero Signed-off-by: Jon Doron --- include/hw/hyperv/vmbus-proto.h

[PATCH v2 5/7] i386:pc: whitelist dynamic vmbus-bridge

2020-04-04 Thread Jon Doron
As vmbus-bridge is derived from sysbus device, it has to be whitelisted to be allowed to be created with -device. Signed-off-by: Roman Kagan Signed-off-by: Maciej S. Szmigiero Signed-off-by: Jon Doron --- hw/i386/pc_piix.c | 2 ++ hw/i386/pc_q35.c | 2 ++ 2 files changed, 4 insertions

[PATCH v2 2/7] hyperv: SControl is optional to enable SynIc

2020-04-04 Thread Jon Doron
pending flag. When the guest polls from the message slot, incase the pending flag is set it will write to the HV_X64_MSR_EOM indicating it has cleared the slow and we can try and push our message again. Signed-off-by: Jon Doron --- hw/hyperv/hyperv.c | 242

[PATCH v2 6/7] i386: Hyper-V VMBus ACPI DSDT entry

2020-04-04 Thread Jon Doron
-configurable via corresponding properties; use 7 and 13 by default. Signed-off-by: Evgeny Yakovlev Signed-off-by: Roman Kagan Signed-off-by: Maciej S. Szmigiero Signed-off-by: Jon Doron --- hw/hyperv/vmbus.c| 7 ++ hw/i386/acpi-build.c | 43

[PATCH v2 7/7] vmbus: add infrastructure to save/load vmbus requests

2020-04-04 Thread Jon Doron
This can be allow to include controller-specific data while saving/loading in-flight scsi requests of the vmbus scsi controller. Signed-off-by: Roman Kagan Signed-off-by: Maciej S. Szmigiero Signed-off-by: Jon Doron --- hw/hyperv/vmbus.c | 99

Re: [PATCH v1 5/5] i386: Hyper-V VMBus ACPI DSDT entry

2020-04-06 Thread Jon Doron
have Roman's "Signed-off-by:" > tags, > > > so I haven't applied mine, either. > > > > > > If you are able to establish a proper SoB chain then please also add: > > > "Signed-off-by: Maciej S. Szmigiero ". > > > > &g

[PATCH v3 0/7] hyperv: VMBus implementation

2020-04-06 Thread Jon Doron
exposes this in the guest. More information about VMBus can be found in the file vmbuskernelmodeclientlibapi.h in Microsoft's WDK. v3: Fixed an error asan v2: Rebased on top of latest patchset from Roman and Maciej Jon Doron (7): hyperv: expose API to determine if synic is enabled

[PATCH v3 3/7] vmbus: add vmbus protocol definitions

2020-04-06 Thread Jon Doron
Add a header with data structures and constants used in Hyper-V VMBus hypervisor <-> guest interactions. Based on the respective stuff from Linux kernel. Signed-off-by: Roman Kagan Signed-off-by: Maciej S. Szmigiero Signed-off-by: Jon Doron --- include/hw/hyperv/vmbus-proto.h

[PATCH v3 1/7] hyperv: expose API to determine if synic is enabled

2020-04-06 Thread Jon Doron
Signed-off-by: Jon Doron --- hw/hyperv/hyperv.c | 8 include/hw/hyperv/hyperv.h | 1 + 2 files changed, 9 insertions(+) diff --git a/hw/hyperv/hyperv.c b/hw/hyperv/hyperv.c index 8ca3706f5b..ddf4f32c60 100644 --- a/hw/hyperv/hyperv.c +++ b/hw/hyperv/hyperv.c @@ -37,6 +37,13

[PATCH v3 7/7] vmbus: add infrastructure to save/load vmbus requests

2020-04-06 Thread Jon Doron
This can be allow to include controller-specific data while saving/loading in-flight scsi requests of the vmbus scsi controller. Signed-off-by: Roman Kagan Signed-off-by: Maciej S. Szmigiero Signed-off-by: Jon Doron --- hw/hyperv/vmbus.c | 99

[PATCH v3 5/7] i386:pc: whitelist dynamic vmbus-bridge

2020-04-06 Thread Jon Doron
As vmbus-bridge is derived from sysbus device, it has to be whitelisted to be allowed to be created with -device. Signed-off-by: Roman Kagan Signed-off-by: Maciej S. Szmigiero Signed-off-by: Jon Doron --- hw/i386/pc_piix.c | 2 ++ hw/i386/pc_q35.c | 2 ++ 2 files changed, 4 insertions

[PATCH v3 2/7] hyperv: SControl is optional to enable SynIc

2020-04-06 Thread Jon Doron
pending flag. When the guest polls from the message slot, incase the pending flag is set it will write to the HV_X64_MSR_EOM indicating it has cleared the slow and we can try and push our message again. Signed-off-by: Jon Doron --- hw/hyperv/hyperv.c | 242

[PATCH v3 6/7] i386: Hyper-V VMBus ACPI DSDT entry

2020-04-06 Thread Jon Doron
-configurable via corresponding properties; use 7 and 13 by default. Signed-off-by: Evgeny Yakovlev Signed-off-by: Roman Kagan Signed-off-by: Maciej S. Szmigiero Signed-off-by: Jon Doron --- hw/hyperv/vmbus.c| 7 ++ hw/i386/acpi-build.c | 43

[PATCH v3 4/7] vmbus: vmbus implementation

2020-04-06 Thread Jon Doron
-off-by: Roman Kagan Signed-off-by: Maciej S. Szmigiero Signed-off-by: Jon Doron --- Makefile.objs|1 + hw/hyperv/Kconfig|5 + hw/hyperv/Makefile.objs |1 + hw/hyperv/trace-events | 18 + hw/hyperv/vmbus.c

Re: [PATCH v1 5/5] i386: Hyper-V VMBus ACPI DSDT entry

2020-04-07 Thread Jon Doron
On 07/04/2020, Maciej S. Szmigiero wrote: On 07.04.2020 20:56, Roman Kagan wrote: On Mon, Apr 06, 2020 at 11:20:39AM +0300, Jon Doron wrote: Well I want it to be merged in :-) Hmm I'm curious why, it has little to offer over virtio. Anyway the series you've posted seems to be

Re: [PATCH v1 5/5] i386: Hyper-V VMBus ACPI DSDT entry

2020-04-08 Thread Jon Doron
On 08/04/2020, Roman Kagan wrote: On Wed, Apr 08, 2020 at 07:16:39AM +0300, Jon Doron wrote: On 07/04/2020, Maciej S. Szmigiero wrote: > On 07.04.2020 20:56, Roman Kagan wrote: > > On Mon, Apr 06, 2020 at 11:20:39AM +0300, Jon Doron wrote: > > > Well I want it to be merged

Re: [PATCH v4 5/6] i386: Hyper-V VMBus ACPI DSDT entry

2020-05-05 Thread Jon Doron
o any changes so we can keep going forward with this. On Fri, 24 Apr 2020 15:34:43 +0300 Jon Doron wrote: Guest OS uses ACPI to discover VMBus presence. Add a corresponding entry to DSDT in case VMBus has been enabled. Experimentally Windows guests were found to require this entry to includ

Re: [PATCH v4 5/6] i386: Hyper-V VMBus ACPI DSDT entry

2020-05-06 Thread Jon Doron
ow if there is anything else. Thanks, -- Jon. On 06/05/2020, Maciej S. Szmigiero wrote: On 05.05.2020 17:38, Jon Doron wrote: On 05/05/2020, Igor Mammedov wrote: I dont know what were the original intentions of the original patch authors (at this point I simply rebased it, and to be honest

Re: [PATCH v1 5/5] i386: Hyper-V VMBus ACPI DSDT entry

2020-05-12 Thread Jon Doron
On 12/05/2020, Roman Kagan wrote: On Thu, Apr 09, 2020 at 06:35:18AM +0300, Jon Doron wrote: On 08/04/2020, Roman Kagan wrote: > On Wed, Apr 08, 2020 at 07:16:39AM +0300, Jon Doron wrote: > > Well I have implemented the hyperv synthetic kernel debugger interface, but > > o

Re: [PATCH v1 5/5] i386: Hyper-V VMBus ACPI DSDT entry

2020-05-12 Thread Jon Doron
On 12/05/2020, Jon Doron wrote: On 12/05/2020, Roman Kagan wrote: On Thu, Apr 09, 2020 at 06:35:18AM +0300, Jon Doron wrote: On 08/04/2020, Roman Kagan wrote: On Wed, Apr 08, 2020 at 07:16:39AM +0300, Jon Doron wrote: > Well I have implemented the hyperv synthetic kernel debugger interf

Re: [PATCH v4 5/6] i386: Hyper-V VMBus ACPI DSDT entry

2020-05-15 Thread Jon Doron
? Do we need a full emulation setup (aka your hv-scsi / hv-net) patches in order to see Windows working this ACPI entry? Thanks, -- Jon. On Mon, 11 May 2020 23:11:23 +0300 Roman Kagan wrote: On Thu, May 07, 2020 at 06:14:25AM +0300, Jon Doron wrote: > Igor it seems like the IRQ being used

Re: [PATCH v4 0/6] hyperv: VMBus implementation

2020-05-21 Thread Jon Doron
On 21/05/2020, Paolo Bonzini wrote: On 24/04/20 14:34, Jon Doron wrote: This is a rebase of the old patchset from Roman for HyperV VMBus implementation. How to use: -device vmbus-bridge Later on new paravirtualized devices can be implemented on top of it (Network/SCSI/etc.) VMBus is a

Re: [PATCH v4 5/6] i386: Hyper-V VMBus ACPI DSDT entry

2020-05-27 Thread Jon Doron
On 22/05/2020, Igor Mammedow wrote: On Thu, 21 May 2020 18:02:07 +0200 Paolo Bonzini wrote: On 13/05/20 17:34, Igor Mammedov wrote: > I'd rather avoid using random IRQ numbers (considering we are > dealing with black-box here). So if it's really necessary to have > IRQ described here, I'd sugg

Re: [PATCH v4 5/6] i386: Hyper-V VMBus ACPI DSDT entry

2020-05-27 Thread Jon Doron
On 28/05/2020, Jon Doron wrote: On 22/05/2020, Igor Mammedow wrote: On Thu, 21 May 2020 18:02:07 +0200 Paolo Bonzini wrote: On 13/05/20 17:34, Igor Mammedov wrote: I'd rather avoid using random IRQ numbers (considering we are dealing with black-box here). So if it's really necessa

Re: [PATCH v4 5/6] i386: Hyper-V VMBus ACPI DSDT entry

2020-05-28 Thread Jon Doron
On 28/05/2020, Igor Mammedov wrote: On Thu, 28 May 2020 08:26:42 +0300 Jon Doron wrote: On 22/05/2020, Igor Mammedow wrote: >On Thu, 21 May 2020 18:02:07 +0200 >Paolo Bonzini wrote: > >> On 13/05/20 17:34, Igor Mammedov wrote: >> > I'd rather avoid using rando

Re: [PATCH-for-5.0] gdbstub: Use correct address space with Qqemu.PhyMemMode packet

2020-05-31 Thread Jon Doron
On 31/05/2020, Philippe Mathieu-Daudé wrote: On 3/30/20 6:41 PM, Peter Maydell wrote: On Mon, 30 Mar 2020 at 17:21, Philippe Mathieu-Daudé wrote: On 3/30/20 6:08 PM, Peter Maydell wrote: On Mon, 30 Mar 2020 at 16:30, Philippe Mathieu-Daudé wrote: Since commit 3f940dc98, we added support fo

Re: [PATCH-for-5.0] gdbstub: Use correct address space with Qqemu.PhyMemMode packet

2020-06-01 Thread Jon Doron
On 31/05/2020, Peter Maydell wrote: On Sun, 31 May 2020 at 17:42, Jon Doron wrote: On 31/05/2020, Philippe Mathieu-Daudé wrote: >On 3/30/20 6:41 PM, Peter Maydell wrote: >> PS: do we have any documentation of this new command ? >> ab4752ec8d9 has the implementation but n

Re: [PATCH-for-5.0] gdbstub: Use correct address space with Qqemu.PhyMemMode packet

2020-06-01 Thread Jon Doron
On 01/06/2020, Alex Bennée wrote: Jon Doron writes: On 31/05/2020, Peter Maydell wrote: On Sun, 31 May 2020 at 17:42, Jon Doron wrote: On 31/05/2020, Philippe Mathieu-Daudé wrote: >On 3/30/20 6:41 PM, Peter Maydell wrote: >> PS: do we have any documentation of this ne

[v1] docs: Add to gdbstub documentation the PhyMemMode

2020-06-01 Thread Jon Doron
The PhyMemMode gdb extension command was missing from the gdb.rst document. Signed-off-by: Jon Doron --- docs/system/gdb.rst | 20 1 file changed, 20 insertions(+) diff --git a/docs/system/gdb.rst b/docs/system/gdb.rst index a40145fcf8..abda961e2b 100644 --- a/docs/system

[Qemu-devel] [PATCH v11 08/20] gdbstub: Implement set register (P pkt) with new infra

2019-05-24 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 39 ++- 1 file changed, 30 insertions(+), 9 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index c59a6765cd..1c210d671a 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1637,6 +1637,27 @@ static void handle_remove_bp

[Qemu-devel] [PATCH v11 04/20] gdbstub: Implement continue (c pkt) with new infra

2019-05-24 Thread Jon Doron
Signed-off-by: Jon Doron Reviewed-by: Alex Bennée --- gdbstub.c | 25 +++-- 1 file changed, 19 insertions(+), 6 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index b4c4bd4b08..698d6f558a 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1517,6 +1517,16 @@ static void

[Qemu-devel] [PATCH v11 02/20] gdbstub: Implement deatch (D pkt) with new infra

2019-05-24 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 93 +++ 1 file changed, 53 insertions(+), 40 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index e6d895177b..307366b250 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1413,11 +1413,6 @@ static inline int

[Qemu-devel] [PATCH v11 09/20] gdbstub: Implement get register (p pkt) with new infra

2019-05-24 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 50 ++ 1 file changed, 38 insertions(+), 12 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 1c210d671a..3284b3e01d 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1658,6 +1658,36 @@ static void

[Qemu-devel] [PATCH v11 00/20] gdbstub: Refactor command packets handler

2019-05-24 Thread Jon Doron
from Alex Bennee version 4-6 changes: - mostly feedback from Richard Henderson version 3 changes - Split the single patch to many individual patches for easier reviewing version 2 changes - Code convention fixes Jon Doron (20): gdbstub: Add infrastructure to parse cmd packets gdbstub

[Qemu-devel] [PATCH v11 05/20] gdbstub: Implement continue with signal (C pkt) with new infra

2019-05-24 Thread Jon Doron
Signed-off-by: Jon Doron Reviewed-by: Alex Bennée --- gdbstub.c | 34 +- 1 file changed, 29 insertions(+), 5 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 698d6f558a..f74a30da03 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1527,6 +1527,25 @@ static void

[Qemu-devel] [PATCH v11 19/20] gdbstub: Clear unused variables in gdb_handle_packet

2019-05-24 Thread Jon Doron
Signed-off-by: Jon Doron Reviewed-by: Alex Bennée --- gdbstub.c | 11 ++- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 097b7d1231..9dd934a079 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -2270,17 +2270,11 @@ static void handle_target_halt

[Qemu-devel] [PATCH v11 06/20] gdbstub: Implement set_thread (H pkt) with new infra

2019-05-24 Thread Jon Doron
Signed-off-by: Jon Doron Reviewed-by: Alex Bennée --- gdbstub.c | 83 +++ 1 file changed, 53 insertions(+), 30 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index f74a30da03..129a47230f 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1546,6

[Qemu-devel] [PATCH v11 12/20] gdbstub: Implement write all registers (G pkt) with new infra

2019-05-24 Thread Jon Doron
Signed-off-by: Jon Doron Reviewed-by: Alex Bennée --- gdbstub.c | 41 +++-- 1 file changed, 31 insertions(+), 10 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index c957b0d8a7..1afad31b49 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1737,6 +1737,29 @@ static

[Qemu-devel] [PATCH v11 01/20] gdbstub: Add infrastructure to parse cmd packets

2019-05-24 Thread Jon Doron
Signed-off-by: Jon Doron Reviewed-by: Alex Bennée --- gdbstub.c | 195 ++ 1 file changed, 195 insertions(+) diff --git a/gdbstub.c b/gdbstub.c index d54abd17cc..e6d895177b 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1268,6 +1268,201 @@ out

[Qemu-devel] [PATCH v11 07/20] gdbstub: Implement breakpoint commands (Z/z pkt) with new infra

2019-05-24 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 84 +++ 1 file changed, 66 insertions(+), 18 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 129a47230f..c59a6765cd 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -950,7 +950,7 @@ static inline int

[Qemu-devel] [PATCH v11 10/20] gdbstub: Implement write memory (M pkt) with new infra

2019-05-24 Thread Jon Doron
Signed-off-by: Jon Doron Reviewed-by: Alex Bennée --- gdbstub.c | 51 +-- 1 file changed, 33 insertions(+), 18 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 3284b3e01d..c798d93e22 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1688,6 +1688,31

[Qemu-devel] [PATCH v11 15/20] gdbstub: Implement step (s pkt) with new infra

2019-05-24 Thread Jon Doron
Signed-off-by: Jon Doron Reviewed-by: Alex Bennée --- gdbstub.c | 25 +++-- 1 file changed, 19 insertions(+), 6 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index b35acc679c..a8b81121c5 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1794,6 +1794,16 @@ static void

[Qemu-devel] [PATCH v11 03/20] gdbstub: Implement thread_alive (T pkt) with new infra

2019-05-24 Thread Jon Doron
Signed-off-by: Jon Doron Reviewed-by: Alex Bennée --- gdbstub.c | 43 --- 1 file changed, 32 insertions(+), 11 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 307366b250..b4c4bd4b08 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1493,6 +1493,30

[Qemu-devel] [PATCH v11 18/20] gdbstub: Implement target halted (? pkt) with new infra

2019-05-24 Thread Jon Doron
Note: The user-mode thread-id has been correctly reported since bd88c780e6 Signed-off-by: Jon Doron --- gdbstub.c | 35 +-- 1 file changed, 25 insertions(+), 10 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 57a05fd6a4..097b7d1231 100644 --- a/gdbstub.c

[Qemu-devel] [PATCH v11 16/20] gdbstub: Implement v commands with new infra

2019-05-24 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 170 +++--- 1 file changed, 110 insertions(+), 60 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index a8b81121c5..3773b23581 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1804,6 +1804,106 @@ static void

[Qemu-devel] [PATCH v11 13/20] gdbstub: Implement read all registers (g pkt) with new infra

2019-05-24 Thread Jon Doron
Signed-off-by: Jon Doron Reviewed-by: Alex Bennée --- gdbstub.c | 31 +++ 1 file changed, 23 insertions(+), 8 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 1afad31b49..781f5882ac 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1760,6 +1760,21 @@ static void

[Qemu-devel] [PATCH v11 11/20] gdbstub: Implement read memory (m pkt) with new infra

2019-05-24 Thread Jon Doron
Signed-off-by: Jon Doron Reviewed-by: Alex Bennée --- gdbstub.c | 48 1 file changed, 32 insertions(+), 16 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index c798d93e22..c957b0d8a7 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1713,6 +1713,30

[Qemu-devel] [PATCH v11 14/20] gdbstub: Implement file io (F pkt) with new infra

2019-05-24 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 48 ++-- 1 file changed, 26 insertions(+), 22 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 781f5882ac..b35acc679c 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1775,6 +1775,25 @@ static void

[Qemu-devel] [PATCH v11 20/20] gdbstub: Implement qemu physical memory mode

2019-05-24 Thread Jon Doron
isable Signed-off-by: Jon Doron --- gdbstub.c | 62 +-- 1 file changed, 60 insertions(+), 2 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 9dd934a079..c9269319d8 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -46,11 +46,27 @@ #define GDB_ATTAC

[Qemu-devel] [PATCH v11 17/20] gdbstub: Implement generic set/query (Q/q pkt) with new infra

2019-05-24 Thread Jon Doron
ing. gdb> maintenance packet Qqemu.sstep:HEX_VALUE Will change the single step mask. Signed-off-by: Jon Doron --- gdbstub.c | 559 -- 1 file changed, 373 insertions(+), 186 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 3773b23581..57a05

[Qemu-devel] [PATCH v12 09/20] gdbstub: Implement get register (p pkt) with new infra

2019-05-28 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 50 ++ 1 file changed, 38 insertions(+), 12 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index fc9526b3f5..07740ec0af 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1672,6 +1672,36 @@ static void

[Qemu-devel] [PATCH v12 01/20] gdbstub: Add infrastructure to parse cmd packets

2019-05-28 Thread Jon Doron
Signed-off-by: Jon Doron Reviewed-by: Alex Bennée --- gdbstub.c | 195 ++ 1 file changed, 195 insertions(+) diff --git a/gdbstub.c b/gdbstub.c index d54abd17cc..e6d895177b 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1268,6 +1268,201 @@ out

[Qemu-devel] [PATCH v12 00/20] gdbstub: Refactor command packets handler

2019-05-28 Thread Jon Doron
Henderson version 3 changes - Split the single patch to many individual patches for easier reviewing version 2 changes - Code convention fixes Jon Doron (20): gdbstub: Add infrastructure to parse cmd packets gdbstub: Implement deatch (D pkt) with new infra gdbstub: Implement thread_alive (T

[Qemu-devel] [PATCH v12 07/20] gdbstub: Implement breakpoint commands (Z/z pkt) with new infra

2019-05-28 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 86 +++ 1 file changed, 67 insertions(+), 19 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index db213cf173..57bfa4 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -950,7 +950,7 @@ static inline int

[Qemu-devel] [PATCH v12 04/20] gdbstub: Implement continue (c pkt) with new infra

2019-05-28 Thread Jon Doron
Signed-off-by: Jon Doron Reviewed-by: Alex Bennée --- gdbstub.c | 25 +++-- 1 file changed, 19 insertions(+), 6 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 7801f2f260..99b78aa426 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1531,6 +1531,16 @@ static void

[Qemu-devel] [PATCH v12 10/20] gdbstub: Implement write memory (M pkt) with new infra

2019-05-28 Thread Jon Doron
Signed-off-by: Jon Doron Reviewed-by: Alex Bennée --- gdbstub.c | 51 +-- 1 file changed, 33 insertions(+), 18 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 07740ec0af..f2ea5bdd5c 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1702,6 +1702,31

[Qemu-devel] [PATCH v12 03/20] gdbstub: Implement thread_alive (T pkt) with new infra

2019-05-28 Thread Jon Doron
Signed-off-by: Jon Doron Reviewed-by: Alex Bennée --- gdbstub.c | 43 --- 1 file changed, 32 insertions(+), 11 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 1db322c15a..7801f2f260 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1507,6 +1507,30

[Qemu-devel] [PATCH v12 19/20] gdbstub: Clear unused variables in gdb_handle_packet

2019-05-28 Thread Jon Doron
Signed-off-by: Jon Doron Reviewed-by: Alex Bennée --- gdbstub.c | 11 ++- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index a474f2c755..a0ff0017f6 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -2284,17 +2284,11 @@ static void handle_target_halt

[Qemu-devel] [PATCH v12 12/20] gdbstub: Implement write all registers (G pkt) with new infra

2019-05-28 Thread Jon Doron
Signed-off-by: Jon Doron Reviewed-by: Alex Bennée --- gdbstub.c | 41 +++-- 1 file changed, 31 insertions(+), 10 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 3d8c2f8f42..a487e549d1 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1751,6 +1751,29 @@ static

[Qemu-devel] [PATCH v12 18/20] gdbstub: Implement target halted (? pkt) with new infra

2019-05-28 Thread Jon Doron
Note: The user-mode thread-id has been correctly reported since bd88c780e6 Signed-off-by: Jon Doron --- gdbstub.c | 35 +-- 1 file changed, 25 insertions(+), 10 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 80fe5b2d0c..a474f2c755 100644 --- a/gdbstub.c

[Qemu-devel] [PATCH v12 02/20] gdbstub: Implement deatch (D pkt) with new infra

2019-05-28 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 101 +- 1 file changed, 61 insertions(+), 40 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index e6d895177b..1db322c15a 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1413,11 +1413,6 @@ static inline int

[Qemu-devel] [PATCH v12 15/20] gdbstub: Implement step (s pkt) with new infra

2019-05-28 Thread Jon Doron
Signed-off-by: Jon Doron Reviewed-by: Alex Bennée --- gdbstub.c | 25 +++-- 1 file changed, 19 insertions(+), 6 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index ea85966b27..3fd1a1cddb 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1808,6 +1808,16 @@ static void

[Qemu-devel] [PATCH v12 05/20] gdbstub: Implement continue with signal (C pkt) with new infra

2019-05-28 Thread Jon Doron
Signed-off-by: Jon Doron Reviewed-by: Alex Bennée --- gdbstub.c | 34 +- 1 file changed, 29 insertions(+), 5 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 99b78aa426..5df4d58427 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1541,6 +1541,25 @@ static void

[Qemu-devel] [PATCH v12 06/20] gdbstub: Implement set_thread (H pkt) with new infra

2019-05-28 Thread Jon Doron
Signed-off-by: Jon Doron Reviewed-by: Alex Bennée --- gdbstub.c | 83 +++ 1 file changed, 53 insertions(+), 30 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 5df4d58427..db213cf173 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1560,6

[Qemu-devel] [PATCH v12 08/20] gdbstub: Implement set register (P pkt) with new infra

2019-05-28 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 39 ++- 1 file changed, 30 insertions(+), 9 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 57bfa4..fc9526b3f5 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1651,6 +1651,27 @@ static void handle_remove_bp

[Qemu-devel] [PATCH v12 11/20] gdbstub: Implement read memory (m pkt) with new infra

2019-05-28 Thread Jon Doron
Signed-off-by: Jon Doron Reviewed-by: Alex Bennée --- gdbstub.c | 48 1 file changed, 32 insertions(+), 16 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index f2ea5bdd5c..3d8c2f8f42 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1727,6 +1727,30

[Qemu-devel] [PATCH v12 13/20] gdbstub: Implement read all registers (g pkt) with new infra

2019-05-29 Thread Jon Doron
Signed-off-by: Jon Doron Reviewed-by: Alex Bennée --- gdbstub.c | 31 +++ 1 file changed, 23 insertions(+), 8 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index a487e549d1..8a401e6527 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1774,6 +1774,21 @@ static void

[Qemu-devel] [PATCH v12 14/20] gdbstub: Implement file io (F pkt) with new infra

2019-05-29 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 48 ++-- 1 file changed, 26 insertions(+), 22 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 8a401e6527..ea85966b27 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1789,6 +1789,25 @@ static void

[Qemu-devel] [PATCH v12 16/20] gdbstub: Implement v commands with new infra

2019-05-29 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 170 +++--- 1 file changed, 110 insertions(+), 60 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 3fd1a1cddb..648191a3b0 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1818,6 +1818,106 @@ static void

[Qemu-devel] [PATCH v12 17/20] gdbstub: Implement generic set/query (Q/q pkt) with new infra

2019-05-29 Thread Jon Doron
ing. gdb> maintenance packet Qqemu.sstep:HEX_VALUE Will change the single step mask. Signed-off-by: Jon Doron --- gdbstub.c | 559 -- 1 file changed, 373 insertions(+), 186 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 648191a3b0..80fe5

[Qemu-devel] [PATCH v12 20/20] gdbstub: Implement qemu physical memory mode

2019-05-29 Thread Jon Doron
isable Signed-off-by: Jon Doron --- gdbstub.c | 62 +-- 1 file changed, 60 insertions(+), 2 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index a0ff0017f6..d46e21bf70 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -46,11 +46,27 @@ #define GDB_ATTAC

[Qemu-devel] [PATCH v1] gdbstub: Refactor gdb packets handler

2019-04-24 Thread Jon Doron
Refactor the command packet handling code to ease the work of adding and extending commands that are currently not implemented. Signed-off-by: Jon Doron --- gdbstub.c | 1577 + 1 file changed, 1092 insertions(+), 485 deletions(-) diff --git a

[Qemu-devel] [PATCH v2] gdbstub: Refactor gdb packets handler

2019-04-24 Thread Jon Doron
Refactor the command packet handling code to ease the work of adding and extending commands that are currently not implemented. Signed-off-by: Jon Doron --- gdbstub.c | 1619 + 1 file changed, 1128 insertions(+), 491 deletions(-) diff --git a

[Qemu-devel] [PATCH v4 13/20] gdbstub: Implement write all registers (G pkt) with new infra

2019-04-24 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 41 +++-- 1 file changed, 31 insertions(+), 10 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index af37222034..084c688f75 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1744,6 +1744,29 @@ static void handle_read_mem

[Qemu-devel] [PATCH v4 19/20] gdbstub: Implement generic set (Q pkt) with new infra

2019-04-24 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 213 +++--- 1 file changed, 25 insertions(+), 188 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 8de4e09caa..61ab630d9e 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1130,14 +1130,6 @@ static

[Qemu-devel] [PATCH v4 17/20] gdbstub: Implement v commands with new infra

2019-04-24 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 170 +++--- 1 file changed, 110 insertions(+), 60 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 265a6e3aeb..8c79e36923 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1825,6 +1825,106 @@ static void

[Qemu-devel] [PATCH v4 20/20] gdbstub: Refactor parse handle packet to work with a static array

2019-04-24 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 386 ++ 1 file changed, 158 insertions(+), 228 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 61ab630d9e..69b3a5185e 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -2257,240 +2257,170 @@ static void

[Qemu-devel] [PATCH v4 16/20] gdbstub: Implement step (s pkt) with new infra

2019-04-24 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 25 +++-- 1 file changed, 19 insertions(+), 6 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 772bcd2e1f..265a6e3aeb 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1815,6 +1815,16 @@ static void handle_file_io(GdbCmdContext *gdb_ctx

[Qemu-devel] [PATCH v4 08/20] gdbstub: Implement remove breakpoint (z pkt) with new infra

2019-04-24 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 49 - 1 file changed, 32 insertions(+), 17 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 03553a1a32..b5d568603c 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1621,6 +1621,29 @@ static void

[Qemu-devel] [PATCH v4 10/20] gdbstub: Implement get register (p pkt) with new infra

2019-04-24 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 50 ++ 1 file changed, 38 insertions(+), 12 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index d3d688a747..58b665d303 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1665,6 +1665,36 @@ static void

[Qemu-devel] [PATCH v4 18/20] gdbstub: Implement generic query (q pkt) with new infra

2019-04-24 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 335 ++ 1 file changed, 335 insertions(+) diff --git a/gdbstub.c b/gdbstub.c index 8c79e36923..8de4e09caa 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1925,6 +1925,331 @@ static void handle_v_commands

[Qemu-devel] [PATCH v4 14/20] gdbstub: Implement read all registers (g pkt) with new infra

2019-04-24 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 31 +++ 1 file changed, 23 insertions(+), 8 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 084c688f75..b9ac9401ed 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1767,6 +1767,21 @@ static void handle_write_all_regs

[Qemu-devel] [PATCH v4 06/20] gdbstub: Implement set_thread (H pkt) with new infra

2019-04-24 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 79 ++- 1 file changed, 49 insertions(+), 30 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index edcb7bfd17..c1ec36a062 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1557,6 +1557,47 @@ static void

<    1   2   3   4   >