[Qemu-devel] [PATCH v8 03/27] gdbstub: Implement thread_alive (T pkt) with new infra

2019-05-02 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 43 --- 1 file changed, 32 insertions(+), 11 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 621d689868..c47ef7dd9c 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1498,6 +1498,30 @@ static void handle_detach

[Qemu-devel] [PATCH v8 01/27] gdbstub: Add infrastructure to parse cmd packets

2019-05-02 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 200 ++ 1 file changed, 200 insertions(+) diff --git a/gdbstub.c b/gdbstub.c index d54abd17cc..d5e0f3878a 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1268,6 +1268,206 @@ out: return res

[Qemu-devel] [PATCH v8 09/27] gdbstub: Implement set register (P pkt) with new infra

2019-05-02 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 39 ++- 1 file changed, 30 insertions(+), 9 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index b42425b24c..10e3f12a68 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1634,6 +1634,27 @@ static void handle_remove_bp

[Qemu-devel] [PATCH v8 00/27] gdbstub: Refactor command packets handler

2019-05-02 Thread Jon Doron
- Split the single patch to many individual patches for easier reviewing version 2 changes - Code convention fixes Jon Doron (27): gdbstub: Add infrastructure to parse cmd packets gdbstub: Implement deatch (D pkt) with new infra gdbstub: Implement thread_alive (T pkt) with new infra gdbstub

[Qemu-devel] [PATCH v8 02/27] gdbstub: Implement deatch (D pkt) with new infra

2019-05-02 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 90 ++- 1 file changed, 50 insertions(+), 40 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index d5e0f3878a..621d689868 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1418,11 +1418,6 @@ static inline int

[Qemu-devel] [PATCH v8 10/27] gdbstub: Implement get register (p pkt) with new infra

2019-05-02 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 50 ++ 1 file changed, 38 insertions(+), 12 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 10e3f12a68..e9a3d0c2bc 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1655,6 +1655,36 @@ static void

[Qemu-devel] [PATCH v8 17/27] gdbstub: Implement v commands with new infra

2019-05-02 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 170 +++--- 1 file changed, 110 insertions(+), 60 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 9b0556f8be..d56d0fd235 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1815,6 +1815,106 @@ static void

[Qemu-devel] [PATCH v8 05/27] gdbstub: Implement continue with signal (C pkt) with new infra

2019-05-02 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 30 +- 1 file changed, 25 insertions(+), 5 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 89f1ab6524..469aaeb875 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1532,6 +1532,21 @@ static void handle_continue(GdbCmdContext

[Qemu-devel] [PATCH v8 27/27] gdbstub: Add support to write a MSR for KVM target

2019-05-02 Thread Jon Doron
gdb> maint packet Qqemu.kvm.Wrmsr:MsrIndex,Value Signed-off-by: Jon Doron --- gdbstub.c | 29 - 1 file changed, 28 insertions(+), 1 deletion(-) diff --git a/gdbstub.c b/gdbstub.c index d5cdda190a..2d9a8e6942 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -2145,7 +214

[Qemu-devel] [PATCH v8 23/27] gdbstub: Implement qemu physical memory mode

2019-05-02 Thread Jon Doron
isable Signed-off-by: Jon Doron --- gdbstub.c | 58 --- 1 file changed, 55 insertions(+), 3 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 00c07d6ec0..6daf779af4 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -46,11 +46,23 @@ #define GDB_ATTAC

[Qemu-devel] [PATCH v8 13/27] gdbstub: Implement write all registers (G pkt) with new infra

2019-05-02 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 41 +++-- 1 file changed, 31 insertions(+), 10 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index daa602edc3..adfe39b3a3 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1734,6 +1734,29 @@ static void handle_read_mem

[Qemu-devel] [PATCH v8 06/27] gdbstub: Implement set_thread (H pkt) with new infra

2019-05-02 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 79 ++- 1 file changed, 49 insertions(+), 30 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 469aaeb875..21cdaf4678 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1547,6 +1547,47 @@ static void

[Qemu-devel] [PATCH v8 16/27] gdbstub: Implement step (s pkt) with new infra

2019-05-02 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 25 +++-- 1 file changed, 19 insertions(+), 6 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 9fe130f30d..9b0556f8be 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1805,6 +1805,16 @@ static void handle_file_io(GdbCmdContext *gdb_ctx

[Qemu-devel] [PATCH v8 24/27] gdbstub: Add another handler for setting qemu.sstep

2019-05-02 Thread Jon Doron
Follow GDB general query/set packet conventions, qemu.sstep can now be set with the following command as well: gdb> maint packet Qqemu.sstep:Value Signed-off-by: Jon Doron --- gdbstub.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/gdbstub.c b/gdbstub.c index 6daf779af4..bceceee

[Qemu-devel] [PATCH v8 21/27] gdbstub: Clear unused variables in gdb_handle_packet

2019-05-02 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 11 ++- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index d678191705..8bdfae4b29 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -2259,17 +2259,11 @@ static void handle_target_halt(GdbCmdContext *gdb_ctx, void

[Qemu-devel] [PATCH v8 20/27] gdbstub: Implement target halted (? pkt) with new infra

2019-05-02 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 36 ++-- 1 file changed, 26 insertions(+), 10 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 2fd0d66f4d..d678191705 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -2239,13 +2239,30 @@ static void handle_gen_set

[Qemu-devel] [PATCH v8 22/27] gdbstub: Implement generic query qemu.Supported

2019-05-02 Thread Jon Doron
qemu.Supported query reply back with the supported qemu query/set commands (commands are seperated with a semicolon from each other). gdb> maint packet qqemu.Supported Signed-off-by: Jon Doron --- gdbstub.c | 9 + 1 file changed, 9 insertions(+) diff --git a/gdbstub.c b/gdbstu

[Qemu-devel] [PATCH v8 25/27] kvm: Add API to read/write a CPU MSR value

2019-05-02 Thread Jon Doron
Signed-off-by: Jon Doron --- accel/kvm/kvm-all.c | 39 +++ include/sysemu/kvm.h | 2 ++ 2 files changed, 41 insertions(+) diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c index 524c4ddfbd..35207d910b 100644 --- a/accel/kvm/kvm-all.c +++ b/accel/kvm

[Qemu-devel] [PATCH v8 15/27] gdbstub: Implement file io (F pkt) with new infra

2019-05-02 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 62 +++ 1 file changed, 40 insertions(+), 22 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 3478ac778d..9fe130f30d 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1772,6 +1772,39 @@ static void

[Qemu-devel] [PATCH v8 07/27] gdbstub: Implement insert breakpoint (Z pkt) with new infra

2019-05-02 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 33 + 1 file changed, 33 insertions(+) diff --git a/gdbstub.c b/gdbstub.c index 21cdaf4678..36c7353a22 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1588,6 +1588,29 @@ static void handle_set_thread(GdbCmdContext *gdb_ctx

[Qemu-devel] [PATCH v8 08/27] gdbstub: Implement remove breakpoint (z pkt) with new infra

2019-05-02 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 49 - 1 file changed, 32 insertions(+), 17 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 36c7353a22..b42425b24c 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1611,6 +1611,29 @@ static void

[Qemu-devel] [PATCH v8 14/27] gdbstub: Implement read all registers (g pkt) with new infra

2019-05-02 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 31 +++ 1 file changed, 23 insertions(+), 8 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index adfe39b3a3..3478ac778d 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1757,6 +1757,21 @@ static void handle_write_all_regs

[Qemu-devel] [PATCH v8 19/27] gdbstub: Implement generic set (Q pkt) with new infra

2019-05-02 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 213 +++--- 1 file changed, 25 insertions(+), 188 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 83ae8738cc..2fd0d66f4d 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1130,14 +1130,6 @@ static

[Qemu-devel] [PATCH v8 26/27] gdbstub: Add support to read a MSR for KVM target

2019-05-02 Thread Jon Doron
gdb> maint packet qqemu.kvm.Rdmsr:MsrIndex Signed-off-by: Jon Doron --- gdbstub.c | 38 +- 1 file changed, 37 insertions(+), 1 deletion(-) diff --git a/gdbstub.c b/gdbstub.c index bceceeec57..d5cdda190a 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -214

[Qemu-devel] [PATCH v8 11/27] gdbstub: Implement write memory (M pkt) with new infra

2019-05-02 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 51 +-- 1 file changed, 33 insertions(+), 18 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index e9a3d0c2bc..8dc2e1d507 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1685,6 +1685,31 @@ static void

[Qemu-devel] [PATCH v8 12/27] gdbstub: Implement read memory (m pkt) with new infra

2019-05-02 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 48 1 file changed, 32 insertions(+), 16 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 8dc2e1d507..daa602edc3 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1710,6 +1710,30 @@ static void

[Qemu-devel] [PATCH v8 18/27] gdbstub: Implement generic query (q pkt) with new infra

2019-05-02 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 327 ++ 1 file changed, 327 insertions(+) diff --git a/gdbstub.c b/gdbstub.c index d56d0fd235..83ae8738cc 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1915,6 +1915,323 @@ static void handle_v_commands

[Qemu-devel] [PATCH v8 04/27] gdbstub: Implement continue (c pkt) with new infra

2019-05-02 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 25 +++-- 1 file changed, 19 insertions(+), 6 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index c47ef7dd9c..89f1ab6524 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1522,6 +1522,16 @@ static void handle_thread_alive(GdbCmdContext

[Qemu-devel] [PATCH v9 01/27] gdbstub: Add infrastructure to parse cmd packets

2019-05-02 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 200 ++ 1 file changed, 200 insertions(+) diff --git a/gdbstub.c b/gdbstub.c index d54abd17cc..d5e0f3878a 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1268,6 +1268,206 @@ out: return res

[Qemu-devel] [PATCH v9 02/27] gdbstub: Implement deatch (D pkt) with new infra

2019-05-02 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 90 ++- 1 file changed, 50 insertions(+), 40 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index d5e0f3878a..621d689868 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1418,11 +1418,6 @@ static inline int

[Qemu-devel] [PATCH v9 00/27] gdbstub: Refactor command packets handler

2019-05-02 Thread Jon Doron
Richard Henderson version 3 changes - Split the single patch to many individual patches for easier reviewing version 2 changes - Code convention fixes Jon Doron (27): gdbstub: Add infrastructure to parse cmd packets gdbstub: Implement deatch (D pkt) with new infra gdbstub: Implement

[Qemu-devel] [PATCH v9 03/27] gdbstub: Implement thread_alive (T pkt) with new infra

2019-05-02 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 43 --- 1 file changed, 32 insertions(+), 11 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 621d689868..c47ef7dd9c 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1498,6 +1498,30 @@ static void handle_detach

[Qemu-devel] [PATCH v9 09/27] gdbstub: Implement set register (P pkt) with new infra

2019-05-02 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 39 ++- 1 file changed, 30 insertions(+), 9 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index b42425b24c..10e3f12a68 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1634,6 +1634,27 @@ static void handle_remove_bp

[Qemu-devel] [PATCH v9 04/27] gdbstub: Implement continue (c pkt) with new infra

2019-05-02 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 25 +++-- 1 file changed, 19 insertions(+), 6 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index c47ef7dd9c..89f1ab6524 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1522,6 +1522,16 @@ static void handle_thread_alive(GdbCmdContext

[Qemu-devel] [PATCH v9 12/27] gdbstub: Implement read memory (m pkt) with new infra

2019-05-02 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 48 1 file changed, 32 insertions(+), 16 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 8dc2e1d507..daa602edc3 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1710,6 +1710,30 @@ static void

[Qemu-devel] [PATCH v9 05/27] gdbstub: Implement continue with signal (C pkt) with new infra

2019-05-02 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 30 +- 1 file changed, 25 insertions(+), 5 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 89f1ab6524..469aaeb875 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1532,6 +1532,21 @@ static void handle_continue(GdbCmdContext

[Qemu-devel] [PATCH v9 14/27] gdbstub: Implement read all registers (g pkt) with new infra

2019-05-02 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 31 +++ 1 file changed, 23 insertions(+), 8 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index adfe39b3a3..3478ac778d 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1757,6 +1757,21 @@ static void handle_write_all_regs

[Qemu-devel] [PATCH v9 07/27] gdbstub: Implement insert breakpoint (Z pkt) with new infra

2019-05-02 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 33 + 1 file changed, 33 insertions(+) diff --git a/gdbstub.c b/gdbstub.c index 21cdaf4678..36c7353a22 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1588,6 +1588,29 @@ static void handle_set_thread(GdbCmdContext *gdb_ctx

[Qemu-devel] [PATCH v9 16/27] gdbstub: Implement step (s pkt) with new infra

2019-05-02 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 25 +++-- 1 file changed, 19 insertions(+), 6 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 9fe130f30d..9b0556f8be 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1805,6 +1805,16 @@ static void handle_file_io(GdbCmdContext *gdb_ctx

[Qemu-devel] [PATCH v9 17/27] gdbstub: Implement v commands with new infra

2019-05-02 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 170 +++--- 1 file changed, 110 insertions(+), 60 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 9b0556f8be..d56d0fd235 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1815,6 +1815,106 @@ static void

[Qemu-devel] [PATCH v9 10/27] gdbstub: Implement get register (p pkt) with new infra

2019-05-02 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 50 ++ 1 file changed, 38 insertions(+), 12 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 10e3f12a68..e9a3d0c2bc 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1655,6 +1655,36 @@ static void

[Qemu-devel] [PATCH v9 22/27] gdbstub: Implement generic query qemu.Supported

2019-05-02 Thread Jon Doron
qemu.Supported query reply back with the supported qemu query/set commands (commands are seperated with a semicolon from each other). gdb> maint packet qqemu.Supported Signed-off-by: Jon Doron --- gdbstub.c | 9 + 1 file changed, 9 insertions(+) diff --git a/gdbstub.c b/gdbstu

[Qemu-devel] [PATCH v9 08/27] gdbstub: Implement remove breakpoint (z pkt) with new infra

2019-05-02 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 49 - 1 file changed, 32 insertions(+), 17 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 36c7353a22..b42425b24c 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1611,6 +1611,29 @@ static void

[Qemu-devel] [PATCH v9 11/27] gdbstub: Implement write memory (M pkt) with new infra

2019-05-02 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 51 +-- 1 file changed, 33 insertions(+), 18 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index e9a3d0c2bc..8dc2e1d507 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1685,6 +1685,31 @@ static void

[Qemu-devel] [PATCH v9 20/27] gdbstub: Implement target halted (? pkt) with new infra

2019-05-02 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 36 ++-- 1 file changed, 26 insertions(+), 10 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 2fd0d66f4d..d678191705 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -2239,13 +2239,30 @@ static void handle_gen_set

[Qemu-devel] [PATCH v9 06/27] gdbstub: Implement set_thread (H pkt) with new infra

2019-05-02 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 79 ++- 1 file changed, 49 insertions(+), 30 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 469aaeb875..21cdaf4678 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1547,6 +1547,47 @@ static void

[Qemu-devel] [PATCH v9 15/27] gdbstub: Implement file io (F pkt) with new infra

2019-05-02 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 62 +++ 1 file changed, 40 insertions(+), 22 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 3478ac778d..9fe130f30d 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1772,6 +1772,39 @@ static void

[Qemu-devel] [PATCH v9 23/27] gdbstub: Implement qemu physical memory mode

2019-05-02 Thread Jon Doron
isable Signed-off-by: Jon Doron --- gdbstub.c | 58 --- 1 file changed, 55 insertions(+), 3 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 00c07d6ec0..88ff6224e6 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -46,11 +46,23 @@ #define GDB_ATTAC

[Qemu-devel] [PATCH v9 18/27] gdbstub: Implement generic query (q pkt) with new infra

2019-05-02 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 327 ++ 1 file changed, 327 insertions(+) diff --git a/gdbstub.c b/gdbstub.c index d56d0fd235..83ae8738cc 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1915,6 +1915,323 @@ static void handle_v_commands

[Qemu-devel] [PATCH v9 13/27] gdbstub: Implement write all registers (G pkt) with new infra

2019-05-02 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 41 +++-- 1 file changed, 31 insertions(+), 10 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index daa602edc3..adfe39b3a3 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1734,6 +1734,29 @@ static void handle_read_mem

[Qemu-devel] [PATCH v9 25/27] kvm: Add API to read/write a CPU MSR value

2019-05-02 Thread Jon Doron
Signed-off-by: Jon Doron --- accel/kvm/kvm-all.c | 39 +++ include/sysemu/kvm.h | 2 ++ 2 files changed, 41 insertions(+) diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c index 524c4ddfbd..35207d910b 100644 --- a/accel/kvm/kvm-all.c +++ b/accel/kvm

[Qemu-devel] [PATCH v9 24/27] gdbstub: Add another handler for setting qemu.sstep

2019-05-02 Thread Jon Doron
Follow GDB general query/set packet conventions, qemu.sstep can now be set with the following command as well: gdb> maint packet Qqemu.sstep:Value Signed-off-by: Jon Doron --- gdbstub.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/gdbstub.c b/gdbstub.c index 88ff6224e6..34da102

[Qemu-devel] [PATCH v9 21/27] gdbstub: Clear unused variables in gdb_handle_packet

2019-05-02 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 11 ++- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index d678191705..8bdfae4b29 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -2259,17 +2259,11 @@ static void handle_target_halt(GdbCmdContext *gdb_ctx, void

[Qemu-devel] [PATCH v9 26/27] gdbstub: Add support to read a MSR for KVM target

2019-05-02 Thread Jon Doron
gdb> maint packet qqemu.kvm.Rdmsr:MsrIndex Signed-off-by: Jon Doron --- gdbstub.c | 38 +- 1 file changed, 37 insertions(+), 1 deletion(-) diff --git a/gdbstub.c b/gdbstub.c index 34da10260d..f48c3a2b5f 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -214

[Qemu-devel] [PATCH v9 19/27] gdbstub: Implement generic set (Q pkt) with new infra

2019-05-02 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 213 +++--- 1 file changed, 25 insertions(+), 188 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 83ae8738cc..2fd0d66f4d 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1130,14 +1130,6 @@ static

[Qemu-devel] [PATCH v9 27/27] gdbstub: Add support to write a MSR for KVM target

2019-05-02 Thread Jon Doron
gdb> maint packet Qqemu.kvm.Wrmsr:MsrIndex,Value Signed-off-by: Jon Doron --- gdbstub.c | 29 - 1 file changed, 28 insertions(+), 1 deletion(-) diff --git a/gdbstub.c b/gdbstub.c index f48c3a2b5f..a434a3749e 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -2145,7 +214

Re: [PATCH v4 0/1] hw/hyperv/vmbus: Is it maintained?

2021-11-16 Thread Jon Doron
On 13/11/2021, Maciej S. Szmigiero wrote: On 12.11.2021 21:39, Roman Kagan wrote: On Fri, Nov 12, 2021 at 09:32:31PM +0300, Vladimir Sementsov-Ogievskiy wrote: Add Den and Roman (his new address) Thanks, I missed it on the list indeed. 06.11.2021 16:41, Philippe Mathieu-Daudé wrote: This i

Re: [PATCH v2 4/4] hw: hyperv: Initial commit for Synthetic Debugging device

2022-02-23 Thread Jon Doron
ping On Wed, Feb 16, 2022, 12:25 Jon Doron wrote: > Signed-off-by: Jon Doron > --- > hw/hyperv/Kconfig | 5 + > hw/hyperv/meson.build | 1 + > hw/hyperv/syndbg.c| 402 ++ > 3 files changed, 408 insertions(+) > create

[PATCH v1 0/4] HyperV: Synthetic Debugging device

2022-02-04 Thread Jon Doron
debugger configured correctly. Jon Doron (4): hyperv: SControl is optional to enable SynIc hyperv: Add definitions for syndbg hyperv: Add support to process syndbg commands hw: hyperv: Initial commit for Synthetic Debugging device docs/hyperv.txt | 15 + hw/hyperv/Kcon

[PATCH v1 3/4] hyperv: Add support to process syndbg commands

2022-02-04 Thread Jon Doron
SynDbg commands can come from two different flows: 1. Hypercalls, in this mode the data being sent is fully encapsulated network packets. 2. SynDbg specific MSRs, in this mode only the data that needs to be transfered is passed. Signed-off-by: Jon Doron --- docs/hyperv.txt

[PATCH v1 1/4] hyperv: SControl is optional to enable SynIc

2022-02-04 Thread Jon Doron
pending flag. When the guest polls from the message slot, incase the pending flag is set it will write to the HV_X64_MSR_EOM indicating it has cleared the slow and we can try and push our message again. Signed-off-by: Jon Doron --- hw/hyperv/hyperv.c | 233

[PATCH v1 2/4] hyperv: Add definitions for syndbg

2022-02-04 Thread Jon Doron
Add all required definitions for hyperv synthetic debugger interface. Signed-off-by: Jon Doron --- include/hw/hyperv/hyperv-proto.h | 52 target/i386/kvm/hyperv-proto.h | 37 +++ 2 files changed, 89 insertions(+) diff --git a/include/hw

[PATCH v1 4/4] hw: hyperv: Initial commit for Synthetic Debugging device

2022-02-04 Thread Jon Doron
Signed-off-by: Jon Doron --- hw/hyperv/Kconfig | 5 + hw/hyperv/meson.build | 1 + hw/hyperv/syndbg.c| 407 ++ 3 files changed, 413 insertions(+) create mode 100644 hw/hyperv/syndbg.c diff --git a/hw/hyperv/Kconfig b/hw/hyperv/Kconfig index

Re: [PATCH v1 0/4] HyperV: Synthetic Debugging device

2022-02-12 Thread Jon Doron
On 04/02/2022, Jon Doron wrote: Ping This patchset adds support for the synthetic debugging device. HyperV supports a special transport layer for the kernel debugger when running in HyperV. This patchset add supports for this device so you could have a setup fast windows kernel debugging

[PATCH v2 2/4] hyperv: Add definitions for syndbg

2022-02-16 Thread Jon Doron
Add all required definitions for hyperv synthetic debugger interface. Signed-off-by: Jon Doron --- include/hw/hyperv/hyperv-proto.h | 52 target/i386/kvm/hyperv-proto.h | 37 +++ 2 files changed, 89 insertions(+) diff --git a/include/hw

[PATCH v2 4/4] hw: hyperv: Initial commit for Synthetic Debugging device

2022-02-16 Thread Jon Doron
Signed-off-by: Jon Doron --- hw/hyperv/Kconfig | 5 + hw/hyperv/meson.build | 1 + hw/hyperv/syndbg.c| 402 ++ 3 files changed, 408 insertions(+) create mode 100644 hw/hyperv/syndbg.c diff --git a/hw/hyperv/Kconfig b/hw/hyperv/Kconfig index

[PATCH v2 1/4] hyperv: SControl is optional to enable SynIc

2022-02-16 Thread Jon Doron
pending flag. When the guest polls from the message slot, in case the pending flag is set it will write to the HV_X64_MSR_EOM indicating it has cleared the slot and we can try and push our message again. Signed-off-by: Jon Doron --- hw/hyperv/hyperv.c | 109

[PATCH v2 0/4] HyperV: Synthetic Debugging device

2022-02-16 Thread Jon Doron
debugger configured correctly. Jon Doron (4): hyperv: SControl is optional to enable SynIc hyperv: Add definitions for syndbg hyperv: Add support to process syndbg commands hw: hyperv: Initial commit for Synthetic Debugging device docs/hyperv.txt | 15 ++ hw/hyperv/Kcon

[PATCH v2 3/4] hyperv: Add support to process syndbg commands

2022-02-16 Thread Jon Doron
SynDbg commands can come from two different flows: 1. Hypercalls, in this mode the data being sent is fully encapsulated network packets. 2. SynDbg specific MSRs, in this mode only the data that needs to be transfered is passed. Signed-off-by: Jon Doron --- docs/hyperv.txt

Re: [PATCH v1 3/4] hyperv: Add support to process syndbg commands

2022-02-16 Thread Jon Doron
On 16/02/2022, Emanuele Giuseppe Esposito wrote: On 04/02/2022 11:07, Jon Doron wrote: SynDbg commands can come from two different flows: 1. Hypercalls, in this mode the data being sent is fully encapsulated network packets. 2. SynDbg specific MSRs, in this mode only the data that needs to

Re: [PATCH v1 1/4] hyperv: SControl is optional to enable SynIc

2022-02-16 Thread Jon Doron
On 16/02/2022, Emanuele Giuseppe Esposito wrote: On 04/02/2022 11:07, Jon Doron wrote: SynIc can be enabled regardless of the SControl mechanisim which can register a GSI for a given SintRoute. This behaviour can achived by setting enabling SIMP and then the guest will poll on the message

Re: [PATCH v1 4/4] hw: hyperv: Initial commit for Synthetic Debugging device

2022-02-16 Thread Jon Doron
On 16/02/2022, Emanuele Giuseppe Esposito wrote: + +static uint16_t handle_recv_msg(HvSynDbg *syndbg, uint64_t outgpa, +uint32_t count, bool is_raw, uint32_t options, +uint64_t timeout, uint32_t *retrieved_count) +{ +uint16_t r

Re: [PATCH v1 2/4] hyperv: Add definitions for syndbg

2022-02-16 Thread Jon Doron
On 16/02/2022, Emanuele Giuseppe Esposito wrote: On 04/02/2022 11:07, Jon Doron wrote: Add all required definitions for hyperv synthetic debugger interface. Signed-off-by: Jon Doron --- include/hw/hyperv/hyperv-proto.h | 52 target/i386/kvm/hyperv-proto.h

Re: [PATCH v2 1/4] hyperv: SControl is optional to enable SynIc

2022-03-06 Thread Jon Doron
Thanks! is there an estimate when will this patchset be merged? On Thu, Feb 24, 2022, 18:36 Emanuele Giuseppe Esposito wrote: > > > On 16/02/2022 11:24, Jon Doron wrote: > > SynIc can be enabled regardless of the SControl mechanisim which can > > register a GSI

[PATCH v3 2/4] hyperv: Add definitions for syndbg

2022-03-15 Thread Jon Doron
Add all required definitions for hyperv synthetic debugger interface. Signed-off-by: Jon Doron --- include/hw/hyperv/hyperv-proto.h | 52 target/i386/kvm/hyperv-proto.h | 37 +++ 2 files changed, 89 insertions(+) diff --git a/include/hw

[PATCH v3 4/4] hw: hyperv: Initial commit for Synthetic Debugging device

2022-03-15 Thread Jon Doron
Signed-off-by: Jon Doron --- hw/hyperv/Kconfig | 5 + hw/hyperv/meson.build | 1 + hw/hyperv/syndbg.c| 402 ++ 3 files changed, 408 insertions(+) create mode 100644 hw/hyperv/syndbg.c diff --git a/hw/hyperv/Kconfig b/hw/hyperv/Kconfig index

[PATCH v3 0/4] HyperV: Synthetic Debugging device

2022-03-15 Thread Jon Doron
debugger configured correctly. v3: Fixed review from Paolo changes from QLIST*RCU to non RCU Jon Doron (4): hyperv: SControl is optional to enable SynIc hyperv: Add definitions for syndbg hyperv: Add support to process syndbg commands hw: hyperv: Initial commit for Synthetic Debu

[PATCH v3 3/4] hyperv: Add support to process syndbg commands

2022-03-15 Thread Jon Doron
SynDbg commands can come from two different flows: 1. Hypercalls, in this mode the data being sent is fully encapsulated network packets. 2. SynDbg specific MSRs, in this mode only the data that needs to be transfered is passed. Signed-off-by: Jon Doron --- docs/hyperv.txt

[PATCH v3 1/4] hyperv: SControl is optional to enable SynIc

2022-03-15 Thread Jon Doron
pending flag. When the guest polls from the message slot, in case the pending flag is set it will write to the HV_X64_MSR_EOM indicating it has cleared the slot and we can try and push our message again. Signed-off-by: Jon Doron --- hw/hyperv/hyperv.c | 109

Re: Concerns regarding e17bebd049 ("dump: Set correct vaddr for ELF dump")

2023-09-20 Thread Jon Doron
ard all the virtual addresses in the program headers, and unconditionally do all the page table walks yourself. But I wanted to see if there was some justification for this behavior that I missed. Thanks, Stephen [1]: https://github.com/osandov/drgn [2]: https://lore.kernel.org/qemu-devel/2018122

[Qemu-devel] [PATCH v1] dump: Set correct vaddr for ELF dump

2018-12-25 Thread Jon Doron
vaddr needs to be equal to the paddr since the dump file represents the physical memory image. Without setting vaddr correctly, GDB would load all the different memory regions on top of each other to vaddr 0, thus making GDB showing the wrong memory data for a given address. Signed-off-by: Jon

Re: [Qemu-devel] [PATCH v1] dump: Set correct vaddr for ELF dump

2019-01-07 Thread Jon Doron
apping->virt_addr) : phdr.p_paddr; So in the case of paging where virt_addr is available we will use it Thanks, -- Jon. On Mon, Jan 7, 2019 at 8:04 PM Laszlo Ersek wrote: > > On 01/07/19 13:14, Marc-André Lureau wrote: > > Hi > > > > On Tue, Dec 25, 2018 at 5:52 PM Jon Do

[Qemu-devel] [PATCH v2] dump: Set correct vaddr for ELF dump

2019-01-08 Thread Jon Doron
vaddr needs to be equal to the paddr since the dump file represents the physical memory image. Without setting vaddr correctly, GDB would load all the different memory regions on top of each other to vaddr 0, thus making GDB showing the wrong memory data for a given address. Signed-off-by: Jon

[Qemu-devel] [PATCH v3] dump: Set correct vaddr for ELF dump

2019-01-09 Thread Jon Doron
vaddr needs to be equal to the paddr since the dump file represents the physical memory image. Without setting vaddr correctly, GDB would load all the different memory regions on top of each other to vaddr 0, thus making GDB showing the wrong memory data for a given address. Signed-off-by: Jon

[PATCH v4 1/6] hyperv: expose API to determine if synic is enabled

2020-04-24 Thread Jon Doron
Signed-off-by: Jon Doron --- hw/hyperv/hyperv.c | 8 include/hw/hyperv/hyperv.h | 1 + 2 files changed, 9 insertions(+) diff --git a/hw/hyperv/hyperv.c b/hw/hyperv/hyperv.c index 8ca3706f5b..ddf4f32c60 100644 --- a/hw/hyperv/hyperv.c +++ b/hw/hyperv/hyperv.c @@ -37,6 +37,13

[PATCH v4 5/6] i386: Hyper-V VMBus ACPI DSDT entry

2020-04-24 Thread Jon Doron
-configurable via corresponding properties; use 7 and 13 by default. Signed-off-by: Evgeny Yakovlev Signed-off-by: Roman Kagan Signed-off-by: Maciej S. Szmigiero Signed-off-by: Jon Doron --- hw/hyperv/vmbus.c| 7 ++ hw/i386/acpi-build.c | 43

[PATCH v4 0/6] hyperv: VMBus implementation

2020-04-24 Thread Jon Doron
2: Rebased on top of latest patchset from Roman and Maciej Jon Doron (6): hyperv: expose API to determine if synic is enabled vmbus: add vmbus protocol definitions vmbus: vmbus implementation i386:pc: whitelist dynamic vmbus-bridge i386: Hyper-V VMBus ACPI DSDT entry vmbus: add infrast

[PATCH v4 4/6] i386:pc: whitelist dynamic vmbus-bridge

2020-04-24 Thread Jon Doron
As vmbus-bridge is derived from sysbus device, it has to be whitelisted to be allowed to be created with -device. Signed-off-by: Roman Kagan Signed-off-by: Maciej S. Szmigiero Signed-off-by: Jon Doron --- hw/i386/pc_piix.c | 2 ++ hw/i386/pc_q35.c | 2 ++ 2 files changed, 4 insertions

[PATCH v4 3/6] vmbus: vmbus implementation

2020-04-24 Thread Jon Doron
-off-by: Roman Kagan Signed-off-by: Maciej S. Szmigiero Signed-off-by: Jon Doron --- Makefile.objs|1 + hw/hyperv/Kconfig|5 + hw/hyperv/Makefile.objs |1 + hw/hyperv/trace-events | 18 + hw/hyperv/vmbus.c

[PATCH v4 2/6] vmbus: add vmbus protocol definitions

2020-04-24 Thread Jon Doron
Add a header with data structures and constants used in Hyper-V VMBus hypervisor <-> guest interactions. Based on the respective stuff from Linux kernel. Signed-off-by: Roman Kagan Signed-off-by: Maciej S. Szmigiero Signed-off-by: Jon Doron --- include/hw/hyperv/vmbus-proto.h

[PATCH v4 6/6] vmbus: add infrastructure to save/load vmbus requests

2020-04-24 Thread Jon Doron
This can be allow to include controller-specific data while saving/loading in-flight scsi requests of the vmbus scsi controller. Signed-off-by: Roman Kagan Signed-off-by: Maciej S. Szmigiero Signed-off-by: Jon Doron --- hw/hyperv/vmbus.c | 99

Re: [PATCH v3 2/3] i386: acpi: vmbus: Add _ADR definition

2020-06-24 Thread Jon Doron
On 23/06/2020, Igor Mammedov wrote: On Thu, 18 Jun 2020 06:00:26 +0300 Jon Doron wrote: It seems like latest HyperV sets _ADR to 0 in the ACPI for the VMBS that's a hardly a good reason to add this. To me looks like a pointless addition, _ADR mostly is used when device resides on a bus

Re: [PATCH v3 3/3] acpi: i386: Move VMBus DSDT entry to SB

2020-06-24 Thread Jon Doron
On 23/06/2020, Igor Mammedov wrote: On Thu, 18 Jun 2020 06:00:27 +0300 Jon Doron wrote: Signed-off-by: Jon Doron --- hw/i386/acpi-build.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c index 6d9df38e31..38be9e5a58

Re: [PATCH v3 3/3] acpi: i386: Move VMBus DSDT entry to SB

2020-06-24 Thread Jon Doron
On 25/06/2020, Jon Doron wrote: On 23/06/2020, Igor Mammedov wrote: On Thu, 18 Jun 2020 06:00:27 +0300 Jon Doron wrote: Signed-off-by: Jon Doron --- hw/i386/acpi-build.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi

[PATCH v4 0/2] hyperv: vmbus: ACPI various corrections

2020-06-24 Thread Jon Doron
: Renamed irq0 to irq now that there is a single IRQ required Jon Doron (2): hyperv: vmbus: Remove the 2nd IRQ acpi: i386: Move VMBus DSDT entry to SB hw/hyperv/vmbus.c| 3 +-- hw/i386/acpi-build.c | 16 include/hw/hyperv/vmbus-bridge.h | 3 +-- 3 files

[PATCH v4 1/2] hyperv: vmbus: Remove the 2nd IRQ

2020-06-24 Thread Jon Doron
It seems like Windows does not really require 2 IRQs to have a functioning VMBus. Signed-off-by: Jon Doron Reviewed-by: Igor Mammedov --- hw/hyperv/vmbus.c| 3 +-- hw/i386/acpi-build.c | 4 +--- include/hw/hyperv/vmbus-bridge.h | 3 +-- 3 files changed, 3 insertions

[PATCH v4 2/2] acpi: i386: Move VMBus DSDT entry to SB

2020-06-24 Thread Jon Doron
Signed-off-by: Jon Doron --- hw/i386/acpi-build.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c index 91af0d2d0d..1f938a53b2 100644 --- a/hw/i386/acpi-build.c +++ b/hw/i386/acpi-build.c @@ -1091,7 +1091,6 @@ static

Re: [PATCH v4 0/2] hyperv: vmbus: ACPI various corrections

2020-07-13 Thread Jon Doron
Sure thing I'll try to take a look at it this weekend. Jon. On Mon, Jul 13, 2020, 11:44 Igor Mammedov wrote: > On Thu, 25 Jun 2020 07:50:09 +0300 > Jon Doron wrote: > > > After doing further tests and looking at the latest HyperV ACPI DSDT. > > Do minor fix to our

[PATCH v5 1/2] acpi: i386: Move VMBus DSDT entry to SB

2020-07-15 Thread Jon Doron
Signed-off-by: Jon Doron --- hw/i386/acpi-build.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c index b7bc2a..7708a27f70 100644 --- a/hw/i386/acpi-build.c +++ b/hw/i386/acpi-build.c @@ -975,7 +975,6 @@ static Aml

[PATCH v5 0/2] hyperv: vmbus: ACPI various corrections

2020-07-15 Thread Jon Doron
under the SB v3: Removed accidental change for the dct submodule head v2: Renamed irq0 to irq now that there is a single IRQ required Jon Doron (2): acpi: i386: Move VMBus DSDT entry to SB hw: hyperv: vmbus: Fix 32bit compilation hw/hyperv/vmbus.c| 3 ++- hw/i386/acpi-build.c | 12

  1   2   3   4   >