Reviewed-by: Max Reitz
Signed-off-by: John Snow
---
tests/qemu-iotests/112 | 122 +
tests/qemu-iotests/112.out | 4 +-
2 files changed, 124 insertions(+), 2 deletions(-)
diff --git a/tests/qemu-iotests/112 b/tests/qemu-iotests/112
index 7985cd1
To test the failure case, we modify iotests.py to allow us to specify
that we'd like to allow failures when we wait for block job events.
Reviewed-by: Max Reitz
Signed-off-by: John Snow
---
tests/qemu-iotests/112| 57 ++-
tests/qemu-iotest
QMP transactions that enable/disable bitmaps have extra error checking
surrounding them that prevent modifying bitmaps that are frozen.
Signed-off-by: John Snow
Reviewed-by: Max Reitz
---
block.c | 104 +-
blockdev.c|
Signed-off-by: John Snow
---
block.c| 20
include/block/block.h | 1 +
include/qemu/hbitmap.h | 10 ++
util/hbitmap.c | 47 +++
4 files changed, 78 insertions(+)
diff --git a/block.c b/block.c
Reviewed-by: Max Reitz
Signed-off-by: John Snow
---
tests/qemu-iotests/112 | 49 ++
tests/qemu-iotests/112.out | 4 ++--
2 files changed, 51 insertions(+), 2 deletions(-)
diff --git a/tests/qemu-iotests/112 b/tests/qemu-iotests/112
index da8f0e0
Signed-off-by: John Snow
---
docs/bitmaps.md | 253
1 file changed, 253 insertions(+)
create mode 100644 docs/bitmaps.md
diff --git a/docs/bitmaps.md b/docs/bitmaps.md
new file mode 100644
index 000..7cda146
--- /dev/null
+++ b/docs
On 02/20/2015 06:55 PM, Eric Blake wrote:
On 02/20/2015 04:07 PM, John Snow wrote:
Signed-off-by: John Snow
---
docs/bitmaps.md | 253
1 file changed, 253 insertions(+)
create mode 100644 docs/bitmaps.md
diff --git a/docs
On 02/19/2015 06:43 AM, Vladimir Sementsov-Ogievskiy wrote:
On 19.02.2015 02:45, John Snow wrote:
On 02/18/2015 09:00 AM, Vladimir Sementsov-Ogievskiy wrote:
Meta bitmap is a 'dirty bitmap' for the BdrvDirtyBitmap. It tracks
changes (set/unset) of this BdrvDirtyBitmap. It is
From: Paolo Bonzini
This patch begins refactoring the restart dma functions
out of bmdma to be shared with AHCI and other future
IDE HBA implementations.
Signed-off-by: Paolo Bonzini
Signed-off-by: John Snow
---
hw/ide/pci.c | 30 +++---
1 file changed, 19 insertions
From: Paolo Bonzini
Whenever an error stops the VM, ide_handle_rw_error does
"s->bus->dma->unit = s->unit". So we can just use
idebus_active_if.
Signed-off-by: Paolo Bonzini
Signed-off-by: John Snow
---
hw/ide/pci.c | 6 +++---
1 file changed, 3 insertions(+), 3 dele
TAPI migration workaround
- Some rephrasing for the comment in patch #15
- Added assertion that the busy_slot variable is within range
John Snow (3):
ahci: Migrate IDEStatus
ahci: Recompute cur_cmd on migrate post load
qtest/ide: Test flush / retry for ISA and PCI
Paolo Bonzini (14)
From: Paolo Bonzini
This moves more common restarting logic to the core IDE code.
Signed-off-by: Paolo Bonzini
Signed-off-by: John Snow
---
hw/ide/core.c | 6 ++
hw/ide/internal.h | 2 ++
hw/ide/pci.c | 15 ++-
hw/ide/pci.h | 5 ++---
4 files changed, 16
From: Paolo Bonzini
A helper is added that registers the IDEDMAOp .restart_cb()
via qemu_add_vm_change_state_handler instead of requiring
each HBA to register the callback themselves.
Signed-off-by: Paolo Bonzini
Signed-off-by: John Snow
---
hw/ide/cmd646.c | 3 +--
hw/ide/core.c | 5
From: Paolo Bonzini
Start moving the initial state of the current request to IDEBus, so that
AHCI can use it. The set_unit callback is not used anymore once this is
done.
Signed-off-by: Paolo Bonzini
Signed-off-by: John Snow
---
hw/ide/ahci.c | 7 ---
hw/ide/core.c | 6
From: Paolo Bonzini
This patch adds the restart_dma callback and adjusts
the ide_restart_dma function to utilize this callback
to call the BMDMA-specific restart code instead of statically
executing BMDMA-specific code.
Signed-off-by: Paolo Bonzini
Signed-off-by: John Snow
---
hw/ide
From: Paolo Bonzini
Pass the containing IDEBus to the restart_cb instead
of the more specific BMDMAState child.
Signed-off-by: Paolo Bonzini
Signed-off-by: John Snow
---
hw/ide/core.c | 2 +-
hw/ide/pci.c | 10 +-
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/hw
This patch adds tests for werror and rerror functionality
for the PCI and ISA ide buses.
Tests for the AHCI device are to be included at a later
date after requisite patches have been merged upstream
to support needed functionality by the tests.
Signed-off-by: Paolo Bonzini
Signed-off-by: John
1 callback would
return true if error_status != 0 and the bus is PATA; the v2 callback
would return true if error_status != 0 and the bus is AHCI.
Forward migration keeps working.
Signed-off-by: Paolo Bonzini
Signed-off-by: John Snow
---
hw/ide/core.c | 5 -
1 file changed, 4 insertions(+),
IDEDMAOps.restart_cb() member.
Signed-off-by: Paolo Bonzini
Signed-off-by: John Snow
---
hw/ide/core.c | 80 ++-
hw/ide/internal.h | 2 ++
hw/ide/pci.c | 79 --
hw/ide/pci.h | 1 -
4 files
From: Paolo Bonzini
Signed-off-by: Paolo Bonzini
Signed-off-by: John Snow
---
hw/ide/core.c | 12
hw/ide/internal.h | 4
2 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/hw/ide/core.c b/hw/ide/core.c
index ff28db0..ef52f35 100644
--- a/hw/ide/core.c
+++ b
From: Paolo Bonzini
With restarts now handled by ide_restart_cb and
the IDEDMAOps.restart_dma() member, remove the old
restart_cb callback.
Signed-off-by: Paolo Bonzini
Signed-off-by: John Snow
---
hw/ide/ahci.c | 5 -
hw/ide/core.c | 5 -
hw/ide/internal.h | 1 -
hw/ide
will restart
the operation and command list processing will proceed after the
erroring command has been completed.
Signed-off-by: Paolo Bonzini
Signed-off-by: John Snow
---
hw/ide/ahci.c | 23 +++
1 file changed, 15 insertions(+), 8 deletions(-)
diff --git a/hw/ide/ahci.c b/hw
he cur_cmd pointer post-migration, we can utilize
the busy_slot index to figure out where the command header
we are still processing is.
This allows a machine in a halted state from rerror=stop or
werror=stop to be migrated and resume operations without issue.
Signed-off-by: John Snow
---
hw/ide/
From: Paolo Bonzini
Signed-off-by: Paolo Bonzini
Signed-off-by: John Snow
---
hw/ide/isa.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/hw/ide/isa.c b/hw/ide/isa.c
index b084162..5eb35c2 100644
--- a/hw/ide/isa.c
+++ b/hw/ide/isa.c
@@ -74,7 +74,8 @@ static void
e the placeholder
error code from initialization time.
Reviewed-by: Paolo Bonzini
Signed-off-by: John Snow
---
hw/ide/ahci.c | 1 +
hw/ide/internal.h | 3 +++
2 files changed, 4 insertions(+)
diff --git a/hw/ide/ahci.c b/hw/ide/ahci.c
index bc6d5ce..3f4fc77 100644
--- a/hw/ide/ahci.c
+++ b/h
setting it there is
not appropriate.
Signed-off-by: Paolo Bonzini
Signed-off-by: John Snow
---
hw/ide/atapi.c | 3 +--
hw/ide/core.c | 3 +--
2 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/hw/ide/atapi.c b/hw/ide/atapi.c
index 1bf8b34..950e311 100644
--- a/hw/ide/atapi.c
+++ b/hw
On 02/23/2015 12:03 PM, Max Reitz wrote:
On 2015-02-20 at 18:07, John Snow wrote:
Signed-off-by: John Snow
---
block.c| 20
include/block/block.h | 1 +
include/qemu/hbitmap.h | 10 ++
util/hbitmap.c | 47
I've been seeing this failure pop up very occasionally and I can usually
get the test to pass again by just re-running, but every now and again:
GTESTER check-qtest-x86_64
blkdebug: Suspended request 'A'
blkdebug: Resuming request 'A'
main-loop: WARNING: I/O thread spun for 1000 iterations
main-
On 02/23/2015 05:35 PM, Marc Marà wrote:
El Mon, 23 Feb 2015 17:22:57 -0500
John Snow escribió:
I've been seeing this failure pop up very occasionally and I can
usually get the test to pass again by just re-running, but every now
and again:
GTESTER check-qtest-x86_64
blkdebug: Susp
was checked in for the rerror/werror migration fixes series.
With the expanded functionality of libqos, we test error injection
and error recovery for the AHCI device.
John Snow (6):
qtest/ahci: Add simple flush test
qtest/ahci: Allow override of default CLI options
libqtest: add
Pull this helper out of ide-test and into libqos,
to be shared with ahci-test.
Signed-off-by: John Snow
---
tests/ide-test.c | 23 +--
tests/libqos/libqos.c | 22 ++
tests/libqos/libqos.h | 1 +
3 files changed, 24 insertions(+), 22 deletions
it is convenient to leave the responses
in the stream.
Signed-off-by: John Snow
---
tests/libqtest.c | 30 +-
tests/libqtest.h | 27 +++
2 files changed, 56 insertions(+), 1 deletion(-)
diff --git a/tests/libqtest.c b/tests/libqtest.c
index a3
Signed-off-by: John Snow
---
tests/ahci-test.c| 67
tests/libqos/libqos-pc.c | 5
tests/libqos/libqos-pc.h | 1 +
3 files changed, 51 insertions(+), 22 deletions(-)
diff --git a/tests/ahci-test.c b/tests/ahci-test.c
index 378cfe5
Signed-off-by: John Snow
---
tests/ahci-test.c | 34 ++
1 file changed, 34 insertions(+)
diff --git a/tests/ahci-test.c b/tests/ahci-test.c
index f536b19..378cfe5 100644
--- a/tests/ahci-test.c
+++ b/tests/ahci-test.c
@@ -774,6 +774,29 @@ static void
Signed-off-by: John Snow
---
tests/ahci-test.c | 44
1 file changed, 44 insertions(+)
diff --git a/tests/ahci-test.c b/tests/ahci-test.c
index d43da45..f194cbc 100644
--- a/tests/ahci-test.c
+++ b/tests/ahci-test.c
@@ -46,6 +46,7 @@
/*** Globals
Allow the user to poll until a desired interrupt occurs.
Signed-off-by: John Snow
---
tests/ide-test.c | 11 +--
tests/libqtest.c | 16
tests/libqtest.h | 20
3 files changed, 37 insertions(+), 10 deletions(-)
diff --git a/tests/ide-test.c b/tests
In writing migration tests for qtest and ahci-test, I ran into an
interesting pattern and wanted to know if this was expected:
1) Using blkdebug, I inject an error to execute once for the first flush
request.
2) Executing the command, I get a STOP event.
3) I migrate the VM, and poll the sourc
On 02/24/2015 11:31 AM, John Snow wrote:
In writing migration tests for qtest and ahci-test, I ran into an
interesting pattern and wanted to know if this was expected:
1) Using blkdebug, I inject an error to execute once for the first flush
request.
2) Executing the command, I get a STOP
AHCI migration to become stable.
John Snow (5):
libqos: Add migration helpers
ich9/ahci: Enable Migration
qtest/ahci: Add migration test
qtest/ahci: add migrate dma test
qtest/ahci: add flush migrate test
hw/ide/ahci.c | 1 -
hw/ide/ich.c | 1 -
tests/ahci-test.c
Write to one guest, migrate, and then read from the other.
adjust ahci_io to clear any buffers it creates, so that we
can use ahci_io safely on both guests knowing we are using
empty buffers and not accidentally re-using data.
Signed-off-by: John Snow
---
tests/ahci-test.c | 46
s from the source to the destination.
Signed-off-by: John Snow
---
tests/libqos/libqos.c | 75 +++
tests/libqos/libqos.h | 2 ++
tests/libqos/malloc.c | 74 ++
tests/libqos/malloc.h | 1 +
4 files ch
- test_migrate_sanity test case is added.
Signed-off-by: John Snow
---
tests/ahci-test.c | 85 +++
1 file changed, 85 insertions(+)
diff --git a/tests/ahci-test.c b/tests/ahci-test.c
index f194cbc..4bd81fa 100644
--- a/tests/ahci-test.c
+++ b/tests/ahci-test.c
Use blkdebug to inject an error on first flush, then attempt to flush
on the first guest. When the error halts the VM, migrate to the
second VM, and attempt to resume the command.
Signed-off-by: John Snow
---
tests/ahci-test.c | 53 -
1 file
Lift the flag preventing the migration of the ICH9/AHCI devices.
Signed-off-by: John Snow
---
hw/ide/ahci.c | 1 -
hw/ide/ich.c | 1 -
2 files changed, 2 deletions(-)
diff --git a/hw/ide/ahci.c b/hw/ide/ahci.c
index e1ae36f..66f47f2 100644
--- a/hw/ide/ahci.c
+++ b/hw/ide/ahci.c
@@ -1421,7
On 02/24/2015 12:38 PM, John Snow wrote:
The day we all feared is here, and I am proposing we allow the
migration of the AHCI device. The series that precedes this
which fixes AHCI migration has improved the stability of the
device and as this test series proves, is stable.
I am justifying
On 02/19/2015 05:29 PM, John Snow wrote:
This series is based on top of my ahci DMA test series, which is in
turn based on the ahci preliminary refactoring series. Both are currently
pending on stefanha/block.
prerequisites are now upstream.
--js
This series adds many variations that
>pdev, dev->addr + QVIRTIO_ISR_STATUS) & 2;
1,600+ runs and no hang, thanks :)
Tested-by: John Snow
Reviewed-by: John Snow
qtest currently has a static buffer of size 1024 that if we
overflow, ignores the additional data silently which leads
to hangs or stream failures.
Use glib's string facilities to allow arbitrarily long data.
Signed-off-by: John Snow
---
qtest.c | 5 +++--
1 file changed, 3 insertions(
This will enable the testing of high offsets without
wasting a lot of disk space, and does not impact the
previous tests.
mkimg and mkqcow2 are added to libqos for other tests.
Signed-off-by: John Snow
---
tests/Makefile| 1 +
tests/ahci-test.c | 16 ++--
tests/libqos
Even though it's just the reserved space, make sure they're zeroes.
Signed-off-by: John Snow
---
tests/libqos/ahci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/libqos/ahci.c b/tests/libqos/ahci.c
index a6105c7..9dc505c 100644
--- a/tests/libqos/ahci.c
+
configurations,
different I/O commands for PIO and DMA, different address scheme
combinations for LBA28 and LBA48, and different sector offsets.
John Snow (8):
libqos/ahci: Zero-fill AHCI headers
qtest/ahci: Add a macro bootup routine
libqos/ahci: add ahci command helpers
qtest/ahci: Add DMA test
Test what happens when we try to use extremely short PRDTs
to accomplish a small data transfer.
Signed-off-by: John Snow
---
tests/ahci-test.c | 59 +++
1 file changed, 59 insertions(+)
diff --git a/tests/ahci-test.c b/tests/ahci-test.c
index
(Please don't top-post on qemu-devel: gmail is kind of awful about this,
but if you expand the conversation while in-reply, you can edit beneath
the quote instead of above.)
On 02/26/2015 04:31 PM, Jordan Hargrave wrote:
The problem is the FIS registers have stale data.
SeaBIOS initialization
|| probably does not mean the same thing as |.
Additionally, allow users to submit a prd_size of 0
to indicate that they'd like to continue using the default.
Signed-off-by: John Snow
---
tests/libqos/ahci.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/tests/l
Use blkdebug to inject an error on first flush, then attempt to flush
on the first guest. When the error halts the VM, migrate to the
second VM, and attempt to resume the command.
Signed-off-by: John Snow
---
tests/ahci-test.c | 52 +++-
1 file
- test_migrate_sanity test case is added.
Signed-off-by: John Snow
---
tests/ahci-test.c | 88 +++
1 file changed, 88 insertions(+)
diff --git a/tests/ahci-test.c b/tests/ahci-test.c
index 64dff8d..b9b1f25 100644
--- a/tests/ahci-test.c
+++ b/tests/ahci-test.c
If we're going to test the migration of halted DMA jobs,
we should probably check to make sure we can resume them
locally as a first step.
Signed-off-by: John Snow
---
tests/ahci-test.c | 60 +++
1 file changed, 60 insertions(+)
diff --
Sometimes we want a command to halt the VM instead
of complete successfully, so it'd be nice to let the
libqos/ahci functions cope with such scenarios.
Signed-off-by: John Snow
---
tests/libqos/ahci.c | 27 +++
tests/libqos/ahci.h | 3 +++
2 files changed, 30 inser
On 02/27/2015 09:30 AM, Paolo Bonzini wrote:
On 27/02/2015 00:50, John Snow wrote:
+/* Write, migrate, then read. */
+ahci_io(src, px, CMD_WRITE_DMA, tx, bufsize, 0);
+ahci_migrate(src, dst, uri);
+ahci_io(dst, px, CMD_READ_DMA, rx, bufsize, 0);
IIUC, tests for
On 02/27/2015 01:32 PM, Eric Blake wrote:
On 02/27/2015 10:24 AM, Vladimir Sementsov-Ogievskiy wrote:
Reviewed-by: John Snow
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
block.c| 1 +
include/qemu/hbitmap.h | 8
qapi/block-core.json | 4 +++-
util
for 'in'
0007: set chunk size to 1kb, disable live iteration for
migrating data < 1mb size.
tests: only one with md5 sum is here. used function event_wait
by John Snow. (I hope, you don't mind me just adding this
function with your 'Signed-off-by&#
bdrv_find_dirty_bitmap to find a dirty bitmap by name, will
be used later when other QMP commands want to reference dirty bitmap by
name.
Add bdrv_dirty_bitmap_make_anon. This unsets the name of dirty bitmap.
Signed-off-by: Fam Zheng
Signed-off-by: John Snow
Reviewed-by: Max Reitz
Reviewed-by
on no longer exist.
09: Since 2.4
10: Since 2.4
Demingled QMP command documentation.
11: Since 2.4
15: Test 112 --> 124
17: Number of tests altered. (Only 4, now.)
Fam Zheng (1):
qapi: Add optional field "name" to block dirty bitmap
John Snow (16):
docs: incremental backup do
o block-core.json will be re-used in future patches
in this series, see:
'qapi: Add transaction support to block-dirty-bitmap-{add, enable, disable}'
Signed-off-by: John Snow
Reviewed-by: Max Reitz
Reviewed-by: Eric Blake
---
block.c | 20 ++
block/mirr
This returns the granularity (in bytes) of dirty bitmap,
which matches the QMP interface and the existing query
interface.
Signed-off-by: John Snow
Reviewed-by: Max Reitz
Reviewed-by: Eric Blake
---
block.c | 8 ++--
include/block/block.h | 1 +
2 files changed, 7 insertions
We treat this field with a variety of different types everywhere
in the code. Now it's just uint32_t.
Reviewed-by: Eric Blake
Reviewed-by: Max Reitz
Signed-off-by: John Snow
---
block.c | 11 ++-
block/mirror.c| 4 ++--
include/block/block.h
QMP transactions that enable/disable bitmaps have extra error checking
surrounding them that prevent modifying bitmaps that are frozen.
Signed-off-by: John Snow
Reviewed-by: Max Reitz
---
block.c | 104 +-
blockdev.c|
running speed for particularly sparse
bitmaps by using iterators, but the running time for dense maps
will be worse.
We present the simpler solution first, and we can refine it later
if needed.
Signed-off-by: John Snow
Reviewed-by: Max Reitz
Reviewed-by: Stefan Hajnoczi
---
include/qemu
removed for now until
a use case emerges where this state must be revealed to the user.
The disabled state WILL be used internally for bitmap migration and
bitmap persistence.
Signed-off-by: Fam Zheng
Signed-off-by: John Snow
---
block.c | 25 +
include/block
Signed-off-by: John Snow
Reviewed-by: Max Reitz
---
tests/qemu-iotests/124 | 89 ++
tests/qemu-iotests/124.out | 5 +++
tests/qemu-iotests/group | 1 +
3 files changed, 95 insertions(+)
create mode 100644 tests/qemu-iotests/124
create mode
Signed-off-by: John Snow
---
block.c| 22
include/block/block.h | 1 +
include/qemu/hbitmap.h | 10 ++
util/hbitmap.c | 54 ++
4 files changed, 87 insertions(+)
diff --git a/block.c b/block.c
Adds the "disabled" and "frozen" status booleans.
Signed-off-by: Fam Zheng
Signed-off-by: John Snow
Reviewed-by: Max Reitz
---
block.c | 2 ++
qapi/block-core.json | 7 ++-
2 files changed, 8 insertions(+), 1 deletion(-)
diff --git a/block.c b/block.c
in
Signed-off-by: John Snow
---
docs/bitmaps.md | 303
1 file changed, 303 insertions(+)
create mode 100644 docs/bitmaps.md
diff --git a/docs/bitmaps.md b/docs/bitmaps.md
new file mode 100644
index 000..ebb6ae8
--- /dev/null
+++ b/docs
Add bdrv_clear_dirty_bitmap and a matching QMP command,
qmp_block_dirty_bitmap_clear that enables a user to reset
the bitmap attached to a drive.
This allows us to reset a bitmap in the event of a full
drive backup.
Reviewed-by: Max Reitz
Signed-off-by: John Snow
---
block.c
On 01/27/2015 07:48 AM, Hannes Reinecke wrote:
On 01/23/2015 06:21 PM, Stefan Hajnoczi wrote:
Dear libvirt, KVM, and QEMU contributors,
The Google Summer of Code season begins soon and it's time to collect
our thoughts for mentoring students this summer working full-time on
libvirt, KVM, and Q
Ping: Waiting for reviews on patches #6 (Marc?), and re-reviews for
patches #12 and #15 (Paolo?)
Thanks
--JS
On 01/19/2015 03:15 PM, John Snow wrote:
This series aims to do two main things:
(1) Eliminate global state out of the ahci-test file so that
the tests are more functional. This
On 01/27/2015 02:45 PM, Max Reitz wrote:
blk_by_name() may return a BlockBackend for which blk_bs() returns NULL.
In this case, an error should be returned (instead of just returning
NULL without modifying *errp).
Signed-off-by: Max Reitz
---
block.c | 5 +
1 file changed, 5 insertions
On 01/29/2015 09:58 AM, Markus Armbruster wrote:
The test uses QMP introspection to find PCI devices, then tries to
cold-plug each of them. Could be extended to hot-plug and unplug.
The tests' QMP introspection part is patterned after Andreas's
qom-test, which uses QMP to find machine types.
On 01/12/2015 11:30 AM, John Snow wrote:
Welcome to version 11. I hope you are enjoying our regular newsletter.
This patchset enables the in-memory part of the incremental backup
feature. A patchset by Vladimir Sementsov-Ogievskiy enables the
migration of in-memory dirty bitmaps, and a future pat
Post-holiday bump that this is sitting out there, awaiting love.
If this gets merged, we should be able to enable Q35 migration soon,
which would be nice.
--js
On 12/16/2014 08:35 PM, John Snow wrote:
This series was written mostly by Paolo Bonzini to do two things:
1. Unify the restart
On 01/30/2015 04:38 AM, Paolo Bonzini wrote:
On 30/01/2015 01:44, John Snow wrote:
Post-holiday bump that this is sitting out there, awaiting love.
If this gets merged, we should be able to enable Q35 migration soon,
which would be nice.
Not sure how valuable my opinion is as the author
On 01/30/2015 09:32 AM, Kevin Wolf wrote:
Am 21.01.2015 um 10:34 hat Markus Armbruster geschrieben:
I'm afraid I forgot much of the discussion we had before the break, and
only now it's coming back, slowly.
Quoting myself on naming parameters identifying nodes[*]:
John Snow p
ff-by: John Snow
---
tests/ahci-test.c | 13 ++---
tests/libqos/ahci.c | 14 ++
tests/libqos/ahci.h | 2 ++
3 files changed, 18 insertions(+), 11 deletions(-)
diff --git a/tests/ahci-test.c b/tests/ahci-test.c
index 63ecf73..e744f44 100644
--- a/tests/ahci-test.c
+++ b/
c facilities to
support this series.
This patchset is a necessary step in checking in AHCI/DMA migration
tests that I will later use as proof as suitability of enabling the
ICH9 and AHCI migration flags.
~John
John Snow (19):
libqos/ahci: Add ahci_port_select helper
libqos/ahci: Add ahci_po
A simple helper that asserts a given port is not busy processing any
commands via the TFD, Command Issue and SACT registers.
Signed-off-by: John Snow
---
tests/ahci-test.c | 1 +
tests/libqos/ahci.c | 18 ++
tests/libqos/ahci.h | 1 +
3 files changed, 20 insertions(+)
diff
This helper identifies which port of the
AHCI HBA has a device we may run tests on.
Signed-off-by: John Snow
---
tests/ahci-test.c | 19 ++-
tests/libqos/ahci.c | 27 +++
tests/libqos/ahci.h | 1 +
3 files changed, 30 insertions(+), 17 deletions
Adds setters for size, prd_size and both via set_sizes.
Signed-off-by: John Snow
---
tests/libqos/ahci.c | 22 ++
tests/libqos/ahci.h | 5 +
2 files changed, 27 insertions(+)
diff --git a/tests/libqos/ahci.c b/tests/libqos/ahci.c
index 594c821..3375d54 100644
--- a
rename the "b1" and "b2" fields
to be a unified uint16_t named "flags."
Signed-off-by: John Snow
---
tests/ahci-test.c | 6 +++---
tests/libqos/ahci.h | 7 +++
2 files changed, 6 insertions(+), 7 deletions(-)
diff --git a/tests/ahci-test.c b/tests/ahci-test.c
i
Helps to verify that a command completed successfully.
Signed-off-by: John Snow
---
tests/ahci-test.c | 16 ++--
tests/libqos/ahci.c | 12
tests/libqos/ahci.h | 1 +
3 files changed, 15 insertions(+), 14 deletions(-)
diff --git a/tests/ahci-test.c b/tests/ahci
Add a helper that assists in clearing out potentially old error and FIS
information from an AHCI port's data structures. This ensures we always
start with a blank slate for interrupt and FIS receipt information.
Signed-off-by: John Snow
---
tests/ahci-test.c | 9 ++---
tests/l
ahci_port_check_error checks a given port's error registers and asserts
that everything from the port-level view is still OK.
Signed-off-by: John Snow
---
tests/ahci-test.c | 8 +---
tests/libqos/ahci.c | 22 ++
tests/libqos/ahci.h | 1 +
3 files change
Adds a test case for AHCI wherein we write a 4K
block of a changing pattern to sector 0, then
read back that 4K and compare the transmit and
receive buffers.
Signed-off-by: John Snow
---
tests/ahci-test.c | 52
1 file changed, 52 insertions
Add a routine that can be used to engage the AHCI
device at a not-granular level so that bringing up
the functionality of the HBA is easy in future tests
that are not concerned with testing the bring-up process.
Signed-off-by: John Snow
---
tests/ahci-test.c | 19 ---
1 file
t not its DMA buffer!
Lastly, the command table pointer fields (dba and dbau) are merged into
a single 64bit value to make managing 64bit tests simpler.
Signed-off-by: John Snow
---
tests/ahci-test.c | 43 ---
tests/libqos/ahci.c
Clean up guest memory being used in ahci_clean_mem, to be
called during ahci_shutdown. With all guest memory leaks removed,
add an option to the allocator to throw an assertion if a leak
occurs.
This test adds some sanity to both the AHCI library and the
allocator.
Signed-off-by: John Snow
ahci_guest_io is a shorthand function that will, in one shot,
execute a data command on the guest to the specified guest buffer
location, in the requested amount.
Signed-off-by: John Snow
---
tests/libqos/ahci.c | 15 +++
tests/libqos/ahci.h | 2 ++
2 files changed, 17 insertions
te to hand-pick,
one-by-one, which preprocessor definitions are useful per-each test.
These definitions include:
ATA Command Mnemonics
Current expected AHCI sector size
FIS magic bytes
REG_H2D_FIS flags
Command Header flags
Signed-off-by: John Snow
---
tests/ahci-test.c | 12 ++--
structure is added for the
PIO Setup FIS type. Existing FIS types (H2D and D2H) have had their
members renamed slightly to condense reserved members into fewer
fields; and LBA fields are now represented by arrays of 8 byte chunks
instead of independent variables.
Signed-off-by: John Snow
that caps the property array is an
invalid ATA command, namely 0x01. 0x00 is NOP and 0xFF is reserved for
vendor usage, so I chose the first invalid one instead.
Signed-off-by: John Snow
---
tests/libqos/ahci.c | 42 ++
1 file changed, 42 insertions(+)
di
the command header with sane values.
command_table_init - Initialize the command table with sane values.
Signed-off-by: John Snow
---
tests/ahci-test.c | 73 +--
tests/libqos/ahci.c | 202
tests/libqos/ahci.h | 15
3
301 - 400 of 11520 matches
Mail list logo
