I've been doing background reading on the wiki and have found multiple dead
links / errors I'd like to fix. Could an admin email me off list regarding a
wiki account under a different email address / name ?
Thanks !
Public bug reported:
https://github.com/anholt/libepoxy/issues/148
** Affects: qemu
Importance: Undecided
Status: New
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1746394
Title:
No
Public bug reported:
Following the instructions here
https://wiki.qemu.org/Documentation/Platforms/m68k I was able to
successfully install debian. However, running apt-get update stalls
after the first 1-2MB.
root@debian:~# apt-get update
Get:1 http://ftp.ports.debian.org/debian-ports sid InRelea
I also see the same problem with version 4.2.1
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1926497
Title:
dp83932 stops working after a short while
Status in QEMU:
New
Bug description:
Foll
The kernel in my m68k disk image is vmlinux-4.16.0-1-m68k which is
presumably what comes from
https://cdimage.debian.org/cdimage/ports/10.0/m68k/iso-cd/debian-10.0
-m68k-NETINST-1.iso. Is there a debian image that uses a newer kernel?
--
You received this bug notification because you are a member
It looks like using
https://cdimage.debian.org/cdimage/ports/snapshots/2021-04-17/debian-10.0.0
-m68k-NETINST-1.iso instead fixes the issue. Perhaps the instruction on
https://wiki.qemu.org/Documentation/Platforms/m68k should be updated.
--
You received this bug notification because you are a mem
On 07/30/2012 05:34 PM, Supriya Kannery wrote:
> Struct BDRVReopenState along with three reopen related functions
> introduced for handling reopening of images safely. This can be
> extended by each of the block drivers to reopen respective
> image files.
>
> Signed-off-by: Supriya Kannery
>
> -
On 07/30/2012 05:34 PM, Supriya Kannery wrote:
> Struct BDRVReopenState along with three reopen related functions
> introduced for handling reopening of images safely. This can be
> extended by each of the block drivers to reopen respective
> image files.
>
> Signed-off-by: Supriya Kannery
>
> -
On 07/30/2012 05:34 PM, Supriya Kannery wrote:
> raw-posix driver changes for bdrv_reopen_xx functions to
> safely reopen image files. Reopening of image files while
> changing hostcache dynamically is handled here.
>
> Signed-off-by: Supriya Kannery
>
> ---
> Index: qemu/block/raw.c
>
On 07/30/2012 05:34 PM, Supriya Kannery wrote:
> For changing host pagecache setting of a running VM, it is
> important to have a safe way of reopening its image file.
>
> V1 introduced:
> * a generic way to reopen image files safely.
> In this approach, before reopening an image, for e
On 07/30/2012 05:35 PM, Supriya Kannery wrote:
> qcow2 driver changes for bdrv_reopen_xx functions to
> safely reopen image files. Reopening of image files while
> changing hostcache dynamically is handled here.
>
> Signed-off-by: Supriya Kannery
>
> ---
> Index: qemu/block/qcow2.c
> ===
On 08/09/2012 05:20 AM, Kevin Wolf wrote:
> Am 09.08.2012 06:26, schrieb Jeff Cody:
>> On 07/30/2012 05:34 PM, Supriya Kannery wrote:
>>> Struct BDRVReopenState along with three reopen related functions
>>> introduced for handling reopening of images safely. This can be
ive-mirror and friends?
> https://lists.gnu.org/archive/html/qemu-devel/2012-07/msg03082.html
>
> Jeff - where do we stand on block-commit and friends?
> https://lists.gnu.org/archive/html/qemu-devel/2012-07/msg04293.html
block-commit and friends will not be in 1.2, but rather 1.3
&
size) != 0 ||
> +le32_to_cpu(footer.footer_marker.type) != MARKER_FOOTER ||
> +le64_to_cpu(footer.eos_marker.val) != 0 ||
> +le32_to_cpu(footer.eos_marker.size) != 0 ||
> +le32_to_cpu(footer.eos_marker.type) != MARKER_END_OF_STREAM)
> +{
> +return -EINVAL;
> +}
> +
> +header = footer.header;
> +}
> +
> l1_entry_sectors = le32_to_cpu(header.num_gtes_per_gte)
> * le64_to_cpu(header.granularity);
> if (l1_entry_sectors == 0) {
>
Reviewed-by: Jeff Cody
On 10/10/2012 02:13 PM, Eric Blake wrote:
> On 10/09/2012 11:56 PM, Jeff Cody wrote:
>> Currently, bdrv_find_backing_image compares bs->backing_file with
>> what is passed in as a backing_file name. Mismatches may occur,
>> however, when bs->backing_file and backing_fi
On 10/10/2012 02:34 PM, Eric Blake wrote:
> On 10/10/2012 12:29 PM, Jeff Cody wrote:
>
>>> That's a LOT of stack space, which risks stack overflow, will mostly be
>>> unused, and still doesn't work if you have super-deep hierarchies larger
>>> th
On 10/12/2012 05:52 PM, Eric Blake wrote:
> On 10/09/2012 11:56 PM, Jeff Cody wrote:
>> Currently, bdrv_find_backing_image compares bs->backing_file with
>> what is passed in as a backing_file name. Mismatches may occur,
>> however, when bs->backing_file and backing_fi
In QEMUMonitorProtocol, commit e9d17b6 removed the __sockfile creation
from __negotiate_capabilities(), which breaks _accept(). This causes
failures in qemu-io python based tests (i.e. tests 030 and 040).
This patch creates the sockfile in __accept() as well.
---
QMP/qmp.py | 1 +
1 file changed
On 10/15/2012 02:57 PM, Jeff Cody wrote:
> In QEMUMonitorProtocol, commit e9d17b6 removed the __sockfile creation
> from __negotiate_capabilities(), which breaks _accept(). This causes
> failures in qemu-io python based tests (i.e. tests 030 and 040).
>
> This patch creates
In QEMUMonitorProtocol, commit e9d17b6 removed the __sockfile creation
from __negotiate_capabilities(), which breaks _accept(). This causes
failures in qemu-io python based tests (i.e. tests 030 and 040).
This patch creates the sockfile in __accept() as well.
Signed-off-by: Jeff Cody
---
QMP
v1 -> v2 differences:
* Updated changes to be protocol friendly
* Updated block-commit tests to account for different error message
wording
* Updated block-commit tests to add relative backing filename tests
* In bdrv_find_backing_image(), use g_malloc() instead of char arrays
Jeff Cody
Some of the error messages put out by block-commit have changed
slightly, which causes 2 tests cases for block-commit to fail.
This patch updates the test cases to look for the correct error
output.
Signed-off-by: Jeff Cody
---
tests/qemu-iotests/040 | 4 ++--
1 file changed, 2 insertions(+), 2
The previous block commit used absolute filenames for all block-commit
images and commands; this adds relative filenames for the same tests.
Signed-off-by: Jeff Cody
---
tests/qemu-iotests/040 | 102 +
tests/qemu-iotests/040.out | 4 +-
2 files
to the current image filename being searched, and then use
realpath() to make all comparisons based on absolute filenames.
This also changes bdrv_find_backing_image to no longer be recursive,
but iterative.
Signed-off-by: Jeff Cody
---
block.
reachable from top.
Signed-off-by: Jeff Cody
---
block/commit.c | 9 -
blockdev.c | 21 +++--
2 files changed, 11 insertions(+), 19 deletions(-)
diff --git a/block/commit.c b/block/commit.c
index 733c914..13d9e82 100644
--- a/block/commit.c
+++ b/block/commit.c
On 10/16/2012 11:22 AM, Eric Blake wrote:
> On 10/16/2012 08:44 AM, Jeff Cody wrote:
>> This simplifies some code and error checking, and also fixes a bug.
>>
>> bdrv_find_backing_image() should only be passed absolute filenames,
>> or filenames relative to the chain.
On 10/16/2012 11:12 AM, Eric Blake wrote:
> On 10/16/2012 08:44 AM, Jeff Cody wrote:
>> Currently, bdrv_find_backing_image compares bs->backing_file with
>> what is passed in as a backing_file name. Mismatches may occur,
>> however, when bs->backing_file and backing_f
tests to add relative backing filename tests
* In bdrv_find_backing_image(), use g_malloc() instead of char arrays
Jeff Cody (4):
block: make bdrv_find_backing_image compare canonical filenames
block: in commit, determine base image from the top image
qemu-iotests: qemu-io tests update for
longer be recursive,
but iterative.
Signed-off-by: Jeff Cody
---
block.c | 60 ++--
1 file changed, 54 insertions(+), 6 deletions(-)
diff --git a/block.c b/block.c
index e95f613..5e7fc9e 100644
--- a/block.c
+++ b/block.c
@@ -3123,22 +3123,
reachable from top.
Signed-off-by: Jeff Cody
---
block/commit.c | 9 -
blockdev.c | 21 +++--
2 files changed, 11 insertions(+), 19 deletions(-)
diff --git a/block/commit.c b/block/commit.c
index 733c914..13d9e82 100644
--- a/block/commit.c
+++ b/block/commit.c
The previous block commit used absolute filenames for all block-commit
images and commands; this adds relative filenames for the same tests.
Signed-off-by: Jeff Cody
---
tests/qemu-iotests/040 | 102 +
tests/qemu-iotests/040.out | 4 +-
2 files
Some of the error messages put out by block-commit have changed
slightly, which causes 2 tests cases for block-commit to fail.
This patch updates the test cases to look for the correct error
output.
Signed-off-by: Jeff Cody
---
tests/qemu-iotests/040 | 4 ++--
1 file changed, 2 insertions(+), 2
On 06/15/2012 04:47 PM, Supriya Kannery wrote:
> New command "block_set_hostcache" added for dynamically changing
> host pagecache setting of a block device.
>
> Usage:
> block_set_hostcache
> = block device
> = on/off
>
> Example:
> (qemu) block_set_hostcache ide0-hd0 off
>
> Sig
On 06/15/2012 04:47 PM, Supriya Kannery wrote:
> Enhance "info block" to display hostcache setting for each
> block device.
>
> Example:
> (qemu) info block
> ide0-hd0: removable=0 file=../rhel6-32.raw ro=0 drv=raw encrypted=0
>
> Enhanced to display "hostcache" setting:
> (qemu) info block
> ide
ed": false, "name": "guest-file-seek"},
{"enabled": false, "name": "guest-file-write"},
{"enabled": false, "name": "guest-file-read"},
{"enabled": false, "name": "guest-file-close"},
{"enabled": false, "name": "guest-file-open"},
{"enabled": true, "name": "guest-shutdown"},
{"enabled": true, "name": "guest-info"},
{"enabled": true, "name": "guest-ping"},
{"enabled": true, "name": "guest-sync"},
{"enabled": true, "name": "guest-sync-delimited"}]}}
Jeff
On Wed, Jan 30, 2013 at 10:24:44AM +0100, Stefan Hajnoczi wrote:
> On Sat, Jan 26, 2013 at 03:21:27AM -, Peter Rehley wrote:
> > Public bug reported:
>
> CCed Stefan Weil and Jeff Cody who may be thoughts on this bug.
>
> If you would like to contribute your pat
On Fri, Feb 01, 2013 at 07:04:36PM +0100, Stefan Weil wrote:
> Am 01.02.2013 18:48, schrieb Jeff Cody:
> > On Wed, Jan 30, 2013 at 10:24:44AM +0100, Stefan Hajnoczi wrote:
> >> On Sat, Jan 26, 2013 at 03:21:27AM -, Peter Rehley wrote:
> >>> Public bug reported:
atch has pretty significant conflicts, so I didn't bother
resolving it to test.
Could you rebase, and then repost?
Thanks,
Jeff
> diff --git a/block/vpc.c b/block/vpc.c
> index bcc2ace..fff103b 100644
> --- a/block/vpc.c
> +++ b/block/vpc.c
> @@ -164,34 +164,30 @@ static int vpc_o
:
> >
> > * Create a VHD disk image (either with QEMU or MS tools).
> > * Run a modern guest OS (which does not use CHS) on this image
> > using Virtual PC or VirtualBox and write into the last disk blocks.
> > * Copy the image to another format using qemu-img.
> >
> > => The last blocks are missing now.
>
> When I wrote that code it wasn't like this. I doubt that Linux was
> relying on the geometry until recently, so is this a change in the
> behaviour of newer Virtual PC versions? If yes, that would be very nasty
> to deal with.
>
> I'm very sure that back then I needed to use the geometry so that images
> could be exchanged between qemu and VPC. If I didn't, they would either
> get truncated or appear to be larger on one of both.
>
Hi Kevin,
I can verify the issue he is seeing (see my comments on Bug 1105670
(https://bugs.launchpad.net/qemu/+bug/1105670/comments/3), at least
using Hyper-V. I haven't tried it against VPC from Win7.
Jeff
-
> then maybe it's best to remove the comment altogether instead of making
> such claims. The new code is the intuitively expected one anyway.
>
> Kevin
Kevin,
I can test this on Virtual PC on a Win 7 install, as well as
Hyper-V (I've already tested the equivalent of this patch on Hyper-V
on Windows Server 2012). I'll do some testing today with this - if
you have anything in particular you want me to look at, just let me
know.
Stefan, did you test if this behaves the same for all disk sizes, or
only for larger disk sizes of 127G and up?
Thanks,
Jeff
On Mon, Feb 11, 2013 at 09:54:56AM +0100, Kevin Wolf wrote:
> Am 08.02.2013 18:43, schrieb Stefan Weil:
> > Am 08.02.2013 13:14, schrieb Jeff Cody:
> >> On Fri, Feb 08, 2013 at 09:38:47AM +0100, Kevin Wolf wrote:
> >>> Am 07.02.2013 20:26, schrieb Stefan
On Mon, Feb 11, 2013 at 09:09:48PM +0100, Kevin Wolf wrote:
> Am 11.02.2013 20:38, schrieb Jeff Cody:
> > I've done some testing back and forth between VPC, Win Server 2012
> > Hyper-V, and qemu/kvm with and without this patch applied.
>
> First of all, thanks a lot
;
> I don't mind reverting it, but just want to understand what the issue
> is.
>
Hi Anthony,
It was tested, the problem is that this will break existing support
for Virtual PC VHD files under certain conditions (most likely
exporting from qemu to VPC, but I don't know if we could guarantee
that is the only way).
Jeff
On Mon, Feb 11, 2013 at 10:33:53PM +0100, Stefan Weil wrote:
> Am 11.02.2013 20:38, schrieb Jeff Cody:
> > I've done some testing back and forth between VPC, Win Server 2012
> > Hyper-V, and qemu/kvm with and without this patch applied.
> >
> > The short: this
On Tue, Feb 12, 2013 at 03:47:38PM +0100, Stefan Weil wrote:
> Am 11.02.2013 22:20, schrieb Jeff Cody:
> > On Mon, Feb 11, 2013 at 03:14:36PM -0600, Anthony Liguori wrote:
> >> Paolo Bonzini writes:
> >>
> >>> Il 11/02/2013 21:13, Anthony Ligu
hdx.c file
(e.g. region / metdata handling)
Any comments are welcome
Jeff Cody (4):
qemu: add castagnoli crc32c checksum algorithm
block: vhdx header for the QEMU support of VHDX images
block: VHDX block driver support
block: add vhdx to Makefile.obj for compile
block/Makefile.ob
Check Codes with 24
and 32 Parity Bits", IEEE Transactions on Communication,
Volume 41, Number 6, June 1993
Signed-off-by: Jeff Cody
---
include/qemu/crc32c.h | 35 +++
util/Makefile.objs| 1 +
util/crc32c.c
re possible, to
reduce alignment issues on different architectures.
Per the specification, all data is little-endian.
Signed-off-by: Jeff Cody
---
block/vhdx.h | 349 +++
1 file changed, 349 insertions(+)
create mode 100644 block/vhdx.h
dif
Signed-off-by: Jeff Cody
---
block/Makefile.objs | 1 +
1 file changed, 1 insertion(+)
diff --git a/block/Makefile.objs b/block/Makefile.objs
index c067f38..a819577 100644
--- a/block/Makefile.objs
+++ b/block/Makefile.objs
@@ -2,6 +2,7 @@ block-obj-y += raw.o cow.o qcow.o vdi.o vmdk.o cloop.o
itions could be mounted and files read.
As this is still under active development, and an RFC, you can
assume that any debug print statements will be removed prior
to formal patch submission.
Signed-off-by: Jeff Cody
---
block/vhdx.c | 814 +++
On Mon, Feb 18, 2013 at 06:03:28PM -0500, Jeff Cody wrote:
> This is preliminary support for VHDX images, based on the spec:
>
> "VHDX Format Specification v0.95", published 4/12/2012
>https://www.microsoft.com/en-us/download/details.aspx?id=29681
>
> My worki
On Tue, Feb 19, 2013 at 10:02:51AM +0100, Stefan Hajnoczi wrote:
> On Mon, Feb 18, 2013 at 06:03:30PM -0500, Jeff Cody wrote:
> > +/* the guid is a 16 byte unique ID - the definition for this used by
> > + * Microsoft is not just 16 bytes though - it is a structure that is
> >
On Tue, Feb 19, 2013 at 10:20:40AM +0100, Stefan Hajnoczi wrote:
> On Mon, Feb 18, 2013 at 06:03:31PM -0500, Jeff Cody wrote:
> > This is preliminary and beta support for the VHDX image format,
> > as specified in:
> >"VHDX Format Specification v0.95", pu
On Tue, Feb 19, 2013 at 03:30:10PM +0100, Kevin Wolf wrote:
> On Tue, Feb 19, 2013 at 08:26:35AM -0500, Jeff Cody wrote:
> > On Tue, Feb 19, 2013 at 10:20:40AM +0100, Stefan Hajnoczi wrote:
> > > On Mon, Feb 18, 2013 at 06:03:31PM -0500, Jeff Cody wrote:
> > >
On Tue, Feb 19, 2013 at 03:57:53PM +0100, Kevin Wolf wrote:
> On Mon, Feb 18, 2013 at 06:03:31PM -0500, Jeff Cody wrote:
> > This is preliminary and beta support for the VHDX image format,
> > as specified in:
> >"VHDX Format Specification v0.95", pu
On Tue, Feb 19, 2013 at 02:55:23PM +0100, Stefan Hajnoczi wrote:
> On Tue, Feb 19, 2013 at 08:11:48AM -0500, Jeff Cody wrote:
> > On Tue, Feb 19, 2013 at 10:02:51AM +0100, Stefan Hajnoczi wrote:
> > > On Mon, Feb 18, 2013 at 06:03:30PM -0500, Jeff Cody wrote:
> > > &g
On Tue, Feb 19, 2013 at 03:23:35PM +0100, Kevin Wolf wrote:
> On Mon, Feb 18, 2013 at 06:03:32PM -0500, Jeff Cody wrote:
> >
> > Signed-off-by: Jeff Cody
> > ---
> > block/Makefile.objs | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --gi
return value in bdrv_commit_all() - before that bdrv_commit_all()
ignored all error returns of bdrv_commit().
Do you think there specific error returns that we should ignore then, in
bdrv_commit_all(), such as -ENOMEDIUM?
Also, could you expand on what you mean by non-populated
medium (test case) - is the error being returned "No medium found"?
Jeff
On Mon, Feb 25, 2013 at 03:30:34PM +0100, Markus Armbruster wrote:
> Jan Kiszka writes:
>
> > On 2013-02-25 14:05, Jeff Cody wrote:
> >> On Sun, Feb 24, 2013 at 07:29:31PM +0100, Jan Kiszka wrote:
> >>> Hi,
> >>>
> >>> I'm seeing
ve will still
return the appropriate error (-ENOMEDIUM if eject / not present, -ENOTSUP
if no backing file).
Reported-by: Jan Kiszka
Signed-off-by: Jeff Cody
---
block.c | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/block.c b/block.c
index 50dab8e..7a105dc 100644
--
On 09/20/2012 07:24 AM, Kevin Wolf wrote:
> Am 18.09.2012 20:53, schrieb Jeff Cody:
>> This is based on Supriya Kannery's bdrv_reopen() patch series.
>>
>> This provides a transactional method to reopen multiple
>> images files safely.
>>
>> Image file
On 09/20/2012 10:10 AM, Kevin Wolf wrote:
> Am 18.09.2012 20:53, schrieb Jeff Cody:
>> This is derived from the Supriya Kannery's reopen patches.
>>
>> This contains the raw-posix driver changes for the bdrv_reopen_*
>> functions. All changes are staged into a te
On 09/20/2012 10:12 AM, Kevin Wolf wrote:
> Am 18.09.2012 20:53, schrieb Jeff Cody:
>> This patch supports reopen for VMDK image files. VMDK extents are added
>> to the existing reopen queue, so that the transactional model of reopen
>> is maintained with multiple image files
On 09/20/2012 09:14 AM, Kevin Wolf wrote:
> Am 18.09.2012 20:53, schrieb Jeff Cody:
>> Move AIO initialization for raw-posix block driver into a helper function.
>>
>> In addition to just code motion, the aio_ctx pointer is checked for NULL,
>> prior to calling laio_ini
Signed-off-by: Jeff Cody
---
block.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/block.c b/block.c
index 4c0e7f5..458bcc9 100644
--- a/block.c
+++ b/block.c
@@ -2168,6 +2168,13 @@ int bdrv_enable_write_cache(BlockDriverState *bs)
void bdrv_set_enable_write_cache(BlockDriverState *bs
Move AIO initialization for raw-posix block driver into a helper function.
In addition to just code motion, the aio_ctx pointer is checked for NULL,
prior to calling laio_init(), to make sure laio_init() is only run once.
Signed-off-by: Jeff Cody
---
block/raw-posix.c | 53
There is currently nothing that needs to be done for VPC image
file reopen.
Signed-off-by: Jeff Cody
---
block/vpc.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/block/vpc.c b/block/vpc.c
index c0b82c4..b6bf52f 100644
--- a/block/vpc.c
+++ b/block/vpc.c
@@ -265,6 +265,12 @@ static
r the reopen
* opaque pointer for any driver-specific data that needs to be
persistent from _prepare to _commit/_abort
* reopen queue pointer, if the driver needs to queue additional
BDS for a reopen
Signed-off-by: Jeff Cody
---
block.c
= 0, ro = 1
|
v
[ snap-1 ] kro = 0, ro = 1
|
v
[ snap-2 ] kro = 0, ro = 1
|
v
[ active ] kro = 0, ro = 0
Signed-off-by: Jeff Cody
---
block.c | 14 +++---
block.h | 1 +
2 files changed, 8 insertions(+), 7 deletions(-)
diff --git a/block.c b/block.c
index e780
Currently, bdrv_commit() reopens images r/w itself, via risky
_delete() and _open() calls. Use the new safe method for drive reopen.
Signed-off-by: Jeff Cody
---
block.c | 48 +---
1 file changed, 5 insertions(+), 43 deletions(-)
diff --git a/block.c
The aligned_buf pointer and aligned_buf size are no longer used in
raw_posix.c, so remove all references to them.
Signed-off-by: Jeff Cody
---
block/raw-posix.c | 21 +
1 file changed, 1 insertion(+), 20 deletions(-)
diff --git a/block/raw-posix.c b/block/raw-posix.c
index
These are the stubs for the file reopen drivers for the raw format.
There is currently nothing that needs to be done by the raw driver
in reopen.
Signed-off-by: Jeff Cody
---
block/raw.c | 10 ++
1 file changed, 10 insertions(+)
diff --git a/block/raw.c b/block/raw.c
index ff34ea4
always feasible, and there are times when we must close the
existing file and then open the new file, breaking the transactional nature
of the reopen.
Signed-off-by: Jeff Cody
---
block/raw-win32.c | 105 ++
1 file changed, 105 insertions(+)
diff
There is currently nothing that needs to be done for VDI reopen.
Signed-off-by: Jeff Cody
---
block/vdi.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/block/vdi.c b/block/vdi.c
index 550cf58..f35b12e 100644
--- a/block/vdi.c
+++ b/block/vdi.c
@@ -454,6 +454,12 @@ static int
These are the stubs for the file reopen drivers for the qed format.
There is currently nothing that needs to be done by the qed driver
in reopen.
Signed-off-by: Jeff Cody
---
block/qed.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/block/qed.c b/block/qed.c
index 21cb239
Rather than check for a non-NULL aligned_buf to determine if
raw_aio_submit needs to check for alignment, check for the presence
of BDRV_O_NOCACHE in the bs->open_flags.
Signed-off-by: Jeff Cody
---
block/raw-posix.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block/
n] Directly embed BDRVReopenState field in
BlockReopenQueueEntry, rather than by reference
[Jeff] Add BlockReopenQueue field to the BDRVReopenState struct
Feedback not incorporated:
--
[Kevin] Sha
, the duplicate/new fd is closed.
Signed-off-by: Jeff Cody
---
block/raw-posix.c | 114 ++
1 file changed, 114 insertions(+)
diff --git a/block/raw-posix.c b/block/raw-posix.c
index 0ffb3d0..28d439f 100644
--- a/block/raw-posix.c
+++ b/block/raw-po
This patch supports reopen for VMDK image files. VMDK extents are added
to the existing reopen queue, so that the transactional model of reopen
is maintained with multiple image files.
Signed-off-by: Jeff Cody
---
block/vmdk.c | 35 +++
1 file changed, 35
Block drivers should ignore BDRV_O_CACHE_WB in .bdrv_open flags,
and in the bs->open_flags.
This patch removes the code, leaving the behaviour behind as if
BDRV_O_CACHE_WB was set.
Signed-off-by: Jeff Cody
---
block/iscsi.c | 4
block/raw-posix.c | 3 ---
block/raw-win32.c |
The keep_read_only flag is no longer used, in favor of the bdrv
flag BDRV_O_ALLOW_RDWR.
Signed-off-by: Jeff Cody
---
block.c | 2 --
block_int.h | 1 -
2 files changed, 3 deletions(-)
diff --git a/block.c b/block.c
index 84544d2..751ebdc 100644
--- a/block.c
+++ b/block.c
@@ -812,8 +812,6
These are the stubs for the file reopen drivers for the qcow format.
There is currently nothing that needs to be done by the qcow driver
in reopen.
Signed-off-by: Jeff Cody
---
block/qcow.c | 10 ++
1 file changed, 10 insertions(+)
diff --git a/block/qcow.c b/block/qcow.c
index
Code motion, to move parsing of open flags into a helper function.
Signed-off-by: Jeff Cody
---
block/raw-posix.c | 38 --
block/raw-win32.c | 43 +++
2 files changed, 47 insertions(+), 34 deletions(-)
diff --git a
These are the stubs for the file reopen drivers for the qcow2 format.
There is currently nothing that needs to be done by the qcow2 driver
in reopen.
Signed-off-by: Jeff Cody
---
block/qcow2.c | 10 ++
1 file changed, 10 insertions(+)
diff --git a/block/qcow2.c b/block/qcow2.c
index
On 09/21/2012 04:43 AM, Paolo Bonzini wrote:
> Il 21/09/2012 10:33, Kevin Wolf ha scritto:
+/* could not reopen the file handle, so fall back to opening
+ * new file (CreateFile) */
+if (raw_s->hfile == INVALID_HANDLE_VALUE) {
+raw_s->hfile = CreateFile(state
s that 'block-commit' with the 'speed' parameter sets the
speed parameter, as reported by 'query-block-jobs'
3. Verifies that a bogus 'device' parameter to 'block-commit'
results in error
Signed-
This is a simple helper function, that will return the base image
of a given image chain.
Signed-off-by: Jeff Cody
---
block.c | 16
block.h | 1 +
2 files changed, 17 insertions(+)
diff --git a/block.c b/block.c
index d044529..4a9bdc1 100644
--- a/block.c
+++ b/block.c
. If the active layer is passed
in currently as top, or top is left to the default, then an error
will be returned.
The is done as a block job, so upon completion a BLOCK_JOB_COMPLETED will
be emitted.
Signed-off-by: Jeff Cody
---
QMP/qmp-events.txt | 6 +++--
blockdev.c | 64
to
bottom <- base <- active
Signed-off-by: Jeff Cody
---
block.c | 150
block.h | 4 ++
2 files changed, 154 insertions(+)
diff --git a/block.c b/block.c
index 751ebdc..d044529 100644
--- a/block.
simplified some logic.
Patch 2/8: [Kevin] - Preserve errors in commit_populate()
[Kevin, Eric] - Check that there is enough room in base, and resize
with bdrv_truncate() if not.
[Jeff]- Switch from 'child'
depends on the bdrv_reopen() series.
Signed-off-by: Jeff Cody
---
blockdev.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/blockdev.c b/blockdev.c
index 6f1080c..fa7efae 100644
--- a/blockdev.c
+++ b/blockdev.c
@@ -803,6 +803,11 @@ void qmp_transaction(BlockdevActionList *dev_list, Err
At the end, intermediate images are deleted, and the
chain stitched together. Images are restored to their original open
flags upon completion.
Signed-off-by: Jeff Cody
---
block/Makefile.objs | 1 +
block/commit.c | 246
b
Signed-off-by: Jeff Cody
---
blockdev.c | 6 +++---
trace-events | 2 +-
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/blockdev.c b/blockdev.c
index 7c83baa..9caa16f 100644
--- a/blockdev.c
+++ b/blockdev.c
@@ -1063,12 +1063,12 @@ static QObject *qobject_from_block_job
On 09/25/2012 02:02 PM, Eric Blake wrote:
> On 09/25/2012 10:29 AM, Jeff Cody wrote:
>> Derived from the streaming test cases (030), this adds the
>> following tests:
>>
>> 1. For the following image chain, commit [mid] into [backing],
>>and use qemu-io to
On 09/25/2012 02:12 PM, Eric Blake wrote:
> On 09/25/2012 10:29 AM, Jeff Cody wrote:
>> This adds the live commit coroutine. This iteration focuses on the
>> commit only below the active layer, and not the active layer itself.
>>
>> The behaviour is similar to block
On 09/25/2012 03:13 PM, Eric Blake wrote:
> On 09/25/2012 10:29 AM, Jeff Cody wrote:
>> This is a simple helper function, that will return the base image
>> of a given image chain.
>>
>> Signed-off-by: Jeff Cody
>> ---
>> block.c | 16
>
On 09/25/2012 03:42 PM, Eric Blake wrote:
> On 09/25/2012 10:29 AM, Jeff Cody wrote:
>> The command for live block commit is added, which has the following
>> arguments:
>>
>> device: the block device to perform the commit on (mandatory)
>> base: the base image
On 09/26/2012 10:20 AM, Kevin Wolf wrote:
> Am 25.09.2012 18:29, schrieb Jeff Cody:
>> Currently, after a live snapshot of a drive, the image that has
>> been 'demoted' to be below the new active layer remains r/w.
>> This patch reopens it read-only.
>>
>
On 09/26/2012 10:13 AM, Kevin Wolf wrote:
> Am 25.09.2012 18:29, schrieb Jeff Cody:
>> The command for live block commit is added, which has the following
>> arguments:
>>
>> device: the block device to perform the commit on (mandatory)
>> base: the base image
ough room in base, and resize
with bdrv_truncate() if not.
[Jeff]- Switch from 'child' to 'overlay' terminology
- Fixed up more error checking
- Minor cleanup
[Kevin]
1 - 100 of 2448 matches
Mail list logo
