Re: [Qemu-devel] [PATCH 24028/24028] Evaluate breakpoint condition on target.Mechanism: translate gdb bytecode to TCG code and add to the translation block. Most of code is located in the new file tra

2013-02-21 Thread Jan Kiszka
I just hope the other 24027 patches won't come over us in the next second. ;) Please split the patch, at least into - prepare infrastructure for feature (that might also be several steps) - add feature (or features, then also in several steps) Thanks, Jan -- Siemens AG, Corporate Technology

Re: [Qemu-devel] [PATCH] slirp: fixed potential use-after-free of a socket

2013-02-21 Thread Jan Kiszka
On 2013-02-15 12:00, Vitaly Chipounov wrote: > A socket may still have references to it in various queues > at the time it is freed, causing memory corruptions. Did you see it in practice? Or is this patch based on code review? What will happen if those queued mbufs find their ifq_so NULL? > > S

Re: [Qemu-devel] [PATCH v4 00/10] main-loop: switch to g_poll(3) on POSIX hosts

2013-02-21 Thread Jan Kiszka
On 2013-02-21 16:33, Stefan Hajnoczi wrote: > On Thu, Feb 21, 2013 at 02:17:14PM +0100, Christian Borntraeger wrote: >> On 20/02/13 11:28, Stefan Hajnoczi wrote: >>> Amos Kong reported that file descriptors numbered higher >>> than 1024 could crash QEMU. This is due to the fixed size of the fd_se

Re: [Qemu-devel] [PATCH v4 00/10] main-loop: switch to g_poll(3) on POSIX hosts

2013-02-21 Thread Jan Kiszka
On 2013-02-21 18:10, Paolo Bonzini wrote: > Il 21/02/2013 17:29, Jan Kiszka ha scritto: >> In this context, I'd like to recall a detail: Real-time prioritization >> of those I/O threads will most probably require locking with >> prio-inversion avoidance (*). In that ca

Re: [Qemu-devel] [PATCH v4 00/10] main-loop: switch to g_poll(3) on POSIX hosts

2013-02-22 Thread Jan Kiszka
On 2013-02-22 09:40, Stefan Hajnoczi wrote: > On Thu, Feb 21, 2013 at 05:29:25PM +0100, Jan Kiszka wrote: >> On 2013-02-21 16:33, Stefan Hajnoczi wrote: >>> On Thu, Feb 21, 2013 at 02:17:14PM +0100, Christian Borntraeger wrote: >>>> On 20/02/13 11:28, Stefan H

Re: [Qemu-devel] [PATCH v2] Fix guest OS hang when 64bit PCI bar present

2013-02-22 Thread Jan Kiszka
On 2013-02-22 04:58, Alexey Korolev wrote: > This patch addresses the issue fully described here: > http://lists.nongnu.org/archive/html/qemu-devel/2013-02/msg01804.html > > Linux kernels prior to 2.6.36 do not disable the PCI device during > enumeration process. Since lower and higher parts of a

Re: [Qemu-devel] using -net dump with tap networking

2013-02-22 Thread Jan Kiszka
On 2013-02-22 10:35, Markus Armbruster wrote: >>("-net socket" has some usecases too: "-net bridge" helps placing >> a VM's network on a bridge, but adding a bridge still requires root >> privileges). > > "-netdev socket" and "-netdev bridge" don't cut it? Reminds me: Last time I tried -n

Re: [Qemu-devel] GTK UI is now the default

2013-02-22 Thread Jan Kiszka
On 2013-02-22 00:04, Anthony Liguori wrote: > > Since this is a pretty visible change for a lot of people, I thought I'd > send a top level note. The GTK UI is now committed and is the default > UI provided it's available. > > For anyone counting, it's been a little more than 7 years in the maki

[Qemu-devel] [PATCH] gtk: Replace bogus term "VGA" with "display"

2013-02-22 Thread Jan Kiszka
VGA is a misnomer, only some of our targets have it. Use the more generic term "display" instead. Signed-off-by: Jan Kiszka --- No translation updates yet as I do not know how you like to handle them. ui/gtk.c | 45 + 1 files c

Re: [Qemu-devel] [PATCH] slirp: fixed potential use-after-free of a socket

2013-02-22 Thread Jan Kiszka
On 2013-02-22 10:57, Vitaly Chipounov wrote: > Hi, > > On 21.02.2013 15:33, Jan Kiszka wrote: >> On 2013-02-15 12:00, Vitaly Chipounov wrote: >>> A socket may still have references to it in various queues >>> at the time it is freed, causing memory corruptions.

Re: [Qemu-devel] GTK UI is now the default

2013-02-22 Thread Jan Kiszka
On 2013-02-22 10:56, Jan Kiszka wrote: > On 2013-02-22 00:04, Anthony Liguori wrote: >> >> Since this is a pretty visible change for a lot of people, I thought I'd >> send a top level note. The GTK UI is now committed and is the default >> UI provided it's

Re: [Qemu-devel] [PATCH] gtk: Replace bogus term "VGA" with "display"

2013-02-22 Thread Jan Kiszka
On 2013-02-22 14:21, Anthony Liguori wrote: > Hi Jan, > > Jan Kiszka writes: > >> VGA is a misnomer, only some of our targets have it. Use the more >> generic term "display" instead. >> >> Signed-off-by: Jan Kiszka > > Sorry, I responded

Re: [Qemu-devel] GTK UI is now the default

2013-02-22 Thread Jan Kiszka
On 2013-02-22 14:46, Anthony Liguori wrote: > Jan Kiszka writes: > >> On 2013-02-22 00:04, Anthony Liguori wrote: >>> >>> Since this is a pretty visible change for a lot of people, I thought I'd >>> send a top level note. The GTK UI is now commi

Re: [Qemu-devel] GTK UI is now the default

2013-02-22 Thread Jan Kiszka
On 2013-02-22 14:50, Paolo Bonzini wrote: > Il 22/02/2013 14:46, Anthony Liguori ha scritto: >> Jan Kiszka writes: >> >>> On 2013-02-22 00:04, Anthony Liguori wrote: >>>> >>>> Since this is a pretty visible change for a lot of people, I thought I&

Re: [Qemu-devel] [PATCH] gtk: Replace bogus term "VGA" with "display"

2013-02-22 Thread Jan Kiszka
On 2013-02-22 15:17, Anthony Liguori wrote: > Jan Kiszka writes: > >> On 2013-02-22 14:21, Anthony Liguori wrote: >>> Hi Jan, >>> >>> Jan Kiszka writes: >>> >>>> VGA is a misnomer, only some of our targets have it. Use the more >&

[Qemu-devel] [PATCH v2] gtk: Replace bogus term "VGA" with "Screen"

2013-02-22 Thread Jan Kiszka
VGA is a misnomer, only some of our targets have it. Use the more generic term "Screen" instead. Signed-off-by: Jan Kiszka --- Note that we have "screendump" as well, so this makes more sense than "VGA". Internal renaming across all QEMU can still be done but is b

[Qemu-devel] [PATCH] gtk: Add control menu with stop, reset and power-down entries

2013-02-22 Thread Jan Kiszka
This adds basic guest control commands to a new menu - a nice added-value for the GTK UI. Signed-off-by: Jan Kiszka --- ui/gtk.c | 64 +- 1 files changed, 63 insertions(+), 1 deletions(-) diff --git a/ui/gtk.c b/ui/gtk.c index

Re: [Qemu-devel] [PATCH] gtk: Replace bogus term "VGA" with "display"

2013-02-22 Thread Jan Kiszka
On 2013-02-22 15:51, Anthony Liguori wrote: > Jan Kiszka writes: > >> On 2013-02-22 15:17, Anthony Liguori wrote: >>> Jan Kiszka writes: >>> >>>> On 2013-02-22 14:21, Anthony Liguori wrote: >>>>> Hi Jan, >>>>> >>&g

Re: [Qemu-devel] GTK UI is now the default

2013-02-22 Thread Jan Kiszka
On 2013-02-22 16:14, Anthony Liguori wrote: > Jan Kiszka writes: > >> On 2013-02-22 10:56, Jan Kiszka wrote: >>> On 2013-02-22 00:04, Anthony Liguori wrote: >>>> >>>> Since this is a pretty visible change for a lot of people, I thought I'd >&g

Re: [Qemu-devel] [PATCH] gtk: Add control menu with stop, reset and power-down entries

2013-02-22 Thread Jan Kiszka
On 2013-02-22 16:35, Anthony Liguori wrote: > Jan Kiszka writes: > >> This adds basic guest control commands to a new menu - a nice >> added-value for the GTK UI. >> >> Signed-off-by: Jan Kiszka >> --- >> ui/gtk.c | 64 >>

Re: [Qemu-devel] [PATCH v2] gtk: Replace bogus term "VGA" with "Screen"

2013-02-22 Thread Jan Kiszka
On 2013-02-22 16:37, Anthony Liguori wrote: > Jan Kiszka writes: > >> VGA is a misnomer, only some of our targets have it. Use the more >> generic term "Screen" instead. >> >> Signed-off-by: Jan Kiszka > > Peter and I discussed this in IRC. > &

Re: [Qemu-devel] [PATCH] gtk: Add control menu with stop, reset and power-down entries

2013-02-22 Thread Jan Kiszka
On 2013-02-22 16:38, Jan Kiszka wrote: >>> @@ -995,6 +1038,22 @@ static void gd_create_menus(GtkDisplayState *s) >>> "/File/Quit"); >>> gtk_accel_map_add_entry("/File/Quit", item.keyval, >>> item.

[Qemu-devel] [PATCH v2] gtk: Rename File to Machine menu and add stop, reset and power-down items

2013-02-22 Thread Jan Kiszka
This adds basic guest control commands to the "Machine" menu - a nice added-value for the GTK UI. We pick up the stock stop accelerators (if any) but not its image as we add a check item. Signed-off-by: Jan Kiszka --- Changes in v2: - File -> Machine menu - stock accels for st

Re: [Qemu-devel] GTK UI is now the default

2013-02-22 Thread Jan Kiszka
On 2013-02-22 18:10, Anthony Liguori wrote: > Paolo Bonzini writes: > >> Il 22/02/2013 16:17, Anthony Liguori ha scritto: > FWIW I'd be in favor of making grab-on-hover the default. >>> It really breaks window manager key bindings. If you alt-tab between >>> windows and you happen to end up

Re: [Qemu-devel] GTK UI is now the default

2013-02-22 Thread Jan Kiszka
On 2013-02-22 18:12, Anthony Liguori wrote: > Jan Kiszka writes: > >> On 2013-02-22 16:14, Anthony Liguori wrote: >>> Jan Kiszka writes: >>> >>>> Some smaller quirks I stumbled over so far: >>>> - text consoles use an inferior font compared

Re: [Qemu-devel] [PATCH v2] gtk: Rename File to Machine menu and add stop, reset and power-down items

2013-02-22 Thread Jan Kiszka
On 2013-02-22 18:16, Anthony Liguori wrote: > Jan Kiszka writes: > >> This adds basic guest control commands to the "Machine" menu - a nice >> added-value for the GTK UI. We pick up the stock stop accelerators (if >> any) but not its image as we add a check ite

Re: [Qemu-devel] [PATCH v4 06/10] iohandler: switch to GPollFD

2013-02-22 Thread Jan Kiszka
On 2013-02-20 11:28, Stefan Hajnoczi wrote: > Convert iohandler_select_fill() and iohandler_select_poll() to use > GPollFD instead of rfds/wfds/xfds. Since this commmit, I'm getting QEMU lock-ups, apparently slirp is involved (the Linux guest tries to start its network at this point): (gdb) threa

[Qemu-devel] [PATCH v3] gtk: Rename File to Machine menu and add stop, reset and power down items

2013-02-22 Thread Jan Kiszka
This adds basic guest control commands to the "Machine" menu - a nice added-value for the GTK UI. We pick up the stock stop label and accelerator (if any) but not its image as we add a check item. Signed-off-by: Jan Kiszka --- Changes in v2: - stock label - Power-down -> Power Do

Re: [Qemu-devel] [PATCH v2] gtk: Rename File to Machine menu and add stop, reset and power-down items

2013-02-22 Thread Jan Kiszka
On 2013-02-22 18:53, Anthony Liguori wrote: > Jan Kiszka writes: > >> On 2013-02-22 18:16, Anthony Liguori wrote: >>> Jan Kiszka writes: >>> >>>> This adds basic guest control commands to the "Machine" menu - a nice >>>> added-

Re: [Qemu-devel] [PATCH 9/9] gtk: suppress accelerators from the File menu when grab is active

2013-02-22 Thread Jan Kiszka
On 2013-02-20 14:43, Anthony Liguori wrote: > If you're full screen, you probably expect Ctrl-Q to go to the guest, > not the host. I think restricting certain menus is the right way to > handle this generally speaking. > > Signed-off-by: Anthony Liguori > --- > ui/gtk.c | 34 ++

[Qemu-devel] [PATCH] gtk: Fix accelerator filtering

2013-02-22 Thread Jan Kiszka
This is in fact very simply: When the input in grabbed, everything should be exclusively passed to the guest - except it has our magic CTRL-ALT modifier set. Then let GTK filter out those accels that are in use. Signed-off-by: Jan Kiszka --- ui/gtk.c | 16 ++-- 1 files changed, 2

[Qemu-devel] [PATCH] slirp: Properly initialize pollfds_idx of new sockets

2013-02-22 Thread Jan Kiszka
Otherwise we may start processing sockets in slirp_pollfds_poll that were created past slirp_pollfds_fill. Signed-off-by: Jan Kiszka --- Not sure if this pattern also applies to other users besides slirp. Worth checking I suppose. slirp/socket.c |1 + 1 files changed, 1 insertions(+), 0

[Qemu-devel] [PATCH v4] gtk: Rename File to Machine menu and add pause, reset and power down items

2013-02-22 Thread Jan Kiszka
This adds basic guest control commands to the "Machine" menu - a nice added-value for the GTK UI. We use "pause" as the term for stopping the machine here. So reword also the related caption tag. Signed-off-by: Jan Kiszka --- Changes in v3: - stop -> pause ren

[Qemu-devel] [PATCH][RESENT] configure: Create link to icon bitmap for out-of-tree builds

2013-02-22 Thread Jan Kiszka
This allows to pick up the icon when starting QEMU directly from an out-of-tree build directory. Signed-off-by: Jan Kiszka --- configure |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/configure b/configure index 0eb25dd..265d8f7 100755 --- a/configure +++ b/configure

[Qemu-devel] [PATCH v2 0/2] i2c: Add AT24Cxx EEPROM model

2013-02-22 Thread Jan Kiszka
Rebased over current master, resolved new reports of checkpatch. See patches for details. Jan Kiszka (2): i2c: Introduce device address mask Add AT24Cxx I2C EEPROM device model hw/Makefile.objs |2 +- hw/at24.c| 363 ++ hw

[Qemu-devel] [PATCH v2 2/2] Add AT24Cxx I2C EEPROM device model

2013-02-22 Thread Jan Kiszka
backing block device. Device addresses are built from the device number property. Write protection can be configured by declaring the block device read-only. Signed-off-by: Jan Kiszka --- hw/Makefile.objs |2 +- hw/at24.c| 363 ++ 2

[Qemu-devel] [PATCH v2 1/2] i2c: Introduce device address mask

2013-02-22 Thread Jan Kiszka
one. Moreover, the transmitted address is passed as additional parameter to the event callback of the device. Signed-off-by: Jan Kiszka --- hw/ds1338.c |2 +- hw/i2c.c |9 + hw/i2c.h |3 ++- hw/lm832x.c |2 +- hw/max7310.c |2 +- hw/pxa2xx.c |3

Re: [Qemu-devel] [PATCH v2 0/2] i2c: Add AT24Cxx EEPROM model

2013-02-23 Thread Jan Kiszka
On 2013-02-23 14:12, Andreas Färber wrote: > Am 22.02.2013 21:39, schrieb Jan Kiszka: >> Rebased over current master, resolved new reports of checkpatch. > > This doesn't really take all developments in master into account, > comments on 2/2. Yeah, that happens if such pa

Re: [Qemu-devel] [PATCH v2 0/2] i2c: Add AT24Cxx EEPROM model

2013-02-23 Thread Jan Kiszka
On 2013-02-23 15:08, Andreas Färber wrote: > Am 23.02.2013 15:02, schrieb Jan Kiszka: >> On 2013-02-23 14:12, Andreas Färber wrote: >>> Am 22.02.2013 21:39, schrieb Jan Kiszka: >>>> Rebased over current master, resolved new reports of >>>> checkp

Re: [Qemu-devel] [PATCH v2 0/2] i2c: Add AT24Cxx EEPROM model

2013-02-23 Thread Jan Kiszka
On 2013-02-23 15:40, Andreas Färber wrote: > Am 23.02.2013 15:29, schrieb Jan Kiszka: >> On 2013-02-23 15:08, Andreas Färber wrote: >>> Am 23.02.2013 15:02, schrieb Jan Kiszka: >>>> Will address the QOM changes, but I need to check back with >>>&

[Qemu-devel] [PATCH] target-i386: Improve x86_cpu_list output

2013-02-23 Thread Jan Kiszka
From: Jan Kiszka Several issues fixed: - We were missing a bunch of feature lists. Fix this by simply dumping the meta list feature_word_info. - kvm_enabled() cannot be true at this point because accelerators are initialized much later during init. Simply dump unconditionally. - Add

[Qemu-devel] [PATCH] gtk: Release modifier when graphic console loses keyboard focus

2013-02-24 Thread Jan Kiszka
From: Jan Kiszka This solves, e.g., sticky ALT when selecting a GTK menu, switching to a different window or selecting a different virtual console. Signed-off-by: Jan Kiszka --- ui/gtk.c | 52 ++-- 1 files changed, 50 insertions(+), 2

[Qemu-devel] QEMU no longer debugable with recent gdb

2013-02-24 Thread Jan Kiszka
Hi, running qemu-system-xxx under recent gdb gives me this instead of starting QEMU: GNU gdb (GDB) 7.5.1 Copyright (C) 2012 Free Software Foundation, Inc. License GPLv3+: GNU GPL version 3 or later This is free software: you are free to change and redistribute i

[Qemu-devel] 'commit' error for 'all': No medium found

2013-02-24 Thread Jan Kiszka
Hi, I'm seeing this with git head and 1.4. Apparently, commit on a non-populated medium now generates this error instead of ignoring it like in the past. As we stop iterating over the block devices while doing "all", this may leaving uncommitted data behind. Didn't test, but I suspect 58513bde83

Re: [Qemu-devel] 'commit' error for 'all': No medium found

2013-02-25 Thread Jan Kiszka
On 2013-02-25 14:05, Jeff Cody wrote: > On Sun, Feb 24, 2013 at 07:29:31PM +0100, Jan Kiszka wrote: >> Hi, >> >> I'm seeing this with git head and 1.4. Apparently, commit on a >> non-populated medium now generates this error instead of ignoring it >> like in t

Re: [Qemu-devel] QEMU no longer debugable with recent gdb

2013-02-25 Thread Jan Kiszka
On 2013-02-25 15:15, Stefan Hajnoczi wrote: > On Sun, Feb 24, 2013 at 02:03:51PM +0100, Jan Kiszka wrote: >> Hi, >> >> running qemu-system-xxx under recent gdb gives me this instead of >> starting QEMU: >> >> GNU gdb (GDB) 7.5.1 >> Copyright (C) 2012 Fr

Re: [Qemu-devel] 'commit' error for 'all': No medium found

2013-02-25 Thread Jan Kiszka
On 2013-02-25 15:30, Markus Armbruster wrote: > Jan Kiszka writes: > >> On 2013-02-25 14:05, Jeff Cody wrote: >>> On Sun, Feb 24, 2013 at 07:29:31PM +0100, Jan Kiszka wrote: >>>> Hi, >>>> >>>> I'm seeing this with git head and 1.4. A

Re: [Qemu-devel] 'commit' error for 'all': No medium found

2013-02-25 Thread Jan Kiszka
On 2013-02-25 15:37, Jeff Cody wrote: > On Mon, Feb 25, 2013 at 03:30:34PM +0100, Markus Armbruster wrote: >> Jan Kiszka writes: >> >>> On 2013-02-25 14:05, Jeff Cody wrote: >>>> On Sun, Feb 24, 2013 at 07:29:31PM +0100, Jan Kiszka wrote: >>>>>

[Qemu-devel] [PATCH v2] gtk: Fix accelerator filtering

2013-02-25 Thread Jan Kiszka
. Signed-off-by: Jan Kiszka --- Changes in v2 (yeah, almost "very simple"): - ignore set NUM or CAPS when testing for hot-key modifiers ui/gtk.c | 40 +++- 1 files changed, 19 insertions(+), 21 deletions(-) diff --git a/ui/gtk.c b/ui/gtk.c index e38ed0

Re: [Qemu-devel] QEMU no longer debugable with recent gdb

2013-02-25 Thread Jan Kiszka
On 2013-02-25 15:22, Jan Kiszka wrote: > On 2013-02-25 15:15, Stefan Hajnoczi wrote: >> On Sun, Feb 24, 2013 at 02:03:51PM +0100, Jan Kiszka wrote: >>> Hi, >>> >>> running qemu-system-xxx under recent gdb gives me this instead of >>> starting QEMU:

Re: [Qemu-devel] [PATCH v2] gtk: Fix accelerator filtering

2013-02-25 Thread Jan Kiszka
On 2013-02-25 16:39, Anthony Liguori wrote: > Jan Kiszka writes: > >> This is in fact very simply: When the input in grabbed, everything >> should be exclusively passed to the guest - except it has our magic >> CTRL-ALT modifier set. Then let GTK filter out those accels

[Qemu-devel] [PULL] slirp: Urgent fix for QEMU lockup

2013-02-26 Thread Jan Kiszka
The following changes since commit 08f4a0f7ee899c32bac91114e859d2687cbcf1d7: target-ppc: Fix SUBFE carry (2013-02-25 14:32:36 -0600) are available in the git repository at: git://git.kiszka.org/qemu.git queues/slirp Jan Kiszka (1): slirp: Properly initialize pollfds_idx of new sockets

Re: [Qemu-devel] [Fwd: qemu tx stop in cloonix]

2013-02-26 Thread Jan Kiszka
On 2013-02-26 10:21, Stefan Hajnoczi wrote: > On Mon, Feb 25, 2013 at 11:38 PM, wrote: >> I coded a socket-based cable between 2 vanilla kvm, here are the commands >> to do: > > Please try: > > kvm \ > -nodefaults \ > -nographic \ > -serial stdio \ > -drive file=guest1,media=di

Re: [Qemu-devel] Working on IPv6 -net user support

2013-02-26 Thread Jan Kiszka
On 2013-02-26 12:23, Guillaume Subiron wrote: > Hi, > > I represent a group of french network students in master degree > working on Qemu. Our tutor is Samuel Thibault. He asked us to come on > this list. > > Our development project consists in implementing IPv6 support in Qemu > in the -net user

Re: [Qemu-devel] [PATCH] PATCH1 - infrastructure for Evaluate breakpoint condition on target.OPC_MAX_SIZE - size of translation buffer - was increased because condition translated bytecode should be e

2013-02-26 Thread Jan Kiszka
Please study http://wiki.qemu.org/Contribute/SubmitAPatch carefully. But lets assume this patch only adds the infrastructure to parse and store the condition expression in a breakpoint. On 2013-02-26 14:50, Anna Neiman wrote: > Signed-off-by: Anna Neiman > --- > exec.c | 16 +

[Qemu-devel] [PATCH v2] gtk: Release modifier when graphic console loses keyboard focus

2013-02-26 Thread Jan Kiszka
From: Jan Kiszka This solves, e.g., sticky ALT when selecting a GTK menu, switching to a different window or selecting a different virtual console. Signed-off-by: Jan Kiszka --- Changes in v2: - fix a style issue - truly switch off line-wrapping before sending (sorry) ui/gtk.c | 53

Re: [Qemu-devel] [PATCH] apic: fixup fallthrough to PIC

2013-02-26 Thread Jan Kiszka
On 2013-02-26 20:48, Mark Asselstine wrote: > Commit 0e21e12bb311c4c1095d0269dc2ef81196ccb60a [Don't route PIC > interrupts through the local APIC if the local APIC config says so.] > missed a check to ensure the local APIC is enabled. Since if the local > APIC is disabled it doesn't matter what th

Re: [Qemu-devel] [PATCH] target-i386: Improve x86_cpu_list output

2013-02-26 Thread Jan Kiszka
On 2013-02-27 08:37, Igor Mammedov wrote: > On Wed, 27 Feb 2013 00:26:38 -0300 > Eduardo Habkost wrote: > >> On Tue, Feb 26, 2013 at 10:57:56PM +0100, Igor Mammedov wrote: >>> On Sat, 23 Feb 2013 16:45:00 +0100 >>> Jan Kiszka wrote: >>> >>>

Re: [Qemu-devel] [PATCH] PATCH1 - infrastructure for Evaluate breakpoint condition on target.OPC_MAX_SIZE - size of translation buffer - was increased because condition translated bytecode should be e

2013-02-27 Thread Jan Kiszka
On 2013-02-27 08:25, Neiman, Anna wrote: > Hi Jan, > Thank you for your review. > I added 4 patches including whole implementation of this feature, not just > infrastructure. > > Some explanations for your notes : Please comment inline, do not top-post. > Cond_exp is the array of bytecodes ( no

Re: [Qemu-devel] [PATCH] slirp: Properly initialize pollfds_idx of new sockets

2013-02-27 Thread Jan Kiszka
On 2013-02-26 23:18, Anthony Liguori wrote: > Jan Kiszka writes: > >> Otherwise we may start processing sockets in slirp_pollfds_poll that >> were created past slirp_pollfds_fill. >> >> Signed-off-by: Jan Kiszka > > I think there's still something w

Re: [Qemu-devel] [PATCH v2 2/2] Add AT24Cxx I2C EEPROM device model

2013-02-27 Thread Jan Kiszka
o look for a slot to address the review comments and come up with a new version. > > On Sat, Feb 23, 2013 at 6:39 AM, Jan Kiszka wrote: >> This implements I2C EEPROMs of the AT24Cxx series. Sizes from 1Kbit to >> 1024Kbit are supported. Each EEPROM is backed by a block device. Its

[Qemu-devel] [PATCH v2] target-i386: Improve x86_cpu_list output

2013-02-27 Thread Jan Kiszka
users. Simply dump unconditionally if CONFIG_KVM is set. - Add explanation for "host" CPU type. Signed-off-by: Jan Kiszka --- Changes in v2: - Do not dump "host" type if CONFIG_KVM is not set - Explain that "host" depends on KVM mode target-i386/cpu.c | 23 ++

Re: [Qemu-devel] [PATCH v2] target-i386: Improve x86_cpu_list output

2013-02-27 Thread Jan Kiszka
On 2013-02-27 10:33, Andreas Färber wrote: > Am 27.02.2013 10:15, schrieb Jan Kiszka: >> Several issues fixed: >> - We were missing a bunch of feature lists. Fix this by simply dumping >>the meta list feature_word_info. >> - kvm_enabled() cannot be true at this poi

Re: [Qemu-devel] Will the ELI incorporated in theKVM?

2012-09-20 Thread Jan Kiszka
On 2012-09-20 08:58, Abel Gordon wrote: > > > GaoYi wrote on 20/09/2012 08:42:51 AM: > >>The CPU isolation in Hitachi patches is just to improve the real >> time performance of GUEST. The core of it, direct IRQ delivery, is >> very similar to that of ELI. >> For the ELI patches, >>

Re: [Qemu-devel] [PATCH 1/2] pseries: Synchronize qemu and KVM state on hypercalls

2012-09-20 Thread Jan Kiszka
On 2012-09-20 09:08, David Gibson wrote: > Currently the KVM exit path for PAPR hypercalls does not synchronize the > qemu cpu state with the KVM state. Mostly this works, because the actual > hypercall arguments and return values are explicitly passed through the > kvm_run structure. However, th

Re: [Qemu-devel] [PATCH] usb-redir: Allow to attach USB 2.0 devices to 1.1 host controller

2012-09-21 Thread Jan Kiszka
On 2012-09-18 11:41, Hans de Goede wrote: > Hi, > > On 09/17/2012 06:22 PM, Jan Kiszka wrote: >>> If that does not work, add the debug parameter to the usb-redir device, >>> set it >>> to 4, collect logs of trying to redirect the device and send me the logs &

Re: [Qemu-devel] [PATCH] usb-redir: Allow to attach USB 2.0 devices to 1.1 host controller

2012-09-21 Thread Jan Kiszka
On 2012-09-21 14:21, Hans de Goede wrote: > Hi, > > On 09/21/2012 01:49 PM, Jan Kiszka wrote: >> On 2012-09-18 11:41, Hans de Goede wrote: >>> Hi, >>> >>> On 09/17/2012 06:22 PM, Jan Kiszka wrote: >>>>> If that does not work, add the debug

[Qemu-devel] [PATCH v2] usb-redir: Allow to attach USB 2.0 devices to 1.1 host controller

2012-09-22 Thread Jan Kiszka
From: Jan Kiszka This follows the logic of host-linux: If a 2.0 device has no ISO endpoint and no interrupt endpoint with a packet size > 64, we can attach it also to an 1.1 host controller. In case the redir server does not report endpoint sizes, play safe and remove the 1.1 compatibility

Re: [Qemu-devel] [PATCH 0/2] add pci-serial device.

2012-09-25 Thread Jan Kiszka
On 2012-09-26 01:43, Anthony Liguori wrote: > Gerd Hoffmann writes: > >> Hi, >> >> Two patches, first split up serial.c a bit, >> then actually add the pci-based serial device. > > The series looks good to me. A couple requests: > > 1) Could you add a spec describing this new PCI device? Do

Re: [Qemu-devel] Bug#688964: qemu-kvm: Fedora 17 guest hangs on boot with soft lockup in udevd

2012-09-27 Thread Jan Kiszka
0xe0 > [ 36.055026] [] ? 0xa00a6fff > [ 36.055026] [] alsa_card_azx_init+0x1e/0x1000 > [snd_hda_intel] > [ 36.055026] [] do_one_initcall+0x12a/0x180 > [ 36.055026] [] sys_init_module+0x10f6/0x20b0 > [ 36.055026] [] system_call_fastpath+0x16/0x1b > > I

Re: [Qemu-devel] Bug#688964: qemu-kvm: Fedora 17 guest hangs on boot with soft lockup in udevd

2012-09-27 Thread Jan Kiszka
On 2012-09-27 20:43, Michael Tokarev wrote: > On 27.09.2012 22:28, Jan Kiszka wrote: > [] >>> --- a/hw/intel-hda.c >>> +++ b/hw/intel-hda.c >>> @@ -1107,6 +1107,9 @@ static void intel_hda_reset(DeviceState *dev) >>> DeviceState *qdev; >>>

Re: [Qemu-devel] [PATCH] Add option to mlock guest and qemu memory

2012-09-28 Thread Jan Kiszka
On 2012-09-28 01:21, Satoru Moriya wrote: > This is a first time for me to post a patch to qemu-devel. > If there is something missing/wrong, please let me know. > > We have some plans to migrate old enterprise systems which require > low latency (msec order) to kvm virtualized environment. Usuall

Re: [Qemu-devel] [PATCH] Add option to mlock guest and qemu memory

2012-09-28 Thread Jan Kiszka
On 2012-09-28 14:33, Anthony Liguori wrote: > Jan Kiszka writes: > >> On 2012-09-28 01:21, Satoru Moriya wrote: >>> This is a first time for me to post a patch to qemu-devel. >>> If there is something missing/wrong, please let me know. >>> >>> We h

Re: [Qemu-devel] qemu-kvm: remove "boot=on|off" drive parameter compatibility

2012-10-01 Thread Jan Kiszka
On 2012-10-01 15:19, Anthony Liguori wrote: > Jan Kiszka writes: > >> On 2012-10-01 11:31, Marcelo Tosatti wrote: >> >> It's not just about default configs. We need to validate if the >> migration formats are truly compatible (qemu-kvm -> QEMU, the other

Re: [Qemu-devel] qemu-kvm: remove "boot=on|off" drive parameter compatibility

2012-10-01 Thread Jan Kiszka
On 2012-10-01 15:31, Marcelo Tosatti wrote: > On Mon, Oct 01, 2012 at 08:19:29AM -0500, Anthony Liguori wrote: >> Jan Kiszka writes: >> >>> On 2012-10-01 11:31, Marcelo Tosatti wrote: >>> >>> It's not just about default configs. We need to

Re: [Qemu-devel] qemu-kvm: remove "boot=on|off" drive parameter compatibility

2012-10-01 Thread Jan Kiszka
On 2012-10-01 15:38, Paolo Bonzini wrote: > Il 01/10/2012 15:19, Anthony Liguori ha scritto: >> I think it's time for the distros to drop qemu-kvm and just ship >> qemu.git. Is there anything else that needs to happen to make that >> switch? > > Perhaps change the default to -machine accel=kvm:tc

Re: [Qemu-devel] qemu-kvm: remove "boot=on|off" drive parameter compatibility

2012-10-01 Thread Jan Kiszka
On 2012-10-01 15:44, Michael Tokarev wrote: > 01.10.2012 17:36, Jan Kiszka wrote: >> On 2012-10-01 15:31, Marcelo Tosatti wrote: > >>>> Default nic is rtl8139 vs. e1000. >>> >>> Config file (as suggested earlier on this thread). >> >> If yo

[Qemu-devel] [PATCH] kvm: Set default accelerator to "kvm" if the host supports it

2012-10-01 Thread Jan Kiszka
If we built a target for a host that supports KVM in principle, set the default accelerator to KVM as well. This also means the start of QEMU will fail to start if KVM support turns out to be unavailable at runtime. Signed-off-by: Jan Kiszka --- kvm-all.c |1 + kvm-stub.c |1 + kvm.h

Re: [Qemu-devel] [PATCH] kvm: Set default accelerator to "kvm" if the host supports it

2012-10-03 Thread Jan Kiszka
On 2012-10-01 18:20, Anthony Liguori wrote: > Jan Kiszka writes: > >> If we built a target for a host that supports KVM in principle, set the >> default accelerator to KVM as well. This also means the start of QEMU >> will fail to start if KVM support turns out to be u

Re: [Qemu-devel] [PATCH] kvm: Set default accelerator to "kvm" if the host supports it

2012-10-03 Thread Jan Kiszka
On 2012-10-03 08:58, Michael Tokarev wrote: > On 02.10.2012 11:46, Markus Armbruster wrote: >> "Daniel P. Berrange" writes: > >>> IMHO, default to KVM, fallback to TCG is the most friendly default >>> behaviour. >> >> Friendly perhaps, generating an infinite series of questions "why is my >> gues

Re: [Qemu-devel] qemu-kvm: remove "boot=on|off" drive parameter compatibility

2012-10-03 Thread Jan Kiszka
On 2012-10-03 11:55, Gleb Natapov wrote: > On Mon, Oct 01, 2012 at 03:26:05PM +0200, Jan Kiszka wrote: >> On 2012-10-01 15:19, Anthony Liguori wrote: >>> Jan Kiszka writes: >>> >>>> On 2012-10-01 11:31, Marcelo Tosatti wrote: >>>> >>>&

Re: [Qemu-devel] [patch 2/6] Use machine options to emulate -no-kvm-irqchip

2012-10-03 Thread Jan Kiszka
On 2012-10-03 17:03, Marcelo Tosatti wrote: > On Wed, Oct 03, 2012 at 09:40:17AM -0500, Anthony Liguori wrote: >> Marcelo Tosatti writes: >> >>> Commit 3ad763fcba5bd0ec5a79d4a9b6baeef119dd4a3d from qemu-kvm.git. >>> >>> From: Jan Kiszka >>>

Re: [Qemu-devel] [patch 2/6] Use machine options to emulate -no-kvm-irqchip

2012-10-03 Thread Jan Kiszka
On 2012-10-03 17:46, Jan Kiszka wrote: > On 2012-10-03 17:03, Marcelo Tosatti wrote: >> On Wed, Oct 03, 2012 at 09:40:17AM -0500, Anthony Liguori wrote: >>> Marcelo Tosatti writes: >>> >>>> Commit 3ad763fcba5bd0ec5a79d4a9b6baeef119dd4a3d from q

Re: [Qemu-devel] [patch 2/6] Use machine options to emulate -no-kvm-irqchip

2012-10-03 Thread Jan Kiszka
On 2012-10-03 19:16, Anthony Liguori wrote: > Jan Kiszka writes: > >> On 2012-10-03 17:03, Marcelo Tosatti wrote: >>> On Wed, Oct 03, 2012 at 09:40:17AM -0500, Anthony Liguori wrote: >>>> Marcelo Tosatti writes: >>>> >>>>> Commi

Re: [Qemu-devel] [patch 2/6] Use machine options to emulate -no-kvm-irqchip

2012-10-04 Thread Jan Kiszka
On 2012-10-03 20:26, Marcelo Tosatti wrote: > On Wed, Oct 03, 2012 at 07:24:48PM +0200, Jan Kiszka wrote: >> On 2012-10-03 19:16, Anthony Liguori wrote: >>> Jan Kiszka writes: >>> >>>> On 2012-10-03 17:03, Marcelo Tosatti wrote: >>>>> On

Re: [Qemu-devel] qemu-kvm: remove "boot=on|off" drive parameter compatibility

2012-10-04 Thread Jan Kiszka
On 2012-10-03 15:19, Paolo Bonzini wrote: > Il 03/10/2012 12:57, Lucas Meneghel Rodrigues ha scritto: >> Yep, I did send patches with the testdev device present on qemu-kvm.git >> to qemu.git a while ago, but there were many comments on the review, I >> ended up not implementing everything that was

Re: [Qemu-devel] qemu-kvm: remove "boot=on|off" drive parameter compatibility

2012-10-04 Thread Jan Kiszka
On 2012-10-04 14:10, Lucas Meneghel Rodrigues wrote: > On 10/04/2012 07:48 AM, Jan Kiszka wrote: >> On 2012-10-03 15:19, Paolo Bonzini wrote: >>> Il 03/10/2012 12:57, Lucas Meneghel Rodrigues ha scritto: >>>> Yep, I did send patches with the testdev device present on

Re: [Qemu-devel] [patch 2/6] Use machine options to emulate -no-kvm-irqchip

2012-10-04 Thread Jan Kiszka
On 2012-10-04 16:21, Anthony Liguori wrote: > -no-kvm should be included too. Reminds me that we still need to agree on the final default accel strategy. > > I just ran across a user that was injecting '-no-kvm-irqchip' in their > libvirt XML via a custom attribute. It turned out it was to work

Re: [Qemu-devel] [patch 2/6] Use machine options to emulate -no-kvm-irqchip

2012-10-04 Thread Jan Kiszka
On 2012-10-04 17:36, Andreas Färber wrote: > Am 04.10.2012 16:30, schrieb Jan Kiszka: >> On 2012-10-04 16:21, Anthony Liguori wrote: >>> -no-kvm should be included too. >> >> Reminds me that we still need to agree on the final default accel strategy. >> >&

Re: [Qemu-devel] [patch 2/6] Use machine options to emulate -no-kvm-irqchip

2012-10-04 Thread Jan Kiszka
On 2012-10-04 18:13, Andreas Färber wrote: > Am 04.10.2012 18:04, schrieb Jan Kiszka: >> On 2012-10-04 17:36, Andreas Färber wrote: >>> Am 04.10.2012 16:30, schrieb Jan Kiszka: >>>> On 2012-10-04 16:21, Anthony Liguori wrote: >>>> - avoid adding th

Re: [Qemu-devel] [PATCH] target-i386: initialize APIC at CPU level

2012-10-04 Thread Jan Kiszka
On 2012-10-04 16:43, Igor Mammedov wrote: > +/* XXX: mapping more APICs at the same memory location */ > +if (apic_mapped == 0) { > +/* NOTE: the APIC is directly connected to the CPU - it is not > + on the global memory bus. */ > +/* XXX: what if the base changes?

Re: [Qemu-devel] qemu-kvm: remove "boot=on|off" drive parameter compatibility

2012-10-04 Thread Jan Kiszka
On 2012-10-04 19:21, Lucas Meneghel Rodrigues wrote: > On 10/04/2012 09:27 AM, Jan Kiszka wrote: >> On 2012-10-04 14:10, Lucas Meneghel Rodrigues wrote: >>> On 10/04/2012 07:48 AM, Jan Kiszka wrote: >>>> On 2012-10-03 15:19, Paolo Bonzini wrote: >>>>>

Re: [Qemu-devel] [PATCH 2/2] hw: Add test device for unittests execution v2

2012-10-04 Thread Jan Kiszka
On 2012-10-04 19:31, Lucas Meneghel Rodrigues wrote: > Add a test device which supports the kvmctl ioports, > so one can run the KVM unittest suite. > > Intended Usage: > > qemu-system-x86_64 -device pc-testdev -serial stdio \ > -device isa-debugexit,iobase=0xf4,access-size=4 \ > -kernel /path/to

Re: [Qemu-devel] [RFC] Starting a (secondary) CPU when it is halted or reset

2012-10-05 Thread Jan Kiszka
On 2012-10-05 11:28, Ronald Hecht wrote: > Hello all, > > I have a question regarding LEON SPARC SMP. In a LEON SPARC SMP system > secondary CPUs (others that CPU#0) can be started by setting certain > bits in the interrupt controller. At startup (reset) all CPUs are halted > except CPU#0. In QEMU

Re: [Qemu-devel] [PATCH 1/2] debugexit: support for custom exit port (LGPL VGA BIOS port 0x501)

2012-10-05 Thread Jan Kiszka
[was a private thread due to typo in qemu list address] On 2012-10-05 14:40, Anthony Liguori wrote: > Paolo Bonzini writes: > >> Il 05/10/2012 00:06, Lucas Meneghel Rodrigues ha scritto: >>> +static void debugexit_ioport_write(void *opaque, uint32_t addr, uint32_t >>> val) >>> +{ >>> +exit(

Re: [Qemu-devel] [PATCH 1/2] debugexit: support for custom exit port (LGPL VGA BIOS port 0x501)

2012-10-05 Thread Jan Kiszka
On 2012-10-05 14:46, Paolo Bonzini wrote: > Il 05/10/2012 14:43, Jan Kiszka ha scritto: >>>>>> This "| 1" might be the problem. Anthony, are you relying on it in >>>>>> qemu-test and/or can you work out the changes if we use just >>>&g

Re: [Qemu-devel] [patch 5/7] Emulate qemu-kvms drive parameter boot=on|off

2012-10-05 Thread Jan Kiszka
On 2012-10-05 19:13, Marcelo Tosatti wrote: > From: Jan Kiszka > > Releases of qemu-kvm will be interrupted at qemu 1.3.0. > Users should switch to plain qemu releases. > To avoid breaking scenarios which are setup with command line > options specific to qemu-kvm, port these

Re: [Qemu-devel] [patch 6/7] Emulate qemu-kvms -tdf option

2012-10-05 Thread Jan Kiszka
On 2012-10-05 19:13, Marcelo Tosatti wrote: > From: Jan Kiszka > > Releases of qemu-kvm will be interrupted at qemu 1.3.0. > Users should switch to plain qemu releases. > To avoid breaking scenarios which are setup with command line > options specific to qemu-kvm, port these

Re: [Qemu-devel] [patch 0/7] qemu-kvm compat (v2)

2012-10-05 Thread Jan Kiszka
On 2012-10-05 19:13, Marcelo Tosatti wrote: > As discussed on this weeks qemu call, follows qemu-kvm compat patches > for qemu: > > - command line compatibility > - allow configurable ram size for cirrus > > Jan, please ACK. Ack except for the misleading subjects. Jan -- Siemens AG, C

[Qemu-devel] [PATCH] versatile: Push lsi initialization to the end

2012-10-05 Thread Jan Kiszka
nd is already registered when the bottom-half is finally processed. This fixes spurious monitor messages with qemu-system-arm ... -machine versatilepb /path/to/disk -nographic Signed-off-by: Jan Kiszka --- hw/versatilepb.c | 11 ++- 1 files changed, 6 insertions(+), 5 deletions(-) diff --

<    2   3   4   5   6   7   8   9   10   11   >