[Qemu-devel] [PATCH v2 4/7] memory: Fold memory_region_update_topology into memory_region_transaction_commit

2012-06-27 Thread Jan Kiszka
Simplify the code as we are using now only a subset of the original features of memory_region_update_topology. Signed-off-by: Jan Kiszka --- memory.c | 39 +++ 1 files changed, 11 insertions(+), 28 deletions(-) diff --git a/memory.c b/memory.c index

[Qemu-devel] [PATCH v2 3/7] memory: Use transaction_begin/commit also for single-step operations

2012-06-27 Thread Jan Kiszka
disabled or unregistered regions. Signed-off-by: Jan Kiszka --- memory.c | 40 +--- 1 files changed, 25 insertions(+), 15 deletions(-) diff --git a/memory.c b/memory.c index c29a8a3..8b1218e 100644 --- a/memory.c +++ b/memory.c @@ -1076,8 +1076,9 @@ void

[Qemu-devel] [PATCH v2 7/7] kvm: Stop flushing coalesced MMIO on vmexit

2012-06-27 Thread Jan Kiszka
The memory subsystem will now take care of flushing whenever affected regions are accessed or the memory mapping changes. Signed-off-by: Jan Kiszka --- kvm-all.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/kvm-all.c b/kvm-all.c index f8e4328..a1d32f6 100644 --- a

Re: [Qemu-devel] race between kvm-kmod-3.0 and kvm-kmod-3.3 // was: race condition in qemu-kvm-1.0.1

2012-06-27 Thread Jan Kiszka
On 2012-06-27 17:39, Peter Lieven wrote: > Hi all, > > i debugged this further and found out that kvm-kmod-3.0 is working with > qemu-kvm-1.0.1 while kvm-kmod-3.3 and kvm-kmod-3.4 are not. What is > working as well is kvm-kmod-3.4 with an old userspace (qemu-kvm-0.13.0). > Has anyone a clue which

Re: [Qemu-devel] [PATCH 5/6 v5] deal with guest panicked event accoring to -onpanic parameter

2012-06-28 Thread Jan Kiszka
On 2012-06-28 03:15, Wen Congyang wrote: > At 06/27/2012 10:39 PM, Jan Kiszka Wrote: >> On 2012-06-27 09:02, Wen Congyang wrote: >>> When the guest is panicked, it will write 0x1 to the port KVM_PV_PORT. >>> So if qemu reads 0x1 from this port, we can do the folloing th

Re: [Qemu-devel] race between kvm-kmod-3.0 and kvm-kmod-3.3 // was: race condition in qemu-kvm-1.0.1

2012-06-28 Thread Jan Kiszka
On 2012-06-28 11:11, Peter Lieven wrote: > On 27.06.2012 18:54, Jan Kiszka wrote: >> On 2012-06-27 17:39, Peter Lieven wrote: >>> Hi all, >>> >>> i debugged this further and found out that kvm-kmod-3.0 is working with >>> qemu-kvm-1.0.1 while k

Re: [Qemu-devel] [PATCH] add -machine mem_merge=on|off option

2012-06-28 Thread Jan Kiszka
On 2012-06-27 18:49, Luiz Capitulino wrote: > Allows to disable memory merge support (KSM on Linux), which is enabled > by default otherwise. > > Signed-off-by: Luiz Capitulino > --- > exec.c | 19 --- > qemu-config.c | 4 > qemu-options.hx | 5 - > 3 files

Re: [Qemu-devel] race between kvm-kmod-3.0 and kvm-kmod-3.3 // was: race condition in qemu-kvm-1.0.1

2012-06-28 Thread Jan Kiszka
On 2012-06-28 11:31, Peter Lieven wrote: > On 28.06.2012 11:21, Jan Kiszka wrote: >> On 2012-06-28 11:11, Peter Lieven wrote: >>> On 27.06.2012 18:54, Jan Kiszka wrote: >>>> On 2012-06-27 17:39, Peter Lieven wrote: >>>>> Hi all, >>>>> &

Re: [Qemu-devel] [PATCH 0/4 v2] target-i386: move tcg intialization inside CPU object

2012-06-28 Thread Jan Kiszka
On 2012-06-25 15:55, Igor Mammedov wrote: > v2: > - drop usage of prev_debug_excp_handler consistently in all users > - split from reset patches to avoid confusion of inter-dependency > > Compile & Run tested: > target-i386: tcg and kvm mode > i386-linux-user: running of /bin/ls > Compile

Re: [Qemu-devel] qemu-kvm-1.0.1 - unable to exit if vcpu is in infinite loop

2012-06-28 Thread Jan Kiszka
On 2012-06-28 15:05, Peter Lieven wrote: > Hi, > > i debugged my initial problem further and found out that the problem > happens to be that > the main thread is stuck in pause_all_vcpus() on reset or quit commands > in the monitor > if one cpu is stuck in the do-while loop kvm_cpu_exec. If I modi

Re: [Qemu-devel] usb_packet_complete: Assertion ... failed

2012-06-28 Thread Jan Kiszka
On 2012-06-27 21:58, Erik Rull wrote: > Jan Kiszka wrote: >> On 2012-06-23 11:29, Erik Rull wrote: >>> Jan Kiszka wrote: >>>> Hi Gerd, >>>> >>>> I'm getting >>>> >>>> qemu/hw/usb/core.c:410: usb_packet_comple

Re: [Qemu-devel] usb_packet_complete: Assertion ... failed

2012-06-28 Thread Jan Kiszka
On 2012-06-28 15:33, Jan Kiszka wrote: > On 2012-06-27 21:58, Erik Rull wrote: >> Jan Kiszka wrote: >>> On 2012-06-23 11:29, Erik Rull wrote: >>>> Jan Kiszka wrote: >>>>> Hi Gerd, >>>>> >>>>> I'm getting >&g

Re: [Qemu-devel] qemu-kvm-1.0.1 - unable to exit if vcpu is in infinite loop

2012-06-28 Thread Jan Kiszka
On 2012-06-28 17:02, Peter Lieven wrote: > On 28.06.2012 15:25, Jan Kiszka wrote: >> On 2012-06-28 15:05, Peter Lieven wrote: >>> Hi, >>> >>> i debugged my initial problem further and found out that the problem >>> happens to be that >>> the

Re: [Qemu-devel] [RFC 1/3] memory: add -disable-mem-merge command-line option

2012-06-29 Thread Jan Kiszka
On 2012-06-29 16:25, Anthony Liguori wrote: > On 06/29/2012 09:18 AM, Andreas Färber wrote: >> Am 25.06.2012 22:39, schrieb Luiz Capitulino: >>> On Mon, 25 Jun 2012 22:26:58 +0200 >>> Jan Kiszka wrote: >>> >>>> On 2012-06-25 18:55, Luiz Capituli

[Qemu-devel] [PATCH] usb: Remove obsolete assert from usb_packet_complete

2012-06-29 Thread Jan Kiszka
Due to queuing/pipelining, there can now be multiple packets per endpoint in flight. So the assertion in usb_packet_complete became wrong and can cause bogus QEMU terminations. Seen with a passed-through USB headset. Signed-off-by: Jan Kiszka --- I'm not 100% sure that the assertion tha

[Qemu-devel] [PATCH v3 2/7] memory: Flush coalesced MMIO on selected region access

2012-06-29 Thread Jan Kiszka
, by calling memory_region_set_flush_coalesced. Signed-off-by: Jan Kiszka --- Changes in v3: - refuse to clear flush_coalesced_mmio for regions that have coalescing enabled memory.c | 24 memory.h | 26 ++ 2 files changed, 50 insertions

Re: [Qemu-devel] qemu-kvm-1.0.1 - unable to exit if vcpu is in infinite loop

2012-07-02 Thread Jan Kiszka
On 2012-07-01 21:18, Peter Lieven wrote: > > Am 01.07.2012 um 10:19 schrieb Avi Kivity: > >> On 06/28/2012 10:27 PM, Peter Lieven wrote: >>> >>> Am 28.06.2012 um 18:32 schrieb Avi Kivity: >>> On 06/28/2012 07:29 PM, Peter Lieven wrote: >> Yes. A signal is sent, and KVM returns from the g

Re: [Qemu-devel] [PATCH] msi/msix: added API to set MSI message address and data

2012-07-02 Thread Jan Kiszka
lity to the config space for the device. */ >> /* Given a bar and its size, add MSI-X table on top of it >> * and fill MSI-X capability in the config space. >> diff --git a/hw/msix.h b/hw/msix.h >> index 50aee82..26a437e 100644 >> --- a/hw/msix.h >> +++ b/hw/msix.h >> @@ -4,6 +4,8 @@ >> #include "qemu-common.h" >> #include "pci.h" >> >> +void msix_set_message(PCIDevice *dev, int vector, MSIMessage msg); >> + >> int msix_init(PCIDevice *pdev, unsigned short nentries, >>MemoryRegion *bar, >>unsigned bar_nr, unsigned bar_size); > > Acked-by: Jan Kiszka -- Siemens AG, Corporate Technology, CT RTC ITP SDP-DE Corporate Competence Center Embedded Linux

[Qemu-devel] [PATCH] vga: Implement blinking of text cursor

2012-07-02 Thread Jan Kiszka
Let the text cursor blink at 5 Hz. No timer is used, instead we rely on the fact that the display is updated periodically. Signed-off-by: Jan Kiszka --- hw/vga.c | 14 +- hw/vga_int.h |2 ++ 2 files changed, 15 insertions(+), 1 deletions(-) diff --git a/hw/vga.c b/hw

[Qemu-devel] [PATCH] console: Implementing blinking of cursor

2012-07-02 Thread Jan Kiszka
Let the text console cursor blink at 5 HZ. Signed-off-by: Jan Kiszka --- console.c | 26 +- 1 files changed, 25 insertions(+), 1 deletions(-) diff --git a/console.c b/console.c index 6a463f5..29b0f1c 100644 --- a/console.c +++ b/console.c @@ -28,6 +28,7 @@ //#define

Re: [Qemu-devel] plan for device assignment upstream

2012-07-02 Thread Jan Kiszka
On 2012-07-02 11:18, Michael S. Tsirkin wrote: > I've been thinking hard about Jan's patches for device > assignment. Basically while I thought it makes sense > to make all devices: assignment and not - behave the > same and use same APIs for injecting irqs, Anthony thinks there is huge > value in

[Qemu-devel] [PATCH v2 2/2] pci: Add INTx routing notifier

2012-07-02 Thread Jan Kiszka
o use pci_device_route_intx_to_irq to check the effect of the change. Will be used by KVM PCI device assignment and VFIO. Signed-off-by: Jan Kiszka --- hw/pci.c | 23 +++ hw/pci.h |7 +++ hw/piix_pci.c |2 ++ 3 files changed, 32 insertions(+), 0 dele

[Qemu-devel] [PATCH v2 0/2] pci: Preparations for KVM device assignment

2012-07-02 Thread Jan Kiszka
Back to the roots: This implements pci_device_route_intx_to_irq and the PCI INTx routing notifier, but only those, without any caching for existing emulated devices. I tried to carry over all other refactorings and comment on the previous version. Please review/merge. Jan Kiszka (2): pci: Add

[Qemu-devel] [PATCH v2 1/2] pci: Add pci_device_route_intx_to_irq

2012-07-02 Thread Jan Kiszka
. It is so far only implemented by the PIIX3, other host bridges can be added later on as required. Will be used for KVM PCI device assignment and VFIO. Signed-off-by: Jan Kiszka --- hw/alpha_typhoon.c |2 +- hw/apb_pci.c |2 +- hw/bonito.c|2 +- hw/grackle_pci.c

Re: [Qemu-devel] usb_packet_complete: Assertion ... failed

2012-07-02 Thread Jan Kiszka
On 2012-07-02 13:05, Gerd Hoffmann wrote: > Hi, > >> What I also so in the trace is that the USB core apparently stumbled as >> a request that took very long too complete finally returned, and then >> the assertion triggered over this request. > > Can I get such a trace please? usb_host_req_*

Re: [Qemu-devel] [PATCH v2 2/2] pci: Add INTx routing notifier

2012-07-02 Thread Jan Kiszka
On 2012-07-02 16:26, Alex Williamson wrote: > On Mon, 2012-07-02 at 14:38 +0200, Jan Kiszka wrote: >> This per-device notifier shall be triggered by any interrupt router >> along the path of a device's legacy interrupt signal on routing changes. >> For simplicity reasons

Re: [Qemu-devel] [PATCH 5/6 v5] deal with guest panicked event accoring to -onpanic parameter

2012-07-02 Thread Jan Kiszka
On 2012-07-03 08:07, Wen Congyang wrote: > At 06/28/2012 04:26 PM, Jan Kiszka Wrote: >> On 2012-06-28 03:15, Wen Congyang wrote: >>> At 06/27/2012 10:39 PM, Jan Kiszka Wrote: >>>> On 2012-06-27 09:02, Wen Congyang wrote: >>>>> When the guest is panick

Re: [Qemu-devel] [RFC PATCH] Expose tsc deadline timer feature to guest

2012-07-02 Thread Jan Kiszka
;& kvm_irqchip_in_kernel() && > +kvm_check_extension(s, KVM_CAP_TSC_DEADLINE_TIMER)) { > +env->cpuid_ext_features |= CPUID_EXT_TSC_DEADLINE_TIMER; > +} > > env->cpuid_ext2_features &= kvm_arch_get_supported_cpuid(s, 0x8001, > 0, R_EDX); > Fine with me. Acked-by: Jan Kiszka Jan -- Siemens AG, Corporate Technology, CT RTC ITP SDP-DE Corporate Competence Center Embedded Linux

Re: [Qemu-devel] [PATCH 5/6 v5] deal with guest panicked event accoring to -onpanic parameter

2012-07-02 Thread Jan Kiszka
On 2012-07-03 08:43, Wen Congyang wrote: >> I'm not talking about changing the interface to the guest, I'm talking >> about how to model it in QEMU. And that difference would be transparent >> to the guest. I pointed you to examples like hw/kvm/clock.c. > > OK, I will read the code in hw/kvm/clock

Re: [Qemu-devel] [PATCH] usb: selective endpoint initialization

2012-07-03 Thread Jan Kiszka
On 2012-07-02 18:16, Gerd Hoffmann wrote: > Add support for (re-)initializing endpoints which belong to a specific > interface only. Use this in usb-host when changing altsetting for an > interface, so other interfaces are not disturbed. > qemu-system-x86_64: /data/qemu/hw/usb/host-linux.c:1220:

Re: [Qemu-devel] [PATCH] usb: selective endpoint initialization

2012-07-03 Thread Jan Kiszka
On 2012-07-03 10:21, Gerd Hoffmann wrote: > On 07/03/12 09:47, Jan Kiszka wrote: >> On 2012-07-02 18:16, Gerd Hoffmann wrote: >>> Add support for (re-)initializing endpoints which belong to a specific >>> interface only. Use this in usb-host when changing altsetting for

Re: [Qemu-devel] [PATCH] usb: selective endpoint initialization

2012-07-03 Thread Jan Kiszka
On 2012-07-03 10:43, Jan Kiszka wrote: > On 2012-07-03 10:21, Gerd Hoffmann wrote: >> On 07/03/12 09:47, Jan Kiszka wrote: >>> On 2012-07-02 18:16, Gerd Hoffmann wrote: >>>> Add support for (re-)initializing endpoints which belong to a specific >>>>

Re: [Qemu-devel] [PATCH] console: Implementing blinking of cursor

2012-07-03 Thread Jan Kiszka
On 2012-07-03 10:59, Alon Levy wrote: > On Mon, Jul 02, 2012 at 10:20:17AM +0200, Jan Kiszka wrote: > > One comment below. > > Reviewed-by: Alon Levy > >> Let the text console cursor blink at 5 HZ. >> >> Signed-off-by: Jan Kiszka >> --- >> c

Re: [Qemu-devel] [PATCH] usb: selective endpoint initialization

2012-07-03 Thread Jan Kiszka
On 2012-07-03 11:17, Gerd Hoffmann wrote: > Hi, > >> BTW, there are still plenty of "husb: out of buffers for iso stream" >> messages. Can we do anything about it, or does the the guest selects too >> few buffers here (for a virtualized setup)? > > Try increase isobufs (usb-host property, defau

Re: [Qemu-devel] [PATCH] console: Implementing blinking of cursor

2012-07-03 Thread Jan Kiszka
On 2012-07-03 16:41, Stefan Weil wrote: > Am 02.07.2012 10:20, schrieb Jan Kiszka: >> Let the text console cursor blink at 5 HZ. >> >> Signed-off-by: Jan Kiszka >> --- >> console.c | 26 +- >> 1 files changed, 25 insertions(+), 1 d

[Qemu-devel] [PATCH v2] vga: Implement blinking of text cursor

2012-07-04 Thread Jan Kiszka
Let the text cursor blink at 5 Hz. No timer is used, instead we rely on the fact that the display is updated periodically. Signed-off-by: Jan Kiszka --- Changes in v2: - avoid full screen updates for cursor blinking - convert cursor_blink_state to cursor_visible_phase hw/vga.c | 14

Re: [Qemu-devel] [PATCH v2] vga: Implement blinking of text cursor

2012-07-04 Thread Jan Kiszka
On 2012-07-04 18:26, Stefan Weil wrote: > Hi Jan, > > please see my comments below. > > > Am 04.07.2012 15:40, schrieb Jan Kiszka: >> Let the text cursor blink at 5 Hz. No timer is used, instead we rely on >> the fact that the display is updated periodically. &

[Qemu-devel] [PATCH v3] vga: Implement blinking of text cursor

2012-07-04 Thread Jan Kiszka
Let the text cursor blink at 1.875 Hz, the original VGA cursor frequency. No timer is used, instead we rely on the fact that the display is updated periodically. Signed-off-by: Jan Kiszka --- Changes in v3: - adjusted frequency to original value - fixed semantic of VGA_TEXT_CURSOR_PERIOD_MS

Re: [Qemu-devel] [PATCH v2 0/2] pci: Preparations for KVM device assignment

2012-07-04 Thread Jan Kiszka
On 2012-07-04 23:15, Michael S. Tsirkin wrote: > On Mon, Jul 02, 2012 at 02:38:45PM +0200, Jan Kiszka wrote: >> Back to the roots: This implements pci_device_route_intx_to_irq and the >> PCI INTx routing notifier, but only those, without any caching for >> existing emulate

Re: [Qemu-devel] [PATCH] cpu: smp_wmb before lauching cpus.

2012-07-04 Thread Jan Kiszka
On 2012-07-05 04:18, Liu Ping Fan wrote: > Vcpu state must be set completely before receiving INIT-IPI,SIPI > > Signed-off-by: Liu Ping Fan > --- > kvm.h |1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/kvm.h b/kvm.h > index 9c7b0ea..5b3c228 100644 > --- a/kvm.h > +

[Qemu-devel] [PATCH] msix: Drop tracking of used vectors

2012-07-05 Thread Jan Kiszka
anyway. So drop this obsolete interface. We still need interfaces to clear pending vectors though. Provide msix_clear_vector and msix_clear_all_vectors for this. Signed-off-by: Jan Kiszka --- hw/ivshmem.c| 20 --- hw/msix.c | 57

Re: [Qemu-devel] [PATCH] cpu: smp_wmb before lauching cpus.

2012-07-05 Thread Jan Kiszka
On 2012-07-05 12:10, liu ping fan wrote: > On Thu, Jul 5, 2012 at 2:46 PM, Jan Kiszka wrote: >> On 2012-07-05 04:18, Liu Ping Fan wrote: >>> Vcpu state must be set completely before receiving INIT-IPI,SIPI >>> >>> Signed-off-by: Liu Ping Fan >>> --

Re: [Qemu-devel] [PATCH] cpu: smp_wmb before lauching cpus.

2012-07-05 Thread Jan Kiszka
On 2012-07-05 13:02, liu ping fan wrote: > On Thu, Jul 5, 2012 at 6:16 PM, Jan Kiszka wrote: >> On 2012-07-05 12:10, liu ping fan wrote: >>> On Thu, Jul 5, 2012 at 2:46 PM, Jan Kiszka wrote: >>>> On 2012-07-05 04:18, Liu Ping Fan wrote: >>>>> Vcpu

Re: [Qemu-devel] [PATCH] msix: Drop tracking of used vectors

2012-07-05 Thread Jan Kiszka
On 2012-07-05 15:17, Michael S. Tsirkin wrote: > On Thu, Jul 05, 2012 at 11:42:14AM +0200, Jan Kiszka wrote: >> This optimization was once used in qemu-kvm to keep KVM route usage low. >> But now we solved that problem via lazy updates. > > What if we are using vhost whic

Re: [Qemu-devel] [PATCH] msix: Drop tracking of used vectors

2012-07-05 Thread Jan Kiszka
On 2012-07-05 22:47, Michael S. Tsirkin wrote: > On Thu, Jul 05, 2012 at 04:27:33PM +0200, Jan Kiszka wrote: >> On 2012-07-05 15:17, Michael S. Tsirkin wrote: >>> On Thu, Jul 05, 2012 at 11:42:14AM +0200, Jan Kiszka wrote: >>>> This optimization was once used in qe

Re: [Qemu-devel] [PATCH] slirp: Ensure smbd and shared directory exist when enable smb

2012-07-05 Thread Jan Kiszka
Sorry for the late review. Two comments below. On 2012-07-03 15:13, Dunrong Huang wrote: > Users may pass the following parameters to qemu: > $ qemu-kvm -net nic -net user,smb= ... > $ qemu-kvm -net nic -net user,smb ... > $ qemu-kvm -net nic -net user,smb=bad_directory ... > > In the

[Qemu-devel] [Bug 1010484] Re: slirp to accept non-local dns server

2012-07-05 Thread Jan Kiszka
The feature makes sense and would be acceptable. But please - post a patch on qemu-devel, following http://wiki.qemu.org/Contribute/SubmitAPatch - reject non-local DNS servers if restrict=on is selected Thanks! -- You received this bug notification because you are a member of qemu- devel-ml, wh

Re: [Qemu-devel] [PATCH] slirp: Handle whole 127.0.0.0/8 network as local addresses.

2012-07-05 Thread Jan Kiszka
On 2012-06-12 14:12, Anders Waldenborg wrote: > Changes so translation of remote address to the host's ip address in > the virtual network happens for all addresses in the 127.0.0.0/8 > network, not just 127.0.0.1. > > This fixes hostfwd bound to addresses such as 127.0.0.2 works Looks good, just

Re: [Qemu-devel] [PATCH] slirp: add 'cmd:' target for guestfwd

2012-07-05 Thread Jan Kiszka
On 2012-06-03 09:45, Alexander Graf wrote: > When using guestfwd=, Qemu only connects the virtual server's TCP port > to a single chardev. This is useless in most cases, as we usually want > to have more than a single connection from the guest to the outside world. > > This patch adds a new cmd: t

[Qemu-devel] [PATCH] slirp: Enforce host-side user of smb share

2012-07-05 Thread Jan Kiszka
From: Jan Kiszka Windows 7 (and possibly other versions) cannot connect to the samba share if the exported host directory is not world-readable. This can be resolved by forcing the username used for access checks to the one under which QEMU and smbd are running. Signed-off-by: Jan Kiszka

Re: [Qemu-devel] [PATCH v2] slirp: Ensure smbd and shared directory exist when enable smb

2012-07-05 Thread Jan Kiszka
On 2012-07-06 08:04, Dunrong Huang wrote: > Users may pass the following parameters to qemu: > $ qemu-kvm -net nic -net user,smb= ... > $ qemu-kvm -net nic -net user,smb ... > $ qemu-kvm -net nic -net user,smb=bad_directory ... > > In these cases, qemu started successfully while samba

Re: [Qemu-devel] [PATCH] cpu: smp_wmb before lauching cpus.

2012-07-06 Thread Jan Kiszka
On 2012-07-06 09:46, liu ping fan wrote: > On Thu, Jul 5, 2012 at 7:58 PM, Jan Kiszka wrote: >> On 2012-07-05 13:02, liu ping fan wrote: >>> On Thu, Jul 5, 2012 at 6:16 PM, Jan Kiszka wrote: >>>> On 2012-07-05 12:10, liu ping fan wrote: >>>>> On T

Re: [Qemu-devel] [PATCH 2/7 v6] update linux headers

2012-07-06 Thread Jan Kiszka
On 2012-07-06 11:38, Wen Congyang wrote: > Signed-off-by: Wen Congyang Which kvm.git hash is this referring? Please state this to avoid that we are merging support for kernel features that are still under review. Jan > --- > linux-headers/asm-x86/kvm_para.h |2 ++ > linux-headers/linux/kvm

Re: [Qemu-devel] [PATCH 5/7 v6] introduce a new qom device to deal with panicked event

2012-07-06 Thread Jan Kiszka
On 2012-07-06 11:41, Wen Congyang wrote: > If the target is x86/x86_64, the guest's kernel will write 0x01 to the > port KVM_PV_PORT when it is panciked. This patch introduces a new qom > device kvm_pv_ioport to listen this I/O port, and deal with panicked > event according to panicked_action's val

Re: [Qemu-devel] [PATCH 7/7 v6] deal with panicked event accoring to '-machine panic_action=action'

2012-07-06 Thread Jan Kiszka
On 2012-07-06 11:41, Wen Congyang wrote: > The action is the same as -onpanic parameter. As explained in patch 5, now that we have a related device, this no longer needs to be a machine property. Would could be a machine property is enabling/disabling this device. That's probably useful as it use

Re: [Qemu-devel] [PATCH 6/7 v6] deal with guest panicked event accoring to -onpanic parameter

2012-07-06 Thread Jan Kiszka
On 2012-07-06 11:41, Wen Congyang wrote: > The onpanic parameter can have the following value: > 1. none > 2. pause > 3. poweroff > 4. reset > > The action for each value when the guest is panicked: > 1. none: emit QEVENT_GUEST_PANICKED only > 2. pause: emit QEVENT_GUEST_PANICKED and pause the gue

Re: [Qemu-devel] [PATCH 2/7 v6] update linux headers

2012-07-06 Thread Jan Kiszka
On 2012-07-06 12:50, Wen Congyang wrote: > At 07/06/2012 06:25 PM, Jan Kiszka Wrote: >> On 2012-07-06 11:38, Wen Congyang wrote: >>> Signed-off-by: Wen Congyang >> >> Which kvm.git hash is this referring? Please state this to avoid that we >> are merging suppor

Re: [Qemu-devel] [PATCH] msi/msix: added API to set MSI message address and data

2012-07-06 Thread Jan Kiszka
On 2012-07-06 17:36, Alexander Graf wrote: > > On 02.07.2012, at 09:24, Jan Kiszka wrote: > >> On 2012-07-02 06:28, Alexey Kardashevskiy wrote: >>> Ping? >>> >>> >>> On 22/06/12 11:15, Alexey Kardashevskiy wrote: >>>> Added (msi|

Re: [Qemu-devel] [PATCH] kvm: First step to push iothread lock out of inner run loop

2012-07-06 Thread Jan Kiszka
On 2012-06-24 16:08, Jan Kiszka wrote: > On 2012-06-24 10:49, Avi Kivity wrote: >> On 06/23/2012 02:45 PM, Jan Kiszka wrote: >>> >>> Hmm, we may need the iothread lock around cpu_set_apic_tpr for >>> !kvm_irqchip_in_kernel(). And as we are at it, apic_base manip

Re: [Qemu-devel] [PATCH] kvm: First step to push iothread lock out of inner run loop

2012-07-06 Thread Jan Kiszka
On 2012-07-06 19:16, Jan Kiszka wrote: > On 2012-06-24 16:08, Jan Kiszka wrote: >> On 2012-06-24 10:49, Avi Kivity wrote: >>> On 06/23/2012 02:45 PM, Jan Kiszka wrote: >>>> >>>> Hmm, we may need the iothread lock around cpu_set_apic_tpr for >>

[Qemu-devel] [PATCH 0/3] apic: Fixes for userspace model

2012-07-09 Thread Jan Kiszka
about the first one. Who would like to process this series, up/master? Or should it go in directly? Jan Kiszka (3): apic: Resolve potential endless loop around apic_update_irq apic: Reevaluate pending interrupts on LVT_LINT0 changes apic: Defer interrupt updates to VCPU thread cpu-exec.c

[Qemu-devel] [PATCH 1/3] apic: Resolve potential endless loop around apic_update_irq

2012-07-09 Thread Jan Kiszka
is currently blocked via TPR. Resolve this by reinjecting only where it matters: inside apic_get_interrupt. This function may clear a vector while a PIC-originated reason still exists. Signed-off-by: Jan Kiszka --- hw/apic.c | 10 +++--- 1 files changed, 7 insertions(+), 3 deletions(-) dif

[Qemu-devel] [PATCH 2/3] apic: Reevaluate pending interrupts on LVT_LINT0 changes

2012-07-09 Thread Jan Kiszka
When the guest modifies the LVT_LINT0 register, we need to check if some pending PIC interrupt can now be delivered. Signed-off-by: Jan Kiszka --- hw/apic.c | 18 ++ 1 files changed, 14 insertions(+), 4 deletions(-) diff --git a/hw/apic.c b/hw/apic.c index e65a35f..5b8f3e8

[Qemu-devel] [PATCH 3/3] apic: Defer interrupt updates to VCPU thread

2012-07-09 Thread Jan Kiszka
e_irq to the context of the target VCPU. We introduce a new interrupt flag for this, CPU_INTERRUPT_POLL. When it is set, the VCPU calls apic_poll_irq before checking for further pending interrupts. To avoid special-casing KVM, we also implement this logic for TCG mode. Signed-off-by: Jan K

[Qemu-devel] [PATCH v2] console: Implementing blinking of cursor

2012-07-09 Thread Jan Kiszka
Let the text console cursor blink at 2 HZ. Signed-off-by: Jan Kiszka --- Changes in v2: - fixed semantic of CONSOLE_CURSOR_PERIOD and reduced frequency I know there was a concern regarding the approach in general, but I still consider it useful and visually more attractive than the static

[Qemu-devel] [PATCH 4/4] slirp: Improve error reporting of inaccessible smb directories

2012-07-09 Thread Jan Kiszka
Instead of guessing, print the error code returned by access. Signed-off-by: Jan Kiszka --- net/slirp.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/net/slirp.c b/net/slirp.c index eb80889..b82eab0 100644 --- a/net/slirp.c +++ b/net/slirp.c @@ -504,8 +504,8

[Qemu-devel] [PATCH 3/4] slirp: Ensure smbd and shared directory exist when enable smb

2012-07-09 Thread Jan Kiszka
will confuse since samba server failed silently without any indication of what it did wrong. To avoid it, we check whether the shared directory exist and if users have permission to access this directory when QEMU's "built-in" SMB server is enabled. Signed-off-by: Dunrong Huang Sig

[Qemu-devel] [PATCH 2/4] slirp: add 'cmd:' target for guestfwd

2012-07-09 Thread Jan Kiszka
that allows for execution of a command on every TCP connection. This leverages the same code as the -smb parameter, just that here the command is user defined. Reported-by: Sascha Wilde Signed-off-by: Alexander Graf Signed-off-by: Jan Kiszka --- net/slirp.c |

[Qemu-devel] [PATCH 1/4] slirp: Enforce host-side user of smb share

2012-07-09 Thread Jan Kiszka
Windows 7 (and possibly other versions) cannot connect to the samba share if the exported host directory is not world-readable. This can be resolved by forcing the username used for access checks to the one under which QEMU and smbd are running. Signed-off-by: Jan Kiszka --- net/slirp.c | 14

[Qemu-devel] [PATCH 0/4] [PULL] slirp: smb fixes and cmd: target for guestfwd

2012-07-09 Thread Jan Kiszka
7;cmd:' target for guestfwd Dunrong Huang (1): slirp: Ensure smbd and shared directory exist when enable smb Jan Kiszka (2): slirp: Enforce host-side user of smb share slirp: Improve error reporting of inaccessible smb directories net/slirp.c

Re: [Qemu-devel] [PATCH v3 2/7] memory: Flush coalesced MMIO on selected region access

2012-07-10 Thread Jan Kiszka
On 2012-07-02 11:07, Avi Kivity wrote: > On 06/29/2012 07:37 PM, Jan Kiszka wrote: >> Instead of flushing pending coalesced MMIO requests on every vmexit, >> this provides a mechanism to selectively flush when memory regions >> related to the coalesced one are accessed. This

Re: [Qemu-devel] [PATCH v2] console: Implementing blinking of cursor

2012-07-10 Thread Jan Kiszka
On 2012-07-10 21:34, Blue Swirl wrote: > On Mon, Jul 9, 2012 at 2:53 PM, Jan Kiszka wrote: >> Let the text console cursor blink at 2 HZ. >> >> Signed-off-by: Jan Kiszka >> --- >> >> Changes in v2: >> - fixed semantic of CONSOLE_CURSOR_PERIOD a

[Qemu-devel] [PATCH v3] console: Implementing blinking of cursor

2012-07-10 Thread Jan Kiszka
From: Jan Kiszka Let the text console cursor blink at 2 HZ. Signed-off-by: Jan Kiszka --- Changes in v3: - renamed cursor_blink_state to cursor_visible_phase and made it a bool console.c | 26 +- 1 files changed, 25 insertions(+), 1 deletions(-) diff --git a

Re: [Qemu-devel] Segfault starting vcpu thread

2012-07-11 Thread Jan Kiszka
On 2012-07-11 13:46, Avi Kivity wrote: > Current qemu-kvm master merged with latest upstream fails on startup: > > (gdb) bt > #0 0x7fdcd4a047a0 in kvm_vcpu_ioctl (env=0x0, type=-1071075694) at > /home/tlv/akivity/qemu/kvm-all.c:1602 > #1 0x7fdcd49c9fda in kvm_apic_enable_tpr_reporting >

Re: [Qemu-devel] Segfault starting vcpu thread

2012-07-11 Thread Jan Kiszka
On 2012-07-11 13:58, Avi Kivity wrote: > On 07/11/2012 02:55 PM, Jan Kiszka wrote: >> On 2012-07-11 13:46, Avi Kivity wrote: >>> Current qemu-kvm master merged with latest upstream fails on startup: >>> >>> (gdb) bt >>> #0 0x7fdcd4a047a0 in

Re: [Qemu-devel] [PATCH v2 2/2] ivshmem: use irqfd to interrupt among VMs

2012-12-05 Thread Jan Kiszka
On 2012-12-05 06:34, Cam Macdonell wrote: >> static void ivshmem_write_config(PCIDevice *pci_dev, uint32_t address, >> uint32_t val, int len) >> { >> +bool is_enabled, was_enabled = msi_enabled(pci_dev); >> + >> pci_default_write_config(pci_dev, address,

Re: [Qemu-devel] [PATCH 2/3] target-i386:make hw_breakpoint_enabled return bool type

2012-12-05 Thread Jan Kiszka
On 2012-12-05 01:51, li guang wrote: > 在 2012-12-04二的 11:26 +,Peter Maydell写道: >> On 4 December 2012 11:11, Jan Kiszka wrote: >>> On 2012-12-04 11:23, Peter Maydell wrote: >>>> Doesn't this break the use of this function in target-i386/seg_helper.c: >&g

Re: [Qemu-devel] [PATCH 3/3] target-i386:slightly refactor dr7 related function

2012-12-05 Thread Jan Kiszka
On 2012-12-05 01:56, li guang wrote: >>> @@ -1014,22 +1016,40 @@ void hw_breakpoint_remove(CPUX86State *env, int >>> index) >>> int check_hw_breakpoints(CPUX86State *env, int force_dr6_update) >>> { >>> target_ulong dr6; >>> -int reg, type; >>> +int index; >>> int hit_enabled =

Re: [Qemu-devel] removing on-demand msix vector allocation

2012-12-06 Thread Jan Kiszka
On 2012-12-06 08:59, Michael S. Tsirkin wrote: > I've been looking at handling of msix masking > in qemu. It looks like all of virtio,vfio and > device assignment implemented their own > similar but slightly different thing. > So I am inclined to move this handling to common > code in msix.c, addin

Re: [Qemu-devel] [PATCH v3 2/3] target-i386:make hw_breakpoint_enabled return bool type

2012-12-07 Thread Jan Kiszka
On 2012-12-07 11:24, Peter Maydell wrote: > On 7 December 2012 01:25, liguang wrote: >> Signed-off-by: liguang >> --- >> target-i386/cpu.h | 15 +-- >> 1 files changed, 13 insertions(+), 2 deletions(-) >> >> diff --git a/target-i386/cpu.h b/target-i386/cpu.h >> index 29245d1..36461

Re: [Qemu-devel] [PATCH v7 00/10] i8254, i8259 and running Microport UNIX (ca 1987)

2012-12-09 Thread Jan Kiszka
On 2012-12-10 06:14, Matthew Ogilvie wrote: > On Sun, Nov 25, 2012 at 02:51:36PM -0700, Matthew Ogilvie wrote: >> This series makes a series of mostly-unrelated fixes to allow >> running an old Microport UNIX (ca 1987) guest under qemu. >> >> Changes since version 6: >>* Patches 1 through 6 hav

Re: [Qemu-devel] removing on-demand msix vector allocation

2012-12-10 Thread Jan Kiszka
On 2012-12-10 10:36, Michael S. Tsirkin wrote: > On Fri, Dec 07, 2012 at 08:37:22AM +0100, Jan Kiszka wrote: >> On 2012-12-06 08:59, Michael S. Tsirkin wrote: >>> I've been looking at handling of msix masking >>> in qemu. It looks like all of virtio,vfio and >>

Re: [Qemu-devel] [PATCH 0/2] i2c: Add AT24Cxx EEPROM model

2012-12-12 Thread Jan Kiszka
On 2012-11-19 15:24, Jan Kiszka wrote: > See patches for details. > > Jan Kiszka (2): > i2c: Introduce device address mask > Add AT24Cxx I2C EEPROM device model > > hw/Makefile.objs |2 +- > hw/at24.c| 363 > ++

Re: [Qemu-devel] [PATCH v7 00/10] i8254, i8259 and running Microport UNIX (ca 1987)

2012-12-12 Thread Jan Kiszka
On 2012-12-12 12:36, Gleb Natapov wrote: >>How about things like pit_get_out(), >> pit_get_next_transition_time(), etc in qemu/hw/i8254_common.c? (If >> not used when KVM is enabled, then why are they "common"?) What >> are the implications if qemu and KVM

Re: [Qemu-devel] [PATCH] kvm: do not flush after deleting gsi

2012-12-12 Thread Jan Kiszka
gt; static unsigned int kvm_hash_msi(uint32_t data) > Reviewed-by: Jan Kiszka -- Siemens AG, Corporate Technology, CT RTC ITP SDP-DE Corporate Competence Center Embedded Linux

Re: [Qemu-devel] [PATCH] kvm: do not flush after deleting gsi

2012-12-13 Thread Jan Kiszka
On 2012-12-13 05:55, Asias He wrote: > Hello Michael, > > On 12/12/2012 06:48 PM, Michael S. Tsirkin wrote: >> Deleting a GSI isn't necessary: it is enough >> to stop using it. Delay flush until an entry is used. >> >> Signed-off-by: Michael S. Tsirkin >> --- >> kvm-all.c | 2 -- >> 1 file chang

Re: [Qemu-devel] [PATCH 2/2] hw: Add test device for unittests execution v6

2012-12-13 Thread Jan Kiszka
On 2012-12-13 15:48, Lucas Meneghel Rodrigues wrote: > Add a test device which supports the kvmctl ioports, > so one can run the KVM unittest suite. > > Intended Usage: > > qemu-system-x86_64\ > -device pc-testdev -serial stdio \ > -device isa-debugexit,iobase=0xf4,access-size=4 \ > -kernel /path

Re: [Qemu-devel] [PATCH] gdbstub: Do not kill target in system emulation mode

2013-01-24 Thread Jan Kiszka
On 2013-01-24 12:19, Fabien Chouteau wrote: > On 01/24/2013 03:02 AM, Joel Brobecker wrote: >>> qAttached is not supported in Qemu yet, this explains why Gdb sends >>> "kill" at the end of debug session. I will implement it and revert your >>> patch. Gdb will automatically detach instead of kill at

[Qemu-devel] [PATCH] configure: Create link to icon bitmap for out-of-tree builds

2013-02-02 Thread Jan Kiszka
From: Jan Kiszka Signed-off-by: Jan Kiszka --- configure |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/configure b/configure index 0657b1a..cfccec5 100755 --- a/configure +++ b/configure @@ -4289,6 +4289,7 @@ FILES="$FILES tests/tcg/lm32/Makefile" FILES=

[Qemu-devel] uhci: cancel delay for unregistered queues

2013-02-12 Thread Jan Kiszka
Hi, was just debugging a memory corruption of my USB driver inside QEMU - and so far only there: I have a queue registered with the UHCI controller on an input endpoint that continuously generates data. At some point my driver decides to stop reading and removes the QH (with a lot of TDs attached

Re: [Qemu-devel] [BUG] Guest OS hangs on boot when 64bit BAR present (kvm-apic -msi resource conflict)

2013-02-13 Thread Jan Kiszka
On 2013-02-13 11:24, Michael S. Tsirkin wrote: > On Wed, Feb 13, 2013 at 06:06:37PM +1300, Alexey Korolev wrote: >> Sometime ago I reported an issue about guest OS hang when 64bit BAR present. >> http://lists.gnu.org/archive/html/qemu-devel/2012-01/msg03189.html >> http://lists.gnu.org/archive/html

Re: [Qemu-devel] [PATCH 4/7 v2] KVM regsync: Add register bitmap parameter to do_kvm_cpu_synchronize_state

2013-02-13 Thread Jan Kiszka
On 2013-02-11 23:49, Marcelo Tosatti wrote: > On Fri, Feb 01, 2013 at 10:47:37AM -0500, Jason J. Herne wrote: >> On 01/24/2013 07:40 AM, Alexander Graf wrote: >>> I think for now the best choice for get_regs() would be to ignore the >>> FULL/RESET bits and always keep the syncing as it happens tod

[Qemu-devel] [PATCH][QEMU] vmxcap: Open MSR file in unbuffered mode

2013-02-13 Thread Jan Kiszka
Python may otherwise decide to to read larger chunks, applying the seek only on the software buffer. This will return results from the wrong MSRs. Signed-off-by: Jan Kiszka --- scripts/kvm/vmxcap |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/scripts/kvm/vmxcap b

[Qemu-devel] [PATCH][QEMU] vmxcap: Augment reported information

2013-02-13 Thread Jan Kiszka
Parse the Basic VMX Information MSR and add the bit for the new posted interrupts. Signed-off-by: Jan Kiszka --- scripts/kvm/vmxcap | 14 ++ 1 files changed, 14 insertions(+), 0 deletions(-) diff --git a/scripts/kvm/vmxcap b/scripts/kvm/vmxcap index 6363e73..a1a44a0 100755 --- a

[Qemu-devel] [PATCH] vmxcap: Report APIC register emulation

2013-02-17 Thread Jan Kiszka
From: Jan Kiszka Signed-off-by: Jan Kiszka --- scripts/kvm/vmxcap |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/scripts/kvm/vmxcap b/scripts/kvm/vmxcap index a1a44a0..bcf79f6 100755 --- a/scripts/kvm/vmxcap +++ b/scripts/kvm/vmxcap @@ -161,6 +161,7 @@ controls

[Qemu-devel] [PATCH v2][QEMU] vmxcap: Report APIC register emulation and RDTSCP control

2013-02-17 Thread Jan Kiszka
From: Jan Kiszka Signed-off-by: Jan Kiszka --- This time I've checked twice that I'm no longer missing a field. scripts/kvm/vmxcap |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/scripts/kvm/vmxcap b/scripts/kvm/vmxcap index a1a44a0..a79f816 100755 --- a/s

Re: [Qemu-devel] [PATCH] kvmvapic: add read operation to the MemoryRegionOps to fix segfault

2013-02-18 Thread Jan Kiszka
On 2013-02-16 10:20, Tommi Rantala wrote: > QEMU would occasionally segfault when fuzzing the linux kernel with > Trinity. Add a read op (copied from hw/kvm/apic.c) to vapic_ops to > prevent the crash. > > Program received signal SIGSEGV, Segmentation fault. > [Switching to Thread 0x7fffeddcc700

Re: [Qemu-devel] [PATCH for-1.4] pc: tag apic as overlap region

2013-02-19 Thread Jan Kiszka
On 2013-02-19 16:20, Michael S. Tsirkin wrote: > apic overlaps PCI space. On real hardware it has > higher priority, emulate this correctly. > > This should addresses the following issue: > >> Subject: Re: [BUG] Guest OS hangs on boot when 64bit BAR present >> (kvm-apic-msi resource conflict) >>

Re: [Qemu-devel] [PATCH for-1.4] pc: tag apic as overlap region

2013-02-19 Thread Jan Kiszka
On 2013-02-19 17:20, Peter Maydell wrote: > On 19 February 2013 16:05, Jan Kiszka wrote: >> On 2013-02-19 16:54, Peter Maydell wrote: >>> On 19 February 2013 15:51, Jan Kiszka wrote: >>>> On 2013-02-19 16:20, Michael S. Tsirkin wrote: >>>>

Re: [Qemu-devel] [PATCH for-1.4] pc: tag apic as overlap region

2013-02-19 Thread Jan Kiszka
On 2013-02-19 16:54, Peter Maydell wrote: > On 19 February 2013 15:51, Jan Kiszka wrote: >> On 2013-02-19 16:20, Michael S. Tsirkin wrote: >>> qdev_init_nofail(dev); >>> d = SYS_BUS_DEVICE(dev); >>> -sysbus_mmio_map(d, 0, 0xfec0); >

<    1   2   3   4   5   6   7   8   9   10   >