Re: [Qemu-devel] [PATCH v2 7/8] optionsrom: Reserve space for checksum

2012-02-11 Thread Jan Kiszka
On 2012-02-11 12:46, Andreas Färber wrote: > Am 10.02.2012 19:31, schrieb Jan Kiszka: >> Always add a byte before the final 512-bytes alignment to reserve the >> space for the ROM checksum. >> >> Signed-off-by: Jan Kiszka >> --- >> pc-bios/optionrom/option

Re: [Qemu-devel] [PATCH v2 7/8] optionsrom: Reserve space for checksum

2012-02-11 Thread Jan Kiszka
On 2012-02-11 13:51, Andreas Färber wrote: > Am 11.02.2012 13:45, schrieb Jan Kiszka: >> On 2012-02-11 12:46, Andreas Färber wrote: >>> Am 10.02.2012 19:31, schrieb Jan Kiszka: >>>> Always add a byte before the final 512-bytes alignment to >>>&

Re: [Qemu-devel] [PATCH v2 1/8] kvm: Set cpu_single_env only once

2012-02-11 Thread Jan Kiszka
On 2012-02-11 14:06, Andreas Färber wrote: > Am 11.02.2012 13:43, schrieb Jan Kiszka: >> On 2012-02-11 12:49, Andreas Färber wrote: >>> Am 11.02.2012 12:25, schrieb Blue Swirl: >>>> I think using cpu_single_env is an indication of a problem, >>>> like

Re: [Qemu-devel] [PATCH v2 1/8] kvm: Set cpu_single_env only once

2012-02-11 Thread Jan Kiszka
On 2012-02-11 14:21, Andreas Färber wrote: > Am 11.02.2012 14:07, schrieb Jan Kiszka: >> On 2012-02-11 14:06, Andreas Färber wrote: >>> Am 11.02.2012 13:43, schrieb Jan Kiszka: >>>> On 2012-02-11 12:49, Andreas Färber wrote: >>>>> Am 11.02.2012 12

Re: [Qemu-devel] [PATCH v2 1/8] kvm: Set cpu_single_env only once

2012-02-11 Thread Jan Kiszka
On 2012-02-11 14:54, Blue Swirl wrote: > On Sat, Feb 11, 2012 at 12:43, Jan Kiszka wrote: >> On 2012-02-11 12:49, Andreas Färber wrote: >>> Am 11.02.2012 12:25, schrieb Blue Swirl: >>>> I think using cpu_single_env is an indication of a problem, like poor >>>

Re: [Qemu-devel] [PATCH v2 1/8] kvm: Set cpu_single_env only once

2012-02-11 Thread Jan Kiszka
On 2012-02-11 14:59, Andreas Färber wrote: > Am 11.02.2012 14:35, schrieb Jan Kiszka: >> On 2012-02-11 14:21, Andreas Färber wrote: >>> CPU base class v3: http://patchwork.ozlabs.org/patch/139284/ (v4 >>> coming up) >>> >>> That doesn't prevent tar

Re: [Qemu-devel] [PATCH v2 1/8] kvm: Set cpu_single_env only once

2012-02-11 Thread Jan Kiszka
On 2012-02-11 15:11, Blue Swirl wrote: > On Sat, Feb 11, 2012 at 14:00, Jan Kiszka wrote: >> On 2012-02-11 14:54, Blue Swirl wrote: >>> On Sat, Feb 11, 2012 at 12:43, Jan Kiszka wrote: >>>> On 2012-02-11 12:49, Andreas Färber wrote: >>>>> Am 11.02.2

Re: [Qemu-devel] [PATCH v2 1/8] kvm: Set cpu_single_env only once

2012-02-11 Thread Jan Kiszka
On 2012-02-11 15:12, Andreas Färber wrote: > Am 11.02.2012 15:02, schrieb Jan Kiszka: >> On 2012-02-11 14:59, Andreas Färber wrote: >>> Am 11.02.2012 14:35, schrieb Jan Kiszka: >>>> On 2012-02-11 14:21, Andreas Färber wrote: >>>>> CPU base class

Re: [Qemu-devel] [PATCH v2 2/8] Allow to use pause_all_vcpus from VCPU context

2012-02-11 Thread Jan Kiszka
On 2012-02-11 15:16, Blue Swirl wrote: > On Fri, Feb 10, 2012 at 18:31, Jan Kiszka wrote: >> In order to perform critical manipulations on the VM state in the >> context of a VCPU, specifically code patching, stopping and resuming of >> all VCPUs may be necessary. resume

Re: [Qemu-devel] slirp-related crash

2012-02-12 Thread Jan Kiszka
On 2012-02-12 19:34, Michael S. Tsirkin wrote: > It seems somewhat easy to crash qemu with slirp if we queue multiple packets. > I didn't investigate further yet so I don't know if this > is a regression. Anyone knowledgeable about slirp wants to take a look? > > /home/mst/qemu-test/bin/qemu-syste

Re: [Qemu-devel] [PATCH v2 5/8] kvmvapic: Introduce TPR access optimization for Windows guests

2012-02-13 Thread Jan Kiszka
On 2012-02-11 16:25, Blue Swirl wrote: > On Fri, Feb 10, 2012 at 18:31, Jan Kiszka wrote: >> This enables acceleration for MMIO-based TPR registers accesses of >> 32-bit Windows guest systems. It is mostly useful with KVM enabled, >> either on older Intel CPUs (without flex

Re: [Qemu-devel] Missing patch in QEMU which is in QEMU-KVM

2012-02-13 Thread Jan Kiszka
On 2012-02-13 07:21, Gerhard Wiesinger wrote: > Hello, > > I miss the following patch in QEMU which is in QEMU-KVM: > http://article.gmane.org/gmane.comp.emulators.kvm.devel/13557 > > commit a7fe0297840908a4fd65a1cf742481ccd45960eb > Author: Andreas Winkelbauer > Date: Sun Feb 24 10:33:27 2008

Re: [Qemu-devel] [PATCH] i8259: Do not clear level-triggered lines in IRR on init

2012-02-13 Thread Jan Kiszka
On 2012-01-24 16:29, Jan Kiszka wrote: > When an input line is handled as level-triggered, it will immediately > raise an IRQ on the output of a PIC again that goes through an init > reset. So only clear the edge-triggered inputs from IRR in that > scenario. > > Signed-

Re: [Qemu-devel] [PATCH v2 5/8] kvmvapic: Introduce TPR access optimization for Windows guests

2012-02-13 Thread Jan Kiszka
On 2012-02-13 19:50, Blue Swirl wrote: > On Mon, Feb 13, 2012 at 10:16, Jan Kiszka wrote: >> On 2012-02-11 16:25, Blue Swirl wrote: >>> On Fri, Feb 10, 2012 at 18:31, Jan Kiszka wrote: >>>> This enables acceleration for MMIO-based TPR registers accesses of >>

Re: [Qemu-devel] slirp-related crash

2012-02-13 Thread Jan Kiszka
On 2012-02-13 16:27, Zhi Yong Wu wrote: > On Mon, Feb 13, 2012 at 4:24 AM, Jan Kiszka wrote: >> On 2012-02-12 19:34, Michael S. Tsirkin wrote: >>> It seems somewhat easy to crash qemu with slirp if we queue multiple >>> packets. >>> I didn't investigate f

Re: [Qemu-devel] slirp-related crash

2012-02-13 Thread Jan Kiszka
On 2012-02-13 20:35, Jan Kiszka wrote: > On 2012-02-13 16:27, Zhi Yong Wu wrote: >> On Mon, Feb 13, 2012 at 4:24 AM, Jan Kiszka wrote: >>> On 2012-02-12 19:34, Michael S. Tsirkin wrote: >>>> It seems somewhat easy to crash qemu with slirp if we queue multipl

Re: [Qemu-devel] slirp-related crash

2012-02-13 Thread Jan Kiszka
On 2012-02-13 21:43, Alex Bradbury wrote: > On 13 February 2012 19:35, Jan Kiszka wrote: >> I'm inclined to suggest a slirp rewrite (base support, not all features >> at once) as a GSOC project. QEMU really deserves something better. > > Would it be feasible to adopt

Re: [Qemu-devel] Kernel mode VGAs?

2012-02-14 Thread Jan Kiszka
On 2012-02-14 08:12, Gerhard Wiesinger wrote: > Hello, > > Current QEMU-KVM VGA implementation have the following problem with > legacy OS (e.g. DOS with INT10h calls): Performance is low on accessing > A000:0 > page and doing bank switching at the 64k page. Do we already understand the mode and

Re: [Qemu-devel] [PATCH v2 5/8] kvmvapic: Introduce TPR access optimization for Windows guests

2012-02-14 Thread Jan Kiszka
On 2012-02-14 08:54, Gleb Natapov wrote: > On Mon, Feb 13, 2012 at 08:22:21PM +0100, Jan Kiszka wrote: >>>> Unfortunately, this is only an internal structure, not officially >>>> documented by MS. However, all supported OS versions a legacy by now, no >>

Re: [Qemu-devel] slirp-related crash

2012-02-14 Thread Jan Kiszka
On 2012-02-14 09:22, Stefan Hajnoczi wrote: > On Mon, Feb 13, 2012 at 08:35:45PM +0100, Jan Kiszka wrote: >> On 2012-02-13 16:27, Zhi Yong Wu wrote: >> I'm inclined to suggest a slirp rewrite (base support, not all features >> at once) as a GSOC project. QEMU really

[Qemu-devel] [PATCH v3 6/9] kvmvapic: Introduce TPR access optimization for Windows guests

2012-02-14 Thread Jan Kiszka
-by: Jan Kiszka --- Makefile.target|3 +- hw/apic.c | 126 - hw/apic_common.c | 64 - hw/apic_internal.h | 27 ++ hw/kvm/apic.c | 32 ++ hw/kvmvapic.c | 803 6 files changed, 1041 insertions

[Qemu-devel] [PATCH v3 2/9] Remove useless casts from cpu iterators

2012-02-14 Thread Jan Kiszka
CPUState::next_cpu is already CPUState *. Signed-off-by: Jan Kiszka --- cpus.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/cpus.c b/cpus.c index d0c8340..4e65894 100644 --- a/cpus.c +++ b/cpus.c @@ -853,7 +853,7 @@ static int all_vcpus_paused(void

[Qemu-devel] [PATCH v3 9/9] kvmvapic: Use optionrom helpers

2012-02-14 Thread Jan Kiszka
Use OPTION_ROM_START/END from the common header file, add comment to init code. Signed-off-by: Jan Kiszka --- pc-bios/optionrom/kvmvapic.S | 18 -- 1 files changed, 8 insertions(+), 10 deletions(-) diff --git a/pc-bios/optionrom/kvmvapic.S b/pc-bios/optionrom/kvmvapic.S index

[Qemu-devel] [PATCH v3 5/9] kvmvapic: Add option ROM

2012-02-14 Thread Jan Kiszka
This imports and builds the original VAPIC option ROM of qemu-kvm. Its interaction with QEMU is described in the commit that introduces the corresponding device model. Signed-off-by: Jan Kiszka --- .gitignore |1 + Makefile |2 +- pc-bios/optionrom

[Qemu-devel] [PATCH v3 1/9] kvm: Set cpu_single_env only once

2012-02-14 Thread Jan Kiszka
As we have thread-local cpu_single_env now and KVM uses exactly one thread per VCPU, we can drop the cpu_single_env updates from the loop and initialize this variable only once during setup. Signed-off-by: Jan Kiszka --- cpus.c|1 + kvm-all.c |5 - 2 files changed, 1 insertions

Re: [Qemu-devel] [RFC][PATCH 01/16 v6] monitor: introduce qemu_suspend_monitor()/qemu_resume_monitor()

2012-02-14 Thread Jan Kiszka
On 2012-02-09 04:19, Wen Congyang wrote: > Sync command needs these two APIs to suspend/resume monitor. > > Signed-off-by: Wen Congyang > --- > monitor.c | 27 +++ > monitor.h |2 ++ > 2 files changed, 29 insertions(+), 0 deletions(-) > > diff --git a/monitor.c b/m

Re: [Qemu-devel] [RFC][PATCH 02/16 v6] Add API to create memory mapping list

2012-02-14 Thread Jan Kiszka
On 2012-02-09 04:20, Wen Congyang wrote: > The memory mapping list stores virtual address and physical address mapping. > The folloing patch will use this information to create PT_LOAD in the vmcore. > > Signed-off-by: Wen Congyang > --- > Makefile.target |1 + > memory_mapping.c | 130 >

Re: [Qemu-devel] [RFC][PATCH 03/16 v6] Add API to check whether a physical address is I/O address

2012-02-14 Thread Jan Kiszka
On 2012-02-09 04:21, Wen Congyang wrote: > This API will be used in the following patch. > > Signed-off-by: Wen Congyang > --- > cpu-common.h |2 ++ > exec.c | 16 > 2 files changed, 18 insertions(+), 0 deletions(-) > > diff --git a/cpu-common.h b/cpu-common.h > ind

Re: [Qemu-devel] [RFC][PATCH 04/16 v6] target-i386: implement cpu_get_memory_mapping()

2012-02-14 Thread Jan Kiszka
On 2012-02-09 04:21, Wen Congyang wrote: > Walk cpu's page table and collect all virtual address and physical address > mapping. > Then, add these mapping into memory mapping list. > > Signed-off-by: Wen Congyang > --- > Makefile.target |2 +- > cpu-all.h |7 ++ >

Re: [Qemu-devel] [RFC][PATCH 05/16 v6] Add API to get memory mapping

2012-02-14 Thread Jan Kiszka
On 2012-02-09 04:22, Wen Congyang wrote: > Add API to get all virtual address and physical address mapping. > If there is no virtual address for some physical address, the virtual > address is 0. > > Signed-off-by: Wen Congyang > --- > memory_mapping.c | 65 > +

[Qemu-devel] [PATCH v3 0/9] uq/master: TPR access optimization for Windows guests

2012-02-14 Thread Jan Kiszka
conflicts on merge) The series is also available at git://git.kiszka.org/qemu-kvm.git queues/kvm-tpr Please review/apply. CC: Paolo Bonzini Jan Kiszka (9): kvm: Set cpu_single_env only once Remove useless casts from cpu iterators Allow to use pause_all_vcpus from VCPU context

Re: [Qemu-devel] [RFC][PATCH 06/16 v6] target-i386: Add API to write elf notes to core file

2012-02-14 Thread Jan Kiszka
On 2012-02-09 04:24, Wen Congyang wrote: > The core file contains register's value. These APIs write registers to > core file, and them will be called in the following patch. > > Signed-off-by: Wen Congyang > --- > cpu-all.h |6 + > target-i386/arch-dump.c | 243 > +++

Re: [Qemu-devel] [RFC][PATCH 07/16 v6] target-i386: Add API to add extra memory mapping

2012-02-14 Thread Jan Kiszka
On 2012-02-09 04:24, Wen Congyang wrote: > Crash needs extra memory mapping to determine phys_base. > > Signed-off-by: Wen Congyang > --- > cpu-all.h |2 ++ > target-i386/arch-dump.c | 43 +++ > 2 files changed, 45 insertions(+), 0 dele

Re: [Qemu-devel] [RFC][PATCH 08/16 v6] target-i386: add API to get dump info

2012-02-14 Thread Jan Kiszka
On 2012-02-09 04:26, Wen Congyang wrote: > Dump info contains: endian, class and architecture. The next > patch will use these information to create vmcore. > > Signed-off-by: Wen Congyang > --- > cpu-all.h |3 +++ > dump.h | 10 ++ > target-i386/arch

Re: [Qemu-devel] [RFC][PATCH 09/16 v6] introduce a new monitor command 'dump' to dump guest's memory

2012-02-14 Thread Jan Kiszka
On 2012-02-09 04:28, Wen Congyang wrote: > Signed-off-by: Wen Congyang > --- > Makefile.target |8 +- > dump.c | 590 > ++ > dump.h |3 + > hmp-commands.hx | 16 ++ > hmp.c|9 + > hmp.h

Re: [Qemu-devel] [RFC][PATCH 10/16 v6] run dump at the background

2012-02-14 Thread Jan Kiszka
On 2012-02-09 04:28, Wen Congyang wrote: > The new monitor command dump may take long time to finish. So we need run it > at the background. How does it work? Like live migration, i.e. you retransmit (overwrite) already written but then dirtied pages? Hmm... no. What does background mean then? Wh

[Qemu-devel] [PATCH v3 4/9] target-i386: Add infrastructure for reporting TPR MMIO accesses

2012-02-14 Thread Jan Kiszka
precise information. Signed-off-by: Jan Kiszka --- cpu-all.h|3 ++- hw/apic.h|2 ++ hw/apic_common.c |4 target-i386/cpu.h| 11 +++ target-i386/helper.c | 19 +++ target-i386/kvm.c| 24 ++-- 6

Re: [Qemu-devel] [RFC][PATCH 16/16 v6] allow user to dump a fraction of the memory

2012-02-14 Thread Jan Kiszka
On 2012-02-09 04:34, Wen Congyang wrote: > diff --git a/hmp-commands.hx b/hmp-commands.hx > index a026905..388b9ac 100644 > --- a/hmp-commands.hx > +++ b/hmp-commands.hx > @@ -868,9 +868,11 @@ ETEXI > > { > .name = "dump", > -.args_type = "detach:-d,file:s", > +

Re: [Qemu-devel] [RFC][PATCH 10/16 v6] run dump at the background

2012-02-14 Thread Jan Kiszka
On 2012-02-14 19:05, Jan Kiszka wrote: > On 2012-02-09 04:28, Wen Congyang wrote: >> The new monitor command dump may take long time to finish. So we need run it >> at the background. > > How does it work? Like live migration, i.e. you retransmit (overwrite) > already

[Qemu-devel] [PATCH v3 7/9] kvmvapic: Simplify mp/up_set_tpr

2012-02-14 Thread Jan Kiszka
The CH registers is only written, never read. So we can remove these operations and, in case of up_set_tpr, also the ECX push/pop. Signed-off-by: Jan Kiszka --- pc-bios/optionrom/kvmvapic.S |6 +- 1 files changed, 1 insertions(+), 5 deletions(-) diff --git a/pc-bios/optionrom

[Qemu-devel] [PATCH v3 3/9] Allow to use pause_all_vcpus from VCPU context

2012-02-14 Thread Jan Kiszka
to wait for the whole gang. CC: Paolo Bonzini Signed-off-by: Jan Kiszka --- cpus.c | 12 1 files changed, 12 insertions(+), 0 deletions(-) diff --git a/cpus.c b/cpus.c index 4e65894..290daa8 100644 --- a/cpus.c +++ b/cpus.c @@ -870,6 +870,18 @@ void pause_all_vcpus(void

[Qemu-devel] [PATCH v3 8/9] optionsrom: Reserve space for checksum

2012-02-14 Thread Jan Kiszka
Always add a byte before the final 512-bytes alignment to reserve the space for the ROM checksum. Signed-off-by: Jan Kiszka --- pc-bios/optionrom/optionrom.h |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/pc-bios/optionrom/optionrom.h b/pc-bios/optionrom/optionrom.h

Re: [Qemu-devel] [PATCH 1/2] slirp: remove duplicate definition

2012-02-15 Thread Jan Kiszka
On 2012-02-15 09:12, zwu.ker...@gmail.com wrote: > From: Zhi Yong Wu > > Signed-off-by: Zhi Yong Wu > --- > slirp/if.c |2 -- > 1 files changed, 0 insertions(+), 2 deletions(-) > > diff --git a/slirp/if.c b/slirp/if.c > index 2852396..8e0cac2 100644 > --- a/slirp/if.c > +++ b/slirp/if.c >

Re: [Qemu-devel] [PATCH 2/2] slirp: fix packet requeue issue in batchq

2012-02-15 Thread Jan Kiszka
On 2012-02-15 09:13, zwu.ker...@gmail.com wrote: > From: Zhi Yong Wu > > This patch fixes the slirp crash in current QEMU upstream. > > Signed-off-by: Zhi Yong Wu > --- > slirp/if.c | 37 ++--- > slirp/mbuf.c |3 +-- > 2 files changed, 31 insertions(+),

Re: [Qemu-devel] [RFC][PATCH 01/16 v6] monitor: introduce qemu_suspend_monitor()/qemu_resume_monitor()

2012-02-15 Thread Jan Kiszka
On 2012-02-15 03:54, Wen Congyang wrote: > At 02/15/2012 12:19 AM, Jan Kiszka Wrote: >> On 2012-02-09 04:19, Wen Congyang wrote: >>> Sync command needs these two APIs to suspend/resume monitor. >>> >>> Signed-off-by: Wen Con

Re: [Qemu-devel] [PATCH 0/6] qapi: Convert migrate

2012-02-15 Thread Jan Kiszka
On 2012-02-10 20:31, Luiz Capitulino wrote: > This is a rebase of Anthony's conversion, from his glib branch; and this is > also the beginning of the conversion of complex commands to the qapi. > > There are two important changes that should be observed: > > 1. patch 5/6 purges the 'mon' object

Re: [Qemu-devel] [PATCH 5/6] Purge migration of (almost) everything to do with monitors

2012-02-15 Thread Jan Kiszka
On 2012-02-10 20:31, Luiz Capitulino wrote: > The Monitor object is passed back and forth within the migration/savevm > code so that it can print errors and progress to the user. > > However, that approach assumes a HMP monitor, being completely invalid > in QMP. > > This commit drops almost ever

Re: [Qemu-devel] [RFC][PATCH 10/16 v6] run dump at the background

2012-02-15 Thread Jan Kiszka
On 2012-02-15 04:47, Wen Congyang wrote: > At 02/15/2012 02:27 AM, Jan Kiszka Wrote: >> On 2012-02-14 19:05, Jan Kiszka wrote: >>> On 2012-02-09 04:28, Wen Congyang wrote: >>>> The new monitor command dump may take long time to finish. So we need run >>>&

Re: [Qemu-devel] [RFC][PATCH 05/16 v6] Add API to get memory mapping

2012-02-15 Thread Jan Kiszka
On 2012-02-15 05:07, Wen Congyang wrote: > At 02/15/2012 01:21 AM, Jan Kiszka Wrote: >> On 2012-02-09 04:22, Wen Congyang wrote: >>> Add API to get all virtual address and physical address mapping. >>> If there is no virtual address for some physical address, t

Re: [Qemu-devel] [RFC][PATCH 10/16 v6] run dump at the background

2012-02-15 Thread Jan Kiszka
On 2012-02-15 10:22, Wen Congyang wrote: > At 02/15/2012 05:07 PM, Jan Kiszka Wrote: >> On 2012-02-15 04:47, Wen Congyang wrote: >>> At 02/15/2012 02:27 AM, Jan Kiszka Wrote: >>>> On 2012-02-14 19:05, Jan Kiszka wrote: >>>>> On 2012-02-09 04:28, Wen C

Re: [Qemu-devel] [RFC][PATCH 07/16 v6] target-i386: Add API to add extra memory mapping

2012-02-15 Thread Jan Kiszka
On 2012-02-15 06:19, Wen Congyang wrote: > At 02/15/2012 01:35 AM, Jan Kiszka Wrote: >> On 2012-02-09 04:24, Wen Congyang wrote: >>> Crash needs extra memory mapping to determine phys_base. >>> >>> Signed-off-by: Wen Congyang >>> --- >>> c

Re: [Qemu-devel] [RFC][PATCH 08/16 v6] target-i386: add API to get dump info

2012-02-15 Thread Jan Kiszka
On 2012-02-15 04:30, Wen Congyang wrote: >>> diff --git a/dump.h b/dump.h >>> new file mode 100644 >>> index 000..a36468b >>> --- /dev/null >>> +++ b/dump.h >>> @@ -0,0 +1,10 @@ >> >> License header missing. > > There is no license in other header files. But those are preexisting files, no ne

Re: [Qemu-devel] [PATCH 1/2] slirp: remove duplicate definition

2012-02-15 Thread Jan Kiszka
On 2012-02-15 10:38, Michael S. Tsirkin wrote: > On Wed, Feb 15, 2012 at 09:30:23AM +0100, Jan Kiszka wrote: >> On 2012-02-15 09:12, zwu.ker...@gmail.com wrote: >>> From: Zhi Yong Wu >>> >>> Signed-off-by: Zhi Yong Wu >>> --- >>> slirp/i

Re: [Qemu-devel] [RFC][PATCH 10/16 v6] run dump at the background

2012-02-15 Thread Jan Kiszka
On 2012-02-15 10:35, Wen Congyang wrote: > At 02/15/2012 05:21 PM, Jan Kiszka Wrote: >> On 2012-02-15 10:22, Wen Congyang wrote: >>> At 02/15/2012 05:07 PM, Jan Kiszka Wrote: >>>> On 2012-02-15 04:47, Wen Congyang wrote: >>>>> At 02/15/2012 02:27 AM,

Re: [Qemu-devel] [RFC][PATCH 05/16 v6] Add API to get memory mapping

2012-02-15 Thread Jan Kiszka
On 2012-02-15 10:47, HATAYAMA Daisuke wrote: > From: Wen Congyang > Subject: Re: [RFC][PATCH 05/16 v6] Add API to get memory mapping > Date: Wed, 15 Feb 2012 17:41:15 +0800 > >> At 02/15/2012 05:17 PM, Jan Kiszka Wrote: >>> On 2012-02-15 05:07, Wen Congyang wrote:

Re: [Qemu-devel] [RFC][PATCH 07/16 v6] target-i386: Add API to add extra memory mapping

2012-02-15 Thread Jan Kiszka
On 2012-02-15 10:44, Wen Congyang wrote: > At 02/15/2012 05:21 PM, Jan Kiszka Wrote: >> On 2012-02-15 06:19, Wen Congyang wrote: >>> At 02/15/2012 01:35 AM, Jan Kiszka Wrote: >>>> On 2012-02-09 04:24, Wen Congyang wrote: >>>>> Crash need

Re: [Qemu-devel] [PATCH 6/6] qapi: Convert migrate

2012-02-15 Thread Jan Kiszka
On 2012-02-10 20:31, Luiz Capitulino wrote: > The migrate command is one of those commands where HMP and QMP completely > mix up together. This made the conversion to the QAPI (which separates the > command into QMP and HMP parts) a bit difficult. > > The first important change to be noticed is th

Re: [Qemu-devel] [PATCH 5/6] Purge migration of (almost) everything to do with monitors

2012-02-15 Thread Jan Kiszka
On 2012-02-15 13:53, Luiz Capitulino wrote: > On Wed, 15 Feb 2012 10:02:54 +0100 > Jan Kiszka wrote: > >> On 2012-02-10 20:31, Luiz Capitulino wrote: >>> The Monitor object is passed back and forth within the migration/savevm >>> code so that it can prin

Re: [Qemu-devel] [PATCH 0/6] qapi: Convert migrate

2012-02-15 Thread Jan Kiszka
On 2012-02-15 13:49, Luiz Capitulino wrote: > On Wed, 15 Feb 2012 09:59:07 +0100 > Jan Kiszka wrote: > >> On 2012-02-10 20:31, Luiz Capitulino wrote: >>> This is a rebase of Anthony's conversion, from his glib branch; and this is >>> also the beginning of

Re: [Qemu-devel] [PATCH 6/6] qapi: Convert migrate

2012-02-15 Thread Jan Kiszka
On 2012-02-15 14:31, Jan Kiszka wrote: > On 2012-02-10 20:31, Luiz Capitulino wrote: >> The migrate command is one of those commands where HMP and QMP completely >> mix up together. This made the conversion to the QAPI (which separates the >> command into QMP and HMP p

Re: [Qemu-devel] QEMU Mascot Competition

2012-02-15 Thread Jan Kiszka
On 2012-02-15 15:48, Anthony Liguori wrote: > On 02/13/2012 03:24 PM, Anthony Liguori wrote: >> Hi, >> >> First, let me apologize that this has taken so long. But it's time to >> start >> voting on the submitted QEMU Mascots so we can pick Q! >> >> Here's how it will work: >> >> I will send a serie

Re: [Qemu-devel] [PATCH 0/6] qapi: Convert migrate

2012-02-15 Thread Jan Kiszka
On 2012-02-15 18:23, Luiz Capitulino wrote: > On Wed, 15 Feb 2012 14:34:52 +0100 > Jan Kiszka wrote: > >> On 2012-02-15 13:49, Luiz Capitulino wrote: >>> On Wed, 15 Feb 2012 09:59:07 +0100 >>> Jan Kiszka wrote: >>> >>>> On 2012-02-10 2

Re: [Qemu-devel] [PATCH 0/6] qapi: Convert migrate

2012-02-15 Thread Jan Kiszka
On 2012-02-15 18:49, Luiz Capitulino wrote: > On Wed, 15 Feb 2012 18:39:31 +0100 > Jan Kiszka wrote: > >> On 2012-02-15 18:23, Luiz Capitulino wrote: >>> On Wed, 15 Feb 2012 14:34:52 +0100 >>> Jan Kiszka wrote: >>> >>>> On 2012-02-15 13:49,

Re: [Qemu-devel] [MASCOT CONTEST] Benoit Canet #2

2012-02-15 Thread Jan Kiszka
On 2012-02-15 15:34, Anthony Liguori wrote: > Please respond to this note with an '+1', or an Ack, to vote for this icon. +1

Re: [Qemu-devel] [PATCH] slirp: kill ugly macros

2012-02-15 Thread Jan Kiszka
On 2012-02-15 19:45, Michael S. Tsirkin wrote: > Remove ugly macros for field names, > change done by the following script: > > s#\bifq_prev\b#m_prev#g; > s#\bifq_next\b#m_next#g; > s#\bifs_prev\b#m_prevpkt#g; > s#\bifs_next\b#m_nextpkt#g; > s#\bifq_so\b#m_so#g; > s#\bm_next\b#m_hdr.mh_next#g; > s

Re: [Qemu-devel] [PATCH v2] slirp: fix packet requeue issue in batchq

2012-02-16 Thread Jan Kiszka
On 2012-02-16 09:07, zwu.ker...@gmail.com wrote: > From: Zhi Yong Wu > Please summarize in a bit more details what was broken. > Signed-off-by: Zhi Yong Wu > --- > slirp/if.c | 19 +-- > slirp/mbuf.c |3 +-- > 2 files changed, 18 insertions(+), 4 deletions(-) > > diff

Re: [Qemu-devel] [PATCH v2] slirp: fix packet requeue issue in batchq

2012-02-16 Thread Jan Kiszka
On 2012-02-16 09:45, Zhi Yong Wu wrote: > On Thu, Feb 16, 2012 at 4:37 PM, Jan Kiszka wrote: >> On 2012-02-16 09:07, zwu.ker...@gmail.com wrote: >>> From: Zhi Yong Wu >>> >> >> Please summarize in a bit more details what was broken. > Should those bits b

Re: [Qemu-devel] [PATCH 7/7] Implement cpu hot-add using device_add monitor command

2012-02-16 Thread Jan Kiszka
On 2012-02-16 00:35, Anthony Liguori wrote: > On 02/15/2012 05:16 PM, Igor Mammedov wrote: >> Adds ability to hot-add cpus if guest was started with options >> -smp X,maxcpus=Y >> where X< Y. >> For simplicity sake this implementation doesn't allow to add specific >> cpu but rather it adds th

Re: [Qemu-devel] [PATCH 1/7] Introduce a new bus "ICC" to connect APIC

2012-02-16 Thread Jan Kiszka
On 2012-02-16 00:16, Igor Mammedov wrote: > Introduce a new structure CPUS as the controller of ICC (INTERRUPT > CONTROLLER COMMUNICATIONS), and new bus "ICC" to hold APIC,instead > of sysbus. So we can support APIC hot-plug feature. > > This is repost of original patch for qemu-kvm rebased on cur

Re: [Qemu-devel] [PATCH 2/7] Convert pc cpu to qdev

2012-02-16 Thread Jan Kiszka
On 2012-02-16 00:16, Igor Mammedov wrote: > Convert pc cpu to qdev device that is attached to icc bus, later > hot-plug ability of icc bus will allow to implement cpu hot-plug. > > Signed-off-by: Igor Mammedov > --- > hw/pc.c | 62 +++--

Re: [Qemu-devel] [PATCH 4/7] cleanup: remove redundant pc_cpu_reset

2012-02-16 Thread Jan Kiszka
On 2012-02-16 00:16, Igor Mammedov wrote: > All cpus except of boot cpu should be halted after reset. > So remove redundant pc_cpu_reset and use cpu_reset instead. > > Signed-off-by: Igor Mammedov > --- > hw/pc.c | 11 ++- > target-i386/helper.c |1 + > 2 files changed

Re: [Qemu-devel] [PATCH 5/7] Set default 'model' property if it wasn't specified yet.

2012-02-16 Thread Jan Kiszka
On 2012-02-16 00:16, Igor Mammedov wrote: > If cpu model wasn't specified at startup or hot-plug set it to default > value for the target. > > Signed-off-by: Igor Mammedov > --- > hw/pc.c |8 > 1 files changed, 8 insertions(+), 0 deletions(-) > > diff --git a/hw/pc.c b/hw/pc.c > in

Re: [Qemu-devel] [PATCH 6/7] Prepare ACPI infrastructure for cpu hot-plug in acpi_piix4

2012-02-16 Thread Jan Kiszka
On 2012-02-16 00:16, Igor Mammedov wrote: > It's backport of acpi related cpu-hotplug code from qemu-kvm. > Provides means to communicate cpu hot-plug events to guest OS > and that works with current seabios. > > Signed-off-by: Igor Mammedov > --- > hw/acpi_piix4.c | 65 +++

Re: [Qemu-devel] [PATCH 2/7] Convert pc cpu to qdev

2012-02-16 Thread Jan Kiszka
On 2012-02-16 00:16, Igor Mammedov wrote: > +static ICCBusDeviceInfo cpu_device_info = { > +.qdev.name = "cpu-pc", > +.qdev.size = sizeof(CPUPC), > +.qdev.reset = cpu_device_reset, > +.init = cpu_device_init, > +.qdev.props = (Property[]) { > +DEFINE_PROP_STRING("model",

Re: [Qemu-devel] [PATCH 1/7] Introduce a new bus "ICC" to connect APIC

2012-02-16 Thread Jan Kiszka
On 2012-02-16 13:42, Anthony Liguori wrote: > On 02/16/2012 05:25 AM, Jan Kiszka wrote: >> On 2012-02-16 00:16, Igor Mammedov wrote: >>> Introduce a new structure CPUS as the controller of ICC (INTERRUPT >>> CONTROLLER COMMUNICATIONS), and new bus "ICC" to h

Re: [Qemu-devel] [PATCH 2/7] Convert pc cpu to qdev

2012-02-16 Thread Jan Kiszka
On 2012-02-16 13:51, Anthony Liguori wrote: > On 02/16/2012 06:01 AM, Jan Kiszka wrote: >> On 2012-02-16 00:16, Igor Mammedov wrote: >>> +static ICCBusDeviceInfo cpu_device_info = { >>> +.qdev.name = "cpu-pc", >>> +.qdev.size = sizeof(C

Re: [Qemu-devel] [PATCH uq/master] Synchronize cpu state with kernel before poking into registers.

2012-02-16 Thread Jan Kiszka
env->cr[0] & CR0_PE_MASK) || > ((env->segs[R_CS].selector & 3) != 3); > } Reviewed-by: Jan Kiszka -- Siemens AG, Corporate Technology, CT T DE IT 1 Corporate Competence Center Embedded Linux

Re: [Qemu-devel] [PATCH 1/7] Introduce a new bus "ICC" to connect APIC

2012-02-16 Thread Jan Kiszka
On 2012-02-16 13:59, Anthony Liguori wrote: > On 02/16/2012 06:50 AM, Jan Kiszka wrote: >> On 2012-02-16 13:42, Anthony Liguori wrote: >>> On 02/16/2012 05:25 AM, Jan Kiszka wrote: >>>> On 2012-02-16 00:16, Igor Mammedov wrote: >>>>> Introduce

Re: [Qemu-devel] [PATCH v3 4/9] target-i386: Add infrastructure for reporting TPR MMIO accesses

2012-02-16 Thread Jan Kiszka
On 2012-02-16 16:21, Avi Kivity wrote: > On 02/14/2012 05:13 PM, Jan Kiszka wrote: >> Note that KVM without in-kernel irqchip will report the address after >> the instruction that triggered a write access. In contrast, read >> accesses will return the precise information.

Re: [Qemu-devel] Minor regression with kvm ioapic, gsi >= 16

2012-02-16 Thread Jan Kiszka
g unused path with our current chipset. When this may change, I'm sure we will also have better IRQ injection mechanisms by that time. Find a patch below. > > Introduced by > > commit c3388c9bd8d4f4fd841b521feed20993185d9be4 > Author: Jan Kiszka > Date: Mon Feb 6 12:20:5

Re: [Qemu-devel] [RFC][PATCH 09/16 v6] introduce a new monitor command 'dump' to dump guest's memory

2012-02-17 Thread Jan Kiszka
On 2012-02-17 09:52, Wen Congyang wrote: >>> +static DumpState *dump_init(int fd, Error **errp) >>> +{ >>> +CPUState *env; >>> +DumpState *s = dump_get_current(); >>> +int ret; >>> + >>> +vm_stop(RUN_STATE_PAUSED); >> >> I would save the current vm state first and restore it when fi

Re: [Qemu-devel] [RFC][PATCH 09/16 v6] introduce a new monitor command 'dump' to dump guest's memory

2012-02-17 Thread Jan Kiszka
On 2012-02-17 10:35, Wen Congyang wrote: > At 02/17/2012 05:26 PM, Jan Kiszka Wrote: >> On 2012-02-17 09:52, Wen Congyang wrote: >>>>> +static DumpState *dump_init(int fd, Error **errp) >>>>> +{ >>>>> +CPUState *env; >>&g

Re: [Qemu-devel] [PATCH] kvmclock: Always register type

2012-02-17 Thread Jan Kiszka
classes are lazy-initialized anyway and kvmclock_create() > has another kvm_enabled() check, simply drop the KVM check in > kvmclock_register_types(). > > kvm-i8259, kvm-apic and kvm-ioapic do not suffer from such a check. > > Signed-off-by: Andreas Färber > Cc: Jan Kiszka >

[Qemu-devel] [PATCH v5 6/7] pcspk: Convert to qdev

2012-02-17 Thread Jan Kiszka
Convert the PC speaker device to a qdev ISA model. Move the public interface to a dedicated header file at this chance. CC: Paolo Bonzini Signed-off-by: Jan Kiszka --- Trivial rebase over git head. Would be great if this series could be merged now quickly. arch_init.c|1 + hw/i82378

Re: [Qemu-devel] [PATCH] slirp: kill ugly macros

2012-02-17 Thread Jan Kiszka
On 2012-02-16 12:06, Kevin Wolf wrote: > Am 15.02.2012 19:55, schrieb Jan Kiszka: >> On 2012-02-15 19:45, Michael S. Tsirkin wrote: >>> Remove ugly macros for field names, >>> change done by the following script: >>> >>> s#\bifq_prev\b#m_prev#g; &g

Re: [Qemu-devel] [PATCH 1/2] slirp: remove duplicate definition

2012-02-17 Thread Jan Kiszka
On 2012-02-15 09:30, Jan Kiszka wrote: > On 2012-02-15 09:12, zwu.ker...@gmail.com wrote: >> From: Zhi Yong Wu >> >> Signed-off-by: Zhi Yong Wu >> --- >> slirp/if.c |2 -- >> 1 files changed, 0 insertions(+), 2 deletions(-) >> >> di

[Qemu-devel] [PATCH 1/3] slirp: Clean up ifs_init

2012-02-17 Thread Jan Kiszka
Remove duplicate ifs_init macros, reimplement the logic as static inline in mbuf.h. CC: Zhi Yong Wu CC: Michael S. Tsirkin Signed-off-by: Jan Kiszka --- slirp/if.c |2 -- slirp/if.h |2 -- slirp/mbuf.h |5 + 3 files changed, 5 insertions(+), 4 deletions(-) diff --git a

[Qemu-devel] [PATCH 0/3] slirp: Fix for requeuing crash, cleanups

2012-02-17 Thread Jan Kiszka
This is an alternative, more complete approach to fix the requeuing- related crashes reported recently. See patch 2 for details. The rest are simple cleanups. Please check carefully if I messed something up. CC: Fabien Chouteau CC: Michael S. Tsirkin CC: Zhi Yong Wu Jan Kiszka (3): slirp

[Qemu-devel] [PATCH 3/3] slirp: Refactor if_start

2012-02-17 Thread Jan Kiszka
Replace gotos with a while loop, fix coding style. CC: Zhi Yong Wu CC: Fabien Chouteau Signed-off-by: Jan Kiszka --- slirp/if.c | 78 +++ 1 files changed, 36 insertions(+), 42 deletions(-) diff --git a/slirp/if.c b/slirp/if.c index

[Qemu-devel] [PATCH 2/3] slirp: Fix requeuing of batchq packets in if_start

2012-02-17 Thread Jan Kiszka
fixes crashes due to inconsistent queues and simplifies the logic. Thanks to Zhi Yong Wu who found the reason for these crashes. CC: Zhi Yong Wu CC: Fabien Chouteau Signed-off-by: Jan Kiszka --- slirp/if.c | 35 +++ 1 files changed, 19 insertions(+), 16 deletions

Re: [Qemu-devel] [PATCH v1 1/1] exec: Fix watchpoint implementation

2012-02-17 Thread Jan Kiszka
On 2012-02-17 17:23, Meador Inge wrote: > Fix a bug introduced by commit 1ec9b909ff207a44d5ef2609cb4a2e3d449d485f > where 'watch_mem_write' was modified to fall-through to 'abort' on > every input. > > Signed-off-by: Meador Inge > --- > exec.c |6 +++--- > 1 files changed, 3 insertions(+), 3

Re: [Qemu-devel] [PATCH v1 1/1] exec: Fix watchpoint implementation

2012-02-17 Thread Jan Kiszka
On 2012-02-17 17:36, Meador Inge wrote: > On 02/17/2012 10:28 AM, Jan Kiszka wrote: > >> On 2012-02-17 17:23, Meador Inge wrote: >>> Fix a bug introduced by commit 1ec9b909ff207a44d5ef2609cb4a2e3d449d485f >>> where 'watch_mem_write' was modified to fa

Re: [Qemu-devel] [RFC][PATCH 09/16 v6] introduce a new monitor command 'dump' to dump guest's memory

2012-02-17 Thread Jan Kiszka
On 2012-02-17 17:32, Eric Blake wrote: > There are other APIs where qemu has ended up pausing the domain and not > restoring things back to running when done, and where libvirt has had to > track existing state prior to starting actions in order to manually fix > things after the fact (see libvirt'

[Qemu-devel] [PATCH v4 03/10] Process pending work while waiting for initial kick-off in TCG mode

2012-02-17 Thread Jan Kiszka
When the TCG thread is started but not yet the machine, we wait in qemu_tcg_cpu_thread_fn on tcg_halt_cond. To allow run_on_cpu already at this time, we need to process pending request in that loop. CC: Paolo Bonzini Signed-off-by: Jan Kiszka --- cpus.c |5 + 1 files changed, 5

[Qemu-devel] [PATCH v4 09/10] optionsrom: Reserve space for checksum

2012-02-17 Thread Jan Kiszka
Always add a byte before the final 512-bytes alignment to reserve the space for the ROM checksum. Signed-off-by: Jan Kiszka --- pc-bios/optionrom/optionrom.h |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/pc-bios/optionrom/optionrom.h b/pc-bios/optionrom/optionrom.h

[Qemu-devel] [PATCH v4 08/10] kvmvapic: Simplify mp/up_set_tpr

2012-02-17 Thread Jan Kiszka
The CH registers is only written, never read. So we can remove these operations and, in case of up_set_tpr, also the ECX push/pop. Signed-off-by: Jan Kiszka --- pc-bios/optionrom/kvmvapic.S |6 +- 1 files changed, 1 insertions(+), 5 deletions(-) diff --git a/pc-bios/optionrom

[Qemu-devel] [PATCH v4 01/10] kvm: Set cpu_single_env only once

2012-02-17 Thread Jan Kiszka
As we have thread-local cpu_single_env now and KVM uses exactly one thread per VCPU, we can drop the cpu_single_env updates from the loop and initialize this variable only once during setup. Signed-off-by: Jan Kiszka --- cpus.c|1 + kvm-all.c |5 - 2 files changed, 1 insertions

[Qemu-devel] [PATCH v4 04/10] Allow to use pause_all_vcpus from VCPU context

2012-02-17 Thread Jan Kiszka
to wait for the whole gang. CC: Paolo Bonzini Signed-off-by: Jan Kiszka --- cpus.c | 12 1 files changed, 12 insertions(+), 0 deletions(-) diff --git a/cpus.c b/cpus.c index 4a10775..17b055f 100644 --- a/cpus.c +++ b/cpus.c @@ -875,6 +875,18 @@ void pause_all_vcpus(void

[Qemu-devel] [PATCH v4 05/10] target-i386: Add infrastructure for reporting TPR MMIO accesses

2012-02-17 Thread Jan Kiszka
allows us to restart, so we postpone the delivery of events recording in the user space APIC until the current instruction is completed. Note that KVM without in-kernel irqchip will report the address after the instruction that triggered the access. Signed-off-by: Jan Kiszka --- cpu-all.h

[Qemu-devel] [PATCH v4 00/10] uq/master: TPR access optimization for Windows guests

2012-02-17 Thread Jan Kiszka
printf The series is also available at git://git.kiszka.org/qemu-kvm.git queues/kvm-tpr Please review/apply. CC: Paolo Bonzini Jan Kiszka (10): kvm: Set cpu_single_env only once Remove useless casts from cpu iterators Process pending work while waiting for initial kick-off in TCG

<    1   2   3   4   5   6   7   8   9   10   >